From patchwork Tue Jan 25 14:33:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Weiguo Li X-Patchwork-Id: 106525 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5E2BA00C3; Tue, 25 Jan 2022 15:33:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 587A9429ED; Tue, 25 Jan 2022 15:33:34 +0100 (CET) Received: from out162-62-57-49.mail.qq.com (out162-62-57-49.mail.qq.com [162.62.57.49]) by mails.dpdk.org (Postfix) with ESMTP id A6247426E4 for ; Tue, 25 Jan 2022 15:33:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1643121209; bh=QObiXbWV8Z0Fp5g9hTWm/HL/NlAiKiyqXWP3VrmLM3c=; h=From:To:Cc:Subject:Date; b=UJ8SUKURVDpzGxB995rc06R5oLHQuNnPmm9KwwtUxOQCfKswU9gIK9EJdAMmoEo5/ SioYYNSmcvzDI8UNxtnKx+YK/AchMU2Za8Ab0PJqotu1rzlgezJHhomUpdbRi349DT Fshm4DII1HKex/ya/+rSrA3c+lhnMuzT/CZxK3cw= Received: from localhost.localdomain ([111.193.130.237]) by newxmesmtplogicsvrsza8.qq.com (NewEsmtp) with SMTP id 8500F4C2; Tue, 25 Jan 2022 22:33:16 +0800 X-QQ-mid: xmsmtpt1643121196tk2yfjj57 Message-ID: X-QQ-XMAILINFO: OGCswexgy68RPPPHEzMOWV4X6PNKs7zqjVBuH+8h7vZGISBUd8+3E9Gmt0c8kw u/EtUk2s9tcj+3t5mXwlmgHvUIqJKNtdbRYvsQla+CDwHbqgfiCO0tl2iNvSVtmYqRNYN60pEupQ jU08I/0O5m+zp9DONXGGUiEk2Oa5oTotN/SCKocBmYY4bA6WSJ1pd+3Ar83IdwPcSeNcWDSD0+7x Z8XoQ/nhPOlg8ER5U80O5pPU7fjNj12sydJ8NQkQC91hln5LjBsqYzaGD8WSbo8kEvx4tf3ToxlA qR4CGJdHxeXy4qAjzFBqbbReaaQ2SFnOgtKESL8Qyloz0a9MbASKIxaYSmbSXVolR6SE816vCZHB MCs6A0/zmwYShWTKnJ3Ow4hsfdlZ4PMsTOn12ldltZZUtf/meor3Q1PGJFkpBMfyauXFKrIfI+Xt n56ClAEyvuHpDtrpXcRPYBkIMRTYPMU0vAHVjv2x6GcYoIY8qawf9H/TFtSjDjJY1UwUD6Nuut38 szEn/1MoLAsKgbJoovDQYEZgd9lKkVzk22QiXi9+2cOC9QJ790eY2OO1YnPHGcK8/5XzZE5XE5wj MfgYmCMxtDHN/uCLvGTOqgb9cw23OgCQnhrfCt9Rgpm0Xj95MwXR8hhFs7ld+EDEAMntx5dur4C7 c+3HK5cyK8nnwY1THYGDL9pY7AHGvPBSOuLtGOHwFok0VFhrBfVtodh5RtUczhxwzMv5f1ejrKX7 zAptv7fzmhzCimEn/M//fmOcpQynuBy9RvA/iLn8JUKsdU7XszqKETWHglWum29/Y4BcuHnvwEJ/ nEzkGjnTeUI7iB6h0mpVs0Pp48zTXoTDz9q6NBSrZHulr2FFacxM7YWlYiBK1vnFfC52Ix1OR4LX XmqjNFWPOvdZyu1V3B6jCOfL8kpnKb4A== From: Weiguo Li To: ashish.gupta@marvell.com Cc: dev@dpdk.org Subject: [PATCH] compress/octeontx: fix null pointer dereference Date: Tue, 25 Jan 2022 22:33:15 +0800 X-OQ-MSGID: <20220125143315.32540-1-liwg06@foxmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Check for memory allocation failure is added to avoid null pointer dereference. Signed-off-by: Weiguo Li Acked-by: Akhil Goyal --- drivers/compress/octeontx/otx_zip_pmd.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/compress/octeontx/otx_zip_pmd.c b/drivers/compress/octeontx/otx_zip_pmd.c index dd62285b86..1b6178f661 100644 --- a/drivers/compress/octeontx/otx_zip_pmd.c +++ b/drivers/compress/octeontx/otx_zip_pmd.c @@ -392,6 +392,8 @@ zip_pmd_qp_setup(struct rte_compressdev *dev, uint16_t qp_id, } name = rte_malloc(NULL, RTE_COMPRESSDEV_NAME_MAX_LEN, 0); + if (name == NULL) + return (-ENOMEM); snprintf(name, RTE_COMPRESSDEV_NAME_MAX_LEN, "zip_pmd_%u_qp_%u", dev->data->dev_id, qp_id); @@ -399,8 +401,10 @@ zip_pmd_qp_setup(struct rte_compressdev *dev, uint16_t qp_id, /* Allocate the queue pair data structure. */ qp = rte_zmalloc_socket(name, sizeof(*qp), RTE_CACHE_LINE_SIZE, socket_id); - if (qp == NULL) + if (qp == NULL) { + rte_free(name); return (-ENOMEM); + } qp->name = name;