From patchwork Sat Jun 23 21:20:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 41427 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D65981BB42; Sat, 23 Jun 2018 23:20:49 +0200 (CEST) Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700081.outbound.protection.outlook.com [40.107.70.81]) by dpdk.org (Postfix) with ESMTP id 52B2B1BB3E; Sat, 23 Jun 2018 23:20:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hQsWb/82ISFPvodOfaQds1YC81UijClEcfK5nkImbn4=; b=XIs7aBw+kaEAqOSA73nGeujm+qEwTci6oZ7k84qXnzNI6/SKRz7MsK2xNQjX3MXtKuuirdVe1PP6zRLYCvUhH280/ST9MOGGrNVDsSphGup+jVXEQV7lyGV5Gf6X62oTD1rnGscZTXLUWQaNIfm5Fzf8I8Lxlocc8eme4YnYXmY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by BL0PR07MB4017.namprd07.prod.outlook.com (2603:10b6:207:4b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.21; Sat, 23 Jun 2018 21:20:44 +0000 From: Rasesh Mody To: dev@dpdk.org Cc: Shahed Shaikh , ferruh.yigit@intel.com, Dept-EngDPDKDev@cavium.com, stable@dpdk.org Date: Sat, 23 Jun 2018 14:20:31 -0700 Message-Id: <1529788834-18717-1-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 MIME-Version: 1.0 X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: BYAPR04CA0012.namprd04.prod.outlook.com (2603:10b6:a03:40::25) To BL0PR07MB4017.namprd07.prod.outlook.com (2603:10b6:207:4b::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d3bfbae4-2b2f-40f2-fed9-08d5d94f2ec1 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:BL0PR07MB4017; X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 3:IGDaY7ESzpMuxJXfov4hnbyUioVu0C1BneT/163xKNVqTqoEKZL1QHyu3EhTBqFJrUVWmAUHy7VoRgQjY4mcf46I5kpgYL7QzjVW8FEfxueA0VQ61q4wB7UGWIb8GoE25RKqbpaH7LamHAeezlkqx6smHGjwCvs1WC8i+FdkVUdN1x0SU0jMCrwbhTYGqJBo+bpGIkxS2QdpVwhBltwNBuvw3VpuztHbW15FVrLeJX96lx1X6MgSK0F6MilY7/IK; 25:B4hfK463JZdh6p7l0rJr/M5klqc6w+1r5D9Ps0hmfZa9WkVzrXEoTRMle5hwz6bfSeo0corTOOCvTKSXvPCjZo2WYa+kTmhMyoAEMgmi4rF2opIzIvN/A6yqNHH5w4KY7GVO0kJHasDUzYeI8Zy4oYPvplUDv+HpLcRh2Op1mCaSnwkTQl8+FgI/OOko+3PSQW+UISUnBw9ocypBhLDqggtsNn6pkQ/oeQOZ/csBc65hkb1qSyzjGd8Z6pvj0nym+q1sMueBMeJuHU+YkJ1tn/5scDaejVUHFxCLpwa4qdcj5AToU5EZuZuFZvnmusav7DTGck79w8Rc9zSkL+MxTA==; 31:cevopkxk4uG9YYmhDMPrCz1f1WkAg8U0DeyzyTHLrYY9OdVe5NCP4J+Bx1/9S7GvknNqtxnuaS7zfwdb8gbSIFBQ7QWo+LsmTaNUHVPz1JqcWcj6uSMwYzUiCSFKRdqad+eX6I9jMqx/jcU29dsgSefOWubTBiSlSGpZXfpiZBAar3N4mr/YClmePXIcfpIsrXSZ+/ZdzrR2YUJMIeZqVxS5WidRSK7ZZrM6SeIgT/4= X-MS-TrafficTypeDiagnostic: BL0PR07MB4017: X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 20:MMxF1ObX4J0pnNWa8ADWLNH/UDvsStOcCxtSG8EBZqlg/NfMrqwJgz0MUYh2EAqzdeohp7c3nFGwZX1mJKs92KQ8PLjhYOpzdDZiObBdiRCPk15Rw7pJ5YEfsitPxAbt9NfWIqlhPkKJKydfkskZjq6qoAG14FBpheXLwvfOaMhE5lYiicehAJeEhIiohrV7NFjahoNXbK49ANkwNYRLSdvHbAwNuEiYl+TRoZqgDX4mhrwKailVz9Hs1FnN0LldC1ZRv6Ndk2YKQ6HWLjE/mI/qoxU/Pr3jRQSCSr1xN9pbO1xb9YFKaxEgdb6KgH8ZexmpL2Apsio//oiF2z20FgxDRXiETqQDrji+HIMpPt/MHsvS93Q4jlJjxJhfhV54XPb8ohIRhH/Qpm8ueMABXJYfktVO0CtNwuNpP8XLG6H/raxZqSaGjqdsa17FMumphrV3YKayo2Od2FapcvXjxcev9mpOo34oXzmYxsUD10MxAc0da3oDs3jrCDRcFem2; 4:S5RNhQf2mmjK7Bigto3MfD79EbUJVjxacxVLLDnLGPa/K5qaXNKrFTWvnKxPr+UwmECDDn9SIidbprt7fOIemZmO0K1OxpoBoN3fVdVkOqpUatC10vR+WZWahSmKrAOQNuP5GTzb+z8BQGSTNmkj35HXUB81YCmbQihYT3TrFa4LdWrZRYrKCStSyO36yOnlWMJVCif1VgqPrsrtZbQxM7coYMhGAVb8W0Q4aQtztBDeiPwWzpOHFvNNKFVDKTq5zz6x9dydFr1dGwr620uJEg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:BL0PR07MB4017; BCL:0; PCL:0; RULEID:; SRVR:BL0PR07MB4017; X-Forefront-PRVS: 07126E493C X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(366004)(396003)(346002)(39850400004)(376002)(39380400002)(189003)(199004)(16586007)(97736004)(2351001)(72206003)(21086003)(316002)(105586002)(2906002)(50466002)(25786009)(48376002)(478600001)(81166006)(86362001)(3846002)(81156014)(6116002)(2361001)(106356001)(8936002)(8676002)(7736002)(55016002)(305945005)(36756003)(26005)(66066001)(44832011)(186003)(50226002)(486006)(69596002)(59450400001)(386003)(53936002)(16526019)(956004)(2616005)(4720700003)(476003)(68736007)(6666003)(6916009)(5660300001)(51416003)(4326008)(7696005)(47776003)(52116002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR07MB4017; H:cavium.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL0PR07MB4017; 23:smh5Ig5NN+6B5cKxdSf3UzPncs1VN1TBp5MUh+wm+?= s+xMaRY46BfMLqBnRxRKikl8v8wOCnpCCZw7U2ap45M2dh1ntA2L3iCDsBPkRIh/g+MBOvaP0vdwqq3oI5nK7Ba450ij1pLZZIs7HlJsdMIqVJwwkL8uxBDXJd2ev720UOlhfpNqne7EgyeO6IoxBq3lHNNJgw2b/SsmemveVInvcNB0J7KZ068JerSttenh3g0Tn9yTV7NNIIEjw8cREgAw6QiHFl5rbCufPhk4fGlHzlCrIfP4RkWl5J2IaAddcbzs+Rj8ok0AoHmLNnohD+LjN0zYj7n0fHecaBGPOWZbhCmK18IQMem8xGRtu7aT43HNOAobFfk9yVbLUw/I3TkZpWTVnLC3GM7IpU55Dhhgzpc9Zm5xX5nrGQOm8kIiu5eO4hV9HKg0XNU+ZgkA7WDh/GFBzfZ4KnBSgt3sxSG/0cszASmeFzua9mQKnCosfTX9AeUb5RCGVb3Wcn/XyRN2dHY7TEwog0iG18JD2eOL8Zh+9vLM8S+cyIpK/Kfv1xdkvWa62YXcB3zuTH+MH+Jr780iOiizDqugwIzBB8Db5TtoTyz20rp0TdywWypc8yS2of///N795cIjAVN91ctOeYkfwGpnHqrf4qTWJJIT+Q6jVYY+YPqCxm6nN+Y/XjIX+hJoYmO//iUev9gRFLg0sgPTpwFBxJ+1hG3JGB78p1XCOAq8xa92pe0DvVxyX9gwtZmMn1impxPWamd+HUs3SfE4t2tYQFD7s/ftR+dqhm+cQVarverkp7zShZEgeTaeGBIbGVSRx/yiXVyLfbMTZZcsIKT3+UIm/EFK7NUZMPaxhE0UOax67ZIuj51ud/KgR9ws9m9wzDeTaxUjmusL7oRqLD02On6WJOeEs3F3V8spLdsZ4nWE5WhiGxPuezgsuR5CZaVAwwaLv7CZgoLZAZlEDoQXnv/IPqnQ3hnwuoEnJnLRgc80E+v8g68xy0IPmpIVJnCFrwfTg9rNlfaTOOUiemtl/CbP3f9uClQB6cU3gfCDfOMQnAACS523ReJPjblkB5hoz6AkduzJfu1Gw1nd3yD4N8Q37tJInOsSQjNmOocpIPVs+Fzi+TN6RlYseakBvdZlGcvdHUgf5L2D1IKTaHwn0LApE7xlB00NPNI8GYBc93T9IRhwRD4OTy+7boG8YL0qTzlO6EU4orlJ3V7kf+K+1HuX+GPOXCq9786qkXYmuR8unDOppl8sLAxxIUTsTrjLhFOpqSS36Ky4uBo+BAED8Ifz9ihvNfE+1Jkna8k3VD2UJFMIUwMkTp2F8PRplKDus5Yqxy82zcxp7gRHBX2PKG414xyGe44olmDCEj/4XqYh8nccrAH/iY= X-Microsoft-Antispam-Message-Info: wnrSddvQqjSJTuE1Sr9npTK2yf8KaNMzcAzQm5W4LbDHc1vei56e3bVO5FWogeehoqE3c858XTtaAo5KgXPNAG1UIq8ckmOB/PTlYEVpleghN7lXJdutLvRhM2cLpy1waXSs/drag//Oc1Qwu3/Mu/Qc5l7OWTRUW3arv9GVy1BmWl7TEGOPEmDnTwTU8zd7dnoEAp1aR92RwQk+yO3zJtVQkC4q63DE+w/ob0aeVxwDzxq0QCJEzJHn9nzxeeoWiJ1yoLAOfMH/+1E/cbynrYfZTWbhArmoxyF90JHaOGtQt89MrQbv6K1xPCh8l2ig++25Spg5PCwktl4/XGLsuA0i70YID5jrki1eXGcfpcg= X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 6:EhlvRwd4lraUHBjF4DjaH6pOwTEDhyDLn3Uic1J+Vk4Hf/fEKvjJOJPnw245FyALObXl8D+riAc5a9v0DA+2Q2duMEMBYnoBNjB29YFZIx9i6TUBhmQpqcmq2cKUnJc6rgnfaEnvVDY0Ps0bZJ7WMFfUV/EGk1AtDhOl70HLVMvKua+REwS8WyTi7DHJXcVqGGBkxv5axYGnPyWoyqy4wqbtHosugz3Ef9VWV9A+Kv7rmd2JU0VudJMS+P9dtx0zVFpjNox+kNLFLYXNy8egxNoTdAP/OTBTvGT9zsGWtcEDCsYat66+zwvtEaGWMLj2C8FdYrOnF01hH045azcLeMf0x4cci1ysM1PIRyR8tATAJUwAX+k+m6pdWtbzLXjcqss3DOGxRuSvIJgd7tVM8P+r7uyq+s/80eYErjNDD9IsMs1/st6yGSiLVpbZ125LJjmqbs1UKvXxFKhhJcgphg==; 5:syd6x0ubiXBhitLmFVK/l7fxSxsp/UgNqEWigRRJkHpLc3VCxJduS6NEEnbOVFPot9LXgq7l7+2Bddq5/oAVpUakXtEOi7lbeZQAD6NpfZ6jp2QyhY61yRwxhuHEX0I8y058X35XLPPaUB7ANUdl23Q9eg5QCDenxYG4RS9ITQw=; 24:v82cl5hxwCTgSBDSm5ehbYFRMTXyeNLhQjWR+az+L+Zda1M/VxlQ/sPwHs+zfren/TFN57sjclf/5I2s2FrVpYmxLoXZAYNLje7nB2zV5Ks= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 7:Se5AgDoeSe0FztcdVxZ2u1M4AOlNZ6IdISGFVSO3LyNOyHsZilTHEvJ+ciM/CLC64juoC1qCW4xtGtxwyyirqjacPzc7ABtzLNwTHj+Soy/va2q2RsOmffg3vANGlpbD4TfipZBmqknQBVJxCDw9BQBXP82Ih4xFZpn/zdQBwJv0cPum3cR1cDUM4EJFuQ4Vx+lQlPDKJMvIqc03jYwRLUOOLYtSrpeP6ZI8Rxs0oji8PHHNpzQYEoLxBrPDBloi X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2018 21:20:44.6651 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d3bfbae4-2b2f-40f2-fed9-08d5d94f2ec1 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR07MB4017 Subject: [dpdk-dev] [PATCH 1/3] net/qede: fix unicast MAC address handling in VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Shahed Shaikh We did not register unicast mac configuration handlers for VF causing failure in bonding of VFs. Also, mac_addr_set operation requires mac_remove followed by mad_add. Fixes: 86a2265e59d7 ("qede: add SRIOV support") Cc: stable@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethdev.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 7a63d05..1cae474 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -957,7 +957,11 @@ static int qede_del_mcast_filters(struct rte_eth_dev *eth_dev) struct ecore_filter_ucast ucast; int re; + if (!is_valid_assigned_ether_addr(mac_addr)) + return -EINVAL; + qede_set_ucast_cmn_params(&ucast); + ucast.opcode = ECORE_FILTER_ADD; ucast.type = ECORE_FILTER_MAC; ether_addr_copy(mac_addr, (struct ether_addr *)&ucast.mac); re = (int)qede_mac_int_ops(eth_dev, &ucast, 1); @@ -979,6 +983,9 @@ static int qede_del_mcast_filters(struct rte_eth_dev *eth_dev) return; } + if (!is_valid_assigned_ether_addr(ð_dev->data->mac_addrs[index])) + return; + qede_set_ucast_cmn_params(&ucast); ucast.opcode = ECORE_FILTER_REMOVE; ucast.type = ECORE_FILTER_MAC; @@ -1002,8 +1009,9 @@ static int qede_del_mcast_filters(struct rte_eth_dev *eth_dev) return -EPERM; } - qede_mac_addr_add(eth_dev, mac_addr, 0, 0); - return 0; + qede_mac_addr_remove(eth_dev, 0); + + return qede_mac_addr_add(eth_dev, mac_addr, 0, 0); } static void qede_config_accept_any_vlan(struct qede_dev *qdev, bool flg) @@ -3024,6 +3032,9 @@ int qede_dev_filter_ctrl(struct rte_eth_dev *eth_dev, .mtu_set = qede_set_mtu, .udp_tunnel_port_add = qede_udp_dst_port_add, .udp_tunnel_port_del = qede_udp_dst_port_del, + .mac_addr_add = qede_mac_addr_add, + .mac_addr_remove = qede_mac_addr_remove, + .mac_addr_set = qede_mac_addr_set, }; static void qede_update_pf_params(struct ecore_dev *edev) @@ -3188,7 +3199,7 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf) ECORE_LEADING_HWFN(edev), vf_mac, &is_mac_forced); - if (is_mac_exist && is_mac_forced) { + if (is_mac_exist) { DP_INFO(edev, "VF macaddr received from PF\n"); ether_addr_copy((struct ether_addr *)&vf_mac, ð_dev->data->mac_addrs[0]); From patchwork Sat Jun 23 21:20:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 41428 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0EAB61BB6F; Sat, 23 Jun 2018 23:20:57 +0200 (CEST) Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700076.outbound.protection.outlook.com [40.107.70.76]) by dpdk.org (Postfix) with ESMTP id 19B371BB4E; Sat, 23 Jun 2018 23:20:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xj6M1gJ3eKgQ8DS9HNGEBnW7EJA+VZ9ogTizdIh8u/w=; b=IG37+4sSxvTupb8VOV30hTM/xXZDONE2WG1XAfF9b6wSerJvql2UDIPOE4st9jLV8iRP+rYSF3Mfe8/suGoTYWmaRwqpdl+8Ei6s6tjZqZ5p9qTyQDuoQJ92XCQdl69KREfaUm//ms+gbqg9EA9geWkLHdIXS7gCBQPTH5+7cIA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by BL0PR07MB4017.namprd07.prod.outlook.com (2603:10b6:207:4b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.21; Sat, 23 Jun 2018 21:20:52 +0000 From: Rasesh Mody To: dev@dpdk.org Cc: Shahed Shaikh , ferruh.yigit@intel.com, david.marchand@6wind.com, Dept-EngDPDKDev@cavium.com, stable@dpdk.org Date: Sat, 23 Jun 2018 14:20:32 -0700 Message-Id: <1529788834-18717-2-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1529788834-18717-1-git-send-email-rasesh.mody@cavium.com> References: <1529788834-18717-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: BYAPR04CA0012.namprd04.prod.outlook.com (2603:10b6:a03:40::25) To BL0PR07MB4017.namprd07.prod.outlook.com (2603:10b6:207:4b::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 10541030-9998-4685-13df-08d5d94f33a8 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:BL0PR07MB4017; X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 3:dmvnUVKpOjzI+9fJQnMHMY7cs/2FJj0xEnVLZxJgEP8a1ICBINNPuH2U9TFsEqfVs5xf1f7ENJMkF6YEJmAHWrOn4dsRztemcQMbE64udDNKs5ianz/4cbqtgtFtBX1JF1DVnaCRh8w2saqRAw0WDT6bnz7WMpqjRIs1ucjsktJHex/mKWH8Z732Iu/BhPsqJ2D1KiGuSdswQEhay1PloLawHvRlJ61CrJXbXvm3tv4CdICQJUubp7GRJ9CZAQcp; 25:FGH2s3WsA/eyKZylfrbJDGYPnPbgopeByMAdJo6r2eeOTlD4giD6kmSZhYcF5qHxpyFRxMIFLCW+jCNrwll+NBu38bl39Lauiou5waIybKnOXCaKvzc3CL6x03bI726DK3vANTDZhujwMhnhn0P+DB4J+UQhcSRAtX4rUZElK5A1ASz1E1yZR5nOgUMlXjh5nradfC2V9olA342qEfMg8iyFlqAP8F9y41jH6b9+dUDnyJkkyM7lLR9CY+1B9IMSddFjgwSgXnnK1ojdqsIRoWiCqHhYKJjffqIREfKU3TRNNyEJfoY45CqYgbB1BVO4O0ktOUF40RtZ26ea3TBfdA==; 31:7WCoiNULz8NSIfO4wiUCOdcPmH1iN2byQC4biu+zhkhGqVrIfaysBs0nwOSezmnWwX3ciWZHB66w1t9Bn//KDmce8WxWUHz7N7KA3ZnxODlqQcRf2XdoqUTWkuR5Ou/mz1Etat5EHZC4ghVUpFi/ADnH4JOaZikj/sRrRydLrWvlu+pqqLW9u4LOD5pqEBD8+3lC3HNe1XbbvIA3SIMzhN5TpLPndiC7aQk/JU6ZCb0= X-MS-TrafficTypeDiagnostic: BL0PR07MB4017: X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 20:GmZIDpiFpwgg0xeLnW3JLqCA8qjm/4LQ0V8M7nOrE0JRp10g8adNrs774XjrnKWo47QJQmEjwgYwqaA7CP8pmEAlXKwaoktLE5f9IrFEOiNxsf9vyDCN9LwrrliqwDskb6ciVRnZALdzOk5Qr3qkvuGPM/9Q/FLK4Pa80BsVvQDuiLdpU4I86EFTREXu675QIvDG4rGzumTHvoWlYsYl8Cnln3P7Obs0wccXyeqJU/cpVdZrNycyMSjkCUY8QKs16aCboOK7lkxb0Sc3j90fmYgpQIe6XgToSKnwlu9A7ey1n98Ylj3K55rbKRTSUbscfuKrh7VZQ9ebSt5s9OG3H+c+AqviaorTrpBE1sf5ybkNZS3BeMcSEtAuxFSVMmeZxCQMRkfxdI+yQBoQU0EIgkABPBRtd5O5K48IhX/m2z1wqqrCWQU4aRpQ2XpAWEouvO1KIGgV/jIxmqI6u/sAJpHRo61traXTQ01+EKtzzN1bQ0+LEKY+UCfIJnvECLvZ; 4:6N50DeZikjgLWe1zRoDJ9jt7AMe5I+aQSitkT09XQgcvPHZGDLNN21+X1Lrf4Cno0ojMX34kDoAKLvNwbaRdkkS+RZmT8dMP8VejlEH5iOjkOHiOjlD3DFtU/Gp6QenmPOgLWiI/sCuskabUP+w4o1Y3fpl9ldH0tDGYIk8mX4FwV/RhCNFely06mCz8OctYqf/Dcc6z7aWw5UODkCY2iqG8Y6buJZDfZe+Xb3ecEHW3lRFyUsrMY5mpbrzuihK5THUIN/tEJD12lhRoMpw4+Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:BL0PR07MB4017; BCL:0; PCL:0; RULEID:; SRVR:BL0PR07MB4017; X-Forefront-PRVS: 07126E493C X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(396003)(346002)(39850400004)(376002)(39380400002)(189003)(199004)(16586007)(97736004)(2351001)(72206003)(21086003)(316002)(105586002)(2906002)(50466002)(25786009)(48376002)(478600001)(81166006)(86362001)(3846002)(81156014)(6116002)(2361001)(106356001)(8936002)(8676002)(7736002)(55016002)(305945005)(36756003)(26005)(66066001)(44832011)(186003)(50226002)(486006)(69596002)(59450400001)(386003)(53936002)(16526019)(956004)(2616005)(446003)(4720700003)(476003)(11346002)(68736007)(6666003)(6916009)(5660300001)(76176011)(51416003)(4326008)(7696005)(47776003)(52116002); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR07MB4017; H:cavium.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL0PR07MB4017; 23:maUG5bjl97ascF5TdwgqnbZzWZBOZQKeO57UINuPD?= KJTVvntkPiP5gc1dmMzEdilQkhgo9ELqmNWzRKcApXU75Poa2OlKjLIttfxDzZbb1517fmNzqTwxX8rEQ3TddcHcNOAjKT8YKd9d+FlE5lGu8k2hm5UPQCgzt4aTY23dx7pophvZW9/YyDH4Z1+0l6mf+j3H43mRE9HyeweqZtzNbURXPDb3lRX/tTEOZkYvTUfENyFyfPO5sBo5O6J1ywbUn1rpNBBjo9tnjdeUWjAY24Sm3tF+wmM7Ss0kx1fW/perB5F17eZf73OsoEva2dd83c34hd7U7r8vwwQIscZa08e9CzXCy2fCgVbCPvc+Kxsq1PpWH8z2LqX3cEXpVvybUgugR/+m1g2Lgbd/hsf5H3py/ybIaPLo7jypr6nquT4CNmkVXUmmynAxzHG9OFSqlEtI37e3LxqWFq/mIQziBjKFHxeVD1DKq/GnvbWRdd4VN/ATsaA7BvWfN/YCJzQgBrKtbzjcUDm6ttbxbUGaFtbATa7kNUrr6hG+d7kjWPTsQjU0LpQakbiuMbj3N7cCl3EcsWKDwFwXQa1jYf9JI4+RnkhcGCu7UrW/xPPNMJHWznGBNuLmyQZ+fv+c3BweLUxApksxWVXE+/y4+Wc6MHZr6jFuJ59PqPq6C0uVaUrbIjhJ6TN0fIQQtaypwsv2kvRhZrBi3J8sX1Gnr43VDdd/4UUVSOCDyT19g0sZaq6FXDygLX8Jf5ZQUD0jP5eH9T9XK/7RGsqf8Z3c5j/TpsRkEDmOVDuQnPkrhkyQydlQooBNGaOgXDqycTwsS21R+MDCdacDa3n3DtmPFL+pbQbAcD0TG1fmqFSXX/dK3YfbmOaDnY62iXTe0nVlb1sjTZu5M/WeGIPMmWAXbGJ7I6v+QiP4foV6UggoMsrQ0jm6bNIOeYH22vOf07SL6dEiVJuGupxv3Jjv8GKn1wshLwDRaHqvx8svoIAvpQ64uWVMdZ9RPJfAipd5YNToTXsD2xJDIGZCg88Fx2/Dgepa+gU+0Z31kPypoz4qwxCUyMqlTREK5psZhF3576XhUPG2TOPBFna8ksn1xaIC1a3fGhe36AZtLv8/IrvXHjmWCV2hP5QzgYagRVEec+30IfMAF+Y+MylzOdRinVOU/6w9Wh+7L35YQR8ppc7yIzU8PRGrzyU14KCb1kmFS6gws5G9ZVd7XKnm97gg15nWCXYHPJz1skM1yhxCpPkwlJHq0akGcmcXh5ejapEsgxMcJ85ESh8nG3do/c/vefd1LiJ1v1LhKbhbLNw+MQgXgWq13GsW9CCp4sGVvjadm7ojvRR X-Microsoft-Antispam-Message-Info: lYRVADW1qFCj4oetVPGgC+T9yzSEJQyhXZgJkKmW5Ua9Cnc9aCSUfy9zOzOAqVsFWa7cpecGyO6vMVzw3lfFXJ/HUHSXV98VjiBc6K1uNJ0AFlhtKUL4/R4AmnFf5CPGb3U0vtwPOZZb4ciEc9/C6bTJv9LAApdfIdYBNma9ndn9+bUIFCQBbdg90m617/Vihc90gFA3ZwjeXt6LltW46XYqjmVXvlyhJ6jVLxqMwCeM6yRCQWioXUTz8O8H19DEWvLxISdvNcX5u5Ulgt0VszUWcJzH6MY4L/A1yCjxLE0OvWbnlkydp8Q7pqAsef/l9JRBd5Dmnf8SbnxCBshZLR+8HxGmaoh7nY6k+FU9CLA= X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 6:DrjjKu1J+LHkt5cel7pBo97aAAVbkdH0Fg0ZE949o3NXZYOusaxbt/66UpCHv/Llo03XdNaMpIb5OGxI8zjlH5rxGOEJtmX6OZbMuOo3dM9BQFZFzvBOwx5ooTNOD3/UCnXD6tyVQ+BV56y5xYgFF3lBSUbKbvMZmRcLSa06V/IfuxLTbXX1Z8ZfpnHH7xtr+74N5uhQpvkpzwMcs9ywHo8KaDtshAbq+A7CpxnK4WmKb0nud0iVjkM+vMVuW4cXMiWW6aIsQb+EWEcZiJIDX8M3+SRNQUy5dK23MbWO7HH4MJ23TdXajLMLs++dRu2X9nr+PSmQBd7rrYzGmdkcT7rDGbJwGszahc6YwV/mH+InyNn2lDE+pPF3zsY/t/HmvuCLDwqNc7nE9W+S1Vi2WwsZDNU05eGQK7NVHttNiETmw+gb/vCee+aUS7g9KDBRSqFpMVyOaE4NLadIbWu4eA==; 5:lOe2b5AtSe/y/v0er2aADo5PSfS7hRbOQxR8Jd/sGkGcqdn/iS1t6bPxj+gqoTqsd+UAR6TgKKZVPgIoNXGF0fer/KjDtZ5yFrVthyCIg0AH1M74KyEeAfh3VmQvJQFqyXAVO07pi7jqFsEYQay33hQ7epLPMUVjNbLGSHGm8pQ=; 24:noTDd+4LNlx2FAyj8/oTuaOBrthiuUo0ftrQ3bTLzcac93Pxt9ZC7MEfl6xzNVi8hMTXrmog22kDxTTH3N4sIJL1XXc27AkISbmXIXc5wK0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 7:Phk2bY55Fnn/mtkxJv0fVjOQoFA7a+4nIii5Rlpya0F+nnGF3J95rePkRivFuM9+Usji5vI0RjeGp5ST1HmNkXiJ0tkM4XSkqXV+nboiLS3dVE4+NdMarjpyRiSOQSw4ecbnqskzufmKk7v/ppFZllfYUzazLWnNYLUJHVAYLwN3MOGrpD2y2+CwAFHYlcoDdyN940MRNMH8JjWiZvK8rS02weSnP9MacuAjJZUQVYgUS+Vh/YbMgFzPsNdkNdW1 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2018 21:20:52.8058 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 10541030-9998-4685-13df-08d5d94f33a8 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR07MB4017 Subject: [dpdk-dev] [PATCH 2/3] net/qede: fix legacy interrupt mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Shahed Shaikh qede pmd does not have support for legacy interrupt mode. This causes slow path completion failure with uio_pci_generic module, since it uses legacy interrupt (INTx) mode. Fix this issue by installing legacy interrupt handler. Fixes: ec94dbc57362 ("qede: add base driver") Cc: stable@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethdev.c | 40 +++++++++++++++++++++++++++++++++++++--- drivers/net/qede/qede_main.c | 2 +- 2 files changed, 38 insertions(+), 4 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 1cae474..8bbfa95 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -339,6 +339,24 @@ static void qede_interrupt_action(struct ecore_hwfn *p_hwfn) } static void +qede_interrupt_handler_intx(void *param) +{ + struct rte_eth_dev *eth_dev = (struct rte_eth_dev *)param; + struct qede_dev *qdev = eth_dev->data->dev_private; + struct ecore_dev *edev = &qdev->edev; + u64 status; + + /* Check if our device actually raised an interrupt */ + status = ecore_int_igu_read_sisr_reg(ECORE_LEADING_HWFN(edev)); + if (status & 0x1) { + qede_interrupt_action(ECORE_LEADING_HWFN(edev)); + + if (rte_intr_enable(eth_dev->intr_handle)) + DP_ERR(edev, "rte_intr_enable failed\n"); + } +} + +static void qede_interrupt_handler(void *param) { struct rte_eth_dev *eth_dev = (struct rte_eth_dev *)param; @@ -3063,6 +3081,7 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf) /* Fix up ecore debug level */ uint32_t dp_module = ~0 & ~ECORE_MSG_HW; uint8_t dp_level = ECORE_LEVEL_VERBOSE; + uint32_t int_mode; int rc; /* Extract key data structures */ @@ -3107,8 +3126,22 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf) return -ENODEV; } qede_update_pf_params(edev); - rte_intr_callback_register(&pci_dev->intr_handle, - qede_interrupt_handler, (void *)eth_dev); + + switch (pci_dev->intr_handle.type) { + case RTE_INTR_HANDLE_UIO_INTX: + case RTE_INTR_HANDLE_VFIO_LEGACY: + int_mode = ECORE_INT_MODE_INTA; + rte_intr_callback_register(&pci_dev->intr_handle, + qede_interrupt_handler_intx, + (void *)eth_dev); + break; + default: + int_mode = ECORE_INT_MODE_MSIX; + rte_intr_callback_register(&pci_dev->intr_handle, + qede_interrupt_handler, + (void *)eth_dev); + } + if (rte_intr_enable(&pci_dev->intr_handle)) { DP_ERR(edev, "rte_intr_enable() failed\n"); return -ENODEV; @@ -3116,7 +3149,8 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf) /* Start the Slowpath-process */ memset(¶ms, 0, sizeof(struct qed_slowpath_params)); - params.int_mode = ECORE_INT_MODE_MSIX; + + params.int_mode = int_mode; params.drv_major = QEDE_PMD_VERSION_MAJOR; params.drv_minor = QEDE_PMD_VERSION_MINOR; params.drv_rev = QEDE_PMD_VERSION_REVISION; diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c index de5a7ca..2885e5d 100644 --- a/drivers/net/qede/qede_main.c +++ b/drivers/net/qede/qede_main.c @@ -281,7 +281,7 @@ static int qed_slowpath_start(struct ecore_dev *edev, /* Start the slowpath */ memset(&hw_init_params, 0, sizeof(hw_init_params)); hw_init_params.b_hw_start = true; - hw_init_params.int_mode = ECORE_INT_MODE_MSIX; + hw_init_params.int_mode = params->int_mode; hw_init_params.allow_npar_tx_switch = true; hw_init_params.bin_fw_data = data; From patchwork Sat Jun 23 21:20:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 41429 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C00B51BB4F; Sat, 23 Jun 2018 23:21:02 +0200 (CEST) Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0044.outbound.protection.outlook.com [104.47.34.44]) by dpdk.org (Postfix) with ESMTP id 1F8161BB4E for ; Sat, 23 Jun 2018 23:21:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kb1FlmMiaDa3NB1tFJGVkiUkg9PxSUfi0nzOdmglVg4=; b=HIuwHZOLkJhvuL32b0wN8xMBUnfinBBnGlXaN/nAKPPehznALeFntqmecuE3sxhrbTTMZwnjf0P6QxQrUMmAGcqiD6XRWSWXzdlWZkDXNhSj65wd94+oPfPUcMxUjCo0eWk2NywklOu0nhyqh8kxfOxwbcxas4iJ1UM3id1f08I= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by BL0PR07MB4017.namprd07.prod.outlook.com (2603:10b6:207:4b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.21; Sat, 23 Jun 2018 21:20:58 +0000 From: Rasesh Mody To: dev@dpdk.org Cc: Rasesh Mody , ferruh.yigit@intel.com, Dept-EngDPDKDev@cavium.com Date: Sat, 23 Jun 2018 14:20:33 -0700 Message-Id: <1529788834-18717-3-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1529788834-18717-1-git-send-email-rasesh.mody@cavium.com> References: <1529788834-18717-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: BYAPR04CA0012.namprd04.prod.outlook.com (2603:10b6:a03:40::25) To BL0PR07MB4017.namprd07.prod.outlook.com (2603:10b6:207:4b::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b82dbbea-4030-44b3-2808-08d5d94f3726 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:BL0PR07MB4017; X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 3:OhJndrc7nf33ZvC1LoPVBisCpI38GXnj2xlCkv6YUt52q8u9H4iaGgQcbfsGLl2KYMd/UCtOPpWYYjxEUoJNvZt7AixHw/dOf5HZS/+6n4ISwIofTxakea6dn99h6biBhaC4wOZOp+bHoipabfgXYdidRnF4HebNb/+mg76t4e3ZpjQmKeN30varnDJh7TLJACoyCu14m1dUUpCNwJS/PYn7JaRWTqerKxnlP1WIEWVtLIWanpZPtVzV667MY+rW; 25:tXu+8+V3WXJX67YHhPKQYLS+UHdJS9HPximthOwbaGiMJqYLufys6Eebyd0zAUPncDJHd12SwHFH075tzMV5dQXtmmVDRxtgdJ+Nf/goNR9kisbCZ1CtbVSyuompq4mws//5QNR+8xzv9L/4FxFror2FnQ1Jz3p/zyjrKJAozENqAKB1a+TWFSc8yIKph8sa7GeU39g5K/3Ouz7GYeh4aqfbPy+6N7HpvPfLhZ2aFCiz6HNWtGl4HuyikGiB4INgZXoLVyjCB2nU1p/hGVZOC8yoWBgdngYeqDj4XkFTN60tXmO2oC59kmKfkWP/dzYUi1kD95aoSVB4vrjObpknng==; 31:gczWD6kemI7qAjslCDDp0ogC/DrEw2C0KuzA4FSSawK+OWyu6xpOpOWZlmU189NOs6pj26cXDjONFwsvFAJWFOWm4GWQAqrsgMojyLnvnrhNHealZ3dcT5dgXZklYAmEBLREFplX4ucdHH4ppFA/82b4fUNFNlEJRWg9q7PVBUj0aWolJ6IB65T60WIUVlvdIF/Na8GAhT6HgKjskml6IrGjYsae9C4hRwT+L1LzVLM= X-MS-TrafficTypeDiagnostic: BL0PR07MB4017: X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 20:YRI/zdJH2T1SidboGnMY5lCuCUteyX5OdW82Q0XhwuenVoOOeuykYOxZdKcHoQ79xwjju+lNIurj2wwN3zZpG9dij8iFs545sL3mJhuRJv9sUNJch/J6UObiHHm9ihZtDTzpKFJrvBmte0M0EtIhVZIxJ1ZWQZ0J4RSkAokjFYDVEJubCDUxlaXn+xo9b43dNr2dX8GKRO5zYjFnueeUqhhN0VhA58o0odhLRZrt/31qPONXTOU2VE0+UUK8v6U3QTNRAunfTUK6dsgxN0QwIREBnzhRCl/Zs3OCk7SFt7K9R3juaznjikOnHrUlrz3/Tc22eWfIdn3QZOVR8hNIeVhWh2ym9MUMDWgHOqsSbjXZbbYazRypNzJxr9zR1Nw0NGVrsUB49RzkwMHrBwoh/5ywKbTWM7qTpe+QOiuGOF1RmQdRut93yZciyT47nWKpt5oD+WpjoWkH/h4r8R2kOmC7VNaXuWP83OHn9pMQbAPsI39xfOwNxrUrMejOye1J; 4:JOyR85ZlXJlA+AD1Lxc4eXxcmG7Kq6hwu/tsc/g3357qAqxiplPL0WCGHTf3v2jqrelHLnXwOGxSrbe75hODbAdrWERm0Mi5EpGzUPODRF4AStiRuWC45Fjtk3+9DCxfI7hNLVm3m80j68UkvCNRIVNnRHfLmWVzIaFiSyv29EMd4oCLTyO/URuwwqS2zTtgip2fT4v/WpfLe8lCvi70fprMz7JP2zkyiYY7g3TzUUTUPUPv0M/6VX738pOmQRI/LoLzhiafLFlUaVuXcKZDDg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:BL0PR07MB4017; BCL:0; PCL:0; RULEID:; SRVR:BL0PR07MB4017; X-Forefront-PRVS: 07126E493C X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(396003)(346002)(39850400004)(376002)(39380400002)(189003)(199004)(16586007)(97736004)(2351001)(72206003)(21086003)(316002)(105586002)(2906002)(50466002)(25786009)(48376002)(478600001)(81166006)(86362001)(3846002)(81156014)(6116002)(2361001)(106356001)(8936002)(8676002)(7736002)(55016002)(305945005)(36756003)(26005)(66066001)(44832011)(186003)(50226002)(486006)(69596002)(59450400001)(386003)(53936002)(16526019)(956004)(2616005)(446003)(4720700003)(476003)(11346002)(68736007)(6666003)(6916009)(5660300001)(107886003)(76176011)(51416003)(4326008)(7696005)(47776003)(52116002); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR07MB4017; H:cavium.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL0PR07MB4017; 23:u37OrTdw5IjjzVwN7Rh7IJJhRy5Yka5u8O4w8S29t?= KcmdxadS8l63k6IFWxk/sBdx7WdJ6OMTLUu9gP2Wg2xELKRs7Dlx7ps6MeOwA+SIp4gZB1vWxjh5DYwwKLMRv+ZWrsbA2ZcffHIqX/wbxNh081H6Pup4Na/AYHaykZ3PKzjQli6ttzbdI4QOj8RHgZk0byAuvsSLfGsURkZAAtXXymKiUXoK7h5Q3WUw895DynUTW+24avJyVVSvCb4dT6g4LPRPT9ZcSkeKfAEUiOKzciaaFdwm/n2R00z536yJmh5C1ECqE3oamPqm4mZOM3bhCS8fHCnaAYjcpIK1+X7gjAcIKODPBGzH4h14zq5ky8gZWMkUJVpqP/hdDEaAxRd+KKymZJbfC8VdG28RZmgz60Gy3gnR17uHfPNVi2QZNQejEOoK1GI0Dbxc3mgXOuFr+qcmjrZS9xzPnV5GaPio+JlxD2pU3oKYWjfGB4Dc/IjZGP3inKYOvnKjeGRbuH5sq+F5bLz4jhXb/JboX1W6JLqOq/BKhZdB/eO2IMZTyHm/1fV4fygleijgejRfml/rmfz5btepq2kzQCToBfaJNzXHwF+UjEyAYlcdtNpSNgtS5yT1P8vEmS/19Y/UnCxYP2jteYmg+VjHc1T82O6uQi/yn2KAxiIbm390m2N8rAdIApZ3dpMK5Et4Ks2G7PTe8C1tIONlp6YZXr4AuwHMCtHe/Sf0mlb84lxcubJsy70pXcBFN8TDtGAcJDYvnR85NsX9EalvwQYwaVuk88b3Ph8amGwSoXifvGOOA2McSg9QFjJb/XtYqnaUtQQ+/ovQ26HeAXN86o7Z2TlOOHcG5riX2wdME0Osu2VRwdgq/g+ecmVPAwypIZwlgj0s2rM3ZI1oK8ORfzZxYbrGVMMe8xlwiFyKtt1Z/lxWS2PFpVVtsX1Qkkdd2No8C97Ce2Mri7Th8UUC/+ADZUAfa/9e5Uhp6RDaultJ6XlBstylIJV0+2ATTgqKTRzNEV7Sd6tSSVOe8YBC8//PfuGGvqerKmObwoiAOs80PXecu4j1HpHP9rrsfJJO3YVkjQtAf8sJREAsghSIOO8SkZiI6HLBwPARgtBbAmmtZ4wa6skwYun3dPiUKgudF2xlwHUzUwvKgvZQy7F7IGOLaaeIsqxIYlTTnDJvUkFkUlIeK0ODrbX/DkPP1WKjvKIIPMP812XfGd5wCgddulPB65FB3n5WPw9BBEI+8TFUOpClFKSw91rhIRv6CJTgNoslPQyXwNzvasfWR6kxZWBL5fyiO5jhc4g/QYjmoZMCTDAAUMVczUAlB/MpCJZF5wdVbmsR7Zu2SBJZ44RuZJ6N7Vo0SuIHg== X-Microsoft-Antispam-Message-Info: bG9mlIDjh3E/L25k7r8Mm4Tz57xHSX/zxzqHD8x7wX1yU1PNsQ69gGE+qmjm3FASEaJDMM/y59tHCrGPQXax1EXNG/+B05JWdYknh/qy3NyqSPeInswGKS3lDTSPV38gkv/NGtMzIUEBKkZX/tDEWscuk6hKpSncPyAwAhmMZKGw4ryRfdYZRlR9c4n5/rPtpxDIa81Avu3hJMS87YSk6syhFopBHRR3W6CMogW8btqNeOBgUiZZ6VBXnK3MlkZZSTyxj6sg6qGxLoIQK+K6xyuG5zZAe6qF+C4akoZbVXXMH+wuc4Vw7q2fO7FyBfwSfv/sN42dHIGWZe4ln59CGp6HMvQ/VXPdGfFDxgB5UBg= X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 6:wlcyHR1xoANhIM10oChFCwLmjtphy6BqMdSs7KrSA1HgznIECAguH23LbUYnf3/aXRvI3jIAG/NxhW1HYbV3EccEPp8eXqZraT0HKRrqTq+UhMwh6mQ5BzQrQYj1X7doG8yd8Ylm5F+okQ12L9cq67QRiw+PupMtYFcT51mCjhkZ1nUWRGj5KEhJrlCsp6QTszd/IBoch5sNaeJxnPocIR0Xs88skKuHolcN8mhb3H2D7ix9BaEtGknqqcwZERukSp8KDoOOuY9Y6oHapXw5ULXpnApMyeopKuqjYib0W9sDO6KOrRHZJcse+5RltjBs6gh+ksq+plb0xeCBs+zMCtVb6lGrGZERsFyjVKsIfrPJkep/ZvTQB/uiVjy4WzzJjx8OvhJOB6uE+n57bUvQ7g54EAJXDssCbgWl9bzq+RG3fThvBe0XYchFn/eHqA6uA1QYTnJlo6TTaNKN9hxrEg==; 5:6HTAwUjZT3jb+sB+yDLZsupptwvS7S1OtVm/QUjIoGqGUa8jORiZlpUwYvGcnhgQon0UL1WMS2m4Q7/s70SiGM/KctJtTwjpJsGKnNSKnxFud6Z0QP/o9E0UpwjUXSgOr53silb6aciMW5Htj0y8RX0hMOXFOtaXNSYEAht7lqo=; 24:sQtMpDBWR+Udz2BYr46XXT3uP+pqK/k1BWpwTQUicighKJaan4RAINvfPOOurCUe1HXCLzLLbPx7hzgATST0PHoEnGlkan7lHb/mks079+U= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 7:jR/6wRtqi36crPwp9bojhudWxT32bfhGlBKrzSUdSJvB4WaJBxoTvdeiSzelbJeUEkZqw5IKKUk6NmxPLbxoH1OrQOFDhBScqXcfjRtlDg4kjKaSopLrMtiHHhTHSooAfohO7JL4z/Vl0I+ojY6sI5muu+8vF4l7P0oa0xUyj2DDFycDYl9aNV2DcujA1g+EBVD24NluJa5VU6rg46dxRPLl97r2HRr3ZHWo5MCawsQNAXOa7zJ1Ka57UhtND2lQ X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2018 21:20:58.8371 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b82dbbea-4030-44b3-2808-08d5d94f3726 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR07MB4017 Subject: [dpdk-dev] [PATCH 3/3] net/qede: remove primary MAC removal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This was added to dev_stop when set MTU requested vport restart. We are not requiring vport restart any more with set MTU as it just needs vport to be inactive and doesn't need the port reconfigured. Fixes: d121a6b5f781 ("net/qede: fix VF MTU update") Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 8bbfa95..b726e89 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1355,9 +1355,6 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev) /* Disable traffic */ ecore_hw_stop_fastpath(edev); /* TBD - loop */ - if (IS_PF(edev)) - qede_mac_addr_remove(eth_dev, 0); - DP_INFO(edev, "Device is stopped\n"); } @@ -2096,8 +2093,6 @@ int qede_update_mtu(struct rte_eth_dev *eth_dev, uint16_t mtu) goto err; /* Restore config lost due to vport stop */ - qede_mac_addr_set(eth_dev, &qdev->primary_mac); - if (eth_dev->data->promiscuous) qede_promiscuous_enable(eth_dev); else @@ -2526,9 +2521,6 @@ static int qede_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) dev->data->dev_started = 0; qede_dev_stop(dev); restart = true; - } else { - if (IS_PF(edev)) - qede_mac_addr_remove(dev, 0); } rte_delay_ms(1000); qdev->mtu = mtu;