From patchwork Fri Feb 18 18:05:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Weiguo Li X-Patchwork-Id: 107828 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02940A0032; Fri, 18 Feb 2022 19:05:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD3FE4014E; Fri, 18 Feb 2022 19:05:32 +0100 (CET) Received: from out162-62-57-252.mail.qq.com (out162-62-57-252.mail.qq.com [162.62.57.252]) by mails.dpdk.org (Postfix) with ESMTP id C753940141 for ; Fri, 18 Feb 2022 19:05:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1645207528; bh=Xuj3KasZs2JjQfadj+76a0NMVuni+3ir6ZNwj8opn7k=; h=From:To:Cc:Subject:Date; b=d1FfxZWOEVwGlhvBVjWBqZke5gM+duw+Xchq9C6h7VnZ+J6/mcQHnljhomb8pVtdy sSXsXfcLS2wBbvacMqD6vtmXoA+ZojkM7LVGSL6bZ3BvjJnSOU1RxTIrRCNcr/xtiI SuGM5dTwsRTUHiPNy1uRgRRjXsLIPOGAzOJC4EaU= Received: from localhost.localdomain ([111.193.130.237]) by newxmesmtplogicsvrszc6.qq.com (NewEsmtp) with SMTP id 1528F8EA; Sat, 19 Feb 2022 02:05:18 +0800 X-QQ-mid: xmsmtpt1645207518t2ngv0k22 Message-ID: X-QQ-XMAILINFO: N0opbxSOYLeWQpmB7grGNyHQo2dl/7cMI5B9YrJDTJbFTHCCE5sPQL6fNCRGBn URR6oZgipFdwqkP5245pxfGJOrLr1s3s3nRtsVjv/7g8V8PyuFxt8Xq1HZShhlNcyECv1yes6I92 PUkew1x8/vuYEbOSDJ+nvrfN17juoyCAcw8S4q+Qm3wiLo+4+0NqeBKB7oLGsbv9DArWUgr7QpR/ eCl8qQN/x/LwdtmIWdX3/LXG4oF+7vdNNnr76+n8wgD8zcwqgUbQLCaAUYo8R7Wox3BL4x+sTrV7 DB46TdaEOAxgsu0IXfgY4ZWKSMRkdFTlllZ/1/dhWvunA7zpwlPK2LxrB62zuZYC5NkMh6Qtyx4g Xy54bNGWPwW/vIqN+PZ+2PrAOCnucVZIpFcPUsXlw/TiAybLxr8lqh3cz9Unwi/c8CN2qKYDj4yr COVvntSaM0L85AvdD+gLeVKF/Hy2tvt4H/bqlWC12m5diFh2/N++A3JiGDGJUFNRWssdONj9QDPq vBv8KxnUvfW7SZ8EKPQnXMKNhy34R51Yw6tIOVQFYTFtkYIptKtO51QE/3eArynRGPl4xnVj8dqe VyfUH4I9LJzFK6Esiw+JZeYHO968AF4O95K5idEDdmXARtlDhLPMxbXChBEYCQeB2hRbq2t89Dgd Dyv6KA1K48QWJ9cgzNiiTFzi0eYgU4XFLqJr+8hxUZHoh/gSd1g2Mfvti+9UvNd+r78FC8uuWSwM KV3RWVFFysZqaZCxckxGKFYT5EdsSJB91XA2ZVWRYzA4NQ9c7Ow/KyMsHXMSlVBI46LzK6w7XKxz hFH6iOrLRleQVIU27HEEgZg5E2tbnVBoasJ9U7x5CN/31mNb1YJMK6dUZxb7mgkW+NhVfc0F6g6c BbimKgF7694oYt+TTBOilBVZo9Z86YzBEDVZx3VnOksNmyL+2LyfU= From: Weiguo Li To: ajit.khaparde@broadcom.com Cc: kalesh-anakkur.purayil@broadcom.com, dev@dpdk.org Subject: [PATCH] net/bnxt: fix a memory leak when new malloc fail Date: Sat, 19 Feb 2022 02:05:18 +0800 X-OQ-MSGID: <20220218180518.494770-1-liwg06@foxmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When new memory is not available and the memory "ctx" allocated beforehand was not assigned to anywhere, so "ctx" should be freed, otherwise will cause a memory leak. Fixes: b4f740511655 ("net/bnxt: remove unnecessary return check") Signed-off-by: Weiguo Li --- drivers/net/bnxt/bnxt_hwrm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index b4aeec593e..4993111ccf 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -5374,6 +5374,7 @@ int bnxt_hwrm_func_backing_store_qcaps(struct bnxt *bp) RTE_CACHE_LINE_SIZE); if (!ctx_pg) { rc = -ENOMEM; + rte_free(ctx); goto ctx_err; } for (i = 0; i < tqm_rings; i++, ctx_pg++)