From patchwork Fri Mar 4 02:37:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wu, WenxuanX" X-Patchwork-Id: 108529 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8CEDDA04A2; Fri, 4 Mar 2022 03:57:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37DCD40150; Fri, 4 Mar 2022 03:57:43 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id A5F3B4013F for ; Fri, 4 Mar 2022 03:57:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646362661; x=1677898661; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Ng5eQB9ib6K/t0HETHjdsiUlzwCQWkxcHxNOG6eoDkU=; b=iYm5QklKRSO5AACjfCG81UNxImx0mt9zdqc6RrE8FRBOFvKsLMwWtW3K mzPxd1WcpNILEa7ePk+EqST4Ba2FcHjTkrq03K6M32AkovI8AeZxM42sx ciftAbidl+TwOlEbd3+60wa5BjEkqcNqS+t8bDjkTfCCJyo0dpbVTVJbe H4N9Uv9kvB4zwb0Wz+jpCYDyOO7ZsI1tOVoggtDyyL9XsusazOwKK0jfV n3p0ToVUPCiVKaCsbuiM+1ncckbVVZl0/cKJEuWGYmnUQu0b45y3ed2+5 Bo0qaNWj2u7thS7p0XYvWwVRtToV0qqwAu3E1HsT1n3c+o3qWNKwzO5CZ Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10275"; a="253609709" X-IronPort-AV: E=Sophos;i="5.90,154,1643702400"; d="scan'208";a="253609709" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2022 18:57:40 -0800 X-IronPort-AV: E=Sophos;i="5.90,154,1643702400"; d="scan'208";a="536114343" Received: from unknown (HELO localhost.localdomain) ([10.239.251.3]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2022 18:57:38 -0800 From: wenxuanx.wu@intel.com To: qiming.yang@intel.com, qi.z.zhang@intel.com, xiaoyun.li@intel.com, aman.deep.singh@intel.com, yuying.zhang@intel.com Cc: dev@dpdk.org Subject: [PATCH v2] app/testpmd : fix testpmd quit error Date: Fri, 4 Mar 2022 10:37:01 +0800 Message-Id: <20220304023701.499961-1-wenxuanx.wu@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: wenxuan wu When testpmd use func get_eth_dev_info() while related resource had been released. Change the logic of func port_is_bonding_slave, this func eth_dev_info_get_print_err while pf is released would result in this error. Use ports instead to avoid this bug. Fixes: 0a0821bcf312 ("app/testpmd: remove most uses of internal ethdev array") Cc: stable@dpdk.org Signed-off-by: wenxuan wu --- app/test-pmd/testpmd.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index e1da961311..37038c9183 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3824,19 +3824,9 @@ void clear_port_slave_flag(portid_t slave_pid) uint8_t port_is_bonding_slave(portid_t slave_pid) { struct rte_port *port; - struct rte_eth_dev_info dev_info; - int ret; port = &ports[slave_pid]; - ret = eth_dev_info_get_print_err(slave_pid, &dev_info); - if (ret != 0) { - TESTPMD_LOG(ERR, - "Failed to get device info for port id %d," - "cannot determine if the port is a bonded slave", - slave_pid); - return 0; - } - if ((*dev_info.dev_flags & RTE_ETH_DEV_BONDED_SLAVE) || (port->slave_flag == 1)) + if ((*port->dev_info.dev_flags & RTE_ETH_DEV_BONDED_SLAVE) || (port->slave_flag == 1)) return 1; return 0; }