From patchwork Fri Jun 24 06:55:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Ling, WeiX" X-Patchwork-Id: 113400 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ACE4CA0032; Fri, 24 Jun 2022 08:57:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A5B0B40A8A; Fri, 24 Jun 2022 08:57:57 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 2C70B40A82 for ; Fri, 24 Jun 2022 08:57:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656053876; x=1687589876; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=OO3l9zONLOkNlBLyhqm+BF3+jDP5sPGXYddFKMMhtyM=; b=lDDsPux8U44wLMUk6BH9BkdDPCDnLailj0k0Am6QM9V1VO2ns5YG8VTW rT7Fdp6My45qYVAncayBrr5QdxKm83cOCe3ke01mUGqyv2yJMTgaNHf8B 63AgaUVq2o8xh3A5gU/D+42w27Zvht1C5trQoJnWSJYmGNXZ4AdZs9xwz La+EZC2K3t3u41kAvKuxpt/rH6CrWssqAQqZsU4rfCfVXaG3AYcnia1z5 6MQPO/X9kNX2xdFwE3Zs14CIOanIsx7zanJgq0rsVwz8OPt3fc4Yj8U4n JdBhHVZlIPE1QqTl4jZaX2+TeRZb5nAw14496/l+KoqYpx9SLwCDjmwOa A==; X-IronPort-AV: E=McAfee;i="6400,9594,10387"; a="269667779" X-IronPort-AV: E=Sophos;i="5.92,218,1650956400"; d="scan'208";a="269667779" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 23:57:55 -0700 X-IronPort-AV: E=Sophos;i="5.92,218,1650956400"; d="scan'208";a="621626386" Received: from unknown (HELO localhost.localdomain) ([10.239.252.222]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 23:57:54 -0700 From: Wei Ling To: dts@dpdk.org Cc: Wei Ling Subject: [dts][PATCH V1 1/2] test_plans/virtio_user_as_exceptional_path_test_plan: delete modify dpdk code content Date: Fri, 24 Jun 2022 02:55:20 -0400 Message-Id: <20220624065520.2832886-1-weix.ling@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org According to the dpdk commit 1945c64674(app/testpmd: perform SW IP checksum for GRO/GSO packets) and commit 8ba1723783(net/vhost: perform SW checksum in Tx path), no need to modify DPDK code to test. Signed-off-by: Wei Ling --- ...virtio_user_as_exceptional_path_test_plan.rst | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/test_plans/virtio_user_as_exceptional_path_test_plan.rst b/test_plans/virtio_user_as_exceptional_path_test_plan.rst index e1d2feb2..81399ea2 100644 --- a/test_plans/virtio_user_as_exceptional_path_test_plan.rst +++ b/test_plans/virtio_user_as_exceptional_path_test_plan.rst @@ -10,22 +10,6 @@ This test plan will test exceptional path with virtio_user and measure throughpu Prerequisites ============= -Modify the testpmd code as following:: - - --- a/app/test-pmd/csumonly.c - +++ b/app/test-pmd/csumonly.c - @@ -693,10 +693,12 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) -                  * and inner headers */ -                 eth_hdr = rte_pktmbuf_mtod(m, struct ether_hdr *); - +#if 0 -                 ether_addr_copy(&peer_eth_addrs[fs->peer_addr], -                                 ð_hdr->d_addr); -                 ether_addr_copy(&ports[fs->tx_port].eth_addr, -                                 ð_hdr->s_addr); - +#endif -                 parse_ethernet(eth_hdr, &info); -                 l3_hdr = (char *)eth_hdr + info.l2_len; - Test Case1:test exceptional path with virtio_user ================================================= Flow:tap0-->vhost-net-->virtio_user-->nic0-->nic1 From patchwork Fri Jun 24 06:55:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ling, WeiX" X-Patchwork-Id: 113401 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D70DAA0032; Fri, 24 Jun 2022 08:58:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA76D427EC; Fri, 24 Jun 2022 08:58:06 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id B01AC40A82 for ; Fri, 24 Jun 2022 08:58:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656053885; x=1687589885; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=p1cZBksHaQSrBJTC4VZkJcJqTgIa5djuLS1IGxsI6rU=; b=nUzBTYmDCDyN/UOBFFCwz+QmwBenFszOLWyD3VaSULqtatqDR+BKJ6dm kr7u33hG5hjld1yxfm1/vRdCJluzNcKFpe1/XJVHjfsaqeMobQKrSmksb AE3eUlY0u6GMOrHY6vLK8QlvO0w29naZim6E0Qre4IMQGTuJLY3xT11fU cksz6keLdP3rIWejyekTXVmU+lbypUVaaXyS1KS6xDwl8wppxOjc6TJkZ U/JbaS4VMfLKE1LqaDTcotYV9r4E3bSZqoPFNnU2m9Zic9qhzsFrWfFwU PnY42Dwt4EXo9T9GUgn34fyDhmmahkhqO+Kj2VN45YDdkToONbCLhuGBA w==; X-IronPort-AV: E=McAfee;i="6400,9594,10387"; a="306404160" X-IronPort-AV: E=Sophos;i="5.92,218,1650956400"; d="scan'208";a="306404160" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 23:58:04 -0700 X-IronPort-AV: E=Sophos;i="5.92,218,1650956400"; d="scan'208";a="621626433" Received: from unknown (HELO localhost.localdomain) ([10.239.252.222]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 23:58:03 -0700 From: Wei Ling To: dts@dpdk.org Cc: Wei Ling Subject: [dts][PATCH V1 2/2] tests/virtio_user_as_exceptional_path: delete modify dpdk code steps Date: Fri, 24 Jun 2022 02:55:29 -0400 Message-Id: <20220624065529.2832947-1-weix.ling@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org According to the dpdk commit 1945c64674(app/testpmd: perform SW IP checksum for GRO/GSO packets) and commit 8ba1723783(net/vhost: perform SW checksum in Tx path), no need to modify DPDK code to test. Signed-off-by: Wei Ling Tested-by: Chenyu Huang --- ...stSuite_virtio_user_as_exceptional_path.py | 26 ------------------- 1 file changed, 26 deletions(-) diff --git a/tests/TestSuite_virtio_user_as_exceptional_path.py b/tests/TestSuite_virtio_user_as_exceptional_path.py index 1f7d8330..c5105d5f 100644 --- a/tests/TestSuite_virtio_user_as_exceptional_path.py +++ b/tests/TestSuite_virtio_user_as_exceptional_path.py @@ -44,7 +44,6 @@ class TestVirtioUserAsExceptionalPath(TestCase): self.socket_mem = "1024,1024" self.pktgen_helper = PacketGeneratorHelper() self.peer_pci_setup = False - self.prepare_dpdk() self.app_testpmd_path = self.dut.apps_name["test-pmd"] self.testpmd_name = self.app_testpmd_path.split("/")[-1] @@ -181,30 +180,6 @@ class TestVirtioUserAsExceptionalPath(TestCase): "ip netns exec ns1 ethtool -K %s tso on" % self.nic_in_kernel, "#" ) - def prepare_dpdk(self): - # - # Changhe the testpmd checksum fwd code for mac change - self.dut.send_expect( - "cp ./app/test-pmd/csumonly.c ./app/test-pmd/csumonly_backup.c", "#" - ) - self.dut.send_expect( - "sed -i '/ether_addr_copy(&peer_eth/i\#if 0' ./app/test-pmd/csumonly.c", "#" - ) - self.dut.send_expect( - "sed -i '/parse_ethernet(eth_hdr, &info/i\#endif' ./app/test-pmd/csumonly.c", - "#", - ) - self.dut.build_install_dpdk(self.dut.target) - time.sleep(3) - - def unprepare_dpdk(self): - # Recovery the DPDK code to original - self.dut.send_expect( - "cp ./app/test-pmd/csumonly_backup.c ./app/test-pmd/csumonly.c ", "#" - ) - self.dut.send_expect("rm -rf ./app/test-pmd/csumonly_backup.c", "#") - self.dut.build_install_dpdk(self.dut.target) - def iperf_result_verify(self, vm_client, direction): """ Get the iperf test result @@ -375,7 +350,6 @@ class TestVirtioUserAsExceptionalPath(TestCase): for i in self.dut_ports: port = self.dut.ports_info[i]["port"] port.bind_driver(self.def_driver) - self.unprepare_dpdk() if self.peer_pci_setup: self.dut.send_expect( "./usertools/dpdk-devbind.py -u %s" % (self.pci), "# ", 30