From patchwork Mon Jul 11 12:11:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Mattias_R=C3=B6nnblom?= X-Patchwork-Id: 113899 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3342FA0032; Mon, 11 Jul 2022 14:14:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28D8540DFD; Mon, 11 Jul 2022 14:14:57 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150080.outbound.protection.outlook.com [40.107.15.80]) by mails.dpdk.org (Postfix) with ESMTP id 05C71410DD; Mon, 11 Jul 2022 14:14:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NQ7mH6DUD75XPAFGvG69n+TYS6U4v1MQHyhB6SDusnVuzVaERyUluCnJIapVeo2yqxIs+FudJdz4iHeM6jxGynqbRy/REO3cV46GY7/cq9TEtqLQbE51xqpAxJCgkqMWZs9Egj6USD2NPMz5t/C+TdiPXGzFEz4YyTkxIyXUYsdZmETpCvFrSr8NyEem39FzPwivCi4QKTMb5xP/F980XyfIzSTlowIuRGaBoyf+dxTIhyigPcVa7BdCpVUj7cKdqyOxOEA9PCOcdW1M44LkTfEM7q9y0fejZ90rZOc+6Wajbco/mCoI0H2ABhdyg6F3qX8bgBCFCpfAXR0O6Aj/Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EBBa4grGwq109fNyAN0RlDvQIUbr4QF0wGD5HH8NdrI=; b=eqbIs8qwTWKdVi/ajEJdiiugMluf3kaQGNsnxplBKKbihVY+T/vZ43C6HoT9do4oTDE75O05bwWfHnR5in5hOkB6+rI6a8jCCCAZjKk6qOBAh2uiStiddHGmZaHghRmGhum0h79Mz++vb4YDy9T91NDqhtzerSAt1mG3iQdVvRSdOra3lk0ftfEeivvkj+CTtwy3sWhUcZTleTZ0heYjro6IFdAuh0tbi1+LnVfEQo0uMpeYq9zzedqTsKRIw6ecTdeJdl4Vyb+xVSpfKXrkaqAwNxk/7cfB64nZurTKPmR7ORPRFV/B0YeIvPH8Bw12K8FteNfMXfbuFNXdYnpOqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=6wind.com smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EBBa4grGwq109fNyAN0RlDvQIUbr4QF0wGD5HH8NdrI=; b=b0aEa/mXiY+UvfWFrcrcjvgvOyXkcUZ3lV3J4UG6lT+ulmbkVfuVkljQmpMQsBxUHSIuw/0WaECD304AIfSFrhg/WOllRFoca+Whh5QLXrdQ8wul+QKi9DPcNRwrlMIvMAXbr8dYAfY8dYgfjqnw3/ZQR2rr1y1tt/Zvh+EycKY= Received: from FR0P281CA0087.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::12) by AM6PR07MB4807.eurprd07.prod.outlook.com (2603:10a6:20b:3d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.12; Mon, 11 Jul 2022 12:14:55 +0000 Received: from VE1EUR02FT046.eop-EUR02.prod.protection.outlook.com (2603:10a6:d10:1e:cafe::7b) by FR0P281CA0087.outlook.office365.com (2603:10a6:d10:1e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.11 via Frontend Transport; Mon, 11 Jul 2022 12:14:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by VE1EUR02FT046.mail.protection.outlook.com (10.152.12.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.5417.15 via Frontend Transport; Mon, 11 Jul 2022 12:14:54 +0000 Received: from ESESBMB504.ericsson.se (153.88.183.171) by ESESBMR505.ericsson.se (153.88.183.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.28; Mon, 11 Jul 2022 14:14:22 +0200 Received: from ESESSMB504.ericsson.se (153.88.183.165) by ESESBMB504.ericsson.se (153.88.183.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.28; Mon, 11 Jul 2022 14:14:21 +0200 Received: from seliicinfr00050.seli.gic.ericsson.se (153.88.183.153) by smtp.internal.ericsson.com (153.88.183.192) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 11 Jul 2022 14:14:21 +0200 Received: from localhost.localdomain (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00050.seli.gic.ericsson.se (Postfix) with ESMTP id 0D78B1C0060; Mon, 11 Jul 2022 14:14:22 +0200 (CEST) From: =?utf-8?q?Mattias_R=C3=B6nnblom?= To: CC: Emil Berg , , , , , , , =?utf-8?q?Morten_Br=C3=B8rup?= , =?utf-8?q?Mattia?= =?utf-8?q?s_R=C3=B6nnblom?= Subject: [PATCH v3 1/2] app/test: add cksum performance test Date: Mon, 11 Jul 2022 14:11:31 +0200 Message-ID: <20220711121132.34546-1-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: afc2e760-7855-48b6-86e2-08da6336f6d9 X-MS-TrafficTypeDiagnostic: AM6PR07MB4807:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cfvR2U54lY21AQXhtTrQ1vmGYEF+vddmq5qFWb6UXw4wzKrgo/svv7Wp1HiCXwRU0oYmGYY6HkiQBTuBJjUok42Ctx1a+vW41VZBnXY0oJfkznHR+7J9Jud5rStedWEpkhD7FV7S+8yaETH2yjnoYeB48iVXKlM3hQ6cYdcMWUjF/LCGLmVK/xY6MgkH42YURsl0uhieqoVTrbDGo3lQ3+cakOIUHKSkgX+1IWHeN0kcmaY5TWmVLOG1yJkC9e0kn24v1Md45R/oo+q7Rg5Gmxey4dkZeKdo+Xqqlljjvqfr+/VWAPu/Ex8na7/yQ2J3WcYXNJKFX7t2GoRwqFaWVGG6sqBKcY94XKr8I/BTIcTJQXcmfG+HjjKoBdBT16X8RrtS1ISvPgs95lOCJQdinhmBci0xibGWPgIn6xovwUuRfgAXLY1+4gJ2/llMbZLYy2k9nzT2WSSEKR8YEV8aPdiqEwcS03+ae0KPqqixpdgxAdVrDESZ53Jf5BOGnq6GJ9obGhdZkCK4lKMq2msRS/K6seTYKX7CzQMSbLj1NaEgJ7CkLvKadid6b5wWZvYV89HCL0rHoXv49w0+IvSthfQSgzoPwurarXT/v0aMF8DNca9+ys47K4fqvidIXY/9oBvMR60HK7LvvIvZtF5EX7eOkukYpo0Zpaqe8VIbcwnhJrPAJe9n+DBTWy3nkeEXHUVoFklbBHY1UPAQRYhQjJ6BEumZ8w1PA2zM3Cm9nK+BD3Ba0G4vQ09olKctnCDutYaGmFy3k1v0mL7LAFFRxphaLZ5uhSaH4IVUcLYQEEaSZ7ks+xufJ7Z7lq1DTfYS X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(376002)(136003)(346002)(396003)(40470700004)(36840700001)(46966006)(6666004)(316002)(356005)(478600001)(1076003)(70206006)(4326008)(41300700001)(26005)(107886003)(2616005)(40140700001)(5660300002)(82310400005)(8936002)(6266002)(2906002)(40480700001)(47076005)(83380400001)(70586007)(86362001)(40460700003)(7636003)(36860700001)(6916009)(82960400001)(82740400003)(336012)(8676002)(54906003)(186003)(66574015)(36756003); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 12:14:54.6400 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: afc2e760-7855-48b6-86e2-08da6336f6d9 X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR02FT046.eop-EUR02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR07MB4807 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add performance test for the rte_raw_cksum() function, which delegates the actual work to __rte_raw_cksum(), which in turn is used by other functions in need of Internet checksum calculation. Signed-off-by: Mattias Rönnblom Acked-by: Olivier Matz --- v3: * Changed init function buffer parameter type, to avoid cast. * Code formatting improved. v2: * Added __rte_unused to unused volatile variable, to keep the Intel compiler happy. --- MAINTAINERS | 1 + app/test/meson.build | 1 + app/test/test_cksum_perf.c | 117 +++++++++++++++++++++++++++++++++++++ 3 files changed, 119 insertions(+) create mode 100644 app/test/test_cksum_perf.c diff --git a/MAINTAINERS b/MAINTAINERS index c923712946..2a4c99e05a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1414,6 +1414,7 @@ Network headers M: Olivier Matz F: lib/net/ F: app/test/test_cksum.c +F: app/test/test_cksum_perf.c Packet CRC M: Jasvinder Singh diff --git a/app/test/meson.build b/app/test/meson.build index 431c5bd318..191db03d1d 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -18,6 +18,7 @@ test_sources = files( 'test_bpf.c', 'test_byteorder.c', 'test_cksum.c', + 'test_cksum_perf.c', 'test_cmdline.c', 'test_cmdline_cirbuf.c', 'test_cmdline_etheraddr.c', diff --git a/app/test/test_cksum_perf.c b/app/test/test_cksum_perf.c new file mode 100644 index 0000000000..1f296cae34 --- /dev/null +++ b/app/test/test_cksum_perf.c @@ -0,0 +1,117 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2022 Ericsson AB + */ + +#include + +#include +#include +#include +#include +#include + +#include "test.h" + +#define NUM_BLOCKS 10 +#define ITERATIONS 1000000 + +static const size_t data_sizes[] = { 20, 21, 100, 101, 1500, 1501 }; + +static __rte_noinline uint16_t +do_rte_raw_cksum(const void *buf, size_t len) +{ + return rte_raw_cksum(buf, len); +} + +static void +init_block(char *buf, size_t len) +{ + size_t i; + + for (i = 0; i < len; i++) + buf[i] = (char)rte_rand(); +} + +static int +test_cksum_perf_size_alignment(size_t block_size, bool aligned) +{ + char *data[NUM_BLOCKS]; + char *blocks[NUM_BLOCKS]; + unsigned int i; + uint64_t start; + uint64_t end; + /* Floating point to handle low (pseudo-)TSC frequencies */ + double block_latency; + double byte_latency; + volatile __rte_unused uint64_t sum = 0; + + for (i = 0; i < NUM_BLOCKS; i++) { + data[i] = rte_malloc(NULL, block_size + 1, 0); + + if (data[i] == NULL) { + printf("Failed to allocate memory for block\n"); + return TEST_FAILED; + } + + init_block(data[i], block_size + 1); + + blocks[i] = aligned ? data[i] : data[i] + 1; + } + + start = rte_rdtsc(); + + for (i = 0; i < ITERATIONS; i++) { + unsigned int j; + for (j = 0; j < NUM_BLOCKS; j++) + sum += do_rte_raw_cksum(blocks[j], block_size); + } + + end = rte_rdtsc(); + + block_latency = (end - start) / (double)(ITERATIONS * NUM_BLOCKS); + byte_latency = block_latency / block_size; + + printf("%-9s %10zd %19.1f %16.2f\n", aligned ? "Aligned" : "Unaligned", + block_size, block_latency, byte_latency); + + for (i = 0; i < NUM_BLOCKS; i++) + rte_free(data[i]); + + return TEST_SUCCESS; +} + +static int +test_cksum_perf_size(size_t block_size) +{ + int rc; + + rc = test_cksum_perf_size_alignment(block_size, true); + if (rc != TEST_SUCCESS) + return rc; + + rc = test_cksum_perf_size_alignment(block_size, false); + + return rc; +} + +static int +test_cksum_perf(void) +{ + uint16_t i; + + printf("### rte_raw_cksum() performance ###\n"); + printf("Alignment Block size TSC cycles/block TSC cycles/byte\n"); + + for (i = 0; i < RTE_DIM(data_sizes); i++) { + int rc; + + rc = test_cksum_perf_size(data_sizes[i]); + if (rc != TEST_SUCCESS) + return rc; + } + + return TEST_SUCCESS; +} + + +REGISTER_TEST_COMMAND(cksum_perf_autotest, test_cksum_perf); From patchwork Mon Jul 11 12:11:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Mattias_R=C3=B6nnblom?= X-Patchwork-Id: 113898 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30789A0032; Mon, 11 Jul 2022 14:14:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CEECB40C35; Mon, 11 Jul 2022 14:14:26 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20084.outbound.protection.outlook.com [40.107.2.84]) by mails.dpdk.org (Postfix) with ESMTP id EDBD440695; Mon, 11 Jul 2022 14:14:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LjFgQ7yAiUr5X23h2S3x6a2ibUfJXF8bRcxdTaWq3fhvkZRYGFoqce5FUETXSn4AcJfza0AsS7Z/Q3dNMTCWFBWjuV68zT0J4DJNgof6BCCJffpjmoBTb/pSRiWPRsj0vx9q9e4egPjW+b/7cLKA7ntOJqZJRb0OeU9/KODT6BzTHAGfQE7VjKh5nOxf44EogcfB5rxoiWVT3b7yQR6LOisewO84i5f8PixTqHBmZsBcGB0POfWwiPp3ngAkOZuqXJ+JNo0lJDDk+O89T0z+PU9txe3RoAAU93NLHdvi2gPENzdg33WY7nCX0ihzoMzn4e0gR0/YrCr4+O6TqzOMWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4S+OiGLiOj+U3zEwgKXzjgcHgOhgFSCjIqChLmz5SNE=; b=W6uWd7tO21xI6xaGwhXSCpS85f7+61pyUGgdoKhaFWXYD67xSMvlB9rxMSPQPlzEpQ8XwlGOEAeWeVAqk3KflBVxsN+Qu8RtCa7xxRCvwzLWI2AeT59kKw3VXR+DV8l1qNYl3WH81ODVilicV3GOUGVIifmowl8jV0zVxSY412OcRZ7KamKe+oollTEUBeVo70diZAQsaGUIXAGyRQxZ1j5BIJRyfzYd9bNzxcc2XLL+EEHgcgTA2/oq5IxDkNwSIl1lETPYq5IgYPpXTuvVPdL2MymVUZXZiIjbh055om/meG3ex+8UlWqlbjZTedg0BOfy38g2PtO7GrEyTD1sBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=6wind.com smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4S+OiGLiOj+U3zEwgKXzjgcHgOhgFSCjIqChLmz5SNE=; b=hfdBduNo4nNgxAo57qWXlVJku+XmI2lC0jkw5sZ/S0gLIY/956Gm+PBrgHCEQ8tTwOlFPXL+33378VVSErdSW8L8DND3M3lKbKxQEZO+9+5CNXEcTreed0+EQ/k99/G5LGbF6BHTqNW4ddci0WQMuxs1vLXgPdZQpOXXKyWqEZk= Received: from AS9PR06CA0199.eurprd06.prod.outlook.com (2603:10a6:20b:45d::18) by DB9PR07MB7210.eurprd07.prod.outlook.com (2603:10a6:10:214::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.11; Mon, 11 Jul 2022 12:14:23 +0000 Received: from VE1EUR02FT008.eop-EUR02.prod.protection.outlook.com (2603:10a6:20b:45d:cafe::d5) by AS9PR06CA0199.outlook.office365.com (2603:10a6:20b:45d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Mon, 11 Jul 2022 12:14:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by VE1EUR02FT008.mail.protection.outlook.com (10.152.12.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.5417.15 via Frontend Transport; Mon, 11 Jul 2022 12:14:23 +0000 Received: from ESESBMB503.ericsson.se (153.88.183.170) by ESESSMR501.ericsson.se (153.88.183.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.28; Mon, 11 Jul 2022 14:14:22 +0200 Received: from seliicinfr00050.seli.gic.ericsson.se (153.88.183.153) by smtp.internal.ericsson.com (153.88.183.186) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 11 Jul 2022 14:14:22 +0200 Received: from localhost.localdomain (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00050.seli.gic.ericsson.se (Postfix) with ESMTP id CA9B11C0060; Mon, 11 Jul 2022 14:14:22 +0200 (CEST) From: =?utf-8?q?Mattias_R=C3=B6nnblom?= To: CC: Emil Berg , , , , , , , =?utf-8?q?Morten_Br=C3=B8rup?= , =?utf-8?q?Mattia?= =?utf-8?q?s_R=C3=B6nnblom?= Subject: [PATCH v3 2/2] net: have checksum routines accept unaligned data Date: Mon, 11 Jul 2022 14:11:32 +0200 Message-ID: <20220711121132.34546-2-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220711121132.34546-1-mattias.ronnblom@ericsson.com> References: <20220711121132.34546-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cdceaf5c-20fc-41b2-2afe-08da6336e43c X-MS-TrafficTypeDiagnostic: DB9PR07MB7210:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fSXtsvkwfSSjKc3Yp5Y3mCrFwmhqPLYiOLKzrLifbLCj0yIPaqIU1eSx1k0PJZiRcUx0fMyO+8HpBI6P4gMQxdV7gDxRrWgixTt9NYgTKat+D268gJOxKjrSWL8Pjc7IYtaiGIBTdweuFeaXFO7aimyL0vnJXiSx3rLJDnUzLIchtvpAxDAf3HAIDmTHglKMLIFlUbxai3Qj8qs34RstDm4S5bsxAWDWtSLuCWW1Irr7kUmGvyCAfIYW22zFaa8gMQkkg7yyzEIAgtyJhldebdtl787AryMkL1FuTuocZDgTFR4RNNU23wlPAp1TEDsjhf024meTyG83q+7cQYXmBKXu/7FMkzIzngD3fnn5KiGcQ737cocGbO+TQZu7HhjcRpuP5TdYFQZXdzdgcWdP1w75WJNfAspzXXDX1RtNgGgqF/K9exHeW+OByhpWbSqW96bXdQcJnGJ2u2w9XO/DNVTeQZXUf51gwYYxKhlGUH8IYMldUvBtwV4YAZe+nEA5aknYAGj/1exBp3EyjfCvEDSqmN/EvE0rXJuyVlzeQ0mRvJAy18D4mKM8Q3rW8k11NJJWHvAg0QsqPa2XUSMdnIC7kWt6XF4EGlLt9nPiDCj9nXVMH+3+Lxw8PXseyHTJkQ+noq4mfhc5/6pUnLnuRH6A4/7ww5sOd4+vgXHaWNeapWdp/ybkuOnTrNRWvgcw19JnS61I27KkiNgh8/DZk66z6W3uzYqWpLcPF89CUwtyf8cpFwLVBNAnpaxsalJ7uIKfQwRL76wPsXMM7BAwFCfyFOLgMd/fvkAR8N1vn7jKDtQfd+7oFV6OvrxkkBpPAiHftABC93DIXD/OZcYPIvOpYR0dDn/jnFL10hRrk+/KwJbJLtcu0ahtX3sMUW/l X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(396003)(376002)(136003)(346002)(40470700004)(36840700001)(46966006)(83380400001)(8676002)(6916009)(478600001)(40460700003)(36860700001)(40480700001)(82960400001)(5660300002)(2906002)(4326008)(41300700001)(6666004)(356005)(8936002)(70586007)(82740400003)(26005)(70206006)(6266002)(66574015)(107886003)(47076005)(2616005)(1076003)(316002)(186003)(86362001)(82310400005)(336012)(54906003)(36756003)(7636003); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 12:14:23.4253 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cdceaf5c-20fc-41b2-2afe-08da6336e43c X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR02FT008.eop-EUR02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR07MB7210 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org __rte_raw_cksum() (used by rte_raw_cksum() among others) accessed its data through an uint16_t pointer, which allowed the compiler to assume the data was 16-bit aligned. This in turn would, with certain architectures and compiler flag combinations, result in code with SIMD load or store instructions with restrictions on data alignment. This patch keeps the old algorithm, but data is read using memcpy() instead of direct pointer access, forcing the compiler to always generate code that handles unaligned input. The __may_alias__ GCC attribute is no longer needed. The data on which the Internet checksum functions operates are almost always 16-bit aligned, but there are exceptions. In particular, the PDCP protocol header may (literally) have an odd size. Performance impact seems to range from none to a very slight regression. Bugzilla ID: 1035 Cc: stable@dpdk.org Acked-by: Olivier Matz --- v3: * Use RTE_ALIGN_FLOOR() in the pointer arithmetic (Olivier Matz). v2: * Simplified the odd-length conditional (Morten Brørup). Reviewed-by: Morten Brørup Signed-off-by: Mattias Rönnblom --- lib/net/rte_ip.h | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h index b502481670..ecd250e9be 100644 --- a/lib/net/rte_ip.h +++ b/lib/net/rte_ip.h @@ -160,18 +160,21 @@ rte_ipv4_hdr_len(const struct rte_ipv4_hdr *ipv4_hdr) static inline uint32_t __rte_raw_cksum(const void *buf, size_t len, uint32_t sum) { - /* extend strict-aliasing rules */ - typedef uint16_t __attribute__((__may_alias__)) u16_p; - const u16_p *u16_buf = (const u16_p *)buf; - const u16_p *end = u16_buf + len / sizeof(*u16_buf); + const void *end; - for (; u16_buf != end; ++u16_buf) - sum += *u16_buf; + for (end = RTE_PTR_ADD(buf, RTE_ALIGN_FLOOR(len, sizeof(uint16_t))); + buf != end; buf = RTE_PTR_ADD(buf, sizeof(uint16_t))) { + uint16_t v; + + memcpy(&v, buf, sizeof(uint16_t)); + sum += v; + } /* if length is odd, keeping it byte order independent */ if (unlikely(len % 2)) { uint16_t left = 0; - *(unsigned char *)&left = *(const unsigned char *)end; + + memcpy(&left, end, 1); sum += left; }