From patchwork Wed Aug 10 06:49:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhichao Zeng X-Patchwork-Id: 114791 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF089A0540; Wed, 10 Aug 2022 08:48:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7DAC240A87; Wed, 10 Aug 2022 08:48:59 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id CAFCF4068E for ; Wed, 10 Aug 2022 08:48:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660114137; x=1691650137; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=oXIg23VgYq7vquNmHzdvf46qkgPCokvNmrnq8Qx94mY=; b=Knmp8N2bffOD1eLZAWg1AxDNrP3RrOsbge5MhlpGcWDiiDbSqZnrmiEx 8J1kwJRz4p6H3N52VA8rjeXD+iHmIvr2c1ENzLwyXBrnWwuSSOlGYW/Mm vr1doYebt3prA9pnn3FWHvJ/VojWTwtKz5CxUfj9Eq1qSTxfjQoXkPyBw K9mh6SnvadoG1pVA/HB1Pzfx6KoKVbZrkfHO6VcSUSB7Nk5FUZOnHiAD7 QI5oeUc46GJG9A0u+yCIZFn60l0k5nywbiYZqIELatSNZObLMhicxSp6z dx/HnNBXZGmdqomkcZPJQUj2W2NjrQMBChWugcZQra141ZXxY6ki5XR9d w==; X-IronPort-AV: E=McAfee;i="6400,9594,10434"; a="355014371" X-IronPort-AV: E=Sophos;i="5.93,226,1654585200"; d="scan'208";a="355014371" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2022 23:48:56 -0700 X-IronPort-AV: E=Sophos;i="5.93,226,1654585200"; d="scan'208";a="932776885" Received: from unknown (HELO localhost.localdomain) ([10.239.252.103]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2022 23:48:54 -0700 From: zhichaox.zeng@intel.com To: dev@dpdk.org Cc: qiming.yang@intel.com, yidingx.zhou@intel.com, Zhichao Zeng , Qi Zhang Subject: [PATCH] net/ice: remove deprecated VF flow action Date: Wed, 10 Aug 2022 14:49:37 +0800 Message-Id: <20220810064937.162455-1-zhichaox.zeng@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Zhichao Zeng According to the ABI and API Deprecation, remove deprecated VF action as hard-to-use / ambiguous. Action REPRESENTED_PORT should be used instead. Signed-off-by: Zhichao Zeng Acked-by: Qi Zhang --- doc/guides/nics/features/ice.ini | 1 - drivers/net/ice/ice_switch_filter.c | 22 ---------------------- 2 files changed, 23 deletions(-) diff --git a/doc/guides/nics/features/ice.ini b/doc/guides/nics/features/ice.ini index 12fd802885..fe1e81302c 100644 --- a/doc/guides/nics/features/ice.ini +++ b/doc/guides/nics/features/ice.ini @@ -81,5 +81,4 @@ mark = Y passthru = Y queue = Y rss = Y -vf = Y represented_port = Y diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c index 5d65988474..da81e49bfa 100644 --- a/drivers/net/ice/ice_switch_filter.c +++ b/drivers/net/ice/ice_switch_filter.c @@ -1619,7 +1619,6 @@ ice_switch_parse_dcf_action(struct ice_dcf_adapter *ad, struct ice_adv_rule_info *rule_info) { const struct rte_flow_action_ethdev *act_ethdev; - const struct rte_flow_action_vf *act_vf; const struct rte_flow_action *action; const struct rte_eth_dev *repr_dev; enum rte_flow_action_type action_type; @@ -1629,26 +1628,6 @@ ice_switch_parse_dcf_action(struct ice_dcf_adapter *ad, RTE_FLOW_ACTION_TYPE_END; action++) { action_type = action->type; switch (action_type) { - case RTE_FLOW_ACTION_TYPE_VF: - rule_info->sw_act.fltr_act = ICE_FWD_TO_VSI; - act_vf = action->conf; - - if (act_vf->id >= ad->real_hw.num_vfs && - !act_vf->original) { - rte_flow_error_set(error, - EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, - actions, - "Invalid vf id"); - return -rte_errno; - } - - if (act_vf->original) - rule_info->sw_act.vsi_handle = - ad->real_hw.avf.bus.func; - else - rule_info->sw_act.vsi_handle = act_vf->id; - break; - case RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT: rule_info->sw_act.fltr_act = ICE_FWD_TO_VSI; act_ethdev = action->conf; @@ -1812,7 +1791,6 @@ ice_switch_check_action(const struct rte_flow_action *actions, RTE_FLOW_ACTION_TYPE_END; action++) { action_type = action->type; switch (action_type) { - case RTE_FLOW_ACTION_TYPE_VF: case RTE_FLOW_ACTION_TYPE_RSS: case RTE_FLOW_ACTION_TYPE_QUEUE: case RTE_FLOW_ACTION_TYPE_DROP: