From patchwork Thu Sep 15 08:16:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kaur, Arshdeep" X-Patchwork-Id: 116331 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36DF2A00C5; Thu, 15 Sep 2022 10:16:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2CF384021D; Thu, 15 Sep 2022 10:16:19 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 9D49240156 for ; Thu, 15 Sep 2022 10:16:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663229777; x=1694765777; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=LwcKUWKVYghgQ2FKBPm0BnPIGMDmTqSc7Io9YWmuuwg=; b=b3TbGtjHs/0NfmHtU9y/9lAA0TlQTAKjnoRMrGahyGWqQ1C+yqweVUAx uQD8ORBWvO8ZPIb1TE9w/WMuBM3NjAjh1JNJBMoRpPVt+4elHBZpg5FZt bkuC5XYJe0KC43HhzmS88seWp+NwA/qmA30jOjGiJsCrnAEGr+8aMgQz4 k++qtAQS/ea0PPO12YEaXJRi07O/4hZ5yLK6+M6dE/CbwDzx3E6m56Pb+ TsjEGuoj9/O0X++8TUpIn+JCr0/0i+tUUzaszxnvxp/fcFFwV1cO5b8L9 CNqEQ2XdNDsvPoBszzg4eX0YqN3mhVmvQQNT/kLflxIVxhGm7iGBaPkcJ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10470"; a="281679805" X-IronPort-AV: E=Sophos;i="5.93,317,1654585200"; d="scan'208";a="281679805" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2022 01:16:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,317,1654585200"; d="scan'208";a="650392446" Received: from unknown (HELO skx-5gnr-sd6.localdomain) ([10.233.180.92]) by orsmga001.jf.intel.com with ESMTP; 15 Sep 2022 01:16:16 -0700 From: Arshdeep Kaur To: dev@dpdk.org Subject: [PATCH v3] dumpcap: fix interface parameter check. Date: Thu, 15 Sep 2022 01:16:09 -0700 Message-Id: <20220915081609.77312-1-arshdeep.kaur@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220912125328.236907-1-arshdeep.kaur@intel.com> References: <20220912125328.236907-1-arshdeep.kaur@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Correction in handling 'IF' condition for -i parameter. Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") Signed-off-by: Arshdeep Kaur Acked-by: Reshma Pattan --- app/dumpcap/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c index a6041d4ff4..8972c45a71 100644 --- a/app/dumpcap/main.c +++ b/app/dumpcap/main.c @@ -240,7 +240,7 @@ static void select_interface(const char *arg) { uint16_t port; - if (strcmp(arg, "*")) + if (!strcmp(arg, "*")) select_all_interfaces(); else if (rte_eth_dev_get_port_by_name(arg, &port) == 0) add_interface(port, arg);