From patchwork Fri Sep 23 07:43:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dongdong Liu X-Patchwork-Id: 116719 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D12B0A0544; Fri, 23 Sep 2022 09:45:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 377164282D; Fri, 23 Sep 2022 09:45:00 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id D748E400D7 for ; Fri, 23 Sep 2022 09:44:56 +0200 (CEST) Received: from kwepemi500017.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MYkbJ1lB7zlWN0; Fri, 23 Sep 2022 15:40:44 +0800 (CST) Received: from localhost.localdomain (10.28.79.22) by kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 15:44:53 +0800 From: Dongdong Liu To: , , , , , CC: "Min Hu (Connor)" , Dongdong Liu Subject: [PATCH v4 1/3] ethdev: introduce ethdev desc dump API Date: Fri, 23 Sep 2022 15:43:14 +0800 Message-ID: <20220923074316.25077-2-liudongdong3@huawei.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20220923074316.25077-1-liudongdong3@huawei.com> References: <20220527023351.40577-1-humin29@huawei.com> <20220923074316.25077-1-liudongdong3@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.28.79.22] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500017.china.huawei.com (7.221.188.110) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: "Min Hu (Connor)" Added the ethdev Rx/Tx desc dump API which provides functions for query descriptor from device. HW descriptor info differs in different NICs. The information demonstrates I/O process which is important for debug. As the information is different between NICs, the new API is introduced. Signed-off-by: Min Hu (Connor) Signed-off-by: Dongdong Liu Acked-by: Ray Kinsella --- doc/guides/rel_notes/release_22_11.rst | 7 ++++ lib/ethdev/ethdev_driver.h | 46 +++++++++++++++++++++++ lib/ethdev/rte_ethdev.c | 52 ++++++++++++++++++++++++++ lib/ethdev/rte_ethdev.h | 49 ++++++++++++++++++++++++ lib/ethdev/version.map | 2 + 5 files changed, 156 insertions(+) diff --git a/doc/guides/rel_notes/release_22_11.rst b/doc/guides/rel_notes/release_22_11.rst index f60161765b..d3f3f2e50c 100644 --- a/doc/guides/rel_notes/release_22_11.rst +++ b/doc/guides/rel_notes/release_22_11.rst @@ -55,6 +55,13 @@ New Features Also, make sure to start the actual text at the margin. ======================================================= +* **Added ethdev desc dump API, to dump Rx/Tx desc info from device.** + +Added the ethdev Rx/Tx desc dump API which provides functions for query +descriptor from device. The descriptor info differs in different NICs. +The information demonstrates I/O process which is important for debug. +As the information is different between NICs, the new API is introduced. +The dump format is vendor-specific. Removed Items ------------- diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h index a0e0b2ae88..76808dae89 100644 --- a/lib/ethdev/ethdev_driver.h +++ b/lib/ethdev/ethdev_driver.h @@ -1093,6 +1093,47 @@ typedef int (*eth_rx_queue_avail_thresh_query_t)(struct rte_eth_dev *dev, uint16_t *rx_queue_id, uint8_t *avail_thresh); + +/** + * @internal + * Dump Rx descriptor info to a file. + * + * It is used for debugging, not a dataplane API. + * + * @param file + * A pointer to a file for output. + * @param dev + * Port (ethdev) handle. + * @param queue_id + * The selected queue. + * @param num + * The number of the descriptors to dump. + * @return + * Negative errno value on error, zero on success. + */ +typedef int (*eth_rx_hw_desc_dump_t)(FILE *file, const struct rte_eth_dev *dev, + uint16_t queue_id, uint16_t num); + +/** + * @internal + * Dump Tx descriptor info to a file. + * + * This API is used for debugging, not a dataplane API. + * + * @param file + * A pointer to a file for output. + * @param dev + * Port (ethdev) handle. + * @param queue_id + * The selected queue. + * @param num + * The number of the descriptors to dump. + * @return + * Negative errno value on error, zero on success. + */ +typedef int (*eth_tx_hw_desc_dump_t)(FILE *file, const struct rte_eth_dev *dev, + uint16_t queue_id, uint16_t num); + /** * @internal A structure containing the functions exported by an Ethernet driver. */ @@ -1308,6 +1349,11 @@ struct eth_dev_ops { eth_rx_queue_avail_thresh_set_t rx_queue_avail_thresh_set; /** Query Rx queue available descriptors threshold event */ eth_rx_queue_avail_thresh_query_t rx_queue_avail_thresh_query; + + /** Dump Rx descriptor info */ + eth_rx_hw_desc_dump_t eth_rx_hw_desc_dump; + /** Dump Tx descriptor info */ + eth_tx_hw_desc_dump_t eth_tx_hw_desc_dump; }; /** diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index 1979dc0850..2093275d87 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -5917,6 +5917,58 @@ rte_eth_dev_priv_dump(uint16_t port_id, FILE *file) return eth_err(port_id, (*dev->dev_ops->eth_dev_priv_dump)(dev, file)); } +int +rte_eth_rx_hw_desc_dump(FILE *file, uint16_t port_id, uint16_t queue_id, + uint16_t num) +{ + struct rte_eth_dev *dev; + int ret; + + if (file == NULL) { + RTE_ETHDEV_LOG(ERR, "Invalid file (NULL)\n"); + return -EINVAL; + } + + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); + dev = &rte_eth_devices[port_id]; + + if (queue_id >= dev->data->nb_rx_queues) { + RTE_ETHDEV_LOG(ERR, "Invalid Rx queue_id=%u\n", queue_id); + return -EINVAL; + } + + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->eth_rx_hw_desc_dump, -ENOTSUP); + ret = (*dev->dev_ops->eth_rx_hw_desc_dump)(file, dev, queue_id, num); + + return ret; +} + +int +rte_eth_tx_hw_desc_dump(FILE *file, uint16_t port_id, uint16_t queue_id, + uint16_t num) +{ + struct rte_eth_dev *dev; + int ret; + + if (file == NULL) { + RTE_ETHDEV_LOG(ERR, "Invalid file (NULL)\n"); + return -EINVAL; + } + + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); + dev = &rte_eth_devices[port_id]; + + if (queue_id >= dev->data->nb_tx_queues) { + RTE_ETHDEV_LOG(ERR, "Invalid Tx queue_id=%u\n", queue_id); + return -EINVAL; + } + + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->eth_tx_hw_desc_dump, -ENOTSUP); + ret = (*dev->dev_ops->eth_tx_hw_desc_dump)(file, dev, queue_id, num); + + return ret; +} + RTE_LOG_REGISTER_DEFAULT(rte_eth_dev_logtype, INFO); RTE_INIT(ethdev_init_telemetry) diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index b62ac5bb6f..4671e6b28e 100644 --- a/lib/ethdev/rte_ethdev.h +++ b/lib/ethdev/rte_ethdev.h @@ -5221,6 +5221,55 @@ typedef struct { __rte_experimental int rte_eth_dev_priv_dump(uint16_t port_id, FILE *file); +/** + * @warning + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice + * + * Dump ethdev Rx descriptor info to a file. + * + * This API is used for debugging, not a dataplane API. + * + * @param file + * A pointer to a file for output. + * @param dev + * Port (ethdev) handle. + * @param queue_id + * The selected queue. + * @param num + * The number of the descriptors to dump. + * @return + * - On success, zero. + * - On failure, a negative value. + */ +__rte_experimental +int rte_eth_rx_hw_desc_dump(FILE *file, uint16_t port_id, uint16_t queue_id, + uint16_t num); + +/** + * @warning + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice + * + * Dump ethdev Tx descriptor info to a file. + * + * This API is used for debugging, not a dataplane API. + * + * @param file + * A pointer to a file for output. + * @param dev + * Port (ethdev) handle. + * @param queue_id + * The selected queue. + * @param num + * The number of the descriptors to dump. + * @return + * - On success, zero. + * - On failure, a negative value. + */ +__rte_experimental +int rte_eth_tx_hw_desc_dump(FILE *file, uint16_t port_id, uint16_t queue_id, + uint16_t num); + + #include /** diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map index 03f52fee91..3c7c75b582 100644 --- a/lib/ethdev/version.map +++ b/lib/ethdev/version.map @@ -285,6 +285,8 @@ EXPERIMENTAL { rte_mtr_color_in_protocol_priority_get; rte_mtr_color_in_protocol_set; rte_mtr_meter_vlan_table_update; + rte_eth_rx_hw_desc_dump; + rte_eth_tx_hw_desc_dump; }; INTERNAL { From patchwork Fri Sep 23 07:43:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dongdong Liu X-Patchwork-Id: 116718 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77BE9A0544; Fri, 23 Sep 2022 09:45:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4A0A6427F0; Fri, 23 Sep 2022 09:44:59 +0200 (CEST) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id C5BE84003C for ; Fri, 23 Sep 2022 09:44:56 +0200 (CEST) Received: from kwepemi500017.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4MYkbK158Qz1P6qs; Fri, 23 Sep 2022 15:40:45 +0800 (CST) Received: from localhost.localdomain (10.28.79.22) by kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 15:44:53 +0800 From: Dongdong Liu To: , , , , , CC: "Min Hu (Connor)" , Dongdong Liu , Yisen Zhuang Subject: [PATCH v4 2/3] net/hns3: support Rx/Tx bd dump Date: Fri, 23 Sep 2022 15:43:15 +0800 Message-ID: <20220923074316.25077-3-liudongdong3@huawei.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20220923074316.25077-1-liudongdong3@huawei.com> References: <20220527023351.40577-1-humin29@huawei.com> <20220923074316.25077-1-liudongdong3@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.28.79.22] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500017.china.huawei.com (7.221.188.110) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: "Min Hu (Connor)" This patch support query HW descriptor from hns3 device. HW descriptor is also called BD(buffer description) which is shared memory between software and hardware. Signed-off-by: Min Hu (Connor) Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_dump.c | 80 +++++++++++++++++++++++++++++++ drivers/net/hns3/hns3_dump.h | 5 ++ drivers/net/hns3/hns3_ethdev.c | 2 + drivers/net/hns3/hns3_ethdev_vf.c | 2 + 4 files changed, 89 insertions(+) diff --git a/drivers/net/hns3/hns3_dump.c b/drivers/net/hns3/hns3_dump.c index 95b64f8896..ce26e5b65f 100644 --- a/drivers/net/hns3/hns3_dump.c +++ b/drivers/net/hns3/hns3_dump.c @@ -10,6 +10,9 @@ #include "hns3_rxtx.h" #include "hns3_dump.h" +#define HNS3_BD_DW_NUM 8 +#define HNS3_BD_ADDRESS_LAST_DW 2 + static const char * hns3_get_adapter_state_name(enum hns3_adapter_state state) { @@ -931,3 +934,80 @@ hns3_eth_dev_priv_dump(struct rte_eth_dev *dev, FILE *file) return 0; } + +int hns3_rx_hw_desc_dump(FILE *file, const struct rte_eth_dev *dev, + uint16_t queue_id, uint16_t num) +{ + struct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private); + struct hns3_rx_queue *rxq = dev->data->rx_queues[queue_id]; + uint32_t *bd_data; + uint16_t count = 0; + uint16_t desc_id; + int i; + + if (num > rxq->nb_rx_desc) { + hns3_err(hw, "Invalid BD num=%u\n", num); + return -EINVAL; + } + + while (count < num) { + desc_id = (rxq->next_to_use + count) % rxq->nb_rx_desc; + bd_data = (uint32_t *)(&rxq->rx_ring[desc_id]); + fprintf(file, "Rx queue id:%u BD id:%u\n", queue_id, desc_id); + for (i = 0; i < HNS3_BD_DW_NUM; i++) { + /* + * For the sake of security, first 8 bytes of BD which + * stands for physical address of packet should not be + * shown. + */ + if (i < HNS3_BD_ADDRESS_LAST_DW) { + fprintf(file, "RX BD WORD[%d]:0x%08x\n", i, 0); + continue; + } + fprintf(file, "RX BD WORD[%d]:0x%08x\n", i, + *(bd_data + i)); + } + count++; + } + + return 0; +} + +int hns3_tx_hw_desc_dump(FILE *file, const struct rte_eth_dev *dev, + uint16_t queue_id, uint16_t num) +{ + struct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private); + struct hns3_tx_queue *txq = dev->data->tx_queues[queue_id]; + uint32_t *bd_data; + uint16_t count = 0; + uint16_t desc_id; + int i; + + if (num > txq->nb_tx_desc) { + hns3_err(hw, "Invalid BD num=%u\n", num); + return -EINVAL; + } + + while (count < num) { + desc_id = (txq->next_to_use + count) % txq->nb_tx_desc; + bd_data = (uint32_t *)(&txq->tx_ring[desc_id]); + fprintf(file, "Tx queue id:%u BD id:%u\n", queue_id, desc_id); + for (i = 0; i < HNS3_BD_DW_NUM; i++) { + /* + * For the sake of security, first 8 bytes of BD which + * stands for physical address of packet should not be + * shown. + */ + if (i < HNS3_BD_ADDRESS_LAST_DW) { + fprintf(file, "TX BD WORD[%d]:0x%08x\n", i, 0); + continue; + } + + fprintf(file, "Tx BD WORD[%d]:0x%08x\n", i, + *(bd_data + i)); + } + count++; + } + + return 0; +} diff --git a/drivers/net/hns3/hns3_dump.h b/drivers/net/hns3/hns3_dump.h index b0fe37ee21..f92d8af880 100644 --- a/drivers/net/hns3/hns3_dump.h +++ b/drivers/net/hns3/hns3_dump.h @@ -10,4 +10,9 @@ #include int hns3_eth_dev_priv_dump(struct rte_eth_dev *dev, FILE *file); + +int hns3_rx_hw_desc_dump(FILE *file, const struct rte_eth_dev *dev, + uint16_t queue_id, uint16_t num); +int hns3_tx_hw_desc_dump(FILE *file, const struct rte_eth_dev *dev, + uint16_t queue_id, uint16_t num); #endif /* _HNS3_DUMP_H_ */ diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c index 7cd1ff53e8..43a604c0fd 100644 --- a/drivers/net/hns3/hns3_ethdev.c +++ b/drivers/net/hns3/hns3_ethdev.c @@ -6567,6 +6567,8 @@ static const struct eth_dev_ops hns3_eth_dev_ops = { .timesync_read_time = hns3_timesync_read_time, .timesync_write_time = hns3_timesync_write_time, .eth_dev_priv_dump = hns3_eth_dev_priv_dump, + .eth_rx_hw_desc_dump = hns3_rx_hw_desc_dump, + .eth_tx_hw_desc_dump = hns3_tx_hw_desc_dump, }; static const struct hns3_reset_ops hns3_reset_ops = { diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c index a72535eb7d..b1997c42f4 100644 --- a/drivers/net/hns3/hns3_ethdev_vf.c +++ b/drivers/net/hns3/hns3_ethdev_vf.c @@ -2308,6 +2308,8 @@ static const struct eth_dev_ops hns3vf_eth_dev_ops = { .dev_supported_ptypes_get = hns3_dev_supported_ptypes_get, .tx_done_cleanup = hns3_tx_done_cleanup, .eth_dev_priv_dump = hns3_eth_dev_priv_dump, + .eth_rx_hw_desc_dump = hns3_rx_hw_desc_dump, + .eth_tx_hw_desc_dump = hns3_tx_hw_desc_dump, }; static const struct hns3_reset_ops hns3vf_reset_ops = { From patchwork Fri Sep 23 07:43:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dongdong Liu X-Patchwork-Id: 116720 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59328A0544; Fri, 23 Sep 2022 09:45:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C43E42B6E; Fri, 23 Sep 2022 09:45:01 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id ACF3D4003C for ; Fri, 23 Sep 2022 09:44:57 +0200 (CEST) Received: from kwepemi500017.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MYkbX3CM4zWgpn; Fri, 23 Sep 2022 15:40:56 +0800 (CST) Received: from localhost.localdomain (10.28.79.22) by kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 15:44:54 +0800 From: Dongdong Liu To: , , , , , CC: "Min Hu (Connor)" , Dongdong Liu , Maryam Tahhan , Reshma Pattan Subject: [PATCH v4 3/3] app/procinfo: support descriptor dump Date: Fri, 23 Sep 2022 15:43:16 +0800 Message-ID: <20220923074316.25077-4-liudongdong3@huawei.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20220923074316.25077-1-liudongdong3@huawei.com> References: <20220527023351.40577-1-humin29@huawei.com> <20220923074316.25077-1-liudongdong3@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.28.79.22] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500017.china.huawei.com (7.221.188.110) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: "Min Hu (Connor)" This patch support HW Rx/Tx descriptor dump The command is like: dpdk-proc-info -a xxxx:xx:xx.x --file-prefix=xxx -- -- --show-rx-descriptor queue_id:num dpdk-proc-info -a xxxx:xx:xx.x --file-prefix=xxx -- -- --show-tx-descriptor queue_id:num Signed-off-by: Min Hu (Connor) Signed-off-by: Dongdong Liu --- app/proc-info/main.c | 80 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 80 insertions(+) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index 1bfba5f60d..3907af3213 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -48,6 +48,9 @@ #define STATS_BDR_STR(w, s) printf("%.*s%s%.*s\n", w, \ STATS_BDR_FMT, s, w, STATS_BDR_FMT) +typedef int (*desc_dump_t)(FILE *file, uint16_t port_id, uint16_t queue_id, + uint16_t num); + /**< mask of enabled ports */ static unsigned long enabled_port_mask; /**< Enable stats. */ @@ -102,6 +105,12 @@ static char *mempool_iter_name; /**< Enable dump regs. */ static uint32_t enable_dump_regs; static char *dump_regs_file_prefix; +/* Enable dump buffer descriptor. */ +#define MAX_NB_ITEM 2 +static uint16_t rx_nb_item; +static uint16_t tx_nb_item; +static uint16_t rx_item_opt[MAX_NB_ITEM]; +static uint16_t tx_item_opt[MAX_NB_ITEM]; /**< display usage */ static void @@ -130,6 +139,8 @@ proc_info_usage(const char *prgname) " --show-crypto: to display crypto information\n" " --show-ring[=name]: to display ring information\n" " --show-mempool[=name]: to display mempool information\n" + " --show-rx-descriptor queue_id:num: to display ports Rx buffer description by queue id and num\n" + " --show-tx-descriptor queue_id:num: to display ports Tx buffer description by queue id and num\n" " --iter-mempool=name: iterate mempool elements to display content\n" " --dump-regs=file-prefix: dump registers to file with the file-prefix\n", prgname); @@ -182,6 +193,34 @@ parse_xstats_ids(char *list, uint64_t *ids, int limit) { return length; } +/* + * Parse ids value list into array + */ +static int +parse_descriptor_param(char *list, uint16_t *item_opt, int limit) +{ + int length; + char *token; + char *ctx = NULL; + char *endptr; + + length = 0; + token = strtok_r(list, ":", &ctx); + while (token != NULL) { + item_opt[length] = strtoul(token, &endptr, 10); + if (*endptr != '\0') + return -EINVAL; + + length++; + if (length > limit) + return -E2BIG; + + token = strtok_r(NULL, ":", &ctx); + } + + return length; +} + static int proc_info_preparse_args(int argc, char **argv) { @@ -242,6 +281,8 @@ proc_info_parse_args(int argc, char **argv) {"show-mempool", optional_argument, NULL, 0}, {"iter-mempool", required_argument, NULL, 0}, {"dump-regs", required_argument, NULL, 0}, + {"show-rx-descriptor", required_argument, NULL, 1}, + {"show-tx-descriptor", required_argument, NULL, 1}, {NULL, 0, 0, 0} }; @@ -334,6 +375,26 @@ proc_info_parse_args(int argc, char **argv) return -1; } nb_xstats_ids = ret; + } else if (!strncmp(long_option[option_index].name, + "show-rx-descriptor", MAX_LONG_OPT_SZ)) { + int ret = parse_descriptor_param(optarg, + rx_item_opt, + MAX_NB_ITEM); + if (ret < MAX_NB_ITEM) { + printf("Rx descriptor param parse error.\n"); + return -1; + } + rx_nb_item = ret; + } else if (!strncmp(long_option[option_index].name, + "show-tx-descriptor", MAX_LONG_OPT_SZ)) { + int ret = parse_descriptor_param(optarg, + tx_item_opt, + MAX_NB_ITEM); + if (ret < MAX_NB_ITEM) { + printf("Tx descriptor param parse error.\n"); + return -1; + } + tx_nb_item = ret; } break; default: @@ -1476,6 +1537,19 @@ dump_regs(char *file_prefix) } } +static void +nic_descriptor_display(uint16_t port_id, uint16_t *item_opt, + desc_dump_t desc_dump) +{ + static const char *nic_desc_border = "###"; + uint16_t queue_id = item_opt[0]; + uint16_t num = item_opt[1]; + + printf("%s NIC descriptor for port %u %s\n", + nic_desc_border, port_id, nic_desc_border); + + desc_dump(stdout, port_id, queue_id, num); +} int main(int argc, char **argv) { @@ -1559,6 +1633,12 @@ main(int argc, char **argv) else if (nb_xstats_ids > 0) nic_xstats_by_ids_display(i, xstats_ids, nb_xstats_ids); + else if (rx_nb_item > 0) + nic_descriptor_display(i, rx_item_opt, + rte_eth_rx_hw_desc_dump); + else if (tx_nb_item > 0) + nic_descriptor_display(i, tx_item_opt, + rte_eth_tx_hw_desc_dump); #ifdef RTE_LIB_METRICS else if (enable_metrics) metrics_display(i);