From patchwork Thu Sep 29 09:57:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh Bhagavatula X-Patchwork-Id: 117116 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FAA0A00C4; Thu, 29 Sep 2022 12:00:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C88941143; Thu, 29 Sep 2022 12:00:05 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 3502940694 for ; Thu, 29 Sep 2022 12:00:03 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28T9kM6h014952; Thu, 29 Sep 2022 02:57:53 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=6e0HJUsVV4MLin7VkmKnCjYgCHxuz7QELsWN69A26ps=; b=WnI5x7iInNiQJDLYwOP2UxcoNHeVaMELzH1YDMyn0dYOhfiSL58dWhnGMIVuk/Zw3XxB jXL4RplNvicsKLyzyBkzcStVoKcTN8DZPqV5tbyeMQSMgPm7TyUWABsKXmM0/pY75QEE V9D/WxCvUDOQN7XoMUJdFJQDUN7S3O9vvXZ92idJddzLSeB/SE4UTgDAYq41kpf+criL VwMqK0B1RXCNISNaUZIGmx5HNJhgQOZE7yk4U3pNZJoAeu/yLrOFxlsUCSlNkak+xHfv MqQIf5DCNU0gI6Dv1Pl3RhcEy6azH9j8M9C9DSJqt8+rPszfrBNI/Y5AVqKCKbi/ZW9f vA== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3jw913g11k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 29 Sep 2022 02:57:53 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 29 Sep 2022 02:57:51 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Thu, 29 Sep 2022 02:57:51 -0700 Received: from MININT-80QBFE8.corp.innovium.com (unknown [10.28.161.88]) by maili.marvell.com (Postfix) with ESMTP id 170F13F705A; Thu, 29 Sep 2022 02:57:49 -0700 (PDT) From: To: , Ray Kinsella CC: , Pavan Nikhilesh Subject: [PATCH 1/3] eventdev: add rte prefix to function declaration Date: Thu, 29 Sep 2022 15:27:46 +0530 Message-ID: <20220929095748.12563-1-pbhagavatula@marvell.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Proofpoint-GUID: RnLTBhZJ0tdYp6AfHQPBEKefenqniLUV X-Proofpoint-ORIG-GUID: RnLTBhZJ0tdYp6AfHQPBEKefenqniLUV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-29_05,2022-09-29_02,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Pavan Nikhilesh Add `rte` prefix to stop flush callback function pointer declaration to avoid conflicts with application functions, ``eventdev_stop_flush_t`` is renamed to ``rte_eventdev_stop_flush_t``. Signed-off-by: Pavan Nikhilesh --- doc/guides/rel_notes/deprecation.rst | 3 --- lib/eventdev/eventdev_pmd.h | 2 ++ lib/eventdev/rte_eventdev.c | 3 ++- lib/eventdev/rte_eventdev.h | 9 ++++----- 4 files changed, 8 insertions(+), 9 deletions(-) -- 2.25.1 diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index e3d609fd88..2826a38f03 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -173,9 +173,6 @@ Deprecation Notices Event will be one of the configuration fields, together with additional vector parameters. -* eventdev: The function pointer declaration ``eventdev_stop_flush_t`` - will be renamed to ``rte_eventdev_stop_flush_t`` in DPDK 22.11. - * eventdev: The element ``*u64s`` in the structure ``rte_event_vector`` is deprecated and will be replaced with ``u64s`` in DPDK 22.11. diff --git a/lib/eventdev/eventdev_pmd.h b/lib/eventdev/eventdev_pmd.h index ca9e3f1875..066104b572 100644 --- a/lib/eventdev/eventdev_pmd.h +++ b/lib/eventdev/eventdev_pmd.h @@ -1315,6 +1315,8 @@ typedef int (*eventdev_eth_tx_adapter_queue_start) typedef int (*eventdev_eth_tx_adapter_queue_stop) (uint8_t id, uint16_t eth_dev_id, uint16_t tx_queue_id); +#define eventdev_stop_flush_t rte_eventdev_stop_flush_t + /** Event device operations function pointer table */ struct eventdev_ops { eventdev_info_get_t dev_infos_get; /**< Get device info. */ diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c index f6b7d0a139..db372a3d8c 100644 --- a/lib/eventdev/rte_eventdev.c +++ b/lib/eventdev/rte_eventdev.c @@ -1325,7 +1325,8 @@ rte_event_dev_start(uint8_t dev_id) int rte_event_dev_stop_flush_callback_register(uint8_t dev_id, - eventdev_stop_flush_t callback, void *userdata) + rte_eventdev_stop_flush_t callback, + void *userdata) { struct rte_eventdev *dev; diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h index cd307643c1..86d656a08b 100644 --- a/lib/eventdev/rte_eventdev.h +++ b/lib/eventdev/rte_eventdev.h @@ -1023,8 +1023,8 @@ rte_event_dev_start(uint8_t dev_id); void rte_event_dev_stop(uint8_t dev_id); -typedef void (*eventdev_stop_flush_t)(uint8_t dev_id, struct rte_event event, - void *arg); +typedef void (*rte_eventdev_stop_flush_t)(uint8_t dev_id, + struct rte_event event, void *arg); /**< Callback function called during rte_event_dev_stop(), invoked once per * flushed event. */ @@ -1053,9 +1053,8 @@ typedef void (*eventdev_stop_flush_t)(uint8_t dev_id, struct rte_event event, * * @see rte_event_dev_stop() */ -int -rte_event_dev_stop_flush_callback_register(uint8_t dev_id, - eventdev_stop_flush_t callback, void *userdata); +int rte_event_dev_stop_flush_callback_register( + uint8_t dev_id, rte_eventdev_stop_flush_t callback, void *userdata); /** * Close an event device. The device cannot be restarted! From patchwork Thu Sep 29 09:57:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh Bhagavatula X-Patchwork-Id: 117117 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D83BA00C4; Thu, 29 Sep 2022 12:00:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA2FE40694; Thu, 29 Sep 2022 12:00:07 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id E767C427FF for ; Thu, 29 Sep 2022 12:00:05 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28T9khs3016863; Thu, 29 Sep 2022 02:57:56 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=oIBngyAICBBUDTUQMPmGNGBkSZJvBHc8FHgLlMIzqY0=; b=FvhennilKqngkBXC8akXuhamTyObf0TgO7UOrnk5GHpw4WxIX4DkctN7ZBG8ERlnCgED MzjJxJq01hdJbFe6QuYVxEnxXNK9QFZJT38qjq2Y4IaBzkkbo4CBtCCjft+SlshnkZ3Z uBLtPC5x+TMSBO4FPTGg2bzmxWkKWqeDDeeCaFc+A07f7ABXE8J4nraqiz4kAqaJoBsb 0D0tJqzOGVvAIYGIYIV4YdPlYZbTFCKI0uBfkiBotZwSnn/5d3ulOf/PMRWiqId4Rlyc F9+zqseHzxUCeRaUVeXB9praoJFOdk0kjrF3Sfte72np6bAa6Xg4dGtV+WZXoWFVkdC4 kw== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3jw913g11s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 29 Sep 2022 02:57:55 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Thu, 29 Sep 2022 02:57:54 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Thu, 29 Sep 2022 02:57:54 -0700 Received: from MININT-80QBFE8.corp.innovium.com (unknown [10.28.161.88]) by maili.marvell.com (Postfix) with ESMTP id 703B03F705D; Thu, 29 Sep 2022 02:57:52 -0700 (PDT) From: To: , Ray Kinsella CC: , Pavan Nikhilesh Subject: [PATCH 2/3] eventdev: replace *u64s with u64s in event vector Date: Thu, 29 Sep 2022 15:27:47 +0530 Message-ID: <20220929095748.12563-2-pbhagavatula@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220929095748.12563-1-pbhagavatula@marvell.com> References: <20220929095748.12563-1-pbhagavatula@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: wka9oH8-aID5nF4gynzUaHcYIO_DRVZs X-Proofpoint-ORIG-GUID: wka9oH8-aID5nF4gynzUaHcYIO_DRVZs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-29_05,2022-09-29_02,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Pavan Nikhilesh Replace *u64s with u64s in rte_event_vector structure as the *ptrs already serves the purpose of holding pointers and the intention of u64s is to hold array of uint64_t values. Signed-off-by: Pavan Nikhilesh --- doc/guides/rel_notes/deprecation.rst | 3 --- lib/eventdev/rte_eventdev.h | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 2826a38f03..bb44b1f9ff 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -173,9 +173,6 @@ Deprecation Notices Event will be one of the configuration fields, together with additional vector parameters. -* eventdev: The element ``*u64s`` in the structure ``rte_event_vector`` - is deprecated and will be replaced with ``u64s`` in DPDK 22.11. - * eventdev: The structure ``rte_event_vector`` will be modified to include ``elem_offset:12`` bits taken from ``rsvd:15``. The ``elem_offset`` defines the offset into the vector array from which valid elements are present. diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h index 86d656a08b..1cbeb6bddc 100644 --- a/lib/eventdev/rte_eventdev.h +++ b/lib/eventdev/rte_eventdev.h @@ -1117,7 +1117,7 @@ struct rte_event_vector { #endif struct rte_mbuf *mbufs[0]; void *ptrs[0]; - uint64_t *u64s[0]; + uint64_t u64s[0]; #ifndef __cplusplus } __rte_aligned(16); #endif From patchwork Thu Sep 29 09:57:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh Bhagavatula X-Patchwork-Id: 117118 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F06E4A00C4; Thu, 29 Sep 2022 12:00:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA217410FA; Thu, 29 Sep 2022 12:00:08 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id CAF3F4281C for ; Thu, 29 Sep 2022 12:00:06 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28T9kM6i014952; Thu, 29 Sep 2022 02:57:58 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=FYEqihjIKqVT4VkYJexeNUGgbBGy1p3n+KKi4LVHuiU=; b=FwZ2fYeLsc2P++W8/PdMXSaziertxzowuR5LV1iKw5wCnVSlfWmw1Js/02ZpdJHkFtVB E4PMPTlXKofdMuxDiyrOlq/S4LJ0nfSqvOBcilr2j/TiEwcTaSk3r+Kqp8Sh0tpWe9Q9 Jh7EjTYphVUQJfLuYYu1PEP7YMuvQCEx89TR7yMiUGQZiqdn1ZJFj0RDZJrTOcdfmPVm g086sckAIGZtQlNrCkCdXMr98BA6PR4v4/6UypsVynLWXBX2V+omvbQHqaChrzM8DTOl Sn1lTVQUPzHkvVDISOw9XpEgV9VAhDHvMaUM5njv/lD4P+oKwe9KUVA6ztLzeU8GxH4P gQ== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3jw913g11w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 29 Sep 2022 02:57:57 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 29 Sep 2022 02:57:56 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Thu, 29 Sep 2022 02:57:56 -0700 Received: from MININT-80QBFE8.corp.innovium.com (unknown [10.28.161.88]) by maili.marvell.com (Postfix) with ESMTP id A811D3F705C; Thu, 29 Sep 2022 02:57:54 -0700 (PDT) From: To: , Ray Kinsella CC: , Pavan Nikhilesh Subject: [PATCH 3/3] doc: remove deprecation notices for event vector Date: Thu, 29 Sep 2022 15:27:48 +0530 Message-ID: <20220929095748.12563-3-pbhagavatula@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220929095748.12563-1-pbhagavatula@marvell.com> References: <20220929095748.12563-1-pbhagavatula@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: fGFDAs-1aQVH4ijVmHDehMfjkLwuOSta X-Proofpoint-ORIG-GUID: fGFDAs-1aQVH4ijVmHDehMfjkLwuOSta X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-29_05,2022-09-29_02,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Pavan Nikhilesh Deprecation notice targeted for v22.11 of event vector has been merged in the following commits, remove deprecation notices. Fixes: 7b12f13ce3ee ("eventdev: add element offset to event vector") Signed-off-by: Pavan Nikhilesh --- doc/guides/rel_notes/deprecation.rst | 7 ------- 1 file changed, 7 deletions(-) -- 2.25.1 diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index bb44b1f9ff..9679615f95 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -173,13 +173,6 @@ Deprecation Notices Event will be one of the configuration fields, together with additional vector parameters. -* eventdev: The structure ``rte_event_vector`` will be modified to include - ``elem_offset:12`` bits taken from ``rsvd:15``. The ``elem_offset`` defines - the offset into the vector array from which valid elements are present. - The difference between ``rte_event_vector::nb_elem`` and - ``rte_event_vector::elem_offset`` gives the number of valid elements left - to process from the ``rte_event_vector::elem_offset``. - * metrics: The function ``rte_metrics_init`` will have a non-void return in order to notify errors instead of calling ``rte_exit``.