From patchwork Wed Oct 5 15:23:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kevin Traynor X-Patchwork-Id: 117388 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C752A0542; Wed, 5 Oct 2022 17:24:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5AE9340694; Wed, 5 Oct 2022 17:24:44 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 28C5A40143 for ; Wed, 5 Oct 2022 17:24:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664983481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=diuykkqiJC2PyCXvVUi6vsXrC/W7ov5/VnpE2wi7Vh4=; b=MUF+seOrN1tsYv07kPT0y/Z0wydBeCfBLgsCTScod3Hht43hMMEUKl8bCpuxnm4lEcqi8o 94nfzuoVFqSwb4lAGzo079d0lBfI5vYwiiX3O8bL2RQFDndbQL/6i+p+b/bLetxIKnJ+R9 qTOeBxgLaNFlixmyxnDYkkinqqSue9M= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-595-weyA4_3WP42LgbdY_0zrgQ-1; Wed, 05 Oct 2022 11:24:36 -0400 X-MC-Unique: weyA4_3WP42LgbdY_0zrgQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0BF0E858F13; Wed, 5 Oct 2022 15:24:36 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id D00A040C83AA; Wed, 5 Oct 2022 15:24:34 +0000 (UTC) From: Kevin Traynor To: dev@dpdk.org Cc: david.marchand@redhat.com, Kevin Traynor , Tomasz Kantecki , Bruce Richardson , Dmitry Kozlyuk Subject: [PATCH] examples/l2fwd-cat: fix build Date: Wed, 5 Oct 2022 16:23:47 +0100 Message-Id: <20221005152347.330954-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org and need to be included for the build since they were removed from . ../examples/l2fwd-cat/cat.c: In function ‘parse_set’: ../examples/l2fwd-cat/cat.c:66:16: warning: implicit declaration of function ‘isblank’ [-Wimplicit-function-declaration] 66 | while (isblank(*str)) | ^~~~~~~ ../examples/l2fwd-cat/cat.c:18:1: note: include ‘’ or provide a declaration of ‘isblank’ 17 | #include "cat.h" +++ |+#include 18 | ../examples/l2fwd-cat/cat.c:70:15: warning: implicit declaration of function ‘isdigit’ [-Wimplicit-function-declaration] 70 | if ((!isdigit(*str) && *str != '(') || *str == '\0') | ^~~~~~~ ../examples/l2fwd-cat/cat.c:70:15: note: include ‘’ or provide a declaration of ‘isdigit’ ../examples/l2fwd-cat/cat.c:75:17: error: ‘errno’ undeclared (first use in this function) 75 | errno = 0; | ^~~~~ ../examples/l2fwd-cat/cat.c:18:1: note: ‘errno’ is defined in header ‘’; did you forget to ‘#include ’? 17 | #include "cat.h" +++ |+#include Fixes: 72b452c5f259 ("eal: remove unneeded includes from a public header") Signed-off-by: Kevin Traynor Reviewed-by: David Marchand --- examples/l2fwd-cat/cat.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/l2fwd-cat/cat.c b/examples/l2fwd-cat/cat.c index 77154c8b7e..00e4cde48b 100644 --- a/examples/l2fwd-cat/cat.c +++ b/examples/l2fwd-cat/cat.c @@ -3,4 +3,6 @@ */ +#include +#include #include #include