From patchwork Wed Nov 9 23:46:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 119685 X-Patchwork-Delegate: andrew.rybchenko@oktetlabs.ru Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2222EA0093; Thu, 10 Nov 2022 00:46:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 951F840156; Thu, 10 Nov 2022 00:46:56 +0100 (CET) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id 2E5FE40150 for ; Thu, 10 Nov 2022 00:46:55 +0100 (CET) Received: by mail-pf1-f173.google.com with SMTP id m6so260153pfb.0 for ; Wed, 09 Nov 2022 15:46:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e8zBhTF4zO2j18HYPLKeG1ulVs3p7/kmyKRPOQvYC/g=; b=4kBdl+CfGoAiRQE7dXy8kkocTNqH3XWFY9KduOnaKyFDrMXsBlGheHydq7ggtXWP5q zwStc5NiPhVvpjg5/3KGCNB5UcyxjmAxxyYIYpiuf4QZucqbKzBGZaZRYpz7kRinUdnn f3PYctvUUsJ35Fcb9CBgvmw6vHoDO8GEK9gg9PHw0MnpDY5qDMLUPlwwp4zeqT+0wDS4 WSVmBmdbk5Vi9HuVtzGmI0miH3G8xqAfNpU6U4OpdxydnLLCta5vafnlDVURtp9/FAjl StGH845QQdMD0FkQZbmnw3DRUiUC+gYTlO71wTNUAMeu2JRYToTgZsLauHMggltLnSn0 HMKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e8zBhTF4zO2j18HYPLKeG1ulVs3p7/kmyKRPOQvYC/g=; b=p1rwEgEqZaQF9ThABASIAOiObAy64xsNKvoua6ACDBnUIAlaD4DwDAqP5WBmAmax4O XcFJSsQONlk3g6+e3LK/MFMXYefUvSj/X7MUJtad/DY72tgj8giolmEJ0ltmZEwg7/3k ONhRt3XRLfL50Epip6npTsFtDkbQT8RZvBwtocRmuqExLw6xTsktD+Q6Q3J2G1SpCIpR XX5iVsTPA6JI1VZWp3pElMzz62wGFBZs6YtHtvAbz5FA7XFg9eOdCjUqu2kFvP++EcAf MGqW10mU4TvM6ZIZEAFeu0QeSau5BJFeEEvJw75Lg8UYxV9uIl/vLM5IgAil6sGv3tu5 y56Q== X-Gm-Message-State: ACrzQf2YkuqSB6zqW6W+Y/s3fexnUY71wQXHcWn3aoNBnhTBwo2Lr+uU HvIJH6PxgC3gpxTgBsVV+zeLVhr49PWXkQ== X-Google-Smtp-Source: AMsMyM6O3jnW/nEsWigBhHKNSNv9piA5Q5LvVtPIKpboEm6yL/FQlPqnw5iT4ViWFkyFqZLd5CHrVA== X-Received: by 2002:a65:628f:0:b0:43c:dac:646a with SMTP id f15-20020a65628f000000b0043c0dac646amr39497453pgv.397.1668037614076; Wed, 09 Nov 2022 15:46:54 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id e18-20020a63e012000000b00470275c8d6dsm7895259pgh.10.2022.11.09.15.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 15:46:53 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Junfeng Guo Subject: [PATCH 1/4] gve: remove unnecessary null checks Date: Wed, 9 Nov 2022 15:46:46 -0800 Message-Id: <20221109234649.331942-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221109234649.331942-1-stephen@networkplumber.org> References: <20221109234649.331942-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The function rte_free() already handles NULL argument; therefore the checks in this code are unnecessary. Signed-off-by: Stephen Hemminger --- drivers/net/gve/gve_ethdev.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c index 0086162f63b3..a05e61feba1f 100644 --- a/drivers/net/gve/gve_ethdev.c +++ b/drivers/net/gve/gve_ethdev.c @@ -81,12 +81,10 @@ gve_free_qpls(struct gve_priv *priv) for (i = 0; i < nb_txqs + nb_rxqs; i++) { if (priv->qpl[i].mz != NULL) rte_memzone_free(priv->qpl[i].mz); - if (priv->qpl[i].page_buses != NULL) - rte_free(priv->qpl[i].page_buses); + rte_free(priv->qpl[i].page_buses); } - if (priv->qpl != NULL) - rte_free(priv->qpl); + rte_free(priv->qpl); } static int From patchwork Wed Nov 9 23:46:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 119686 X-Patchwork-Delegate: andrew.rybchenko@oktetlabs.ru Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2A03A0093; Thu, 10 Nov 2022 00:47:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73767410E7; Thu, 10 Nov 2022 00:46:58 +0100 (CET) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by mails.dpdk.org (Postfix) with ESMTP id 63DFC40156 for ; Thu, 10 Nov 2022 00:46:56 +0100 (CET) Received: by mail-pj1-f52.google.com with SMTP id c15-20020a17090a1d0f00b0021365864446so191591pjd.4 for ; Wed, 09 Nov 2022 15:46:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j5co4SVnDs+RMKfasJ46cav5do5uDqVp8PfISy2ngLc=; b=cUxEAUMSHfqKrKq5ViYWMKLtiIU6UzvR79owJcWdvH8Q8IUazIuSPQbeN998Vxsr17 DO9KhGuGyOxjdwFsMAf6/xeqouyKnS/C7SqpCyyV9thMqnZCO2239GkiA9KjmceGFwGf ZttdE/t0M3kco0FgwkdbQ11IwoWPJLOwY9FSTp4IACdwdZJTKOUOM237EN1/aC5ho1EK kVBjEX7RXf5qBr+DJGKABL4cLkQuHcirad8qeo3mmKULdsV+Ke4/PCKDo9x1XiBRnbJW E15/aVJiWEZ2hMDlzRWCDx1+AnfF5P54uXFAeMH+OLHcAA9lvct2+DRSEW0VjRFeGeFO k7tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j5co4SVnDs+RMKfasJ46cav5do5uDqVp8PfISy2ngLc=; b=W2kRbRbjUO3UDr8tUnqaE1qS2J+PR9YZ3pnj/rlmuKf0ideIzvEy6VeWYEOlvJ7y5H lU1EucAjxwRP3jSFqYlZehP9etA/ujqFT9aoOOIThtKZOK643OC+BcLABXPOIVeicWbk D9cPlhPiIHhICPSy3Lx4tyBLiMxNFVPhVKleqofJT52w0qeKmdPxlbiOYOIAJDTFG1Jo IcWV82O3f771O83xEr/xv7psGPa6l9Dn6rH2DxQl68EbtaB0XHsWcl+LwwBY5WO983vn 73Kz4Bph3jFMQLV/LvADsh+ixcnz19bcIUsD07h9fRTIMklpKv2Wwis4RPPnHXWeEA7/ 289w== X-Gm-Message-State: ACrzQf3DY9O++NJ1vMZNYbPcfzBnZflV9UsBXRvEmS2eRZZ0IZfcRan/ BKP6D9C5XSD1F5D5WTIajd4X2YBkNY4WpA== X-Google-Smtp-Source: AMsMyM4WLTZEBByqw+C39aIUOLo6mMUBRvP507tzaaTFKQGcOJOTNVyGr30yy0G7YRty+/xafgai6w== X-Received: by 2002:a17:90a:d586:b0:213:de8f:4d6 with SMTP id v6-20020a17090ad58600b00213de8f04d6mr56551296pju.31.1668037615263; Wed, 09 Nov 2022 15:46:55 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id e18-20020a63e012000000b00470275c8d6dsm7895259pgh.10.2022.11.09.15.46.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 15:46:54 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Matan Azrad , Viacheslav Ovsiienko Subject: [PATCH 2/4] mlx5: remove unnecessary null checks Date: Wed, 9 Nov 2022 15:46:47 -0800 Message-Id: <20221109234649.331942-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221109234649.331942-1-stephen@networkplumber.org> References: <20221109234649.331942-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The function rte_free() already handles NULL argument; therefore the checks in this code are unnecessary. Signed-off-by: Stephen Hemminger --- drivers/net/mlx5/hws/mlx5dr_pool.c | 3 +-- drivers/net/mlx5/mlx5_flow_hw.c | 6 ++---- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_pool.c b/drivers/net/mlx5/hws/mlx5dr_pool.c index 2bfda5b4a5be..fdbd3d438d08 100644 --- a/drivers/net/mlx5/hws/mlx5dr_pool.c +++ b/drivers/net/mlx5/hws/mlx5dr_pool.c @@ -537,8 +537,7 @@ static void mlx5dr_onesize_element_db_uninit(struct mlx5dr_pool *pool) for (i = 0; i < MLX5DR_POOL_RESOURCE_ARR_SZ; i++) { elem = pool->db.element_manager->elements[i]; if (elem) { - if (elem->bitmap) - rte_free(elem->bitmap); + rte_free(elem->bitmap); simple_free(elem); pool->db.element_manager->elements[i] = NULL; } diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 2d275ad11127..bea7805ee267 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -7063,10 +7063,8 @@ flow_hw_configure(struct rte_eth_dev *dev, if (dr_ctx) claim_zero(mlx5dr_context_close(dr_ctx)); for (i = 0; i < nb_q_updated; i++) { - if (priv->hw_q[i].indir_iq) - rte_ring_free(priv->hw_q[i].indir_iq); - if (priv->hw_q[i].indir_cq) - rte_ring_free(priv->hw_q[i].indir_cq); + rte_ring_free(priv->hw_q[i].indir_iq); + rte_ring_free(priv->hw_q[i].indir_cq); } mlx5_free(priv->hw_q); priv->hw_q = NULL; From patchwork Wed Nov 9 23:46:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 119687 X-Patchwork-Delegate: andrew.rybchenko@oktetlabs.ru Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62392A0093; Thu, 10 Nov 2022 00:47:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 40D6942D0C; Thu, 10 Nov 2022 00:46:59 +0100 (CET) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id 9D857400D4 for ; Thu, 10 Nov 2022 00:46:57 +0100 (CET) Received: by mail-pj1-f48.google.com with SMTP id l22-20020a17090a3f1600b00212fbbcfb78so3330055pjc.3 for ; Wed, 09 Nov 2022 15:46:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/sluQM/YR/JUUSXg8kIj5TtFEM3ub/Ak2m/Sv78jozs=; b=wjqj8iDiNgQ2mug5zI+9Ii1Jvo1wubU+2igAvGOokwniCP1a7FXAGcKBOkDQm5E7tJ t6YQZAf6XvfQbyUgCD2m1zsD6LfC8fUsFDXkFJx6tpcy2fidc6iMC290VRlrlbOnaUus YQy3gfIySDHhGI0xpnRQvdzTrH4DpAfychTB/gx1z8np7WQam5jUIMpVrvZMFiZ59K9/ OGSDFqoa+x2oCEa3vXZFIxY5g7HeMZovFbkbhuWvs7eZ3sxSuzAWM7P+onahb2QFuUYh USxdmHl1ogTNDLOb2u2HRrUIxqXnEhr40SRUg/neEE/wOunAMPbFYmTg3sZnL3rcU4Py /Fcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/sluQM/YR/JUUSXg8kIj5TtFEM3ub/Ak2m/Sv78jozs=; b=ecw44+5/gmAPyeVupvI8W0Cp4WPBlAsLx0o0VA2YiKv3wroWlZzk3jX9O7oTkHwvhK nFBQv2SZMBKeLVPK4p9n66jYkfN8qu47JpRedoPiL2Rm5IMSeMi5EvWQxBtD5uTDAENm dh4YLPcH0FDpqSKxByEs2wn1wYwwdAFnbOuJbt20cSjqAd0PVzd8pRFmby2tPTpGAel9 ezdvIH4e2k1Z5YQeO/AO183Ck7A7eeJ8G0QnUdhC2kYzXCy8qjnsyLqgHAGyDDac+oo8 viaoj3V1XK6xuK4ABnvcUki4tDFNONw7PYS5gwpCz+7zMV2oROmtRysYyaqvl4nH+xoN H/mA== X-Gm-Message-State: ACrzQf0zBB5jgad5nKLEo2XHeTSnRalBpuPqiKwD8i23BybC5SzfGdAc sM0+nh2zbd/aC/CWZ+5D7Vfsi2jOUS4Jnw== X-Google-Smtp-Source: AMsMyM5lj2E8XKuVvtFC+cl45TQZL1N3XRAFUVKqO7WbnAhu7L8FfM4YijP7D/H+UJZWgsvxqoL5xQ== X-Received: by 2002:a17:90a:520c:b0:212:d135:4471 with SMTP id v12-20020a17090a520c00b00212d1354471mr83695244pjh.71.1668037616498; Wed, 09 Nov 2022 15:46:56 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id e18-20020a63e012000000b00470275c8d6dsm7895259pgh.10.2022.11.09.15.46.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 15:46:55 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jingjing Wu , Beilei Xing Subject: [PATCH 3/4] idpf: remvoee unnecessary null checks Date: Wed, 9 Nov 2022 15:46:48 -0800 Message-Id: <20221109234649.331942-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221109234649.331942-1-stephen@networkplumber.org> References: <20221109234649.331942-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The function rte_free() already handles NULL argument; therefore the checks in this code are unnecessary. Signed-off-by: Stephen Hemminger --- drivers/net/idpf/idpf_rxtx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/idpf/idpf_rxtx.c b/drivers/net/idpf/idpf_rxtx.c index bafa007faf85..b1f58089e031 100644 --- a/drivers/net/idpf/idpf_rxtx.c +++ b/drivers/net/idpf/idpf_rxtx.c @@ -251,8 +251,7 @@ reset_single_rx_queue(struct idpf_rx_queue *rxq) rxq->rx_tail = 0; rxq->nb_rx_hold = 0; - if (rxq->pkt_first_seg != NULL) - rte_pktmbuf_free(rxq->pkt_first_seg); + rte_pktmbuf_free(rxq->pkt_first_seg); rxq->pkt_first_seg = NULL; rxq->pkt_last_seg = NULL; From patchwork Wed Nov 9 23:46:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 119688 X-Patchwork-Delegate: andrew.rybchenko@oktetlabs.ru Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7E2FA0093; Thu, 10 Nov 2022 00:47:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21FFF42D15; Thu, 10 Nov 2022 00:47:01 +0100 (CET) Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by mails.dpdk.org (Postfix) with ESMTP id D51A14114A for ; Thu, 10 Nov 2022 00:46:58 +0100 (CET) Received: by mail-pg1-f182.google.com with SMTP id h193so97749pgc.10 for ; Wed, 09 Nov 2022 15:46:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nmrm3b9OhvEkvfnTnYQjrjZdM1u7QDkj4LQSw7hPXdc=; b=59W/cEEqMZQISAFdeh6T2rYAoS7JliGloL+ZzIPYGi1QiKYugjWurl4vDPmovY/VZ0 XmBOjjBhYvrCnUbtU8r5DS10bzq/1GXLGgs7rnD/HV5hpSIgnFUqZve3ObO4KTsN0p2j K7DeKaWdElNvv/psMnucCMRrA6PxtzGvHBChbHA6VpYdnbvIQr25iBnRSMTqJJvIuzB8 sqQpWS6RyY+2fwExPYqftKtYZJqQVekvpiy5NHDMxR/io3s+cqv08vx4foJStXp/ijox ubsueNY4fEFZC60YwArsosycxZaB5BpeEdWwzhylc+oEVDnl7VwFjjKeb0LwmxIyXksq UnIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nmrm3b9OhvEkvfnTnYQjrjZdM1u7QDkj4LQSw7hPXdc=; b=wZJL5GByxb7upOg0x/yHgC/doAW69IFS35bQ6RnaMduI19VuX0ZrFuucHce6gwtTzF fUKuohtAAprn3pG/Tx7TwiFhyh7oIfoUUa3kmDJPvc/L8InIEVbu9ilWo9sdkvRnVGFs N3RhkvZaz/ANGLjAEZ0JwYDbofkaJaLBeZELbielKnK2+xHyrCAEZedfsANUL1MlktN5 54QubXglChm6eLwYVSK0D7rAW5AeEmW+zHXRs02oREB/5wKIQSQI8eX/aguAj7k2px6L oRvBGKOy85o+lodumfS2ekZuMIOpm2EN37EUbflPGwVH40b1Bhk+pB7lAJaJ1Ohqx+ka 4C+g== X-Gm-Message-State: ACrzQf2Hy6jSoh3JWiiWCjiSpQtPk/IE7jlNTIVH1kPRDNVROIRptrtN veBk4dKg033Wl8RiN1TokomR5qjazfIUeA== X-Google-Smtp-Source: AMsMyM5DBBQCPaqjHvpMhIPCrrmLaQiR0sBJ/3r9NQW83QebeTqehdp3fAoYT0LkLyVnpEay7STwBg== X-Received: by 2002:a05:6a00:848:b0:56e:4e85:33fc with SMTP id q8-20020a056a00084800b0056e4e8533fcmr35049081pfk.40.1668037617729; Wed, 09 Nov 2022 15:46:57 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id e18-20020a63e012000000b00470275c8d6dsm7895259pgh.10.2022.11.09.15.46.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 15:46:57 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , David Hunt , Brian Dooley Subject: [PATCH 4/4] examples: remove unnecessary null checks Date: Wed, 9 Nov 2022 15:46:49 -0800 Message-Id: <20221109234649.331942-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221109234649.331942-1-stephen@networkplumber.org> References: <20221109234649.331942-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The function rte_free() already handles NULL argument; therefore the checks in this code are unnecessary. Signed-off-by: Stephen Hemminger Acked-by: Brian Dooley --- examples/distributor/main.c | 3 +-- examples/fips_validation/main.c | 15 +++++---------- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index e767973ed8de..21304d661873 100644 --- a/examples/distributor/main.c +++ b/examples/distributor/main.c @@ -1017,8 +1017,7 @@ main(int argc, char *argv[]) print_stats(); - if (pd) - rte_free(pd); + rte_free(pd); rte_free(pr); /* clean up the EAL */ diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c index 40a5b70e073b..73caaffb7e7a 100644 --- a/examples/fips_validation/main.c +++ b/examples/fips_validation/main.c @@ -962,8 +962,7 @@ prepare_rsa_op(void) asym->rsa.message.data = msg.val; asym->rsa.message.length = msg.len; - if (vec.rsa.signature.val) - rte_free(vec.rsa.signature.val); + rte_free(vec.rsa.signature.val); vec.rsa.signature.val = rte_zmalloc(NULL, vec.rsa.n.len, 0); vec.rsa.signature.len = vec.rsa.n.len; @@ -1011,11 +1010,9 @@ prepare_ecdsa_op(void) asym->ecdsa.k.data = vec.ecdsa.k.val; asym->ecdsa.k.length = vec.ecdsa.k.len; - if (vec.ecdsa.r.val) - rte_free(vec.ecdsa.r.val); + rte_free(vec.ecdsa.r.val); - if (vec.ecdsa.s.val) - rte_free(vec.ecdsa.s.val); + rte_free(vec.ecdsa.s.val); vec.ecdsa.r.len = info.interim_info.ecdsa_data.curve_len; vec.ecdsa.r.val = rte_zmalloc(NULL, vec.ecdsa.r.len, 0); @@ -1060,11 +1057,9 @@ prepare_ecfpm_op(void) asym->ecpm.scalar.data = vec.ecdsa.pkey.val; asym->ecpm.scalar.length = vec.ecdsa.pkey.len; - if (vec.ecdsa.qx.val) - rte_free(vec.ecdsa.qx.val); + rte_free(vec.ecdsa.qx.val); - if (vec.ecdsa.qy.val) - rte_free(vec.ecdsa.qy.val); + rte_free(vec.ecdsa.qy.val); vec.ecdsa.qx.len = info.interim_info.ecdsa_data.curve_len; vec.ecdsa.qx.val = rte_zmalloc(NULL, vec.ecdsa.qx.len, 0);