From patchwork Wed Jun 27 09:20:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrien Mazarguil X-Patchwork-Id: 41646 X-Patchwork-Delegate: shahafs@mellanox.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D9C881BDE1; Wed, 27 Jun 2018 11:21:09 +0200 (CEST) Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 25B4F1BDCD for ; Wed, 27 Jun 2018 11:21:09 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id v16-v6so4955025wmv.5 for ; Wed, 27 Jun 2018 02:21:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=aLBlDjyS5LwDQaZiwwwbIkRNApVTKTI/oO6PcJmhR7g=; b=xO+NeYguOnVlwNAR+y+2s+gCMoc20Gdh/rEOo2NyJpNdJQQiJtFUiMBwvRcNY0b7vl PH8cWEfM2Tknr5hW+fT0pgZXlpG2IOBhTNHQ6B1pEBNKXItFmpdu1nRPSxVXUF//vwMS MVe9P/ignUG/jte3ngxQDs/VBumhZY+tUB9Wa7Pxinr0u1WHYJyX8mNLP1o8UVE3g0g7 jgNVc0n0UyTB+BjBIbIaj937K9NuhLSyXZwHi1wB8g+6g4QaAaMzrAjP0PP3CJdo1wjW gMNNBghsjBiA3bIoPnCvD2k4GUJbOpPdaWmJYV6xnNeqEuzPxoNUwkvEcBh3APjTMVD5 24FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=aLBlDjyS5LwDQaZiwwwbIkRNApVTKTI/oO6PcJmhR7g=; b=BfGhiWSgV0PIGW1Tq0Pb2rI43fcem84tOCTaKZeubjU9mEMpDwcZx8NoVVmVGQFsbk Oeoi+6QJcD7ZlYI8lfHVrqYTP3VLHOzBCNUzuGc6rAXfX++S0ePqhKR9QRLG/7ye/bAW nQL4XgF0fBOoeSWEGYx2n47NZLCJU6E+Pu6HV5CU0zVIh0iG6ITz4NgO/w8HVFrUqvxU ZBH30xA5QdQHXbRXoMdMLmgx3u5e9ctqzvLZFdmhhT2M90yLYantJjP2qCm0/raZm4SQ h/KAHfrt+gorWRKdVgkw8Ka+gfJ/qeZ7wV0K+oMc1sOuzQcW7ehKX2FqDutKeFZJZuRY ks9Q== X-Gm-Message-State: APt69E3TUv7UP6IRbv0wBPlY0Ao3Maq7GWVNYnVPJQNVLWjUPHcoDba2 3vpixnmYsKs9Lse2rj6+ooH55w== X-Google-Smtp-Source: AAOMgpceJ9s2NtqNU57qHGjPPleVzojjIFLUy8To0O8lnY2/LlRgdEtiLQfwo9xz9XcT3m9J665NXw== X-Received: by 2002:a1c:7141:: with SMTP id m62-v6mr4165621wmc.157.1530091268917; Wed, 27 Jun 2018 02:21:08 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 14-v6sm5124647wmh.8.2018.06.27.02.21.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Jun 2018 02:21:08 -0700 (PDT) Date: Wed, 27 Jun 2018 11:20:52 +0200 From: Adrien Mazarguil To: Shahaf Shuler Cc: dev@dpdk.org, Nelio Laranjeiro , stable@dpdk.org Message-ID: <20180627091909.22689-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH] net/mlx5: fix invalid error check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since its return type is unsigned, if_nametoindex() returns 0 in case of error, never -1. Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses") Cc: Nelio Laranjeiro Cc: stable@dpdk.org Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 90488af33..ebe5cb6e3 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -192,13 +192,13 @@ int mlx5_ifindex(const struct rte_eth_dev *dev) { char ifname[IF_NAMESIZE]; - int ret; + unsigned int ret; ret = mlx5_get_ifname(dev, &ifname); if (ret) return ret; ret = if_nametoindex(ifname); - if (ret == -1) { + if (ret == 0) { rte_errno = errno; return -rte_errno; }