From patchwork Fri Nov 11 06:37:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Du, Frank" X-Patchwork-Id: 119754 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47BE7A0542; Fri, 11 Nov 2022 07:47:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D956D40141; Fri, 11 Nov 2022 07:47:14 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id D1B6D400EF for ; Fri, 11 Nov 2022 07:47:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668149233; x=1699685233; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=bjxY7rW3uGN6pzfkbXDPDU6RPguA8eROKSzxqEL7KhY=; b=BwOvO/hsNjASFxZgwSZU1sOkQyOHyfWpePWcImSbl00Qr2fFTg5jcbfc QYkAqcdln46nkc9Ju8yK7V5/hvCnUhgTmlD8lZyQ6EBnp8ZGU7YgfbAcq 5oNPAPorjIaMdOqhP/CuI3LnQEFDftqkFBtlXQvdbudGXZGWScytWmTNa 8R4lRFxbMixVy3LBstlUy1t648L737K4neClSWhK/h6bRmtm2tAhskGlr M0JW0VyeYBaR5POGWfl0YH4GaM2l9f4ZcAYj74x6BASytNHasiLnJlfBm 2tml5PD+SS14bU667Dyp3VXSyX5kUAsUb+f7dxWRdy2Uo2E6cNd0+6bhs g==; X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="338305158" X-IronPort-AV: E=Sophos;i="5.96,156,1665471600"; d="scan'208";a="338305158" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2022 22:47:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="588469379" X-IronPort-AV: E=Sophos;i="5.96,156,1665471600"; d="scan'208";a="588469379" Received: from media-frankdu-kahawai-node2.sh.intel.com ([10.67.119.73]) by orsmga003.jf.intel.com with ESMTP; 10 Nov 2022 22:47:10 -0800 From: "Du, Frank" To: dev@dpdk.org Subject: [PATCH v2] net/ice: fix ice_interrupt_handler panic when stop Date: Fri, 11 Nov 2022 14:37:29 +0800 Message-Id: <20221111063729.874731-1-frank.du@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221111062219.874370-1-frank.du@intel.com> References: <20221111062219.874370-1-frank.du@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org rte_intr_callback_unregister may fail when irq cb is in handling, use sync version to make sure unregister successfully. Signed-off-by: Du, Frank --- drivers/net/ice/ice_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 7294f38edc..b7ce6b053f 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -2596,8 +2596,8 @@ ice_dev_close(struct rte_eth_dev *dev) rte_intr_disable(intr_handle); /* unregister callback func from eal lib */ - rte_intr_callback_unregister(intr_handle, - ice_interrupt_handler, dev); + rte_intr_callback_unregister_sync(intr_handle, + ice_interrupt_handler, dev); return ret; }