From patchwork Tue Nov 15 07:42:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, HongboX" X-Patchwork-Id: 119864 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2768A0547; Tue, 15 Nov 2022 09:41:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B98540DFD; Tue, 15 Nov 2022 09:41:49 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id AC4FB40150 for ; Tue, 15 Nov 2022 09:41:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668501707; x=1700037707; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=FdjFoMIHlgpf83yV7Lv2W6Y4Rrm8IAszQeRByNMJFvM=; b=S8xp89LFtK7PZ/AxlxSpAyZNHhUKmoxTbSnGhwsKt/NXY6tbCNYm4e/q Q14i7ZngbpFydehN3qp0Nl45vUpbJkaWxK+e0o5QI+e41Q5fOcoExFBVO Gfmd95anPcNj2AxF0yejaUZ8onsD4UgSgZi2SgK+8irCUb5/Ki23Nvyu4 0Cdoh6moXuyoy0TBNRpeQTNb/AlI9hgt8C8zQgh56GJ/VQ2TYwgaOEYPn 6S2UglQtnIWEs0kZ9Hj6S5Fw0K5cFhdVUNS+J+INFFdyezlB8lW4GxxyC dxvBP2AH1BIEYUqcB4m1vmoTKSfj3/qizEb23PLG7evQKHytNkdW76xcf A==; X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="313348047" X-IronPort-AV: E=Sophos;i="5.96,165,1665471600"; d="scan'208";a="313348047" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2022 00:41:46 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="671919114" X-IronPort-AV: E=Sophos;i="5.96,165,1665471600"; d="scan'208";a="671919114" Received: from unknown (HELO localhost.localdomain) ([10.239.252.19]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2022 00:41:45 -0800 From: Hongbo Li To: dts@dpdk.org Cc: Hongbo Li Subject: [dts] [PATCH V1 1/3] tests/ice_iavf_fdir: optimize scripts Date: Tue, 15 Nov 2022 07:42:12 +0000 Message-Id: <20221115074214.62185-1-hongbox.li@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org when the dpdk testpmd exits abnormally, the port will not be initialized, and sometimes the test of other cases will be affected. therefore, after the test, should use quit to close the dpdk testpmd normally to avoid the impact between cases. Signed-off-by: Hongbo Li --- tests/TestSuite_ice_iavf_fdir.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/TestSuite_ice_iavf_fdir.py b/tests/TestSuite_ice_iavf_fdir.py index d6ca832a..b7954784 100644 --- a/tests/TestSuite_ice_iavf_fdir.py +++ b/tests/TestSuite_ice_iavf_fdir.py @@ -11932,12 +11932,12 @@ class TestICEIAVFFdir(TestCase): "test_mac_ipv6_multicast_protocol", ]: self.pmd_output.execute_cmd("mcast_addr remove 0 11:22:33:44:55:66") - self.destroy_env() - self.dut.kill_all() if getattr(self, "session_secondary", None): self.dut.close_session(self.session_secondary) if getattr(self, "session_third", None): self.dut.close_session(self.session_third) + self.destroy_env() + self.dut.kill_all() if self.running_case in [ "test_pfcp_vlan_strip_off_sw_checksum", From patchwork Tue Nov 15 07:42:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, HongboX" X-Patchwork-Id: 119865 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6393A0547; Tue, 15 Nov 2022 09:42:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B0B2C410D3; Tue, 15 Nov 2022 09:42:02 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 50CE340F18 for ; Tue, 15 Nov 2022 09:42:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668501720; x=1700037720; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4kYvU4kl5RfNEIydJTQP4UxSGu9CzrUpiCBxieszzwg=; b=iVFsqClRFg1pNS/YLbkYNps2/W/2epZdaoZ0IQr1WF08QeYzbgwPjkHu tKd/txFGgbTULEp8UNGM40V2NUcbxIUVMEKVKOiaeo9QJXPUK4gUvVLZD zuRynLRKA/P/xVAgWMY/N+qIlS6YTY8Fox3hsuO0EocL7ALDzfOziVHNG kU0ZpH71RRxGUFpmrJYhIWlguQ+0RHjLDI2pw4OWkfQtCDyurM8Kkq2hl WMgg+w/59NXJ2GxgiP5ShUUZVhzNDBc+bs/Hc5IcCstG2QRdmFV7mBaeB zJxFvW1aRF/VdH/YIjHXxnkHXbDXhUu8Meiwg4f2jThLiYX4DJscbRCR4 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="312203181" X-IronPort-AV: E=Sophos;i="5.96,165,1665471600"; d="scan'208";a="312203181" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2022 00:41:59 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="671919162" X-IronPort-AV: E=Sophos;i="5.96,165,1665471600"; d="scan'208";a="671919162" Received: from unknown (HELO localhost.localdomain) ([10.239.252.19]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2022 00:41:58 -0800 From: Hongbo Li To: dts@dpdk.org Cc: Hongbo Li Subject: [dts] [PATCH V1 2/3] tests/ice_fdir: optimize scripts Date: Tue, 15 Nov 2022 07:42:13 +0000 Message-Id: <20221115074214.62185-2-hongbox.li@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221115074214.62185-1-hongbox.li@intel.com> References: <20221115074214.62185-1-hongbox.li@intel.com> MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org when the dpdk testpmd exits abnormally, the port will not be initialized, and sometimes the test of other cases will be affected. therefore, after the test, should use quit to close the dpdk testpmd normally to avoid the impact between cases. Signed-off-by: Hongbo Li --- tests/TestSuite_ice_fdir.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/TestSuite_ice_fdir.py b/tests/TestSuite_ice_fdir.py index fac65fda..b0fd8207 100644 --- a/tests/TestSuite_ice_fdir.py +++ b/tests/TestSuite_ice_fdir.py @@ -4517,4 +4517,5 @@ class TestICEFdir(TestCase): self.launch_testpmd_with_mark() def tear_down_all(self): + self.pmd_output.quit() self.dut.kill_all() From patchwork Tue Nov 15 07:42:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, HongboX" X-Patchwork-Id: 119866 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE2AEA0548; Tue, 15 Nov 2022 09:42:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9F81410F2; Tue, 15 Nov 2022 09:42:03 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 6768C40F18 for ; Tue, 15 Nov 2022 09:42:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668501722; x=1700037722; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=inTpYHe3UuVG9ZQOiQcuNmWIgKNdJd4xUbFy7gPWmNM=; b=H1GWnXKWd5wAms84X2TW21wTvQ8qibI0Vq7Rl2/QftNPPeUIl0S9iwsf crMEAp+zYqkdJ893PiTX2keI/6jOpXBi7SxdjiKROL2FkbdIeE96RhhMr WSH7DcgiJlESvQb2UxkololmGkcqDqhKos0ZaLQJ9NmN2T8en8IHCIApb ko2rA8Lktc4BdtxDj4/3uEcMLpicWxhbap0StrIRPCTf0+h77zJHtNCf4 FQVkeAfd7cqYqaWaCi7vlw00kLxkw45OeLCHKsWI1QkrcLA5wNppCsSna DHeDDgJ+WmJRNyjOigXXFoXW9OtDmHfMX4pZw6lWg0Px2TknanJpbn0VD Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="312203188" X-IronPort-AV: E=Sophos;i="5.96,165,1665471600"; d="scan'208";a="312203188" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2022 00:42:01 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="671919194" X-IronPort-AV: E=Sophos;i="5.96,165,1665471600"; d="scan'208";a="671919194" Received: from unknown (HELO localhost.localdomain) ([10.239.252.19]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2022 00:42:00 -0800 From: Hongbo Li To: dts@dpdk.org Cc: Hongbo Li Subject: [dts] [PATCH V1 3/3] tests/ice_limit_value_test: optimize scripts Date: Tue, 15 Nov 2022 07:42:14 +0000 Message-Id: <20221115074214.62185-3-hongbox.li@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221115074214.62185-1-hongbox.li@intel.com> References: <20221115074214.62185-1-hongbox.li@intel.com> MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org 1.when the dpdk testpmd exits abnormally, the port will not be initialized, and sometimes the test of other cases will be affected. therefore, after the test, should use quit to close the dpdk testpmd normally to avoid the impact between cases. 2.the object named "self.session_third" is undefined, delete useless code. Signed-off-by: Hongbo Li Tested-by: Song Jiale --- tests/TestSuite_ice_limit_value_test.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/TestSuite_ice_limit_value_test.py b/tests/TestSuite_ice_limit_value_test.py index b75cea84..b5bc6dc2 100644 --- a/tests/TestSuite_ice_limit_value_test.py +++ b/tests/TestSuite_ice_limit_value_test.py @@ -1256,13 +1256,10 @@ class TestICELimitValue(TestCase): def tear_down(self): # destroy all flow rule on port 0 - self.dut.kill_all() - self.destroy_env() if getattr(self, "session_secondary", None): self.dut.close_session(self.session_secondary) - if getattr(self, "session_third", None): - self.dut.close_session(self.session_third) + self.destroy_env() + self.dut.kill_all() def tear_down_all(self): self.dut.kill_all() - self.destroy_env()