From patchwork Wed Nov 23 12:42:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuang Han X-Patchwork-Id: 120118 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C1DAA0093; Wed, 23 Nov 2022 13:42:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0BED542D91; Wed, 23 Nov 2022 13:42:29 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id C777440E5A for ; Wed, 23 Nov 2022 13:42:27 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id y10so15334195plp.3 for ; Wed, 23 Nov 2022 04:42:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zPA+rivtr10Rfr98vr6cfuwOmUL99z3eB/0+ZAgie68=; b=AvLpxtlwSvZ6XOALk/TtLg4ZGatxekxtKloO8wUjQzaJIqNxXIp9QZaI5qxZuLcDXE pk7f/YWzKmg13QNgmohc9Jy38HbLBk3/Hj4tKl9uOQvxS+SvHYyUx5v3gR65v3gIFk2B kPFxRUlGpsQxmnUpunRY1G+Q8OolCb8xCrwRtc8xh0/f3mKQ5TDOKm3EOlsj6vTZUEzL ho2NhhCQ17fEQbjAtVKVfdKxvrvQbLZQXn0HUPCAvfxxYL0gn7nK1iHPOWb37+YMkwvK ZnyflfU23MVJZVN4ymzUwrkq4QBF8bPByAZWr2+Eiqyw6H+fKUTSlImwcDKhhXsGQ3ra p+Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zPA+rivtr10Rfr98vr6cfuwOmUL99z3eB/0+ZAgie68=; b=lAKDTAZcCAjDjDir8nf7EFmjl0mu1csT3gl51eJVruCcki4IdBfc3bBWTzT7Mbn/Ny pzdol3P6XgXMmxTriaxV38gbDlXY4BNKhJuyoMFrDlzBv2PJpNbqI3ju48z6HTrLSGX0 5XRqpQSW2lqPvVdNsAvqKjYoivSPgtjKHiTGwTIuZvx7mdZ1j3GUC0dCf2MLrlTXvAd1 VBOAUysySbODshvoDq7FIzZ77rIRtFVTORS71V9r3Pc8nK/qzIw75SrpNzu+0ddFbtUu x4BvFJ2tbImRxYxBt4DgQxM5wLySbAFEhKw9AiPAPGG6Lgxb5BFwClaQjA6g+VzBlkjh ouiQ== X-Gm-Message-State: ANoB5pmgNTkJsMK0d2Zs65KVcFsiAePGgquvUZ9B8FykzpNDUOjXYwck MnkR0XbgkVoo4VycQXaffVN3rwJUlv8YxDpImuU= X-Google-Smtp-Source: AA0mqf7WGhLBbVzYO1+WOEzzViMCg2XFge+MwgrWUUWiZEi2JVZaz1J7NjAv1yltSqJUu3IB42Y1aA== X-Received: by 2002:a17:90a:2c43:b0:213:f0bb:a44d with SMTP id p3-20020a17090a2c4300b00213f0bba44dmr36385425pjm.237.1669207346806; Wed, 23 Nov 2022 04:42:26 -0800 (PST) Received: from localhost ([168.70.103.235]) by smtp.gmail.com with ESMTPSA id d4-20020a170902654400b00186a2274382sm14094831pln.76.2022.11.23.04.42.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Nov 2022 04:42:26 -0800 (PST) From: Shuang Han To: dev@dpdk.org Cc: qiming.yang@intel.com, qi.z.zhang@intel.com, Shuang Han Subject: [PATCH] net/ice: fix link status error when dev start Date: Wed, 23 Nov 2022 12:42:13 +0000 Message-Id: <1669207333-8769-1-git-send-email-hanshuang87@gmail.com> X-Mailer: git-send-email 1.8.3.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org ice_link_update get port link status and wait for one second when dev start. If the device need almost one second for link up, ice_link_update will enter the last rte_delay_ms(CHECK_INTERVAL) with link down, in the meantime link interrupt raised, the interrupt handler update dev->data->dev_link to up. After a while the rte_delay_ms(CHECK_INTERVAL) finished and update dev->data->dev_link to down. Signed-off-by: Shuang Han --- drivers/net/ice/ice_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 0bc739d..316ba5a 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -4013,9 +4013,9 @@ static int ice_init_rss(struct ice_pf *pf) RTE_ETH_LINK_SPEED_FIXED); out: - ice_atomic_write_link_status(dev, &link); if (link.link_status == old.link_status) return -1; + ice_atomic_write_link_status(dev, &link); return 0; }