From patchwork Thu Nov 24 14:26:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 120130 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D73EAA00C3; Thu, 24 Nov 2022 15:27:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B8F9042DC8; Thu, 24 Nov 2022 15:27:11 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 45D8942DC3 for ; Thu, 24 Nov 2022 15:27:10 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 74B945C012A; Thu, 24 Nov 2022 09:27:09 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 24 Nov 2022 09:27:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1669300029; x=1669386429; bh=AF HEJOYuLkj4AO/4Ct64DqYwa0nNuCH+TPo88YSi1nA=; b=dP2tWtEgCGioxDayYC 6EgQg7XMi8TKSOTUWnr7w4WOqDqv1hjeXsWPlLMRTdXb/7ACsEmCVWzxh4oP+8QI 9WIG8tfMMVj8EfOQ22GOm/i5AV308IpFvJYIOQ+wg461bLtAtBC+Ywnb5Ga4ElGh JPB+pzPKyPyGJwRTdf8h6SuFHDOvyNnQDCcmsfadiMwXK+mnuN3+DcMmySTAisqt xXpzviFqPEMUV1FZ5A+EUSOb4tzLdUBID3IAofAwgMMyf+6Ku7hARy+hsSFUyZLi szEYkjlfwbAqthpYoPUtCHMXnnhotUFaONCk/+uxaU/LA482nKxG2VfvHmkGxQuN NmNg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1669300029; x=1669386429; bh=AFHEJOYuLkj4A O/4Ct64DqYwa0nNuCH+TPo88YSi1nA=; b=J9dEiIHVStxJIhZe72yc/lwxCzANI 3wWouY6iA/a40LPfmJV8+dFAA8cjrhdpKSVXWRuAyQcfqzMhvrvuMS0rfhB3Ldnh HbNHCzuL1l9JIj5SMZ7d+YbAkqj/45zjvqgvcj7Rvzb5EzmLEBStIbQXSQ9gVGWY nVpUPdEqwyu8MiQM1iFJBVROj598TfAjwgl7YrGr57dgbD+H1oSyix487IxMJWvN tr4HmgK4nJEfsyyIQGVeBmar2eVbOWhyxxwvWX8TH0fR6JpbUHXn3SKYEWY3c3IJ G1pPOWZT9YPSUnpwTU5eWZ2Ce/dvR7w8aU4OzeC5QBwZugubxuXkv2agg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrieefgdeigecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvdejhfdugeehvddtieejieegteeuudfgjeeukeeiledthfetveek hefhieelhfdtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 24 Nov 2022 09:27:08 -0500 (EST) From: Thomas Monjalon To: dev@dpdk.org Cc: Ori Kam , Ferruh Yigit , Andrew Rybchenko Subject: [PATCH 1/2] doc: update deprecation notice of legacy flow actions Date: Thu, 24 Nov 2022 15:26:58 +0100 Message-Id: <20221124142659.3350953-2-thomas@monjalon.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20221124142659.3350953-1-thomas@monjalon.net> References: <20221124142659.3350953-1-thomas@monjalon.net> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The legacy flow actions, replaced with the more generic modify action, are not completely replaced yet in DPDK 22.11. The plan needs to be updated for this release, and a new plan must be precised during the next release. Signed-off-by: Thomas Monjalon --- doc/guides/rel_notes/deprecation.rst | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index e2efa2f8b0..8e4b1c08ff 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -54,9 +54,6 @@ Deprecation Notices us extending existing enum/define. One solution can be using a fixed size array instead of ``.*MAX.*`` value. -* ethdev: Announce moving from dedicated modify function for each field, - to using the general ``rte_flow_modify_field`` action. - * ethdev: The flow API matching pattern structures, ``struct rte_flow_item_*``, should start with relevant protocol header. Some matching pattern structures implements this by duplicating protocol header @@ -87,10 +84,9 @@ Deprecation Notices ``DEC_TTL``, ``SET_TTL``, ``SET_MAC_SRC``, ``SET_MAC_DST``, ``INC_TCP_SEQ``, ``DEC_TCP_SEQ``, ``INC_TCP_ACK``, ``DEC_TCP_ACK``, ``SET_IPV4_DSCP``, ``SET_IPV6_DSCP``, ``SET_TAG``, ``SET_META`` are marked as legacy and - superseded by the generic MODIFY_FIELD action. - The legacy actions should be deprecated in 22.07, once MODIFY_FIELD - alternative is implemented. - The legacy actions should be removed in DPDK 22.11. + superseded by the generic ``RTE_FLOW_ACTION_TYPE_MODIFY_FIELD``. + The legacy actions should be removed + once ``MODIFY_FIELD`` alternative is implemented in drivers. * cryptodev: The function ``rte_cryptodev_cb_fn`` will be updated to have another parameter ``qp_id`` to return the queue pair ID From patchwork Thu Nov 24 14:26:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 120131 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF95EA00C3; Thu, 24 Nov 2022 15:27:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9918642DCE; Thu, 24 Nov 2022 15:27:13 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id BD44942DC9 for ; Thu, 24 Nov 2022 15:27:11 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 667E45C0121; Thu, 24 Nov 2022 09:27:11 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 24 Nov 2022 09:27:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1669300031; x=1669386431; bh=JI b79+/8nYSK36fselgk2gecfNdBCsd5WWWk0DkcVac=; b=LkVxSa+8M0AxgYudnZ NZDK+L59BGE6vC+ypi2edoyNjxaf3RO1Zvhu7uwGbkAKuuttSbDJMauB9h8Aj7PH /9p15GbRTVe16MzQQsh8Ob04/rJiukzP+ECbw3PmLYwQV/6VAZ/DWvAS4r7MnQj3 +tkTD0d73ZvcUZPqO3FguU172ZYitnAhLq6ilPoBZ3u38KFTK+u5Xj5C7H0Zmzwf DzYlMiS3MnaVe2c82kk9xlKHwmTWYu02NoYf0w7/xDbGMmVQvM+SCWYuOFHeyO6k syPpKK8TD896VJm0abJZM/pG4k0v1xjH6ijTjzR+v4eyDQq3nYsJiGTfSzqe+8Yt 4mVg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1669300031; x=1669386431; bh=JIb79+/8nYSK3 6fselgk2gecfNdBCsd5WWWk0DkcVac=; b=hItTMvzrM3TCDjRWDvyWzcmA1QnF4 YCTBUYWLaJzqtFNgydX4wfsWvc0kBTmrgwpHOqlAyqRQDpMm2NzksS/TqKB5OX+6 2515OWmR8mJdP/KhTFkLlYyPC7AHJ5lgs4EVm+XBKxvbUThwef79oe9xC6YY09ll j1CATFpUQ5r2mrdyn3khNLhcT/p3Q4+W+xmKBYzuEFx48yrRFOHti/tkqIMmQ1nz mzPJBTpgnUbtBf4yIIhRKs2Og2o39q3f/+FvpEfUzUIHmHfza+qay6JIeDTbG4wj HevVtm1kkDb1zXfZ63lwKxpnuLxpYpG5MCKvlsvz3czdm+SQLLisDmNXw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrieefgdeigecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvdejhfdugeehvddtieejieegteeuudfgjeeukeeiledthfetveek hefhieelhfdtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 24 Nov 2022 09:27:10 -0500 (EST) From: Thomas Monjalon To: dev@dpdk.org Cc: Ori Kam , Ferruh Yigit , Andrew Rybchenko Subject: [PATCH 2/2] doc: update deprecation notice of flow items Date: Thu, 24 Nov 2022 15:26:59 +0100 Message-Id: <20221124142659.3350953-3-thomas@monjalon.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20221124142659.3350953-1-thomas@monjalon.net> References: <20221124142659.3350953-1-thomas@monjalon.net> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The flow items are not yet cleaned up in DPDK 22.11 as desired. The plan is updated for this release, with more details. A new plan must be precised during the next release. Signed-off-by: Thomas Monjalon --- doc/guides/rel_notes/deprecation.rst | 37 ++++++++++++++++++++++------ 1 file changed, 29 insertions(+), 8 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 8e4b1c08ff..a780c5b126 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -55,14 +55,35 @@ Deprecation Notices One solution can be using a fixed size array instead of ``.*MAX.*`` value. * ethdev: The flow API matching pattern structures, ``struct rte_flow_item_*``, - should start with relevant protocol header. - Some matching pattern structures implements this by duplicating protocol header - fields in the struct. To clarify the intention and to be sure protocol header - is intact, will replace those fields with relevant protocol header struct. - In v21.02 both individual protocol header fields and the protocol header struct - will be added as union, target is switch usage to the protocol header by time. - In v21.11 LTS, protocol header fields will be cleaned and only protocol header - struct will remain. + should start with relevant protocol header structure from lib/net/. + The individual protocol header fields and the protocol header struct + may be kept together in an union as a first migration step. + + These items are not compliant (not including struct from lib/net/): + + - ``rte_flow_item_ah`` + - ``rte_flow_item_arp_eth_ipv4`` + - ``rte_flow_item_e_tag`` + - ``rte_flow_item_geneve`` + - ``rte_flow_item_geneve_opt`` + - ``rte_flow_item_gre`` + - ``rte_flow_item_gtp`` + - ``rte_flow_item_icmp6`` + - ``rte_flow_item_icmp6_nd_na`` + - ``rte_flow_item_icmp6_nd_ns`` + - ``rte_flow_item_icmp6_nd_opt`` + - ``rte_flow_item_icmp6_nd_opt_sla_eth`` + - ``rte_flow_item_icmp6_nd_opt_tla_eth`` + - ``rte_flow_item_igmp`` + - ``rte_flow_item_ipv6_ext`` + - ``rte_flow_item_l2tpv3oip`` + - ``rte_flow_item_mpls`` + - ``rte_flow_item_nsh`` + - ``rte_flow_item_nvgre`` + - ``rte_flow_item_pfcp`` + - ``rte_flow_item_pppoe`` + - ``rte_flow_item_pppoe_proto_id`` + - ``rte_flow_item_vxlan_gpe`` * ethdev: Queue specific stats fields will be removed from ``struct rte_eth_stats``. Mentioned fields are: ``q_ipackets``, ``q_opackets``, ``q_ibytes``, ``q_obytes``,