From patchwork Wed Nov 30 06:37:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jin Ling X-Patchwork-Id: 120333 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36F4BA00C2; Wed, 30 Nov 2022 07:38:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3256E410D1; Wed, 30 Nov 2022 07:38:29 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 1792B4014F for ; Wed, 30 Nov 2022 07:38:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669790307; x=1701326307; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LXv9b9LTBNW9ZuIbaYuKHE93qVPF6HrQf5O+cghIKuI=; b=Pt9UcgMKgoquiX7WmGlKCCekwCLaJ2KYwjRebpPpKTku4Xm/cN1g/2sD EFVZwdfqELpr8xsfCLal11D3BddqG7kTt0PcIM+o+Th0sWMqMFZ4wsgPY 46h+Xn7TnpF+Sc/GljoVvfszbBB7QUUsvSR/QASGJgHHIfOQWJ5JpeYh6 D7jeddddjNkODGGn+rThWA2t8zBjCeOfvlwdBczw/y8sSeBWGuVy99za+ U6fQO09t+1tEmCdhpF5AopBnZ6VJ6A0YQkXUmW8Y2eZnsYEHnHOVHE9Oz 22sL3Fvbe0aSYk5aqf9gFsxzUgC3j0ctzGPliwwNgjvxl7Pe7k50mHd2E A==; X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="379600370" X-IronPort-AV: E=Sophos;i="5.96,205,1665471600"; d="scan'208";a="379600370" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2022 22:38:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="637882674" X-IronPort-AV: E=Sophos;i="5.96,205,1665471600"; d="scan'208";a="637882674" Received: from dpdk-lingjin.sh.intel.com ([10.67.115.8]) by orsmga007.jf.intel.com with ESMTP; 29 Nov 2022 22:38:22 -0800 From: Jin Ling To: dts@dpdk.org Cc: lijuan.tu@intel.com, yuan.peng@intel.com, Jin Ling Subject: [DTS][PATCH V2 1/3] test_plans/index.rst: add ice_dcf_disable_acl_filter test plan Date: Wed, 30 Nov 2022 14:37:59 +0800 Message-Id: <20221130063801.4135296-2-jin.ling@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221130063801.4135296-1-jin.ling@intel.com> References: <20221130063801.4135296-1-jin.ling@intel.com> MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Signed-off-by: Jin Ling --- test_plans/index.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/test_plans/index.rst b/test_plans/index.rst index 0fd58f69..22550336 100644 --- a/test_plans/index.rst +++ b/test_plans/index.rst @@ -28,6 +28,7 @@ The following are the test plans for the DPDK DTS automated test system. ice_advanced_iavf_rss_pppol2tpoudp_test_plan ice_advanced_rss_vlan_esp_ah_l2tp_pfcp_test_plan ice_dcf_acl_filter_test_plan + ice_dcf_disable_acl_filter_test_plan ice_dcf_data_path_test_plan ice_dcf_switch_filter_test_plan ice_dcf_switch_filter_pppoe_test_plan From patchwork Wed Nov 30 06:38:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jin Ling X-Patchwork-Id: 120334 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98B74A00C3; Wed, 30 Nov 2022 07:38:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 509B442D0D; Wed, 30 Nov 2022 07:38:29 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 8888C40151 for ; Wed, 30 Nov 2022 07:38:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669790307; x=1701326307; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xpVXMr/2KCj+60rBVAUASlQmNr68hD8NJ8KF+EuQOcc=; b=ZOm/6eGB/fzXF7B0OtlyRiqt/9x40+LUf9m6zMWJYpMOlDNA1Jl6ruKA FCDU1mkHauiyv2Vrhxmrlct0QQ9sRTEEztNwYbXWE71QPnZ3uaV3mHCvR zDcnW9Ci+qNcSW9xf/6eb5pLNTFjpa4w0Ql7zkcwxnwSFqeqnlXqIF9Mx 68eQuwn2HxyMMsvDN+3zEL5YNf9TxcWFkHiwOvFkYLzWDVKB6VydJeUD4 bSEJ2Mkwf0ZShYlgyhVxwDEGWYx/r2fw7MRZynuH6yq9M0Q491yrX8RgG e/8kbb6KhNZIEjYzG/nOmMQmKMlQTahPi99e8HccdD2fHg4k5XGhQqRLu A==; X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="379600373" X-IronPort-AV: E=Sophos;i="5.96,205,1665471600"; d="scan'208";a="379600373" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2022 22:38:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="637882703" X-IronPort-AV: E=Sophos;i="5.96,205,1665471600"; d="scan'208";a="637882703" Received: from dpdk-lingjin.sh.intel.com ([10.67.115.8]) by orsmga007.jf.intel.com with ESMTP; 29 Nov 2022 22:38:24 -0800 From: Jin Ling To: dts@dpdk.org Cc: lijuan.tu@intel.com, yuan.peng@intel.com, Jin Ling Subject: [DTS][PATCH V2 2/3] test_plans/ice_disable_acl_filter: add ice_dcf_disable_acl_filter test plan Date: Wed, 30 Nov 2022 14:38:00 +0800 Message-Id: <20221130063801.4135296-3-jin.ling@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221130063801.4135296-1-jin.ling@intel.com> References: <20221130063801.4135296-1-jin.ling@intel.com> MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org The startup time of ACL engine is too long (6s+), so add a devargs that customers can use it to disable/enable ACL engine. add new test plan to test if ACL engine is disabled. Signed-off-by: Jin Ling --- .../ice_dcf_disable_acl_filter_test_plan.rst | 254 ++++++++++++++++++ 1 file changed, 254 insertions(+) create mode 100644 test_plans/ice_dcf_disable_acl_filter_test_plan.rst diff --git a/test_plans/ice_dcf_disable_acl_filter_test_plan.rst b/test_plans/ice_dcf_disable_acl_filter_test_plan.rst new file mode 100644 index 00000000..f8577b97 --- /dev/null +++ b/test_plans/ice_dcf_disable_acl_filter_test_plan.rst @@ -0,0 +1,254 @@ +.. Copyright (c) <2015-2017>, Intel Corporation + All rights reserved. + + Redistribution and use in source and binary forms, with or without + modification, are permitted provided that the following conditions + are met: + + - Redistributions of source code must retain the above copyright + notice, this list of conditions and the following disclaimer. + + - Redistributions in binary form must reproduce the above copyright + notice, this list of conditions and the following disclaimer in + the documentation and/or other materials provided with the + distribution. + + - Neither the name of Intel Corporation nor the names of its + contributors may be used to endorse or promote products derived + from this software without specific prior written permission. + + THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR + SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) + HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, + STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED + OF THE POSSIBILITY OF SUCH DAMAGE. + +========================== +ICE DCF DISABLE ACL engine +========================== + +Description +=========== + +Support disabling DCF ACL engine via devarg "acl=off" in cmdline, aiming to shorten the DCF startup time. +After disabling the ACL engine, some of the rules supported by the ACL engine will be created by the Switch engine and others will failed to be created, +as shown in the following table. + ++-----------+-------------------------------------------------------------------------+---------+---------+ +| Pattern | Input Set | ACL | Switch | ++===========+=========================================================================+=========+=========+ +| IPv4 | [Source MAC] | success | fail | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| | [Dest MAC] | success | success | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| | [Source IP] | success | success | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| | [Dest IP] | success | success | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| | [Source IP],[Dest IP] | success | success | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| | [Source MAC],[Dest MAC],[Source IP],[Dest IP] | success | fail | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| IPv4_TCP | [Source MAC] | success | fail | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| | [Dest MAC] | success | success | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| | [Source IP] | success | success | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| | [Dest IP] | success | success | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| | [Source port] | success | success | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| | [Dest port] | success | success | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| | [Source IP],[Dest IP],[Source port],[Dest port] | success | success | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| | [Source MAC],[Dest MAC],[Source IP],[Dest IP],[Source port],[Dest port] | success | fail | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| IPv4_UDP | [Source MAC] | success | fail | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| | [Dest MAC] | success | success | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| | [Source IP] | success | success | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| | [Dest IP] | success | success | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| | [Source port] | success | success | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| | [Dest port] | success | success | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| | [Source IP],[Dest IP],[Source port],[Dest port] | success | success | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| | [Source MAC],[Dest MAC],[Source IP],[Dest IP],[Source port],[Dest port] | success | fail | ++-----------+-------------------------------------------------------------------------+---------+---------+ +| IPv4_SCTP | all input sets | success | fail | ++-----------+-------------------------------------------------------------------------+---------+---------+ + + +Prerequisites +============= + +Topology +-------- + + dut_port_0 <---> tester_port_0 + + dut_port_1 <---> tester_port_1 + +Hardware +-------- + + Supportted NICs: columbiaville_25g/columbiaville_100g + +Software +-------- + + dpdk: http://dpdk.org/git/dpdk + + scapy: http://www.secdev.org/projects/scapy/ + +General set up +-------------- + +1. Compile DPDK:: + + CC=gcc meson -Denable_kmods=True -Dlibdir=lib --default-library=static x86_64-native-linuxapp-gcc + ninja -C x86_64-native-linuxapp-gcc + +2. Get the pci device id of DUT, for example:: + + ./usertools/dpdk-devbind.py -s + + 0000:17:00.0 'Ethernet Controller E810-C for QSFP 1592' if=ens9 drv=ice unused=vfio-pci + +3. Generate 2 VFs on PF0:: + + echo 2 > /sys/bus/pci/devices/0000:17:00.0/sriov_numvfs + + ./usertools/dpdk-devbind.py -s + 0000:17:01.0 'Ethernet Adaptive Virtual Function 1889' drv=vfio-pci unused=iavf + 0000:17:01.1 'Ethernet Adaptive Virtual Function 1889' drv=vfio-pci unused=iavf + +4. Set VF0 as trust and set VF1 mac adress:: + + ip link set ens9 vf 0 trust on + ip link set enp9 vf 1 mac 00:01:23:45:67:89 + +5. Bind VFs to dpdk driver:: + + modprobe vfio-pci + ./usertools/dpdk-devbind.py -b vfio-pci 0000:17:01.0 0000:17:01.1 + +6. Start testpmd on VF0, VF0 request DCF mode and set `devargs` parameter "acl=off" to disable the ACL engine:: + + ./x86_64-native-linuxapp-gcc/app/dpdk-testpmd -c 0xf -n 4 -a 0000:17:01.0,cap=dcf,acl=off --file-prefix=vf0 --log-level="ice,7" -- -i + + Check that when starting testpmd, the application prints "ice_flow_init():Engine 4 disabled" + + Quit testpmd:: + + testpmd> quit + + Check that when quitting testpmd, the application prints "ice_flow_uninit():Engine 4 disabled skip it" + +Test Case +========= + +Test Case 1: Compare start-up time +----------------------------------- +It takes too much time to enable the ACL engine when starting testpmd, so the startup time should be shortened after disabling ACL. + +test steps +~~~~~~~~~~ + +1. Disable ACL, execute command and record the time "start_time_disable_acl":: + + echo quit | time ./x86_64-native-linuxapp-gcc/app/dpdk-testpmd -c 0xf -n 4 -a 0000:17:01.0,cap=dcf,acl=off --file-prefix=vf0 --log-level="ice,7" -- -i + +2. Enable ACL, execute command and record the time "start_time_enable_acl":: + + echo quit | time ./x86_64-native-linuxapp-gcc/app/dpdk-testpmd -c 0xf -n 4 -a 0000:17:01.0,cap=dcf --file-prefix=vf1 --log-level="ice,7" -- -i + +3. Repeat step 1~2 for at least 5 times to get the average time of "start_time_disable_acl" and "start_time_enable_acl". + + +expected result +~~~~~~~~~~~~~~~ + + Check that the average start-up time with "acl=off" is at least 6 seconds shorter than that without "acl=off". + +Test Case 2: disable ACL engine +------------------------------- + +test steps +~~~~~~~~~~ + +1. Start testpmd:: + + ./x86_64-native-linuxapp-gcc/app/dpdk-testpmd -c 0xf -n 4 -a 0000:17:01.0,cap=dcf,acl=off -a 17:01.1 --file-prefix=vf0 --log-level="ice,7" -- -i + +2. Create ACL rules on port 0:: + + Switch supported rules:: + + ipv4: + flow create 0 ingress pattern eth dst spec 00:11:22:33:44:55 dst mask ff:ff:ff:ff:ff:ff / ipv4 / end actions drop / end + flow create 0 ingress pattern eth / ipv4 src spec 192.168.0.1 src mask 255.255.255.0 / end actions drop / end + flow create 0 ingress pattern eth / ipv4 dst spec 192.168.0.2 dst mask 255.255.255.0 / end actions drop / end + flow create 0 ingress pattern eth / ipv4 src spec 192.168.0.1 src mask 255.255.255.0 dst spec 192.168.0.2 dst mask 255.255.0.255 / end actions drop / end + ipv4_tcp: + flow create 0 ingress pattern eth dst spec 00:11:22:33:44:55 dst mask ff:ff:ff:ff:ff:00 / ipv4 / tcp / end actions drop / end + flow create 0 ingress pattern eth / ipv4 src spec 192.168.0.1 src mask 255.255.255.254 / tcp / end actions drop / end + flow create 0 ingress pattern eth / ipv4 dst spec 192.168.0.2 dst mask 255.255.255.243 / tcp / end actions drop / end + flow create 0 ingress pattern eth / ipv4 / tcp src spec 8010 src mask 65520 / end actions drop / end + flow create 0 ingress pattern eth / ipv4 / tcp dst spec 8010 dst mask 65520 / end actions drop / end + flow create 0 ingress pattern eth / ipv4 src spec 192.168.0.1 src mask 255.255.255.0 dst spec 192.168.0.2 dst mask 255.255.0.255 / tcp src spec 8010 src mask 65520 dst spec 8017 dst mask 65520 / end actions drop / end + ipvv4_udp: + flow create 0 ingress pattern eth dst spec 00:11:22:33:44:55 dst mask ff:ff:ff:ff:ff:00 / ipv4 / udp / end actions drop / end + flow create 0 ingress pattern eth / ipv4 src spec 192.168.0.1 src mask 255.255.255.254 / udp / end actions drop / end + flow create 0 ingress pattern eth / ipv4 dst spec 192.168.0.2 dst mask 255.255.255.243 / udp / end actions drop / end + flow create 0 ingress pattern eth / ipv4 / udp src spec 8010 src mask 65520 / end actions drop / end + flow create 0 ingress pattern eth / ipv4 / udp dst spec 8010 dst mask 65520 / end actions drop / end + flow create 0 ingress pattern eth / ipv4 src spec 192.168.0.1 src mask 255.255.255.0 dst spec 192.168.0.2 dst mask 255.255.0.255 / udp src spec 8010 src mask 65520 dst spec 8017 dst mask 65520 / end actions drop / end + + Switch not supported rules:: + + ipv4: + flow create 0 ingress pattern eth src spec 00:11:22:33:44:55 src mask 00:ff:ff:ff:ff:ff / ipv4 / end actions drop / end + flow create 0 ingress pattern eth src spec 00:11:22:33:44:55 src mask ff:ff:ff:ff:ff:00 dst spec 33:00:00:00:00:02 dst mask ff:ff:ff:ff:ff:fe / ipv4 src spec 192.168.0.1 src mask 255.255.255.0 dst spec 192.168.0.2 dst mask 255.255.0.255 / end actions drop / end + ipv4_tcp: + flow create 0 ingress pattern eth src spec 00:11:22:33:44:55 src mask ff:ff:ff:ff:ff:fe / ipv4 / tcp / end actions drop / end + flow create 0 ingress pattern eth src spec 00:11:22:33:44:55 src mask ff:ff:ff:ff:ff:00 dst spec 00:01:23:45:67:89 dst mask ff:ff:ff:ff:00:ff / ipv4 src spec 192.168.0.1 src mask 255.255.255.0 dst spec 192.168.0.2 dst mask 255.255.0.255 / tcp src spec 8010 src mask 65520 dst spec 8017 dst mask 65520 / end actions drop / end + ipvv4_udp: + flow create 0 ingress pattern eth src spec 00:11:22:33:44:55 src mask ff:ff:ff:ff:ff:fe / ipv4 / udp / end actions drop / end + flow create 0 ingress pattern eth src spec 00:11:22:33:44:55 src mask ff:ff:ff:ff:ff:00 dst spec 00:01:23:45:67:89 dst mask ff:ff:ff:ff:00:ff / ipv4 src spec 192.168.0.1 src mask 255.255.255.0 dst spec 192.168.0.2 dst mask 255.255.0.255 / udp src spec 8010 src mask 65520 dst spec 8017 dst mask 65520 / end actions drop / end + ipv4_sctp: + flow create 0 ingress pattern eth src spec 00:11:22:33:44:55 src mask ff:ff:ff:ff:ff:fe / ipv4 / sctp / end actions drop / end + flow create 0 ingress pattern eth dst spec 00:11:22:33:44:55 dst mask ff:ff:ff:ff:ff:00 / ipv4 / sctp / end actions drop / end + flow create 0 ingress pattern eth / ipv4 src spec 192.168.0.1 src mask 255.255.255.254 / sctp / end actions drop / end + flow create 0 ingress pattern eth / ipv4 dst spec 192.168.0.2 dst mask 255.255.255.243 / sctp / end actions drop / end + flow create 0 ingress pattern eth / ipv4 / sctp src spec 8010 src mask 65520 / end actions drop / end + flow create 0 ingress pattern eth / ipv4 / sctp dst spec 8010 dst mask 65520 / end actions drop / end + flow create 0 ingress pattern eth / ipv4 src spec 192.168.0.1 src mask 255.255.255.0 dst spec 192.168.0.2 dst mask 255.255.0.255 / sctp src spec 8010 src mask 65520 dst spec 8017 dst mask 65520 / end actions drop / end + flow create 0 ingress pattern eth src spec 00:11:22:33:44:55 src mask ff:ff:ff:ff:ff:00 dst spec 00:01:23:45:67:89 dst mask ff:ff:ff:ff:00:ff / ipv4 src spec 192.168.0.1 src mask 255.255.255.0 dst spec 192.168.0.2 dst mask 255.255.0.255 / sctp src spec 8010 src mask 65520 dst spec 8017 dst mask 65520 / end actions drop / end + +expected result +~~~~~~~~~~~~~~~ + + Check that Switch support rules will be created:: + + ice_flow_create(): Succeeded to create (2) flow + + Switch not support rules will be created failed:: + + ice_flow_create(): Failed to create flow + port_flow_complain(): Caught PMD error type 10 (item specification): cause: 0x7ffd63133730,Invalid input set: Invalid argument + + Both outputs mean that the ACL engine has been disabled. From patchwork Wed Nov 30 06:38:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jin Ling X-Patchwork-Id: 120335 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77165A00C2; Wed, 30 Nov 2022 07:38:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7182D40151; Wed, 30 Nov 2022 07:38:30 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 2B5954014F for ; Wed, 30 Nov 2022 07:38:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669790309; x=1701326309; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fLz1b5hjJGw9/vO684w/FsH9vrpC/PTHvgt7eFPECIk=; b=BmYSUX/dV7wa4WugoYVywZ7y68H7bn2jLsNNCMMR+8zXx06/P+JxbWnC cnrrvkBZSlq3LYz8LM2qOmnOOvu4tO6JxYh5CVU2BhWdBy2obo7wagBaj BMMZGkoeQL4dvpc802HIMAFNHeMgdI1RGUfcY4OdUdT4p6tt09jnc43dN AC/uc8py1gZkrRPgWNC17oQldZCoI/JsC62yLMjF2JCravcNbwGohDKeS EbQIKwN5pXtLx+CdNpCs9W7B3ZnQqzoEMolszPJZOaJrW9p1QgOrIIfAT HcWYEmUQm9v75d2gtc5sS/P472B+UCBmEVNQi8rpV3aPSZ+x2yd1POyzI g==; X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="379600379" X-IronPort-AV: E=Sophos;i="5.96,205,1665471600"; d="scan'208";a="379600379" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2022 22:38:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="637882718" X-IronPort-AV: E=Sophos;i="5.96,205,1665471600"; d="scan'208";a="637882718" Received: from dpdk-lingjin.sh.intel.com ([10.67.115.8]) by orsmga007.jf.intel.com with ESMTP; 29 Nov 2022 22:38:26 -0800 From: Jin Ling To: dts@dpdk.org Cc: lijuan.tu@intel.com, yuan.peng@intel.com, Jin Ling Subject: [DTS][PATCH V2 3/3] tests/ice_dcf_disable_acl_filter: add new test suite Date: Wed, 30 Nov 2022 14:38:01 +0800 Message-Id: <20221130063801.4135296-4-jin.ling@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221130063801.4135296-1-jin.ling@intel.com> References: <20221130063801.4135296-1-jin.ling@intel.com> MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org The startup time of ACL engine is too long(6s+), so add a devargs that customers can use it to disable/enable ACL engine. add new test suite to test if ACL engine is disabled. Signed-off-by: Jin Ling --- tests/TestSuite_ice_dcf_disable_acl_filter.py | 285 ++++++++++++++++++ 1 file changed, 285 insertions(+) create mode 100644 tests/TestSuite_ice_dcf_disable_acl_filter.py diff --git a/tests/TestSuite_ice_dcf_disable_acl_filter.py b/tests/TestSuite_ice_dcf_disable_acl_filter.py new file mode 100644 index 00000000..8a8480bc --- /dev/null +++ b/tests/TestSuite_ice_dcf_disable_acl_filter.py @@ -0,0 +1,285 @@ +# SPDX-License-Identifier: BSD-3-Clause +# Copyright(c) 2020 Intel Corporation +# + + +import re +import time + +from framework.packet import Packet +from framework.pmd_output import PmdOutput +from framework.test_case import TestCase, check_supported_nic +from framework.utils import BLUE, GREEN, RED + +rule_switch_unsupported = { + "name": "create switch unsupported rules", + "message": "ice_flow_create(): Failed to create flow", + "ipv4": [ + "flow create 0 ingress pattern eth src spec 00:11:22:33:44:55 src mask 00:ff:ff:ff:ff:ff / ipv4 / end actions drop / end", + "flow create 0 ingress pattern eth src spec 00:11:22:33:44:55 src mask ff:ff:ff:ff:ff:00 dst spec 33:00:00:00:00:02 dst mask ff:ff:ff:ff:ff:fe / ipv4 src spec 192.168.0.1 src mask 255.255.255.0 dst spec 192.168.0.2 dst mask 255.255.0.255 / end actions drop / end", + ], + "ipv4_tcp": [ + "flow create 0 ingress pattern eth src spec 00:11:22:33:44:55 src mask ff:ff:ff:ff:ff:fe / ipv4 / tcp / end actions drop / end", + "flow create 0 ingress pattern eth src spec 00:11:22:33:44:55 src mask ff:ff:ff:ff:ff:00 dst spec 00:01:23:45:67:89 dst mask ff:ff:ff:ff:00:ff / ipv4 src spec 192.168.0.1 src mask 255.255.255.0 dst spec 192.168.0.2 dst mask 255.255.0.255 / tcp src spec 8010 src mask 65520 dst spec 8017 dst mask 65520 / end actions drop / end", + ], + "ipv4_udp": [ + "flow create 0 ingress pattern eth src spec 00:11:22:33:44:55 src mask ff:ff:ff:ff:ff:fe / ipv4 / udp / end actions drop / end", + "flow create 0 ingress pattern eth src spec 00:11:22:33:44:55 src mask ff:ff:ff:ff:ff:00 dst spec 00:01:23:45:67:89 dst mask ff:ff:ff:ff:00:ff / ipv4 src spec 192.168.0.1 src mask 255.255.255.0 dst spec 192.168.0.2 dst mask 255.255.0.255 / udp src spec 8010 src mask 65520 dst spec 8017 dst mask 65520 / end actions drop / end", + ], + "ipv4_sctp": [ + "flow create 0 ingress pattern eth src spec 00:11:22:33:44:55 src mask ff:ff:ff:ff:ff:fe / ipv4 / sctp / end actions drop / end", + "flow create 0 ingress pattern eth dst spec 00:11:22:33:44:55 dst mask ff:ff:ff:ff:ff:00 / ipv4 / sctp / end actions drop / end", + "flow create 0 ingress pattern eth / ipv4 src spec 192.168.0.1 src mask 255.255.255.254 / sctp / end actions drop / end", + "flow create 0 ingress pattern eth / ipv4 dst spec 192.168.0.2 dst mask 255.255.255.243 / sctp / end actions drop / end", + "flow create 0 ingress pattern eth / ipv4 / sctp src spec 8010 src mask 65520 / end actions drop / end", + "flow create 0 ingress pattern eth / ipv4 / sctp dst spec 8010 dst mask 65520 / end actions drop / end", + "flow create 0 ingress pattern eth / ipv4 src spec 192.168.0.1 src mask 255.255.255.0 dst spec 192.168.0.2 dst mask 255.255.0.255 / sctp src spec 8010 src mask 65520 dst spec 8017 dst mask 65520 / end actions drop / end", + "flow create 0 ingress pattern eth src spec 00:11:22:33:44:55 src mask ff:ff:ff:ff:ff:00 dst spec 00:01:23:45:67:89 dst mask ff:ff:ff:ff:00:ff / ipv4 src spec 192.168.0.1 src mask 255.255.255.0 dst spec 192.168.0.2 dst mask 255.255.0.255 / sctp src spec 8010 src mask 65520 dst spec 8017 dst mask 65520 / end actions drop / end", + ], +} + +rule_switch_supported = { + "name": "create switch supported rules", + "message": "Succeeded to create (2) flow", + "ipv4": [ + "flow create 0 ingress pattern eth dst spec 00:11:22:33:44:55 dst mask ff:ff:ff:ff:ff:ff / ipv4 / end actions drop / end", + "flow create 0 ingress pattern eth / ipv4 src spec 192.168.0.1 src mask 255.255.255.0 / end actions drop / end", + "flow create 0 ingress pattern eth / ipv4 dst spec 192.168.0.2 dst mask 255.255.255.0 / end actions drop / end", + "flow create 0 ingress pattern eth / ipv4 src spec 192.168.0.1 src mask 255.255.255.0 dst spec 192.168.0.2 dst mask 255.255.0.255 / end actions drop / end", + ], + "ipv4_tcp": [ + "flow create 0 ingress pattern eth dst spec 00:11:22:33:44:55 dst mask ff:ff:ff:ff:ff:00 / ipv4 / tcp / end actions drop / end", + "flow create 0 ingress pattern eth / ipv4 src spec 192.168.0.1 src mask 255.255.255.254 / tcp / end actions drop / end", + "flow create 0 ingress pattern eth / ipv4 dst spec 192.168.0.2 dst mask 255.255.255.243 / tcp / end actions drop / end", + "flow create 0 ingress pattern eth / ipv4 / tcp src spec 8010 src mask 65520 / end actions drop / end", + "flow create 0 ingress pattern eth / ipv4 / tcp dst spec 8010 dst mask 65520 / end actions drop / end", + "flow create 0 ingress pattern eth / ipv4 src spec 192.168.0.1 src mask 255.255.255.0 dst spec 192.168.0.2 dst mask 255.255.0.255 / tcp src spec 8010 src mask 65520 dst spec 8017 dst mask 65520 / end actions drop / end", + ], + "ipv4_udp": [ + "flow create 0 ingress pattern eth dst spec 00:11:22:33:44:55 dst mask ff:ff:ff:ff:ff:00 / ipv4 / udp / end actions drop / end", + "flow create 0 ingress pattern eth / ipv4 src spec 192.168.0.1 src mask 255.255.255.254 / udp / end actions drop / end", + "flow create 0 ingress pattern eth / ipv4 dst spec 192.168.0.2 dst mask 255.255.255.243 / udp / end actions drop / end", + "flow create 0 ingress pattern eth / ipv4 / udp src spec 8010 src mask 65520 / end actions drop / end", + "flow create 0 ingress pattern eth / ipv4 / udp dst spec 8010 dst mask 65520 / end actions drop / end", + "flow create 0 ingress pattern eth / ipv4 src spec 192.168.0.1 src mask 255.255.255.0 dst spec 192.168.0.2 dst mask 255.255.0.255 / udp src spec 8010 src mask 65520 dst spec 8017 dst mask 65520 / end actions drop / end", + ], +} + +subcases = { + "case": [rule_switch_supported, rule_switch_unsupported], + "result": [], +} + + +class ICEDCFACLDisableFilterTest(TestCase): + supported_nic = ["ICE_25G-E810C_SFP", "ICE_25G-E810_XXV_SFP", "ICE_100G-E810C_QSFP"] + + @check_supported_nic(supported_nic) + def set_up_all(self): + """ + Run at the start of each test suite. + """ + self.dut_ports = self.dut.get_ports(self.nic) + # Verify that enough ports are available + self.verify(len(self.dut_ports) >= 2, "Insufficient ports") + localPort0 = self.tester.get_local_port(self.dut_ports[0]) + self.tester_iface0 = self.tester.get_interface(localPort0) + self.pf0_intf = self.dut.ports_info[self.dut_ports[0]]["intf"] + self.dut.send_expect("ifconfig %s up" % self.tester_iface0, "# ") + self.pkt = Packet() + self.pmd_output = PmdOutput(self.dut) + self.testpmd_status = "close" + # bind pf to kernel + self.dut.bind_interfaces_linux("ice") + # set vf driver + self.vf_driver = "vfio-pci" + self.dut.send_expect("modprobe vfio-pci", "# ") + self.path = self.dut.apps_name["test-pmd"] + self.setup_1pf_1vf_env() + self.dut.send_expect("ifconfig %s up" % self.tester_iface0, "# ", 15) + + def setup_1pf_1vf_env(self, pf_port=0, driver="default"): + + self.used_dut_port_0 = self.dut_ports[pf_port] + # get PF interface name + self.dut.send_expect("ethtool -i %s" % self.pf0_intf, "#") + # generate 1 VF on PF + self.dut.generate_sriov_vfs_by_port(self.used_dut_port_0, 1, driver=driver) + self.sriov_vfs_port_0 = self.dut.ports_info[self.used_dut_port_0]["vfs_port"] + self.vf0_pci = self.sriov_vfs_port_0[0].pci + # set VF0 as trust + self.dut.send_expect("ip link set %s vf 0 trust on" % self.pf0_intf, "#") + # bind drivers + for port in self.sriov_vfs_port_0: + port.bind_driver(self.vf_driver) + time.sleep(5) + + def set_up(self): + """ + Run before each test case. + """ + self.setup_1pf_1vf_env() + + def create_testpmd_command(self, param, acl_status): + """ + Create testpmd command + """ + # Prepare testpmd EAL and parameters + if acl_status != "": + all_eal_param = self.dut.create_eal_parameters( + cores="1S/4C/1T", + ports=[self.vf0_pci], + port_options={self.vf0_pci: "cap=dcf,acl=" + acl_status}, + ) + else: + all_eal_param = self.dut.create_eal_parameters( + cores="1S/4C/1T", + ports=[self.vf0_pci], + port_options={self.vf0_pci: "cap=dcf"}, + ) + command = self.path + all_eal_param + "--log-level='ice,7'" + " -- -i" + param + return command + + def launch_testpmd(self, param="", acl_status="off"): + """ + launch testpmd with the command + """ + time.sleep(5) + command = self.create_testpmd_command(param, acl_status) + out = self.dut.send_expect(command, "testpmd> ", 20) + return out + + def create_acl_filter_rule(self, rules, session_name="", check_stats=False): + """ + Create acl filter rules, + set check_stats=False to check all rules can not be created by acl engine successfully + """ + if session_name == "": + session_name = self.dut + + rule_list = {} + # switch_rule = "Succeeded to create (2) flow" + # failed_rule = "ice_flow_create(): Failed to create flow" + + # if isinstance(rules, list): + for item in rules.values(): + if isinstance(item, list): + for rule in item: + out = session_name.send_expect(rule, "testpmd> ") + # check switch not support rule + if check_stats == False: + rule_list.update( + {rule: False if rules["message"] in out else True} + ) + # check switch support rule + if check_stats == True: + rule_list.update( + {rule: True if rules["message"] in out else False} + ) + + if check_stats: + self.verify( + all(list(rule_list.values())), + "all rules should be created successfully by switch engine, result {}".format( + rule_list + ), + ) + else: + self.verify( + not any(list(rule_list.values())), + "all rules should be created failed by acl engine, result {}".format( + rule_list + ), + ) + + def test_startup_time(self): + + repeat_time = 6 + start_up_time_acl_off = [] + start_up_time_acl_on = [] + regex = re.compile(".*real (\d+\.\d{2}).*") + # acl = off + command_acl_off = self.create_testpmd_command(param="", acl_status="off") + # acl = on + command_acl_on = self.create_testpmd_command(param="", acl_status="") + # record startup time + for i in range(repeat_time): + out_acl_off = self.dut.send_expect( + "echo quit | time -p ./%s" % (command_acl_off), + "#", + 120, + ) + + out_acl_on = self.dut.send_expect( + "echo quit | time -p ./%s" % (command_acl_on), + "#", + 120, + ) + + time_acl_on = regex.findall(out_acl_on)[0] + time_acl_off = regex.findall(out_acl_off)[0] + if time_acl_on != "" and time_acl_off != "": + start_up_time_acl_off.append(eval(time_acl_off)) + start_up_time_acl_on.append(eval(time_acl_on)) + print(BLUE("%s times done, total %s times" % (i + 1, repeat_time))) + # get the average + avg_start_up_time_acl_on = sum(start_up_time_acl_on) / repeat_time + avg_start_up_time_acl_off = sum(start_up_time_acl_off) / repeat_time + self.verify( + avg_start_up_time_acl_on >= avg_start_up_time_acl_off + 6, + "disable acl to reduce startup time failed!!!", + ) + self.testpmd_status = "close" + + def test_disable_acl(self): + + launch_testpmd = True + if launch_testpmd: + # launch testpmd + self.launch_testpmd(acl_status="off") + + self.dut.send_expect("flow flush 0", "testpmd> ", 120) + # test subcase + for subcase in subcases["case"]: + try: + self.logger.info( + (GREEN("========test subcase: %s========" % subcase["name"])) + ) + self.create_acl_filter_rule( + subcase, + check_stats=False if "unsupported" in subcase["name"] else True, + ) + self.logger.info((GREEN("case passed: %s" % subcase["name"]))) + + except Exception as e: + self.logger.warning((RED(e))) + self.logger.info((GREEN("case failed: %s" % subcase["name"]))) + subcases["result"].append(False) + self.verify(all(subcases["result"]), "test disable failed.") + + self.testpmd_status = "open" + + def quit_testpmd(self): + """ + quit testpmd + """ + if self.testpmd_status != "close": + # destroy all flow rules on DCF + self.dut.send_expect("flow flush 0", "testpmd> ", 15) + self.dut.send_expect("clear port stats all", "testpmd> ", 15) + self.dut.send_expect("quit", "#", 30) + # kill all DPDK application + self.dut.kill_all() + # self.testpmd_status = "close" + + def tear_down(self): + """ + Run after each test case. + """ + self.quit_testpmd() + + def tear_down_all(self): + """ + Run after each test suite. + """ + self.dut.kill_all()