From patchwork Mon Dec 26 07:47:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alvaro Karsz X-Patchwork-Id: 121391 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D820A00C5; Mon, 26 Dec 2022 08:47:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52F7340146; Mon, 26 Dec 2022 08:47:15 +0100 (CET) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mails.dpdk.org (Postfix) with ESMTP id 0B46A40143 for ; Mon, 26 Dec 2022 08:47:14 +0100 (CET) Received: by mail-wm1-f46.google.com with SMTP id z8-20020a05600c220800b003d33b0bda11so7514336wml.0 for ; Sun, 25 Dec 2022 23:47:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=solid-run-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=b8Uflz59ZcTF3/SDkjWyUF0thDdKyXswH3X6u6wPD28=; b=5+VJN6xneFdMwQzQlLmOnQnv2bzeEHr2OopdHLXyty4XDFd1pie5ci7SVUsitB5p72 Ul6+epYDEzaippHNSFjmokC9xNoQ8bYZ/P4BbgCtCD7IrsCAVzviyEwVZcUMxj3l7S4f 84eqMgefb5DVxm651mhxdPOH9TCFpvpI+8mKqXAyJkW24AP6CtPhAkWN1NlJKstdwqR9 UKcAXd1szSA7RK2nOtQrs8rvcOeSAJJMRqA61gDgerMcEVUng+cSkjFuUPy57EhuWBFV cYBo4CRog8HIKadXh1CQyDBbm2vdmOhk8BUetmw8bfQ8BAbrccLpWeiSa2SVLOqXKt6v 4SUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b8Uflz59ZcTF3/SDkjWyUF0thDdKyXswH3X6u6wPD28=; b=I9Q6w7wZSHu7BQ23uDyvf/XFlnam7iyoJGUPKp/Jel7+lZWhMU/hxm4VNxCNt7Rumn S8CDCz2oafJDZOQNz0755FOhTcJe80Ie3zgNjFOUG5DyHUPuGrs/QrlMmaDeHaawlZ6U RO5dpiU0f54ct1bQp5aQ9QLjPUe5SGS6S30wfLG7IMKhQXh3FwabO9kgSCY5sDiU38bR cum3xZjpTq8qMPMs93/xD9Ez47P06a4rPTFfUH9ptR0TpaDuzoQEqaAzVZ7aLxnhdZ19 nsOla+DCJTTFgE44nvOBO8nBifcd0UdPbdSIYICqZhBcMtTk6LTnGZBXSB/gOQ8he1Td Hs8g== X-Gm-Message-State: AFqh2krtG/z3GtoZiqMewb/hEEjvetvgxW41BIovXfuvPlglXX6Yrp4j Vd6j16CgZoj/PTsE3Ubvy+alq9O2qOPZyh4T X-Google-Smtp-Source: AMrXdXtMM2wZEcYXO6VdL+Sfv0VGOOWw8VoptMDHA+mDeadPgmZZvbg/xAjmXVtoS3a5AhmtEdGURw== X-Received: by 2002:a05:600c:501e:b0:3d3:47b7:56ab with SMTP id n30-20020a05600c501e00b003d347b756abmr14427847wmr.27.1672040833060; Sun, 25 Dec 2022 23:47:13 -0800 (PST) Received: from localhost.localdomain (bzq-84-110-153-254.static-ip.bezeqint.net. [84.110.153.254]) by smtp.gmail.com with ESMTPSA id f8-20020a05600c154800b003cf774c31a0sm19983640wmg.16.2022.12.25.23.47.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Dec 2022 23:47:12 -0800 (PST) From: Alvaro Karsz To: dev@dpdk.org Cc: sachin.saxena@oss.nxp.com, hemant.agrawal@nxp.com, Alvaro Karsz Subject: [PATCH v2] bus/fslmc: unlock spinlock in case of timeout Date: Mon, 26 Dec 2022 09:47:09 +0200 Message-Id: <20221226074709.2432165-1-alvaro.karsz@solid-run.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Bug in function mc_send_command, A spinlock is not unlocked in case of timeouts. Fixes: 79711846f676 ("bus/fslmc: add timeout in MC send command") Signed-off-by: Alvaro Karsz Reviewed-by: David Marchand --- v2: - Fix code indentation. - Fix "Fixes: " tag format. --- drivers/bus/fslmc/mc/mc_sys.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/bus/fslmc/mc/mc_sys.c b/drivers/bus/fslmc/mc/mc_sys.c index ab9a074835..018bd9990e 100644 --- a/drivers/bus/fslmc/mc/mc_sys.c +++ b/drivers/bus/fslmc/mc/mc_sys.c @@ -77,8 +77,12 @@ int mc_send_command(struct fsl_mc_io *mc_io, struct mc_command *cmd) total_time = rte_get_timer_cycles() - start_time; } while (status == MC_CMD_STATUS_READY && total_time <= time_to_wait); - if (status == MC_CMD_STATUS_READY) + if (status == MC_CMD_STATUS_READY) { + /* --- Call unlock function here in case portal is shared --- */ + rte_spinlock_unlock(&mc_portal_lock); + return mc_status_to_error(MC_CMD_STATUS_TIMEOUT); + } /* Read the response back into the command buffer */ mc_read_response(mc_io->regs, cmd);