From patchwork Tue Jan 31 11:08:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Malov X-Patchwork-Id: 122745 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B30DA41B8E; Tue, 31 Jan 2023 12:08:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 614E540DFB; Tue, 31 Jan 2023 12:08:31 +0100 (CET) Received: from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80]) by mails.dpdk.org (Postfix) with ESMTP id 301154067B; Tue, 31 Jan 2023 12:08:30 +0100 (CET) Received: from localhost.localdomain (unknown [78.109.72.147]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by agw.arknetworks.am (Postfix) with ESMTPSA id 34F38E0162; Tue, 31 Jan 2023 15:08:29 +0400 (+04) From: Ivan Malov To: dev@dpdk.org Cc: Andrew Rybchenko , stable@dpdk.org, Andy Moreton , Viacheslav Galaktionov Subject: [PATCH v2] net/sfc: export pick transfer proxy callback to representors Date: Tue, 31 Jan 2023 15:08:39 +0400 Message-Id: <20230131110839.7453-1-ivan.malov@arknetworks.am> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230131072444.6925-1-ivan.malov@arknetworks.am> References: <20230131072444.6925-1-ivan.malov@arknetworks.am> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently, the "pick transfer proxy ethdev" callback is only advertised for non-representor (in example, main PF) ethdevs. That does not sit well with the original idea of this method, which is to let applications discover the privileged port to use for transfer flow management instead of any given ethdev. Applications trying to leverage this API on sfc representors receive an error and cannot configure transfer flow offloads. Fix the problem by exporting the method to representor ports. Fixes: 26706314d418 ("net/sfc: implement transfer proxy port callback") Cc: stable@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Andy Moreton Reviewed-by: Viacheslav Galaktionov Reviewed-by: Andrew Rybchenko --- v2: address community review notes drivers/net/sfc/sfc_repr.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/drivers/net/sfc/sfc_repr.c b/drivers/net/sfc/sfc_repr.c index 417d0073cb..4b03b101d8 100644 --- a/drivers/net/sfc/sfc_repr.c +++ b/drivers/net/sfc/sfc_repr.c @@ -9,6 +9,8 @@ #include +#include +#include #include #include #include @@ -888,6 +890,29 @@ sfc_repr_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) return 0; } +static int +sfc_repr_flow_pick_transfer_proxy(struct rte_eth_dev *dev, + uint16_t *transfer_proxy_port, + struct rte_flow_error *error) +{ + struct sfc_repr_shared *srs = sfc_repr_shared_by_eth_dev(dev); + + return rte_flow_pick_transfer_proxy(srs->pf_port_id, + transfer_proxy_port, error); +} + +const struct rte_flow_ops sfc_repr_flow_ops = { + .pick_transfer_proxy = sfc_repr_flow_pick_transfer_proxy, +}; + +static int +sfc_repr_dev_flow_ops_get(struct rte_eth_dev *dev __rte_unused, + const struct rte_flow_ops **ops) +{ + *ops = &sfc_repr_flow_ops; + return 0; +} + static const struct eth_dev_ops sfc_repr_dev_ops = { .dev_configure = sfc_repr_dev_configure, .dev_start = sfc_repr_dev_start, @@ -901,6 +926,7 @@ static const struct eth_dev_ops sfc_repr_dev_ops = { .rx_queue_release = sfc_repr_rx_queue_release, .tx_queue_setup = sfc_repr_tx_queue_setup, .tx_queue_release = sfc_repr_tx_queue_release, + .flow_ops_get = sfc_repr_dev_flow_ops_get, };