From patchwork Fri Jun 9 10:54:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wenjun Wu X-Patchwork-Id: 128461 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6EBA942C6D; Fri, 9 Jun 2023 12:53:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6529640EDB; Fri, 9 Jun 2023 12:53:04 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 183C140A84; Fri, 9 Jun 2023 12:53:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686307983; x=1717843983; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qbJiOAXLLYKFNEtSyX9for3c4ne18sR23EWvqV3gngQ=; b=N7y+TSFaGSOQg/RVBeA7/nQx31fzXA0Jvruf3dz6pGh6a6/0EkTbRGfm DsNcUNewHVOBld+vyLo3Dip4Y0WL6HxyaHTqs4qqL99UZM5Wo57B5ulTy aELFRkYA3DqeBIzrKif7hkovpaE3fFd+sdS7miIyUF9584VH6UD5r7Ood 8VUA6rrBWX+9fFc1vmSwkFV3bvyyBGNxqKfteMNfP31Bp6SId9H6yG1oH O2EgwWNcQv6U44d2eYqy1nI9WVcScRajJoyFqe6KlBXuBgsKGW+6BqbkH UOPpuG6NHYZb7pKNfZTzCkw9yaeAJlfmc6e5hUAIafiTDIUEFq9NLldKA Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="355062996" X-IronPort-AV: E=Sophos;i="6.00,229,1681196400"; d="scan'208";a="355062996" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2023 03:53:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="1040463987" X-IronPort-AV: E=Sophos;i="6.00,229,1681196400"; d="scan'208";a="1040463987" Received: from dpdk-wuwenjun-icelake-ii.sh.intel.com ([10.67.110.188]) by fmsmga005.fm.intel.com with ESMTP; 09 Jun 2023 03:53:00 -0700 From: Wenjun Wu To: dev@dpdk.org, jingjing.wu@intel.com, beilei.xing@intel.com, qi.z.zhang@intel.com Cc: Wenjun Wu , stable@dpdk.org Subject: [PATCH v2] common/idpf: fix memory leak on AVX512 TX queue close Date: Fri, 9 Jun 2023 18:54:05 +0800 Message-Id: <20230609105405.1778979-1-wenjun1.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230531013955.1069485-1-wenjun1.wu@intel.com> References: <20230531013955.1069485-1-wenjun1.wu@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When releasing mbufs for TX queue software ring of AVX512, the mbuf in the range [i, tx_tail] should also be freed. The variable i refers to the index of the last mbuf released in the software ring. Fixes: 5bf87b45b2c8 ("net/idpf: add AVX512 data path for single queue model") Cc: stable@dpdk.org Signed-off-by: Wenjun Wu Acked-by: Qi Zhang --- drivers/common/idpf/idpf_common_rxtx_avx512.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/common/idpf/idpf_common_rxtx_avx512.c b/drivers/common/idpf/idpf_common_rxtx_avx512.c index dffb11fcf2..81312617cc 100644 --- a/drivers/common/idpf/idpf_common_rxtx_avx512.c +++ b/drivers/common/idpf/idpf_common_rxtx_avx512.c @@ -1601,6 +1601,10 @@ idpf_tx_release_mbufs_avx512(struct idpf_tx_queue *txq) } i = 0; } + for (; i < txq->tx_tail; i++) { + rte_pktmbuf_free_seg(swr[i].mbuf); + swr[i].mbuf = NULL; + } } static const struct idpf_txq_ops avx512_tx_vec_ops = {