From patchwork Wed Jun 14 14:26:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 128687 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A029B42CB3; Wed, 14 Jun 2023 16:31:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 91FC040FDF; Wed, 14 Jun 2023 16:31:11 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id C39A740DDB for ; Wed, 14 Jun 2023 16:31:09 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 632E45C01B9; Wed, 14 Jun 2023 10:31:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 14 Jun 2023 10:31:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1686753069; x= 1686839469; bh=874TzaWUY4F2NltiOvCDEIwv9Ij0a1AE1kFZkjFarz4=; b=P CeTbNxkvBnptr0myfTKtRbYU9eJQE9hwFiAyr0PqEsaUVY7oSKsZ3Ymgq4D0zKZ0 fut3vyJM0bjTu+P+hCkPWDDsnswnBilWEZ9p8MFf0VxEtshDntWdh+Re6sdzJ/zp rF7QWAzbrdE9V2YOWEj3EKwh32we8G4TXPutr1+GvC/a1SWTI/loZENEOPlvJHVL L535+C7F6+7Z3IOuesV2pfo6nQd+OdR94zSHf0p9kANZ5TnNZrdAG/c4c+pN2nvK 68ZWHbSsd36P9OweJcYPNKev1EZpkSzrboeN7X09wb39Lsh2LlBE9ISDdxSWpFql Zyp8SPE5qn+uZLy+YFC3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1686753069; x= 1686839469; bh=874TzaWUY4F2NltiOvCDEIwv9Ij0a1AE1kFZkjFarz4=; b=c RmbK7R4oFEgSnGiL0svh8+VHHbnY3XbuTsEGVRWlZgrZJPA4Y2zZId4wX9t81/jK 2Vs7s8ZgTEDhJjldd0BcIIP9xPzqrmZ+GkJ+8SJhrf/bEsSmUTFOfnvrohBxf1/l d30+rfoTlHUvTm2WTK8EkuNxjSYn6UyYsfbO4tOH/8IodO29io2GoBhbW536L3aC CfGN9g5gb3DNSpOl8SodQjurccFP4niZA0aaSMfd9DNIaceKswaZ8rszXB5RLGhM FTC0k7asCOJhep183tV9GYh4UEGYcDM/5KJDruZ/vloqTFWlarvlKeBPap2l0uPJ r8RX6FbsHYpOtdOiEz1RQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedvtddgjeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedvjefhudeghedvtdeijeeigeetuedugfejueekieeltdfhteev keehhfeilefhtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Jun 2023 10:31:02 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: Nicolas Chautru , Cristian Dumitrescu , Olivier Matz , Fan Zhang , Ashish Gupta , Akhil Goyal , Ruifeng Wang , Anatoly Burakov , Harman Kalra , Joyce Kong , Jerin Jacob , Sunil Kumar Kori , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Byron Marohn , Yipeng Wang , Ferruh Yigit , Andrew Rybchenko , Ori Kam , Erik Gabriel Carrillo , Kiran Kumar K , Nithin Dabilpuram , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , Konstantin Ananyev , Srikanth Yalavarthi , Pavan Nikhilesh , Reshma Pattan , Stephen Hemminger , Anoob Joseph , Volodymyr Fialko , David Hunt , Sachin Saxena , Hemant Agrawal , Honnappa Nagarahalli , Ciara Power Subject: [PATCH 1/5] lib: remove blank line ending comment blocks Date: Wed, 14 Jun 2023 16:26:47 +0200 Message-Id: <20230614142651.1456116-2-thomas@monjalon.net> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230614142651.1456116-1-thomas@monjalon.net> References: <20230614142651.1456116-1-thomas@monjalon.net> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org At the end of a comment, no need for an extra line. This pattern was fixed with the following command: git ls lib | xargs sed -i '/^ *\* *$/{N;/ *\*\/ *$/D;}' Signed-off-by: Thomas Monjalon Reviewed-by: Ruifeng Wang --- lib/bbdev/rte_bbdev.h | 2 -- lib/bbdev/rte_bbdev_op.h | 1 - lib/bbdev/rte_bbdev_pmd.h | 1 - lib/cfgfile/rte_cfgfile.h | 1 - lib/cmdline/cmdline_parse.h | 1 - lib/compressdev/rte_comp.h | 1 - lib/compressdev/rte_compressdev.h | 1 - lib/cryptodev/cryptodev_pmd.h | 1 - lib/cryptodev/rte_crypto.h | 1 - lib/cryptodev/rte_crypto_asym.h | 12 ------------ lib/cryptodev/rte_cryptodev.h | 3 --- lib/cryptodev/rte_cryptodev_core.h | 1 - lib/eal/arm/include/rte_cycles_64.h | 1 - lib/eal/common/eal_common_proc.c | 1 - lib/eal/include/generic/rte_pause.h | 1 - lib/eal/include/generic/rte_spinlock.h | 1 - lib/eal/include/rte_bitmap.h | 1 - lib/eal/include/rte_branch_prediction.h | 2 -- lib/eal/include/rte_eal.h | 2 -- lib/eal/include/rte_interrupts.h | 1 - lib/eal/include/rte_keepalive.h | 1 - lib/eal/include/rte_lcore.h | 1 - lib/eal/include/rte_tailq.h | 1 - lib/eal/include/rte_thread.h | 1 - lib/eal/include/rte_ticketlock.h | 1 - lib/eal/include/rte_trace_point.h | 1 - lib/eal/windows/include/sys/queue.h | 1 - lib/efd/rte_efd.c | 1 - lib/ethdev/ethdev_driver.h | 1 - lib/ethdev/rte_ethdev.c | 1 - lib/ethdev/rte_ethdev.h | 1 - lib/ethdev/rte_ethdev_core.h | 1 - lib/ethdev/rte_flow.h | 11 ----------- lib/ethdev/rte_mtr.h | 2 -- lib/ethdev/sff_8636.h | 2 -- lib/ethdev/sff_common.h | 1 - lib/eventdev/event_timer_adapter_pmd.h | 1 - lib/eventdev/eventdev_pmd.h | 17 ----------------- lib/eventdev/rte_event_timer_adapter.h | 2 -- lib/eventdev/rte_eventdev.h | 11 ----------- lib/graph/rte_graph.h | 2 -- lib/hash/rte_hash.h | 1 - lib/hash/rte_hash_crc.h | 1 - lib/ip_frag/rte_ipv6_fragmentation.c | 1 - lib/ip_frag/rte_ipv6_reassembly.c | 1 - lib/ipsec/ipsec_telemetry.c | 1 - lib/member/rte_member.h | 1 - lib/mempool/rte_mempool.c | 1 - lib/mempool/rte_mempool.h | 1 - lib/meter/rte_meter.h | 3 --- lib/mldev/mldev_utils.h | 1 - lib/node/rte_node_eth_api.h | 1 - lib/node/rte_node_ip4_api.h | 1 - lib/node/rte_node_ip6_api.h | 1 - lib/pcapng/rte_pcapng.h | 1 - lib/pdcp/rte_pdcp_group.h | 1 - lib/pipeline/rte_pipeline.c | 4 ---- lib/pipeline/rte_pipeline.h | 7 ------- lib/pipeline/rte_swx_ipsec.h | 2 -- lib/pipeline/rte_swx_pipeline_spec.c | 11 ----------- lib/port/rte_port.h | 3 --- lib/port/rte_port_ethdev.h | 1 - lib/port/rte_port_eventdev.h | 1 - lib/port/rte_port_fd.h | 1 - lib/port/rte_port_frag.h | 1 - lib/port/rte_port_kni.h | 1 - lib/port/rte_port_ras.h | 1 - lib/port/rte_port_ring.h | 1 - lib/port/rte_port_sched.h | 1 - lib/port/rte_port_source_sink.h | 1 - lib/port/rte_port_sym_crypto.h | 1 - lib/port/rte_swx_port_fd.h | 1 - lib/power/guest_channel.h | 1 - lib/rawdev/rte_rawdev.h | 2 -- lib/rawdev/rte_rawdev_pmd.h | 3 --- lib/rcu/rte_rcu_qsbr.h | 1 - lib/regexdev/rte_regexdev_core.h | 1 - lib/reorder/rte_reorder.h | 1 - lib/ring/rte_ring.h | 1 - lib/sched/rte_approx.h | 1 - lib/sched/rte_pie.h | 2 -- lib/sched/rte_red.h | 4 ---- lib/sched/rte_sched.c | 1 - lib/sched/rte_sched.h | 3 --- lib/sched/rte_sched_common.h | 2 -- lib/security/rte_security.h | 1 - lib/security/rte_security_driver.h | 1 - lib/table/rte_swx_table_em.c | 1 - lib/table/rte_table.h | 1 - lib/table/rte_table_acl.h | 1 - lib/table/rte_table_array.h | 1 - lib/table/rte_table_hash.h | 1 - lib/table/rte_table_hash_cuckoo.h | 1 - lib/table/rte_table_hash_ext.c | 2 -- lib/table/rte_table_hash_lru.c | 2 -- lib/table/rte_table_lpm.h | 1 - lib/table/rte_table_lpm_ipv6.h | 1 - lib/table/rte_table_stub.h | 1 - lib/telemetry/telemetry_internal.h | 1 - lib/telemetry/telemetry_json.h | 1 - 100 files changed, 192 deletions(-) diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h index 52f6ed9b01..f124e1f5db 100644 --- a/lib/bbdev/rte_bbdev.h +++ b/lib/bbdev/rte_bbdev.h @@ -963,7 +963,6 @@ rte_bbdev_queue_intr_ctl(uint16_t dev_id, uint16_t queue_id, int epfd, int op, * * @returns * Device status as string or NULL if invalid. - * */ __rte_experimental const char* @@ -977,7 +976,6 @@ rte_bbdev_device_status_str(enum rte_bbdev_device_status status); * * @returns * Queue status as string or NULL if op_type is invalid. - * */ __rte_experimental const char* diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h index 96a390cd9b..cb17a17cbc 100644 --- a/lib/bbdev/rte_bbdev_op.h +++ b/lib/bbdev/rte_bbdev_op.h @@ -936,7 +936,6 @@ struct rte_bbdev_op_pool_private { * * @returns * Operation type as string or NULL if op_type is invalid - * */ const char* rte_bbdev_op_type_str(enum rte_bbdev_op_type op_type); diff --git a/lib/bbdev/rte_bbdev_pmd.h b/lib/bbdev/rte_bbdev_pmd.h index 3da7a2bdf5..442b23943d 100644 --- a/lib/bbdev/rte_bbdev_pmd.h +++ b/lib/bbdev/rte_bbdev_pmd.h @@ -64,7 +64,6 @@ rte_bbdev_release(struct rte_bbdev *bbdev); * @return * - The device structure pointer, or * - NULL otherwise - * */ struct rte_bbdev * rte_bbdev_get_named_dev(const char *name); diff --git a/lib/cfgfile/rte_cfgfile.h b/lib/cfgfile/rte_cfgfile.h index b2030fa66c..ea7244bcac 100644 --- a/lib/cfgfile/rte_cfgfile.h +++ b/lib/cfgfile/rte_cfgfile.h @@ -17,7 +17,6 @@ extern "C" { * * This library allows reading application defined parameters from standard * format configuration file. -* ***/ #ifndef CFG_NAME_LEN diff --git a/lib/cmdline/cmdline_parse.h b/lib/cmdline/cmdline_parse.h index afc2fcd3dc..a852ac411c 100644 --- a/lib/cmdline/cmdline_parse.h +++ b/lib/cmdline/cmdline_parse.h @@ -142,7 +142,6 @@ typedef struct cmdline_inst cmdline_parse_inst_t; /** * A context is identified by its name, and contains a list of * instruction - * */ typedef cmdline_parse_inst_t *cmdline_parse_ctx_t; diff --git a/lib/compressdev/rte_comp.h b/lib/compressdev/rte_comp.h index 026a2814b5..bf896d0722 100644 --- a/lib/compressdev/rte_comp.h +++ b/lib/compressdev/rte_comp.h @@ -9,7 +9,6 @@ * @file rte_comp.h * * RTE definitions for Data Compression Service - * */ #ifdef __cplusplus diff --git a/lib/compressdev/rte_compressdev.h b/lib/compressdev/rte_compressdev.h index 7eb5c58798..13a4186318 100644 --- a/lib/compressdev/rte_compressdev.h +++ b/lib/compressdev/rte_compressdev.h @@ -495,7 +495,6 @@ rte_compressdev_enqueue_burst(uint8_t dev_id, uint16_t qp_id, * - Returns -ENOTSUP if comp device does not support STATEFUL operations. * - Returns -ENOTSUP if comp device does not support the comp transform. * - Returns -ENOMEM if the private stream could not be allocated. - * */ __rte_experimental int diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h index 0dfad9e24f..585c29df8a 100644 --- a/lib/cryptodev/cryptodev_pmd.h +++ b/lib/cryptodev/cryptodev_pmd.h @@ -390,7 +390,6 @@ typedef void (*cryptodev_asym_clear_session_t)(struct rte_cryptodev *dev, * * @return * - Returns number of successfully processed packets. - * */ typedef uint32_t (*cryptodev_sym_cpu_crypto_process_t) (struct rte_cryptodev *dev, struct rte_cryptodev_sym_session *sess, diff --git a/lib/cryptodev/rte_crypto.h b/lib/cryptodev/rte_crypto.h index f9644d29ec..7c9c413349 100644 --- a/lib/cryptodev/rte_crypto.h +++ b/lib/cryptodev/rte_crypto.h @@ -9,7 +9,6 @@ * @file rte_crypto.h * * RTE Cryptography Common Definitions - * */ #ifdef __cplusplus diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h index 083320e555..fc3f331393 100644 --- a/lib/cryptodev/rte_crypto_asym.h +++ b/lib/cryptodev/rte_crypto_asym.h @@ -76,7 +76,6 @@ enum rte_crypto_curve_id { * Asymmetric crypto transformation types. * Each xform type maps to one asymmetric algorithm * performing specific operation - * */ enum rte_crypto_asym_xform_type { RTE_CRYPTO_ASYM_XFORM_UNSPECIFIED = 0, @@ -181,7 +180,6 @@ enum rte_crypto_rsa_padding_type { * * enumerates private key format required to perform RSA crypto * transform. - * */ enum rte_crypto_rsa_priv_key_type { RTE_RSA_KEY_TYPE_EXP, @@ -303,7 +301,6 @@ struct rte_crypto_rsa_padding { * Asymmetric RSA transform data * * Structure describing RSA xform params - * */ struct rte_crypto_rsa_xform { rte_crypto_uint n; @@ -326,7 +323,6 @@ struct rte_crypto_rsa_xform { * Asymmetric Modular exponentiation transform data * * Structure describing modular exponentiation xform param - * */ struct rte_crypto_modex_xform { rte_crypto_uint modulus; @@ -339,7 +335,6 @@ struct rte_crypto_modex_xform { * Asymmetric modular multiplicative inverse transform operation * * Structure describing modular multiplicative inverse transform - * */ struct rte_crypto_modinv_xform { rte_crypto_uint modulus; @@ -350,7 +345,6 @@ struct rte_crypto_modinv_xform { * Asymmetric DH transform data * * Structure describing deffie-hellman xform params - * */ struct rte_crypto_dh_xform { rte_crypto_uint p; @@ -363,7 +357,6 @@ struct rte_crypto_dh_xform { * Asymmetric Digital Signature transform operation * * Structure describing DSA xform params - * */ struct rte_crypto_dsa_xform { rte_crypto_uint p; @@ -380,7 +373,6 @@ struct rte_crypto_dsa_xform { * Asymmetric elliptic curve transform data * * Structure describing all EC based xform params - * */ struct rte_crypto_ec_xform { enum rte_crypto_curve_id curve_id; @@ -400,7 +392,6 @@ struct rte_crypto_sm2_xform { /** * Operations params for modular operations: * exponentiation and multiplicative inverse - * */ struct rte_crypto_mod_op_param { rte_crypto_uint base; @@ -411,7 +402,6 @@ struct rte_crypto_mod_op_param { /** * RSA operation params - * */ struct rte_crypto_rsa_op_param { enum rte_crypto_asym_op_type op_type; @@ -545,7 +535,6 @@ struct rte_crypto_ecdh_op_param { /** * DSA Operations params - * */ struct rte_crypto_dsa_op_param { enum rte_crypto_asym_op_type op_type; @@ -734,7 +723,6 @@ struct rte_crypto_sm2_op_param { * Asymmetric Cryptographic Operation. * * Structure describing asymmetric crypto operation params. - * */ struct rte_crypto_asym_op { RTE_STD_C11 diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h index 228273df90..1674945229 100644 --- a/lib/cryptodev/rte_cryptodev.h +++ b/lib/cryptodev/rte_cryptodev.h @@ -162,7 +162,6 @@ struct rte_cryptodev_symmetric_capability { /** * Asymmetric Xform Crypto Capability - * */ struct rte_cryptodev_asymmetric_xform_capability { enum rte_crypto_asym_xform_type xform_type; @@ -188,7 +187,6 @@ struct rte_cryptodev_asymmetric_xform_capability { /** * Asymmetric Crypto Capability - * */ struct rte_cryptodev_asymmetric_capability { struct rte_cryptodev_asymmetric_xform_capability xform_capa; @@ -222,7 +220,6 @@ struct rte_cryptodev_sym_capability_idx { /** * Structure used to describe asymmetric crypto xforms * Each xform maps to one asym algorithm. - * */ struct rte_cryptodev_asym_capability_idx { enum rte_crypto_asym_xform_type type; diff --git a/lib/cryptodev/rte_cryptodev_core.h b/lib/cryptodev/rte_cryptodev_core.h index 16832f645d..5de89d099f 100644 --- a/lib/cryptodev/rte_cryptodev_core.h +++ b/lib/cryptodev/rte_cryptodev_core.h @@ -14,7 +14,6 @@ * public API because they are used by inline functions in the published API. * * Applications should not use these directly. - * */ typedef uint16_t (*dequeue_pkt_burst_t)(void *qp, diff --git a/lib/eal/arm/include/rte_cycles_64.h b/lib/eal/arm/include/rte_cycles_64.h index 029fdc4355..8b05302f47 100644 --- a/lib/eal/arm/include/rte_cycles_64.h +++ b/lib/eal/arm/include/rte_cycles_64.h @@ -72,7 +72,6 @@ rte_rdtsc(void) * val |= (BIT(0) | BIT(2)); * isb(); * asm volatile("msr pmcr_el0, %0" : : "r" (val)); - * */ /** Read PMU cycle counter */ diff --git a/lib/eal/common/eal_common_proc.c b/lib/eal/common/eal_common_proc.c index 1fc1d6c53b..7a038e0a3c 100644 --- a/lib/eal/common/eal_common_proc.c +++ b/lib/eal/common/eal_common_proc.c @@ -669,7 +669,6 @@ rte_mp_channel_cleanup(void) * Return -1, as fail to send message and it's caused by the local side. * Return 0, as fail to send message and it's caused by the remote side. * Return 1, as succeed to send message. - * */ static int send_msg(const char *dst_path, struct rte_mp_msg *msg, int type) diff --git a/lib/eal/include/generic/rte_pause.h b/lib/eal/include/generic/rte_pause.h index 2173a544d5..ec1f41819c 100644 --- a/lib/eal/include/generic/rte_pause.h +++ b/lib/eal/include/generic/rte_pause.h @@ -10,7 +10,6 @@ * @file * * CPU pause operation. - * */ #include diff --git a/lib/eal/include/generic/rte_spinlock.h b/lib/eal/include/generic/rte_spinlock.h index 8ca47bbfaa..c50ebaaa80 100644 --- a/lib/eal/include/generic/rte_spinlock.h +++ b/lib/eal/include/generic/rte_spinlock.h @@ -15,7 +15,6 @@ * a loop repeatedly checking until the lock becomes available. * * All locks must be initialised before use, and only initialised once. - * */ #include diff --git a/lib/eal/include/rte_bitmap.h b/lib/eal/include/rte_bitmap.h index 27ee3d18a4..25897ed512 100644 --- a/lib/eal/include/rte_bitmap.h +++ b/lib/eal/include/rte_bitmap.h @@ -32,7 +32,6 @@ extern "C" { * serialization of the bit set/clear and bitmap scan operations needs to be * enforced by the caller, while the bit get operation does not require locking * the bitmap. - * ***/ #include diff --git a/lib/eal/include/rte_branch_prediction.h b/lib/eal/include/rte_branch_prediction.h index 0256a9de60..414cd921ba 100644 --- a/lib/eal/include/rte_branch_prediction.h +++ b/lib/eal/include/rte_branch_prediction.h @@ -22,7 +22,6 @@ extern "C" { * * if (likely(x > 1)) * do_stuff(); - * */ #ifndef likely #define likely(x) __builtin_expect(!!(x), 1) @@ -36,7 +35,6 @@ extern "C" { * * if (unlikely(x < 1)) * do_stuff(); - * */ #ifndef unlikely #define unlikely(x) __builtin_expect(!!(x), 0) diff --git a/lib/eal/include/rte_eal.h b/lib/eal/include/rte_eal.h index d52f79f63d..b612577b38 100644 --- a/lib/eal/include/rte_eal.h +++ b/lib/eal/include/rte_eal.h @@ -240,7 +240,6 @@ rte_mp_action_register(const char *name, rte_mp_t action); * * @param name * The name argument plays as the nonredundant key to find the action. - * */ void rte_mp_action_unregister(const char *name); @@ -463,7 +462,6 @@ uint64_t rte_eal_get_baseaddr(void); * IOVA mapping mode is iommu programming mode of a device. * That device (for example: IOMMU backed DMA device) based * on rte_iova_mode will generate physical or virtual address. - * */ enum rte_iova_mode { RTE_IOVA_DC = 0, /* Don't care mode */ diff --git a/lib/eal/include/rte_interrupts.h b/lib/eal/include/rte_interrupts.h index 487e3c8875..bcafdd58a9 100644 --- a/lib/eal/include/rte_interrupts.h +++ b/lib/eal/include/rte_interrupts.h @@ -234,7 +234,6 @@ rte_intr_instance_alloc(uint32_t flags); * @param intr_handle * Interrupt handle allocated with rte_intr_instance_alloc(). * If intr_handle is NULL, no operation is performed. - * */ __rte_experimental void diff --git a/lib/eal/include/rte_keepalive.h b/lib/eal/include/rte_keepalive.h index 538fb09095..28c3064493 100644 --- a/lib/eal/include/rte_keepalive.h +++ b/lib/eal/include/rte_keepalive.h @@ -5,7 +5,6 @@ /** * @file rte_keepalive.h * DPDK RTE LCore Keepalive Monitor. - * **/ #ifndef _KEEPALIVE_H_ diff --git a/lib/eal/include/rte_lcore.h b/lib/eal/include/rte_lcore.h index 6a355e9986..6ce810b876 100644 --- a/lib/eal/include/rte_lcore.h +++ b/lib/eal/include/rte_lcore.h @@ -9,7 +9,6 @@ * @file * * API for lcore and socket manipulation - * */ #include diff --git a/lib/eal/include/rte_tailq.h b/lib/eal/include/rte_tailq.h index 0f67f9e4db..931d549e59 100644 --- a/lib/eal/include/rte_tailq.h +++ b/lib/eal/include/rte_tailq.h @@ -8,7 +8,6 @@ /** * @file * Here defines rte_tailq APIs for only internal use - * */ #ifdef __cplusplus diff --git a/lib/eal/include/rte_thread.h b/lib/eal/include/rte_thread.h index ddd411e067..369e2375f6 100644 --- a/lib/eal/include/rte_thread.h +++ b/lib/eal/include/rte_thread.h @@ -356,7 +356,6 @@ int rte_thread_set_affinity(rte_cpuset_t *cpusetp); * @param cpusetp * Pointer to CPU affinity of current thread. * It presumes input is not NULL, otherwise it causes panic. - * */ void rte_thread_get_affinity(rte_cpuset_t *cpusetp); diff --git a/lib/eal/include/rte_ticketlock.h b/lib/eal/include/rte_ticketlock.h index 693c67b517..5db0d8ae92 100644 --- a/lib/eal/include/rte_ticketlock.h +++ b/lib/eal/include/rte_ticketlock.h @@ -15,7 +15,6 @@ * serviced. * * All locks must be initialised before use, and only initialised once. - * */ #ifdef __cplusplus diff --git a/lib/eal/include/rte_trace_point.h b/lib/eal/include/rte_trace_point.h index 4d6b5700dd..c6b6fccda5 100644 --- a/lib/eal/include/rte_trace_point.h +++ b/lib/eal/include/rte_trace_point.h @@ -234,7 +234,6 @@ __rte_trace_point_fp_is_enabled(void) * @internal * * Allocate trace memory buffer per thread. - * */ __rte_experimental void __rte_trace_mem_per_thread_alloc(void); diff --git a/lib/eal/windows/include/sys/queue.h b/lib/eal/windows/include/sys/queue.h index 9756bee6fb..917526531b 100644 --- a/lib/eal/windows/include/sys/queue.h +++ b/lib/eal/windows/include/sys/queue.h @@ -83,7 +83,6 @@ * _REMOVE_HEAD + - + - * _REMOVE s + s + * _SWAP + + + + - * */ #ifdef QUEUE_MACRO_DEBUG #warn Use QUEUE_MACRO_DEBUG_TRACE and/or QUEUE_MACRO_DEBUG_TRASH diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c index 686a137757..dad962ce29 100644 --- a/lib/efd/rte_efd.c +++ b/lib/efd/rte_efd.c @@ -344,7 +344,6 @@ efd_get_choice(const struct rte_efd_table * const table, * Computed chunk ID * @param bin_id * Computed bin ID - * */ static inline void efd_compute_ids(const struct rte_efd_table * const table, diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h index 367c0c4878..980f837ab6 100644 --- a/lib/ethdev/ethdev_driver.h +++ b/lib/ethdev/ethdev_driver.h @@ -16,7 +16,6 @@ extern "C" { * * These APIs for the use from Ethernet drivers, user applications shouldn't * use them. - * */ #include diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index 7317015895..4428428adc 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -1109,7 +1109,6 @@ eth_dev_check_lro_pkt_size(uint16_t port_id, uint32_t config_size, * @return * - (0) if validation successful. * - (-EINVAL) if requested offload has been silently disabled. - * */ static int eth_dev_validate_offloads(uint16_t port_id, uint64_t req_offloads, diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index 34ca25bbc0..e550f09889 100644 --- a/lib/ethdev/rte_ethdev.h +++ b/lib/ethdev/rte_ethdev.h @@ -6372,7 +6372,6 @@ rte_eth_tx_burst(uint16_t port_id, uint16_t queue_id, * - EINVAL: offload flags are not correctly set * - ENOTSUP: the offload feature is not supported by the hardware * - ENODEV: if *port_id* is invalid (with debug enabled only) - * */ #ifndef RTE_ETHDEV_TX_PREPARE_NOOP diff --git a/lib/ethdev/rte_ethdev_core.h b/lib/ethdev/rte_ethdev_core.h index dcf8adab92..46e9721e07 100644 --- a/lib/ethdev/rte_ethdev_core.h +++ b/lib/ethdev/rte_ethdev_core.h @@ -16,7 +16,6 @@ * public API because they are used by inline functions in the published API. * * Applications should not use these directly. - * */ struct rte_eth_dev_callback; diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index dec454275f..f1d6b4de30 100644 --- a/lib/ethdev/rte_flow.h +++ b/lib/ethdev/rte_flow.h @@ -1726,7 +1726,6 @@ static const struct rte_flow_item_mark rte_flow_item_mark_mask = { * RTE_FLOW_ITEM_TYPE_NSH * * Match network service header (NSH), RFC 8300 - * */ struct rte_flow_item_nsh { uint32_t version:2; @@ -1758,7 +1757,6 @@ static const struct rte_flow_item_nsh rte_flow_item_nsh_mask = { * RTE_FLOW_ITEM_TYPE_IGMP * * Match Internet Group Management Protocol (IGMP), RFC 2236 - * */ struct rte_flow_item_igmp { uint32_t type:8; @@ -1781,7 +1779,6 @@ static const struct rte_flow_item_igmp rte_flow_item_igmp_mask = { * RTE_FLOW_ITEM_TYPE_AH * * Match IP Authentication Header (AH), RFC 4302 - * */ struct rte_flow_item_ah { uint32_t next_hdr:8; @@ -3028,7 +3025,6 @@ struct rte_flow_action_quota { * Query indirect QUOTA action. * * @see RTE_FLOW_ACTION_TYPE_QUOTA - * */ struct rte_flow_query_quota { int64_t quota; /**< Quota value. */ @@ -3422,7 +3418,6 @@ struct rte_flow_action_of_push_mpls { * - ETH / IPV4 / UDP / VXLAN / END * - ETH / IPV6 / UDP / VXLAN / END * - ETH / VLAN / IPV4 / UDP / VXLAN / END - * */ struct rte_flow_action_vxlan_encap { /** @@ -3456,7 +3451,6 @@ struct rte_flow_action_vxlan_encap { * * - ETH / IPV4 / NVGRE / END * - ETH / VLAN / IPV6 / NVGRE / END - * */ struct rte_flow_action_nvgre_encap { /** @@ -4041,7 +4035,6 @@ struct rte_flow_action_meter_mark { * RTE_FLOW_ACTION_TYPE_METER_MARK * * Wrapper structure for the context update interface. - * */ struct rte_flow_update_meter_mark { /** New meter_mark parameters to be updated. */ @@ -5285,7 +5278,6 @@ rte_flow_flex_item_release(uint16_t port_id, * * Information about flow engine resources. * The zero value means a resource is not supported. - * */ struct rte_flow_port_info { /** @@ -5329,7 +5321,6 @@ struct rte_flow_port_info { * * Information about flow engine asynchronous queues. * The value only valid if @p port_attr.max_nb_queues is not zero. - * */ struct rte_flow_queue_info { /** @@ -5379,7 +5370,6 @@ rte_flow_info_get(uint16_t port_id, * * Flow engine resources settings. * The zero value means on demand resource allocations only. - * */ struct rte_flow_port_attr { /** @@ -5423,7 +5413,6 @@ struct rte_flow_port_attr { * * Flow engine asynchronous queues settings. * The value means default value picked by PMD. - * */ struct rte_flow_queue_attr { /** diff --git a/lib/ethdev/rte_mtr.h b/lib/ethdev/rte_mtr.h index 46c398dd8b..7e6a66b938 100644 --- a/lib/ethdev/rte_mtr.h +++ b/lib/ethdev/rte_mtr.h @@ -223,7 +223,6 @@ struct rte_mtr_meter_policy_params { * applicable for the current input packet wins; * if none is both enabled and applicable, the default input color is used. * @see function rte_mtr_color_in_protocol_set() - * */ enum rte_mtr_color_in_protocol { /** @@ -1043,7 +1042,6 @@ rte_mtr_color_in_protocol_set(uint16_t port_id, uint32_t mtr_id, * Error details. Filled in only on error, when not NULL. * @return * 0 on success, non-zero error code otherwise. - * */ __rte_experimental int diff --git a/lib/ethdev/sff_8636.h b/lib/ethdev/sff_8636.h index 70f70353d0..cf11a2c247 100644 --- a/lib/ethdev/sff_8636.h +++ b/lib/ethdev/sff_8636.h @@ -17,7 +17,6 @@ * * Lower Memory Page 00h * Measurement, Diagnostic and Control Functions - * */ /* Identifier - 0 */ /* Values are defined under SFF_8024_ID_OFFSET */ @@ -221,7 +220,6 @@ * * Upper Memory Page 00h * Serial ID - Base ID, Extended ID and Vendor Specific ID fields - * */ /* Identifier - 128 */ /* Identifier values same as Lower Memory Page 00h */ diff --git a/lib/ethdev/sff_common.h b/lib/ethdev/sff_common.h index e44f3c7bf3..2e42cbe8be 100644 --- a/lib/ethdev/sff_common.h +++ b/lib/ethdev/sff_common.h @@ -3,7 +3,6 @@ * * Implements SFF-8024 Rev 4.0 of pluggable I/O configuration and some * common utilities for SFF-8436/8636 and SFF-8472/8079 - * */ #ifndef _SFF_COMMON_H_ diff --git a/lib/eventdev/event_timer_adapter_pmd.h b/lib/eventdev/event_timer_adapter_pmd.h index c7d4a4f0f6..8f3e6c4851 100644 --- a/lib/eventdev/event_timer_adapter_pmd.h +++ b/lib/eventdev/event_timer_adapter_pmd.h @@ -14,7 +14,6 @@ * This file provides implementation helpers for internal use by PMDs. They * are not intended to be exposed to applications and are not subject to ABI * versioning. - * */ #ifdef __cplusplus diff --git a/lib/eventdev/eventdev_pmd.h b/lib/eventdev/eventdev_pmd.h index aebab26852..c68c3a2262 100644 --- a/lib/eventdev/eventdev_pmd.h +++ b/lib/eventdev/eventdev_pmd.h @@ -310,7 +310,6 @@ typedef int (*eventdev_close_t)(struct rte_eventdev *dev); * Event queue index * @param[out] queue_conf * Event queue configuration structure - * */ typedef void (*eventdev_queue_default_conf_get_t)(struct rte_eventdev *dev, uint8_t queue_id, struct rte_event_queue_conf *queue_conf); @@ -339,7 +338,6 @@ typedef int (*eventdev_queue_setup_t)(struct rte_eventdev *dev, * Event device pointer * @param queue_id * Event queue index - * */ typedef void (*eventdev_queue_release_t)(struct rte_eventdev *dev, uint8_t queue_id); @@ -373,7 +371,6 @@ typedef int (*eventdev_queue_attr_set_t)(struct rte_eventdev *dev, * Event port index * @param[out] port_conf * Event port configuration structure - * */ typedef void (*eventdev_port_default_conf_get_t)(struct rte_eventdev *dev, uint8_t port_id, struct rte_event_port_conf *port_conf); @@ -400,7 +397,6 @@ typedef int (*eventdev_port_setup_t)(struct rte_eventdev *dev, * * @param port * Event port pointer - * */ typedef void (*eventdev_port_release_t)(void *port); @@ -415,7 +411,6 @@ typedef void (*eventdev_port_release_t)(void *port); * User-provided event flush function. * @param args * Arguments to be passed to the user-provided event flush function. - * */ typedef void (*eventdev_port_quiesce_t)(struct rte_eventdev *dev, void *port, rte_eventdev_port_flush_t flush_cb, @@ -439,7 +434,6 @@ typedef void (*eventdev_port_quiesce_t)(struct rte_eventdev *dev, void *port, * * @return * Returns 0 on success. - * */ typedef int (*eventdev_port_link_t)(struct rte_eventdev *dev, void *port, const uint8_t queues[], const uint8_t priorities[], @@ -459,7 +453,6 @@ typedef int (*eventdev_port_link_t)(struct rte_eventdev *dev, void *port, * * @return * Returns 0 on success. - * */ typedef int (*eventdev_port_unlink_t)(struct rte_eventdev *dev, void *port, uint8_t queues[], uint16_t nb_unlinks); @@ -493,7 +486,6 @@ typedef int (*eventdev_port_unlinks_in_progress_t)(struct rte_eventdev *dev, * * @return * Returns 0 on success. - * */ typedef int (*eventdev_dequeue_timeout_ticks_t)(struct rte_eventdev *dev, uint64_t ns, uint64_t *timeout_ticks); @@ -505,7 +497,6 @@ typedef int (*eventdev_dequeue_timeout_ticks_t)(struct rte_eventdev *dev, * Event device pointer * @param f * A pointer to a file for output - * */ typedef void (*eventdev_dump_t)(struct rte_eventdev *dev, FILE *f); @@ -602,7 +593,6 @@ typedef uint64_t (*eventdev_xstats_get_by_name)(const struct rte_eventdev *dev, * - 0: Success, driver provides Rx event adapter capabilities for the * ethernet device. * - <0: Error code returned by the driver function. - * */ typedef int (*eventdev_eth_rx_adapter_caps_get_t) (const struct rte_eventdev *dev, @@ -634,7 +624,6 @@ struct rte_event_eth_rx_adapter_queue_conf; * - 0: Success, driver provides Rx event adapter capabilities for the * ethernet device. * - <0: Error code returned by the driver function. - * */ typedef int (*eventdev_timer_adapter_caps_get_t)( const struct rte_eventdev *dev, uint64_t flags, uint32_t *caps, @@ -660,7 +649,6 @@ typedef int (*eventdev_timer_adapter_caps_get_t)( * @return * - 0: Success, ethernet receive queue added successfully. * - <0: Error code returned by the driver function. - * */ typedef int (*eventdev_eth_rx_adapter_queue_add_t)( const struct rte_eventdev *dev, @@ -685,7 +673,6 @@ typedef int (*eventdev_eth_rx_adapter_queue_add_t)( * @return * - 0: Success, ethernet receive queue deleted successfully. * - <0: Error code returned by the driver function. - * */ typedef int (*eventdev_eth_rx_adapter_queue_del_t) (const struct rte_eventdev *dev, @@ -932,7 +919,6 @@ struct rte_event_crypto_adapter_queue_conf; * - 0: Success, driver provides event adapter capabilities for the * cryptodev. * - <0: Error code returned by the driver function. - * */ typedef int (*eventdev_crypto_adapter_caps_get_t) (const struct rte_eventdev *dev, @@ -963,7 +949,6 @@ typedef int (*eventdev_crypto_adapter_caps_get_t) * @return * - 0: Success, cryptodev queue pair added successfully. * - <0: Error code returned by the driver function. - * */ typedef int (*eventdev_crypto_adapter_queue_pair_add_t)( const struct rte_eventdev *dev, @@ -991,7 +976,6 @@ typedef int (*eventdev_crypto_adapter_queue_pair_add_t)( * @return * - 0: Success, cryptodev queue pair deleted successfully. * - <0: Error code returned by the driver function. - * */ typedef int (*eventdev_crypto_adapter_queue_pair_del_t) (const struct rte_eventdev *dev, @@ -1114,7 +1098,6 @@ typedef int (*eventdev_crypto_adapter_vector_limits_get_t)( * @return * - 0: Success, driver provides eth Tx adapter capabilities * - <0: Error code returned by the driver function. - * */ typedef int (*eventdev_eth_tx_adapter_caps_get_t) (const struct rte_eventdev *dev, diff --git a/lib/eventdev/rte_event_timer_adapter.h b/lib/eventdev/rte_event_timer_adapter.h index 9a771ac679..9ac35b7d5a 100644 --- a/lib/eventdev/rte_event_timer_adapter.h +++ b/lib/eventdev/rte_event_timer_adapter.h @@ -310,7 +310,6 @@ struct rte_event_timer_adapter_info { * * @see RTE_EVENT_TIMER_ADAPTER_F_ADJUST_RES, * struct rte_event_timer_adapter_info - * */ int rte_event_timer_adapter_get_info( @@ -596,7 +595,6 @@ struct rte_event_timer_adapter { * - EALREADY A timer was encountered that was already armed * * @see RTE_EVENT_TIMER_ADAPTER_F_PERIODIC - * */ static inline uint16_t rte_event_timer_arm_burst(const struct rte_event_timer_adapter *adapter, diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h index a90e23ac8b..b6a4fa1495 100644 --- a/lib/eventdev/rte_eventdev.h +++ b/lib/eventdev/rte_eventdev.h @@ -203,7 +203,6 @@ * rte_event_enqueue_burst(...); * } * \endcode - * */ #ifdef __cplusplus @@ -462,7 +461,6 @@ struct rte_event_dev_info { * @return * - 0: Success, driver updates the contextual information of the event device * - <0: Error code returned by the driver info get function. - * */ int rte_event_dev_info_get(uint8_t dev_id, struct rte_event_dev_info *dev_info); @@ -679,7 +677,6 @@ struct rte_event_queue_conf { * - <0: Error code returned by the driver info get function. * * @see rte_event_queue_setup() - * */ int rte_event_queue_default_conf_get(uint8_t dev_id, uint8_t queue_id, @@ -881,7 +878,6 @@ struct rte_event_port_conf { * - <0: Error code returned by the driver info get function. * * @see rte_event_port_setup() - * */ int rte_event_port_default_conf_get(uint8_t dev_id, uint8_t port_id, @@ -1271,7 +1267,6 @@ struct rte_event_vector { * * This operation must only be enqueued to the same port that the * event to be released was dequeued from. - * */ /** @@ -1388,7 +1383,6 @@ struct rte_event { * - 0: Success, driver provides Rx event adapter capabilities for the * ethernet device. * - <0: Error code returned by the driver function. - * */ int rte_event_eth_rx_adapter_caps_get(uint8_t dev_id, uint16_t eth_port_id, @@ -1464,7 +1458,6 @@ rte_event_timer_adapter_caps_get(uint8_t dev_id, uint32_t *caps); * - 0: Success, driver provides event adapter capabilities for the * cryptodev device. * - <0: Error code returned by the driver function. - * */ int rte_event_crypto_adapter_caps_get(uint8_t dev_id, uint8_t cdev_id, @@ -1494,7 +1487,6 @@ rte_event_crypto_adapter_caps_get(uint8_t dev_id, uint8_t cdev_id, * @return * - 0: Success, driver provides eth Tx adapter capabilities. * - <0: Error code returned by the driver function. - * */ int rte_event_eth_tx_adapter_caps_get(uint8_t dev_id, uint16_t eth_port_id, @@ -1523,7 +1515,6 @@ rte_event_eth_tx_adapter_caps_get(uint8_t dev_id, uint16_t eth_port_id, * * @see rte_event_dequeue_burst(), RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT * @see rte_event_dev_configure() - * */ int rte_event_dequeue_timeout_ticks(uint8_t dev_id, uint64_t ns, @@ -1587,7 +1578,6 @@ rte_event_dequeue_timeout_ticks(uint8_t dev_id, uint64_t ns, * (EDQUOT) Quota exceeded(Application tried to link the queue configured with * RTE_EVENT_QUEUE_CFG_SINGLE_LINK to more than one event ports) * (EINVAL) Invalid parameter - * */ int rte_event_port_link(uint8_t dev_id, uint8_t port_id, @@ -1686,7 +1676,6 @@ rte_event_port_unlinks_in_progress(uint8_t dev_id, uint8_t port_id); * The number of links established on the event port designated by its * *port_id*. * - <0 on failure. - * */ int rte_event_port_links_get(uint8_t dev_id, uint8_t port_id, diff --git a/lib/graph/rte_graph.h b/lib/graph/rte_graph.h index c9a77297fc..c30de0c5bb 100644 --- a/lib/graph/rte_graph.h +++ b/lib/graph/rte_graph.h @@ -20,7 +20,6 @@ * dump and destroy on graph and node operations such as clone, * edge update, and edge shrink, etc. The API also allows to create the stats * cluster to monitor per graph and per node stats. - * */ #include @@ -95,7 +94,6 @@ struct rte_graph_cluster_node_stats; /**< Node stats within cluster of graphs */ * Number of objects processed. * * @see rte_graph_walk() - * */ typedef uint16_t (*rte_node_process_t)(struct rte_graph *graph, struct rte_node *node, void **objs, diff --git a/lib/hash/rte_hash.h b/lib/hash/rte_hash.h index a399346d02..7ecc021111 100644 --- a/lib/hash/rte_hash.h +++ b/lib/hash/rte_hash.h @@ -176,7 +176,6 @@ rte_hash_find_existing(const char *name); * * @param h * Hash table to free, if NULL, the function does nothing. - * */ void rte_hash_free(struct rte_hash *h); diff --git a/lib/hash/rte_hash_crc.h b/lib/hash/rte_hash_crc.h index 0249ad16c5..60bf42ce1d 100644 --- a/lib/hash/rte_hash_crc.h +++ b/lib/hash/rte_hash_crc.h @@ -51,7 +51,6 @@ static uint8_t crc32_alg = CRC32_SW; * - (CRC32_SSE42) Use SSE4.2 intrinsics if available * - (CRC32_SSE42_x64) Use 64-bit SSE4.2 intrinsic if available (default x86) * - (CRC32_ARM64) Use ARMv8 CRC intrinsic if available (default ARMv8) - * */ static inline void rte_hash_crc_set_alg(uint8_t alg) diff --git a/lib/ip_frag/rte_ipv6_fragmentation.c b/lib/ip_frag/rte_ipv6_fragmentation.c index 2e692418b5..56696f32f8 100644 --- a/lib/ip_frag/rte_ipv6_fragmentation.c +++ b/lib/ip_frag/rte_ipv6_fragmentation.c @@ -14,7 +14,6 @@ * RTE IPv6 Fragmentation * * Implementation of IPv6 fragmentation. - * */ static inline void diff --git a/lib/ip_frag/rte_ipv6_reassembly.c b/lib/ip_frag/rte_ipv6_reassembly.c index d4019e87e6..88863a98d1 100644 --- a/lib/ip_frag/rte_ipv6_reassembly.c +++ b/lib/ip_frag/rte_ipv6_reassembly.c @@ -13,7 +13,6 @@ * IPv6 reassemble * * Implementation of IPv6 reassembly. - * */ static inline void diff --git a/lib/ipsec/ipsec_telemetry.c b/lib/ipsec/ipsec_telemetry.c index 90d4b67156..68a91108dd 100644 --- a/lib/ipsec/ipsec_telemetry.c +++ b/lib/ipsec/ipsec_telemetry.c @@ -41,7 +41,6 @@ handle_telemetry_cmd_ipsec_sa_list(const char *cmd __rte_unused, * "SA_SPI_XX": {"count": 0, "bytes": 0, "errors": 0}, * "SA_SPI_YY": {"count": 0, "bytes": 0, "errors": 0} * } - * */ static int handle_telemetry_cmd_ipsec_sa_stats(const char *cmd __rte_unused, diff --git a/lib/member/rte_member.h b/lib/member/rte_member.h index 072a253c89..237d403714 100644 --- a/lib/member/rte_member.h +++ b/lib/member/rte_member.h @@ -213,7 +213,6 @@ struct rte_member_setsum { * Parameters used when create the set summary table. Currently user can * specify two types of setsummary: HT based and vBF. For HT based, user can * specify cache or non-cache mode. Here is a table to describe some differences - * */ struct rte_member_parameters { const char *name; /**< Name of the hash. */ diff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c index cf5dea2304..4d337fca8d 100644 --- a/lib/mempool/rte_mempool.c +++ b/lib/mempool/rte_mempool.c @@ -55,7 +55,6 @@ mempool_event_callback_invoke(enum rte_mempool_event event, #if defined(RTE_ARCH_X86) /* * return the greatest common divisor between a and b (fast algorithm) - * */ static unsigned get_gcd(unsigned a, unsigned b) { diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h index e53f9e7abd..160975a7e7 100644 --- a/lib/mempool/rte_mempool.h +++ b/lib/mempool/rte_mempool.h @@ -1867,7 +1867,6 @@ void rte_mempool_list_dump(FILE *f); * NULL on error * with rte_errno set appropriately. Possible rte_errno values include: * - ENOENT - required entry not available to return. - * */ struct rte_mempool *rte_mempool_lookup(const char *name); diff --git a/lib/meter/rte_meter.h b/lib/meter/rte_meter.h index 0932645d0a..d2c91b3a40 100644 --- a/lib/meter/rte_meter.h +++ b/lib/meter/rte_meter.h @@ -18,7 +18,6 @@ extern "C" { * 1. Single Rate Three Color Marker (srTCM): defined by IETF RFC 2697 * 2. Two Rate Three Color Marker (trTCM): defined by IETF RFC 2698 * 3. Two Rate Three Color Marker (trTCM): defined by IETF RFC 4115 - * ***/ #include @@ -26,7 +25,6 @@ extern "C" { /* * Application Programmer's Interface (API) - * ***/ /** @@ -328,7 +326,6 @@ rte_meter_trtcm_rfc4115_color_aware_check( /* * Inline implementation of run-time methods - * ***/ struct rte_meter_srtcm_profile { diff --git a/lib/mldev/mldev_utils.h b/lib/mldev/mldev_utils.h index 7d798a92a5..5bc8020453 100644 --- a/lib/mldev/mldev_utils.h +++ b/lib/mldev/mldev_utils.h @@ -15,7 +15,6 @@ extern "C" { * ML Device PMD utility API * * These APIs for the use from ML drivers, user applications shouldn't use them. - * */ #include diff --git a/lib/node/rte_node_eth_api.h b/lib/node/rte_node_eth_api.h index 1e7477349c..40b2021f01 100644 --- a/lib/node/rte_node_eth_api.h +++ b/lib/node/rte_node_eth_api.h @@ -14,7 +14,6 @@ * * This API allows to setup ethdev_rx and ethdev_tx nodes * and its queue associations. - * */ #ifdef __cplusplus diff --git a/lib/node/rte_node_ip4_api.h b/lib/node/rte_node_ip4_api.h index 46d0d8976b..3397da0ae8 100644 --- a/lib/node/rte_node_ip4_api.h +++ b/lib/node/rte_node_ip4_api.h @@ -14,7 +14,6 @@ * * This API allows to do control path functions of ip4_* nodes * like ip4_lookup, ip4_rewrite. - * */ #ifdef __cplusplus extern "C" { diff --git a/lib/node/rte_node_ip6_api.h b/lib/node/rte_node_ip6_api.h index 1459ccef47..f3b5a1002a 100644 --- a/lib/node/rte_node_ip6_api.h +++ b/lib/node/rte_node_ip6_api.h @@ -14,7 +14,6 @@ * * This API allows to do control path functions of ip6_* nodes * like ip6_lookup, ip6_rewrite. - * */ #ifdef __cplusplus extern "C" { diff --git a/lib/pcapng/rte_pcapng.h b/lib/pcapng/rte_pcapng.h index 4afdec22ef..d93cc9f73a 100644 --- a/lib/pcapng/rte_pcapng.h +++ b/lib/pcapng/rte_pcapng.h @@ -131,7 +131,6 @@ enum rte_pcapng_direction { * @return * - The pointer to the new mbuf formatted for pcapng_write * - NULL if allocation fails. - * */ __rte_experimental struct rte_mbuf * diff --git a/lib/pdcp/rte_pdcp_group.h b/lib/pdcp/rte_pdcp_group.h index 2ac2af9b36..f6a94ff587 100644 --- a/lib/pdcp/rte_pdcp_group.h +++ b/lib/pdcp/rte_pdcp_group.h @@ -78,7 +78,6 @@ rte_pdcp_en_from_cop(const struct rte_crypto_op *cop) * The maximum number of crypto-ops to process. * @return * Number of filled elements in *grp* array. - * */ static inline uint16_t rte_pdcp_pkt_crypto_group(struct rte_crypto_op *cop[], struct rte_mbuf *mb[], diff --git a/lib/pipeline/rte_pipeline.c b/lib/pipeline/rte_pipeline.c index ff86c7cf96..1fa9f9c47e 100644 --- a/lib/pipeline/rte_pipeline.c +++ b/lib/pipeline/rte_pipeline.c @@ -155,7 +155,6 @@ rte_pipeline_port_out_free(struct rte_port_out *port); /* * Pipeline - * */ static int rte_pipeline_check_params(struct rte_pipeline_params *params) @@ -267,7 +266,6 @@ rte_pipeline_free(struct rte_pipeline *p) /* * Table - * */ static int rte_table_check_params(struct rte_pipeline *p, @@ -682,7 +680,6 @@ int rte_pipeline_table_entry_delete_bulk(struct rte_pipeline *p, /* * Port - * */ static int rte_pipeline_port_in_check_params(struct rte_pipeline *p, @@ -1030,7 +1027,6 @@ rte_pipeline_port_in_disable(struct rte_pipeline *p, uint32_t port_id) /* * Pipeline run-time - * */ int rte_pipeline_check(struct rte_pipeline *p) diff --git a/lib/pipeline/rte_pipeline.h b/lib/pipeline/rte_pipeline.h index 3cfb6868f7..267dbcfa2c 100644 --- a/lib/pipeline/rte_pipeline.h +++ b/lib/pipeline/rte_pipeline.h @@ -51,7 +51,6 @@ extern "C" { * Thread safety. It is possible to have multiple pipelines running on * the same CPU core, but it is not allowed (for thread safety reasons) to have * multiple CPU cores running the same pipeline instance. - * ***/ #include @@ -64,7 +63,6 @@ struct rte_mbuf; /* * Pipeline - * */ /** Opaque data type for pipeline */ struct rte_pipeline; @@ -175,7 +173,6 @@ int rte_pipeline_flush(struct rte_pipeline *p); /* * Actions - * */ /** Reserved actions */ enum rte_pipeline_action { @@ -197,7 +194,6 @@ enum rte_pipeline_action { /* * Table - * */ /** Maximum number of tables allowed for any given pipeline instance. The value of this parameter cannot be changed. */ @@ -530,7 +526,6 @@ int rte_pipeline_table_stats_read(struct rte_pipeline *p, uint32_t table_id, /* * Port IN - * */ /** Maximum number of input ports allowed for any given pipeline instance. The value of this parameter cannot be changed. */ @@ -662,7 +657,6 @@ int rte_pipeline_port_in_stats_read(struct rte_pipeline *p, uint32_t port_id, /* * Port OUT - * */ /** Maximum number of output ports allowed for any given pipeline instance. The value of this parameter cannot be changed. */ @@ -753,7 +747,6 @@ int rte_pipeline_port_out_stats_read(struct rte_pipeline *p, uint32_t port_id, /* * Functions to be called as part of the port IN/OUT or table action handlers - * */ /** * Action handler packet insert to output port diff --git a/lib/pipeline/rte_swx_ipsec.h b/lib/pipeline/rte_swx_ipsec.h index ebfb7ea5ea..a43e341cac 100644 --- a/lib/pipeline/rte_swx_ipsec.h +++ b/lib/pipeline/rte_swx_ipsec.h @@ -87,7 +87,6 @@ struct rte_swx_ipsec_burst_size { /** * IPsec instance configuration parameters - * */ struct rte_swx_ipsec_params { /** Input packet queue. */ @@ -111,7 +110,6 @@ struct rte_swx_ipsec_params { /** * IPsec input packet meta-data - * */ struct rte_swx_ipsec_input_packet_metadata { /* SA ID. */ diff --git a/lib/pipeline/rte_swx_pipeline_spec.c b/lib/pipeline/rte_swx_pipeline_spec.c index 006b24082a..2bba0d0524 100644 --- a/lib/pipeline/rte_swx_pipeline_spec.c +++ b/lib/pipeline/rte_swx_pipeline_spec.c @@ -102,7 +102,6 @@ extobj_statement_parse(struct extobj_spec *s, /* * struct. - * */ static void struct_spec_free(struct struct_spec *s) @@ -279,7 +278,6 @@ struct_block_parse(struct struct_spec *s, /* * header. - * */ static void header_spec_free(struct header_spec *s) @@ -331,7 +329,6 @@ header_statement_parse(struct header_spec *s, /* * metadata. - * */ static void metadata_spec_free(struct metadata_spec *s) @@ -375,7 +372,6 @@ metadata_statement_parse(struct metadata_spec *s, /* * action. - * */ static void action_spec_free(struct action_spec *s) @@ -504,7 +500,6 @@ action_block_parse(struct action_spec *s, /* * table. - * */ static void table_spec_free(struct table_spec *s) @@ -1059,7 +1054,6 @@ table_block_parse(struct table_spec *s, /* * selector. - * */ static void selector_spec_free(struct selector_spec *s) @@ -1345,7 +1339,6 @@ selector_block_parse(struct selector_spec *s, /* * learner. - * */ static void learner_spec_free(struct learner_spec *s) @@ -1927,7 +1920,6 @@ learner_block_parse(struct learner_spec *s, /* * regarray. - * */ static void regarray_spec_free(struct regarray_spec *s) @@ -1995,7 +1987,6 @@ regarray_statement_parse(struct regarray_spec *s, /* * metarray. - * */ static void metarray_spec_free(struct metarray_spec *s) @@ -2052,7 +2043,6 @@ metarray_statement_parse(struct metarray_spec *s, /* * * rss - * */ static void @@ -2097,7 +2087,6 @@ rss_statement_parse(struct rss_spec *s, /* * apply. - * */ static void apply_spec_free(struct apply_spec *s) diff --git a/lib/port/rte_port.h b/lib/port/rte_port.h index 6b6a2cdd17..f001ffbacf 100644 --- a/lib/port/rte_port.h +++ b/lib/port/rte_port.h @@ -15,7 +15,6 @@ extern "C" { * * This tool is part of the DPDK Packet Framework tool suite and provides * a standard interface to implement different types of packet ports. - * ***/ #include @@ -46,7 +45,6 @@ extern "C" { /* * Port IN - * */ /** Maximum number of packets read from any input port in a single burst. Cannot be changed. */ @@ -125,7 +123,6 @@ struct rte_port_in_ops { /* * Port OUT - * */ /** Output port statistics */ struct rte_port_out_stats { diff --git a/lib/port/rte_port_ethdev.h b/lib/port/rte_port_ethdev.h index 7f28d512f1..b607365c98 100644 --- a/lib/port/rte_port_ethdev.h +++ b/lib/port/rte_port_ethdev.h @@ -15,7 +15,6 @@ extern "C" { * * ethdev_reader: input port built on top of pre-initialized NIC RX queue * ethdev_writer: output port built on top of pre-initialized NIC TX queue - * ***/ #include diff --git a/lib/port/rte_port_eventdev.h b/lib/port/rte_port_eventdev.h index 966e9cdafb..bf3f8254af 100644 --- a/lib/port/rte_port_eventdev.h +++ b/lib/port/rte_port_eventdev.h @@ -17,7 +17,6 @@ extern "C" { * interface * eventdev_writer: output port built on top of pre-initialized eventdev * interface - * **/ #include diff --git a/lib/port/rte_port_fd.h b/lib/port/rte_port_fd.h index c8cfd9765a..810b0e9cc0 100644 --- a/lib/port/rte_port_fd.h +++ b/lib/port/rte_port_fd.h @@ -15,7 +15,6 @@ extern "C" { * * fd_reader: input port built on top of valid non-blocking file descriptor * fd_writer: output port built on top of valid non-blocking file descriptor - * ***/ #include diff --git a/lib/port/rte_port_frag.h b/lib/port/rte_port_frag.h index 07060297f6..69fdc000f1 100644 --- a/lib/port/rte_port_frag.h +++ b/lib/port/rte_port_frag.h @@ -24,7 +24,6 @@ extern "C" { * packets read from the ring are all non-jumbo frames. The complete IP * datagrams written to the ring are not changed. The jumbo frames are * fragmented into several IP packets with length less or equal to MTU. - * ***/ #include diff --git a/lib/port/rte_port_kni.h b/lib/port/rte_port_kni.h index 35c6253806..54227251f6 100644 --- a/lib/port/rte_port_kni.h +++ b/lib/port/rte_port_kni.h @@ -16,7 +16,6 @@ extern "C" { * * kni_reader: input port built on top of pre-initialized KNI interface * kni_writer: output port built on top of pre-initialized KNI interface - * ***/ #include diff --git a/lib/port/rte_port_ras.h b/lib/port/rte_port_ras.h index ee1d8ae21e..8fd8ae8444 100644 --- a/lib/port/rte_port_ras.h +++ b/lib/port/rte_port_ras.h @@ -25,7 +25,6 @@ extern "C" { * The complete IP datagrams written to the ring are not changed. The IP * fragments written to the ring are first reassembled and into complete IP * datagrams or dropped on error or IP reassembly time-out. - * ***/ #include diff --git a/lib/port/rte_port_ring.h b/lib/port/rte_port_ring.h index ba609b3436..9532ac1d22 100644 --- a/lib/port/rte_port_ring.h +++ b/lib/port/rte_port_ring.h @@ -21,7 +21,6 @@ extern "C" { * input port built on top of pre-initialized multi consumers ring * ring_multi_writer: * output port built on top of pre-initialized multi producers ring - * ***/ #include diff --git a/lib/port/rte_port_sched.h b/lib/port/rte_port_sched.h index 953451463f..5f46297a60 100644 --- a/lib/port/rte_port_sched.h +++ b/lib/port/rte_port_sched.h @@ -15,7 +15,6 @@ extern "C" { * * sched_reader: input port built on top of pre-initialized rte_sched_port * sched_writer: output port built on top of pre-initialized rte_sched_port - * ***/ #include diff --git a/lib/port/rte_port_source_sink.h b/lib/port/rte_port_source_sink.h index 16b8318e52..c2ddb297f4 100644 --- a/lib/port/rte_port_source_sink.h +++ b/lib/port/rte_port_source_sink.h @@ -15,7 +15,6 @@ extern "C" { * * source: input port that can be used to generate packets * sink: output port that drops all packets written to it - * ***/ #include "rte_port.h" diff --git a/lib/port/rte_port_sym_crypto.h b/lib/port/rte_port_sym_crypto.h index 181f6ce01d..4cf8566633 100644 --- a/lib/port/rte_port_sym_crypto.h +++ b/lib/port/rte_port_sym_crypto.h @@ -15,7 +15,6 @@ extern "C" { * * crypto_reader: input port built on top of pre-initialized crypto interface * crypto_writer: output port built on top of pre-initialized crypto interface - * **/ #include diff --git a/lib/port/rte_swx_port_fd.h b/lib/port/rte_swx_port_fd.h index c1a9200a4f..2dd1480a42 100644 --- a/lib/port/rte_swx_port_fd.h +++ b/lib/port/rte_swx_port_fd.h @@ -12,7 +12,6 @@ extern "C" { /** * @file * RTE SWX FD Input and Output Ports - * ***/ #include diff --git a/lib/power/guest_channel.h b/lib/power/guest_channel.h index bdda1367f0..409fa67b74 100644 --- a/lib/power/guest_channel.h +++ b/lib/power/guest_channel.h @@ -39,7 +39,6 @@ int guest_channel_host_connect(const char *path, unsigned int lcore_id); * * @param lcore_id * lcore_id. - * */ void guest_channel_host_disconnect(unsigned int lcore_id); diff --git a/lib/rawdev/rte_rawdev.h b/lib/rawdev/rte_rawdev.h index 66080eae9e..36c9c9a9b4 100644 --- a/lib/rawdev/rte_rawdev.h +++ b/lib/rawdev/rte_rawdev.h @@ -90,7 +90,6 @@ struct rte_rawdev_info; * @return * - 0: Success, driver updates the contextual information of the raw device * - <0: Error code returned by the driver info get function. - * */ int rte_rawdev_info_get(uint16_t dev_id, struct rte_rawdev_info *dev_info, @@ -152,7 +151,6 @@ rte_rawdev_configure(uint16_t dev_id, struct rte_rawdev_info *dev_conf, * - <0: Error code returned by the driver info get function. * * @see rte_raw_queue_setup() - * */ int rte_rawdev_queue_conf_get(uint16_t dev_id, diff --git a/lib/rawdev/rte_rawdev_pmd.h b/lib/rawdev/rte_rawdev_pmd.h index a51944c8ff..7b9ef1d09f 100644 --- a/lib/rawdev/rte_rawdev_pmd.h +++ b/lib/rawdev/rte_rawdev_pmd.h @@ -254,7 +254,6 @@ typedef int (*rawdev_queue_setup_t)(struct rte_rawdev *dev, * Raw device pointer * @param queue_id * Raw queue index - * */ typedef int (*rawdev_queue_release_t)(struct rte_rawdev *dev, uint16_t queue_id); @@ -273,7 +272,6 @@ typedef int (*rawdev_queue_release_t)(struct rte_rawdev *dev, * Raw device pointer * @return * Number of queues; 0 is assumed to be a valid response. - * */ typedef uint16_t (*rawdev_queue_count_t)(struct rte_rawdev *dev); @@ -339,7 +337,6 @@ typedef int (*rawdev_dequeue_bufs_t)(struct rte_rawdev *dev, * @return * 0 for success, * !0 Error - * */ typedef int (*rawdev_dump_t)(struct rte_rawdev *dev, FILE *f); diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index 1aa078e2c2..87e1b55153 100644 --- a/lib/rcu/rte_rcu_qsbr.h +++ b/lib/rcu/rte_rcu_qsbr.h @@ -226,7 +226,6 @@ rte_rcu_qsbr_get_memsize(uint32_t max_threads); * On error - 1 with error code set in rte_errno. * Possible rte_errno codes are: * - EINVAL - max_threads is 0 or 'v' is NULL. - * */ int rte_rcu_qsbr_init(struct rte_rcu_qsbr *v, uint32_t max_threads); diff --git a/lib/regexdev/rte_regexdev_core.h b/lib/regexdev/rte_regexdev_core.h index a5576d353f..15ba712b86 100644 --- a/lib/regexdev/rte_regexdev_core.h +++ b/lib/regexdev/rte_regexdev_core.h @@ -14,7 +14,6 @@ * in order to expose their ops to the class. * * Applications should not use these API directly. - * */ struct rte_regexdev; diff --git a/lib/reorder/rte_reorder.h b/lib/reorder/rte_reorder.h index 06a8d56e3f..56a6507f9f 100644 --- a/lib/reorder/rte_reorder.h +++ b/lib/reorder/rte_reorder.h @@ -12,7 +12,6 @@ * Reorder library is a component which is designed to * provide ordering of out of ordered packets based on * sequence number present in mbuf. - * */ #include diff --git a/lib/ring/rte_ring.h b/lib/ring/rte_ring.h index 7e4cd60650..c709f30497 100644 --- a/lib/ring/rte_ring.h +++ b/lib/ring/rte_ring.h @@ -32,7 +32,6 @@ * Note: the ring implementation is not preemptible. Refer to Programmer's * guide/Environment Abstraction Layer/Multiple pthread/Known Issues/rte_ring * for more information. - * */ #ifdef __cplusplus diff --git a/lib/sched/rte_approx.h b/lib/sched/rte_approx.h index 74d55f457b..0200fa1521 100644 --- a/lib/sched/rte_approx.h +++ b/lib/sched/rte_approx.h @@ -16,7 +16,6 @@ extern "C" { * Given a rational number alpha with 0 < alpha < 1 and a precision d, the goal * is to find positive integers p, q such that alpha - d < p/q < alpha + d, and * q is minimal. - * ***/ #include diff --git a/lib/sched/rte_pie.h b/lib/sched/rte_pie.h index 2236b98a71..cb52fd933e 100644 --- a/lib/sched/rte_pie.h +++ b/lib/sched/rte_pie.h @@ -32,7 +32,6 @@ extern "C" { /** * PIE configuration parameters passed by user - * */ struct rte_pie_params { uint16_t qdelay_ref; /**< Latency Target (milliseconds) */ @@ -43,7 +42,6 @@ struct rte_pie_params { /** * PIE configuration parameters - * */ struct rte_pie_config { uint64_t qdelay_ref; /**< Latency Target (in CPU cycles.) */ diff --git a/lib/sched/rte_red.h b/lib/sched/rte_red.h index 80b43b6da0..13a9ad24a8 100644 --- a/lib/sched/rte_red.h +++ b/lib/sched/rte_red.h @@ -12,8 +12,6 @@ extern "C" { /** * @file * RTE Random Early Detection (RED) - * - * ***/ #include @@ -35,7 +33,6 @@ extern "C" { /** * Externs - * */ extern uint32_t rte_red_rand_val; extern uint32_t rte_red_rand_seed; @@ -44,7 +41,6 @@ extern uint16_t rte_red_pow2_frac_inv[16]; /** * RED configuration parameters passed by user - * */ struct rte_red_params { uint16_t min_th; /**< Minimum threshold for queue (max_th) */ diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index 19768d8c38..e7787344b3 100644 --- a/lib/sched/rte_sched.c +++ b/lib/sched/rte_sched.c @@ -2043,7 +2043,6 @@ rte_sched_port_enqueue_qwa(struct rte_sched_port *port, * | 0 | | 1 | | 2 | | 3 | * ----->|_______|----->|_______|----->|_______|----->|_______|-----> * p01 p11 p21 p31 - * */ int rte_sched_port_enqueue(struct rte_sched_port *port, struct rte_mbuf **pkts, diff --git a/lib/sched/rte_sched.h b/lib/sched/rte_sched.h index a33292b066..c7081ceeef 100644 --- a/lib/sched/rte_sched.h +++ b/lib/sched/rte_sched.h @@ -53,7 +53,6 @@ extern "C" { * the same user; * - Weighted Round Robin (WRR) is used to service the * queues within same pipe lowest priority traffic class (best-effort). - * */ #include @@ -310,7 +309,6 @@ struct rte_sched_port_params { /* * Configuration - * ***/ /** @@ -436,7 +434,6 @@ rte_sched_port_get_memory_footprint(struct rte_sched_port_params *port_params, struct rte_sched_subport_params **subport_params); /* * Statistics - * ***/ /** diff --git a/lib/sched/rte_sched_common.h b/lib/sched/rte_sched_common.h index e4cbbd9077..419700b1a5 100644 --- a/lib/sched/rte_sched_common.h +++ b/lib/sched/rte_sched_common.h @@ -49,7 +49,6 @@ rte_min_pos_4_u16(uint16_t *x) * This implementation uses Euclid's algorithm: * gcd(a, 0) = a * gcd(a, b) = gcd(b, a mod b) - * */ static inline uint64_t rte_get_gcd64(uint64_t a, uint64_t b) @@ -89,7 +88,6 @@ rte_get_gcd(uint32_t a, uint32_t b) * Compute the Lowest Common Denominator (LCD) of two numbers. * This implementation computes GCD first: * LCD(a, b) = (a * b) / GCD(a, b) - * */ static inline uint32_t rte_get_lcd(uint32_t a, uint32_t b) diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h index 30bac4e25a..daef846d40 100644 --- a/lib/security/rte_security.h +++ b/lib/security/rte_security.h @@ -10,7 +10,6 @@ * @file rte_security.h * * RTE Security Common Definitions - * */ #ifdef __cplusplus diff --git a/lib/security/rte_security_driver.h b/lib/security/rte_security_driver.h index 677c7d1f91..31444a05d3 100644 --- a/lib/security/rte_security_driver.h +++ b/lib/security/rte_security_driver.h @@ -10,7 +10,6 @@ * @file rte_security_driver.h * * RTE Security Common Definitions - * */ #ifdef __cplusplus diff --git a/lib/table/rte_swx_table_em.c b/lib/table/rte_swx_table_em.c index 2b5201e006..84837c8be4 100644 --- a/lib/table/rte_swx_table_em.c +++ b/lib/table/rte_swx_table_em.c @@ -489,7 +489,6 @@ table_mailbox_size_get(void) * match = 1111_1111_1111_1110 = 0xFFFE * match_many = 1111_1110_1110_1000 = 0xFEE8 * match_pos = 0001_0010_0001_0011__0001_0010_0001_0000 = 0x12131210 - * */ #define LUT_MATCH 0xFFFE diff --git a/lib/table/rte_table.h b/lib/table/rte_table.h index 096ab8a7c8..3f592d1aa2 100644 --- a/lib/table/rte_table.h +++ b/lib/table/rte_table.h @@ -22,7 +22,6 @@ extern "C" { * use-case, the lookup key is an n-tuple of packet fields that uniquely * identifies a traffic flow, while data represents actions and action * meta-data associated with the same traffic flow. - * ***/ #include diff --git a/lib/table/rte_table_acl.h b/lib/table/rte_table_acl.h index 516819213c..673725f82e 100644 --- a/lib/table/rte_table_acl.h +++ b/lib/table/rte_table_acl.h @@ -17,7 +17,6 @@ extern "C" { * associate data to lookup keys. * * Use-cases: Firewall rule database, etc. - * ***/ #include diff --git a/lib/table/rte_table_array.h b/lib/table/rte_table_array.h index b16c5dfe5b..ac3ca59c75 100644 --- a/lib/table/rte_table_array.h +++ b/lib/table/rte_table_array.h @@ -14,7 +14,6 @@ extern "C" { * RTE Table Array * * Simple array indexing. Lookup key is the array entry index. - * ***/ #include diff --git a/lib/table/rte_table_hash.h b/lib/table/rte_table_hash.h index 61a0eed6c5..5d1a0e2bea 100644 --- a/lib/table/rte_table_hash.h +++ b/lib/table/rte_table_hash.h @@ -46,7 +46,6 @@ extern "C" { * 2. Key size: * a. Configurable key size * b. Single key size (8-byte, 16-byte or 32-byte key size) - * ***/ #include diff --git a/lib/table/rte_table_hash_cuckoo.h b/lib/table/rte_table_hash_cuckoo.h index d9d4312190..cb5a771c8b 100644 --- a/lib/table/rte_table_hash_cuckoo.h +++ b/lib/table/rte_table_hash_cuckoo.h @@ -12,7 +12,6 @@ extern "C" { /** * @file * RTE Table Hash Cuckoo - * ***/ #include diff --git a/lib/table/rte_table_hash_ext.c b/lib/table/rte_table_hash_ext.c index 70ea84fa2e..bd97dc5eba 100644 --- a/lib/table/rte_table_hash_ext.c +++ b/lib/table/rte_table_hash_ext.c @@ -552,7 +552,6 @@ static int rte_table_hash_ext_lookup_unoptimized( * match = 0xFFFELLU * match_many = 0xFEE8LLU * match_pos = 0x12131210LLU - * ***/ #define LUT_MATCH 0xFFFELLU @@ -844,7 +843,6 @@ static int rte_table_hash_ext_lookup_unoptimized( * * The naming convention is: * pXY = packet Y of stage X, X = 0 .. 3, Y = 0 .. 1 -* ***/ static int rte_table_hash_ext_lookup( void *table, diff --git a/lib/table/rte_table_hash_lru.c b/lib/table/rte_table_hash_lru.c index c31acc11cf..354cd5aee4 100644 --- a/lib/table/rte_table_hash_lru.c +++ b/lib/table/rte_table_hash_lru.c @@ -489,7 +489,6 @@ static int rte_table_hash_lru_lookup_unoptimized( * match = 0xFFFELLU * match_many = 0xFEE8LLU * match_pos = 0x12131210LLU -* ***/ #define LUT_MATCH 0xFFFELLU @@ -796,7 +795,6 @@ static int rte_table_hash_lru_lookup_unoptimized( * * The naming convention is: * pXY = packet Y of stage X, X = 0 .. 3, Y = 0 .. 1 -* ***/ static int rte_table_hash_lru_lookup( void *table, diff --git a/lib/table/rte_table_lpm.h b/lib/table/rte_table_lpm.h index 571ff2f009..135f07384c 100644 --- a/lib/table/rte_table_lpm.h +++ b/lib/table/rte_table_lpm.h @@ -39,7 +39,6 @@ extern "C" { * has to carefully manage the format of the LPM table entry (i.e. the next * hop information) so that any next hop data that changes value during * run-time (e.g. counters) is placed outside of this area. - * ***/ #include diff --git a/lib/table/rte_table_lpm_ipv6.h b/lib/table/rte_table_lpm_ipv6.h index eadc316ee1..a6cea2c707 100644 --- a/lib/table/rte_table_lpm_ipv6.h +++ b/lib/table/rte_table_lpm_ipv6.h @@ -39,7 +39,6 @@ extern "C" { * has to carefully manage the format of the LPM table entry (i.e. the next * hop information) so that any next hop data that changes value during * run-time (e.g. counters) is placed outside of this area. - * ***/ #include diff --git a/lib/table/rte_table_stub.h b/lib/table/rte_table_stub.h index 9086e4edcc..b4aa0a16a2 100644 --- a/lib/table/rte_table_stub.h +++ b/lib/table/rte_table_stub.h @@ -14,7 +14,6 @@ extern "C" { * RTE Table Stub * * The stub table lookup operation produces lookup miss for all input packets. - * ***/ diff --git a/lib/telemetry/telemetry_internal.h b/lib/telemetry/telemetry_internal.h index d085c492dc..37d79bcb24 100644 --- a/lib/telemetry/telemetry_internal.h +++ b/lib/telemetry/telemetry_internal.h @@ -14,7 +14,6 @@ * * @file * RTE Telemetry Legacy and internal definitions - * ***/ /** diff --git a/lib/telemetry/telemetry_json.h b/lib/telemetry/telemetry_json.h index 7a246deacb..31a3d56756 100644 --- a/lib/telemetry/telemetry_json.h +++ b/lib/telemetry/telemetry_json.h @@ -18,7 +18,6 @@ * * This file contains small inline functions to make it easier for applications * to build up valid JSON responses to telemetry requests. - * ***/ /** From patchwork Wed Jun 14 14:26:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 128688 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85F2C42CB3; Wed, 14 Jun 2023 16:31:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 11F73427F5; Wed, 14 Jun 2023 16:31:16 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id ED6DB4161A for ; Wed, 14 Jun 2023 16:31:14 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 7C3565C01C5; Wed, 14 Jun 2023 10:31:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 14 Jun 2023 10:31:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1686753074; x= 1686839474; bh=2cVhPhrWL0fBT4BcmNObtD819OnD/lMvUkMTK+ilrDg=; b=R mg2roHhvSlyVDXCchNI10vOM2bdWBLhWyTFA/FFHxnZcMNunTj/MQTjMa+qlhfEK /Xrg1s5rMxQKQ+5WBCmeHmjNSs7Vcu2NOJIqWijBeItE+jKBZYlO6X+TEtYUmtjf NQfL7d55aiWs4gSM/sKl9SkB7L6knUSwnUiwt9ZeMX+QafmROQTY0fNNCBlz0lqG 3cvsj3h29frx0+5S7TAxRo5z2ZaNRrXBAQMmR66WnJ5CcU+h5z8OUH26XQokYG2M pmXEXbZgSd5M4BetJqATIJ5DQeleYvQSSpJm8zhJZj0KdLl/RmwlNlfnbfM0zB1E 9i+U2oSgmNqBdpcWI/mpw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1686753074; x= 1686839474; bh=2cVhPhrWL0fBT4BcmNObtD819OnD/lMvUkMTK+ilrDg=; b=j /dwSltVYg+b6ocQENiBw5BkngqKFHGYjMWLbFzReL+X2EqZJTEmxiWzZb4xDo5XI qz8qqC2D46uVtdTtZls0pjEY5XSx9psrf78GlPV2F54GVCGYgFIOgIHtUfNmR7jg Voitr98UWLShewanmvZXR0eBLJ6X2zhabXXa3ncPTMHZkpSgixb4ZLa0te0FpAZA zAYsrKhQUR9Pg3AFDxu8R634gNoNMI2NKYautk21fiJ7ctRlyNAykT5NUAvJL3ZU 4WheeHJmHPhwo2x4zNHgBUXtBX1VdnWz581o8ZAPY8Wa8wtUg1ynp6KxkIEFUYTy cP3f3EAlVBToSuc2KgaDw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedvtddgjeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedvjefhudeghedvtdeijeeigeetuedugfejueekieeltdfhteev keehhfeilefhtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Jun 2023 10:31:12 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: Cristian Dumitrescu , Akhil Goyal , Fan Zhang , Anatoly Burakov , Ori Kam , Ferruh Yigit , Andrew Rybchenko , Ciara Power Subject: [PATCH 2/5] lib: remove extra asterisks ending comment blocks Date: Wed, 14 Jun 2023 16:26:48 +0200 Message-Id: <20230614142651.1456116-3-thomas@monjalon.net> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230614142651.1456116-1-thomas@monjalon.net> References: <20230614142651.1456116-1-thomas@monjalon.net> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org A comment should always be terminated with */ Extra asterisks were found with this kind of command: git grep '\* *\*/' lib Signed-off-by: Thomas Monjalon --- lib/cfgfile/rte_cfgfile.h | 2 +- lib/cryptodev/rte_crypto_sym.h | 2 +- lib/cryptodev/rte_cryptodev.h | 4 ++-- lib/eal/include/rte_bitmap.h | 2 +- lib/eal/include/rte_keepalive.h | 2 +- lib/eal/linux/eal_vfio.h | 4 ++-- lib/ethdev/rte_flow.h | 4 ++-- lib/meter/rte_meter.h | 7 +++---- lib/pipeline/rte_pipeline.h | 2 +- lib/pipeline/rte_table_action.c | 2 +- lib/port/rte_port.h | 2 +- lib/port/rte_port_ethdev.h | 2 +- lib/port/rte_port_eventdev.h | 2 +- lib/port/rte_port_fd.h | 2 +- lib/port/rte_port_frag.h | 2 +- lib/port/rte_port_kni.h | 3 +-- lib/port/rte_port_ras.h | 3 +-- lib/port/rte_port_ring.h | 3 +-- lib/port/rte_port_sched.h | 2 +- lib/port/rte_port_source_sink.h | 2 +- lib/port/rte_port_sym_crypto.h | 2 +- lib/port/rte_swx_port_fd.h | 4 ++-- lib/port/rte_swx_port_ring.h | 3 +-- lib/sched/rte_approx.h | 2 +- lib/sched/rte_pie.h | 2 +- lib/sched/rte_red.h | 2 +- lib/sched/rte_sched.c | 2 +- lib/sched/rte_sched.h | 5 +++-- lib/table/rte_table.h | 2 +- lib/table/rte_table_acl.h | 2 +- lib/table/rte_table_array.h | 2 +- lib/table/rte_table_hash.h | 3 ++- lib/table/rte_table_hash_cuckoo.h | 3 ++- lib/table/rte_table_hash_ext.c | 9 ++++----- lib/table/rte_table_hash_lru.c | 9 ++++----- lib/table/rte_table_lpm.h | 2 +- lib/table/rte_table_lpm_ipv6.h | 2 +- lib/table/rte_table_stub.h | 3 +-- lib/telemetry/rte_telemetry.h | 2 +- lib/telemetry/telemetry_internal.h | 2 +- lib/telemetry/telemetry_json.h | 2 +- 41 files changed, 57 insertions(+), 62 deletions(-) diff --git a/lib/cfgfile/rte_cfgfile.h b/lib/cfgfile/rte_cfgfile.h index ea7244bcac..7729c133b4 100644 --- a/lib/cfgfile/rte_cfgfile.h +++ b/lib/cfgfile/rte_cfgfile.h @@ -17,7 +17,7 @@ extern "C" { * * This library allows reading application defined parameters from standard * format configuration file. -***/ + */ #ifndef CFG_NAME_LEN #define CFG_NAME_LEN 64 diff --git a/lib/cryptodev/rte_crypto_sym.h b/lib/cryptodev/rte_crypto_sym.h index 152d40623f..76c868c503 100644 --- a/lib/cryptodev/rte_crypto_sym.h +++ b/lib/cryptodev/rte_crypto_sym.h @@ -246,7 +246,7 @@ struct rte_crypto_cipher_xform { * (key1 || key2). * - Each key can be either 128 bits (16 bytes) or 256 bits (32 bytes). * - Both keys must have the same size. - **/ + */ struct { uint16_t offset; /**< Starting point for Initialisation Vector or Counter, diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h index 1674945229..be708edc0f 100644 --- a/lib/cryptodev/rte_cryptodev.h +++ b/lib/cryptodev/rte_cryptodev.h @@ -1407,7 +1407,7 @@ typedef int (*cryptodev_sym_raw_operation_done_t)(void *qp, uint8_t *drv_ctx, * @param user_data Dequeued user data. * @return * - The number of operations to be dequeued. - **/ + */ typedef uint32_t (*rte_cryptodev_raw_get_dequeue_count_t)(void *user_data); /** @@ -1417,7 +1417,7 @@ typedef uint32_t (*rte_cryptodev_raw_get_dequeue_count_t)(void *user_data); * @param user_data Dequeued user data. * @param index Index number of the processed descriptor. * @param is_op_success Operation status provided by the driver. - **/ + */ typedef void (*rte_cryptodev_raw_post_dequeue_t)(void *user_data, uint32_t index, uint8_t is_op_success); diff --git a/lib/eal/include/rte_bitmap.h b/lib/eal/include/rte_bitmap.h index 25897ed512..46a822768d 100644 --- a/lib/eal/include/rte_bitmap.h +++ b/lib/eal/include/rte_bitmap.h @@ -32,7 +32,7 @@ extern "C" { * serialization of the bit set/clear and bitmap scan operations needs to be * enforced by the caller, while the bit get operation does not require locking * the bitmap. - ***/ + */ #include #include diff --git a/lib/eal/include/rte_keepalive.h b/lib/eal/include/rte_keepalive.h index 28c3064493..3ec413da01 100644 --- a/lib/eal/include/rte_keepalive.h +++ b/lib/eal/include/rte_keepalive.h @@ -5,7 +5,7 @@ /** * @file rte_keepalive.h * DPDK RTE LCore Keepalive Monitor. - **/ + */ #ifndef _KEEPALIVE_H_ #define _KEEPALIVE_H_ diff --git a/lib/eal/linux/eal_vfio.h b/lib/eal/linux/eal_vfio.h index bba5c7afa5..dc8ef32bb7 100644 --- a/lib/eal/linux/eal_vfio.h +++ b/lib/eal/linux/eal_vfio.h @@ -99,14 +99,14 @@ struct vfio_group { /* DMA mapping function prototype. * Takes VFIO container fd as a parameter. * Returns 0 on success, -1 on error. - * */ + */ typedef int (*vfio_dma_func_t)(int); /* Custom memory region DMA mapping function prototype. * Takes VFIO container fd, virtual address, physical address, length and * operation type (0 to unmap 1 for map) as a parameters. * Returns 0 on success, -1 on error. - **/ + */ typedef int (*vfio_dma_user_func_t)(int fd, uint64_t vaddr, uint64_t iova, uint64_t len, int do_map); diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index f1d6b4de30..e11c4a044a 100644 --- a/lib/ethdev/rte_flow.h +++ b/lib/ethdev/rte_flow.h @@ -4315,7 +4315,7 @@ enum rte_flow_conv_op { * @code (const void *)enum rte_flow_item_type @endcode * - @p dst type: * @code char * @endcode - **/ + */ RTE_FLOW_CONV_OP_ITEM_NAME, /** @@ -4329,7 +4329,7 @@ enum rte_flow_conv_op { * @code (const void *)enum rte_flow_action_type @endcode * - @p dst type: * @code char * @endcode - **/ + */ RTE_FLOW_CONV_OP_ACTION_NAME, /** diff --git a/lib/meter/rte_meter.h b/lib/meter/rte_meter.h index d2c91b3a40..6ba9967436 100644 --- a/lib/meter/rte_meter.h +++ b/lib/meter/rte_meter.h @@ -18,14 +18,13 @@ extern "C" { * 1. Single Rate Three Color Marker (srTCM): defined by IETF RFC 2697 * 2. Two Rate Three Color Marker (trTCM): defined by IETF RFC 2698 * 3. Two Rate Three Color Marker (trTCM): defined by IETF RFC 4115 - ***/ + */ #include - /* * Application Programmer's Interface (API) - ***/ + */ /** * Color @@ -326,7 +325,7 @@ rte_meter_trtcm_rfc4115_color_aware_check( /* * Inline implementation of run-time methods - ***/ + */ struct rte_meter_srtcm_profile { uint64_t cbs; diff --git a/lib/pipeline/rte_pipeline.h b/lib/pipeline/rte_pipeline.h index 267dbcfa2c..68ab40dd19 100644 --- a/lib/pipeline/rte_pipeline.h +++ b/lib/pipeline/rte_pipeline.h @@ -51,7 +51,7 @@ extern "C" { * Thread safety. It is possible to have multiple pipelines running on * the same CPU core, but it is not allowed (for thread safety reasons) to have * multiple CPU cores running the same pipeline instance. - ***/ + */ #include diff --git a/lib/pipeline/rte_table_action.c b/lib/pipeline/rte_table_action.c index de5da0b695..59d71ee50d 100644 --- a/lib/pipeline/rte_table_action.c +++ b/lib/pipeline/rte_table_action.c @@ -1956,7 +1956,7 @@ pkt_work_sym_crypto(struct rte_mbuf *mbuf, struct sym_crypto_data *data, /** For encryption, update the pkt iv field, otherwise * update the iv_aad_field - **/ + */ if (data->direction == RTE_CRYPTO_CIPHER_OP_ENCRYPT) rte_memcpy(pkt_iv, data->iv_aad_data, data->cipher_auth.cipher_iv_update_len); diff --git a/lib/port/rte_port.h b/lib/port/rte_port.h index f001ffbacf..0e30db371e 100644 --- a/lib/port/rte_port.h +++ b/lib/port/rte_port.h @@ -15,7 +15,7 @@ extern "C" { * * This tool is part of the DPDK Packet Framework tool suite and provides * a standard interface to implement different types of packet ports. - ***/ + */ #include #include diff --git a/lib/port/rte_port_ethdev.h b/lib/port/rte_port_ethdev.h index b607365c98..e07021cb89 100644 --- a/lib/port/rte_port_ethdev.h +++ b/lib/port/rte_port_ethdev.h @@ -15,7 +15,7 @@ extern "C" { * * ethdev_reader: input port built on top of pre-initialized NIC RX queue * ethdev_writer: output port built on top of pre-initialized NIC TX queue - ***/ + */ #include diff --git a/lib/port/rte_port_eventdev.h b/lib/port/rte_port_eventdev.h index bf3f8254af..0efb8e1021 100644 --- a/lib/port/rte_port_eventdev.h +++ b/lib/port/rte_port_eventdev.h @@ -17,7 +17,7 @@ extern "C" { * interface * eventdev_writer: output port built on top of pre-initialized eventdev * interface -**/ + */ #include #include diff --git a/lib/port/rte_port_fd.h b/lib/port/rte_port_fd.h index 810b0e9cc0..885b9ada22 100644 --- a/lib/port/rte_port_fd.h +++ b/lib/port/rte_port_fd.h @@ -15,7 +15,7 @@ extern "C" { * * fd_reader: input port built on top of valid non-blocking file descriptor * fd_writer: output port built on top of valid non-blocking file descriptor - ***/ + */ #include diff --git a/lib/port/rte_port_frag.h b/lib/port/rte_port_frag.h index 69fdc000f1..4055872e8d 100644 --- a/lib/port/rte_port_frag.h +++ b/lib/port/rte_port_frag.h @@ -24,7 +24,7 @@ extern "C" { * packets read from the ring are all non-jumbo frames. The complete IP * datagrams written to the ring are not changed. The jumbo frames are * fragmented into several IP packets with length less or equal to MTU. - ***/ + */ #include diff --git a/lib/port/rte_port_kni.h b/lib/port/rte_port_kni.h index 54227251f6..280f58c121 100644 --- a/lib/port/rte_port_kni.h +++ b/lib/port/rte_port_kni.h @@ -16,11 +16,10 @@ extern "C" { * * kni_reader: input port built on top of pre-initialized KNI interface * kni_writer: output port built on top of pre-initialized KNI interface - ***/ + */ #include - #include "rte_port.h" /** kni_reader port parameters */ diff --git a/lib/port/rte_port_ras.h b/lib/port/rte_port_ras.h index 8fd8ae8444..94cfb3ed92 100644 --- a/lib/port/rte_port_ras.h +++ b/lib/port/rte_port_ras.h @@ -25,11 +25,10 @@ extern "C" { * The complete IP datagrams written to the ring are not changed. The IP * fragments written to the ring are first reassembled and into complete IP * datagrams or dropped on error or IP reassembly time-out. - ***/ + */ #include - #include "rte_port.h" /** ring_writer_ipv4_ras port parameters */ diff --git a/lib/port/rte_port_ring.h b/lib/port/rte_port_ring.h index 9532ac1d22..027928c924 100644 --- a/lib/port/rte_port_ring.h +++ b/lib/port/rte_port_ring.h @@ -21,11 +21,10 @@ extern "C" { * input port built on top of pre-initialized multi consumers ring * ring_multi_writer: * output port built on top of pre-initialized multi producers ring - ***/ + */ #include - #include "rte_port.h" /** ring_reader port parameters */ diff --git a/lib/port/rte_port_sched.h b/lib/port/rte_port_sched.h index 5f46297a60..251380ef80 100644 --- a/lib/port/rte_port_sched.h +++ b/lib/port/rte_port_sched.h @@ -15,7 +15,7 @@ extern "C" { * * sched_reader: input port built on top of pre-initialized rte_sched_port * sched_writer: output port built on top of pre-initialized rte_sched_port - ***/ + */ #include diff --git a/lib/port/rte_port_source_sink.h b/lib/port/rte_port_source_sink.h index c2ddb297f4..bcdbaf1e40 100644 --- a/lib/port/rte_port_source_sink.h +++ b/lib/port/rte_port_source_sink.h @@ -15,7 +15,7 @@ extern "C" { * * source: input port that can be used to generate packets * sink: output port that drops all packets written to it - ***/ + */ #include "rte_port.h" diff --git a/lib/port/rte_port_sym_crypto.h b/lib/port/rte_port_sym_crypto.h index 4cf8566633..6532b4388a 100644 --- a/lib/port/rte_port_sym_crypto.h +++ b/lib/port/rte_port_sym_crypto.h @@ -15,7 +15,7 @@ extern "C" { * * crypto_reader: input port built on top of pre-initialized crypto interface * crypto_writer: output port built on top of pre-initialized crypto interface - **/ + */ #include diff --git a/lib/port/rte_swx_port_fd.h b/lib/port/rte_swx_port_fd.h index 2dd1480a42..e61719c8f6 100644 --- a/lib/port/rte_swx_port_fd.h +++ b/lib/port/rte_swx_port_fd.h @@ -12,10 +12,10 @@ extern "C" { /** * @file * RTE SWX FD Input and Output Ports - ***/ + */ + #include - #include "rte_swx_port.h" /** fd_reader port parameters */ diff --git a/lib/port/rte_swx_port_ring.h b/lib/port/rte_swx_port_ring.h index dc0ef9247c..efc485fb08 100644 --- a/lib/port/rte_swx_port_ring.h +++ b/lib/port/rte_swx_port_ring.h @@ -12,11 +12,10 @@ extern "C" { /** * @file * RTE SWX Ring Input and Output Ports - ***/ + */ #include - #include "rte_swx_port.h" /** Ring input port (reader) creation parameters. */ diff --git a/lib/sched/rte_approx.h b/lib/sched/rte_approx.h index 0200fa1521..b60086330e 100644 --- a/lib/sched/rte_approx.h +++ b/lib/sched/rte_approx.h @@ -16,7 +16,7 @@ extern "C" { * Given a rational number alpha with 0 < alpha < 1 and a precision d, the goal * is to find positive integers p, q such that alpha - d < p/q < alpha + d, and * q is minimal. - ***/ + */ #include diff --git a/lib/sched/rte_pie.h b/lib/sched/rte_pie.h index cb52fd933e..e0d6d5a3cd 100644 --- a/lib/sched/rte_pie.h +++ b/lib/sched/rte_pie.h @@ -12,7 +12,7 @@ extern "C" { /** * @file * Proportional Integral controller Enhanced (PIE) - **/ + */ #include diff --git a/lib/sched/rte_red.h b/lib/sched/rte_red.h index 13a9ad24a8..afaa35fcd6 100644 --- a/lib/sched/rte_red.h +++ b/lib/sched/rte_red.h @@ -12,7 +12,7 @@ extern "C" { /** * @file * RTE Random Early Detection (RED) - ***/ + */ #include #include diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index e7787344b3..a1ca710cf8 100644 --- a/lib/sched/rte_sched.c +++ b/lib/sched/rte_sched.c @@ -1226,7 +1226,7 @@ rte_sched_subport_config(struct rte_sched_port *port, /** Memory is allocated only on first invocation of the api for a * given subport. Subsequent invocation on same subport will just * update subport bandwidth parameter. - **/ + */ if (port->subports[subport_id] == NULL) { status = rte_sched_subport_check_params(params, diff --git a/lib/sched/rte_sched.h b/lib/sched/rte_sched.h index c7081ceeef..a9ac5909ad 100644 --- a/lib/sched/rte_sched.h +++ b/lib/sched/rte_sched.h @@ -309,7 +309,7 @@ struct rte_sched_port_params { /* * Configuration - ***/ + */ /** * Hierarchical scheduler port configuration @@ -432,9 +432,10 @@ rte_sched_pipe_config(struct rte_sched_port *port, uint32_t rte_sched_port_get_memory_footprint(struct rte_sched_port_params *port_params, struct rte_sched_subport_params **subport_params); + /* * Statistics - ***/ + */ /** * Hierarchical scheduler subport statistics read diff --git a/lib/table/rte_table.h b/lib/table/rte_table.h index 3f592d1aa2..9a5faf0e32 100644 --- a/lib/table/rte_table.h +++ b/lib/table/rte_table.h @@ -22,7 +22,7 @@ extern "C" { * use-case, the lookup key is an n-tuple of packet fields that uniquely * identifies a traffic flow, while data represents actions and action * meta-data associated with the same traffic flow. - ***/ + */ #include #include diff --git a/lib/table/rte_table_acl.h b/lib/table/rte_table_acl.h index 673725f82e..1cb7b9fbbd 100644 --- a/lib/table/rte_table_acl.h +++ b/lib/table/rte_table_acl.h @@ -17,7 +17,7 @@ extern "C" { * associate data to lookup keys. * * Use-cases: Firewall rule database, etc. - ***/ + */ #include diff --git a/lib/table/rte_table_array.h b/lib/table/rte_table_array.h index ac3ca59c75..fad83b0588 100644 --- a/lib/table/rte_table_array.h +++ b/lib/table/rte_table_array.h @@ -14,7 +14,7 @@ extern "C" { * RTE Table Array * * Simple array indexing. Lookup key is the array entry index. - ***/ + */ #include diff --git a/lib/table/rte_table_hash.h b/lib/table/rte_table_hash.h index 5d1a0e2bea..6698621dae 100644 --- a/lib/table/rte_table_hash.h +++ b/lib/table/rte_table_hash.h @@ -46,7 +46,8 @@ extern "C" { * 2. Key size: * a. Configurable key size * b. Single key size (8-byte, 16-byte or 32-byte key size) - ***/ + */ + #include #include "rte_table.h" diff --git a/lib/table/rte_table_hash_cuckoo.h b/lib/table/rte_table_hash_cuckoo.h index cb5a771c8b..3a55d28e9b 100644 --- a/lib/table/rte_table_hash_cuckoo.h +++ b/lib/table/rte_table_hash_cuckoo.h @@ -12,7 +12,8 @@ extern "C" { /** * @file * RTE Table Hash Cuckoo - ***/ + */ + #include #include diff --git a/lib/table/rte_table_hash_ext.c b/lib/table/rte_table_hash_ext.c index bd97dc5eba..bb7d23019b 100644 --- a/lib/table/rte_table_hash_ext.c +++ b/lib/table/rte_table_hash_ext.c @@ -514,8 +514,7 @@ static int rte_table_hash_ext_lookup_unoptimized( return 0; } -/*** - * +/* * mask = match bitmask * match = at least one match * match_many = more than one match @@ -552,7 +551,7 @@ static int rte_table_hash_ext_lookup_unoptimized( * match = 0xFFFELLU * match_many = 0xFEE8LLU * match_pos = 0x12131210LLU - ***/ + */ #define LUT_MATCH 0xFFFELLU #define LUT_MATCH_MANY 0xFEE8LLU @@ -829,7 +828,7 @@ static int rte_table_hash_ext_lookup_unoptimized( pkts_mask_out |= match_keys; \ } -/*** +/* * The lookup function implements a 4-stage pipeline, with each stage processing * two different packets. The purpose of pipelined implementation is to hide the * latency of prefetching the data structures and loosen the data dependency @@ -843,7 +842,7 @@ static int rte_table_hash_ext_lookup_unoptimized( * * The naming convention is: * pXY = packet Y of stage X, X = 0 .. 3, Y = 0 .. 1 -***/ +*/ static int rte_table_hash_ext_lookup( void *table, struct rte_mbuf **pkts, diff --git a/lib/table/rte_table_hash_lru.c b/lib/table/rte_table_hash_lru.c index 354cd5aee4..d71fc70834 100644 --- a/lib/table/rte_table_hash_lru.c +++ b/lib/table/rte_table_hash_lru.c @@ -451,8 +451,7 @@ static int rte_table_hash_lru_lookup_unoptimized( return 0; } -/*** -* +/* * mask = match bitmask * match = at least one match * match_many = more than one match @@ -489,7 +488,7 @@ static int rte_table_hash_lru_lookup_unoptimized( * match = 0xFFFELLU * match_many = 0xFEE8LLU * match_pos = 0x12131210LLU -***/ +*/ #define LUT_MATCH 0xFFFELLU #define LUT_MATCH_MANY 0xFEE8LLU @@ -781,7 +780,7 @@ static int rte_table_hash_lru_lookup_unoptimized( lru_update(bkt31, match_pos31); \ } -/*** +/* * The lookup function implements a 4-stage pipeline, with each stage processing * two different packets. The purpose of pipelined implementation is to hide the * latency of prefetching the data structures and loosen the data dependency @@ -795,7 +794,7 @@ static int rte_table_hash_lru_lookup_unoptimized( * * The naming convention is: * pXY = packet Y of stage X, X = 0 .. 3, Y = 0 .. 1 -***/ +*/ static int rte_table_hash_lru_lookup( void *table, struct rte_mbuf **pkts, diff --git a/lib/table/rte_table_lpm.h b/lib/table/rte_table_lpm.h index 135f07384c..dde32deed9 100644 --- a/lib/table/rte_table_lpm.h +++ b/lib/table/rte_table_lpm.h @@ -39,7 +39,7 @@ extern "C" { * has to carefully manage the format of the LPM table entry (i.e. the next * hop information) so that any next hop data that changes value during * run-time (e.g. counters) is placed outside of this area. - ***/ + */ #include diff --git a/lib/table/rte_table_lpm_ipv6.h b/lib/table/rte_table_lpm_ipv6.h index a6cea2c707..96ddbd32c2 100644 --- a/lib/table/rte_table_lpm_ipv6.h +++ b/lib/table/rte_table_lpm_ipv6.h @@ -39,7 +39,7 @@ extern "C" { * has to carefully manage the format of the LPM table entry (i.e. the next * hop information) so that any next hop data that changes value during * run-time (e.g. counters) is placed outside of this area. - ***/ + */ #include diff --git a/lib/table/rte_table_stub.h b/lib/table/rte_table_stub.h index b4aa0a16a2..846526ea99 100644 --- a/lib/table/rte_table_stub.h +++ b/lib/table/rte_table_stub.h @@ -14,8 +14,7 @@ extern "C" { * RTE Table Stub * * The stub table lookup operation produces lookup miss for all input packets. - ***/ - + */ #include "rte_table.h" diff --git a/lib/telemetry/rte_telemetry.h b/lib/telemetry/rte_telemetry.h index d8ea97f173..cab9daa6fe 100644 --- a/lib/telemetry/rte_telemetry.h +++ b/lib/telemetry/rte_telemetry.h @@ -30,7 +30,7 @@ extern "C" { * The telemetry library provides a method to retrieve statistics from * DPDK by sending a request message over a socket. DPDK will send * a JSON encoded response containing telemetry data. - ***/ + */ /** opaque structure used internally for managing data from callbacks */ struct rte_tel_data; diff --git a/lib/telemetry/telemetry_internal.h b/lib/telemetry/telemetry_internal.h index 37d79bcb24..80e2bd3a49 100644 --- a/lib/telemetry/telemetry_internal.h +++ b/lib/telemetry/telemetry_internal.h @@ -14,7 +14,7 @@ * * @file * RTE Telemetry Legacy and internal definitions - ***/ + */ /** * @internal diff --git a/lib/telemetry/telemetry_json.h b/lib/telemetry/telemetry_json.h index 31a3d56756..a754dfaa0c 100644 --- a/lib/telemetry/telemetry_json.h +++ b/lib/telemetry/telemetry_json.h @@ -18,7 +18,7 @@ * * This file contains small inline functions to make it easier for applications * to build up valid JSON responses to telemetry requests. - ***/ + */ /** * @internal From patchwork Wed Jun 14 14:26:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 128689 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90D2442CB3; Wed, 14 Jun 2023 16:31:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2864342D12; Wed, 14 Jun 2023 16:31:19 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 6959142D10 for ; Wed, 14 Jun 2023 16:31:18 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 0B8105C00AC; Wed, 14 Jun 2023 10:31:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 14 Jun 2023 10:31:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1686753078; x=1686839478; bh=ROXWrlPMj0Dj2f8IgfkbKyRWsUamdcsXHrp lx/KtODI=; b=aPUVuGfKssk60uWbDl/+r2IpJgNEMJSn22Iu4NFVE0VqNdB4xqY nClpDBwE2iXYeYjrrOqka7CQloweMOFyqbH2D6IDJs+oGctuzFxSrWiBy8RUwV6j 6vUTAxKqqUG0/ZMQh+FIA+7hJdTLY1XYv1Y6xmqlNcr07vYnlFb4UwoU+2HS01yE eyj8BEM8HI7Phj0BUcyJursjxYMc2WQx52r27Kpnk2RkuJAMqj0lu75LZGCJHAtr 8C0q7CEecMRErVYt7F0NcXYgw0T6o6Imm2pAXhle8zJNMHpf2z0zCDyar819Gdt4 z/sgLVJo5hRXnMF7Gd0OgxpeQxeV+ZrawXg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1686753078; x=1686839478; bh=ROXWrlPMj0Dj2f8IgfkbKyRWsUamdcsXHrp lx/KtODI=; b=HK75QXqE7ej9xrM21YeaKi8h1fREhKvxyoO9nCmbmcDibBPp9yk 1UWA3XhpqrNpK+lgmSNAJojIXsL2quMqwJDY3kVliLu3fO29FsA1B/YUtf6oavdl BsX3wslrFk0LjiluLrv9r7BlqGDCK3p6Vh+a2RIxNPN0C+AkKXo9LjZxc1QpphdN Rar1n0P6SZqUJvIusEoG8eoAFdPFyCEX3TTf43kBw0wOiDK2RSyKoWmdL1GUB0eK 0SALqbjYY9jkMRfCAK7Ehgk7uc3Ylrd+7yo6T7Ri1IOY62BTbb7kFOeAyk9InL2+ /AanKYIoomYe+Fw3q1my+DQFcNgKUbcpL9A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedvtddgjeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdeiffffgeefteelhfekueetueduffejgfelvedtieejudek gfevheetheehgeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Jun 2023 10:31:16 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: Konstantin Ananyev , Cristian Dumitrescu , Olivier Matz , Ruifeng Wang , David Christensen , Bruce Richardson , Ferruh Yigit , Andrew Rybchenko , Ori Kam Subject: [PATCH 3/5] lib: align comment blocks Date: Wed, 14 Jun 2023 16:26:49 +0200 Message-Id: <20230614142651.1456116-4-thomas@monjalon.net> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230614142651.1456116-1-thomas@monjalon.net> References: <20230614142651.1456116-1-thomas@monjalon.net> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Some comment blocks were missing a space or had too many spaces at the beginning of the lines, resulting in misalignment of asterisks. Such mistakes were found with this kind of commands: git grep '^\*' lib git grep '^ *\*' lib Signed-off-by: Thomas Monjalon Reviewed-by: Ruifeng Wang --- lib/acl/acl_gen.c | 10 +- lib/acl/acl_vect.h | 2 +- lib/cfgfile/rte_cfgfile.h | 300 ++++++++++++------------- lib/cmdline/cmdline_parse_string.h | 14 +- lib/eal/arm/include/rte_cycles_32.h | 13 +- lib/eal/include/generic/rte_cycles.h | 2 +- lib/eal/include/rte_hexdump.h | 51 ++--- lib/eal/ppc/include/rte_byteorder.h | 2 +- lib/eal/x86/include/rte_byteorder_32.h | 2 +- lib/eal/x86/include/rte_byteorder_64.h | 2 +- lib/ethdev/rte_ethdev.h | 65 +++--- lib/ethdev/rte_flow.h | 8 +- lib/ethdev/rte_tm.h | 4 +- lib/table/rte_table_hash_ext.c | 28 +-- lib/table/rte_table_hash_lru.c | 102 ++++----- 15 files changed, 302 insertions(+), 303 deletions(-) diff --git a/lib/acl/acl_gen.c b/lib/acl/acl_gen.c index e759a2ca15..25e75fec35 100644 --- a/lib/acl/acl_gen.c +++ b/lib/acl/acl_gen.c @@ -148,11 +148,11 @@ acl_node_fill_dfa(const struct rte_acl_node *node, } /* -* Counts the number of groups of sequential bits that are -* either 0 or 1, as specified by the zero_one parameter. This is used to -* calculate the number of ranges in a node to see if it fits in a quad range -* node. -*/ + * Count the number of groups of sequential bits that are either 0 or 1, + * as specified by the zero_one parameter. + * This is used to calculate the number of ranges in a node + * to see if it fits in a quad range node. + */ static int acl_count_sequential_groups(struct rte_acl_bitset *bits, int zero_one) { diff --git a/lib/acl/acl_vect.h b/lib/acl/acl_vect.h index e4b4666090..2ab58a55a4 100644 --- a/lib/acl/acl_vect.h +++ b/lib/acl/acl_vect.h @@ -36,7 +36,7 @@ * This is effectively a popcnt of bytes that are greater than the * input byte. * Single nodes are processed in the same ways as quad range nodes. -*/ + */ #define ACL_TR_CALC_ADDR(P, S, \ addr, index_mask, next_input, shuffle_input, \ ones_16, range_base, tr_lo, tr_hi) do { \ diff --git a/lib/cfgfile/rte_cfgfile.h b/lib/cfgfile/rte_cfgfile.h index 7729c133b4..232c65c77b 100644 --- a/lib/cfgfile/rte_cfgfile.h +++ b/lib/cfgfile/rte_cfgfile.h @@ -12,11 +12,11 @@ extern "C" { #endif /** -* @file -* RTE Configuration File -* -* This library allows reading application defined parameters from standard -* format configuration file. + * @file + * Configuration File management. + * + * This library allows reading application defined parameters + * from standard format configuration file. */ #ifndef CFG_NAME_LEN @@ -63,15 +63,15 @@ enum { #define CFG_DEFAULT_COMMENT_CHARACTER ';' /** -* Open config file -* -* @param filename -* Config file name -* @param flags -* Config file flags -* @return -* Handle to configuration file on success, NULL otherwise -*/ + * Open config file. + * + * @param filename + * Config file name. + * @param flags + * Config file flags. + * @return + * Handle to configuration file on success, NULL otherwise. + */ struct rte_cfgfile *rte_cfgfile_load(const char *filename, int flags); /** @@ -167,133 +167,133 @@ int rte_cfgfile_set_entry(struct rte_cfgfile *cfg, const char *sectionname, int rte_cfgfile_save(struct rte_cfgfile *cfg, const char *filename); /** -* Get number of sections in config file -* -* @param cfg -* Config file -* @param sec_name -* Section name -* @param length -* Maximum section name length -* @return -* Number of sections -*/ + * Get number of sections in config file. + * + * @param cfg + * Config file. + * @param sec_name + * Section name. + * @param length + * Maximum section name length. + * @return + * Number of sections. + */ int rte_cfgfile_num_sections(struct rte_cfgfile *cfg, const char *sec_name, size_t length); /** -* Get name of all config file sections. -* -* Fills in the array sections with the name of all the sections in the file -* (up to the number of max_sections sections). -* -* @param cfg -* Config file -* @param sections -* Array containing section names after successful invocation. Each element -* of this array should be preallocated by the user with at least -* CFG_NAME_LEN characters. -* @param max_sections -* Maximum number of section names to be stored in sections array -* @return -* Number of populated sections names -*/ + * Get name of all config file sections. + * + * Fills in the array sections with the name of all the sections in the file + * (up to the number of max_sections sections). + * + * @param cfg + * Config file. + * @param sections + * Array containing section names after successful invocation. + * Each element of this array should be preallocated by the user + * with at least CFG_NAME_LEN characters. + * @param max_sections + * Maximum number of section names to be stored in sections array. + * @return + * Number of populated sections names. + */ int rte_cfgfile_sections(struct rte_cfgfile *cfg, char *sections[], int max_sections); /** -* Check if given section exists in config file -* -* @param cfg -* Config file -* @param sectionname -* Section name -* @return -* TRUE (value different than 0) if section exists, FALSE (value 0) otherwise -*/ + * Check if given section exists in config file. + * + * @param cfg + * Config file. + * @param sectionname + * Section name. + * @return + * TRUE (value different than 0) if section exists, FALSE (value 0) otherwise. + */ int rte_cfgfile_has_section(struct rte_cfgfile *cfg, const char *sectionname); /** -* Get number of entries in given config file section -* -* If multiple sections have the given name this function operates on the -* first one. -* -* @param cfg -* Config file -* @param sectionname -* Section name -* @return -* Number of entries in section on success, -1 otherwise -*/ + * Get number of entries in given config file section. + * + * If multiple sections have the given name, + * this function operates on the first one. + * + * @param cfg + * Config file. + * @param sectionname + * Section name. + * @return + * Number of entries in section on success, -1 otherwise. + */ int rte_cfgfile_section_num_entries(struct rte_cfgfile *cfg, const char *sectionname); /** -* Get number of entries in given config file section -* -* The index of a section is the same as the index of its name in the -* result of rte_cfgfile_sections. This API can be used when there are -* multiple sections with the same name. -* -* @param cfg -* Config file -* @param sectionname -* Section name -* @param index -* Section index -* @return -* Number of entries in section on success, -1 otherwise -*/ + * Get number of entries in given config file section. + * + * The index of a section is the same as the index of its name + * in the result of rte_cfgfile_sections. + * This API can be used when there are multiple sections with the same name. + * + * @param cfg + * Config file. + * @param sectionname + * Section name. + * @param index + * Section index. + * @return + * Number of entries in section on success, -1 otherwise. + */ int rte_cfgfile_section_num_entries_by_index(struct rte_cfgfile *cfg, char *sectionname, int index); /** -* Get section entries as key-value pairs -* -* If multiple sections have the given name this function operates on the -* first one. -* -* @param cfg -* Config file -* @param sectionname -* Section name -* @param entries -* Pre-allocated array of at least max_entries entries where the section -* entries are stored as key-value pair after successful invocation -* @param max_entries -* Maximum number of section entries to be stored in entries array -* @return -* Number of entries populated on success, -1 otherwise -*/ + * Get section entries as key-value pairs. + * + * If multiple sections have the given name, + * this function operates on the first one. + * + * @param cfg + * Config file. + * @param sectionname + * Section name. + * @param entries + * Pre-allocated array of at least max_entries entries where the section + * entries are stored as key-value pair after successful invocation. + * @param max_entries + * Maximum number of section entries to be stored in entries array. + * @return + * Number of entries populated on success, -1 otherwise. + */ int rte_cfgfile_section_entries(struct rte_cfgfile *cfg, const char *sectionname, struct rte_cfgfile_entry *entries, int max_entries); /** -* Get section entries as key-value pairs -* -* The index of a section is the same as the index of its name in the -* result of rte_cfgfile_sections. This API can be used when there are -* multiple sections with the same name. -* -* @param cfg -* Config file -* @param index -* Section index -* @param sectionname -* Pre-allocated string of at least CFG_NAME_LEN characters where the -* section name is stored after successful invocation. -* @param entries -* Pre-allocated array of at least max_entries entries where the section -* entries are stored as key-value pair after successful invocation -* @param max_entries -* Maximum number of section entries to be stored in entries array -* @return -* Number of entries populated on success, -1 otherwise -*/ + * Get section entries as key-value pairs. + * + * The index of a section is the same as the index of its name + * in the result of rte_cfgfile_sections. + * This API can be used when there are multiple sections with the same name. + * + * @param cfg + * Config file. + * @param index + * Section index. + * @param sectionname + * Pre-allocated string of at least CFG_NAME_LEN characters + * where the section name is stored after successful invocation. + * @param entries + * Pre-allocated array of at least max_entries entries where the section + * entries are stored as key-value pair after successful invocation. + * @param max_entries + * Maximum number of section entries to be stored in entries array. + * @return + * Number of entries populated on success, -1 otherwise. + */ int rte_cfgfile_section_entries_by_index(struct rte_cfgfile *cfg, int index, char *sectionname, @@ -301,50 +301,50 @@ int rte_cfgfile_section_entries_by_index(struct rte_cfgfile *cfg, int max_entries); /** -* Get value of the named entry in named config file section -* -* If multiple sections have the given name this function operates on the -* first one. -* -* @param cfg -* Config file -* @param sectionname -* Section name -* @param entryname -* Entry name -* @return -* Entry value on success, NULL otherwise -*/ + * Get value of the named entry in named config file section. + * + * If multiple sections have the given name, + * this function operates on the first one. + * + * @param cfg + * Config file. + * @param sectionname + * Section name. + * @param entryname + * Entry name. + * @return + * Entry value on success, NULL otherwise. + */ const char *rte_cfgfile_get_entry(struct rte_cfgfile *cfg, const char *sectionname, const char *entryname); /** -* Check if given entry exists in named config file section -* -* If multiple sections have the given name this function operates on the -* first one. -* -* @param cfg -* Config file -* @param sectionname -* Section name -* @param entryname -* Entry name -* @return -* TRUE (value different than 0) if entry exists, FALSE (value 0) otherwise -*/ + * Check if given entry exists in named config file section. + * + * If multiple sections have the given name, + * this function operates on the first one. + * + * @param cfg + * Config file. + * @param sectionname + * Section name. + * @param entryname + * Entry name. + * @return + * TRUE (value different than 0) if entry exists, FALSE (value 0) otherwise. + */ int rte_cfgfile_has_entry(struct rte_cfgfile *cfg, const char *sectionname, const char *entryname); /** -* Close config file -* -* @param cfg -* Config file -* @return -* 0 on success, -1 otherwise -*/ + * Close config file. + * + * @param cfg + * Config file. + * @return + * 0 on success, -1 otherwise. + */ int rte_cfgfile_close(struct rte_cfgfile *cfg); #ifdef __cplusplus diff --git a/lib/cmdline/cmdline_parse_string.h b/lib/cmdline/cmdline_parse_string.h index 52a26670ee..2199ca9a21 100644 --- a/lib/cmdline/cmdline_parse_string.h +++ b/lib/cmdline/cmdline_parse_string.h @@ -44,13 +44,13 @@ int cmdline_get_help_string(cmdline_parse_token_hdr_t *tk, char *dstbuf, unsigned int size); /** -* Token marked as TOKEN_STRING_MULTI takes entire parsing string -* until “#” sign appear. Everything after “#” sign is treated as a comment. -* -* Note: -* In this case second parameter of TOKEN_STRING_INITIALIZER must be a type of -* cmdline_multi_string_t. -*/ + * Token marked as TOKEN_STRING_MULTI takes entire parsing string + * until “#” sign appear. Everything after “#” sign is treated as a comment. + * + * Note: + * In this case second parameter of TOKEN_STRING_INITIALIZER + * must be a type of cmdline_multi_string_t. + */ #define TOKEN_STRING_MULTI "" #define TOKEN_STRING_INITIALIZER(structure, field, string) \ diff --git a/lib/eal/arm/include/rte_cycles_32.h b/lib/eal/arm/include/rte_cycles_32.h index cec4d69e7a..859cd2e5bb 100644 --- a/lib/eal/arm/include/rte_cycles_32.h +++ b/lib/eal/arm/include/rte_cycles_32.h @@ -5,12 +5,13 @@ #ifndef _RTE_CYCLES_ARM32_H_ #define _RTE_CYCLES_ARM32_H_ -/* ARM v7 does not have suitable source of clock signals. The only clock counter - available in the core is 32 bit wide. Therefore it is unsuitable as the - counter overlaps every few seconds and probably is not accessible by - userspace programs. Therefore we use clock_gettime(CLOCK_MONOTONIC_RAW) to - simulate counter running at 1GHz. -*/ +/* ARM v7 does not have suitable source of clock signals. + * The only clock counter available in the core is 32 bit wide. + * Therefore it is unsuitable as the counter overlaps every few seconds + * and probably is not accessible by userspace programs. + * Therefore we use clock_gettime(CLOCK_MONOTONIC_RAW) + * to simulate counter running at 1GHz. + */ #include diff --git a/lib/eal/include/generic/rte_cycles.h b/lib/eal/include/generic/rte_cycles.h index 69f3cee8d1..075e899f5a 100644 --- a/lib/eal/include/generic/rte_cycles.h +++ b/lib/eal/include/generic/rte_cycles.h @@ -38,7 +38,7 @@ rte_get_tsc_hz(void); /** * Return the number of TSC cycles since boot * - * @return + * @return * the number of cycles */ static inline uint64_t diff --git a/lib/eal/include/rte_hexdump.h b/lib/eal/include/rte_hexdump.h index 80cf2933a7..009ce24c5c 100644 --- a/lib/eal/include/rte_hexdump.h +++ b/lib/eal/include/rte_hexdump.h @@ -17,37 +17,34 @@ extern "C" { #endif /** -* Dump out memory in a special hex dump format. -* -* @param f -* A pointer to a file for output -* @param title -* If not NULL this string is printed as a header to the output. -* @param buf -* This is the buffer address to print out. -* @param len -* The number of bytes to dump out -*/ - + * Dump out memory in a special hex dump format. + * + * @param f + * A pointer to a file for output. + * @param title + * If not NULL this string is printed as a header to the output. + * @param buf + * This is the buffer address to print out. + * @param len + * The number of bytes to dump out. + */ extern void -rte_hexdump(FILE *f, const char * title, const void * buf, unsigned int len); +rte_hexdump(FILE *f, const char *title, const void *buf, unsigned int len); /** -* Dump out memory in a hex format with colons between bytes. -* -* @param f -* A pointer to a file for output -* @param title -* If not NULL this string is printed as a header to the output. -* @param buf -* This is the buffer address to print out. -* @param len -* The number of bytes to dump out -*/ - + * Dump out memory in a hex format with colons between bytes. + * + * @param f + * A pointer to a file for output. + * @param title + * If not NULL this string is printed as a header to the output. + * @param buf + * This is the buffer address to print out. + * @param len + * The number of bytes to dump out. + */ void -rte_memdump(FILE *f, const char * title, const void * buf, unsigned int len); - +rte_memdump(FILE *f, const char *title, const void *buf, unsigned int len); #ifdef __cplusplus } diff --git a/lib/eal/ppc/include/rte_byteorder.h b/lib/eal/ppc/include/rte_byteorder.h index bfdded40f5..49f369f1e7 100644 --- a/lib/eal/ppc/include/rte_byteorder.h +++ b/lib/eal/ppc/include/rte_byteorder.h @@ -39,7 +39,7 @@ static inline uint32_t rte_arch_bswap32(uint32_t _x) /* * An architecture-optimized byte swap for a 64-bit value. * - * Do not use this function directly. The preferred function is rte_bswap64(). + * Do not use this function directly. The preferred function is rte_bswap64(). */ /* 64-bit mode */ static inline uint64_t rte_arch_bswap64(uint64_t _x) diff --git a/lib/eal/x86/include/rte_byteorder_32.h b/lib/eal/x86/include/rte_byteorder_32.h index d5a768e52b..da901a4176 100644 --- a/lib/eal/x86/include/rte_byteorder_32.h +++ b/lib/eal/x86/include/rte_byteorder_32.h @@ -15,7 +15,7 @@ /* * An architecture-optimized byte swap for a 64-bit value. * - * Do not use this function directly. The preferred function is rte_bswap64(). + * Do not use this function directly. The preferred function is rte_bswap64(). */ /* Compat./Leg. mode */ static inline uint64_t rte_arch_bswap64(uint64_t x) diff --git a/lib/eal/x86/include/rte_byteorder_64.h b/lib/eal/x86/include/rte_byteorder_64.h index 8c6cf285b5..537d9a511e 100644 --- a/lib/eal/x86/include/rte_byteorder_64.h +++ b/lib/eal/x86/include/rte_byteorder_64.h @@ -15,7 +15,7 @@ /* * An architecture-optimized byte swap for a 64-bit value. * - * Do not use this function directly. The preferred function is rte_bswap64(). + * Do not use this function directly. The preferred function is rte_bswap64(). */ /* 64-bit mode */ static inline uint64_t rte_arch_bswap64(uint64_t _x) diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index e550f09889..91a3b863db 100644 --- a/lib/ethdev/rte_ethdev.h +++ b/lib/ethdev/rte_ethdev.h @@ -825,10 +825,10 @@ rte_eth_rss_hf_refine(uint64_t rss_hf) #define RTE_ETH_VLAN_ID_MAX 0x0FFF /**< VLAN ID is in lower 12 bits*/ /**@}*/ -/* Definitions used for receive MAC address */ +/* Definitions used for receive MAC address */ #define RTE_ETH_NUM_RECEIVE_MAC_ADDR 128 /**< Maximum nb. of receive mac addr. */ -/* Definitions used for unicast hash */ +/* Definitions used for unicast hash */ #define RTE_ETH_VMDQ_NUM_UC_HASH_ARRAY 128 /**< Maximum nb. of UC hash array. */ /**@{@name VMDq Rx mode @@ -4496,7 +4496,7 @@ int rte_eth_dev_rss_reta_query(uint16_t port_id, * @return * - (0) if successful. * - (-ENOTSUP) if hardware doesn't support. - * - (-ENODEV) if *port_id* invalid. + * - (-ENODEV) if *port_id* invalid. * - (-EIO) if device is removed. * - (-EINVAL) if bad parameter. */ @@ -4517,7 +4517,7 @@ int rte_eth_dev_uc_hash_table_set(uint16_t port_id, struct rte_ether_addr *addr, * @return * - (0) if successful. * - (-ENOTSUP) if hardware doesn't support. - * - (-ENODEV) if *port_id* invalid. + * - (-ENODEV) if *port_id* invalid. * - (-EIO) if device is removed. * - (-EINVAL) if bad parameter. */ @@ -5231,38 +5231,39 @@ int rte_eth_read_clock(uint16_t port_id, uint64_t *clock); /** -* Get the port ID from device name. The device name should be specified -* as below: -* - PCIe address (Domain:Bus:Device.Function), for example- 0000:2:00.0 -* - SoC device name, for example- fsl-gmac0 -* - vdev dpdk name, for example- net_[pcap0|null0|tap0] -* -* @param name -* pci address or name of the device -* @param port_id -* pointer to port identifier of the device -* @return -* - (0) if successful and port_id is filled. -* - (-ENODEV or -EINVAL) on failure. -*/ + * Get the port ID from device name. + * The device name should be specified as below: + * - PCIe address (Domain:Bus:Device.Function), for example- 0000:2:00.0 + * - SoC device name, for example- fsl-gmac0 + * - vdev dpdk name, for example- net_[pcap0|null0|tap0] + * + * @param name + * PCI address or name of the device. + * @param port_id + * Pointer to port identifier of the device. + * @return + * - (0) if successful and port_id is filled. + * - (-ENODEV or -EINVAL) on failure. + */ int rte_eth_dev_get_port_by_name(const char *name, uint16_t *port_id); /** -* Get the device name from port ID. The device name is specified as below: -* - PCIe address (Domain:Bus:Device.Function), for example- 0000:02:00.0 -* - SoC device name, for example- fsl-gmac0 -* - vdev dpdk name, for example- net_[pcap0|null0|tun0|tap0] -* -* @param port_id -* Port identifier of the device. -* @param name -* Buffer of size RTE_ETH_NAME_MAX_LEN to store the name. -* @return -* - (0) if successful. -* - (-ENODEV) if *port_id* is invalid. -* - (-EINVAL) on failure. -*/ + * Get the device name from port ID. + * The device name is specified as below: + * - PCIe address (Domain:Bus:Device.Function), for example- 0000:02:00.0 + * - SoC device name, for example- fsl-gmac0 + * - vdev dpdk name, for example- net_[pcap0|null0|tun0|tap0] + * + * @param port_id + * Port identifier of the device. + * @param name + * Buffer of size RTE_ETH_NAME_MAX_LEN to store the name. + * @return + * - (0) if successful. + * - (-ENODEV) if *port_id* is invalid. + * - (-EINVAL) on failure. + */ int rte_eth_dev_get_name_by_port(uint16_t port_id, char *name); diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index e11c4a044a..59e4093a5b 100644 --- a/lib/ethdev/rte_flow.h +++ b/lib/ethdev/rte_flow.h @@ -5831,10 +5831,10 @@ rte_flow_template_table_destroy(uint16_t port_id, */ __extension__ struct rte_flow_op_attr { - /** - * When set, the requested action will not be sent to the HW immediately. - * The application must call the rte_flow_queue_push to actually send it. - */ + /** + * When set, the requested action will not be sent to the HW immediately. + * The application must call the rte_flow_queue_push to actually send it. + */ uint32_t postpone:1; }; diff --git a/lib/ethdev/rte_tm.h b/lib/ethdev/rte_tm.h index 001d13f301..4103c49a3f 100644 --- a/lib/ethdev/rte_tm.h +++ b/lib/ethdev/rte_tm.h @@ -1937,9 +1937,9 @@ rte_tm_node_cman_update(uint16_t port_id, * Error details. Filled in only on error, when not NULL. * @return * 0 on success, non-zero error code otherwise. - * + * * @see struct rte_tm_capabilities::cman_wred_context_private_n_max -*/ + */ __rte_experimental int rte_tm_node_wred_context_update(uint16_t port_id, diff --git a/lib/table/rte_table_hash_ext.c b/lib/table/rte_table_hash_ext.c index bb7d23019b..4753ccb15c 100644 --- a/lib/table/rte_table_hash_ext.c +++ b/lib/table/rte_table_hash_ext.c @@ -829,20 +829,20 @@ static int rte_table_hash_ext_lookup_unoptimized( } /* -* The lookup function implements a 4-stage pipeline, with each stage processing -* two different packets. The purpose of pipelined implementation is to hide the -* latency of prefetching the data structures and loosen the data dependency -* between instructions. -* -* p00 _______ p10 _______ p20 _______ p30 _______ -*----->| |----->| |----->| |----->| |-----> -* | 0 | | 1 | | 2 | | 3 | -*----->|_______|----->|_______|----->|_______|----->|_______|-----> -* p01 p11 p21 p31 -* -* The naming convention is: -* pXY = packet Y of stage X, X = 0 .. 3, Y = 0 .. 1 -*/ + * The lookup function implements a 4-stage pipeline, with each stage processing + * two different packets. The purpose of pipelined implementation is to hide the + * latency of prefetching the data structures and loosen the data dependency + * between instructions. + * + * p00 _______ p10 _______ p20 _______ p30 _______ + *----->| |----->| |----->| |----->| |-----> + * | 0 | | 1 | | 2 | | 3 | + *----->|_______|----->|_______|----->|_______|----->|_______|-----> + * p01 p11 p21 p31 + * + * The naming convention is: + * pXY = packet Y of stage X, X = 0 .. 3, Y = 0 .. 1 + */ static int rte_table_hash_ext_lookup( void *table, struct rte_mbuf **pkts, diff --git a/lib/table/rte_table_hash_lru.c b/lib/table/rte_table_hash_lru.c index d71fc70834..f312d898c2 100644 --- a/lib/table/rte_table_hash_lru.c +++ b/lib/table/rte_table_hash_lru.c @@ -452,43 +452,43 @@ static int rte_table_hash_lru_lookup_unoptimized( } /* -* mask = match bitmask -* match = at least one match -* match_many = more than one match -* match_pos = position of first match -* -* ---------------------------------------- -* mask match match_many match_pos -* ---------------------------------------- -* 0000 0 0 00 -* 0001 1 0 00 -* 0010 1 0 01 -* 0011 1 1 00 -* ---------------------------------------- -* 0100 1 0 10 -* 0101 1 1 00 -* 0110 1 1 01 -* 0111 1 1 00 -* ---------------------------------------- -* 1000 1 0 11 -* 1001 1 1 00 -* 1010 1 1 01 -* 1011 1 1 00 -* ---------------------------------------- -* 1100 1 1 10 -* 1101 1 1 00 -* 1110 1 1 01 -* 1111 1 1 00 -* ---------------------------------------- -* -* match = 1111_1111_1111_1110 -* match_many = 1111_1110_1110_1000 -* match_pos = 0001_0010_0001_0011__0001_0010_0001_0000 -* -* match = 0xFFFELLU -* match_many = 0xFEE8LLU -* match_pos = 0x12131210LLU -*/ + * mask = match bitmask + * match = at least one match + * match_many = more than one match + * match_pos = position of first match + * + * ---------------------------------------- + * mask match match_many match_pos + * ---------------------------------------- + * 0000 0 0 00 + * 0001 1 0 00 + * 0010 1 0 01 + * 0011 1 1 00 + * ---------------------------------------- + * 0100 1 0 10 + * 0101 1 1 00 + * 0110 1 1 01 + * 0111 1 1 00 + * ---------------------------------------- + * 1000 1 0 11 + * 1001 1 1 00 + * 1010 1 1 01 + * 1011 1 1 00 + * ---------------------------------------- + * 1100 1 1 10 + * 1101 1 1 00 + * 1110 1 1 01 + * 1111 1 1 00 + * ---------------------------------------- + * + * match = 1111_1111_1111_1110 + * match_many = 1111_1110_1110_1000 + * match_pos = 0001_0010_0001_0011__0001_0010_0001_0000 + * + * match = 0xFFFELLU + * match_many = 0xFEE8LLU + * match_pos = 0x12131210LLU + */ #define LUT_MATCH 0xFFFELLU #define LUT_MATCH_MANY 0xFEE8LLU @@ -781,20 +781,20 @@ static int rte_table_hash_lru_lookup_unoptimized( } /* -* The lookup function implements a 4-stage pipeline, with each stage processing -* two different packets. The purpose of pipelined implementation is to hide the -* latency of prefetching the data structures and loosen the data dependency -* between instructions. -* -* p00 _______ p10 _______ p20 _______ p30 _______ -* ----->| |----->| |----->| |----->| |-----> -* | 0 | | 1 | | 2 | | 3 | -* ----->|_______|----->|_______|----->|_______|----->|_______|-----> -* p01 p11 p21 p31 -* -* The naming convention is: -* pXY = packet Y of stage X, X = 0 .. 3, Y = 0 .. 1 -*/ + * The lookup function implements a 4-stage pipeline, with each stage processing + * two different packets. The purpose of pipelined implementation is to hide the + * latency of prefetching the data structures and loosen the data dependency + * between instructions. + * + * p00 _______ p10 _______ p20 _______ p30 _______ + * ----->| |----->| |----->| |----->| |-----> + * | 0 | | 1 | | 2 | | 3 | + * ----->|_______|----->|_______|----->|_______|----->|_______|-----> + * p01 p11 p21 p31 + * + * The naming convention is: + * pXY = packet Y of stage X, X = 0 .. 3, Y = 0 .. 1 + */ static int rte_table_hash_lru_lookup( void *table, struct rte_mbuf **pkts, From patchwork Wed Jun 14 14:26:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 128690 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5309142CB3; Wed, 14 Jun 2023 16:31:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F92B42D1D; Wed, 14 Jun 2023 16:31:23 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 079EE427F2 for ; Wed, 14 Jun 2023 16:31:22 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id ECBCB3200915; Wed, 14 Jun 2023 10:31:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 14 Jun 2023 10:31:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1686753080; x= 1686839480; bh=YkcS6wMmrcZrdjt0dMoFqWSCDlbXmt8Tu7blt4B6zAw=; b=a SygDmK6dMuurQ6JUyEMo8VgPLB6FAYjNjpdrSWTyV/g5On5sc/JDbhI/CAy2OcGX LkrV+kzjXIiURkVYIBZenwMdrDx4H2D7IPRJUc59wKQsFhUfsIbWVYvjIHN9cHxd xxieiGgZtqDsfW4wiMMgv1ydzogorhsIekG7vgeJvsvBSQ3hG8nOqH5QrcF7haKH sAP7rI+GbnF3U6O290SMXNPIzH1w+Ch6SFXVvhT6o3LiPaZPA1CmfuJFYxWedmQf Zr2kFPDL5p08luEXD6UDmdu64BCFHNvzTpnVzaqCI89ZPizMVmQtqOPvo8MpSyJy mzglKUx5qjFdWSe27YJzQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1686753080; x= 1686839480; bh=YkcS6wMmrcZrdjt0dMoFqWSCDlbXmt8Tu7blt4B6zAw=; b=G llaFhxwj2K+QMbTLCahbHNTicSbcUVBn8pti5Sa49h/46ungig9zij21ugczui6a 1+GhXj/1HB3uGpl5RQNua/p1CGNoRMvbNTzkPnwZnnY7KxmaM3N6qEmt/0taHomK 6FLmdONj3pZk+NcQuO72vrF4SuTlTaECKagJHyqMD34Or6nH07qcxHWLC4SdHHQ8 lEW0EyiVhtZgCO6TCylijf3+lXZkB3PwamR5IXvyXy4xX7OtFMa+n44Su0cy8p4N l1aBxsVAl5ltzMWU5Kq8cmu9bgq8PTVYo/H4Zf7Ajc7dCtl/JIV8Iebgy9bNx3al 6epHJxElM/m0jmrs6gN9Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedvtddgjeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedvjefhudeghedvtdeijeeigeetuedugfejueekieeltdfhteev keehhfeilefhtdenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Jun 2023 10:31:19 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: Konstantin Ananyev , Akhil Goyal , Fan Zhang Subject: [PATCH 4/5] lib: restrict use of keyword extern Date: Wed, 14 Jun 2023 16:26:50 +0200 Message-Id: <20230614142651.1456116-5-thomas@monjalon.net> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230614142651.1456116-1-thomas@monjalon.net> References: <20230614142651.1456116-1-thomas@monjalon.net> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Variable declarations in header files are using extern, it is valid. But function declarations do not need the keyword extern. Also, extern "C" should have a space after the keyword extern. Signed-off-by: Thomas Monjalon --- lib/acl/acl.h | 2 +- lib/bpf/bpf_impl.h | 8 ++++---- lib/cryptodev/cryptodev_pmd.h | 2 +- lib/cryptodev/rte_crypto.h | 2 +- lib/cryptodev/rte_cryptodev.h | 35 +++++++++++++++++------------------ lib/eal/include/rte_hexdump.h | 2 +- lib/security/rte_security.h | 6 +++--- 7 files changed, 28 insertions(+), 29 deletions(-) diff --git a/lib/acl/acl.h b/lib/acl/acl.h index f5739a475c..c8e4e72fab 100644 --- a/lib/acl/acl.h +++ b/lib/acl/acl.h @@ -6,7 +6,7 @@ #define _ACL_H_ #ifdef __cplusplus -extern"C" { +extern "C" { #endif /* __cplusplus */ #define RTE_ACL_QUAD_MAX 5 diff --git a/lib/bpf/bpf_impl.h b/lib/bpf/bpf_impl.h index 3e067c1ff4..b483569071 100644 --- a/lib/bpf/bpf_impl.h +++ b/lib/bpf/bpf_impl.h @@ -21,10 +21,10 @@ struct rte_bpf { * Use '__rte' prefix for non-static internal functions * to avoid potential name conflict with other libraries. */ -extern int __rte_bpf_validate(struct rte_bpf *bpf); -extern int __rte_bpf_jit(struct rte_bpf *bpf); -extern int __rte_bpf_jit_x86(struct rte_bpf *bpf); -extern int __rte_bpf_jit_arm64(struct rte_bpf *bpf); +int __rte_bpf_validate(struct rte_bpf *bpf); +int __rte_bpf_jit(struct rte_bpf *bpf); +int __rte_bpf_jit_x86(struct rte_bpf *bpf); +int __rte_bpf_jit_arm64(struct rte_bpf *bpf); extern int rte_bpf_logtype; diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h index 585c29df8a..8710ed7558 100644 --- a/lib/cryptodev/cryptodev_pmd.h +++ b/lib/cryptodev/cryptodev_pmd.h @@ -534,7 +534,7 @@ rte_cryptodev_pmd_allocate(const char *name, int socket_id); * - 0 on success, negative on error */ __rte_internal -extern int +int rte_cryptodev_pmd_release_device(struct rte_cryptodev *cryptodev); diff --git a/lib/cryptodev/rte_crypto.h b/lib/cryptodev/rte_crypto.h index 7c9c413349..9b8d0331a4 100644 --- a/lib/cryptodev/rte_crypto.h +++ b/lib/cryptodev/rte_crypto.h @@ -216,7 +216,7 @@ __rte_crypto_op_get_priv_data_size(struct rte_mempool *mempool) * - On success pointer to mempool * - On failure NULL */ -extern struct rte_mempool * +struct rte_mempool * rte_crypto_op_pool_create(const char *name, enum rte_crypto_op_type type, unsigned nb_elts, unsigned cache_size, uint16_t priv_size, int socket_id); diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h index be708edc0f..ba730373fb 100644 --- a/lib/cryptodev/rte_cryptodev.h +++ b/lib/cryptodev/rte_cryptodev.h @@ -545,8 +545,7 @@ rte_cryptodev_asym_get_xform_string(enum rte_crypto_asym_xform_type xform_enum); * @return * The name of this flag, or NULL if it's not a valid feature flag. */ - -extern const char * +const char * rte_cryptodev_get_feature_name(uint64_t flag); /** Crypto device information */ @@ -662,7 +661,7 @@ struct rte_cryptodev_stats { * - Returns crypto device identifier on success. * - Return -1 on failure to find named crypto device. */ -extern int +int rte_cryptodev_get_dev_id(const char *name); /** @@ -675,7 +674,7 @@ rte_cryptodev_get_dev_id(const char *name); * - Returns crypto device name. * - Returns NULL if crypto device is not present. */ -extern const char * +const char * rte_cryptodev_name_get(uint8_t dev_id); /** @@ -685,7 +684,7 @@ rte_cryptodev_name_get(uint8_t dev_id); * @return * - The total number of usable crypto devices. */ -extern uint8_t +uint8_t rte_cryptodev_count(void); /** @@ -696,7 +695,7 @@ rte_cryptodev_count(void); * @return * Returns number of crypto device. */ -extern uint8_t +uint8_t rte_cryptodev_device_count_by_driver(uint8_t driver_id); /** @@ -723,7 +722,7 @@ rte_cryptodev_devices_get(const char *driver_name, uint8_t *devices, * a default of zero if the socket could not be determined. * -1 if returned is the dev_id value is out of range. */ -extern int +int rte_cryptodev_socket_id(uint8_t dev_id); /** Crypto device configuration structure */ @@ -756,7 +755,7 @@ struct rte_cryptodev_config { * - 0: Success, device configured. * - <0: Error code returned by the driver configuration function. */ -extern int +int rte_cryptodev_configure(uint8_t dev_id, struct rte_cryptodev_config *config); /** @@ -774,7 +773,7 @@ rte_cryptodev_configure(uint8_t dev_id, struct rte_cryptodev_config *config); * - 0: Success, device started. * - <0: Error code of the driver device start function. */ -extern int +int rte_cryptodev_start(uint8_t dev_id); /** @@ -783,7 +782,7 @@ rte_cryptodev_start(uint8_t dev_id); * * @param dev_id The identifier of the device. */ -extern void +void rte_cryptodev_stop(uint8_t dev_id); /** @@ -795,7 +794,7 @@ rte_cryptodev_stop(uint8_t dev_id); * - 0 on successfully closing device * - <0 on failure to close device */ -extern int +int rte_cryptodev_close(uint8_t dev_id); /** @@ -819,7 +818,7 @@ rte_cryptodev_close(uint8_t dev_id); * - 0: Success, queue pair correctly set up. * - <0: Queue pair configuration failed */ -extern int +int rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id, const struct rte_cryptodev_qp_conf *qp_conf, int socket_id); @@ -847,7 +846,7 @@ rte_cryptodev_get_qp_status(uint8_t dev_id, uint16_t queue_pair_id); * @return * - The number of configured queue pairs. */ -extern uint16_t +uint16_t rte_cryptodev_queue_pair_count(uint8_t dev_id); @@ -862,7 +861,7 @@ rte_cryptodev_queue_pair_count(uint8_t dev_id); * - Zero if successful. * - Non-zero otherwise. */ -extern int +int rte_cryptodev_stats_get(uint8_t dev_id, struct rte_cryptodev_stats *stats); /** @@ -870,7 +869,7 @@ rte_cryptodev_stats_get(uint8_t dev_id, struct rte_cryptodev_stats *stats); * * @param dev_id The identifier of the device. */ -extern void +void rte_cryptodev_stats_reset(uint8_t dev_id); /** @@ -886,7 +885,7 @@ rte_cryptodev_stats_reset(uint8_t dev_id); * the last valid element has it's op field set to * RTE_CRYPTO_OP_TYPE_UNDEFINED. */ -extern void +void rte_cryptodev_info_get(uint8_t dev_id, struct rte_cryptodev_info *dev_info); @@ -903,7 +902,7 @@ rte_cryptodev_info_get(uint8_t dev_id, struct rte_cryptodev_info *dev_info); * - On success, zero. * - On failure, a negative value. */ -extern int +int rte_cryptodev_callback_register(uint8_t dev_id, enum rte_cryptodev_event_type event, rte_cryptodev_cb_fn cb_fn, void *cb_arg); @@ -921,7 +920,7 @@ rte_cryptodev_callback_register(uint8_t dev_id, * - On success, zero. * - On failure, a negative value. */ -extern int +int rte_cryptodev_callback_unregister(uint8_t dev_id, enum rte_cryptodev_event_type event, rte_cryptodev_cb_fn cb_fn, void *cb_arg); diff --git a/lib/eal/include/rte_hexdump.h b/lib/eal/include/rte_hexdump.h index 009ce24c5c..59813f2096 100644 --- a/lib/eal/include/rte_hexdump.h +++ b/lib/eal/include/rte_hexdump.h @@ -28,7 +28,7 @@ extern "C" { * @param len * The number of bytes to dump out. */ -extern void +void rte_hexdump(FILE *f, const char *title, const void *buf, unsigned int len); /** diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h index daef846d40..3b2df526ba 100644 --- a/lib/security/rte_security.h +++ b/lib/security/rte_security.h @@ -901,9 +901,9 @@ rte_security_session_fast_mdata_set(void *sess, uint64_t fdata) /** Function to call PMD specific function pointer set_pkt_metadata() */ __rte_experimental -extern int __rte_security_set_pkt_metadata(struct rte_security_ctx *instance, - void *sess, - struct rte_mbuf *m, void *params); +int __rte_security_set_pkt_metadata(struct rte_security_ctx *instance, + void *sess, + struct rte_mbuf *m, void *params); /** * Updates the buffer with device-specific defined metadata From patchwork Wed Jun 14 14:26:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 128691 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B27D342CB3; Wed, 14 Jun 2023 16:31:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C43A742D2C; Wed, 14 Jun 2023 16:31:27 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 0189642D2C; Wed, 14 Jun 2023 16:31:26 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id D978E3200918; Wed, 14 Jun 2023 10:31:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 14 Jun 2023 10:31:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1686753084; x= 1686839484; bh=UnkMI0qj/OTm8TlR4Jp4114TBF07WFj0CGvpjzRVstI=; b=o ahVvzlprVzPJ7GP0qH2544fyiPur6tGr5w09ff2BxiJIHQ/AkCj/JQMI2uoYpd0N XUDqV0kL/9Jgk6npsvaMFY2AOXSPvkzurWF0myQsux/zuTDaoJw36LQjO1KtiCwe 9D7LUZebU0nLjWdjskiCz7oaOy83cTryS2dp1WPhX0V2fvx51DRirtz+eG0ZJAD5 DkMcaSBdPQRDMASlpClEWHuIzX8NlXU4OE7OarRY+kMw9qTEeXy+eFovjWaQ8Ocn T1RWh8S5RGREgvok/s3ATbjO6ajbJ9K3nqIh90ZoSYCwwEBixj1dojYThm3UO2qn 3Dhses9W2wsX4jPgQRZzQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1686753084; x= 1686839484; bh=UnkMI0qj/OTm8TlR4Jp4114TBF07WFj0CGvpjzRVstI=; b=h ScbNVC5R+TrIfKxAGK/H9oo8Ijehcw37zjoBCMaV/7Rgf8ms2f/6u4h6LPvEZUqD pHc/vkDKP1yLxyV9oydS4Dvz1fkvU+1EQPBUsUp6Lh18HUvecBKf4hPX54wkkJcb XC/6N3Ww75QjXXsOYdHnfslAvPuk8t4TgefUFGf5gDlZ++9EhL2R2EI1MaW9Si/C KmUvufsRyIHbG+oa9IYrlSgKgtg/mj8r97G+7rkY+ZbZWMhJ1HJmM/wkcb/meQpG pNsiucLJfOx3KBQL8BF04xDjXshmo3UEwv2v+BX5I899xEYc/PXPWYZR3vj6lEi7 kNaCp0+RTnX7laoto7GNw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedvtddgjeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedvjefhudeghedvtdeijeeigeetuedugfejueekieeltdfhteev keehhfeilefhtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Jun 2023 10:31:23 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: stable@dpdk.org, Akhil Goyal , Fan Zhang , Arkadiusz Kusztal Subject: [PATCH 5/5] cryptodev: fix comments of modular operation parameters Date: Wed, 14 Jun 2023 16:26:51 +0200 Message-Id: <20230614142651.1456116-6-thomas@monjalon.net> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230614142651.1456116-1-thomas@monjalon.net> References: <20230614142651.1456116-1-thomas@monjalon.net> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The Doxygen comments are made after the struct field, but were missing the Doxygen syntax /**<. Fixes: 518a974bfecc ("cryptodev: reorganize asymmetric structs") Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon --- lib/cryptodev/rte_crypto_asym.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h index fc3f331393..8b5794fb7c 100644 --- a/lib/cryptodev/rte_crypto_asym.h +++ b/lib/cryptodev/rte_crypto_asym.h @@ -395,9 +395,9 @@ struct rte_crypto_sm2_xform { */ struct rte_crypto_mod_op_param { rte_crypto_uint base; - /** Base of modular exponentiation/multiplicative inverse */ + /**< Base of modular exponentiation/multiplicative inverse. */ rte_crypto_uint result; - /** Result of modular exponentiation/multiplicative inverse */ + /**< Result of modular exponentiation/multiplicative inverse. */ }; /**