From patchwork Fri Jun 16 12:39:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhijit Gangurde X-Patchwork-Id: 128778 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A59342CDA; Fri, 16 Jun 2023 14:41:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A8AA4161A; Fri, 16 Jun 2023 14:41:15 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2044.outbound.protection.outlook.com [40.107.92.44]) by mails.dpdk.org (Postfix) with ESMTP id 58CEE40DDB for ; Fri, 16 Jun 2023 14:41:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=atmSYn14rLFHGREEiQtYvnUbZcqmbC+smy5siDjjxVBxN7ZP8lL6xY4dt1wfiq+7Rf5/cjUjHsNyXcxXO6Pok8HIqEG3cuG7CiuH5UhGG352ZXX5MbcbL9VEqLWVw+g8D+UkulOPebEiyaXkxWUyT4psandy/8ZBJVDXQG9wgT6a/gCaLRQa0cFsQi1R/4m5p6SsKjgo+OQoWYDr4dblWnTUGU6YFr/7yh/KW7VJ5gWtJHxuxbura9fAr8dcx7TSmdfMCwZgJsGj1+nrlWBMXmV66+fy9AwVOu0VSSpE65vJ0Zbtl81G1pdzgoJGmqELOidDntQlF0SdtRFRHUJDXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q2oxFh5AcYFJV/8Xd1KHaTMCfq3Xsw4V1R+uY1NPIFE=; b=D2Mv+bn57c6IVJIg7V6CUU3xCvQVci9Zmhco4gDHfLzovmR0KEXskQvwZJ9ExuZ/tMB/ASLMl4Op89uYtNEC8yXqm6hUNhG8SspmhD+fIcr8phZAqNdyXFBLEaUzT0e5DjntX9NTSQH1JTWegb/poplBON7yFtLP2LzTzeUyKkoA7px9DXRnbllFGWoSQn7d7cPXr9g64IK24kBAjhZP90Y7BpCwJQ9t0C1EBIxM1uR7J6Pj/foGeY0c/Lcu3f3LZSTlk/8mKh4JW5ZiTFYBkEFZi61CZdQnmPWvB7Y/oRtPUAD2fKpwQ6KLJf/1gT9pKMzGJMHs1f0ycQbpzVL0Sg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q2oxFh5AcYFJV/8Xd1KHaTMCfq3Xsw4V1R+uY1NPIFE=; b=EN/XQQD+rv8ImIWc17LQ9SJHglOzt+893vEENMJxl/OohnqBGjn5gnX1l1I9Jfat2CuaTl1BlvR1oAOmt6bPSXxphDMIrOkVTK4VCCzFdNQnDn/t+Sdya88p9QgUlvk9Dv/zzo47Pd/Lg/z1t6DZtgJLRXCpPp7c8LJC41Qb538= Received: from BN0PR04CA0065.namprd04.prod.outlook.com (2603:10b6:408:ea::10) by SN7PR12MB6692.namprd12.prod.outlook.com (2603:10b6:806:270::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.29; Fri, 16 Jun 2023 12:41:10 +0000 Received: from BN8NAM11FT094.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ea:cafe::38) by BN0PR04CA0065.outlook.office365.com (2603:10b6:408:ea::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.29 via Frontend Transport; Fri, 16 Jun 2023 12:41:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT094.mail.protection.outlook.com (10.13.176.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6500.29 via Frontend Transport; Fri, 16 Jun 2023 12:41:10 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 16 Jun 2023 07:41:09 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.6; Fri, 16 Jun 2023 05:41:09 -0700 Received: from xhdipdslab59.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Fri, 16 Jun 2023 07:41:02 -0500 From: Abhijit Gangurde To: , CC: , , , Abhijit Gangurde , Nipun Gupta Subject: [PATCH v2 1/3] bus/cdx: remove ineffective code statement Date: Fri, 16 Jun 2023 18:09:08 +0530 Message-ID: <20230616123910.1110724-2-abhijit.gangurde@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230616123910.1110724-1-abhijit.gangurde@amd.com> References: <20230616123910.1110724-1-abhijit.gangurde@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT094:EE_|SN7PR12MB6692:EE_ X-MS-Office365-Filtering-Correlation-Id: 42323e0a-1f88-4c9a-fbe2-08db6e66f675 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P5cn32FiZ5vktnvlegTI9Yarbczxqd4wmovrt8ngWUgpxJGMwN57DwabZ4gcbC5zA2M8aslDvMw/uTVbATqhCcDQkRJPK6D4N+WIoC4+7X5qknkC6gPx8Zryna7/piwdwpjkGEmMDWM1qel5r/RgGc0nW8Cgve6Wd8EBFpACc10fq8ewkMxfxS1QGgvjvJejFtCxlTFqQkXLAdGMfaHnVN8KabIS2vRRN5jqBdSLpP99w0gTroG6UPZ63/P3jqD54z9UmgPMPtV4JHdcsjMx9tt1wz/D3i1or17CfcJWDBTwGYSmj44WUEwqA5sEQDFHJt9iqcZdIi2/pvdE9VrHRMnVai65p1kqa8NuE4FF+oyqSOUV2mhC5FqV0Ghyhx45ADsZT44LRu5ONscYCRDHJ4U5oqvgbCSPm7/WcNGgpwZ/j9dExggIns3Mp+yLcKwoQ/EEF3RzvDfA9z31EwoBr2yFcek9oBlPi5jbIQK66CADibqgJEuSY6xhBOBw1jJGj0/qoMDpYKqcOoM+pPol6hucJC6Ta3xB3gUKpNN/DhlYr4P+I0KGn46I5NSye0X9oqLJmhHloq2ITI57dt/xXxqbb/nlVYcKZVHlkxHE/pBVZJA/5O+XIu6rp0sru8jIjBFrX7mQ+1iudKC4LsOjttPCrQdicMdpCu9PGOiMarqtektTC/fBWg/4t+r8g0z01lEDuPxJRmLVDs9KUJgrVGb0xL9r8kiTgyTKbsaS8MKB0Twt3OT/RvuB2yfYaWROkouCriOt/KS87z27TSAQ7w== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB03.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(376002)(396003)(346002)(451199021)(40470700004)(46966006)(36840700001)(336012)(426003)(83380400001)(47076005)(40460700003)(2906002)(4744005)(2616005)(356005)(82740400003)(81166007)(36860700001)(36756003)(40480700001)(5660300002)(86362001)(82310400005)(41300700001)(70206006)(70586007)(316002)(4326008)(6636002)(8676002)(8936002)(478600001)(186003)(44832011)(26005)(1076003)(54906003)(110136005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 12:41:10.3235 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 42323e0a-1f88-4c9a-fbe2-08db6e66f675 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT094.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6692 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove ineffective code statement ret = 0 since it is overwritten in a loop. Coverity issue: 385379 Fixes: 45ef232af515 ("bus/cdx: introduce AMD CDX bus") Signed-off-by: Abhijit Gangurde Acked-by: Nipun Gupta --- v2: - Updated commit message drivers/bus/cdx/cdx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx/cdx.c index 28bbf92ed5..9130c30515 100644 --- a/drivers/bus/cdx/cdx.c +++ b/drivers/bus/cdx/cdx.c @@ -452,7 +452,6 @@ cdx_probe(void) dev->name); rte_errno = errno; failed++; - ret = 0; } } From patchwork Fri Jun 16 12:39:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhijit Gangurde X-Patchwork-Id: 128779 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B72A842CDA; Fri, 16 Jun 2023 14:41:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A911A42B71; Fri, 16 Jun 2023 14:41:39 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2051.outbound.protection.outlook.com [40.107.220.51]) by mails.dpdk.org (Postfix) with ESMTP id 16DF840DDB for ; Fri, 16 Jun 2023 14:41:39 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ch88Pr/Gn36XQRMYEzBceq/Q2LY6SIk/xbYvQYC5OdyqwhjCGYQ3jo1fip8SCB/KzsRVlhCCB5q72wv5UrbjZT9dtrgeyky8oJVfSOl9tpHpyaGUe5j+iNM9esR4FB6N2tHSZS6CVp0zeMH23UUE4xHHBthWI+B4w5HA4xr1RHJaseQ7oI9Fwy8VDHZWGsDDhkuVQKUbM+LecD5nCcJfkWYm+rO6BcBKDbO3h34LEummNWwaJY5Y0daJ+6kCUuqF7yviLEVCP+xid624iMNiQ/LQ/K3k3UxfldiqMPmmibWflOOqteLm6RwAQjg0h4qjLhYHYNCcbrJspJ8USKZeQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pKW1ALHu+rN1q26AGFy1T6UTXYTUne+kDZl7GPMDeIw=; b=kzHOWMyIAfQT9m66Bm4uQtroj0kFmKCaHMvgEJPNjErK0zxEPNYQy0FXPwXhv5K2OPveO02XAHkUijiGaIeFzZtjuImVWbhA2MKrD5RUQSmFgYVbQ1vcrlZfU9g40PbRYzdVv9zF2+RDi1cchuctO3frmd7s9EDlcZ0CVUGPkgi4bDEj58ngUEBNVoQZzaAkYOzdOwehKROH2XlgxiC1JKxu62LPdtSUPXVlN+YVCN1+1iCEqtEUDUya4eXiak+2NPswv1mNdya1E2Q7ZG8VlDoCizJV3qJ2f5gtw/E0/iuGkxPeIRiivIQW5P8JLdAOqBDd+ibQ7KFKbzJe799dtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pKW1ALHu+rN1q26AGFy1T6UTXYTUne+kDZl7GPMDeIw=; b=UKEiFxkNWjoyoajG6Hv+rAIxwcB6Ifs3CHD34OsClP0kNk4xCLFA4rZre1UPZpS5ilsHaXQEL/B5NSo+Z34dXk5oC4dklwiOTNl6CNKwYUKnJdjq0c+FZiqw1g6zZEctaSpLtr6etJEvQ90Y9La+9NRuVbRsiyHo4vOoMuAPdI0= Received: from MW2PR16CA0060.namprd16.prod.outlook.com (2603:10b6:907:1::37) by BY5PR12MB4321.namprd12.prod.outlook.com (2603:10b6:a03:204::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.27; Fri, 16 Jun 2023 12:41:36 +0000 Received: from CO1NAM11FT031.eop-nam11.prod.protection.outlook.com (2603:10b6:907:1:cafe::99) by MW2PR16CA0060.outlook.office365.com (2603:10b6:907:1::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.27 via Frontend Transport; Fri, 16 Jun 2023 12:41:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT031.mail.protection.outlook.com (10.13.174.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6500.29 via Frontend Transport; Fri, 16 Jun 2023 12:41:36 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 16 Jun 2023 07:41:34 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 16 Jun 2023 07:41:29 -0500 Received: from xhdipdslab59.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Fri, 16 Jun 2023 07:41:27 -0500 From: Abhijit Gangurde To: , CC: , , , Abhijit Gangurde Subject: [PATCH v2 2/3] bus/cdx: move debug print before unmapping resource Date: Fri, 16 Jun 2023 18:09:09 +0530 Message-ID: <20230616123910.1110724-3-abhijit.gangurde@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230616123910.1110724-1-abhijit.gangurde@amd.com> References: <20230616123910.1110724-1-abhijit.gangurde@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT031:EE_|BY5PR12MB4321:EE_ X-MS-Office365-Filtering-Correlation-Id: d3507bf9-7a39-42af-650e-08db6e6705d7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PxPUMrF4Ankxzz63sbusF3p5oREja6eCr3dc/VixZvoeSfKyJRAnTXSkxDpb2exZ6Du+hn5vV6yeZ2W8tFoo6ykZ8plaH6Tv9UC2zHvpMvi/UkN9wXbaOkSsq8hdTRg5r/CUMtD2TpL2pU3t7i6gim3Hq8EvdpEl6mV/03h1v18IpzLj3ypLfiX32l5Delou7yCWIf5OJ8WO8NI7dKf4qVO0hgu/CP2tPiI0++TXoLgUGnYZfwbr5dfBk3OPT/F+cdMoQS9kCje+Fj3/5bs/aczpTdNJzPCJ73YXiBppSSrSKeSv2OLJflhmPzQw9KKLHyb8q6M7rcU9K+fayPZUT2Y/AFZNKlxAozjbuMtF1AwGzvd+qL2Fgzi8+D/0/PMgMSOqN6RXJMyj8o+jTzOAQqZ4yvniJB4zPVpXZx64ZYUILJCg4CD4sfw03rspezc6DFnspYE0DlLSv5yeh1u2buYkAg1TMn8L4KP5bg25klSKc7prHv+5BlbnVwNfENG0tPup3k4KqWQTvZDCs1Ui7Nwiwku2nuIBDVKTIxRMK3KHCFcy/RxL+3LaBUfXRJZqFNJwohrRNd7hv+hUKY3MFglM6PIHMb5Ju70YDRBx3uBlABopNsvMteD52ZtRonY0CM/sHcrklvvsr5b8Zr1TJMeCeGU6gZlY1Uq75OJSYC+c68BEAPjCsudI9+3vPtYmH+i9E3fpqteCID4EC6gr0ftycoZckgs6Q38RraWnHIJ6KNxoS/MTZMp+VVbD1fvPlBJdQDrfdrPM++RP5PrAsg== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230028)(4636009)(346002)(376002)(136003)(39860400002)(396003)(451199021)(36840700001)(40470700004)(46966006)(36756003)(82310400005)(86362001)(478600001)(8676002)(8936002)(41300700001)(81166007)(82740400003)(6636002)(4326008)(110136005)(54906003)(6666004)(316002)(5660300002)(44832011)(1076003)(186003)(26005)(2906002)(36860700001)(2616005)(47076005)(40480700001)(356005)(70586007)(70206006)(426003)(83380400001)(40460700003)(336012)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 12:41:36.0027 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d3507bf9-7a39-42af-650e-08db6e6705d7 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT031.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4321 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Move debug print before unmapping requested address to fix use after free coverity issue. Coverity issue: 385381 Fixes: 45ef232af515 ("bus/cdx: introduce AMD CDX bus") Signed-off-by: Abhijit Gangurde --- v2: - Updated commit message drivers/bus/cdx/cdx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx/cdx.c index 9130c30515..aef19682f4 100644 --- a/drivers/bus/cdx/cdx.c +++ b/drivers/bus/cdx/cdx.c @@ -322,12 +322,13 @@ cdx_unmap_resource(void *requested_addr, size_t size) if (requested_addr == NULL) return; + CDX_BUS_DEBUG("Unmapping CDX memory at %p", requested_addr); + /* Unmap the CDX memory resource of device */ if (rte_mem_unmap(requested_addr, size)) { CDX_BUS_ERR("%s(): cannot mem unmap(%p, %#zx): %s", __func__, requested_addr, size, rte_strerror(rte_errno)); } - CDX_BUS_DEBUG("CDX memory unmapped at %p", requested_addr); } /* * Match the CDX Driver and Device using device id and vendor id. From patchwork Fri Jun 16 12:39:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhijit Gangurde X-Patchwork-Id: 128780 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D88C742CDA; Fri, 16 Jun 2023 14:42:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5AA04161A; Fri, 16 Jun 2023 14:42:07 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2059.outbound.protection.outlook.com [40.107.220.59]) by mails.dpdk.org (Postfix) with ESMTP id 3900340DDB for ; Fri, 16 Jun 2023 14:42:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YpJ3H6hERfG/R+NIZEkESlz4q0tYgE7lUJfq3uHrhM1BJ+CDnrXxXeictubaxnHjH5UTOFvJaGiy1tpV6Ln1NPQkAMdyKU+129s6zd+y/lBLcGjU70XoBrDop0/NzW2JhwD3Yc2udrCLu2VlgkOGWUiGVAvQPLlkHi8XGvS+XvmJcOC/+ZOMnqmwZ1LEVhDqm4cWWew+tpXeqPD3fc52+rKu03GMnCGc9f1POXGQBPmB2HR0HpqCCMQjajHnKhIBMVEdGlJmf+P+6QiJjteX/fE+G1dUg2cyOTeDbjGfbdhOvhtgVpmd8POu2eKyuuqhd+7Zf1CpTb8SixwFV/MTAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Koe9r0iORvvsrRDxHt01rewETy2dbo8FFU4X/KemanY=; b=WUQyhgX6zfKNw/e8gyRtAvg7TFeCF+5mV4liZj4t2NF0wc9SSxNf0+yo5gL+bGKx4ivaC3pqqyAdEvapqKr8nXfikvpMT/7VSEuvON13je6NFjNZq9qJIJF6EsuwbjM1j1cVCX3fjKG1MP2B6CNm977roeikvPsoQnGQWuUkRY6sIJWcvekVQ1H/gGocD2rS+Pb2dl2boT/+xdQXqzt4iO2E5hkVSz4saUelrhZG6aU6FEFKxRoYwGDZkNYg7fGPs+0iek8VvYeh0OCSbrGM+129fR3hR5gFLvDeLzP2c0NoqEI88l8sDivsACJxTA9LhInhkDPkdpzl8obcEZz6eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Koe9r0iORvvsrRDxHt01rewETy2dbo8FFU4X/KemanY=; b=pR1J8g2PTnu46vQ3r6uyYUOBpJBBajC09HTd0D6R4XQDIkPPBB1nMInVMZgZNvmx4GRWAyeumTcin/yZp0PXOedVA0hE/Ue4G8tsm7KiGTXG+E4uOW7C3lP87dwQbYNwaNbWNH4icyUeJUyZCcIlhhkQmH7jn8xIYEwgVNwJB/g= Received: from BN0PR04CA0146.namprd04.prod.outlook.com (2603:10b6:408:ed::31) by CH3PR12MB7620.namprd12.prod.outlook.com (2603:10b6:610:150::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.25; Fri, 16 Jun 2023 12:42:04 +0000 Received: from BN8NAM11FT084.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ed:cafe::3e) by BN0PR04CA0146.outlook.office365.com (2603:10b6:408:ed::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.29 via Frontend Transport; Fri, 16 Jun 2023 12:42:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT084.mail.protection.outlook.com (10.13.176.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6500.29 via Frontend Transport; Fri, 16 Jun 2023 12:42:03 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 16 Jun 2023 07:42:02 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.6; Fri, 16 Jun 2023 05:42:02 -0700 Received: from xhdipdslab59.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Fri, 16 Jun 2023 07:42:01 -0500 From: Abhijit Gangurde To: , CC: , , , Abhijit Gangurde Subject: [PATCH v2 3/3] bus/cdx: fix resource leak Date: Fri, 16 Jun 2023 18:09:10 +0530 Message-ID: <20230616123910.1110724-4-abhijit.gangurde@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230616123910.1110724-1-abhijit.gangurde@amd.com> References: <20230616123910.1110724-1-abhijit.gangurde@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT084:EE_|CH3PR12MB7620:EE_ X-MS-Office365-Filtering-Correlation-Id: 271db4be-2b25-449c-f0d2-08db6e671640 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 41dHxwOxVqQU3zzkXXY8u2U35YnxiYljvpbQrbmumvsMzmXygyrdrCvOKIYoMDwhJbSeEiCDb3AT8LYIftJ1mH17fmgCsdvMfP8BlLkAL8Z8Vek8Yy4wVXKSaTYN0rS0ZKOfWEmEFp2pSCCMuPrnelrOG6Ut/2sx6Intd9raxCcn4G1F2JMY6XmG1gQUwPKnG4q7IOfdAvVtlLZClFNV0GWsFdqPqqytJr30JCmjqIfJ/2Iy+PqCTlkQxWe1xNd4L84+zUVRrnvpK1GBK8/pom3uVBbvk6jP3XpZwjnWpu0bDZMD9QNmnfYb6fYmNi3ZhG9d28L82Opn1a9QFEFs7jTjZHf8nWtIGohxChi/xIw8oYDOHRp0bMfVHF0YVgDemVZQjwoELJPzirJp4UMmt3hfuOYomKGgy50JPmOLAgKg0YlSdiqdK2EENFF+5jxeI65S04jrmk7Kla7lfenkWvr24gYYSCdCFMKPTsd5VNGTwA3PWGFSsTpFbx5qdWXWHf4ZSHiF44vjP/+uAy7ue8JTRfOS0zdgA4EJXfP3zbzUhXxJV9hfd/6OHiO105rYD9cfT1Smrw9bCAf3RL25ubXSWjEFeygagdfNeh3W8Z124FR9w13XEzXlQREzM4VsPHCLNQ3WgEwXGApwkOR4QEljgp6jQIahKh8tA4jtgYwNIkysmUBFqnpT4t97azwArq4ML1eu6Oi3bmJ9MwYWS2JCaOiralE8jDN5JmQFMNnll9cLsL4wxz0WY7lJ0nPzDL5p/bZpQgtPm++u4qCAGA== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB03.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230028)(4636009)(136003)(396003)(346002)(39860400002)(376002)(451199021)(40470700004)(36840700001)(46966006)(44832011)(70586007)(6636002)(4326008)(2906002)(86362001)(316002)(70206006)(41300700001)(110136005)(8936002)(5660300002)(8676002)(54906003)(40480700001)(82310400005)(478600001)(81166007)(6666004)(82740400003)(356005)(40460700003)(83380400001)(26005)(186003)(2616005)(36756003)(426003)(1076003)(336012)(47076005)(36860700001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 12:42:03.6629 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 271db4be-2b25-449c-f0d2-08db6e671640 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT084.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7620 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Free the allocated device memory and interrupt handler on error scenarios. Coverity issue: 385377 Fixes: f29fb5caa135 ("bus/cdx: support MSI") Signed-off-by: Abhijit Gangurde --- v2: - Updated commit message drivers/bus/cdx/cdx.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx/cdx.c index aef19682f4..f9526e08cc 100644 --- a/drivers/bus/cdx/cdx.c +++ b/drivers/bus/cdx/cdx.c @@ -208,8 +208,8 @@ cdx_scan_one(const char *dirname, const char *dev_name) ret = cdx_get_kernel_driver_by_path(filename, driver, sizeof(driver)); if (ret < 0) { CDX_BUS_ERR("Fail to get kernel driver"); - ret = -1; - goto err; + free(dev); + return -1; } /* Allocate interrupt instance for cdx device */ @@ -218,6 +218,7 @@ cdx_scan_one(const char *dirname, const char *dev_name) if (dev->intr_handle == NULL) { CDX_BUS_ERR("Failed to create interrupt instance for %s", dev->device.name); + free(dev); return -ENOMEM; } @@ -241,8 +242,8 @@ cdx_scan_one(const char *dirname, const char *dev_name) /* get device id */ snprintf(filename, sizeof(filename), "%s/device", dirname); if (eal_parse_sysfs_value(filename, &tmp) < 0) { - free(dev); - return -1; + ret = -1; + goto err; } dev->id.device_id = (uint16_t)tmp; @@ -251,6 +252,7 @@ cdx_scan_one(const char *dirname, const char *dev_name) return 0; err: + rte_intr_instance_free(dev->intr_handle); free(dev); return ret; }