From patchwork Tue Jun 27 21:03:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: David Christensen X-Patchwork-Id: 129025 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3593842D76; Tue, 27 Jun 2023 23:03:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB90940F18; Tue, 27 Jun 2023 23:03:52 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mails.dpdk.org (Postfix) with ESMTP id 3BCE040EE1 for ; Tue, 27 Jun 2023 23:03:51 +0200 (CEST) Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35RKqKss016061 for ; Tue, 27 Jun 2023 21:03:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=pp1; bh=E3We9I1nSFCpRzlgDDo8MV47rh+GYchP6XVtwyWG/dg=; b=isKxSipfFmu50yBUKnwz38StKFhnRrCJj5JxuqNJUOqCXAkZ0ys3gTO3SDJj5rDSUr+6 bKFI+CJjHnVJJCsO4gOYpsocOWg438ttAmDEE1yIswPBvlUcpaIlPEiyoVaXP8JZVJVi E8rx95y1voFlwUAoNDAYlk51xY2OGzq/1JHCNp1FqwQcxqrMu6Mjab8EfioCNP8eJHs5 bM2yEPT+TCOQR6g0+E56G5uvpxveYr8hkP9nGTh6jmJzNPXu6lS6OCDDQThHNj8ViT1a CRyorcUop5qqHV5iTvxbz37FiEV99pIqc2ULSxDY2JwyeAiNPmcJGubfcvMekISfHKwh Hw== Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rg76b0at3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 27 Jun 2023 21:03:49 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35RGqoMT014641 for ; Tue, 27 Jun 2023 21:03:48 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([9.208.130.100]) by ppma03dal.us.ibm.com (PPS) with ESMTPS id 3rdr45ersy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 27 Jun 2023 21:03:48 +0000 Received: from smtpav02.wdc07v.mail.ibm.com (smtpav02.wdc07v.mail.ibm.com [10.39.53.229]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35RL3lx151446148 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Jun 2023 21:03:47 GMT Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6FA9D58058; Tue, 27 Jun 2023 21:03:47 +0000 (GMT) Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0F37D5805B; Tue, 27 Jun 2023 21:03:47 +0000 (GMT) Received: from ltc19u30.pok.stglabs.ibm.com (unknown [9.114.224.51]) by smtpav02.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 27 Jun 2023 21:03:46 +0000 (GMT) From: David Christensen To: dev@dpdk.org Cc: David Christensen , Thinh Tran Subject: [PATCH v2] config/ppc: fix gcc "internal compiler error" message for p10 Date: Tue, 27 Jun 2023 17:03:41 -0400 Message-Id: <20230627210341.2516951-1-drc@linux.vnet.ibm.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20230627205437.2476729-1-drc@linux.vnet.ibm.com> References: <20230627205437.2476729-1-drc@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 59t7ma_PErY7H4WoJ3s_g4_J56Cvuezd X-Proofpoint-ORIG-GUID: 59t7ma_PErY7H4WoJ3s_g4_J56Cvuezd X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-27_14,2023-06-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 phishscore=0 spamscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 mlxlogscore=945 adultscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306270192 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Building DPDK with gcc 11.3.x for the power10 instruction set may generate the following error: ../drivers/mempool/cnxk/cnxk_mempool_ops.c during RTL pass: final ../drivers/mempool/cnxk/cnxk_mempool_ops.c: In function ‘cnxk_mempool_alloc’: ../drivers/mempool/cnxk/cnxk_mempool_ops.c:124:1: internal compiler error: output_operand: invalid expression as operand 124 | } | ^ Please submit a full bug report, with preprocessed source if appropriate. ... ninja: build stopped: subcommand failed. The same issue is not encountered when building with gcc 11.4 or later, where the compiler automatically adds the option "-mno-block-ops-vector-pair" when building for power10 which is intended as a code optimization and also effectively avoids the compiler bug displayed. Modify the meson.build file for ppc and manually set the flag when building for power10 with gcc less than 11.4. Bugzilla ID: 1251 Signed-off-by: David Christensen Tested-by: Thinh Tran --- v2: - Fixed spelling error in commit message --- config/ppc/meson.build | 8 ++++++++ 1 file changed, 8 insertions(+) -- 2.31.1 diff --git a/config/ppc/meson.build b/config/ppc/meson.build index 1cba44011f..160b203cb1 100644 --- a/config/ppc/meson.build +++ b/config/ppc/meson.build @@ -105,6 +105,14 @@ else endif endif machine_args = ['-mcpu=' + cpu_instruction_set, '-mtune=' + cpu_instruction_set] + +# gcc versions < 11.4 may fail to build for power10, see https://bugs.dpdk.org/show_bug.cgi?id=1251. +# Explicitly specify a default used in gcc 11.4 and later to workaround the issue +if (cpu_instruction_set == 'power10' and cc.get_id() == 'gcc' and + cc.version().version_compare('<=11.4')) + machine_args += '-mno-block-ops-vector-pair' +endif + dpdk_conf.set('RTE_MACHINE', cpu_instruction_set)