From patchwork Fri Jun 30 06:06:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhichao Zeng X-Patchwork-Id: 129132 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F254642D67; Fri, 30 Jun 2023 07:59:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC3CE406B5; Fri, 30 Jun 2023 07:59:39 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 8C5D74021F for ; Fri, 30 Jun 2023 07:59:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688104778; x=1719640778; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=KYl/QM5dRigZbfy5ga1uhWcZyEWPwnhTdK6aw0nS7Lw=; b=ioexu1r4mJ87e9VxN9BN2GNV5Bg8KIH3dpKYrA/xW5c8H1Y1ALOzPjId qevN3X8Sxm8zJVg1T39m4z82QZ0U7wVWbty1b94u6shtGzURpxxxps5Z2 3CYGFWmz4rKQ2PbS+WlLpM8MBqo+k6ub95SCRL0PnLiKKJIIsKP+3G2/4 i/cDQMZg36BfB85p004Ap5izjLs2pbZCnEiRX7+Z30lmhUffDUMBx/sCV vRnnXLovgPNUZiBXI+57slptkTBlmZERoe51DCl3lc47pa2qkUAkWWo4w glz7S9GSVZDkuJH3gV1ONKwQaqg18+/R3gQk5PI3r8uVd3LfXUtZUQQ2G Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10756"; a="361168381" X-IronPort-AV: E=Sophos;i="6.01,169,1684825200"; d="scan'208";a="361168381" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2023 22:59:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10756"; a="720830513" X-IronPort-AV: E=Sophos;i="6.01,169,1684825200"; d="scan'208";a="720830513" Received: from unknown (HELO zhichao-dpdk..) ([10.239.252.103]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2023 22:59:35 -0700 From: Zhichao Zeng To: dev@dpdk.org Cc: qi.z.zhang@intel.com, songx.jiale@intel.com, Zhichao Zeng , Jingjing Wu , Beilei Xing Subject: [PATCH v2] net/iavf: fix duplicate reset done check with large VF Date: Fri, 30 Jun 2023 14:06:16 +0800 Message-Id: <20230630060616.1569254-1-zhichaox.zeng@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230621075156.2997087-1-zhichaox.zeng@intel.com> References: <20230621075156.2997087-1-zhichaox.zeng@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When starting with large vf, need to reset VF to request queues, the reset process will execute VIRTCHNL commands to clean up resource. VF reset done check and reset watchdog read the same global register, resulting in the NIC not responding to the VIRTCHNL command. This patch turns off the watchdog when request queues to avoid the VIRTCHNL command timeout error when starting with large VF. Fixes: af801b0374e3 ("net/iavf: add devargs to control watchdog") Fixes: 7a93cd3575eb ("net/iavf: add VF reset check") Signed-off-by: Zhichao Zeng Acked-by: Qi Zhang --- drivers/net/iavf/iavf_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 00b963128b..ac7154d720 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -577,6 +577,7 @@ iavf_queues_req_reset(struct rte_eth_dev *dev, uint16_t num) PMD_DRV_LOG(INFO, "change queue pairs from %u to %u", vf->vsi_res->num_queue_pairs, num); + iavf_dev_watchdog_disable(ad); ret = iavf_dev_reset(dev); if (ret) { PMD_DRV_LOG(ERR, "vf reset failed");