From patchwork Fri Jun 30 12:57:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bing Zhao X-Patchwork-Id: 129164 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0654142D95; Fri, 30 Jun 2023 14:57:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 79FFF41141; Fri, 30 Jun 2023 14:57:55 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2079.outbound.protection.outlook.com [40.107.220.79]) by mails.dpdk.org (Postfix) with ESMTP id BDC0B406B6; Fri, 30 Jun 2023 14:57:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hzORP97z+X8F4gmKoL2t6su+dqJsb2XXQYfdf513/9jcz13Ae6b3FeFNDEWHq7/4V7XmZddxNgshQvHDpDQ+nW3dzXqdC+KGaRKJXEgO3fgUdtTTmHnx/nyQ7Avp/gWFTZYHgW1MxbWPQI3ToL+IL0LOG36iLC1imXaIzS14yAK2YC1WHTcUWwjVJZMhCThB4PbudsfvbYRdkk0xUjq0Qzpgt6JWoHLh1wYPRyzGXb4YSz36PgGzbcaXUxNSRZgrA7BjxulKRGEVfKMEYbkdyNcA472S4nW3Nx7Q32b5LhnKBUppmR8Lps1SVrUjifzP/8s0bfBO/OiiDPdyD6FVzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZC0OwDf4dFJOwLkDXrGcyyPI3/huQE8ndcbTQPCXeyk=; b=cGZ9BQD3tOiteYXzkR2BOrCq3vw2uKtgiQuaxqlo9oofAGo+WCNkcFEakGP0fFAXQFZHV6RdgNH0apM9g+HoUC6jh4KgDY0E4J1m/EvwcixgqbW1ZS0Ky0ImiYDjGt7eYTmIs0lnehjWlp/BGjNyazS2qSB9Mtsd2b9zeEleTZiMaxwczRbf8KYaYbsR6LmP9vsexbJsOILtCk5mVLPnwFkA7bDwRi8K9LmvNBSMS0O8xJzqy3pBMvWXKEXi7R6GHk5AQCR7gcxuCmEAYk+5LE/16nengE0O66NaJtsSF3+khWBTCtiUyTPupqPZv9Cglnw6VBzJkdcS0clgwvkM3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZC0OwDf4dFJOwLkDXrGcyyPI3/huQE8ndcbTQPCXeyk=; b=Cq1vbXLrwjpWTCJBrnOS7Ko+F/6/VUpnQlk/1CfRABe/2hV1eZOSXJnewRlgUrnOTl4yMNNG04JmKbqBYFwIFphbrLzoLbXRkpslKFUCzvKksYfvSqfhYXcgrD4495kbAc3rIbpFl0ypxrtg4d7rLo9JYCsVoX/ee/4XKx9o8T7uF2KzcWx4XEmOJgV4QuDWcBi4HV1Zn3b+b2DkjURGkq59Apbc0VTBjBiTOEGbRJ0Dp+1uo5t5s18bSjL6TyusMcstg9cbAGn+ObofDdrElMZ3dV1cEYKOMJZoP6Zd29b8th+xjXrwiXmkVI77+ehuJjzJkjt3k+dk9LvA7BFc1g== Received: from BN9PR03CA0901.namprd03.prod.outlook.com (2603:10b6:408:107::6) by IA0PR12MB7776.namprd12.prod.outlook.com (2603:10b6:208:430::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.19; Fri, 30 Jun 2023 12:57:51 +0000 Received: from BN8NAM11FT028.eop-nam11.prod.protection.outlook.com (2603:10b6:408:107:cafe::77) by BN9PR03CA0901.outlook.office365.com (2603:10b6:408:107::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.22 via Frontend Transport; Fri, 30 Jun 2023 12:57:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT028.mail.protection.outlook.com (10.13.176.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.49 via Frontend Transport; Fri, 30 Jun 2023 12:57:51 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Fri, 30 Jun 2023 05:57:47 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Fri, 30 Jun 2023 05:57:45 -0700 From: Bing Zhao To: , , , , CC: , , Subject: [PATCH] net/mlx5: reduce the counter pool name length Date: Fri, 30 Jun 2023 15:57:30 +0300 Message-ID: <20230630125730.435542-1-bingz@nvidia.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT028:EE_|IA0PR12MB7776:EE_ X-MS-Office365-Filtering-Correlation-Id: cebfffb1-5320-4e49-3be4-08db79699d09 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EuR75kZSJwvKxr1PaR0APYXpa3ezuC/J3EqIf/O4SRLf4jtonYC2E0t+//O6EKbla/pESjFn+sJ8l3EdScAK4HTgdCN0K5iTkJfCH5UCocATDxOAM77MKB5OfS8NpbU+xN46YPF9QTps6isZyvTl7hBJ1HMMblewVT+VQOmLs2uYov/HOL4oeHWdZLfJiiTNjftH/AtLNGtmkdSBTFOpylcIobNHuTbJ0VmbPcD/9J95NMF9lo+3rWHbDg0QTL0tt4jJI3aHWMcZNGURQO4LcTYZpr8TQ+kbAJZRv7WV+1RhRay38sf5VMbahZ5oP1DWW6qv4C3HBetlQjmzXEInlltEFOX0BzxfaWK79k95vT2DBylHAFbjzpwWF0trPc1tx6qWVKg19RAWd5ZbEjo0Sh75CakoXhng53mB4Bk2C7cKxfgx8hSdg57Q7ADEGFugqIP52DpRGAwJVTKd6LlrrUj5sdGoPgYEAMLcm/Sg9ag1WwFtyQgpNaZpXuxw/qatnbYjTNptSe4JFvJ+HRi4dBEdxbf98XwI305RU/QbDy64i5nZCHTRqJlfqvNX3dYf/PLv5aR5oVgKuyqcOryJdRWOYYCchOdbC2AolGq0AUsjvCULD9A1j1WwM051rNslACkpE8CY83d1n6gmR6crUgzDKk5+2OLfMyN3RqfDSgrMkzPtzspurhfjpBX+JTCI3/+SfSw3JSxDH8T+IDlfyGKJQq9jXeX6kZHBmAyXzX1Dg2wkVHhsRA8YNm13l/Ww X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(346002)(376002)(396003)(451199021)(46966006)(36840700001)(40470700004)(336012)(426003)(47076005)(40460700003)(83380400001)(2616005)(2906002)(7636003)(356005)(82740400003)(36860700001)(40480700001)(36756003)(55016003)(8936002)(8676002)(82310400005)(110136005)(5660300002)(86362001)(450100002)(54906003)(41300700001)(6636002)(4326008)(70206006)(70586007)(6666004)(316002)(7696005)(478600001)(16526019)(6286002)(186003)(1076003)(26005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 12:57:51.4337 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cebfffb1-5320-4e49-3be4-08db79699d09 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT028.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7776 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The name size of a rte_ring is RTE_MEMZONE_NAMESIZE with the value 32 by default. When creating a HWS counter pool cache, the final string format was "RG_MLX5_HWS_CNT_POOL_%u_cache/%u" and it could support less than 1000 variants. For example, if the first %u representing port id is 100 and it will take all the available characters then the second %u for queues will be discarded. If there was more than one rule creation queue, the rte_ring could not be created. By reducing the fixed character number and using hexadecimal format, the issue can be overcome with an assumption that not all the integer fields for queue index is used. Fixes: 13ea6bdcc7ee ("net/mlx5: support counters in cross port shared mode") Fixes: 4d368e1da3a4 ("net/mlx5: support flow counter action for HWS") Cc: jackmin@nvidia.com Cc: stable@dpdk.org Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_hws_cnt.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/mlx5_hws_cnt.c b/drivers/net/mlx5/mlx5_hws_cnt.c index d98df68f39..18d80f34ba 100644 --- a/drivers/net/mlx5/mlx5_hws_cnt.c +++ b/drivers/net/mlx5/mlx5_hws_cnt.c @@ -419,8 +419,7 @@ mlx5_hws_cnt_pool_init(struct mlx5_dev_ctx_shared *sh, goto error; } for (qidx = 0; qidx < ccfg->q_num; qidx++) { - snprintf(mz_name, sizeof(mz_name), "%s_cache/%u", pcfg->name, - qidx); + snprintf(mz_name, sizeof(mz_name), "%s_qc/%x", pcfg->name, qidx); cntp->cache->qcache[qidx] = rte_ring_create(mz_name, ccfg->size, SOCKET_ID_ANY, RING_F_SP_ENQ | RING_F_SC_DEQ | @@ -612,12 +611,10 @@ mlx5_hws_cnt_pool_create(struct rte_eth_dev *dev, int ret = 0; size_t sz; - mp_name = mlx5_malloc(MLX5_MEM_ZERO, RTE_MEMZONE_NAMESIZE, 0, - SOCKET_ID_ANY); + mp_name = mlx5_malloc(MLX5_MEM_ZERO, RTE_MEMZONE_NAMESIZE, 0, SOCKET_ID_ANY); if (mp_name == NULL) goto error; - snprintf(mp_name, RTE_MEMZONE_NAMESIZE, "MLX5_HWS_CNT_POOL_%u", - dev->data->port_id); + snprintf(mp_name, RTE_MEMZONE_NAMESIZE, "MLX5_HWS_CNT_P_%x", dev->data->port_id); pcfg.name = mp_name; pcfg.request_num = pattr->nb_counters; pcfg.alloc_factor = HWS_CNT_ALLOC_FACTOR_DEFAULT;