From patchwork Thu Jul 6 16:21:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Dooley X-Patchwork-Id: 129348 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BAA642DEA; Thu, 6 Jul 2023 18:21:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A35EC42FDA; Thu, 6 Jul 2023 18:21:28 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 213A6410FA for ; Thu, 6 Jul 2023 18:21:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688660486; x=1720196486; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9z0+SbXl1fPRqgTUHxcDG3TEuJgDBi7trhoHiVEhik0=; b=Dor4OctLmg9LSsrjCoA55SVu/Ic8CRzAuHsFo4OpMYSTNDSPt3InCZ+A 6WLnYXUegmiWfgbBA9Mbn6n8mvLKYUPJTfeliDCQ6V1ctpoK4lfaxiJBD 5AEJ9lTiKKRku7j44I5yT50lzo6BUjXL4+Y1r6WuPS+RxIONN+18+y8Rg oneE73w76ZvEW7ov4ak0XSaCA23BiBK1GvsuFdM8KqisvW7uXhq2S7lrX P56omr26h5nkr5kN0z4088JSDga6Cmo4ZE9HH8wY9J5b0FCsbv5eooWa0 FN/cWzvMfKOsiz1OQxjUu3/EQJcGXPocrhWRyt+Czkqx9QseQJd/5Hqje w==; X-IronPort-AV: E=McAfee;i="6600,9927,10763"; a="394409432" X-IronPort-AV: E=Sophos;i="6.01,185,1684825200"; d="scan'208";a="394409432" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2023 09:21:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10763"; a="669789886" X-IronPort-AV: E=Sophos;i="6.01,185,1684825200"; d="scan'208";a="669789886" Received: from unknown (HELO silpixa00400883.ir.intel.com) ([10.243.22.155]) by orsmga003.jf.intel.com with ESMTP; 06 Jul 2023 09:21:23 -0700 From: Brian Dooley To: Kai Ji , Pablo de Lara Cc: dev@dpdk.org, gakhil@marvell.com, Brian Dooley , maxime.coquelin@redhat.com Subject: [PATCH v3 1/2] crypto/ipsec_mb: remove unused defines Date: Thu, 6 Jul 2023 16:21:16 +0000 Message-Id: <20230706162117.481960-2-brian.dooley@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230706162117.481960-1-brian.dooley@intel.com> References: <20230706160454.479229-1-brian.dooley@intel.com> <20230706162117.481960-1-brian.dooley@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org removed AESNI_MB_DOCSIS_SEC_ENABLED defines as they are no longer used. Fixes: 798f9d134519 ("crypto/ipsec_mb: remove security lib presence checks") Cc: maxime.coquelin@redhat.com Signed-off-by: Brian Dooley Reviewed-by: Maxime Coquelin --- drivers/crypto/ipsec_mb/ipsec_mb_private.c | 4 ---- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 22 ++------------------- drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 1 - 3 files changed, 2 insertions(+), 25 deletions(-) diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_private.c b/drivers/crypto/ipsec_mb/ipsec_mb_private.c index 64f2b4b604..f485d130b6 100644 --- a/drivers/crypto/ipsec_mb/ipsec_mb_private.c +++ b/drivers/crypto/ipsec_mb/ipsec_mb_private.c @@ -205,10 +205,6 @@ ipsec_mb_remove(struct rte_vdev_device *vdev) rte_free(cryptodev->security_ctx); cryptodev->security_ctx = NULL; } -#ifdef AESNI_MB_DOCSIS_SEC_ENABLED - rte_free(cryptodev->security_ctx); - cryptodev->security_ctx = NULL; -#endif for (qp_id = 0; qp_id < cryptodev->data->nb_queue_pairs; qp_id++) ipsec_mb_qp_release(cryptodev, qp_id); diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c index 7fcb8f99e0..9e298023d7 100644 --- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c +++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c @@ -851,7 +851,6 @@ aesni_mb_session_configure(IMB_MGR *mb_mgr, return 0; } -#ifdef AESNI_MB_DOCSIS_SEC_ENABLED /** Check DOCSIS security session configuration is valid */ static int check_docsis_sec_session(struct rte_security_session_conf *conf) @@ -988,7 +987,6 @@ aesni_mb_set_docsis_sec_session_parameters( free_mb_mgr(mb_mgr); return ret; } -#endif static inline uint64_t auth_start_offset(struct rte_crypto_op *op, struct aesni_mb_session *session, @@ -1762,7 +1760,6 @@ set_mb_job_params(IMB_JOB *job, struct ipsec_mb_qp *qp, return 0; } -#ifdef AESNI_MB_DOCSIS_SEC_ENABLED /** * Process a crypto operation containing a security op and complete a * IMB_JOB job structure for submission to the multi buffer library for @@ -1853,7 +1850,6 @@ verify_docsis_sec_crc(IMB_JOB *job, uint8_t *status) if (memcmp(job->auth_tag_output, crc, RTE_ETHER_CRC_LEN) != 0) *status = RTE_CRYPTO_OP_STATUS_AUTH_FAILED; } -#endif static inline void verify_digest(IMB_JOB *job, void *digest, uint16_t len, uint8_t *status) @@ -1921,8 +1917,6 @@ post_process_mb_job(struct ipsec_mb_qp *qp, IMB_JOB *job) struct aesni_mb_session *sess = NULL; uint8_t *linear_buf = NULL; int sgl = 0; - -#ifdef AESNI_MB_DOCSIS_SEC_ENABLED uint8_t is_docsis_sec = 0; if (op->sess_type == RTE_CRYPTO_OP_SECURITY_SESSION) { @@ -1933,7 +1927,6 @@ post_process_mb_job(struct ipsec_mb_qp *qp, IMB_JOB *job) is_docsis_sec = 1; sess = SECURITY_GET_SESS_PRIV(op->sym->session); } else -#endif sess = CRYPTODEV_GET_SYM_SESS_PRIV(op->sym->session); if (likely(op->status == RTE_CRYPTO_OP_STATUS_NOT_PROCESSED)) { @@ -1961,11 +1954,9 @@ post_process_mb_job(struct ipsec_mb_qp *qp, IMB_JOB *job) op->sym->aead.digest.data, sess->auth.req_digest_len, &op->status); -#ifdef AESNI_MB_DOCSIS_SEC_ENABLED else if (is_docsis_sec) verify_docsis_sec_crc(job, &op->status); -#endif else verify_digest(job, op->sym->auth.digest.data, @@ -2098,12 +2089,10 @@ aesni_mb_dequeue_burst(void *queue_pair, struct rte_crypto_op **ops, job = jobs[i]; op = deqd_ops[i]; -#ifdef AESNI_MB_DOCSIS_SEC_ENABLED if (op->sess_type == RTE_CRYPTO_OP_SECURITY_SESSION) retval = set_sec_mb_job_params(job, qp, op, &digest_idx); else -#endif retval = set_mb_job_params(job, qp, op, &digest_idx, mb_mgr); @@ -2259,12 +2248,10 @@ aesni_mb_dequeue_burst(void *queue_pair, struct rte_crypto_op **ops, if (retval < 0) break; -#ifdef AESNI_MB_DOCSIS_SEC_ENABLED if (op->sess_type == RTE_CRYPTO_OP_SECURITY_SESSION) retval = set_sec_mb_job_params(job, qp, op, &digest_idx); else -#endif retval = set_mb_job_params(job, qp, op, &digest_idx, mb_mgr); @@ -2440,7 +2427,6 @@ struct rte_cryptodev_ops aesni_mb_pmd_ops = { .sym_session_clear = ipsec_mb_sym_session_clear }; -#ifdef AESNI_MB_DOCSIS_SEC_ENABLED /** * Configure a aesni multi-buffer session from a security session * configuration @@ -2528,8 +2514,6 @@ aesni_mb_configure_dev(struct rte_cryptodev *dev) return -ENOMEM; } -#endif - static int aesni_mb_probe(struct rte_vdev_device *vdev) { @@ -2570,17 +2554,15 @@ RTE_INIT(ipsec_mb_register_aesni_mb) RTE_CRYPTODEV_FF_IN_PLACE_SGL | RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT | RTE_CRYPTODEV_FF_OOP_LB_IN_SGL_OUT | - RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT; + RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT | + RTE_CRYPTODEV_FF_SECURITY; aesni_mb_data->internals_priv_size = 0; aesni_mb_data->ops = &aesni_mb_pmd_ops; aesni_mb_data->qp_priv_size = sizeof(struct aesni_mb_qp_data); aesni_mb_data->queue_pair_configure = NULL; -#ifdef AESNI_MB_DOCSIS_SEC_ENABLED aesni_mb_data->security_ops = &aesni_mb_pmd_sec_ops; aesni_mb_data->dev_config = aesni_mb_configure_dev; - aesni_mb_data->feature_flags |= RTE_CRYPTODEV_FF_SECURITY; -#endif aesni_mb_data->session_configure = aesni_mb_session_configure; aesni_mb_data->session_priv_size = sizeof(struct aesni_mb_session); } diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h b/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h index 3f6cf30c39..85994fe5a1 100644 --- a/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h +++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h @@ -5,7 +5,6 @@ #ifndef _PMD_AESNI_MB_PRIV_H_ #define _PMD_AESNI_MB_PRIV_H_ -#define AESNI_MB_DOCSIS_SEC_ENABLED 1 #include #include #include From patchwork Thu Jul 6 16:21:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Dooley X-Patchwork-Id: 129349 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0E1742DEA; Thu, 6 Jul 2023 18:21:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CAACA42FE2; Thu, 6 Jul 2023 18:21:29 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id CFD3F42FC6 for ; Thu, 6 Jul 2023 18:21:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688660488; x=1720196488; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FlfW6lOrlC6LtvvmzW2OrgzdhVCqefRwax23qqGWuYM=; b=m0Ki1d9PLzwTGIGKUy1tMtNV/iINmNf+jfuMuRjYaBLFXRhlAu/7+V28 JNjXsy4ndxnMqDV/+lXiMDW4SuAgoP0mWGMboyMJ0B95ImYSeeHHLcIQh meDj55bV03khrOHbLfAfaxBfgG5HLPT+J0VFsmgfOnGSISt5n8djQpgyj 0snfFct+5jsB02pMxEB4YjtRI/jy9YOzFUkspJGmBWr1Uf14XGorSsD7T FlPbb9OLUjKNWkgM+RGhiXSHed21cc61g2QuaRI4wzyog2koWQTCTIoRe 74XUREJsTkU0fAdQ8OLndPN9/Oqy9FiWlhofeurhUbj1U/8h+7d8Fdv4b A==; X-IronPort-AV: E=McAfee;i="6600,9927,10763"; a="394409440" X-IronPort-AV: E=Sophos;i="6.01,185,1684825200"; d="scan'208";a="394409440" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2023 09:21:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10763"; a="669789890" X-IronPort-AV: E=Sophos;i="6.01,185,1684825200"; d="scan'208";a="669789890" Received: from unknown (HELO silpixa00400883.ir.intel.com) ([10.243.22.155]) by orsmga003.jf.intel.com with ESMTP; 06 Jul 2023 09:21:25 -0700 From: Brian Dooley To: Kai Ji Cc: dev@dpdk.org, gakhil@marvell.com, Brian Dooley , kevin.osullivan@intel.com Subject: [PATCH v3 2/2] common/qat: change define header Date: Thu, 6 Jul 2023 16:21:17 +0000 Message-Id: <20230706162117.481960-3-brian.dooley@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230706162117.481960-1-brian.dooley@intel.com> References: <20230706160454.479229-1-brian.dooley@intel.com> <20230706162117.481960-1-brian.dooley@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org change define from RTE_LIB_SECURITY to BUILD_QAT_SYM as RTE_ETHER_CRC_LEN value is protected by BUILD_QAT_SYM. Fixes: ce7a737c8f02 ("crypto/qat: support cipher-CRC offload") Cc: kevin.osullivan@intel.com Signed-off-by: Brian Dooley --- drivers/common/qat/qat_qp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c index 094d684abc..f284718441 100644 --- a/drivers/common/qat/qat_qp.c +++ b/drivers/common/qat/qat_qp.c @@ -11,7 +11,7 @@ #include #include #include -#ifdef RTE_LIB_SECURITY +#ifdef BUILD_QAT_SYM #include #endif