From patchwork Mon Aug 7 13:36:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomer Shmilovich X-Patchwork-Id: 129935 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D97B542FFE; Mon, 7 Aug 2023 15:37:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64D22410D3; Mon, 7 Aug 2023 15:37:04 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2049.outbound.protection.outlook.com [40.107.92.49]) by mails.dpdk.org (Postfix) with ESMTP id 4237540A8B for ; Mon, 7 Aug 2023 15:37:02 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NbLIeGW47oyHss4H/HUVk0kAytEotLunI5viHtlP0oL/JS6kIVKf4ZdNb3zJzlKd/kk5PYVFIS1XukCiEysLVBCeZI27WrJopvoJMFWJJAGKfP3xQ38Bj3sSyowt5SCCa0KkN/yqjNyHv6y7W3ixz4o1yuMtk1VLI+lkmLZUG/AMhvEV1YfLlQLXcwLkZlRwomVQK17cgwVypf6eZtZfXPDg33r5hkCUb9j834hMql9lq/gTrL4LESpXnxNwbIapJaKwJIfEtpZZsa/GpBuWaRGkhW8LnQgjQrWqw6WEYwQob/D+93fE6eXRMLr6xGPbYJ+bAkZEW3XI78dEqzZ+ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6bWF9xKIdiR0gBaNLLH2S3f9Q8Hz1+c+scdR5LRTQXA=; b=eP9k68I1x88YC1Xc2QmIfsGX/gjT6G3NuCL1uDCLVNNbsk0P5NRsXldZaAmDYaR1rzYjQnKjIjJ8Ot5CCy5F/Z5JDi/yndoCMu2siY2JL/FH0qrLRAUeCNNj5k02DiOHfPYV0Ff9lxBiGMOyeC4QJrPUYD2XvD66dX1XTO/dvXf5kQIK0EPslwjHfarF2cgUPlyeMrHoc/7QWztHH/J5Ux+JmTI7poHFHWQERvq5CPQNgr+QNzv4xJChf4i/HJnTIH8m1hB6atdXV8pk2gQ1cBVjYDgXDEKIJrt1Qfs5KMDRk3O+mqLNzm8JEg4MtVq+NLmqbOTAp+7nNuvfAnFV3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6bWF9xKIdiR0gBaNLLH2S3f9Q8Hz1+c+scdR5LRTQXA=; b=MnYeM47jjbsWOpN1FORW8IZz4Uimj0NyoeEFsnoHd8GzOkZigfcSeX4r9hemNZPc+v/MkxLdGTizJtXXG/mqAH++Lml6PAAF27vsnjGiu4qt30fl9HIAJIpa7BCK51e7+JTQrmvD6FqvEi2yY3J6MUwuBfpUZLjonC6gHwwU4Xi5GiBr8+N2a5fKqXOzETOeQsfEuzci2jRKasjFUxzqJoYAVNhNNp3MXZWui1sXVBsCPWAKHr5zsZLmiTO6S7Is+wN8ll6o4qWW/eBfUraIDCbuDDP76YMA1I0vLi+7581q5rlCHDGXAfzDD7S2L2BfElG76ERMrQJxV9ZIzSoy9Q== Received: from MW4PR04CA0362.namprd04.prod.outlook.com (2603:10b6:303:81::7) by DM4PR12MB6399.namprd12.prod.outlook.com (2603:10b6:8:b7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 13:36:57 +0000 Received: from MWH0EPF000971E2.namprd02.prod.outlook.com (2603:10b6:303:81:cafe::78) by MW4PR04CA0362.outlook.office365.com (2603:10b6:303:81::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27 via Frontend Transport; Mon, 7 Aug 2023 13:36:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by MWH0EPF000971E2.mail.protection.outlook.com (10.167.243.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20 via Frontend Transport; Mon, 7 Aug 2023 13:36:59 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 7 Aug 2023 06:36:31 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 7 Aug 2023 06:36:29 -0700 From: Tomer Shmilovich To: Ori Kam , Thomas Monjalon , "Ferruh Yigit" , Andrew Rybchenko CC: Subject: [RFC] ethdev: add group set miss actions API Date: Mon, 7 Aug 2023 13:36:01 +0000 Message-ID: <20230807133601.164018-1-tshmilovich@nvidia.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000971E2:EE_|DM4PR12MB6399:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d2fa523-4b81-469f-8ed9-08db974b6054 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: te+qDhjqaH5pkeFn8d6z5nVlODjtVjLPnBBXFhwRyOh9bqVJzn1N1RYyXbWs/dOogAHooHSgUYnLhWIbpP18n3rHhWvrpBXd4HgMKPNtql7FxtzUaVzE588xomG7XKoe0OZH1elac4xWFCcoIU8lRvvdSeLhnn5LPJXIdiCj0ztILTiC3Nl0bA1/cPYcXcSrWGLxnDvFx2izwPkofGFq9aaICD4E/1tHwS0pRPAYwvRihjrPN64HgMAWM38QB9BbCFu4TY4KNjxrkmLRMFnoLp9m3+I93dkupS2FAubBZQc79EQ816LDeKjvGAGF7+LoTMHkFSWVlOGw8eaHJ+eAdo9iFnU9kn3VpigJvfkOc3sXjoXDh8k4llYjj2o9mB4wvc6MH9VwtCW3Ss4loamfuDnKAqvj/8A7qTJW4se9WIBtZcFqagGtOzh08cuhY27iPJ8XBXxCIckom61W5ztmp8pMmkPPW6iKMXDg3AAkTpMOtju/amaEFpnFnRc34HGaOr6S+mSAI5e1vYAbSvGAd9Ol78iKUB2epcHt1cteLC5BtNesytc35W7lEAArAzIpeoyw7w/lNUIrz4xri6yxblO5z76smFsw8Rwg3Bm6FJXTAcb4gBqZDc6WUymL5kQFJp51Ojl3gOj41jZIXohTshfa7bvbue0gLO91S9LJ/MJlpINqu2YWWguRhS9MdyZ+m8U1VVx56t/8yUghvTimmJlTRGSUebR/vn8lfsjt61RTZZ9ifY/d94DlnYViBGSm X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(396003)(376002)(136003)(39860400002)(1800799003)(186006)(82310400008)(451199021)(46966006)(40470700004)(36840700001)(83380400001)(426003)(47076005)(36860700001)(2616005)(40460700003)(55016003)(40480700001)(110136005)(2906002)(4326008)(8936002)(316002)(5660300002)(8676002)(336012)(70586007)(70206006)(6286002)(16526019)(86362001)(478600001)(82740400003)(6666004)(7636003)(7696005)(356005)(41300700001)(36756003)(1076003)(26005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 13:36:59.6146 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3d2fa523-4b81-469f-8ed9-08db974b6054 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000971E2.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6399 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Introduce new group set miss actions API: rte_flow_group_set_miss_actions(). A group's miss actions are a set of actions to be performed in case of a miss on a group, i.e. when a packet didn't hit any flow rules in the group. Currently, the expected behavior in this case is undefined. In order to achieve such functionality, a user can add a flow rule that matches on all traffic with the lowest priority in the group - this is not explicit however, and can be overridden by another flow rule with a lower priority. This new API function allows a user to set a group's miss actions in an explicit way. Signed-off-by: Tomer Shmilovich --- doc/guides/prog_guide/rte_flow.rst | 30 +++++++++++++++++++++++++ lib/ethdev/rte_flow.c | 22 +++++++++++++++++++ lib/ethdev/rte_flow.h | 35 ++++++++++++++++++++++++++++++ lib/ethdev/rte_flow_driver.h | 7 ++++++ lib/ethdev/version.map | 3 +++ 5 files changed, 97 insertions(+) diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index 5bc998a433..590d2a770e 100644 --- a/doc/guides/prog_guide/rte_flow.rst +++ b/doc/guides/prog_guide/rte_flow.rst @@ -3758,6 +3758,36 @@ Information about the number of available resources can be retrieved via struct rte_flow_queue_info *queue_info, struct rte_flow_error *error); +Group Miss Actions +~~~~~~~~~~~~~~~~~~ + +In an application, many flow rules share common group attributes, meaning they can be grouped and +classified together. A user can explicitly specify a set of actions performed on a packet when it +did not match any flows rules in a group using the following API: + +.. code-block:: c + + int + rte_flow_group_set_miss_actions(uint16_t port_id, + uint32_t group_id, + const struct rte_flow_group_attr *attr, + const struct rte_flow_action actions[], + struct rte_flow_error *error); + +For example, to configure a RTE_FLOW_TYPE_JUMP action as a miss action for ingress group 1: + +.. code-block:: c + + struct rte_flow_group_attr attr = {.ingress = 1}; + struct rte_flow_action act[] = { + /* Setting miss actions to jump to group 3 */ + [0] = {.type = RTE_FLOW_ACTION_TYPE_JUMP, + .conf = &(struct rte_flow_action_jump){.group = 3}}, + [1] = {.type = RTE_FLOW_ACTION_TYPE_END}, + }; + struct rte_flow_error err; + rte_flow_group_set_miss_actions(port, 1, &attr, act, &err); + Flow templates ~~~~~~~~~~~~~~ diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c index 271d854f78..a98d87265f 100644 --- a/lib/ethdev/rte_flow.c +++ b/lib/ethdev/rte_flow.c @@ -1973,6 +1973,28 @@ rte_flow_template_table_destroy(uint16_t port_id, NULL, rte_strerror(ENOTSUP)); } +int +rte_flow_group_set_miss_actions(uint16_t port_id, + uint32_t group_id, + const struct rte_flow_group_attr *attr, + const struct rte_flow_action actions[], + struct rte_flow_error *error) +{ + struct rte_eth_dev *dev = &rte_eth_devices[port_id]; + const struct rte_flow_ops *ops = rte_flow_ops_get(port_id, error); + + if (unlikely(!ops)) + return -rte_errno; + if (likely(!!ops->group_set_miss_actions)) { + return flow_err(port_id, + ops->group_set_miss_actions(dev, group_id, attr, actions, error), + error); + } + return rte_flow_error_set(error, ENOTSUP, + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, + NULL, rte_strerror(ENOTSUP)); +} + struct rte_flow * rte_flow_async_create(uint16_t port_id, uint32_t queue_id, diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index 86ed98c562..2d4fd49eb7 100644 --- a/lib/ethdev/rte_flow.h +++ b/lib/ethdev/rte_flow.h @@ -129,6 +129,12 @@ struct rte_flow_attr { uint32_t reserved:29; /**< Reserved, must be zero. */ }; +struct rte_flow_group_attr { + uint32_t ingress:1; + uint32_t egress:1; + uint32_t transfer:1; +}; + /** * Matching pattern item types. * @@ -5839,6 +5845,35 @@ rte_flow_template_table_destroy(uint16_t port_id, struct rte_flow_template_table *template_table, struct rte_flow_error *error); +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Set group miss actions. + * + * @param port_id + * Port identifier of Ethernet device. + * @param group_id + * Identifier of a group to set miss actions for. + * @param attr + * Group attributes. + * @param actions + * List of group miss actions. + * @param[out] error + * Perform verbose error reporting if not NULL. + * PMDs initialize this structure in case of error only. + * + * @return + * 0 on success, a negative errno value otherwise and rte_errno is set. + */ +__rte_experimental +int +rte_flow_group_set_miss_actions(uint16_t port_id, + uint32_t group_id, + const struct rte_flow_group_attr *attr, + const struct rte_flow_action actions[], + struct rte_flow_error *error); + /** * @warning * @b EXPERIMENTAL: this API may change without prior notice. diff --git a/lib/ethdev/rte_flow_driver.h b/lib/ethdev/rte_flow_driver.h index f9fb01b8a2..3ced086c47 100644 --- a/lib/ethdev/rte_flow_driver.h +++ b/lib/ethdev/rte_flow_driver.h @@ -227,6 +227,13 @@ struct rte_flow_ops { (struct rte_eth_dev *dev, struct rte_flow_template_table *template_table, struct rte_flow_error *err); + /** See rte_flow_group_set_miss_actions() */ + int (*group_set_miss_actions) + (struct rte_eth_dev *dev, + uint32_t group_id, + const struct rte_flow_group_attr *attr, + const struct rte_flow_action actions[], + struct rte_flow_error *err); /** See rte_flow_async_create() */ struct rte_flow *(*async_create) (struct rte_eth_dev *dev, diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map index fc492ee839..bdd41ecb5e 100644 --- a/lib/ethdev/version.map +++ b/lib/ethdev/version.map @@ -312,6 +312,9 @@ EXPERIMENTAL { rte_flow_async_action_list_handle_query_update; rte_flow_async_actions_update; rte_flow_restore_info_dynflag; + + # added in 23.11 + rte_flow_group_set_miss_actions; }; INTERNAL {