From patchwork Wed Aug 9 05:38:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jhascoet X-Patchwork-Id: 130038 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08C3342FBE; Wed, 9 Aug 2023 11:07:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D510943259; Wed, 9 Aug 2023 11:07:25 +0200 (CEST) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by mails.dpdk.org (Postfix) with ESMTP id C3D2B400D6 for ; Wed, 9 Aug 2023 07:39:18 +0200 (CEST) Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5231f439968so6823103a12.0 for ; Tue, 08 Aug 2023 22:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691559558; x=1692164358; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=82Weh1aOmyZ1VZC8wr3Apn8Fcn/Alqk+KmDWQV0boCM=; b=Xs5NLAHS8DzAXj3kZhBID9w9dPjwGro4iLWWcOu52RJDtfoe4Bvw9lCeU+HSHapdiA iSs9x3Qaef//jnA0dALx8qNXeQGQRTE2yzXnfg4esafoXhFH3JhSwE1pCndlvhA9RX9b MQbEGrWN51AmazG0rautBdS8KIYn18ctgZGdUC2tqmwgVNet9QUp1RWpFHpfCwNynJPQ +pE6zjKgb4IMJFu3LBkmN6p94HLWmaYAkbb9RQrOGbqmhckEOWgU2UtCbjziF1t0bg4R LpbWXKIR5FT+uMQdzPEMPq0p4VdqmpqGgU5r6NJ19FBg86ypb0oio2/rL+bz9+1P2GrQ Wc7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691559558; x=1692164358; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=82Weh1aOmyZ1VZC8wr3Apn8Fcn/Alqk+KmDWQV0boCM=; b=kCaEq4CdWY1tgf/eBEPm5QRGRVQECfDLZVzKDTDmNJursTEumLOK26GFGqkeWiOkTd /vB4jU88JH2m/UL2DuGnfPuSn353xv741cndA4O4uMQrj/tp94bf6wCDyonR6qzRiCiX orleXzueGKiMYS6lUz6NocHnJM2JZE6jaLQDrDcHF8q6vmXI7azelLCrOGrdluo752au wEo8RFxzMxlDM710NvldVAoZEHXurvmW5ApQnbQ6xin5EUHXK8Ej18fH2+RbEhWVHfZ9 VMzzsK+6MdSHFZxEnWlW5sbDzINwqPO70rhLK1EZiqV/btUSiXfyp1SXI40IkDnOsaz9 n0oA== X-Gm-Message-State: AOJu0Yx6Xkg293zcQPs6jK+0KFcNLtn6Odd1IXSqOC6/j42Wbn6JjRCK mFe8RGL3+S+LF0wqIUevzUA= X-Google-Smtp-Source: AGHT+IHa5H/oGxuqEkV0dRYoQnhjlqyrycN7abRjHoMDFJ0DrU+3puU1SHWUzKDTqR+piO4neFmlMg== X-Received: by 2002:aa7:d754:0:b0:523:2da2:1ec4 with SMTP id a20-20020aa7d754000000b005232da21ec4mr1649132eds.11.1691559558122; Tue, 08 Aug 2023 22:39:18 -0700 (PDT) Received: from coolup54.lin.mbt.kalray.eu ([217.181.231.53]) by smtp.gmail.com with ESMTPSA id t18-20020aa7d712000000b0051e0be09297sm7566700edq.53.2023.08.08.22.39.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 22:39:17 -0700 (PDT) From: jhascoet X-Google-Original-From: jhascoet To: david.marchand@redhat.com Cc: dev@dpdk.org, jhascoet , Julien Hascoet Subject: [PATCH] app: fix silent enqueue fail in test_mbuf test_refcnt_iter Date: Wed, 9 Aug 2023 07:38:43 +0200 Message-Id: <20230809053843.3698537-1-jhascoet@kalray.eu> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 09 Aug 2023 11:07:23 +0200 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In case of ring full state, we retry the enqueue operation in order to avoid mbuf loss. Fixes: af75078fece ("first public release") Signed-off-by: Julien Hascoet --- app/test/test_mbuf.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index efac01806b..be114e3302 100644 --- a/app/test/test_mbuf.c +++ b/app/test/test_mbuf.c @@ -1033,12 +1033,17 @@ test_refcnt_iter(unsigned int lcore, unsigned int iter, tref += ref; if ((ref & 1) != 0) { rte_pktmbuf_refcnt_update(m, ref); - while (ref-- != 0) - rte_ring_enqueue(refcnt_mbuf_ring, m); + while (ref-- != 0) { + /* retry in case of failure */ + while (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0) + ; + } } else { while (ref-- != 0) { rte_pktmbuf_refcnt_update(m, 1); - rte_ring_enqueue(refcnt_mbuf_ring, m); + /* retry in case of failure */ + while (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0) + ; } } rte_pktmbuf_free(m);