From patchwork Thu Aug 10 15:39:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jhascoet X-Patchwork-Id: 130266 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B85DA43063; Mon, 14 Aug 2023 16:07:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5AF9640A7F; Mon, 14 Aug 2023 16:07:37 +0200 (CEST) Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by mails.dpdk.org (Postfix) with ESMTP id C086940691 for ; Thu, 10 Aug 2023 17:39:54 +0200 (CEST) Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-9923833737eso148410466b.3 for ; Thu, 10 Aug 2023 08:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691681994; x=1692286794; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=d9Q09I0LtHFmXf2vFpeusB0iurOxqBmRKJhdrl0c+rk=; b=CMT09z2wSJbaUQlgv8PxsInmKvZsflUZV3P4B/lNrmQKFjq4XvkUk5RLPzfaN3SJRd 68DnLNwaw0efc4SkQxQduh08HO/uNCHoY/AwUDd5JagI7WWLkocHv8VpHL5pLviGfamP SIPVJ9N25fMIjYIpSzmyJQHcYFlUYnCZRkDjErA7yeSl9v3/JnmojbXNUTPk2wJDEVZ3 GoO7wslZXuRTBVTUXUizNLh+zmuA10Cxs95rKsilIbFXb6fVedGxjn4e9s+txg7AmJfi wm0MHzuTcqijrrl/mRuy+S1WJxXsa+70obq20iOmCyazhSfrIsUQa/KuBVj3X2nJVxpq 4/rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691681994; x=1692286794; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d9Q09I0LtHFmXf2vFpeusB0iurOxqBmRKJhdrl0c+rk=; b=ZShICU4KVa6j8VnJYIu/dT/TpSOYgDzmuukFWD+Ice4A7PuCc+DKZROuRApDiqlEcy OcwNruTu369V9xA3Dk0NZTpk10a1BEPAdNuP9c7zSON0+fF8OI1n5GRr8pOil5YNV8L1 9voLYwrucxVY9XF4ER9Uypza9qiDR9HSgrimg5qzQ5bas96VO4DK1C9ze2XOp/r6p4lN 5fQ1IdryqVLOGAsehNBYWbU2DnwwB839NVJK5GzVET+jdjwyl0UYMTrqHBYMxrd9PEwb Xdn+pAPPLfsjftD+lrYmhThLg10et1DY7cWhxKJ7KqiR/NjgjnIH5XMrQgWMfLlwOOmf krvg== X-Gm-Message-State: AOJu0Yym4rtNkFnKlKvVAlhoPwKHZzpe1mTuBi4s0FUsSvDZmndqrVSl bewNo8SThpMZOuNrg+hPr0c= X-Google-Smtp-Source: AGHT+IGEnKhJe4wjJitnjzvNwfwOY53ozsTSuwU+75jV30Cu0KdLSsThuvi74WdYkvNt0EQ6VJRbqg== X-Received: by 2002:a17:907:760d:b0:992:13c7:563 with SMTP id jx13-20020a170907760d00b0099213c70563mr2306355ejc.75.1691681994063; Thu, 10 Aug 2023 08:39:54 -0700 (PDT) Received: from coolup54.lin.mbt.kalray.eu ([217.181.231.53]) by smtp.gmail.com with ESMTPSA id kd7-20020a17090798c700b0099ba3438554sm1084778ejc.191.2023.08.10.08.39.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 08:39:53 -0700 (PDT) From: jhascoet X-Google-Original-From: jhascoet To: david.marchand@redhat.com Cc: dev@dpdk.org, Julien Hascoet Subject: [PATCH] app: fix silent enqueue fail in test_mbuf test_refcnt_iter Date: Thu, 10 Aug 2023 17:39:51 +0200 Message-Id: <20230810153951.3889409-1-jhascoet@kalray.eu> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 14 Aug 2023 16:07:37 +0200 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Julien Hascoet In case of ring full state, we retry the enqueue operation in order to avoid mbuf loss. Fixes: af75078fece ("first public release") Signed-off-by: Julien Hascoet --- app/test/test_mbuf.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index efac01806b..be114e3302 100644 --- a/app/test/test_mbuf.c +++ b/app/test/test_mbuf.c @@ -1033,12 +1033,17 @@ test_refcnt_iter(unsigned int lcore, unsigned int iter, tref += ref; if ((ref & 1) != 0) { rte_pktmbuf_refcnt_update(m, ref); - while (ref-- != 0) - rte_ring_enqueue(refcnt_mbuf_ring, m); + while (ref-- != 0) { + /* retry in case of failure */ + while (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0) + ; + } } else { while (ref-- != 0) { rte_pktmbuf_refcnt_update(m, 1); - rte_ring_enqueue(refcnt_mbuf_ring, m); + /* retry in case of failure */ + while (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0) + ; } } rte_pktmbuf_free(m);