From patchwork Tue Aug 22 06:34:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jhascoet X-Patchwork-Id: 130629 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD3EE430CE; Tue, 22 Aug 2023 10:12:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5489B4021D; Tue, 22 Aug 2023 10:12:21 +0200 (CEST) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by mails.dpdk.org (Postfix) with ESMTP id 7D82540041; Tue, 22 Aug 2023 08:35:32 +0200 (CEST) Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-51e28cac164so10631916a12.1; Mon, 21 Aug 2023 23:35:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692686132; x=1693290932; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vNUJtctEe9Fb/DWhLDmJ4i4ahTOndz0EhBeq9LlgZk0=; b=XXIbNrSm4JTvw+T36wJz/PUnS44j95Pti5yTwseWstpxOqDArvPFkRgRUYAaa50fna pH3SWSE0LIydI1her9L5XQsmzI0RZe7smukwrxTdfxeVpx+ZIgD5wHSzrOpb4GR8OXvK oyeCgKTVWn+g92p49NiOj8tJLjssw2geCqJYvwWNc/tGRx6Fx8HMlVs4b3LVNJdMY7ZZ z8P3vIbwrZGelNMeLKdq87ncYPiqJcXwgIC7Ghg8hUmqypskxGvhQuCorrc82RdNHyfH 2Bx2mwebVTaKTLHcO081CPMPEdCU+80n0ijnk5s58itlVVqkqrywimrtoCnz8jxwM8DV PoQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692686132; x=1693290932; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vNUJtctEe9Fb/DWhLDmJ4i4ahTOndz0EhBeq9LlgZk0=; b=CkKXgAGU7CjIBrRqURlebRQ1dA6lKOImr47JLYYm/eu3kFBz6HLaMYBvIp1/DvvsG+ rZZTo63euxUhk2oQOvfjkFSelHLvddN+QHthrDKH42bkMTmQfc1Mpel48+GMce9wyJUV WOOTcDsYpQ8Dcswv6AW291NBBpzSI4v5da4E7mHhONE51IC9DN4Loj1q/VvkT4yMfIBk tiAvSemfRRfPCKxGreNkQuVlIJBmYCLLD4i8TW7HmvMrjHOcrYJgSquaEbeqdyzSuDlX QDxOTlxHawsJHsQ2Zbr90NadhclzDzmjFoOZuSZ57xVyzjBfFs8s4zqQ1eQd2mqjySvK ntEw== X-Gm-Message-State: AOJu0YxUkNn5V7b4wXVExSmNcnX1piXK4Qc1vgK/atQAEOp8PV+0Cf3a bI9MeOk9KvnWIALCiv2uwRgYdEzprkredQ== X-Google-Smtp-Source: AGHT+IFZSvsieFJfjpyYneTKtD8sgmWPPIY1wnFhRtBoxhuzVxL7QBXGw8oxN+V9wRdWuItAhRz0rQ== X-Received: by 2002:a17:906:7693:b0:99b:cb59:79b3 with SMTP id o19-20020a170906769300b0099bcb5979b3mr9878744ejm.1.1692686131819; Mon, 21 Aug 2023 23:35:31 -0700 (PDT) Received: from coolup54.lin.mbt.kalray.eu ([217.181.231.53]) by smtp.gmail.com with ESMTPSA id y6-20020a170906470600b0099364d9f0e9sm7666296ejq.102.2023.08.21.23.35.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Aug 2023 23:35:31 -0700 (PDT) From: jhascoet X-Google-Original-From: jhascoet To: olivier.matz@6wind.com Cc: dev@dpdk.org, maintainers@dpdk.org, Julien Hascoet Subject: [PATCH] app: fix silent enqueue fail in test_mbuf test_refcnt_iter Date: Tue, 22 Aug 2023 08:34:53 +0200 Message-Id: <20230822063453.97904-1-jhascoet@kalray.eu> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230810160941.3895855-1-jhascoet@kalray.eu> References: <20230810160941.3895855-1-jhascoet@kalray.eu> MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 22 Aug 2023 10:12:20 +0200 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Julien Hascoet In case of ring full state, we retry the enqueue operation in order to avoid mbuf loss. Fixes: af75078fece ("first public release") Signed-off-by: Julien Hascoet --- app/test/test_mbuf.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index efac01806b..ad18bf6378 100644 --- a/app/test/test_mbuf.c +++ b/app/test/test_mbuf.c @@ -1033,12 +1033,21 @@ test_refcnt_iter(unsigned int lcore, unsigned int iter, tref += ref; if ((ref & 1) != 0) { rte_pktmbuf_refcnt_update(m, ref); - while (ref-- != 0) - rte_ring_enqueue(refcnt_mbuf_ring, m); + while (ref-- != 0) { + /* retry in case of failure */ + while (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0) { + /* let others consume */ + rte_pause(); + } + } } else { while (ref-- != 0) { rte_pktmbuf_refcnt_update(m, 1); - rte_ring_enqueue(refcnt_mbuf_ring, m); + /* retry in case of failure */ + while (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0) { + /* let others consume */ + rte_pause(); + } } } rte_pktmbuf_free(m);