From patchwork Wed Oct 25 15:13:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 133311 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A807F431A1; Wed, 25 Oct 2023 17:15:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3755B402B3; Wed, 25 Oct 2023 17:15:45 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id C6DA740273; Wed, 25 Oct 2023 17:15:43 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 781303200930; Wed, 25 Oct 2023 11:15:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 25 Oct 2023 11:15:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1698246939; x=1698333339; bh=S4kRson5HXs6sIhZd0X1HLAXfzwJMSX5kz8 QR/CY2J4=; b=OXqHlzwQ1R0JXW+X2SnP23FMBDseZXXLAYXOG6796P+yhPV++da E9Fxg/1szLMeczWyrI6cAOOPoyVMmipTWU+8LRW6IISfu6tpek+wHQmnakjd/TdN y97gc1f832xBWPcMki8su04FNKBhKLcKqbRnFNcNmFclDjNdw1TSMZQ5zW2k2U/B 6FPzmVIXEdJxga/xTRyJvvBnKgWVg22hZVdRM6w6cDI5orCOGYena7K2O61AHlNN PR416IHeVuFRraxB+pfj6zMsWDmIiwTQhyOBHuEr0UXHA3IyBwL+3GTburt+Y5XF qy3azOBJeVAuhOJWhtO44FGoRd7icGbbrUQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1698246939; x=1698333339; bh=S4kRson5HXs6sIhZd0X1HLAXfzwJMSX5kz8 QR/CY2J4=; b=J5k6r4W0xnwgWopk2REyabSSOkDk1/VWhMOM09dc7WBmYHHnnP0 DvWfgLQ9TJurSMeSu5b5Ev08UFi91UEvT4IwT+6w20Fidndm/JOYumedwzJ+sLh0 WmB3VbMoAcTs7nsv+WybZ2jQe86iFpmLpGNeR0XGV91/ub+xqDd6S/utlrsiaKeM YOqUFpSpH1xkzzZskwHGOY19nZjtAo7qH9nwMbi1D2PZy7HaAWyLk1K3whdeSzLI LM/yS9WyFXQWuTKO2doBJ/7qTCEB8lhb9r0GMzxvUVO97sne02S4bp9FscPYD9Zj bjKlKNoe4JC0ckEsXUi4/7ghSi6+Ayrkb4A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrledtgdekgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffojghfgggtgfesthekredtredtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtieffffegfeetlefhkeeuteeuudffjefgleevtdeijedukefg veehteehheegjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 Oct 2023 11:15:36 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: David Marchand , stable@dpdk.org, =?utf-8?q?M?= =?utf-8?q?orten_Br=C3=B8rup?= , Anatoly Burakov , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Stephen Hemminger , Tyler Retzlaff , Andrew Rybchenko , Konstantin Ananyev Subject: [PATCH v2] eal/unix: allow creating thread with real-time priority Date: Wed, 25 Oct 2023 17:13:14 +0200 Message-ID: <20231025151352.995318-1-thomas@monjalon.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231024125416.798897-1-thomas@monjalon.net> References: <20231024125416.798897-1-thomas@monjalon.net> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When adding an API for creating threads, the real-time priority has been forbidden on Unix. There is a known issue with ring behaviour, but it should not be completely forbidden. Real-time thread can block some kernel threads on the same core, making the system unstable. That's why a pause is added in the test thread. This pause is a new API function rte_thread_yield(), compatible with both Unix and Windows. Fixes: ca04c78b6262 ("eal: get/set thread priority per thread identifier") Fixes: ce6e911d20f6 ("eal: add thread lifetime API") Fixes: a7ba40b2b1bf ("drivers: convert to internal control threads") Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon Acked-by: Morten Brørup --- app/test/test_threads.c | 11 +--------- .../prog_guide/env_abstraction_layer.rst | 4 +++- lib/eal/include/rte_thread.h | 13 ++++++++++-- lib/eal/unix/rte_thread.c | 21 +++++++++++-------- lib/eal/version.map | 3 +++ lib/eal/windows/rte_thread.c | 6 ++++++ 6 files changed, 36 insertions(+), 22 deletions(-) diff --git a/app/test/test_threads.c b/app/test/test_threads.c index 4ac3f2671a..9a449ba9c5 100644 --- a/app/test/test_threads.c +++ b/app/test/test_threads.c @@ -22,7 +22,7 @@ thread_main(void *arg) __atomic_store_n(&thread_id_ready, 1, __ATOMIC_RELEASE); while (__atomic_load_n(&thread_id_ready, __ATOMIC_ACQUIRE) == 1) - ; + rte_thread_yield(); /* required in case of real-time priority */ return 0; } @@ -97,21 +97,12 @@ test_thread_priority(void) "Priority set mismatches priority get"); priority = RTE_THREAD_PRIORITY_REALTIME_CRITICAL; -#ifndef RTE_EXEC_ENV_WINDOWS - RTE_TEST_ASSERT(rte_thread_set_priority(thread_id, priority) == ENOTSUP, - "Priority set to critical should fail"); - RTE_TEST_ASSERT(rte_thread_get_priority(thread_id, &priority) == 0, - "Failed to get thread priority"); - RTE_TEST_ASSERT(priority == RTE_THREAD_PRIORITY_NORMAL, - "Failed set to critical should have retained normal"); -#else RTE_TEST_ASSERT(rte_thread_set_priority(thread_id, priority) == 0, "Priority set to critical should succeed"); RTE_TEST_ASSERT(rte_thread_get_priority(thread_id, &priority) == 0, "Failed to get thread priority"); RTE_TEST_ASSERT(priority == RTE_THREAD_PRIORITY_REALTIME_CRITICAL, "Priority set mismatches priority get"); -#endif priority = RTE_THREAD_PRIORITY_NORMAL; RTE_TEST_ASSERT(rte_thread_set_priority(thread_id, priority) == 0, diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst b/doc/guides/prog_guide/env_abstraction_layer.rst index 6debf54efb..d1f7cae7cd 100644 --- a/doc/guides/prog_guide/env_abstraction_layer.rst +++ b/doc/guides/prog_guide/env_abstraction_layer.rst @@ -815,7 +815,9 @@ Known Issues 4. It MAY be used by preemptible multi-producer and/or preemptible multi-consumer pthreads whose scheduling policy are all SCHED_OTHER(cfs), SCHED_IDLE or SCHED_BATCH. User SHOULD be aware of the performance penalty before using it. - 5. It MUST not be used by multi-producer/consumer pthreads, whose scheduling policies are SCHED_FIFO or SCHED_RR. + 5. It MUST not be used by multi-producer/consumer pthreads + whose scheduling policies are ``SCHED_FIFO`` + or ``SCHED_RR`` (``RTE_THREAD_PRIORITY_REALTIME_CRITICAL``). Alternatively, applications can use the lock-free stack mempool handler. When considering this handler, note that: diff --git a/lib/eal/include/rte_thread.h b/lib/eal/include/rte_thread.h index 8da9d4d3fb..eeccc40532 100644 --- a/lib/eal/include/rte_thread.h +++ b/lib/eal/include/rte_thread.h @@ -56,10 +56,11 @@ typedef uint32_t (*rte_thread_func) (void *arg); * Thread priority values. */ enum rte_thread_priority { + /** Normal thread priority, the default. */ RTE_THREAD_PRIORITY_NORMAL = 0, - /**< normal thread priority, the default */ + /** Highest thread priority, use with caution. + * WARNING: System may be unstable because of a real-time busy loop. */ RTE_THREAD_PRIORITY_REALTIME_CRITICAL = 1, - /**< highest thread priority allowed */ }; /** @@ -183,6 +184,14 @@ int rte_thread_join(rte_thread_t thread_id, uint32_t *value_ptr); */ int rte_thread_detach(rte_thread_t thread_id); +/** + * Allow another thread to run on the same CPU core. + * + * Especially useful in real-time thread priority. + * @see RTE_THREAD_PRIORITY_REALTIME_CRITICAL + */ +void rte_thread_yield(void); + /** * Get the id of the calling thread. * diff --git a/lib/eal/unix/rte_thread.c b/lib/eal/unix/rte_thread.c index 36a21ab2f9..399acf2fa0 100644 --- a/lib/eal/unix/rte_thread.c +++ b/lib/eal/unix/rte_thread.c @@ -5,6 +5,7 @@ #include #include +#include #include #include #include @@ -49,6 +50,11 @@ thread_map_priority_to_os_value(enum rte_thread_priority eal_pri, int *os_pri, sched_get_priority_max(SCHED_OTHER)) / 2; break; case RTE_THREAD_PRIORITY_REALTIME_CRITICAL: + /* + * WARNING: Real-time busy loop takes priority on kernel threads, + * making the system unstable. + * There is also a known issue when using rte_ring. + */ *pol = SCHED_RR; *os_pri = sched_get_priority_max(SCHED_RR); break; @@ -153,11 +159,6 @@ rte_thread_create(rte_thread_t *thread_id, goto cleanup; } - if (thread_attr->priority == - RTE_THREAD_PRIORITY_REALTIME_CRITICAL) { - ret = ENOTSUP; - goto cleanup; - } ret = thread_map_priority_to_os_value(thread_attr->priority, ¶m.sched_priority, &policy); if (ret != 0) @@ -227,6 +228,12 @@ rte_thread_detach(rte_thread_t thread_id) return pthread_detach((pthread_t)thread_id.opaque_id); } +void +rte_thread_yield(void) +{ + sched_yield(); +} + int rte_thread_equal(rte_thread_t t1, rte_thread_t t2) { @@ -275,10 +282,6 @@ rte_thread_set_priority(rte_thread_t thread_id, int policy; int ret; - /* Realtime priority can cause crashes on non-Windows platforms. */ - if (priority == RTE_THREAD_PRIORITY_REALTIME_CRITICAL) - return ENOTSUP; - ret = thread_map_priority_to_os_value(priority, ¶m.sched_priority, &policy); if (ret != 0) diff --git a/lib/eal/version.map b/lib/eal/version.map index e00a844805..0b4a503c5f 100644 --- a/lib/eal/version.map +++ b/lib/eal/version.map @@ -413,6 +413,9 @@ EXPERIMENTAL { # added in 23.07 rte_memzone_max_get; rte_memzone_max_set; + + # added in 23.11 + rte_thread_yield; }; INTERNAL { diff --git a/lib/eal/windows/rte_thread.c b/lib/eal/windows/rte_thread.c index acf648456c..b0373b1a55 100644 --- a/lib/eal/windows/rte_thread.c +++ b/lib/eal/windows/rte_thread.c @@ -304,6 +304,12 @@ rte_thread_detach(rte_thread_t thread_id) return 0; } +void +rte_thread_yield(void) +{ + Sleep(0); +} + int rte_thread_equal(rte_thread_t t1, rte_thread_t t2) {