From patchwork Mon Dec 18 07:49:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sivaprasad Tummala X-Patchwork-Id: 135244 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF1FD4372C; Mon, 18 Dec 2023 08:49:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77F1540276; Mon, 18 Dec 2023 08:49:24 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2081.outbound.protection.outlook.com [40.107.244.81]) by mails.dpdk.org (Postfix) with ESMTP id AEA954026A; Mon, 18 Dec 2023 08:49:22 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PVpuJeajfPKt/3EOeBMPeX/A0WL3Mjci3Yw8a6q5aofsOdoEjxXjxF0y18JUSdXDBKs0XhwntG1oUMn8xhoblbIE3Fwy4Hh68eTyj3L8iR5EONFHEic9PL1I2+JJ9X5TYVZkaz7h7egxhjdhUcOcE50rILpmXxg+wLaIWa/x0N48YECDGFfCPYNXZgsiO8BJ5n+JJ5CIA/ZE1tdktUpjd6kqTVXx+lD7CgpjuiqDAg4BxnsR65pM1j0gFHC5AVamkEyFocwhTyJve0FFxubTVWmVLetwiBpzC4I8bdWD6NsEAnQHz+MYiTCsE14+5Nw377/uon0RlysGj5xee3RA3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MM/KSMQrM10AAC4oFE2CJUjiDFsvQhkpubTGvhn6Gpo=; b=V3+U65SV912SPwSLNT7e/sGoMCqLE9BQWPz2wlbqHrBCO9ARhxBcNmXgUximXINugRbYkHY96LvAMSpS5mCr2d3I1NXeszpb1YO3/8SZvVkL2zMa1VOhwbCK4U61GsRXGLVEyEAHXi6R8cqZe+PQUwnRh8/SGypPXvcL/peytNyY8Maa0bW4dADEnd39lPU05BkTzuwJjKq+U0PLlN8nug9jK2sPxlshWxGGEGeOssZX/g8zQTb8LaIHPe+Y+073/ti8swowEk9z6cYP0+2OpjMLj6IR3VwEGa0pY2hwNiNOGTTppnkX7WKRwovJgtLQYIFRRplBG6tj+evPJQhDgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MM/KSMQrM10AAC4oFE2CJUjiDFsvQhkpubTGvhn6Gpo=; b=Gl3BeTs4Z5tRESZYDXHqgWBI4AhsyfU51pvLnlDyV/12/lfovMI28OMEwyA6qgXSD+YX7utF3KZtFqENC84kbP/6M1SnQF6HgqRUyWrE04oBDF2WHDwrs4u5JBh9SbJmcwToCqybZsbt3PYo5UuzUQ/qDJ+wB3qt0toWC1fzuTw= Received: from MW2PR16CA0023.namprd16.prod.outlook.com (2603:10b6:907::36) by MN2PR12MB4552.namprd12.prod.outlook.com (2603:10b6:208:24f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38; Mon, 18 Dec 2023 07:49:19 +0000 Received: from MWH0EPF000989EB.namprd02.prod.outlook.com (2603:10b6:907:0:cafe::3f) by MW2PR16CA0023.outlook.office365.com (2603:10b6:907::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37 via Frontend Transport; Mon, 18 Dec 2023 07:49:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000989EB.mail.protection.outlook.com (10.167.241.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Mon, 18 Dec 2023 07:49:19 +0000 Received: from 7dbylenovo.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 01:49:17 -0600 From: Sivaprasad Tummala To: , , , , , , , CC: , Subject: [PATCH 1/6] examples/l3fwd: fix lcore ID restriction Date: Mon, 18 Dec 2023 07:49:00 +0000 Message-ID: <20231218074905.42749-1-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989EB:EE_|MN2PR12MB4552:EE_ X-MS-Office365-Filtering-Correlation-Id: 90c661b1-8210-4deb-1139-08dbff9dd79a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JIdKBOkmv02W0l4pDXHp1URplzsfF8z8pNztwu/FRxoDDAgwrVg9J62SMUXuejpwjImZ6ZUeYO/wtiihnh9LhS8fuXKjzl1jru1y3SoCyQoSiqPQbbz4+350L9hkEycoUSomGhjSZeHm+w5Yov7tCH5tjxKH4h2LSFkc9YEvr1tj0pbKaRezbC+mf0l6cQaPEOU3PjY9nVefBOnKtiRa88dv+XQuXWD+R0eB1YDejEdH8l9XPUNsSK3HtQlpMWnlwcen+x8noYNY/SpUL+UM2iKLskTi0pTUDzFsjU6WKMH2xgUXUn2vhMhosiR3QU6En9Ed1aOv3urHe6nOaR/lLrujQ2jS6Waj9WjW8xNqHqvZ/ERoW+l48+GDCeKo2SGr4gcpkpBFRbdD06XBdcA7JpifFu76ueWZza6JrwFGYlUrV8cL0BAnCYMVRkdXslDcybQQMp3ksaz7Q8jE8YkR+JHQP2KAhxi28H7J/IUj9Ek1UkBYtbIvFhbchHhgwLw9joLzoUSDRXITN8O84T2zn+93erXvNDwD0lYwDUo0eb3aFb26zPRUJ3x3x/YMlivBPjHbOK5dK+4/wsTQhAGipVGpjmxJuMb3LmUVqcJg9S1EdEOcz9j1L8Jz208m+2Et1NoEOGEhCcv2ptZfDwCi6H9JY7+V8URy5iXxvXivNZOV1PHfkFCbEaCQFi78MumDAd4wrNwaZctz7M2cWNqWFHAhVTLWEeJ6db7qnBGMAHBKLlal/AZgaSHz+QOuuCxLKvwHwZQwZJdmr+sVWz9mUQ== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(376002)(136003)(39860400002)(346002)(396003)(230922051799003)(82310400011)(64100799003)(186009)(451199024)(1800799012)(40470700004)(46966006)(36840700001)(40480700001)(40460700003)(110136005)(70586007)(356005)(81166007)(86362001)(82740400003)(36756003)(316002)(36860700001)(47076005)(83380400001)(336012)(426003)(16526019)(26005)(2616005)(1076003)(478600001)(2906002)(54906003)(70206006)(7696005)(6666004)(5660300002)(8936002)(8676002)(4326008)(41300700001)(44832011)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 07:49:19.3485 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 90c661b1-8210-4deb-1139-08dbff9dd79a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989EB.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4552 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch allows config options based on DPDK config. Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Sivaprasad Tummala --- examples/l3fwd/main.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index 3bf28aec0c..847ded0ad2 100644 --- a/examples/l3fwd/main.c +++ b/examples/l3fwd/main.c @@ -99,7 +99,7 @@ struct parm_cfg parm_config; struct lcore_params { uint16_t port_id; uint8_t queue_id; - uint8_t lcore_id; + uint16_t lcore_id; } __rte_cache_aligned; static struct lcore_params lcore_params_array[MAX_LCORE_PARAMS]; @@ -292,8 +292,8 @@ setup_l3fwd_lookup_tables(void) static int check_lcore_params(void) { - uint8_t queue, lcore; - uint16_t i; + uint8_t queue; + uint16_t i, lcore; int socketid; for (i = 0; i < nb_lcore_params; ++i) { @@ -359,7 +359,7 @@ static int init_lcore_rx_queues(void) { uint16_t i, nb_rx_queue; - uint8_t lcore; + uint16_t lcore; for (i = 0; i < nb_lcore_params; ++i) { lcore = lcore_params[i].lcore_id; @@ -500,6 +500,8 @@ parse_config(const char *q_arg) char *str_fld[_NUM_FLD]; int i; unsigned size; + unsigned int max_fld[_NUM_FLD] = {RTE_MAX_ETHPORTS, + 255, RTE_MAX_LCORE}; nb_lcore_params = 0; @@ -518,7 +520,8 @@ parse_config(const char *q_arg) for (i = 0; i < _NUM_FLD; i++){ errno = 0; int_fld[i] = strtoul(str_fld[i], &end, 0); - if (errno != 0 || end == str_fld[i] || int_fld[i] > 255) + if (errno != 0 || end == str_fld[i] || int_fld[i] > + max_fld[i]) return -1; } if (nb_lcore_params >= MAX_LCORE_PARAMS) { @@ -531,7 +534,7 @@ parse_config(const char *q_arg) lcore_params_array[nb_lcore_params].queue_id = (uint8_t)int_fld[FLD_QUEUE]; lcore_params_array[nb_lcore_params].lcore_id = - (uint8_t)int_fld[FLD_LCORE]; + (uint16_t)int_fld[FLD_LCORE]; ++nb_lcore_params; } lcore_params = lcore_params_array; From patchwork Mon Dec 18 07:49:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sivaprasad Tummala X-Patchwork-Id: 135245 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7027B4372C; Mon, 18 Dec 2023 08:49:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2BCC40E0F; Mon, 18 Dec 2023 08:49:25 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2083.outbound.protection.outlook.com [40.107.94.83]) by mails.dpdk.org (Postfix) with ESMTP id 88EB04026A; Mon, 18 Dec 2023 08:49:23 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c4qOJJaMb6SfsvjpyDtlcTApai32B3hgXeaUhP5iG4+BRgwYB5z3ItX1wXNFhnWnK0wYOblkqKi/VQ8UCCTyhKvkt9ELGpTy+GhIisY+k7WcxBEsioyxwbH3TggdoClwQ0EFYvQiGBdbCF5mlmTToqLR+IwawLo/ABnLL9H9EDi/fj3UQlzyOa2DlrykndqvwiXtAcZoOJLzl0Yb0qYg96RSvDBrEYlF98XDVc7Op2fVcDy2qkI7nwyIkTgtYuRSnwCrk/9N3C1r6mcBAek5SASewst/s0EO0d3F3vYcUZDxIWv1+ufp8tgjeEWM0ieFIHQA0NEyjdJNhxTRx2yskw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T59MMZGFtmoI8CGtm4pTJnp2pw2Zhc6yv2vsAxLCkEg=; b=e/KJB4FDFf5Lr72Vg5io1dSJryonFa+qol1HRU8WKLISDD+AClHUxTnAW+WKhMh7hjWIl6lwCXVwU4QxcauIGLI7nzryZaTpmbMO4hKl1zbLh4aEhGkkF0B5PbKzo0FRnVpOhHXLk1h+CUNr1D6DbsHqCefzvPAxBPpzZfFyTarqh0h4XdyteniQN+alPgAYgnlnlG0HINozlu2aG5Df1YtWucqvRzG8ancrJ5xmrnIoM7r3cUfBB+QhJPCycr21SWxXg+aHq2MTEdOyhz7MlG0+toelkQxN5SFZCxAXTN2pp8lpHMutyru0TkhVay7DKoqfxJlgwEnb9Of4yBMapQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T59MMZGFtmoI8CGtm4pTJnp2pw2Zhc6yv2vsAxLCkEg=; b=A3EHTeS15DoeW68jTvt+pL232Gyi0/FR4uyv5sP1lahm6CMl2TrBj2F2hQhDQC3e+FjTgSZrgxFLaqT74EHvkhXf4+ajACD6n9p42RVGrH93c1MRx6MoCz8zUAl9EKDw97qbs5w2jMCLjRfWzpgQHE1eM+2oDA92sPHM0Hmicm0= Received: from MW2PR16CA0034.namprd16.prod.outlook.com (2603:10b6:907::47) by SA3PR12MB7858.namprd12.prod.outlook.com (2603:10b6:806:306::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Mon, 18 Dec 2023 07:49:20 +0000 Received: from MWH0EPF000989EB.namprd02.prod.outlook.com (2603:10b6:907:0:cafe::d1) by MW2PR16CA0034.outlook.office365.com (2603:10b6:907::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37 via Frontend Transport; Mon, 18 Dec 2023 07:49:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000989EB.mail.protection.outlook.com (10.167.241.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Mon, 18 Dec 2023 07:49:20 +0000 Received: from 7dbylenovo.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 01:49:18 -0600 From: Sivaprasad Tummala To: , , , , , , , CC: , Subject: [PATCH 2/6] examples/l3fwd-power: fix lcore ID restriction Date: Mon, 18 Dec 2023 07:49:01 +0000 Message-ID: <20231218074905.42749-2-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231218074905.42749-1-sivaprasad.tummala@amd.com> References: <20231218074905.42749-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989EB:EE_|SA3PR12MB7858:EE_ X-MS-Office365-Filtering-Correlation-Id: ac26263d-40ed-4552-93ae-08dbff9dd83e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mcxbzufX4VsNTnKoI4jq/IbjnII7YPrxsWKLJfGpcg5vNFiCdHqLGzjXLJjh8NpHI9oKF09fRvsG84wGBEZcXQW4MZfXlIIZwHOv8RnsJeM6CaBTMwTWS5phoxkUeSMrquN4ZM6K/kY4QIZwlXbrxGwT91uSl50COCqI9CuZsjQWNSLgS/IGy+YKtHbgEo0fROAszqitQKO7B+curRH0tk/VTlsmxxMhKDNIzHYzu6jRafZoofNKRoMYMw+Nrsbnrc9+u/FkGkZXAwq3WnLwayf05iHILRp27oBKjupaKEZTcA2aGe00UEnwQok59A3U40EnbuuORbFtCrJ5lJr/Z4PYMeLy5hF7f9CLt4r3ND8UYo42XOfQUjraSw7xnRj/Roh7yO4inTcMZ/BCzJkde6PTk8qzkpWGKuJedZQ0+y2oSfe8iH2tUMMnWByR63kze/21TAXIkoDGWhxYInct9HZsxPrvB+eke5so0QebBN+tIsCNaWK/F0C8Mz0xKaAPf9AdFRKohGFaTJkWEdmnKWGVfSdi7Bl7clu/TSmpqI1giciW5i1ALdvJd6Uxqe+joPMDBmjmgY4guws3yL3aNqFFcjTDh4jpuCI9Mur2PXIvfJJKZJ+XTH63+DIX6NRZsgHwSa3k4UkGpI1tnlo70FuXUt3BsX4SetDTYQMFaM7+ErFnXRXGkUySeq8zPV1R7OCXCvm9GuzLjV8LD3UhlT2gleLGVk6l2EgRLnevXlAd4tApffYigbCKxHjgQJP9Eqbt6vrskQnCushWQuyMUw== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(376002)(39860400002)(136003)(396003)(346002)(230922051799003)(82310400011)(1800799012)(186009)(64100799003)(451199024)(40470700004)(46966006)(36840700001)(16526019)(2616005)(40480700001)(7696005)(26005)(5660300002)(478600001)(6666004)(83380400001)(426003)(336012)(1076003)(70586007)(54906003)(70206006)(316002)(110136005)(40460700003)(8676002)(4326008)(8936002)(47076005)(2906002)(41300700001)(86362001)(44832011)(36860700001)(81166007)(82740400003)(356005)(36756003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 07:49:20.4110 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ac26263d-40ed-4552-93ae-08dbff9dd83e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989EB.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7858 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch allows config options based on DPDK config. Fixes: f88e7c175a68 ("examples/l3fwd-power: add high/regular perf cores options") Cc: radu.nicolau@intel.com Cc: stable@dpdk.org Signed-off-by: Sivaprasad Tummala --- examples/l3fwd-power/main.c | 12 +++++++----- examples/l3fwd-power/main.h | 2 +- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index f4adcf41b5..1f0ac3e660 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -1399,8 +1399,8 @@ main_legacy_loop(__rte_unused void *dummy) static int check_lcore_params(void) { - uint8_t queue, lcore; - uint16_t i; + uint8_t queue; + uint16_t lcore, i; int socketid; for (i = 0; i < nb_lcore_params; ++i) { @@ -1469,7 +1469,7 @@ static int init_lcore_rx_queues(void) { uint16_t i, nb_rx_queue; - uint8_t lcore; + uint16_t lcore; for (i = 0; i < nb_lcore_params; ++i) { lcore = lcore_params[i].lcore_id; @@ -1661,6 +1661,8 @@ parse_config(const char *q_arg) char *str_fld[_NUM_FLD]; int i; unsigned size; + unsigned int max_fld[_NUM_FLD] = {RTE_MAX_ETHPORTS, + 255, RTE_MAX_LCORE}; nb_lcore_params = 0; @@ -1681,7 +1683,7 @@ parse_config(const char *q_arg) errno = 0; int_fld[i] = strtoul(str_fld[i], &end, 0); if (errno != 0 || end == str_fld[i] || int_fld[i] > - 255) + max_fld[i]) return -1; } if (nb_lcore_params >= MAX_LCORE_PARAMS) { @@ -1694,7 +1696,7 @@ parse_config(const char *q_arg) lcore_params_array[nb_lcore_params].queue_id = (uint8_t)int_fld[FLD_QUEUE]; lcore_params_array[nb_lcore_params].lcore_id = - (uint8_t)int_fld[FLD_LCORE]; + (uint16_t)int_fld[FLD_LCORE]; ++nb_lcore_params; } lcore_params = lcore_params_array; diff --git a/examples/l3fwd-power/main.h b/examples/l3fwd-power/main.h index 258de98f5b..4e5fd3b6d6 100644 --- a/examples/l3fwd-power/main.h +++ b/examples/l3fwd-power/main.h @@ -10,7 +10,7 @@ struct lcore_params { uint16_t port_id; uint8_t queue_id; - uint8_t lcore_id; + uint16_t lcore_id; } __rte_cache_aligned; extern struct lcore_params *lcore_params; From patchwork Mon Dec 18 07:49:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sivaprasad Tummala X-Patchwork-Id: 135246 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42C894372C; Mon, 18 Dec 2023 08:49:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E6D840E78; Mon, 18 Dec 2023 08:49:27 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2050.outbound.protection.outlook.com [40.107.244.50]) by mails.dpdk.org (Postfix) with ESMTP id 4CE7D40DDB; Mon, 18 Dec 2023 08:49:25 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GYE6iUl8CA0BiuLKy+ZfztlMSg8WQqVSsun+suBz3itzwqgaGtg1qxWrm/hMVyvxo+9DgFiMADiM9EZdlAkCJt04AArvcWWlOY0jtH/FyTzUeSijVCHlw+k0dc1GeIPn4aCkGpLEPBCnLKvfp6gPdhu5agHKVPE8IpSvNXuSu+NvO7gSp+j2u3WseKDEy8ZKzbdURtMRLhXwyX3inKe3hQ19b01ErVvBNujwIznUhGmiidTFzAoKpn/nafj6Mum5SXk7ByIvyha+Va/EZG4Z4BQOxtHdq/HXoPeMwc0VItIDiPWMbT6zpvx0jfei12bDFieTNLyXrybwUtgm0HgSDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3FxPbbY2wHmlFk7VjKHA8lesOUoPv/shc8XoFWT+kIY=; b=Gpv1WkETvUruL+cZV//lGSorwcr1mccr2nltZ2fUOuG2JjhkLN9qLvfoctID6j0f8HhfczMElDfhYbDpYci0uev8hupqBpxX2axXPL/BYyqkAl6GTAopCxYY4gxMLxNifCQU8GYkLk8FVvScvruadNgHA7RlHESjUDYbFNGQTLQjEBBtvXP6XA+n/za65ivkbjhv+weSBCr168GWdC1f7rBbbxGIWU4XQygdLBWAdGdX9y/K5t3L89kzDrD6Z41t+qFwu9nSdKo09suqFQk8TLRP+IbrOJad4MIP+FD2phX0oH4gHAuFcaFXstepc7yQ2PV2tEhOMhV69m9Rivag9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3FxPbbY2wHmlFk7VjKHA8lesOUoPv/shc8XoFWT+kIY=; b=Xablr7FQyZpheg/TXirEBpZh9/HbpGc5NH2JjU5KcHTJVEqHzr2Mp/vDy1Yt5ntLSNat7gEOy60OsjrpsxNKpxvJ9Cp/+d7eJcVCf0BYgVecEs8LINTadhGtU+6RPMKADdcGZPQ8S4bcGUqNPtrLSjzRDg89M+N40EGsmONEtYo= Received: from MW2PR16CA0017.namprd16.prod.outlook.com (2603:10b6:907::30) by SA1PR12MB8859.namprd12.prod.outlook.com (2603:10b6:806:37c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38; Mon, 18 Dec 2023 07:49:21 +0000 Received: from MWH0EPF000989EB.namprd02.prod.outlook.com (2603:10b6:907:0:cafe::f9) by MW2PR16CA0017.outlook.office365.com (2603:10b6:907::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37 via Frontend Transport; Mon, 18 Dec 2023 07:49:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000989EB.mail.protection.outlook.com (10.167.241.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Mon, 18 Dec 2023 07:49:21 +0000 Received: from 7dbylenovo.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 01:49:19 -0600 From: Sivaprasad Tummala To: , , , , , , , CC: , , Subject: [PATCH 3/6] examples/l3fwd-graph: fix lcore ID restriction Date: Mon, 18 Dec 2023 07:49:02 +0000 Message-ID: <20231218074905.42749-3-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231218074905.42749-1-sivaprasad.tummala@amd.com> References: <20231218074905.42749-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989EB:EE_|SA1PR12MB8859:EE_ X-MS-Office365-Filtering-Correlation-Id: c6b62dde-f726-4700-66fc-08dbff9dd8b3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XLT9Y06Ta5OWdj01oY4aOYQSSX801urDSUdPq5aZTkykBoSMcYJRn/e7OlKr7DOkrvwmAsTAmDE0ttFnjiRzkfNexw6voKYsJht6KVcIjWkXgpIJjfQD+Ku4QoN4ZPfJp43fVwsxLQwWLmoxbXM/d6gAsfHzxy+mVRKqYvlS0PnSzG6KNY4SHFp+ElXWhoGVqb3yr5bINLwtJXOSo4fePTnbjcFYdplrxDMcoYOUxQZhKfQlbQfmWP6WD59dQ4lRiA9Yy+LJ3HHKgSVlHK4geq9D1accwsogdxCgZFWR6N9byiYRkaSsuzUVCwyc57BN/i30K7rim5hOoUwkvLuQ8dRIxunLacJjlY5QELf/CqL/KqbL7tPC/xcqdnYeqge+2dL5nTvY56vhOvA1UA58eFVAEYKoFhr+cxB/9q6ExEuGaLEFQBJmFIa1aR1YVhASXXPIkbisZJyIVj4cf8fq8aapFNA5XAccwZUjXxA+s4rMjihsU3smrE6RsTCFnZkoXV2f9hBH97n3iLyrVYyiZ26S20i1xLPZNqV1xaB4WuQ/j31fBmGnJfIX7zdD1YkooBQ8CF0kCi0oNEYkuNbNK6PdGHB1AlPRSU2XaKCDad4LZ9QJaz90490TGD+iu5I1jUS0LsQj6g4mWtSjcsJIjtKQ89emCegZMc8Fcvqo5yt4wQt0CRLfIlvrx2Mxi8CkTmoLqfXnVtfXADhQyoLt1ao/FEwIyzgKCMhGHEJehxlSjZ1KCiZTep7RBZ/rRrmwkoZGi+721p6nS08hZ+7XyQ== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(396003)(376002)(136003)(39860400002)(346002)(230922051799003)(1800799012)(82310400011)(451199024)(186009)(64100799003)(46966006)(36840700001)(40470700004)(40480700001)(478600001)(2616005)(1076003)(70586007)(336012)(426003)(83380400001)(6666004)(70206006)(316002)(54906003)(110136005)(5660300002)(44832011)(7696005)(47076005)(8676002)(4326008)(8936002)(36860700001)(26005)(16526019)(7416002)(40460700003)(2906002)(81166007)(356005)(82740400003)(41300700001)(86362001)(36756003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 07:49:21.1922 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c6b62dde-f726-4700-66fc-08dbff9dd8b3 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989EB.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8859 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch allows config options based on DPDK config. Fixes: 08bd1a174461 ("examples/l3fwd-graph: add graph-based l3fwd skeleton") Cc: ndabilpuram@marvell.com Cc: stable@dpdk.org Signed-off-by: Sivaprasad Tummala --- examples/l3fwd-graph/main.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/l3fwd-graph/main.c b/examples/l3fwd-graph/main.c index 96cb1c81ff..149677a3cc 100644 --- a/examples/l3fwd-graph/main.c +++ b/examples/l3fwd-graph/main.c @@ -111,7 +111,7 @@ static struct lcore_conf lcore_conf[RTE_MAX_LCORE]; struct lcore_params { uint16_t port_id; uint8_t queue_id; - uint8_t lcore_id; + uint16_t lcore_id; } __rte_cache_aligned; static struct lcore_params lcore_params_array[MAX_LCORE_PARAMS]; @@ -205,9 +205,9 @@ check_worker_model_params(void) static int check_lcore_params(void) { - uint8_t queue, lcore; + uint8_t queue; int socketid; - uint16_t i; + uint16_t i, lcore; for (i = 0; i < nb_lcore_params; ++i) { queue = lcore_params[i].queue_id; @@ -282,7 +282,7 @@ static int init_lcore_rx_queues(void) { uint16_t i, nb_rx_queue; - uint8_t lcore; + uint16_t lcore; for (i = 0; i < nb_lcore_params; ++i) { lcore = lcore_params[i].lcore_id; @@ -452,7 +452,7 @@ parse_config(const char *q_arg) lcore_params_array[nb_lcore_params].queue_id = (uint8_t)int_fld[FLD_QUEUE]; lcore_params_array[nb_lcore_params].lcore_id = - (uint8_t)int_fld[FLD_LCORE]; + (uint16_t)int_fld[FLD_LCORE]; ++nb_lcore_params; } lcore_params = lcore_params_array; From patchwork Mon Dec 18 07:49:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sivaprasad Tummala X-Patchwork-Id: 135248 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39FD24372C; Mon, 18 Dec 2023 08:49:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 713A8410E3; Mon, 18 Dec 2023 08:49:31 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2061.outbound.protection.outlook.com [40.107.237.61]) by mails.dpdk.org (Postfix) with ESMTP id 8BE5B40E4A; Mon, 18 Dec 2023 08:49:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J6Ol5WCYr6znlT3ZweX1mQphQ43XRyNnHAzcVc8FUnKfmE2Lw7IWYBvgStBLHWpnSa/pDdBUUFshoH+Rc8YFMMSMMaQ1Y/rNEiCHJczJmtq9D0d0bkW4XH8N13b29F1bKZlpcGnzwAK8XtvvmrJfsNS/IDVUSNoMiXCUWEW2MsMzV55jfNJd01JJrkHK/Cd4Da6S5j8FP8Kr7jLgoz3wZsE3cqWM0GBnxbKt2gpgM3at6PYf3PbH5TjepqHOQRXNZsMDHgDpxTiwnzlOfGt6foIfeL2rAeSrUcUJt1PWKWJnp45A7PCNytYQB3h4dDFcfrvbgGSICX9THu4aO+JvQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z6NM6pRsFv5jFGe1HGdE+lS9TQZ9lz8aZ6NeCKtNHW0=; b=RNrLLNLtbY05HEzEB/Fy31KL2gD1aeZDw0b8c8PhstfaWpFGm2QnJMM4uxKAsLJasjgJ2Hso842JYHKZLHKkzxFA1AP0Ljzirftyno56m9Ot+1gnFKWEZzhXB2c05ypQb2WyeZbxYM9xw2kxe+VeZTU9tExLkP98pLZi1Xgti7P0RVvgUBP8GdPz3/asPf81+cjL3p2w/088RZIKNFlZubaf3lBtbokD+XWKtWOhj91lFlAJqUjYSc+6O281iJ+swklLqCyUOiOAJskd0oHBrblDYV4iG1UWtT1tlJ5zJWLVL8Wo1ROAEnEBctq1p4YUw2pJbvpouOaDRN+QPrhhHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z6NM6pRsFv5jFGe1HGdE+lS9TQZ9lz8aZ6NeCKtNHW0=; b=m00GltWlIN/sA/odajg1D+llurv/uBBebBTB4inz3LLQPE0ihx0H46+L0dBYnf3SMVP0jsrL4sYsAJFtMk3BKrVrC060KIWIHtJKKst8pxNEK6pakEwk/E64N94fwLppztcLu6TEf8sOEitMQXwt0oysP74Bl0RtCKF7IEa+/5E= Received: from MW2PR16CA0005.namprd16.prod.outlook.com (2603:10b6:907::18) by SJ0PR12MB5454.namprd12.prod.outlook.com (2603:10b6:a03:304::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Mon, 18 Dec 2023 07:49:22 +0000 Received: from MWH0EPF000989EB.namprd02.prod.outlook.com (2603:10b6:907:0:cafe::d6) by MW2PR16CA0005.outlook.office365.com (2603:10b6:907::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37 via Frontend Transport; Mon, 18 Dec 2023 07:49:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000989EB.mail.protection.outlook.com (10.167.241.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Mon, 18 Dec 2023 07:49:22 +0000 Received: from 7dbylenovo.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 01:49:20 -0600 From: Sivaprasad Tummala To: , , , , , , , CC: , , Subject: [PATCH 4/6] examples/ipsec-secgw: fix lcore ID restriction Date: Mon, 18 Dec 2023 07:49:03 +0000 Message-ID: <20231218074905.42749-4-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231218074905.42749-1-sivaprasad.tummala@amd.com> References: <20231218074905.42749-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989EB:EE_|SJ0PR12MB5454:EE_ X-MS-Office365-Filtering-Correlation-Id: 9f0b4f98-804a-4b3e-ae03-08dbff9dd95c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WMwG5l2gYsXL19ySsxa/MgBH+pgUMdhPNZbzLyqkLX6grktc/CAxg2s9PhEMC79sXJl6wqsfc6g2GI6fyWhaxQGsYjykpobXE6bykYZHCuceDMYdsSwiyyXLrWL5XUogHs3LIpbZ8eWT+VFsZSkKT0fWMJJr7DF3cvwXPY0JMC9PDkhmAbs5MRV9PcibQ1ziAaL25vjfwlNXiOiqynf2Un9R0M2Az9U67dU/eVWVBItDL8D0bi0mlBOBnUS/lgjT4Ex/Mefcv17UoOloDnZ5dWBDQ7f/vma0MOxwa+zVFDNnecL9s8swus7KHqPD4/Azn6SIkBlQwi0nWydtO6GYJm4q4w95eNJmOuTRbEjiijbBiYIOgNrGap5USIHJf3cFrN3eX9FtqgBzr5/PHPjKFVlLOcKk2Th8nCHFa+T2nyY/7tA2cf/jFFPQFMpdS5cnfCBe02CO2nIagAcS0MoeE62CN7uO1S7xoU7nYabMBIaXHpdX3sA1iLjc+yEhlr5lYHQIYpk79CRfUt2Yufe9OCQJnfUeMGqhVX0N+v8kLV6Wl/QxerOpNSZClosgibJESGv87JwPsD3q1m/NjzSccJWbjgdHcKbKsIP9DznNlnCY829KOQ9qoED4eewGLopuWdMoRqBv1eeEnfdAh8ZwDJbdof829u0kF+AuIezkO8m7ofqTyXaEmKXp9lb3gsqo1l6Jy+Z8KnSCCpTv7kDs1S32Tycw2x9+o33c2gxmmQxZMgjPqPghdJVeNCmZaF68hBSPPr6tQX6ViVEZD2gqkQ== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(39860400002)(376002)(136003)(346002)(396003)(230922051799003)(1800799012)(451199024)(186009)(82310400011)(64100799003)(46966006)(40470700004)(36840700001)(40460700003)(47076005)(83380400001)(2616005)(1076003)(16526019)(426003)(336012)(26005)(36860700001)(316002)(44832011)(8676002)(8936002)(5660300002)(4326008)(41300700001)(7416002)(2906002)(70206006)(478600001)(6666004)(7696005)(54906003)(70586007)(110136005)(36756003)(81166007)(356005)(86362001)(82740400003)(40480700001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 07:49:22.3016 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9f0b4f98-804a-4b3e-ae03-08dbff9dd95c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989EB.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5454 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch allows config options based on DPDK config. Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application") Cc: sergio.gonzalez.monroy@intel.com Cc: stable@dpdk.org Signed-off-by: Sivaprasad Tummala --- examples/ipsec-secgw/event_helper.h | 2 +- examples/ipsec-secgw/ipsec-secgw.c | 12 +++++++----- examples/ipsec-secgw/ipsec.c | 2 +- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/examples/ipsec-secgw/event_helper.h b/examples/ipsec-secgw/event_helper.h index dfb81bfcf1..9923700f03 100644 --- a/examples/ipsec-secgw/event_helper.h +++ b/examples/ipsec-secgw/event_helper.h @@ -102,7 +102,7 @@ struct eh_event_link_info { /**< Event port ID */ uint8_t eventq_id; /**< Event queue to be linked to the port */ - uint8_t lcore_id; + uint16_t lcore_id; /**< Lcore to be polling on this port */ }; diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index bf98d2618b..0c15ec5334 100644 --- a/examples/ipsec-secgw/ipsec-secgw.c +++ b/examples/ipsec-secgw/ipsec-secgw.c @@ -221,7 +221,7 @@ static const char *cfgfile; struct lcore_params { uint16_t port_id; uint8_t queue_id; - uint8_t lcore_id; + uint16_t lcore_id; } __rte_cache_aligned; static struct lcore_params lcore_params_array[MAX_LCORE_PARAMS]; @@ -810,7 +810,7 @@ check_flow_params(uint16_t fdir_portid, uint8_t fdir_qid) static int32_t check_poll_mode_params(struct eh_conf *eh_conf) { - uint8_t lcore; + uint16_t lcore; uint16_t portid; uint16_t i; int32_t socket_id; @@ -870,7 +870,7 @@ static int32_t init_lcore_rx_queues(void) { uint16_t i, nb_rx_queue; - uint8_t lcore; + uint16_t lcore; for (i = 0; i < nb_lcore_params; ++i) { lcore = lcore_params[i].lcore_id; @@ -1051,6 +1051,8 @@ parse_config(const char *q_arg) char *str_fld[_NUM_FLD]; int32_t i; uint32_t size; + unsigned int max_fld[_NUM_FLD] = {RTE_MAX_ETHPORTS, + 255, RTE_MAX_LCORE}; nb_lcore_params = 0; @@ -1071,7 +1073,7 @@ parse_config(const char *q_arg) for (i = 0; i < _NUM_FLD; i++) { errno = 0; int_fld[i] = strtoul(str_fld[i], &end, 0); - if (errno != 0 || end == str_fld[i] || int_fld[i] > 255) + if (errno != 0 || end == str_fld[i] || int_fld[i] > max_fld[i]) return -1; } if (nb_lcore_params >= MAX_LCORE_PARAMS) { @@ -1084,7 +1086,7 @@ parse_config(const char *q_arg) lcore_params_array[nb_lcore_params].queue_id = (uint8_t)int_fld[FLD_QUEUE]; lcore_params_array[nb_lcore_params].lcore_id = - (uint8_t)int_fld[FLD_LCORE]; + (uint16_t)int_fld[FLD_LCORE]; ++nb_lcore_params; } lcore_params = lcore_params_array; diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c index f5cec4a928..5ebb71bb9a 100644 --- a/examples/ipsec-secgw/ipsec.c +++ b/examples/ipsec-secgw/ipsec.c @@ -259,7 +259,7 @@ create_lookaside_session(struct ipsec_ctx *ipsec_ctx_lcore[], continue; /* Looking for cryptodev, which can handle this SA */ - key.lcore_id = (uint8_t)lcore_id; + key.lcore_id = (uint16_t)lcore_id; key.cipher_algo = (uint8_t)sa->cipher_algo; key.auth_algo = (uint8_t)sa->auth_algo; key.aead_algo = (uint8_t)sa->aead_algo; From patchwork Mon Dec 18 07:49:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sivaprasad Tummala X-Patchwork-Id: 135247 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 832574372C; Mon, 18 Dec 2023 08:49:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 89F1C40E8A; Mon, 18 Dec 2023 08:49:29 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2073.outbound.protection.outlook.com [40.107.243.73]) by mails.dpdk.org (Postfix) with ESMTP id 50D6A40DF5; Mon, 18 Dec 2023 08:49:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DYF6vMDfyvd9avHhjBTlHyFcJR5gP7vcoP4xhVDlRqMufBP+grvM/h4trHrx6JWn+Vprn/9Ez/pgXwCh2BdyGF4wo1LqJL0zxLKrlz560kWkqRqqMCs+3BaeaDuXHI1LpZrmFQWt1lXcSZVINC5gDX/Ir9DkNTR3Idzh7+G8N7F9r8nQkuf+0YyVCZOGE9k7biLsVkp0KxXM+MpjjJBLay0jlpdlAnTgLniStHRlP3mwJNy/pzH/+VsxGbsy9yGlTpuz+PiB35TvBNsx/Rds8Q9p9UEr0jaC0WXSQ9EGypHJcH99z4EW7gqt7N/CZ0m5Qa5RiS1HMTeAIqflsK9pZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jD6y2+mVBnTppD6Uln3qKfA7bxRgibnJHITerqEztrQ=; b=KBbY8WdpOW6Cq0QmbBZoL2WQsE9ckLyoJv2JulK54SPRrnKbAg2dsr509x5jSoNzSbDKRmfDfdN0LrPgUxoDjeIKHmivaeI5XNrzqVO3AaY2yJhuRHrM98CPH8obZznGckFrN8w1vzPHja4lIKbjvH+IGTf7BE1Arpn4EuGfhFXNNgqmjSg4XOprBf6CuYdGFxC/OrJs3mm4h3n3aLApnVJFyjEDxv0/z9LKXwCZf3HTTLWmlxJQKymIQ5E+ytZWMuAkJGeITpm6u3V0dM/cK18EEFIS4HgPcUe07JiR1x8UPh82FSwxGISKxB2gqBSLtVQJZdj7BIV9zY19LneAxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jD6y2+mVBnTppD6Uln3qKfA7bxRgibnJHITerqEztrQ=; b=aAIsWaoNSCelEA5cBZVOScWt0y2/QeOYtHqysz6kTpZ+hvWQuGRtFWghTp/mYGpx0XlziK7380KVxNDnx1Ty3Wz6AkOQSPE/Cme89cQVruC9XQeR6/2aXNLLpXsQizpPr2HNMOtzhlXKDuI9jyUB4k8SVbnL3JxKv5wlE0z/Yyo= Received: from MW4PR04CA0145.namprd04.prod.outlook.com (2603:10b6:303:84::30) by SA3PR12MB7901.namprd12.prod.outlook.com (2603:10b6:806:306::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38; Mon, 18 Dec 2023 07:49:24 +0000 Received: from MWH0EPF000989E6.namprd02.prod.outlook.com (2603:10b6:303:84:cafe::4e) by MW4PR04CA0145.outlook.office365.com (2603:10b6:303:84::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37 via Frontend Transport; Mon, 18 Dec 2023 07:49:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000989E6.mail.protection.outlook.com (10.167.241.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Mon, 18 Dec 2023 07:49:23 +0000 Received: from 7dbylenovo.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 01:49:21 -0600 From: Sivaprasad Tummala To: , , , , , , , CC: , Subject: [PATCH 5/6] examples/qos_sched: fix lcore ID restriction Date: Mon, 18 Dec 2023 07:49:04 +0000 Message-ID: <20231218074905.42749-5-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231218074905.42749-1-sivaprasad.tummala@amd.com> References: <20231218074905.42749-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989E6:EE_|SA3PR12MB7901:EE_ X-MS-Office365-Filtering-Correlation-Id: ff2a2cb2-772c-49fb-5845-08dbff9dda25 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TysaFy/bucMXNTT6CwPCwzBuloEJnPY9PMgtyPh+h+EjnWK+5cn2SoBD23bkGkNQbZ1HzYUxJHj/gc5+FIEtCF5fIcM9Pc1yDCZpqcw49/2IqzcUq+BxdLzpL9OKPBuOSmbRZ84Umks2iW6FV2DztA9ZYdxKHaruzjgJhfdvu39FKxDxMu2hz0n6dg+uc+GbTulFW/xk51/Pxk7zvFz8tyfDuRFQsTdk+v8w4rATCzsOMUy3qB7ZEUKlbfGBvG8wLRkir3du1kbJlK1nrU6XPq5A0PMDdj635sZAts3iw64R+p+DaQMApFjLBIHzXmweQxW3erI5pcaIqUmIFYm0USKX4Drdl5YUFKCMxtdIYp4+bZVz1Z2Eg7ZK4jceRJ6wuyEgrdMDanK73SNjDABUlnNi96fYLhAGSXMwXDk6RYM+J4Gwlfz3tavspvIng0UH8YAArsZIBCXpdbzwErfET+Z/JKIKEJO0abjrJHIqty1AgtzrL3smbk6cSJVzhuTL3ZsypeG+tCTzpg3qIbQOUM5gB9HGPfB31utZJ9Ha2eJohygcKQZCE++PuGyFf5nNcvKpQT8/msq/n7GKxMG5RxYrHjHldDeZFXOCRuoL+5IPetTPAS9bhJeHXrBPD0ODx9rQWHy1NOMz8X2eJMWJD0FLoMRccN3kG+2+QGERzv01Mu/9aY839IJ0/YTi8MjIdblf/gmTlDNlZTo7WB1v3o2qq2og+ULHHBUw7n8+xfXrM6l8yO92bP+Mp1xh4YqmuZAMgqf+m3ZXu115y2K94Q== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(136003)(376002)(346002)(39860400002)(396003)(230922051799003)(1800799012)(64100799003)(82310400011)(451199024)(186009)(36840700001)(40470700004)(46966006)(7696005)(6666004)(478600001)(47076005)(2616005)(36860700001)(83380400001)(1076003)(336012)(426003)(26005)(16526019)(4744005)(2906002)(5660300002)(41300700001)(316002)(54906003)(70206006)(70586007)(4326008)(110136005)(8676002)(8936002)(44832011)(81166007)(36756003)(356005)(40460700003)(40480700001)(86362001)(82740400003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 07:49:23.6323 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ff2a2cb2-772c-49fb-5845-08dbff9dda25 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989E6.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7901 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch allows config options based on DPDK config. Fixes: de3cfa2c9823 ("sched: initial import") Cc: stable@dpdk.org Signed-off-by: Sivaprasad Tummala --- examples/qos_sched/args.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c index e97273152a..22fe76eeb5 100644 --- a/examples/qos_sched/args.c +++ b/examples/qos_sched/args.c @@ -182,10 +182,10 @@ app_parse_flow_conf(const char *conf_str) pconf->rx_port = vals[0]; pconf->tx_port = vals[1]; - pconf->rx_core = (uint8_t)vals[2]; - pconf->wt_core = (uint8_t)vals[3]; + pconf->rx_core = (uint16_t)vals[2]; + pconf->wt_core = (uint16_t)vals[3]; if (ret == 5) - pconf->tx_core = (uint8_t)vals[4]; + pconf->tx_core = (uint16_t)vals[4]; else pconf->tx_core = pconf->wt_core; From patchwork Mon Dec 18 07:49:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sivaprasad Tummala X-Patchwork-Id: 135249 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 371174372C; Mon, 18 Dec 2023 08:50:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A194240ED6; Mon, 18 Dec 2023 08:49:32 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2048.outbound.protection.outlook.com [40.107.94.48]) by mails.dpdk.org (Postfix) with ESMTP id 1A13440E68; Mon, 18 Dec 2023 08:49:27 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A/p2r4Xg44RVnlAKqhiNjSvUbnZvp6cgBKkT3rZs27hnwhcNKdoHjW7d5YOT556N7fkHcQ5sxAsA/mZMEsO8BeVilOAwMzSxhL4HODXiCMAqVHPq5gAvlb/kMond7QsL3P0pOYR9aDPU7BYM0iUzOT0BCTNT4XI3OQ5gpBza16BWomQkutHZOzFY29/+XUbFcc9e2paKOPc+HxpgX33lZTEqscpD85ureyix/R3n9EESocho6pVEDMeUujMVkDfJhlHQJYyiiY/95QL+C1738+9RIqcDLmRNi8P2qjGidmo4zCVL5/6aSDeodVBLxDLUHqVDd0yCwn0dBjEqnzv+Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pelULDo/Wpz4C81J43QCyteewJdU1439J7sWe81Jjj8=; b=k5F4QYFq3mqQ+HwcgN+t/SkQkNV7CbNpbJgB3zhp3AR4vL6N37BbKgkQFtnMP/jNsiSKH+jE1JvsZKisoWE1oy88BHjwMBAsi3l1Rh7vEg6FD8evPT9veCpYOGDp7oj95RY6SM9ztn8DNHZsDDg1iTlgk813wq+dDUR5qNy0jaOscleMZNpAPmbaYHOirKNVK2IVeRqV1RhxP9XFicDn0oealSxfHOMDAJcIYFamwmb2phLNXPIrmvenOB/0e4XTxR1bSDsuMLsHyykKBxmars3mOCLMgpGe2fM3RoRsxu0CEHkcuPvZSCHSG40OzF51+8r4daZXVMZfpWKoMxIv9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pelULDo/Wpz4C81J43QCyteewJdU1439J7sWe81Jjj8=; b=il/4qSwf8xeata8+zQjIB0HQlMwxns7ibbsmBXhbe72gTx4lAUAMpmhofLhPVAUAfgYTjnztFsRiUKa3PjqJJ5JKnrT+hb9BQy+db//4M5eTVc3XA65sGUjAy5gm4ynzNwuxLcCq/VqYMm9nk/4juZELNxsOLXGD296HNtfFo/I= Received: from MW4PR04CA0140.namprd04.prod.outlook.com (2603:10b6:303:84::25) by DM4PR12MB5819.namprd12.prod.outlook.com (2603:10b6:8:63::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Mon, 18 Dec 2023 07:49:24 +0000 Received: from MWH0EPF000989E6.namprd02.prod.outlook.com (2603:10b6:303:84:cafe::29) by MW4PR04CA0140.outlook.office365.com (2603:10b6:303:84::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37 via Frontend Transport; Mon, 18 Dec 2023 07:49:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000989E6.mail.protection.outlook.com (10.167.241.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Mon, 18 Dec 2023 07:49:24 +0000 Received: from 7dbylenovo.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 01:49:23 -0600 From: Sivaprasad Tummala To: , , , , , , , CC: , , Subject: [PATCH 6/6] examples/vm_power_manager: fix lcore ID restriction Date: Mon, 18 Dec 2023 07:49:05 +0000 Message-ID: <20231218074905.42749-6-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231218074905.42749-1-sivaprasad.tummala@amd.com> References: <20231218074905.42749-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989E6:EE_|DM4PR12MB5819:EE_ X-MS-Office365-Filtering-Correlation-Id: 2f0057f8-e8a7-45f3-2a41-08dbff9ddab9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CxU4YIHFqp7lcVtLm/iVSJwPXIhopi6xGQI+xg2WW1RTTG3vkA2kkAVL8vdEX21QbZJGQTLBzNv2wK8Om3n/sVLKhuRb+UQB8qpvs4w0YYfXHu1k2DXMsevPbFm68c4R+yZr5L8JI4RetkIdqwe3bft+ksSVWUhhwlFo1Oiyi5QspktJDRsYOKFT9L5es+pZZQx/i6kYIEJBPPsCm08WylqvEuKGW2usLpXyEs/ShH7fo7aWJyKKJEBb8eQ0MtGCTmiyXGRKdNOtGcTVDl46ly49G+yh94FW2gLGasBXsaYln5793N0SixGTdS0rHY75Dy7SUTqYTz5aEx2QO0scApqRDgx/vQ6mVn2CmeA6Q6wrRLLxeQunHvb9PwoYZ89aOLtqJPApEijimZF/DLvc7b6xpHwlV7L/87pv9udyMhz6iWJjXREu5Q09eQlsKw5G5+REoKa800LZ1TOJOKtdRH9Pcgjv/gy1LaoJNygj6pYe8FOc17LoanqUHzRxT5BOgHd08iruwY/GEHbG2ykNeVy1eO8QHNjVtPcpO6/aMJJCJnIllkNW+Dfj+NvKy42AF33egwlDlRV2wI8HfgX4miVmkg1uG2PkJst23uVCGJMsn7TGXjkjdQ1aFP3ZdUGVOP7ySas058UOsytTflKJs0hiYL1OyA8vFvuKCmH2WBWAhj7OPl7hHka1hZnOMAvhto7iHGcG9/cWucc01CqoduANu/JmyQkyAipDOypPz8BQAiqxHxxK7Fi8TtCCPIC/p8TctbvMVWDBtfqyB/nc+g== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(346002)(396003)(136003)(39860400002)(376002)(230922051799003)(82310400011)(1800799012)(186009)(451199024)(64100799003)(36840700001)(46966006)(40470700004)(83380400001)(2616005)(70206006)(70586007)(110136005)(478600001)(54906003)(316002)(1076003)(26005)(40480700001)(336012)(426003)(16526019)(4326008)(44832011)(47076005)(8936002)(8676002)(7696005)(40460700003)(6666004)(36860700001)(7416002)(5660300002)(2906002)(86362001)(81166007)(356005)(82740400003)(36756003)(41300700001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 07:49:24.6011 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2f0057f8-e8a7-45f3-2a41-08dbff9ddab9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989E6.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5819 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch allows config options based on DPDK config. Fixes: 0e8f47491f09 ("examples/vm_power: add command to query CPU frequency") Cc: marcinx.hajkowski@intel.com Cc: stable@dpdk.org Signed-off-by: Sivaprasad Tummala --- examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c index 94bfbbaf78..a586853a76 100644 --- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c +++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c @@ -401,7 +401,7 @@ check_response_cmd(unsigned int lcore_id, int *result) struct cmd_set_cpu_freq_result { cmdline_fixed_string_t set_cpu_freq; - uint8_t lcore_id; + uint16_t lcore_id; cmdline_fixed_string_t cmd; }; @@ -444,7 +444,7 @@ cmdline_parse_token_string_t cmd_set_cpu_freq = set_cpu_freq, "set_cpu_freq"); cmdline_parse_token_num_t cmd_set_cpu_freq_core_num = TOKEN_NUM_INITIALIZER(struct cmd_set_cpu_freq_result, - lcore_id, RTE_UINT8); + lcore_id, RTE_UINT16); cmdline_parse_token_string_t cmd_set_cpu_freq_cmd_cmd = TOKEN_STRING_INITIALIZER(struct cmd_set_cpu_freq_result, cmd, "up#down#min#max#enable_turbo#disable_turbo");