From patchwork Wed Jan 31 00:18:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 136225 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81F0943A13; Wed, 31 Jan 2024 01:18:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4CCFD40269; Wed, 31 Jan 2024 01:18:53 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id BDE7E40266 for ; Wed, 31 Jan 2024 01:18:51 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id E112A20B2000; Tue, 30 Jan 2024 16:18:50 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E112A20B2000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1706660330; bh=JMXCTL4ACzs2pjlxeq2XyO+i46R64dsG3PYxFEQvW9k=; h=From:To:Cc:Subject:Date:From; b=C3/L3vgEe2U6StYiZ58OnrUzehfjaAmAfamjSZTYuaP2bPg9HX8d1BbicGCF0a3a/ LxkDYWpN/Z2k5wDxz9voydebHPi1Eu28MPBvBL4Wktxov1Ztqh9gK46rdizfs9KAXb WxrSA8bqgYDeErcc/UJTuWkCQ0l46a3AwlUzIIOA= From: Tyler Retzlaff To: dev@dpdk.org Cc: Bruce Richardson , Konstantin Ananyev , Tyler Retzlaff Subject: [PATCH] eal: remove unnecessary use of statement expression Date: Tue, 30 Jan 2024 16:18:49 -0800 Message-Id: <1706660329-1752-1-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove use of statement expression syntax in expansion of MOVEUNALIGNED_LEFT47_IMM and MOVEUNALIGNED_LEFT47 macro expansions. There appears to be no need to use the statement expression compiler extension a simple block should work. Signed-off-by: Tyler Retzlaff --- lib/eal/x86/include/rte_memcpy.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/eal/x86/include/rte_memcpy.h b/lib/eal/x86/include/rte_memcpy.h index fd151be..72a9229 100644 --- a/lib/eal/x86/include/rte_memcpy.h +++ b/lib/eal/x86/include/rte_memcpy.h @@ -610,7 +610,7 @@ * - __m128i ~ must be pre-defined */ #define MOVEUNALIGNED_LEFT47_IMM(dst, src, len, offset) \ -__extension__ ({ \ +{ \ size_t tmp; \ while (len >= 128 + 16 - offset) { \ xmm0 = _mm_loadu_si128((const __m128i *)(const void *)((const uint8_t *)src - offset + 0 * 16)); \ @@ -656,7 +656,7 @@ src = (const uint8_t *)src + tmp; \ dst = (uint8_t *)dst + tmp; \ } \ -}) +} /** * Macro for copying unaligned block from one location to another, @@ -671,7 +671,7 @@ * - __m128i ~ used in MOVEUNALIGNED_LEFT47_IMM must be pre-defined */ #define MOVEUNALIGNED_LEFT47(dst, src, len, offset) \ -__extension__ ({ \ +{ \ switch (offset) { \ case 0x01: MOVEUNALIGNED_LEFT47_IMM(dst, src, n, 0x01); break; \ case 0x02: MOVEUNALIGNED_LEFT47_IMM(dst, src, n, 0x02); break; \ @@ -690,7 +690,7 @@ case 0x0F: MOVEUNALIGNED_LEFT47_IMM(dst, src, n, 0x0F); break; \ default:; \ } \ -}) +} static __rte_always_inline void * rte_memcpy_generic(void *dst, const void *src, size_t n)