From patchwork Thu Mar 14 11:42:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 138384 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB95D43CA5; Thu, 14 Mar 2024 12:43:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D01ED42E7E; Thu, 14 Mar 2024 12:43:07 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2079.outbound.protection.outlook.com [40.107.223.79]) by mails.dpdk.org (Postfix) with ESMTP id 63F9E4028C for ; Thu, 14 Mar 2024 12:43:04 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=giu1QkmCuPKngS3poeylpJojtdkXLdWfU7OQjfqyqXq7kcZubYGm/SntadP2NCfWjqbDjlgthxpBfkxYtGkrNIEnSNIRHyajxkYmarFIfvZL0ftq6Qn3R4UyW/8Ei6XGzzeu0LrMrfIJYXDoL+GM3T4DC+v2jkkmMWfH9KYDK+NzT6vsTYKNqyIDAK7TDRjTIpagScLbFBry7vNXnGwaUXl7MCtzvxklRluMzlFl3HGrS0OwWwIJSuYuzavzIVdyExU2wQWMNrI+ncySC9qke+1nlWO51iuFfSbwBxK5b8RJ2oylOaxBOoQ5+/y4ZdjmnsHN3MI1fbmw67dpzk1NEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YO0AWP7UD14uwfYa4MZJbxmUEoBspItSjqhBkvLsW4M=; b=iCIJyOgH3TN7eaA4iZ0MjJZAwHxYhKnzRG4rb/taYomKM6ba2lRlx2ygw8tQL0qH2pyOHaSknvb8bwdwPwIBfSKWJruF5WSjbr5k1czHaZH90D32f+hAe8rtz4IwtFi24baPLMFAEG/GpNwm2l8Ee/hAhQ7HTBPILefgS2X4C9JGrVdPJrSrE7eTUNPpwnVRgO65q+KeTbEcgkxYWRd9jT7dFhfv/awViAEJ3MJW5uPotDlxp85KqGSBczNznvkAxTd4vsP3gHV7A0FulYoHYENan1yO1L1gXdFeT9VEC4ZOFUcPE60l5xHA8/vtDi+J6cQ8S+Rsr8n0nmzUWt+LdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YO0AWP7UD14uwfYa4MZJbxmUEoBspItSjqhBkvLsW4M=; b=LJH2/bahZfw5eCuwSBUCAikau/fIzdZmvjRrulAvcBPnb8OmVX9ifox4AWyYtcEgfUMhyp8XFEAbAtm7VKPq1ErHjBzh1bZ2K2wQZIJHKuyAY4ptRwsF++cAjpREJgJRa9s0004X4Y4FInBJni7U7iNKyYrevB9unPPhRoiQUT3p9wsRhOzVyWf+HY9ppUEj9wX9c7HGFJofKhgBCcPnc0redHrXgzeNNqTnZy+LEwuBrpQQW9YS5zs1YbTPaH6/Bd0GfUsUzY0JNYaA618lVdGw6HS6+AvvB+2o+qHDOHqiAw1F0+rSK02cCn5fj0b9ySk0/Npu5foXarGBu5OAWQ== Received: from DM6PR05CA0042.namprd05.prod.outlook.com (2603:10b6:5:335::11) by CY8PR12MB7514.namprd12.prod.outlook.com (2603:10b6:930:92::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.20; Thu, 14 Mar 2024 11:43:01 +0000 Received: from CY4PEPF0000E9D7.namprd05.prod.outlook.com (2603:10b6:5:335:cafe::2) by DM6PR05CA0042.outlook.office365.com (2603:10b6:5:335::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.7 via Frontend Transport; Thu, 14 Mar 2024 11:43:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000E9D7.mail.protection.outlook.com (10.167.241.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.12 via Frontend Transport; Thu, 14 Mar 2024 11:43:00 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 14 Mar 2024 04:42:47 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 14 Mar 2024 04:42:47 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend Transport; Thu, 14 Mar 2024 04:42:43 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Suanming Mou , Matan Azrad , Mark Bloch CC: , Subject: [PATCH 01/13] net/mlx5/hws: move warn into debug level when needed Date: Thu, 14 Mar 2024 13:42:08 +0200 Message-ID: <20240314114220.203241-1-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D7:EE_|CY8PR12MB7514:EE_ X-MS-Office365-Filtering-Correlation-Id: b73ec5d6-0266-454a-fd21-08dc441be6cc X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yMush/AnRM3f7LAu4VqnSiGBVVAjoigg0mZm9ohh0x/vQBfU/IQQvlNtXg6qqQ/v2Dvcx5uekwI5Wh6zvjkEyxUgXfkP46GKS06kZJWBC54/gppJ5SCT5oo+6PK4dHCp52E3VUi1k2YdIN55v/MEKmhmkHtXNN0gYmmAZYx3kV37ePBFSmNpc8bR3DbrBNMPaWjgVETZqPlfA0ocO+NMF+HJDv/9xoGiv7U447anfRXAgBWQvRwwu1Sa1ZqGKy5eueE4ePYUq96Fd5fQmmHUeS8VvkgWa1SR1HbTc5o1hz5CnYwu4d83Bg314vbex9Us9QQUqAprtvhxFWpsdAdrbu99t7rJ+BFz1TvgHXhoHiU/yvQ531164pTeKuMfrUec3978ow1vZkLj/ZKiWgamTkz4h2mPiofgUW1CClbpjO+jQeknchSyulJt0B0Z0fA7gDxR2annn5MJmH/p/tryqPnevQQuRohuScSI6l1uPzzGUZgPwqqFzmwjPiFJlMeWIaOYDu8nHu9N7J32RssrqeKsqW/VzXFFONL84Db+GowdjxArJ5meMWqlkH1oQTh/NT2AbxBTS7MoE6I+8r+DB7nD8drsdUjQPJlwohGJFmL1/5U9hD1niVzvMMtmXxK4qwUSdOfOVjkEi+ZYKo+Vli6mfVFwbatcSZA8rpKU9H38SKJbV7d6jwI+By8jMqotW2u13UG8Xy01ZctLUgvZbFlCbESE+fihX+Dfn9JesBBFr+h3pMbA2mkj9kMAf+p6R6Q5l1uKkbhTwTGoOU6fDw== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(376005)(82310400014)(1800799015)(36860700004)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 11:43:00.5673 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b73ec5d6-0266-454a-fd21-08dc441be6cc X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D7.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7514 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Erez Shitrit When the user tries to create a matcher and if failed with specific errno (E2BIG) the message will be in debug level and not in warning. It is a part of a feature when the user re-try to insert a new matching depends on that errno, no need the annoying message. Fixes: c55c2bf3533 ("net/mlx5/hws: net/mlx5/hws: add definer layer") Signed-off-by: Erez Shitrit Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_definer.c | 6 +++--- drivers/net/mlx5/hws/mlx5dr_matcher.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c index 35a2ed2048..81d0e0e6df 100644 --- a/drivers/net/mlx5/hws/mlx5dr_definer.c +++ b/drivers/net/mlx5/hws/mlx5dr_definer.c @@ -3534,7 +3534,7 @@ mlx5dr_definer_find_best_match_fit(struct mlx5dr_context *ctx, return 0; } - DR_LOG(ERR, "Unable to find supporting match/jumbo definer combination"); + DR_LOG(DEBUG, "Unable to find supporting match/jumbo definer combination"); rte_errno = E2BIG; return rte_errno; } @@ -3689,7 +3689,7 @@ mlx5dr_definer_calc_layout(struct mlx5dr_matcher *matcher, /* Find the match definer layout for header layout match union */ ret = mlx5dr_definer_find_best_match_fit(ctx, match_definer, match_hl); if (ret) { - DR_LOG(ERR, "Failed to create match definer from header layout"); + DR_LOG(DEBUG, "Failed to create match definer from header layout"); goto free_fc; } @@ -4041,7 +4041,7 @@ int mlx5dr_definer_matcher_init(struct mlx5dr_context *ctx, ret = mlx5dr_definer_calc_layout(matcher, &match_layout, &range_layout); if (ret) { - DR_LOG(ERR, "Failed to calculate matcher definer layout"); + DR_LOG(DEBUG, "Failed to calculate matcher definer layout"); return ret; } diff --git a/drivers/net/mlx5/hws/mlx5dr_matcher.c b/drivers/net/mlx5/hws/mlx5dr_matcher.c index 1c64abfa57..1213e7f0ad 100644 --- a/drivers/net/mlx5/hws/mlx5dr_matcher.c +++ b/drivers/net/mlx5/hws/mlx5dr_matcher.c @@ -877,7 +877,7 @@ static int mlx5dr_matcher_bind_mt(struct mlx5dr_matcher *matcher) /* Calculate match, range and hash definers */ ret = mlx5dr_definer_matcher_init(ctx, matcher); if (ret) { - DR_LOG(ERR, "Failed to set matcher templates with match definers"); + DR_LOG(DEBUG, "Failed to set matcher templates with match definers"); return ret; } From patchwork Thu Mar 14 11:42:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 138385 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A01743CA5; Thu, 14 Mar 2024 12:43:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73B1442E9C; Thu, 14 Mar 2024 12:43:20 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2062.outbound.protection.outlook.com [40.107.212.62]) by mails.dpdk.org (Postfix) with ESMTP id 12F5340297 for ; Thu, 14 Mar 2024 12:43:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ncbB5LPUFO30qxvTDbRbngrVOnLdMIuVzPmz/4rCKKIYZATsDtAdiarSuQiqkKnej0qhZ9xVeMfE4ewhZovGYxdDAWyhT7f+UbKK8dTPi3MVOhpBC91YFKn6zvxq/XRKNB3JQlYeIloSDBDHVE0oAN65BEgJzVgES/rrqfPjwfGfROqDS/z5svt0eIyWvoB0Ho22pT0hrd+gjApW5JS+ssEAcN/Vnk5Q84ZZsLEJLWqFOJiyS+ypuWkymg7YZ15SD3kNKFyIIHbDmJ7SWJf3XW1wb25iegkTJBjJOOM/FzUWJZDMw5pharWlS/eOOb5rFKw9ZHasNYbKtiIv0MrQOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6MwGpcDESHnRGLgyGJ+OnBEi0nQiB5wKVH2oA2mF8HI=; b=ZtWQRpU5V/cMcocj9er2sZ40GJ4bjN0zRJKrWyN1YfvYgBgiKFwG7czc399XJj3+bJLqG+j14IFz0IBHIu94n92D/dw+7Bn9wgaTxYJc9v6NDiHRh7xFlIMQf0EqFzuIfQDG5OA7BpCXPvmIqv+U0Kl82dudcjn6mpflQY2/7gdSHfeJPfzGXxPqj6sJgOdhrn1FFoUoijXJ9juHXH4VxVPI2b1leQtuUEPEn9xqJTAxVv6wc2EwYXlI3lmj77hOOp/Fi04Bi6IBT9pNvAcHC3R1z7dFMOIYcz6+hzbOHbwpd7LVQgEdeOIC8Sa/9NWXqmuK1A69uD0mdnf5iA3nIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6MwGpcDESHnRGLgyGJ+OnBEi0nQiB5wKVH2oA2mF8HI=; b=A3QVuot8QIhuuyaUEIP5pBVk/b7u1bkFm3xHsvpRA2nMitXZsg7oFIQ5KTmPxttBmogOrhhjs+f3bJLW1JPKUiu5iqUpk0p321DKShGzQefYqbbOepLRMkdIO7lLReRo+M7ELS+DdU+VfyKWgp+zDgBykEu/i4s/hUaYaEv1MTlODkEs2LxbyOMTX9KnxEhmsTwB7AxiTILGhUr1fz8h1/24SV7YndWkNSaaGTEHe5idmnsEkT7dk8wFWErRzyh5+7KCH68DodbcpQPVbJCKfHpVy58sgojvebbC2xqBAQQCqeSaPS+61//IMjX7pLj6AUIEifvh7JIDMKqEaB1xZA== Received: from DM6PR05CA0060.namprd05.prod.outlook.com (2603:10b6:5:335::29) by DS7PR12MB5838.namprd12.prod.outlook.com (2603:10b6:8:79::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.18; Thu, 14 Mar 2024 11:43:06 +0000 Received: from CY4PEPF0000E9D7.namprd05.prod.outlook.com (2603:10b6:5:335:cafe::62) by DM6PR05CA0060.outlook.office365.com (2603:10b6:5:335::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.20 via Frontend Transport; Thu, 14 Mar 2024 11:43:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000E9D7.mail.protection.outlook.com (10.167.241.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.12 via Frontend Transport; Thu, 14 Mar 2024 11:43:05 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 14 Mar 2024 04:42:51 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 14 Mar 2024 04:42:50 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend Transport; Thu, 14 Mar 2024 04:42:47 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Suanming Mou , Matan Azrad CC: , Subject: [PATCH 02/13] common/mlx5: fix error in mlx5 prm structs Date: Thu, 14 Mar 2024 13:42:09 +0200 Message-ID: <20240314114220.203241-2-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240314114220.203241-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D7:EE_|DS7PR12MB5838:EE_ X-MS-Office365-Filtering-Correlation-Id: 5a44cb1f-3936-41a6-b5e1-08dc441be98e X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AXm2uqiKIGuwOjFLWzJvMG22j/Hwasbv+xqijP0cRGXk6XJ3mhSYyUzp2KixX2yxG+THue7Si3MPl+F//yIDpr6UI5yb1g4Oo4nkpuw12dZT/PaGnjwRntiiJrKRoH15OQk6C3urLIkpF2Lifrf84+K29Caztj8wj2SS2RB7zxkvueHvSqF7Ss0lKCNZ9nEjhz/FIkc3nxLhb74+2RFj/aYuiSvsw3K8kvmNBbik2kK/DIx9OLhw/ALaqY18ZB8YBcV9qfxmOM0CbncXndY8JS2wJo4U4/fVxXLqEy5++mgR87OlTwF1UJe7EAP/5SxUojGJgv1TidgnaXUkqQ8+egdpeaGAGCTc1yXeucHME6lHZP5erbj9W38yk4wUoU/W8jnq/S0bkwXm4HvcihOcT8iq4cweJMpUFCVGLQKTkJDCNMcLpJTSwIZmfRd3pF9VQ2+/Rf3mXybIRoAfxZ8N9FyP+2KuPMQB/869P6DbZcWF9hjJzJ37dVabN1CxZhMSrbcFePROt3W/8Y1s2SeyODtrtIBpS+YB0DWytEw27gYpo+NfJMfGHZ/T0RVpdP8TykPfiiFMzA1V0s3mXQKP7ev+YXeU6bNvAcnoRzzqOWV6vYOtYFkegC6OOxsbHYCWbU+kmJ7i1Op8kst2JSbhw1efEuAsUa/A/3cPjWDxEon03atUpFAGphaEPTxujLafBbWABbr5MN0HNNbiuAcHBYzXpGFKtsCP1oQRKs07T4N5SwrZHyus2lMARqM27Z9e9rB335bA8YjFHdscxgpitw== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(82310400014)(1800799015)(36860700004)(376005)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 11:43:05.2080 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5a44cb1f-3936-41a6-b5e1-08dc441be98e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D7.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5838 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Yevgeny Kliteynik Fix wrong reserved size and add helpful comment Fixes: 365cdf5f8ce ("net/mlx5/hws: add command layer") Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h index c671c75bfd..c6846cdb7e 100644 --- a/drivers/common/mlx5/mlx5_prm.h +++ b/drivers/common/mlx5/mlx5_prm.h @@ -2360,8 +2360,8 @@ struct mlx5_ifc_cmd_hca_cap_2_bits { u8 reserved_at_d0[0x3]; u8 log_conn_track_max_alloc[0x5]; u8 reserved_at_d8[0x3]; - u8 log_max_conn_track_offload[0x5]; - u8 cross_vhca_object_to_object_supported[0x20]; /* End of DW7. */ + u8 log_max_conn_track_offload[0x5]; /* End of DW7. */ + u8 cross_vhca_object_to_object_supported[0x20]; u8 allowed_object_for_other_vhca_access_high[0x20]; u8 allowed_object_for_other_vhca_access[0x20]; u8 reserved_at_140[0x20]; @@ -3655,7 +3655,7 @@ struct mlx5_ifc_stc_ste_param_vport_bits { u8 eswitch_owner_vhca_id[0x10]; u8 vport_number[0x10]; u8 eswitch_owner_vhca_id_valid[0x1]; - u8 reserved_at_21[0x59]; + u8 reserved_at_21[0x5f]; }; union mlx5_ifc_stc_param_bits { From patchwork Thu Mar 14 11:42:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 138386 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6BDE43CA5; Thu, 14 Mar 2024 12:43:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D536742EAC; Thu, 14 Mar 2024 12:43:21 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2042.outbound.protection.outlook.com [40.107.93.42]) by mails.dpdk.org (Postfix) with ESMTP id D72C742E51 for ; Thu, 14 Mar 2024 12:43:10 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=amxkERScCCKbcjW+pvj4ek4uSrkefr84lGWwLpkHWvW1iezu8fesSiLbKiIWubFxGo404W6jKfSqZlWMoTS4QbNsAaHJeRKmqmgdBaY7BT0Pc9x5BjK1iQ/yoPxykykmKomsOjDAdUJDrB0Wa/TBaUi1qTdwT3wH0frb3QDWraX+FWs6VAvMSBWgAlD4AgXmsma6GvK+s6YWg9Z5M9j3pvbxyZWudnrCrdzBuszxtvOKKzfreKP/dXKeBDchrCEahn4sSE8+fLJ1ZJqzpK0HcNiFD5WpBDcU6+ENxpXDyxTpHFP4FLXGKVkDMJ+wZb5ndrhca6NM7tHMuQfUYSLndw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cMfwTVuq7JR1KDVLTU1sGSWgi/DNhQHzQlw0Vf12hYo=; b=TPft0KFJ2eTM2BHX/TkqJKBKEmSvagVCw9y+JIPSWKIz1WSgrA67QKXhffTk06hzVJtJdkPKu3KQ+kyzf1o/5T383YC6K/aXEEmshpJXN/PpdpYnR2TFtkU6/ImTTi8zcNUebOMU+IYqfInURBbiNP0/jIvpPDnwi6Dobx/osQy1vP+JhaaFgWnWE9oQKd854v2Iu+RMHfXnVfPLCknLSX8twq4qPb1bUvcCcPhLgYrlZYeir3MwcQZqvvl+zc3ChMBfZhaj4locrgYj820dc/slyV8EAbSHh5OIcTh6o6xvWRBgHif30nyKOk0qXE/dkmYzvS9HwUwDBKn8vFaXfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cMfwTVuq7JR1KDVLTU1sGSWgi/DNhQHzQlw0Vf12hYo=; b=CrGC0VGhqTDxYWlvffzBJyknaYHB9ecDCD5jNUV7TAB/nbZ6LCBu4xuWE6ogvbV89whb7ZafxaBbEER7DAGEUCvgD3xQsRB3JuBJGe6Zr+pR0ivDueko1TXV9UcTKdYOQLUMNNdSaM5TM0lqq+XW5XNS9pm4fdsqovE4yTynGLisOLrSpV9vRZwsaxnR3Vn6IXw7CfhZJy3JAwBWvuqZp9QhGjetnLMJj4l4XqoNWh2TGg690h6vnuDVhizgMHSaMhnhbSXJsI/DVYZc5Hz143aaDq9c6fqqTPhNvPXhLbvArROppJe+TfI3+gJZrujDk7MHpHSetAUCbfV9UViF/A== Received: from CH2PR11CA0004.namprd11.prod.outlook.com (2603:10b6:610:54::14) by CH3PR12MB8902.namprd12.prod.outlook.com (2603:10b6:610:17d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.18; Thu, 14 Mar 2024 11:43:06 +0000 Received: from CH3PEPF0000000C.namprd04.prod.outlook.com (2603:10b6:610:54:cafe::bd) by CH2PR11CA0004.outlook.office365.com (2603:10b6:610:54::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.19 via Frontend Transport; Thu, 14 Mar 2024 11:43:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CH3PEPF0000000C.mail.protection.outlook.com (10.167.244.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.12 via Frontend Transport; Thu, 14 Mar 2024 11:43:05 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 14 Mar 2024 04:42:55 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 14 Mar 2024 04:42:54 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend Transport; Thu, 14 Mar 2024 04:42:51 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Suanming Mou , Matan Azrad , Mark Bloch CC: , Subject: [PATCH 03/13] net/mlx5/hws: fix wrong comment in mlx5dr_send Date: Thu, 14 Mar 2024 13:42:10 +0200 Message-ID: <20240314114220.203241-3-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240314114220.203241-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF0000000C:EE_|CH3PR12MB8902:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d8649cb-1f94-497b-202f-08dc441bea0b X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cRMKAZSXk7AtEAOfddLWjGQ2jeoNYO3kKNS3I2bD8VA5WcJMPHXuL6ESQLXCSM8RMfEexoQe/iLUw6nxRZ/k7lkl/0Z730uyLO2wQgWaeG3StfBqnOgcJThcpcNeEumwm3VbAxoCqYC+gdMkjZkgulx6IDCZZyPjTk8VPBe+nYg0OdDAAdHSb+laNFDAYOmzJGU/zHrx1Q2uusRf6VUt7d3njzbJHGPFU9FwYKw5/vRpGh2t0jRz5g3UWoyWVfiuz3NZzQO+MksAZ/QwmBC8pvQDmIf/EiZnic/loyQSz4XcSdx7BDDjqPisJjp+jTjlMxhlRX7IHFfAA8XZF7IUUB+3qLuhHDy5fHzud6FmljoLq4k3ReMTksHobWTESz9dId3ICMX5gt1eXLkFlIiC/bodS+NSkJyf+rBw+ipto6Bf0oASCxTTBR3Ijblqq6yq/dhovhOq4cLEHceMgHksu8QfGiTdbyw11Dr37z2l36udoDMGulHuMVRbu6irI5Jejxp2KwKV3RiLOy7BvjvU8SAXuQCfSww1Do4ry39sTponJhNg11zBSUfBXyiBmlCN3mIl3oDOQ9KQRDu6fsiEOdwU4WzXxbSU7f6xr1SOfpgyyrC8tW+KHVlR7/92PizSeD0RM81zZAj447Mo2Wj63qrOZKKjRYMtUBhR9/AABu07a+uw6FlpukOx9gEf2dkPc0Pjic6WpufgJCYWvIrRIOjtX+gDQ6fgVSRiM0pdTUxzeV2GZEb5/br/AL+9O9Dt2F5zW2lN3nzHGuPQJ5H5eQ== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(376005)(36860700004)(82310400014)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 11:43:05.9608 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3d8649cb-1f94-497b-202f-08dc441bea0b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF0000000C.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8902 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Yevgeny Kliteynik Remove comment that documents parameter that doesn't exist. Fixes: 3eb748869d2d ("net/mlx5/hws: add send layer") Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_send.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_send.h b/drivers/net/mlx5/hws/mlx5dr_send.h index c4eaea52ab..0c89faa8a7 100644 --- a/drivers/net/mlx5/hws/mlx5dr_send.h +++ b/drivers/net/mlx5/hws/mlx5dr_send.h @@ -203,8 +203,6 @@ struct mlx5dr_send_ste_attr { * value to write in CPU endian format. * @param addr * Address to write to. - * @param lock - * Address of the lock to use for that UAR access. */ static __rte_always_inline void mlx5dr_uar_write64_relaxed(uint64_t val, void *addr) From patchwork Thu Mar 14 11:42:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 138387 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4129743CA5; Thu, 14 Mar 2024 12:43:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3504442EAD; Thu, 14 Mar 2024 12:43:23 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2061.outbound.protection.outlook.com [40.107.243.61]) by mails.dpdk.org (Postfix) with ESMTP id 8EE8D42E89 for ; Thu, 14 Mar 2024 12:43:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qjja3TLrB1Ozz/6WrsocOylTWcQSJwba7hXj6fYtiSCAKZUDm1U4pGcuhcrqODwSbhtV1NKLbZPxRbK6G7X/sTR0IvfyMlvWtNCvUSlaQcERs4cil7AniK5p3ZzUH2kCV9GylvsCLXzPkufwuodjFFi4E8SAHBRk3FxiTjEYD6jPoVNw+kTHQ19P9LOiHslcrhW2P+1hSS9JZ4HN9fB2eTCv+9567He24Izooob8igwzfVUhHj4evRj03RbOyp22IZ3JrCgDXi6LfhRU6d91pikK9/FZoI1mTNbunYEKWUSqmw84CKweg2ibFECY+zQg73Ap6RhLePCHeHhCvBxgyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cuBzhutTkD9BFus82ufCUwEb6ahUTKmQ7XOjKwoEojg=; b=FdKGXJiOivlFr3NhoFBR5pHCyhXgSEK+PcNfy/1DxTCsLQ+O8IslhSvU7MtXHzArBGGfnAv40RetEUOFauzyvrayx/n23zj+rr1pr1mDdpmAncLapEMBbJCvK/NBXxdAh/xG7z94gWMhAStYxZGxVQiEeooayvkmrGvUkXVfIKSB8bpVhSB/eisuK0W+n5ArYHhuVkd3Tvm5gxC86cgQwa+1tG0ytBge4xQwRl2fTQCagnNSrp37kFBcBW6XRDPKqK9Z46aHehQtFIgQLe/CSR7ENQXmK77P+2Ml9JT61GioE3uP+Z20LmslJO8D6Qa5x2igk5Q+2mcfSL2zvj95mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cuBzhutTkD9BFus82ufCUwEb6ahUTKmQ7XOjKwoEojg=; b=AidvcTQuE/T6i8poly+HeH1rftly+rfeRIv15x8w4/EL7FdPogKiWBda5Gm4QJDA+Zn5V3LMjA6R6eF2q1Ch2UdNduyctxAKmLhfwpIuffqgwzw/GLxTCdd/vPI8+pY2vJ1PtCoSeHbyE8F9whej+q8s3DYUSiAqWH4ToxT/T3XXswZh9TD8Dw5khVp51+C2C96ZCFDD1EDXsgFN6uHVWvjnloz1P5AGzmX15FCLaOEnZBhL7NsPap0ynZXmnqnV3jiKrd4+d7ZnH7y2s5se4VsT2msXVEi+GXXvgnnLTByuxAot0lvqZxwVBnwy5jB1gDWZ4+92Vc4BDayrsHDGpw== Received: from CH2PR11CA0027.namprd11.prod.outlook.com (2603:10b6:610:54::37) by SA3PR12MB8021.namprd12.prod.outlook.com (2603:10b6:806:305::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.21; Thu, 14 Mar 2024 11:43:11 +0000 Received: from CH3PEPF0000000C.namprd04.prod.outlook.com (2603:10b6:610:54:cafe::98) by CH2PR11CA0027.outlook.office365.com (2603:10b6:610:54::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.36 via Frontend Transport; Thu, 14 Mar 2024 11:43:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CH3PEPF0000000C.mail.protection.outlook.com (10.167.244.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.12 via Frontend Transport; Thu, 14 Mar 2024 11:43:10 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 14 Mar 2024 04:42:59 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 14 Mar 2024 04:42:59 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend Transport; Thu, 14 Mar 2024 04:42:56 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Suanming Mou , Matan Azrad CC: , Subject: [PATCH 04/13] net/mlx5/hws: remove unused capabilities and fields Date: Thu, 14 Mar 2024 13:42:11 +0200 Message-ID: <20240314114220.203241-4-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240314114220.203241-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF0000000C:EE_|SA3PR12MB8021:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c42c8dc-8b03-42d1-5f65-08dc441becf5 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: akXHCfK2fZhieMSud2G9bPyI7akLZRbYCw+ifbMbAlhFjG1/euzMGalhnrcBJlBWd7iO/D8kcnPvnloi0KyyHX1Hqwu46XupfQ4pMEKL1AJwz4l/yysgEKNgZMb2cqEVfnyEfPAlt83QIfkdxrsPB6DY1Z7o3ibUPKvUWuk5QYQ+akrjTd20pFXIMQk7/G5NhbzmdPyz22oHwq7yDeRoBe+DwxXe0UPRoKU97xqU+SPfXNlt2+uJ/WcnQsnO4DK8pc1m1lKOLUysiTl43l9DErQZe0bzle4RA2WpK+581cK+92YeGVuf83It5LESYv1pLnbABiuGfdfkEByhLdWCQ7tkO2EGqbRs6GOc323tZOFdNpxrddYl1hKMlSUZDTh+ANsS7/CR9eU5DWYdw+YS9z6SGPW5+A1eSXzWUITcZFD7vC7WZkr/T8fvmTu8IZo7n17DSMRCc/QyglimzQ19fgAfLFT2In7D/7ClcaADUEXWi9LRkqHShfbJEGGrIEGUwMdcqMceVq8M76O5k7LboqNb1xvNJsQncoHpFf9XC33qlDyvqjRltEGK3i9ZCYdtCCxD34SpbbJU6lRCfCoUe3rhb5IU2Cj/JhtAiBAWFP4t4TQHZxn8mLpVMtkJCUJI2kBD60f127+VwI956DkpCAmcyU1VVi2Uo1vPlYIiQcCFEI1yC743PHowUzwUpYaPM2IfhApUs86eGfMHmWOakwOcX7gda5EWph9emqfIjsKX846dIF8ktjot4BgLNCXeWewA8mp96EyErjwaDi2e/Q== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(36860700004)(376005)(82310400014)(1800799015)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 11:43:10.8514 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4c42c8dc-8b03-42d1-5f65-08dc441becf5 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF0000000C.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB8021 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Yevgeny Kliteynik The following caps were never in use: - wire_regc - metadata_c - metadata_c_mask Also send ring's reg_addr field wasn't in use. Removing these caps and fields from structs and removing the code that queried them. Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_cmd.c | 11 ++--------- drivers/net/mlx5/hws/mlx5dr_cmd.h | 3 --- drivers/net/mlx5/hws/mlx5dr_send.c | 1 - drivers/net/mlx5/hws/mlx5dr_send.h | 1 - 4 files changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.c b/drivers/net/mlx5/hws/mlx5dr_cmd.c index 0e0cc479a6..666d678b42 100644 --- a/drivers/net/mlx5/hws/mlx5dr_cmd.c +++ b/drivers/net/mlx5/hws/mlx5dr_cmd.c @@ -1344,12 +1344,10 @@ int mlx5dr_cmd_query_caps(struct ibv_context *ctx, strlcpy(caps->fw_ver, attr_ex.orig_attr.fw_ver, sizeof(caps->fw_ver)); port_info = flow_hw_get_wire_port(ctx); - if (port_info) { - caps->wire_regc = port_info->regc_value; + if (port_info) caps->wire_regc_mask = port_info->regc_mask; - } else { + else DR_LOG(INFO, "Failed to query wire port regc value"); - } return ret; } @@ -1374,10 +1372,5 @@ int mlx5dr_cmd_query_ib_port(struct ibv_context *ctx, vport_caps->vport_num = port_info.vport_id; vport_caps->esw_owner_vhca_id = port_info.esw_owner_vhca_id; - if (port_info.query_flags & MLX5_PORT_QUERY_REG_C0) { - vport_caps->metadata_c = port_info.vport_meta_tag; - vport_caps->metadata_c_mask = port_info.vport_meta_mask; - } - return 0; } diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.h b/drivers/net/mlx5/hws/mlx5dr_cmd.h index 9d385fc57f..ea5d346d8e 100644 --- a/drivers/net/mlx5/hws/mlx5dr_cmd.h +++ b/drivers/net/mlx5/hws/mlx5dr_cmd.h @@ -194,8 +194,6 @@ struct mlx5dr_cmd_query_ft_caps { struct mlx5dr_cmd_query_vport_caps { uint16_t vport_num; uint16_t esw_owner_vhca_id; - uint32_t metadata_c; - uint32_t metadata_c_mask; }; struct mlx5dr_cmd_generate_wqe_attr { @@ -207,7 +205,6 @@ struct mlx5dr_cmd_generate_wqe_attr { }; struct mlx5dr_cmd_query_caps { - uint32_t wire_regc; uint32_t wire_regc_mask; uint32_t flex_protocols; uint8_t wqe_based_update; diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c index f749401c6f..d58fdb108f 100644 --- a/drivers/net/mlx5/hws/mlx5dr_send.c +++ b/drivers/net/mlx5/hws/mlx5dr_send.c @@ -729,7 +729,6 @@ static int mlx5dr_send_ring_open_sq(struct mlx5dr_context *ctx, buf_sz = queue->num_entries * MAX_WQES_PER_RULE; sq_log_buf_sz = log2above(buf_sz); sq_buf_sz = 1 << (sq_log_buf_sz + log2above(MLX5_SEND_WQE_BB)); - sq->reg_addr = queue->uar->reg_addr; page_size = sysconf(_SC_PAGESIZE); buf_aligned = align(sq_buf_sz, page_size); diff --git a/drivers/net/mlx5/hws/mlx5dr_send.h b/drivers/net/mlx5/hws/mlx5dr_send.h index 0c89faa8a7..48593adbed 100644 --- a/drivers/net/mlx5/hws/mlx5dr_send.h +++ b/drivers/net/mlx5/hws/mlx5dr_send.h @@ -114,7 +114,6 @@ struct mlx5dr_send_ring_sq { char *buf; uint32_t sqn; __be32 *db; - void *reg_addr; uint16_t cur_post; uint16_t buf_mask; struct mlx5dr_send_ring_priv *wr_priv; From patchwork Thu Mar 14 11:42:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 138388 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F1B743CA5; Thu, 14 Mar 2024 12:43:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F3BA42EB4; Thu, 14 Mar 2024 12:43:24 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2044.outbound.protection.outlook.com [40.107.102.44]) by mails.dpdk.org (Postfix) with ESMTP id 38B2442E9C for ; Thu, 14 Mar 2024 12:43:17 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GxqEcmT7KrIkvn97fdDAxN5zkwp2dm44u59HZapotuoPqc28ZCOydl0cDlj/gAoy0QhXhUwHyQO7bfNiZVXK734nQzypCQipdlYUYrzn6v0xNR0QjVTGEwVa+tPXcZURvUGjgWCXUVZTlpoUscK7F32xbb7rWbDDQCJHNnvSxu93xwuHJihC02G1wgs0OhGvFPpBMOKyocoU0D2LgFnLyuX6lv7wFS2rfTcasvyG7o/2PvbBMcA6zjuScvBt1tV1SWQFdOLF0I8s60F2W0kSOGDUH35kzT2UX6eCXbYebMRm58TCpAQes4iO1BwI5Dzu6WRg+W+xUZFRqV25LSB6kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dg8CYyZLCYkg9LxB3PxgWsBz7NUD10OcQyeraMVBi9E=; b=fK3AmYYsh3XKeemPuXa8AarHSVREeIKLjMbrM89/O77N0+lxk9sPb7+omDpoQAdu0qPqipBcrB5Q1blfRfAqRkNQiCEKrxfcVCNtOqLQvQVos8N91PM+Mr4lrlpHmql1BiqWuoEvxwtdSAoWRk2eQR1+UAUNQdJH4r97DPQR4ZwFIdVRRCmwXRKPEVbGO/BaynTFoeax0DLYNyJcykU1meqesQLaoK/5DX2c6Q9yV6ERUN31uZWg+4YPpT94DYOJkTxd+v/vG/FSH9QG/H25By1awnNpwgcDl7QWMg/jQDKPJDw+A97KXK7FslHREPtnpyf2T3FvnZPaUuV+UNR8qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dg8CYyZLCYkg9LxB3PxgWsBz7NUD10OcQyeraMVBi9E=; b=GtxEQu9YEvtymcbF27oyj7vIamSOiChAxcWK6Zdb6SZsk8z6VNOHjHcZyPF1GXtSURsky4aTrPbZvDaTtWGibonXtapfMUXMf3nf+6MAicTRbU6g3WW7fENK1VxqdXKgazjyn1XZ6awjri4+VEWLMKFK+eCJCVzS4f/Rie8RITZSOGR2bg0mB/C4j6w+hKClhS8O7xwCBjhHr/oBl6uOvUBsnpIWXOAG/9hhFU3DIC1yaoAzQMhMvxc9kLq57QDJladvXuSpLiaLBzUj6uj1vk9owVSCk/HqdYbUn3bcpphaC9jNPt3lxlDkcJZO+j82ze4ckmRUrmbqCOhY+p8kog== Received: from CY8PR19CA0018.namprd19.prod.outlook.com (2603:10b6:930:44::15) by SA1PR12MB5615.namprd12.prod.outlook.com (2603:10b6:806:229::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.36; Thu, 14 Mar 2024 11:43:13 +0000 Received: from CY4PEPF0000E9D8.namprd05.prod.outlook.com (2603:10b6:930:44:cafe::eb) by CY8PR19CA0018.outlook.office365.com (2603:10b6:930:44::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.21 via Frontend Transport; Thu, 14 Mar 2024 11:43:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000E9D8.mail.protection.outlook.com (10.167.241.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.12 via Frontend Transport; Thu, 14 Mar 2024 11:43:12 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 14 Mar 2024 04:43:03 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 14 Mar 2024 04:43:03 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend Transport; Thu, 14 Mar 2024 04:42:59 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Suanming Mou , Matan Azrad CC: , Subject: [PATCH 05/13] net/mlx5/hws: return -rte_errno on rule creation failure Date: Thu, 14 Mar 2024 13:42:12 +0200 Message-ID: <20240314114220.203241-5-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240314114220.203241-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D8:EE_|SA1PR12MB5615:EE_ X-MS-Office365-Filtering-Correlation-Id: 40010e34-11f3-4c18-b712-08dc441bee29 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MebJz4n7l48/M/sfxX+6K+huNPAgtF5xDj7XygySr27I2XcBE4k+C8HeRxZo8PVdj5zkDElsHOvCto1by9DHI9DGIP+fiDgo9DhVZWt2JxhMxr+FQIRzBXELw4DOcXyzEfJrS9GQAoF+iHsALc4BzM53rb64q5Oc2tOSdqHPA8qtST2ga+qmS/zmCbA2EBFeJBwJhx+/DekJkPpSRoopJpueQQYuMeC7r4uTJw2Ky19tGK2sw7dL9NIMqdLjrYv9bID0faPrI1+shHSN7kEb3N/ld6Kw0eRLOEKzMs+yP9/xBZ7ZAStD4vEl5rDrPXPqLJYM09eix4El5aElHzHUaY8D5/toWlTt3uHmPCUfhSQjB0l4l7zvsZdW9W/sYD/9LKwhIsRoXWN0UHa4rJs9A+gQHBVElqslHIFl9nNBt/QeDEl+EXHaqbVavy3f3Fg+5byc+VWYvHaCcinDwjIK71XPOr+5fPXroP7JxuR3WVL1DCM2/0TAqKGzd6R8s9XXfOSVfSuxRxTxr5uBvkX+FXTdbIQK7hzur256HuWFzuC0DCHxPbOv4iRYFlP0DDEg+tbAZibSQH6lWvR74FsBaLbqNfaShmFPudSJsvr8E0JbENzRlqXp7+9qfn2B9UYqIFWcnGEblZKxq2dgYgxY+Bgpzomdf0WEWRiG1vPoBr2HDnSL4Ioa0KF5HLXx696hqn6085xJd/PXVbsJ1g2vvtmfw5vclx+YKqPwNjz5oPRRjqUpKeYutyJfUmW1WmT90rRut0+TDyko1zZV2HDaxg== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(82310400014)(376005)(36860700004)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 11:43:12.9191 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 40010e34-11f3-4c18-b712-08dc441bee29 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB5615 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Yevgeny Kliteynik mlx5dr_rule_create returns -ret, so internal functions should return rte_errno on failure. Fix return values of the function that creates rule in root table. Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_rule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_rule.c b/drivers/net/mlx5/hws/mlx5dr_rule.c index f14e1e6ecd..7bcf2de55f 100644 --- a/drivers/net/mlx5/hws/mlx5dr_rule.c +++ b/drivers/net/mlx5/hws/mlx5dr_rule.c @@ -733,7 +733,7 @@ static int mlx5dr_rule_create_root(struct mlx5dr_rule *rule, free_attr: simple_free(attr); - return -rte_errno; + return rte_errno; } static int mlx5dr_rule_destroy_root(struct mlx5dr_rule *rule, From patchwork Thu Mar 14 11:42:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 138390 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0236543CA5; Thu, 14 Mar 2024 12:43:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F03B742EBB; Thu, 14 Mar 2024 12:43:28 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2054.outbound.protection.outlook.com [40.107.237.54]) by mails.dpdk.org (Postfix) with ESMTP id 7966B42EA8 for ; Thu, 14 Mar 2024 12:43:21 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ver5bGLYQ97F7rLpnFJE6Sj89AC8EwPU9IjfJET1JcyRB1M7q/QyCznGb459+R3mHr1ejABY/QLpm9auWeNU95+hdKEbLG9Tbn/DRUYUP55U1UDy1ZF3SkO1GG+5hQlfcGddWjjAMwdkhPk7tLYMtFrA2WWs1xilqZ1uRDOE2Ut1Vc4HyPAYvJau7I7EEaEMpafUH7y6xHKUFIyf8cH/R3kkURZVB9x6o5GCwjxfry6k32LV+8STWszzLFpjLaCDUSORHl2VZnDZTWFgLaKNqmUfCROf6kh1IDShDevsvlnzY/YudH++30pStkJeMQIAzKXaDEyJYZ/B2SAB377TTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cx06RviQA/BcyHoUJNh6LyGqfiZBMQWWd4HL5w4QWno=; b=T+mEuTJ9CbyRvi0ftEDnK9/6fxMxb+6ZMpnum2zDymhxm+ldfWJsjsF4qBuP1Xm4IllprkttlhBWra1jVFuxjX3duixy+C9Cogs5MeX1LmIRKT+7fOrBJHIEaAXHVDxphI24lvySdvfh4gUP2SyuatwOsep/ifuE2MqZsxj0FOeBScqeH3frC4xcYIhmcZm6Uk3UDH/e7vMUHHBQAcBXbm4EpxQKu6XgY5z7XRngrFGxBpji3SYSARK/bvRWlkqv1N3Ck6teiRa6L22gFTfKXXrqbvdGMZyIC7IgEQQ3HqNRXc6nG0fuOSrH0EuytTWtGM9dIV//cpJWgRebFmkNsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cx06RviQA/BcyHoUJNh6LyGqfiZBMQWWd4HL5w4QWno=; b=iwyt2+ntxZ0gAjxUU9ZrPE98KCkpeZtm87O0Zqfm6OP4TT83MyD33hcm+SndHQ301QpWLMXuGdsowz2vByIRMvgGj++Cxjm3NTLBeSjImf9pkzp4JaJw+7L1EA+2cNDe165dyQYVBy4bZ5Xj47E6JmoRZ4pPZlV5Ee5rsnshMhO1aPrIeQZ7hPO5ST5mLZ7+d4IlDxTacvsCx/njEmuh2BHwJh8vVEFYj/Nbj3xkJ3e02S45KbUkRYXB6BYqi11dx4JgaXMbhahiGIJeNzeC3Jv8/cLJommIPoHVW4NyZT3sZd7Q27K+tFBEPMGSGXT1leO2wRdzkZcSDjLTo9Ve4Q== Received: from DM6PR21CA0009.namprd21.prod.outlook.com (2603:10b6:5:174::19) by DS0PR12MB7725.namprd12.prod.outlook.com (2603:10b6:8:136::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.35; Thu, 14 Mar 2024 11:43:19 +0000 Received: from CH3PEPF00000010.namprd04.prod.outlook.com (2603:10b6:5:174:cafe::19) by DM6PR21CA0009.outlook.office365.com (2603:10b6:5:174::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.7 via Frontend Transport; Thu, 14 Mar 2024 11:43:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CH3PEPF00000010.mail.protection.outlook.com (10.167.244.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.12 via Frontend Transport; Thu, 14 Mar 2024 11:43:18 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 14 Mar 2024 04:43:07 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 14 Mar 2024 04:43:06 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend Transport; Thu, 14 Mar 2024 04:43:03 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Suanming Mou , Matan Azrad CC: , Subject: [PATCH 06/13] net/mlx5/hws: simplify send_queues_close code Date: Thu, 14 Mar 2024 13:42:13 +0200 Message-ID: <20240314114220.203241-6-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240314114220.203241-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000010:EE_|DS0PR12MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: 292d526b-3c5d-4760-aa90-08dc441bf1a8 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lgXFcQ5C4kT4VF13PeVyxVQis6WnRCWdhfV2k2jL726bhvih4RhW3r03wYMtVV2mNlKebAHIvlhcGrk6mspf3UzAL4wppS3m79ceb8hj/YM/85ghEQJOhMcxk2i9mgv1WtZqIRfzZlLG6BEIJe4x8aH0o1sepQMuZHfDPeABSyvys61ctFhZzhI9m5RvrsV6zfFPD80I3NipJ3t2Ui6f7EQcJDhC+89j+SYXxbXG7ZxS/qPZLTBv6TRCisfYKHtUZ8lEsvAyKKugkdO21k+MVvnL63WJptpNJ26vWaYVg4NB8N83JbA2PLltzSyX5sb1VNbuWWOv4H4o84YP6MKfzzPahrlbKwLZGMNKcEL69G6hU037Ypug7FquM0c+fO8RSBUQdiF3/qym3UD4wIy2TeBDgzaLkVqF8JMr7837LY76nm13J9C82JOaNoNlAhZquQrjQP2Wuh11cllW+rGKQJp+1hxy+pZyJ8uG5KMyiH/5ImiMxCsK+89wdzGMsTbVkl7/NFSq9BJIVl4X3+LX79UM5nLOgGx7jHdjdR9x5SZ4tagd0E+aLjUYstPElGSoE5D9aA0jemHwMIQ8uVVj2strzPyormKwwlREwiAYJncf/e7950OMHkWZvFjZdUZVMoL7N/iPcQaH9PQiyT5++iGOIpwJDaa4PfEvfU3wwp7ilMDx9UAbbVE1Mi1f1hvk2AMg/lC27EPy1MEDTAgOTL2jxlF8i+jN2ebqPyJj/9P4nAhHr/ZnYqwrHeC9jDExMwjDcjubq6KQ0IEH8cm9jg== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(82310400014)(376005)(1800799015)(36860700004)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 11:43:18.7373 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 292d526b-3c5d-4760-aa90-08dc441bf1a8 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000010.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7725 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Yevgeny Kliteynik Small simplification to the send_queues_close code Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_send.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c index d58fdb108f..d61862f074 100644 --- a/drivers/net/mlx5/hws/mlx5dr_send.c +++ b/drivers/net/mlx5/hws/mlx5dr_send.c @@ -970,13 +970,8 @@ int mlx5dr_send_queue_open(struct mlx5dr_context *ctx, static void __mlx5dr_send_queues_close(struct mlx5dr_context *ctx, uint16_t queues) { - struct mlx5dr_send_engine *queue; - - while (queues--) { - queue = &ctx->send_queue[queues]; - - mlx5dr_send_queue_close(queue); - } + while (queues--) + mlx5dr_send_queue_close(&ctx->send_queue[queues]); } void mlx5dr_send_queues_close(struct mlx5dr_context *ctx) From patchwork Thu Mar 14 11:42:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 138389 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5BBF43CA5; Thu, 14 Mar 2024 12:43:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB18442EBF; Thu, 14 Mar 2024 12:43:26 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id 3765D42EA7 for ; Thu, 14 Mar 2024 12:43:21 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=akrsxVe6tsp/FKKnEH1EB8s4Y8GwN+GAGDn7Clk3hy3PCAVN7VN1gYI891uzj/bwtYgjTPyYn29pcfXnet8i6HVsNH6S2gppIS8q+Ci4so0AgTgmSyrdeZg0A/EV6I58m3HatmT3V08Z+VGLIPi47Y574bIcg5XnaKWGliHBWHGgh7r5QnvIac3Dv0aiWXh1CRrh/G37MuMxH2AE88kS0MPzZcYmbWtIOuYK5HLdGgqMivbpG8YiGjHl8n5o9NKiyJue4QDyMa9kOifgqTgaxfPmNMJ8rM6qxt6CeildmBD7GeRK0BS4ya9LVedIE7CmETP6hpn5lzFS0NiUaqFgGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sgW1jkAGWHx0Z77s9w4NBl02zicMd+jDdHR4D2dO9/U=; b=N5r4JUxC0GMqMRvT3DcTZERxG10KX8Eg9UdzgcvRzv/szN5KcS+pAUaSTlIBySg74d0rahKIZpD2iftY8oYnVB/prDnr/yXsgwCahOwQNtEzTU47590kDZIcioDrvADoXCfHCxuJMOiu9M0aYWp9gdbDlcDYrQxoQFMKfKLuc3IlMzOqCKK1sIK1xFotzzbviT3+vqpzRaIiEHXxZw4xHJSGVptuU76bVMwSgoGoW7X4ScBCkkZN1pK8t/XGMQxysFbhwUTWsgMblx4cCAGmNKV+jkF07UArbusRyoAh37KA8oWpteYBNvR8faBG5aDZMoxi8G7i+LKz+xC2q11/7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sgW1jkAGWHx0Z77s9w4NBl02zicMd+jDdHR4D2dO9/U=; b=jopWKc1bn2k93P30aTdiV14MHNGr0a69iJqTmz8B/xWfciStak0tTM3t61z/yhHJFMg/vO3ZrnUz0lf58xPzoCeLYd20w7fNDvLh+MmJ7vX1JgphiSHUlum9tGLMrlSs2c77O82oM8RV6Wa2djV7n0SJmCyHvFLEyy3FSvmW+TOo1pIkahmHVc/wpXRFJ7NPp/jP0UmABmsSD4vzgoBbuVJgC37bOu70qgdKWMYWjFZR4vMljmEXyspJPL2yD8L3Dn7kOo2sAv/p016ArUIxRZvz3uVSms5EvXAiZYc9qPJ+QpNho+mTybECuaHLtfd574mn2eHpXfoEIGE9CgDaqg== Received: from DS7P222CA0029.NAMP222.PROD.OUTLOOK.COM (2603:10b6:8:2e::28) by MN0PR12MB5716.namprd12.prod.outlook.com (2603:10b6:208:373::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.41; Thu, 14 Mar 2024 11:43:19 +0000 Received: from CY4PEPF0000E9D5.namprd05.prod.outlook.com (2603:10b6:8:2e::4) by DS7P222CA0029.outlook.office365.com (2603:10b6:8:2e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.20 via Frontend Transport; Thu, 14 Mar 2024 11:43:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000E9D5.mail.protection.outlook.com (10.167.241.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.12 via Frontend Transport; Thu, 14 Mar 2024 11:43:18 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 14 Mar 2024 04:43:11 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 14 Mar 2024 04:43:10 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend Transport; Thu, 14 Mar 2024 04:43:07 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Suanming Mou , Matan Azrad CC: , Subject: [PATCH 07/13] net/mlx5/hws: fix error flow in mlx5dr_context_open Date: Thu, 14 Mar 2024 13:42:14 +0200 Message-ID: <20240314114220.203241-7-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240314114220.203241-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D5:EE_|MN0PR12MB5716:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b48cc3f-4b99-4c22-e597-08dc441bf16a X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Y9reQ4sps6kUoBpelo2uvtNb06URqQZ58AWTCNkBrVGTI64KRCvOVH0VuwdCSfY38vCdLUdlxc4TYSFrpLZxQ0hpDncrxHFMVT9q6T1q8WbLGokV7HgqEqJ/fa80e4yCLmIFEso2S0uj3aSMH3q7OkB0KkC8KcV4kG+1JFdYATYvX2UD8Kb1KKoqXt6SK7MNPlOYdKpQmplEYbwXEnPNgWg0uGQdw0GnsxGsVJYPqpBhVS4ezcFd4pptCzIJx6lKm1crDB+bfH+b2I9YMr+m6JOvFvAY+Mf4x2LS8NHW0DsxFToHEn2p3aYZ8EC+GmswTL3FhOvFnKNKOHCJ6B6vK5q/o4As8GHQeUri6KNMVfmhMOSe1eMmfCVoZ2J4jalPFQdWyReREY0GaQZsbC7+52bnheldl9626JilSrFynS/3EqbT3YZvvZ+8COkxh3HieFWUfBPC2+dbgXK48tcghrK5XG2YAlnGUHskCWn56lXGhU4uXXpGEl23bsEOjCVV4ELg1iN3kAlEC4YYLnsx2a89/5yEWZi82toPhZzYOtgKLHdrjoJ2WYZyyu+6z9ofobN55igW+bvIPB6J0jLIzTCVddUijOy/m1WLmvJNma/ApK9LoCfgS99Wl4y3zx/aXqfzutZyk9PipVfm4LVKSbKeGv/eZdYyaY6remuBXkAAHX9ciS220uNZPxIaOo7BDmnUEuVe8CbVtDrRbv79rPoRhi6KzN07kA3Ha1o1ma17oQpEb+9C/GTewCQRqKOHrKTNxO673fIVUVvYBEaxpQ== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(82310400014)(1800799015)(36860700004)(376005)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 11:43:18.3950 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7b48cc3f-4b99-4c22-e597-08dc441bf16a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5716 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Yevgeny Kliteynik Add missing spinlock destruction in error flow. Fixes: b0290e56dd08 ("net/mlx5/hws: add context object") Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/hws/mlx5dr_context.c b/drivers/net/mlx5/hws/mlx5dr_context.c index 15d53c578a..7f120b3b1b 100644 --- a/drivers/net/mlx5/hws/mlx5dr_context.c +++ b/drivers/net/mlx5/hws/mlx5dr_context.c @@ -263,6 +263,7 @@ struct mlx5dr_context *mlx5dr_context_open(struct ibv_context *ibv_ctx, free_caps: simple_free(ctx->caps); free_ctx: + pthread_spin_destroy(&ctx->ctrl_lock); simple_free(ctx); return NULL; } From patchwork Thu Mar 14 11:42:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 138391 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A82A43CA5; Thu, 14 Mar 2024 12:44:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F1E1942ED3; Thu, 14 Mar 2024 12:43:32 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2067.outbound.protection.outlook.com [40.107.220.67]) by mails.dpdk.org (Postfix) with ESMTP id DDB9D42EB2 for ; Thu, 14 Mar 2024 12:43:25 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OElncAeMDkZsvsKBJzZxtGPH5DvoQrgGSwJSbHzpsesZig4gRNRcRRzZMNxopm3PC54wRxCTN5TJoQ2s8a1gQpq1m+r8k/bxCIhmK0z99zpb+qM2auoRZ6VCsiJ+6bdWFQ2ekIGw4XcChidKFE3a+gLSq7sL/osFAsR3yIuxJSi8r4Wy9kS3OeYeS3hHYvpjoh1Mz6WoANtk4gpYIAa3jn2nWNKtqx0hidzQeemSRBj+gbT1N1gp/CSEelIqxhRnVvHXsCC2Ai7DVU+reIqWNYyUt+nWww3JawtdkDXp3WcQkhhcT/r8zywPvCf9z7NHyAEBV6KZSVs6LyUyZw7O1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=joWw8dgTN4HLo7Ibc02JRRIO18JJAARl6LVloO63wo4=; b=nGDfpEFj2HVkgqFXlu0s5LFeHoM0b6zrR2d0CvY+pgZPJ/kiV08xcWjEas+JJfaXjDWYQ2DKHHSJFfyfTNIR4EMH3/4n1RymF31F9z8ZBe31BTd75cDZOWeSdZkrXIh8r8Z6lzq8NEADurXB5oUSnsPzVThGXS46tOAJtqVGL3Y7v0yhGKXTSZf05a6arQqncxhQi2QHNb8qqpqrhLo40o/iSNVzJjgwSBI/QsGDRzgLTLoriMc4GHIGpU4mcekcdacqic3+l4R0MrEG88FJPFHa/DcVeRuopm0Wf4vjTfe+c+Vqn4MbNg+z75fQ/jhYz9VwvkNkB8k2/efFhrmUSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=joWw8dgTN4HLo7Ibc02JRRIO18JJAARl6LVloO63wo4=; b=gKTcCIf0dI0RgOG6W/jvmuadW943EtyPgYdMF539kDOUSvmtuZ81sbR1bLz5sNOPpYSN4ZZoReNP8bFI5KvPwAzI4MmdJ5UWiTelmhUl4zIevtroq6F4U15fjZAyCSNEBPHIsNVaS8JjgFZiXRRNPTHFweXaOzqk7/F4Tmbw4vIZXSe67Tqu3WSS5NGDDgLOZa4LsmvzY9Jtyu4yk80cKVlFrklt29N55uPH7S2Sj9kkPG4bYZnVDjGuy4uNRWPqLjZX+O+FsrhIR8Vrg5BziR5idBCrCr7GPJdFfdoV3jJgu6rKzOHkqQ8c+UOQz50qj7TJZk8rAfovlsF47A1zPA== Received: from CH5PR05CA0005.namprd05.prod.outlook.com (2603:10b6:610:1f0::6) by CH3PR12MB7521.namprd12.prod.outlook.com (2603:10b6:610:143::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.21; Thu, 14 Mar 2024 11:43:23 +0000 Received: from CH3PEPF0000000E.namprd04.prod.outlook.com (2603:10b6:610:1f0:cafe::6e) by CH5PR05CA0005.outlook.office365.com (2603:10b6:610:1f0::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.7 via Frontend Transport; Thu, 14 Mar 2024 11:43:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CH3PEPF0000000E.mail.protection.outlook.com (10.167.244.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.12 via Frontend Transport; Thu, 14 Mar 2024 11:43:23 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 14 Mar 2024 04:43:14 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 14 Mar 2024 04:43:14 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend Transport; Thu, 14 Mar 2024 04:43:11 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Suanming Mou , Matan Azrad CC: , Subject: [PATCH 08/13] net/mlx5/hws: fix code analysis error in passing 0 enum val Date: Thu, 14 Mar 2024 13:42:15 +0200 Message-ID: <20240314114220.203241-8-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240314114220.203241-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF0000000E:EE_|CH3PR12MB7521:EE_ X-MS-Office365-Filtering-Correlation-Id: f1f6b0a9-4e65-49ca-881d-08dc441bf466 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MpCpaNMqxR6V11sDU81zg8rnL2+kiq138BhuI+jHfOrWTvQCXPgrSDyZnSXR0YJVG5NdbWo353G2bVKvMYPI6HytE8QvNUuqrXuhZDQ5jc0tq2G8BrUFL8yCKfsjCTWrhPtzNyqW6PMyjgsnaRTcjbA9rIvfvTs4GadJbAsyFQlmYE3S+ghq9rsrOYql00Wzztv6xkepvdTgFcJzqz5cJ8tqNXFntVn6IJExcE/xjNxJRMZIdlOmlK7O4dDXWBSFZCvxMcecC7/Z/BYJj/CDIXl3mWXSVMriIROD70v8qHv3GY76pO35qF61cUvYqPsfXomQwnU/LI0n/MPqM6yiFywaAqlI+RaHi6St45d3GAqHpjGT8JPmF1vfoO3NEQ+jG3OYnEmFJDzGgrsAejYXFxRe1F4w+/DR4Ev7jQTmvfgdDKtujm6RWDOhLDBTzwmnAFtMVySd2Y4cD8NrfKnGsRDqbrlvKTV7h+gRgUtCOM+344BisFgveyWuNDZvEJH5PA+Fk2yUdw6xSSN1pdm+J8mhqKx6d6guPbbuZaBhoGLKtXv8FAT8MvGP8XPhdRrmftNyd2oqqrx1hflVQG3A8cjTt1LombuTlocJXMhm/huH3HjxJRlMccHQVH87K5FiAMlq8ntp9DEBzWbrNaY9WcKDB7zjnauDiwCUF3qj/2puy9PDz+YqK6bFOW+r99fSrZmQgSVGqXWcBHBWdDzVksmn68CERvj8RIgUCRqy5rxZnRKMbKMyhwGehpv4T/IpRxt8yK2IS2K4p/w7nu6KfA== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(36860700004)(376005)(82310400014)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 11:43:23.3372 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f1f6b0a9-4e65-49ca-881d-08dc441bf466 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF0000000E.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7521 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Yevgeny Kliteynik Instead of passing 0 as an enum parameter, define flag NONE. This resolves the following code analysis error: "enumerated type mixed with another type". This value is currently used in tests only, and will later be used in backward-compatible steering API. Fixes: 5cadd74fbc08 ("net/mlx5: add HW steering low-level abstract stub") Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/hws/mlx5dr.h b/drivers/net/mlx5/hws/mlx5dr.h index 80e118a980..d2c426e679 100644 --- a/drivers/net/mlx5/hws/mlx5dr.h +++ b/drivers/net/mlx5/hws/mlx5dr.h @@ -82,6 +82,7 @@ enum mlx5dr_action_aso_ct_flags { }; enum mlx5dr_match_template_flags { + MLX5DR_MATCH_TEMPLATE_FLAG_NONE = 0, /* Allow relaxed matching by skipping derived dependent match fields. */ MLX5DR_MATCH_TEMPLATE_FLAG_RELAXED_MATCH = 1, }; From patchwork Thu Mar 14 11:42:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 138392 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DD4843CA5; Thu, 14 Mar 2024 12:44:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4393342ECE; Thu, 14 Mar 2024 12:43:38 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id C7BBC42ED6 for ; Thu, 14 Mar 2024 12:43:33 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P9cHaaL4DpTTJsZ29CVQHl0ev6thzDAG3knuNkpOQ+aYvUzE9AH4omOkIEgUai3AV0DERdEAXkgQ43puy69fIho6I7fQn1TtLI68We3SaLITX4DrnWL8F6UICKSiyV1CT7tooShPfO8GwP166g4vmVVNqheocey3ShvNVEzNLq+wrB5cHs3uw+ojwlMq/Gvb3qDB7AzpofDa0QHxu96GaAEk62a1ecqSPueZvk9Xntk7dkxr8Mp3a2div8U389OQX8FPG0SunW6iuSKx1XwCe6ubZuyvnsTSlQyzKRSXyPX1Uvm9OaN/WGTk6/V2ou7zm/vr+/VrFnEpsPAJv7p8+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1RxP9ZFL5dYilofDsNEiziT7c8u0vExtHQFnD8chL80=; b=OXJfMetFWhJpSZr+RmEF/f8QbuwRf53ae30HxGBuZHxErbgAJZvwsSyDJtjlU9u6GyY743dPjKxvWdDCEqGIRO3LPvDPP8EurYT5ias5DbIDazFN5HFO7Piy6UsQHwojFJRJ+3leXImS/nf7Wk2PCFMw2bxap91LJL2A4k6T/his6PbtGW/eI5i7zhp6QPU0s0IrIMgepcVlOkSvL6O2x4W6nrdcaj+J0hguasp5AyeyD8bCcux/ccJcg4l4mEFS0Hu4zTU8pFf8XgWwLQLwx7xv6XjjUJ0niEqNBKBskYYcAKc7/YemtCQqRP0OATZEARXshGQoNohJLrdA+Qn0SA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1RxP9ZFL5dYilofDsNEiziT7c8u0vExtHQFnD8chL80=; b=XlU4bydQWkqTaKoNvBsHUEVbnkjipgYNeqKEUaK8iSIwK6iIkWRJfKJgK7o7CTEJe95Ft3w8rIt/BTvkBk8YZ+kO9umt1gbSAvitOT3GiTpGBu7Rzu85L3Vy3/CqRSgIh1vmvpbaDwBXqBEVnZPQHdqKew+5WY0Qi/6aKTNGyAzKP9g4//SZMDfBR3Adtg5oDwkC3opBXSELmGac1kma5ks/jCtFOOpfg2Tk/0b2D1qSWu4Wz1M9sAdD6dQeuFad2uHjFC3Cx902XG0eFTQa7e3iMm8Th4bXi+ILXyalnPIr/Iff8/DU4AdSJB/X4DVo1hwKckumK2udi5iiiKmEow== Received: from DM6PR07CA0102.namprd07.prod.outlook.com (2603:10b6:5:337::35) by IA1PR12MB6652.namprd12.prod.outlook.com (2603:10b6:208:38a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.35; Thu, 14 Mar 2024 11:43:29 +0000 Received: from CY4PEPF0000E9DA.namprd05.prod.outlook.com (2603:10b6:5:337:cafe::45) by DM6PR07CA0102.outlook.office365.com (2603:10b6:5:337::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.21 via Frontend Transport; Thu, 14 Mar 2024 11:43:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000E9DA.mail.protection.outlook.com (10.167.241.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.12 via Frontend Transport; Thu, 14 Mar 2024 11:43:28 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 14 Mar 2024 04:43:18 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 14 Mar 2024 04:43:18 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend Transport; Thu, 14 Mar 2024 04:43:15 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Suanming Mou , Matan Azrad CC: , Subject: [PATCH 09/13] net/mlx5/hws: simplify code for updating CQ doorbell record Date: Thu, 14 Mar 2024 13:42:16 +0200 Message-ID: <20240314114220.203241-9-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240314114220.203241-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9DA:EE_|IA1PR12MB6652:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ea0e43d-5dbb-4737-1747-08dc441bf74f X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p/tsuGWD9hIvSiv197RdB0+BSeVoFd0rX/qir9bjpWhfv0uw3fN5kA8VO8w4NhWLy3CF2uEbpQ8Vhzpzg4n5jmhHM2oKSjQKx6JvFH0or56Uj/ZXM/9+PbyaenUbkHU13H457X2o91XvVBKoOJ0mA/9eIitDfY9bNMRLNZLzOfU54z0RYGXczkL21Xvy9MzNl1Yh7aLjFPlPAqC0bKPrlR+ZPu4bmuipWi0tthXkn5CbiCDP9nz/RU6Vgynz57ghmOJrjXrVTQ3YJAym2LC4BqLGL9Md+WcaZlP7ysJVsWx6f3k8J7tYT+R1OBV262QlQ33EgE0W/fzb+z4XN20hPCU2AlaMOlBwgKe+YwXmfF6to1Gz71zq5hbE3qbegDjd9WL7PfzVGzfE+vgTbWTDQ+lSCVTNLsuF3MrEBT4xxmebNHMANsm9ccwKVtJT0CSvKza4QErlXn7icg0Ok2NNdG8bubTplxWpDF/blxMEqWJ6CoYeXx1BChmNMFwFYyHsRr9CB5mAh6KiJ5AnKsfooayskdLfId6aZ+vKkj73Mh28lW7+5QcoDMe+BdcnDWXNgh/nEVTTlsZlg4yP61XdSDR+tLKE17+Wa0Ilnyk2CWeM++SmI0lRd3oinxYpYYp53SLxmqlyjM10XQfxVApyjoaMl3QjyeNprefqSH673nnOqK0b01dzcHfSlH73vnbP0EvGo418LwAIogB54XL0xQvKxwhSssBVQn0EIcEvcqpUxtbnTMU1jKzXSNeJ//VD5khpImLg2Ppl9uTfLzgcjw== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(376005)(36860700004)(1800799015)(82310400014)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 11:43:28.2635 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8ea0e43d-5dbb-4737-1747-08dc441bf74f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9DA.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6652 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Yevgeny Kliteynik Simplify the code that does CQ poll - have DB record update as part of CQ polling. Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_send.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c index d61862f074..2942668e76 100644 --- a/drivers/net/mlx5/hws/mlx5dr_send.c +++ b/drivers/net/mlx5/hws/mlx5dr_send.c @@ -594,7 +594,7 @@ static void mlx5dr_send_engine_poll_cq(struct mlx5dr_send_engine *queue, cqe_owner != sw_own) return; - if (unlikely(mlx5dv_get_cqe_opcode(cqe) != MLX5_CQE_REQ)) + if (unlikely(cqe_opcode != MLX5_CQE_REQ)) queue->err = true; rte_io_rmb(); @@ -611,6 +611,7 @@ static void mlx5dr_send_engine_poll_cq(struct mlx5dr_send_engine *queue, cq->poll_wqe = (wqe_cnt + priv->num_wqebbs) & sq->buf_mask; mlx5dr_send_engine_update(queue, cqe, priv, res, i, res_nb, wqe_cnt); cq->cons_index++; + *cq->db = htobe32(cq->cons_index & 0xffffff); } static void mlx5dr_send_engine_poll_cqs(struct mlx5dr_send_engine *queue, @@ -620,13 +621,9 @@ static void mlx5dr_send_engine_poll_cqs(struct mlx5dr_send_engine *queue, { int j; - for (j = 0; j < MLX5DR_NUM_SEND_RINGS; j++) { + for (j = 0; j < MLX5DR_NUM_SEND_RINGS; j++) mlx5dr_send_engine_poll_cq(queue, &queue->send_ring[j], res, polled, res_nb); - - *queue->send_ring[j].send_cq.db = - htobe32(queue->send_ring[j].send_cq.cons_index & 0xffffff); - } } static void mlx5dr_send_engine_poll_list(struct mlx5dr_send_engine *queue, From patchwork Thu Mar 14 11:42:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 138393 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7E2943CA5; Thu, 14 Mar 2024 12:44:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C08B242EDB; Thu, 14 Mar 2024 12:43:39 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2085.outbound.protection.outlook.com [40.107.243.85]) by mails.dpdk.org (Postfix) with ESMTP id 9D6AA42ECC for ; Thu, 14 Mar 2024 12:43:36 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E/AZe/hmudDjfQS08rhrEOmNtrqQy/Ebh+WyU/EhIchMyAIJaae8qVHQRCvXHBzwRgkRxDVYg12/539MHhiNfK2YzmjpDeE3ziNC+Hr8r2+g44OR1sgaVQ3jfKvmISXi8PLfXZfUPzuh40stqS03LZOpOQSRFV/1txAm9mt2sMWBU+AXHtPWFqdtWz7IFoClEkWQjPIPsV+DCFHLZ7unCjcFO7Gu8jxtodDMgpANNS0qbkCq/furQmY8cck8nIaHMXaWUqB0nRVeYd3dJokJYaNvIN9PNPF2qSD9lqHkdYPgq+FZ0N0odkiy0Wx0Uhz4HzLuiZBZ2vzs24fmgJyDnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NQxJgIlO1iuKcyHGuqLuf6ZWEg488S1jViRG5gr1qs4=; b=gNoH0Rd3I+7hIiFv9FRPxZOoo4szJOkbtG035/u6fwQpzOwZh+PhPdbYZ8WKcZ5XaRANTaAZ6KYSBg5D0TBfVZkUjcpqdkVmdjIPx48cMqHEqGQ6HFfn0P1qhZl7VXtW3HQ670kNg9tv/G1BUz99ce9F44pD7Jw12CRvg/UwlVT6bxwG+NEYoB/m2bcrEQuM0GUDW7FgAuYPzJfdpxnVXFYLzQD1hyJQw83CJIGOreGxxOTD7SgVPXxICPrQCV0v16hA9nS10qWdNoGW7wlqHyhuTzkzNW0ayFmKiq4dQcWDCZayvKO2xSq+ClWXxf8okuOOA70bFw9B4kKpANH2bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NQxJgIlO1iuKcyHGuqLuf6ZWEg488S1jViRG5gr1qs4=; b=MT9jQtVrj4lbBUAMj9oFE8noV4OiY5shyzhHvj1s7VMDvv1QPZjXxGuTCcINs0D6H/VwTf5Il3ISLAsAubc+VTcEv+aKLrRQ4a9BJaf2hGAXjJ996Tta7uGkFc3069RQw/yVCm91wb/uZgz+vRJNXNMwLeop1VTqZwbjQl1OnN2c2mFtPDPbCjkCmI2PD8dptehGiGSlV/F63dq+4qScgASYDtGe9Lt+v2ZqjpZkhj6jFzS8RPWb/mcs/x/1vL4f031yDeZPFQivtlNcpYxJ6n/V6dtz6i3oPYamwMMjYHsEvWPfkWUKksKfX683bjLAm1TwpPj3onU+sPZtZJngEA== Received: from DS7PR03CA0167.namprd03.prod.outlook.com (2603:10b6:5:3b2::22) by MN6PR12MB8514.namprd12.prod.outlook.com (2603:10b6:208:474::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.33; Thu, 14 Mar 2024 11:43:32 +0000 Received: from CY4PEPF0000E9DB.namprd05.prod.outlook.com (2603:10b6:5:3b2:cafe::b2) by DS7PR03CA0167.outlook.office365.com (2603:10b6:5:3b2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.21 via Frontend Transport; Thu, 14 Mar 2024 11:43:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000E9DB.mail.protection.outlook.com (10.167.241.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.12 via Frontend Transport; Thu, 14 Mar 2024 11:43:32 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 14 Mar 2024 04:43:22 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 14 Mar 2024 04:43:21 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend Transport; Thu, 14 Mar 2024 04:43:18 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Suanming Mou , Matan Azrad CC: , Subject: [PATCH 10/13] net/mlx5/hws: fix rule is in resize check Date: Thu, 14 Mar 2024 13:42:17 +0200 Message-ID: <20240314114220.203241-10-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240314114220.203241-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9DB:EE_|MN6PR12MB8514:EE_ X-MS-Office365-Filtering-Correlation-Id: be9e4b3c-a756-4331-0395-08dc441bf990 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EI50Wio1Lb1rgT7iqvW/P3Q9cTis89llMK4Lk1hhv9//vyqp5Ovt+xkRUfoVZkwAjuuNZI/nnQa1QkjPUuOnHAP9VS6aFsb1ZWyKTnTsaoHbnoeX1Z6rjCb7NNKLYAvjvC07QIubaE7+C3YoHO3H5FtMy7Ai+TvEI6Z30p9/QX6r7diV4tb4PFsfq4HsO52IGzfPbq+5TTyQZMrqGauMRqSV9w6rxK5APLd4wrfuiF7fVG53WzO9sxazGVEfpb55WJurUyHBZ7ujOkEG9YzC3dskZyPsVq8MtHvLTXBjWanFreFpLlewvrcbknFF/qvvwKI1jdtlJpDMZRPUW+LZazygFSM76bKROatPPR/tW7QMqvkRTkeCdcCFkOzjLE5oVN8Gv47wsGieaz4JztxihlrFfLgs35ZOeKw6eQxb4AS7vynqwRSSCpU/91xh/zfOKtplpvOVl1mIoRTHcUayO7E4bSefRAF55BiQlGyRe9+VjWNwEbSjruk1IT9l/OgafUyWs7waAQAi7YO8jBXu5YSwbbQupqJogp48ewvpPio86JAZV3s+OIUaRj+RyvDqlbOWJDPI/t33wogewYPhHp9QPaLxzW3v5wR4inyLsBIMgRGkY/aY2CHHxpphKMRQzJ7fucqcN/2XCOlxQWOeL+I7kV39GoTkNCXkuipL3DtkHOk/GkYLc5dwGAilPspsTo27Yvqgqf9rapzgsgP/hTMSiemd2m1mMwX/cCM15LKn90/hvZ0mCffI95T389PVr80yp/nDawOGaP74cBsgZg== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(36860700004)(376005)(1800799015)(82310400014)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 11:43:32.0444 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: be9e4b3c-a756-4331-0395-08dc441bf990 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9DB.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR12MB8514 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Alex Vesker The check to detect if a rule is in resize was done incorrectly, this can lead to an incorrect function call upon completion for rules which are not in resize (move). Since the resize_info is in a union we cannot rely only on the pointer value but also need to make sure the matcher is in resize process, this assures us the resize info is valid. Fixes: 762feceb8294 ("net/mlx5/hws: support resizable matchers") Signed-off-by: Alex Vesker Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_rule.c | 7 +++++++ drivers/net/mlx5/hws/mlx5dr_rule.h | 6 +----- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_rule.c b/drivers/net/mlx5/hws/mlx5dr_rule.c index 7bcf2de55f..3e8e90ba76 100644 --- a/drivers/net/mlx5/hws/mlx5dr_rule.c +++ b/drivers/net/mlx5/hws/mlx5dr_rule.c @@ -350,6 +350,13 @@ static void mlx5dr_rule_move_init(struct mlx5dr_rule *rule, rule->resize_info->state = MLX5DR_RULE_RESIZE_STATE_WRITING; } +bool mlx5dr_rule_move_in_progress(struct mlx5dr_rule *rule) +{ + return unlikely(mlx5dr_matcher_is_in_resize(rule->matcher)) && + rule->resize_info && + rule->resize_info->state != MLX5DR_RULE_RESIZE_STATE_IDLE; +} + static int mlx5dr_rule_create_hws_fw_wqe(struct mlx5dr_rule *rule, struct mlx5dr_rule_attr *attr, uint8_t mt_idx, diff --git a/drivers/net/mlx5/hws/mlx5dr_rule.h b/drivers/net/mlx5/hws/mlx5dr_rule.h index 07adf9c5ad..dffaec1c0f 100644 --- a/drivers/net/mlx5/hws/mlx5dr_rule.h +++ b/drivers/net/mlx5/hws/mlx5dr_rule.h @@ -72,10 +72,6 @@ int mlx5dr_rule_move_hws_remove(struct mlx5dr_rule *rule, int mlx5dr_rule_move_hws_add(struct mlx5dr_rule *rule, struct mlx5dr_rule_attr *attr); -static inline bool mlx5dr_rule_move_in_progress(struct mlx5dr_rule *rule) -{ - return rule->resize_info && - rule->resize_info->state != MLX5DR_RULE_RESIZE_STATE_IDLE; -} +bool mlx5dr_rule_move_in_progress(struct mlx5dr_rule *rule); #endif /* MLX5DR_RULE_H_ */ From patchwork Thu Mar 14 11:42:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 138394 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A761743CA5; Thu, 14 Mar 2024 12:44:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3234542EC2; Thu, 14 Mar 2024 12:43:41 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2066.outbound.protection.outlook.com [40.107.94.66]) by mails.dpdk.org (Postfix) with ESMTP id F096342EDE for ; Thu, 14 Mar 2024 12:43:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bWEED6d82g27TANZY3i5+FfQB8yk8kThCxq0L0vK59n9eCoql45JvLxZTufnLwGUfQ6Dru2PLGYo0E8OYUMF7lpVGtFM0K2SBllecgGXFnxqA1RHZleb4RndxsqB8tBPrUHYlghRfD1sPM420hO/zWzyV1yfW0YUsZhZmYU1wTBQQ1M3FG781juPr/+H0SWIhA/8ENpVvFYoNWT5uUx4yb2Doc9kRfEvuqjP7QhNI5ncbsceLR/JaD3tfL2cfINoupE6ppj/7VBb5FndZKu3JISJuuORLC+ZMDpDJYSYGltSJvrW/QVddxPl8kGnzkIZXcXlw77l+SqI07lNW5eydg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l6ZBDlAFUIFFS+L/GCPkVhf35fx2Na82QiBLT+YCVu4=; b=mS7Z4ZCwr1q9XRgsjeztw5vsVD15m8lT1YLYAXC0Sz8Z+qCaoM1tOsna2Z3Wb9KuY5Fob+KqB5VPkJwkhLHFGpeCZ+B3EsHjdwYHQQrbUpCp+FYJnMuIJYedh58gDVoHQdvDsayWZn3PBbXquipj0i+xDxSyaQcgTwFCbh2gpYrUkLsMrG+NUFzDx6hMKgUZGREQGxYwYa+nM5QyQa7bJXs1W4RxHJuPmFwuntSOGdOfD2R+MSIooDb0SaK2lNoZvNr+wIsEzJChdo7gjQ1ah02eZi+hN0JFt6Xc4DLfJ8gd//w/ZaLoFmezmasM4S4/2+sUWSAAb+ZU3/EY4T6CXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l6ZBDlAFUIFFS+L/GCPkVhf35fx2Na82QiBLT+YCVu4=; b=oMYQJHbeZwlJtgVS9E8/R1JP1vTO10Jdy4qx/qM1YGhrW1rtBKrtzZL+katFWTVGgaA7tkJtzyqtqi2gm+TlCURNu2LR2gwNnOtlthGeuf5nuPTQOQwj16Bl5qoqtH2/aqGMfXmq4koScw/2XKA9jrUXIj/nzXDO7X3CrfTwVjOt+GAGFhcMDoTyVJKIqt718mCtwugZ/1Q+IuYemvf21Y66PDKHVANX7SWqZ0N8Cu6niWIfpXiQMAXGdLew9KIoMrgmpApk8pRp7GWPcCJ4wMs6fFU9XIJ9cdw7yHDMyv+EpHI2Xe74ptGRu+LOtYZffiigSWi/cAv9KxrpmC54Hg== Received: from CY8PR19CA0002.namprd19.prod.outlook.com (2603:10b6:930:44::11) by PH8PR12MB6843.namprd12.prod.outlook.com (2603:10b6:510:1ca::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.19; Thu, 14 Mar 2024 11:43:37 +0000 Received: from CY4PEPF0000E9D8.namprd05.prod.outlook.com (2603:10b6:930:44:cafe::e6) by CY8PR19CA0002.outlook.office365.com (2603:10b6:930:44::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.36 via Frontend Transport; Thu, 14 Mar 2024 11:43:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000E9D8.mail.protection.outlook.com (10.167.241.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.12 via Frontend Transport; Thu, 14 Mar 2024 11:43:36 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 14 Mar 2024 04:43:26 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 14 Mar 2024 04:43:25 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend Transport; Thu, 14 Mar 2024 04:43:22 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Suanming Mou , Matan Azrad CC: , Subject: [PATCH 11/13] net/mlx5/hws: drop at attach number of actions Date: Thu, 14 Mar 2024 13:42:18 +0200 Message-ID: <20240314114220.203241-11-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240314114220.203241-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D8:EE_|PH8PR12MB6843:EE_ X-MS-Office365-Filtering-Correlation-Id: 94b17101-3b7b-403e-9a50-08dc441bfc5d X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /bKSWgiZ87X1bZgCEpTgXbLmZ+COVvSsJCV4lPlbrHI4q7H/8dOLOX9cAeLLgJUYRF2oKp5HP9qIwWADjDGkMlvhAkdi3tvZd1tmmNPqd81PKuIXFkK1ZS8kCWTWMzC5QbpIJByWNb7eRQ7ZC3OarQoj5/D8D8ojhJiilV7+qGnUWJyWyUDI061HFLQQSVpKrWEJVdr2byMUIPl3nS+wiT/3bWdtc3VjfSjFOasUMHBqvL6F5vdGzIP9Ljxc2+q4wYG79Tz866aHiHmi+QHJrDf+pRfslsyul+McFNN5UxcYdpM3Gw4qY2/p3Y3xvdUU53mE9tFVJELrPxPTM3qKuEFM+URyx66coZTMRzR3amLoHkQKQGMjeDhDqILtwElOLEubuigzjgLHmEeEYj2x5zrOOIOzGOXE17iYucvRjgRich4zsH3nzhm7IPzO1n9gScbxH9cQv78sq19qyL4fejeePJ52/YetlRfFMO9RhYQmFrwQE4vDIJcP6wcjhhTsH7Ko6kGyB5sz1XrcSRvKkwTPnfO06zw9G6hxbBUYq5K6XS2USRqiDaHWIUdRb+lU4kv/sHkqVynDvoQ50OyIx0DzoXrUrVllZszCn1t02Tk27UyO1Tg+WYN/hbWBNM6m8qmiRItqbTwZrYHqrTy1PshND3K9Li+a+DG1S2VRYHq+FeNrzQphiDQaj1QAJldUqMbBsRN+cj+xImPMi4rpq5Tx0vUtvhgrIJGbkoaYyxG1UUF6MZBWSYlM856Bp93jaeGlI2gvHoNsI3LjmRO/cw== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(376005)(82310400014)(1800799015)(36860700004)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 11:43:36.7471 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 94b17101-3b7b-403e-9a50-08dc441bfc5d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6843 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Alex Vesker Requesting the user for number of action resources is not defined well enough, instead the user should provide an initial action template which should contain the future attached action templates. Signed-off-by: Alex Vesker Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_matcher.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/mlx5/hws/mlx5dr_matcher.c b/drivers/net/mlx5/hws/mlx5dr_matcher.c index 1213e7f0ad..78d525e578 100644 --- a/drivers/net/mlx5/hws/mlx5dr_matcher.c +++ b/drivers/net/mlx5/hws/mlx5dr_matcher.c @@ -785,6 +785,13 @@ static int mlx5dr_matcher_bind_at(struct mlx5dr_matcher *matcher) if (matcher->flags & MLX5DR_MATCHER_FLAGS_COLLISION) return 0; + if (matcher->attr.max_num_of_at_attach && + mlx5dr_matcher_req_fw_wqe(matcher)) { + DR_LOG(ERR, "FW extended matcher doesn't support additional at"); + rte_errno = ENOTSUP; + return rte_errno; + } + for (i = 0; i < matcher->num_of_at; i++) { struct mlx5dr_action_template *at = &matcher->at[i]; From patchwork Thu Mar 14 11:42:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 138395 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47DFC43CA5; Thu, 14 Mar 2024 12:44:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0AD9842EAF; Thu, 14 Mar 2024 12:43:50 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2083.outbound.protection.outlook.com [40.107.92.83]) by mails.dpdk.org (Postfix) with ESMTP id C4A3A42EE4 for ; Thu, 14 Mar 2024 12:43:47 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NrpjclTLGiseMxcAMbixuFiHyw5Rjilpr8UxdneZFWeHIvkl2Q3a49rkSVKK14IgX2H0U4TOJrKsJkfP5viX9wD7mxSisqCVpdDoYg8O9/CpcUHRhqY4iGvmj/+1EOu9W2MiTP1RRkcWf+zdV8S54x2JFghOzwzhCSJjciEHD1G2n3fHY23wWqs2K84gHedXsv6/8gxzCqf+pSICmcTFz1VqBSeXsLHinkxgmMQ8sruiRp22zEqSnZzkZa9fOVf8kSRnEZ7ZRrPS2XeqgMDWnonqfKpIzJ3AbHqGlhBi2bKi6Iy4W1TxX3iFA54Ag5uo61FQBPDDZf0REZ+P/9PY+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5RXSfAXvJ5Cy7G2gUulUEmejxzyCccaNk7J+hVXIZBM=; b=WZGoSjIVoBNBdxrLdfYiuzGN2jbOE4EnLXRNSQrDoz+ZMTToBfXlZGfF4ZIt76c6S4AE7crz4yoPFB8XuMvjUP+EobL+sola88sNmQFXGEsQxVN5m5jaHH0QytjXmp9oxSEQ5zX6/Mjqkf/J9iT2iu75U5RehzStJwh4sY5fOCRkjkn3n8ss8PNDYTSybDKO1jsOMKmzj18vqbkFheBe/g/lVBc2vWgr0XpxkEo49OI4b5MA56bm8Rm5f4Fjbgxw/KGLUaIJAaBEXLNXuKN8UI5SQ5bAOai5+gDMLuaTShmtAuc/BKaXFtQ4nZU6G4NyxciiUST72TDi2DgId4RMJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5RXSfAXvJ5Cy7G2gUulUEmejxzyCccaNk7J+hVXIZBM=; b=Ohb8LgiFXxRjKCak8N43mqpjLZN0yD2j9V0xHQEsCzbCJHImD3HIuxQphTWF4H8TSjVW+vqI9pPZ9jjsNUW83sTqxtQPKGEdPHdZtck6Ha5Fw8kXZZsu0H3k12YCJ5Cp0qAifuiZlqiN93vDPuRA+86jcqZvram8iKThry/WLyIQ5ZqsTEuiSMTZ6w8L3zjptbqYExugiSvPnSFz86XI/x54SkDPXdLfvpLQcvgP0Xran37V3Vj5dmRnzwFmsvNDJ8mjQaVGGfd4v9WrKncULB5DG25D4mJShZbSUcyFOLI9DZJTmFSGlvvd/2LXBQIs2ih2TOim/lolRgI6z03Wig== Received: from DS7PR03CA0179.namprd03.prod.outlook.com (2603:10b6:5:3b2::34) by PH7PR12MB7257.namprd12.prod.outlook.com (2603:10b6:510:205::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.20; Thu, 14 Mar 2024 11:43:44 +0000 Received: from CY4PEPF0000E9DB.namprd05.prod.outlook.com (2603:10b6:5:3b2:cafe::f3) by DS7PR03CA0179.outlook.office365.com (2603:10b6:5:3b2::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.21 via Frontend Transport; Thu, 14 Mar 2024 11:43:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000E9DB.mail.protection.outlook.com (10.167.241.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.12 via Frontend Transport; Thu, 14 Mar 2024 11:43:43 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 14 Mar 2024 04:43:29 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 14 Mar 2024 04:43:29 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend Transport; Thu, 14 Mar 2024 04:43:26 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Suanming Mou , Matan Azrad CC: , Subject: [PATCH 12/13] net/mlx5/hws: extending tag saving for match and jumbo Date: Thu, 14 Mar 2024 13:42:19 +0200 Message-ID: <20240314114220.203241-12-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240314114220.203241-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9DB:EE_|PH7PR12MB7257:EE_ X-MS-Office365-Filtering-Correlation-Id: cd6fe8e9-1657-4fb8-6120-08dc441c00a6 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /4+0SVaEySYF+L35P5G4aKyv3rRXeJE6s8I3NIgQOPeu91Uzq75srMbWfNxPuiIbzQ2fakHyQd++q3V3vFcyofF2ys0babQaeSBalPkZR08zouEOouGhDq1Jhx7fABGNA9LujP09exru+aolrUlgjISSZ8nQdkWCB2gUaL1l+sIKCGQ6eHoQOMl7jN1m9EpIYd7Qlbgy8KCPrpX+gnils5LgYxeQJydibx+jA5imQSYRo/EbnIYhITRvkjlMiOYQASo53qvKbnJ782xqfqjHnn8Vz1ALuO6sLbGgfYR6kTjkkP4WF0McUayuJcvFvrHEI7O0G016Yy8JGQtVDGTjuC17G2raRBjDGwC48ENK+hwzq0/kZDoMBw9MW7ThlDYFMIHF5bUkQcz1wRxoGrDqG2UzvBdImZGMS3SCcnwwe1vXFpVMcfMhxLzVmp4z9Izt7tdMcmSnFSTF2dJ0zlg/mDpWb+eioIWRRs7pUawzBLwFC6xKAAK1923YlQPc5nUOd55kSwU22QglzI5T+bRz3iZg1MGesNaWnig7KkV/mAbAqiCueL5jkF4ppYcJdvYx+jfEhmEq7o2cJCtnZkF8UQiYd9iKmWY8y2HCffJuZ1yet9ikfrr+49VzR09pJj09se+cw1NcMy8Jkv+LBkgUItGrblnR6vdkKKVVuvttXaQ1yPeGJaF/Xstsw2p3u5jOYFhzrfsMBAvN+o0ZAGNNa2vKz0ryWlXriCv4TcuuNCkWl53G+tz8WtoHvI1k7VVb8m3FZD+BZrlsLfufJwpgfA== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(376005)(36860700004)(82310400014)(1800799015)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 11:43:43.9507 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cd6fe8e9-1657-4fb8-6120-08dc441c00a6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9DB.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7257 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Erez Shitrit Save the exact tag when matching over jumbo masking. Fixes: 348cdeec6472 ("net/mlx5/hws: add FW WQE rule creation logic") Signed-off-by: Erez Shitrit Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_rule.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_rule.c b/drivers/net/mlx5/hws/mlx5dr_rule.c index 3e8e90ba76..d56677a1a5 100644 --- a/drivers/net/mlx5/hws/mlx5dr_rule.c +++ b/drivers/net/mlx5/hws/mlx5dr_rule.c @@ -195,8 +195,13 @@ mlx5dr_rule_save_delete_info(struct mlx5dr_rule *rule, rule->tag_ptr = simple_calloc(2, sizeof(*rule->tag_ptr)); assert(rule->tag_ptr); - src_tag = (uint8_t *)ste_attr->wqe_data->tag; - memcpy(rule->tag_ptr[0].match, src_tag, MLX5DR_MATCH_TAG_SZ); + if (is_jumbo) + memcpy(rule->tag_ptr[0].jumbo, ste_attr->wqe_data->action, + MLX5DR_JUMBO_TAG_SZ); + else + memcpy(rule->tag_ptr[0].match, ste_attr->wqe_data->tag, + MLX5DR_MATCH_TAG_SZ); + rule->tag_ptr[1].reserved[0] = ste_attr->send_attr.match_definer_id; /* Save range definer id and tag for delete */ From patchwork Thu Mar 14 11:42:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 138396 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96DDC43CA5; Thu, 14 Mar 2024 12:44:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 400C042EEC; Thu, 14 Mar 2024 12:43:52 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2044.outbound.protection.outlook.com [40.107.94.44]) by mails.dpdk.org (Postfix) with ESMTP id A3F6C42EE5 for ; Thu, 14 Mar 2024 12:43:50 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FWBDt1PMFRN7nPEoUTYdLFf5RvFZOwqHRxHqeDVGLnEw8WpD62fOAuftxmPWgGDNh538oA7jGFcyAFYKujJGEThSOib6fKxA6x/sEVP9TDsuR+cvotzsS5bTokiW3Z4OW2aEe4b1YJZUIVPFdJYwB9M1P+cxZnaNTW730EKCz5oOmVCvZ9oSQDkAIM657RMWgALLG4S3n98kaM6Cj+T1a6V9KKt7Q2sHM6eRpAtvSs9vwN9KZBEb0MiWrD3xEv5EK4wclCXOS9icLv6Ikudl9eN2seIZUIl8G6E46Ucz1e6JuBL/DHtCmhwvM+m/fv4kQZSC5PeiCwvnce9i+r7Z+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WkJLkVT6q4mJgLKczljKjzsGGIS5yjWX/UCjXUNht28=; b=FmSmS5hst54yXHCGXknLyy9DrNXL4P18dgfE8Jq7+k0mP6rg8Vnz8f9MQLClQcyOUSnko6mgKiJ/KWfyQWQOQUopKRtmUPBKaHGDasabscktR9HEzFgAJmhH0jUYWgpht2V2O+S9nsYJPVI33W64z109X0ngKUISDssyd3jO1JYS2lWraRWp8QdwqK0k1mRl/gpJDtBoIV8x1mf65CB48uhlp+rxHq1/NEGhteevdy3jTXeoM2NRe+MqUY4P5n2X+or2QxwqxSgFVOZiNrmRsVeINYWXaWheuW1gy9IRxED6nFTwuVbhG0/Ny7LiELX0+N1NViaa3ovJX15Fws+PmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WkJLkVT6q4mJgLKczljKjzsGGIS5yjWX/UCjXUNht28=; b=O+1kXy3yC5whRVapClBTvqYCdZ/5WJgwMMlfRfjf6UJdlWZKrIaV/1PgAYAOO1H20exhx70dB33XNa4ZgCs9aqVFmTxM/Rh7Q6GIm9k75cP6/kivzzNBB6I8q4JVlcuBfUdBP/xmMjCGA0tmvys2/2Tsnka8GWi/cmWdFGowGhS50GsDwICCwKtoFVy4sTvn87O2nQBg4QyXzijTefPDKpa7O/wwC2FAH6prvrcejj1SYuPlWt5GfmwpfeFt0Wr44/RM1BNPKFzGZDzGQZ2LVQk0cFSJbCKr+atnt7/BeuY9bo2xOfpB4xWocIN6YYNx+2tY5QpMOMqXksllhaMzxA== Received: from CH0PR03CA0043.namprd03.prod.outlook.com (2603:10b6:610:b3::18) by IA0PR12MB9009.namprd12.prod.outlook.com (2603:10b6:208:48f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.36; Thu, 14 Mar 2024 11:43:48 +0000 Received: from CH3PEPF00000009.namprd04.prod.outlook.com (2603:10b6:610:b3:cafe::86) by CH0PR03CA0043.outlook.office365.com (2603:10b6:610:b3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.43 via Frontend Transport; Thu, 14 Mar 2024 11:43:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CH3PEPF00000009.mail.protection.outlook.com (10.167.244.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.12 via Frontend Transport; Thu, 14 Mar 2024 11:43:47 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 14 Mar 2024 04:43:33 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 14 Mar 2024 04:43:33 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend Transport; Thu, 14 Mar 2024 04:43:30 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Suanming Mou , Matan Azrad CC: , Subject: [PATCH 13/13] net/mlx5/hws: fix port ID for root matcher and rule Date: Thu, 14 Mar 2024 13:42:20 +0200 Message-ID: <20240314114220.203241-13-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240314114220.203241-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000009:EE_|IA0PR12MB9009:EE_ X-MS-Office365-Filtering-Correlation-Id: a011d9a4-0e16-4c20-f796-08dc441c0308 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ryyKoR0kTV8m2A8aIhYIo5ExkLyQQs5IgVlsBKpfd7V8rCkCPupDJmxkQXs7jV7bgVcRRUg0hOTC9qTkA2l4yXA7opqaTheZmcDaVSDVL+qi9idlvQ+RpXfPgqDonhXhUO7BxNWw0eGtDIEW+fJRT78MbNKPciG1oRA4hrRPz6/VdTioNeXU18y3oyvGnc+knvpDQ971Py9a2E7n2Wk81X6/OL482bCKV9Tmyt3q3QjHJqL2Xo4+LcmN/gYjTgBz/ALDlfiCsyOJmGDKPvkoOaoBjPwGSy1o4oecAGWUtydrrSkzf0QTxMzvNnP18fN/MVDTTI0rg0jut0Aor2hVVL+kGgw9UordA/6K1hiF1383c9liafP3K8Z6LUXeJ2zQ4GOlaPSmiBMcH2Wzcph3YI39OrXPYBKGzVWlBGQwun1qXqDuizh61g9t+OyKarSLoa2ThU2lWbYdp/TJonHyywLCEiPpV1WptMQwPk4Ams2bJRwvo34CyU6V7NcMQ7DkddZ26sHq+rLk4mMCIuujFxTR3xtF5TMZBtbFOc/jnNtL8GkuwFTGDmsLyKbW8WhdefwiDrHTc/X777EXt9os9FnKjgSD95wVDcA8cGLV5yoQM3TLfh0mrjGjS9r1evvrzzafjTTuC9vkCUnzHtSaL178lzEDUrAgbrrRZECMwca1s1pRirha0vO+oggW8v9Uu9phCFXFjl8Hnjj0OXJIswc72cSze2Qrx6Ib3a+s7arBS/TUg/vZpBCLHPlHWp9w1xMzeJ+mMSLb1/ZoJjNpng== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(82310400014)(376005)(36860700004)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 11:43:47.8897 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a011d9a4-0e16-4c20-f796-08dc441c0308 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000009.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB9009 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Erez Shitrit In root tables matcher and rule need to have their port-id, otherwise the translate function that done in dpdk layer will not get the right attributes. For that whenever the matcher is matching the source-port we need to get the relevant port-id before calling the translate function. Fixes: 405242c52dd5 ("net/mlx5/hws: add rule object") Signed-off-by: Erez Shitrit Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_matcher.c | 17 +++++++++++++++++ drivers/net/mlx5/hws/mlx5dr_rule.c | 18 ++++++++++++++++++ drivers/net/mlx5/mlx5_flow.h | 18 ++++++++++++++++++ 3 files changed, 53 insertions(+) diff --git a/drivers/net/mlx5/hws/mlx5dr_matcher.c b/drivers/net/mlx5/hws/mlx5dr_matcher.c index 78d525e578..394244b55b 100644 --- a/drivers/net/mlx5/hws/mlx5dr_matcher.c +++ b/drivers/net/mlx5/hws/mlx5dr_matcher.c @@ -1227,6 +1227,7 @@ static int mlx5dr_matcher_init_root(struct mlx5dr_matcher *matcher) struct mlx5dv_flow_match_parameters *mask; struct mlx5_flow_attr flow_attr = {0}; struct rte_flow_error rte_error; + struct rte_flow_item *item; uint8_t match_criteria; int ret; @@ -1255,6 +1256,22 @@ static int mlx5dr_matcher_init_root(struct mlx5dr_matcher *matcher) return rte_errno; } + /* We need the port id in case of matching representor */ + item = matcher->mt[0].items; + while (item->type != RTE_FLOW_ITEM_TYPE_END) { + if (item->type == RTE_FLOW_ITEM_TYPE_PORT_REPRESENTOR || + item->type == RTE_FLOW_ITEM_TYPE_REPRESENTED_PORT) { + ret = flow_hw_get_port_id_from_ctx(ctx, &flow_attr.port_id); + if (ret) { + DR_LOG(ERR, "Failed to get port id for dev %s", + ctx->ibv_ctx->device->name); + rte_errno = EINVAL; + return rte_errno; + } + } + ++item; + } + mask = simple_calloc(1, MLX5_ST_SZ_BYTES(fte_match_param) + offsetof(struct mlx5dv_flow_match_parameters, match_buf)); if (!mask) { diff --git a/drivers/net/mlx5/hws/mlx5dr_rule.c b/drivers/net/mlx5/hws/mlx5dr_rule.c index d56677a1a5..5dae4f3442 100644 --- a/drivers/net/mlx5/hws/mlx5dr_rule.c +++ b/drivers/net/mlx5/hws/mlx5dr_rule.c @@ -692,10 +692,28 @@ static int mlx5dr_rule_create_root(struct mlx5dr_rule *rule, struct mlx5dv_flow_match_parameters *value; struct mlx5_flow_attr flow_attr = {0}; struct mlx5dv_flow_action_attr *attr; + const struct rte_flow_item *cur_item; struct rte_flow_error error; uint8_t match_criteria; int ret; + /* We need the port id in case of matching representor */ + cur_item = items; + while (cur_item->type != RTE_FLOW_ITEM_TYPE_END) { + if (cur_item->type == RTE_FLOW_ITEM_TYPE_PORT_REPRESENTOR || + cur_item->type == RTE_FLOW_ITEM_TYPE_REPRESENTED_PORT) { + ret = flow_hw_get_port_id_from_ctx(rule->matcher->tbl->ctx, + &flow_attr.port_id); + if (ret) { + DR_LOG(ERR, "Failed to get port id for dev %s", + rule->matcher->tbl->ctx->ibv_ctx->device->name); + rte_errno = EINVAL; + return rte_errno; + } + } + ++cur_item; + } + attr = simple_calloc(num_actions, sizeof(*attr)); if (!attr) { rte_errno = ENOMEM; diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h index 34b5e0f45b..e435a686fd 100644 --- a/drivers/net/mlx5/mlx5_flow.h +++ b/drivers/net/mlx5/mlx5_flow.h @@ -2001,6 +2001,24 @@ flow_hw_get_reg_id(struct rte_eth_dev *dev, #endif } +static __rte_always_inline int +flow_hw_get_port_id_from_ctx(void *dr_ctx, uint32_t *port_val) +{ + uint32_t port; + + MLX5_ETH_FOREACH_DEV(port, NULL) { + struct mlx5_priv *priv; + priv = rte_eth_devices[port].data->dev_private; + + if (priv->dr_ctx == dr_ctx) { + *port_val = port; + return 0; + } + } + + return -EINVAL; +} + /** * Get GENEVE TLV option FW information according type and class. *