From patchwork Thu Mar 21 09:50:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Jones X-Patchwork-Id: 138657 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9946243D14; Thu, 21 Mar 2024 10:55:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8797542D7F; Thu, 21 Mar 2024 10:55:33 +0100 (CET) Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by mails.dpdk.org (Postfix) with ESMTP id 4ACEA40261 for ; Thu, 21 Mar 2024 10:50:41 +0100 (CET) Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4V0ggj0x0gz4MYT; Thu, 21 Mar 2024 09:50:41 +0000 (UTC) (envelope-from thj@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V0ggh6tTdz41NK; Thu, 21 Mar 2024 09:50:40 +0000 (UTC) (envelope-from thj@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711014641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lOJaI7IZHaN6uPi0TQuejvhnZHgDce4G52ZJ4iXVFAE=; b=ll/h671oBh/hfiI/ihDADYeANrW9XBDSRcaBmLkHfZE6wmJKC3Q0WruIOyCjrK8fIaEd4N icWDGHH3lmbKt3GbFqFqXOpV6dW043olT217LFlV4YxzdSa8Lsz69s5JJLNe2DAKyrUClF Jol40GIJPghRIV1vEywUeA3tGHpNKM51otuit0AgjGP9rIJeIfUSHV1HgfRBzK0sZRv0dU Yv2Lh+/JK9qMMYRGr8yg4yoHh93zYI33QtMhdvwAAcJOsZyRSITdwDHLy0JMXh0zDgpy+k TrK5aYFkNAimChHUSU+Sp5b3nkqROEAPLdkhn4XlQnl3JUsQ/lW7Mf7K2iBjyg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711014641; a=rsa-sha256; cv=none; b=MrgCZSm6ZIHo8RYp758nazAgPb6RNYVVRD85OCl8IVDrj17RbEUfOMlmmx4kmJDkMTP352 uf1D2qaqIdHMXg10GZx1uKCZDBa9+WK/ucaFDV/itGoY1nxdBE4xW03GZhbb4DOCn0RSiI tW1FQbB0D39RP4ISklDls/PpOENn6EmQNXtr0CPEbjf9vZBAu1hHBZFmyXf34MDoNPike3 AnWnarjKqkrI7nPJa1bWtfH+FuxJStgdNeZc9+3WBIsH6BusxMWHQ8DmC6CNwHRS5NehtW TgNo8l2RX57yJNWR7M3eeJJjLbXZ5dPKgHl923Iy0duBnVqc6XZbRDqAqMA81g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711014641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lOJaI7IZHaN6uPi0TQuejvhnZHgDce4G52ZJ4iXVFAE=; b=Et7nhMHqBN7ZmvE5qrg/QMt1ySh1ZgY4Rvx2VRn/yWYTNBYyUIkmxcz49u52QwIBY/+pjk vMATtKSAemq6iDSPXBbxA/GtQck2dBM9mwu/LRxk+HXD+OiGB9gHRW+NHgiMUEiubPPdUH cTSh7927KUkQM3A2ozRnJ5jn/ms42/1OUJ5PTYoyXB8aMxYWP3YVC1VAs7j5fP1f5SaXsx /DNwNBsrYk3GEp3kpkmkrngAcO9jsrWXBb0rSpj1RQUpk8yYhaR3YUoULEmnHv2Xx8MRYJ G75x4McaB6XRw2GluTKHu4YpJI6+LDqQCqJy4wcglsFJ1d8cdoUtN3DoEbHv8A== Received: from vpp.my.domain (unknown [188.74.83.122]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: thj) by smtp.freebsd.org (Postfix) with ESMTPSA id 4V0ggh3bRpzh1V; Thu, 21 Mar 2024 09:50:40 +0000 (UTC) (envelope-from thj@freebsd.org) From: Tom Jones To: dev@dpdk.org Cc: Tom Jones Subject: [PATCH] net/vmxnet3: Don't enable rx queue interrupts on FreeBSD Date: Thu, 21 Mar 2024 09:50:29 +0000 Message-ID: <20240321095029.1216-1-thj@freebsd.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240320130255.1526-1-thj@freebsd.org> References: <20240320130255.1526-1-thj@freebsd.org> MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 21 Mar 2024 10:55:31 +0100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Commit 29a1c9107bb disabled interrupts on FreeBSD for the vmxnet3 driver as they are not supported. Rx queue interrupts were missed by this change, don't attempt to enable them on FreeBSD. Without this change applications enabling interrupts encounter an immediate abort on FreeBSD. Signed-off-by: Tom Jones --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index 2707b25148..ce7c347254 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c @@ -1936,11 +1936,13 @@ vmxnet3_interrupt_handler(void *param) static int vmxnet3_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id) { +#ifndef RTE_EXEC_ENV_FREEBSD struct vmxnet3_hw *hw = dev->data->dev_private; vmxnet3_enable_intr(hw, rte_intr_vec_list_index_get(dev->intr_handle, queue_id)); +#endif return 0; }