From patchwork Wed Apr 3 10:16:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jie Hai X-Patchwork-Id: 139074 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B74C843DE7; Wed, 3 Apr 2024 12:21:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A49F8402D9; Wed, 3 Apr 2024 12:21:45 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id BF8F94025C for ; Wed, 3 Apr 2024 12:21:44 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4V8ghX30mgztRKX for ; Wed, 3 Apr 2024 18:19:08 +0800 (CST) Received: from kwepemd100004.china.huawei.com (unknown [7.221.188.31]) by mail.maildlp.com (Postfix) with ESMTPS id B6AE518005D for ; Wed, 3 Apr 2024 18:21:42 +0800 (CST) Received: from localhost.localdomain (10.67.165.2) by kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.28; Wed, 3 Apr 2024 18:21:42 +0800 From: Jie Hai To: , Yisen Zhuang , "Min Hu (Connor)" CC: , , , , Subject: [PATCH 1/5] net/hns3: fix offload flag of IEEE 1588 Date: Wed, 3 Apr 2024 18:16:19 +0800 Message-ID: <20240403101624.2771140-2-haijie1@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20240403101624.2771140-1-haijie1@huawei.com> References: <20240403101624.2771140-1-haijie1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.67.165.2] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemd100004.china.huawei.com (7.221.188.31) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Dengdui Huang Currently, the RTE_MBUF_F_RX_IEEE1588_TMST offload flag will not be set when the scatter algorithm is used. This patch fixes it. Fixes: 4801f0403b58 ("net/hns3: fix IEEE 1588 PTP for scalar scattered Rx") Cc: stable@dpdk.org Signed-off-by: Dengdui Huang Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index 7e636a0a2e99..3e7dd1057940 100644 --- a/drivers/net/hns3/hns3_rxtx.c +++ b/drivers/net/hns3/hns3_rxtx.c @@ -2669,6 +2669,7 @@ hns3_recv_scattered_pkts(void *rx_queue, continue; } + first_seg->ol_flags = 0; if (unlikely(bd_base_info & BIT(HNS3_RXD_TS_VLD_B))) hns3_rx_ptp_timestamp_handle(rxq, first_seg, timestamp); @@ -2698,7 +2699,7 @@ hns3_recv_scattered_pkts(void *rx_queue, first_seg->port = rxq->port_id; first_seg->hash.rss = rte_le_to_cpu_32(rxd.rx.rss_hash); - first_seg->ol_flags = RTE_MBUF_F_RX_RSS_HASH; + first_seg->ol_flags |= RTE_MBUF_F_RX_RSS_HASH; if (unlikely(bd_base_info & BIT(HNS3_RXD_LUM_B))) { first_seg->hash.fdir.hi = rte_le_to_cpu_16(rxd.rx.fd_id); From patchwork Wed Apr 3 10:16:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jie Hai X-Patchwork-Id: 139076 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F1C843DE7; Wed, 3 Apr 2024 12:22:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 742524064E; Wed, 3 Apr 2024 12:21:49 +0200 (CEST) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id 51BEC4025C for ; Wed, 3 Apr 2024 12:21:45 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4V8ghK6DyWz1h5F0 for ; Wed, 3 Apr 2024 18:18:57 +0800 (CST) Received: from kwepemd100004.china.huawei.com (unknown [7.221.188.31]) by mail.maildlp.com (Postfix) with ESMTPS id 636AA1400D3 for ; Wed, 3 Apr 2024 18:21:43 +0800 (CST) Received: from localhost.localdomain (10.67.165.2) by kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.28; Wed, 3 Apr 2024 18:21:42 +0800 From: Jie Hai To: , Yisen Zhuang , "Min Hu (Connor)" CC: , , , , Subject: [PATCH 2/5] net/hns3: fix read Rx timestamp handle Date: Wed, 3 Apr 2024 18:16:20 +0800 Message-ID: <20240403101624.2771140-3-haijie1@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20240403101624.2771140-1-haijie1@huawei.com> References: <20240403101624.2771140-1-haijie1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.67.165.2] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemd100004.china.huawei.com (7.221.188.31) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Dengdui Huang The flag RTE_MBUF_F_RX_IEEE1588_PTP depends on the packet type and does not need to be set when reading Rx timestamp. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: stable@dpdk.org Signed-off-by: Dengdui Huang Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_rxtx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index 3e7dd1057940..54bf724a0e6c 100644 --- a/drivers/net/hns3/hns3_rxtx.c +++ b/drivers/net/hns3/hns3_rxtx.c @@ -2389,8 +2389,7 @@ hns3_rx_ptp_timestamp_handle(struct hns3_rx_queue *rxq, struct rte_mbuf *mbuf, { struct hns3_pf *pf = HNS3_DEV_PRIVATE_TO_PF(rxq->hns); - mbuf->ol_flags |= RTE_MBUF_F_RX_IEEE1588_PTP | - RTE_MBUF_F_RX_IEEE1588_TMST; + mbuf->ol_flags |= RTE_MBUF_F_RX_IEEE1588_TMST; if (hns3_timestamp_rx_dynflag > 0) { *RTE_MBUF_DYNFIELD(mbuf, hns3_timestamp_dynfield_offset, rte_mbuf_timestamp_t *) = timestamp; From patchwork Wed Apr 3 10:16:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jie Hai X-Patchwork-Id: 139075 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 485F743DE7; Wed, 3 Apr 2024 12:21:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3CFDE402EC; Wed, 3 Apr 2024 12:21:48 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 28CA2402D1 for ; Wed, 3 Apr 2024 12:21:45 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4V8ghY5TT6ztRcD; Wed, 3 Apr 2024 18:19:09 +0800 (CST) Received: from kwepemd100004.china.huawei.com (unknown [7.221.188.31]) by mail.maildlp.com (Postfix) with ESMTPS id 1892B140FB0; Wed, 3 Apr 2024 18:21:44 +0800 (CST) Received: from localhost.localdomain (10.67.165.2) by kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.28; Wed, 3 Apr 2024 18:21:43 +0800 From: Jie Hai To: , Yisen Zhuang , Hao Chen , "Wei Hu (Xavier)" , "Min Wang (Jushui)" , "Min Hu (Connor)" , Huisong Li CC: , , , Subject: [PATCH 3/5] net/hns3: fix double free for Rx/Tx queue Date: Wed, 3 Apr 2024 18:16:21 +0800 Message-ID: <20240403101624.2771140-4-haijie1@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20240403101624.2771140-1-haijie1@huawei.com> References: <20240403101624.2771140-1-haijie1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.67.165.2] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemd100004.china.huawei.com (7.221.188.31) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Dengdui Huang The Pointers to some resources on the Rx/Tx queue need to be set to NULL after free inside the hns3_rx/tx_queue_release(), as this function is called from multiple threads (reset thread, device config thread, etc), leading to double memory free error. Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Cc: stable@dpdk.org Signed-off-by: Dengdui Huang Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_rxtx.c | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index 54bf724a0e6c..fbc5ef3225c5 100644 --- a/drivers/net/hns3/hns3_rxtx.c +++ b/drivers/net/hns3/hns3_rxtx.c @@ -86,9 +86,14 @@ hns3_rx_queue_release(void *queue) struct hns3_rx_queue *rxq = queue; if (rxq) { hns3_rx_queue_release_mbufs(rxq); - if (rxq->mz) + if (rxq->mz) { rte_memzone_free(rxq->mz); - rte_free(rxq->sw_ring); + rxq->mz = NULL; + } + if (rxq->sw_ring) { + rte_free(rxq->sw_ring); + rxq->sw_ring = NULL; + } rte_free(rxq); } } @@ -99,10 +104,18 @@ hns3_tx_queue_release(void *queue) struct hns3_tx_queue *txq = queue; if (txq) { hns3_tx_queue_release_mbufs(txq); - if (txq->mz) + if (txq->mz) { rte_memzone_free(txq->mz); - rte_free(txq->sw_ring); - rte_free(txq->free); + txq->mz = NULL; + } + if (txq->sw_ring) { + rte_free(txq->sw_ring); + txq->sw_ring = NULL; + } + if (txq->free) { + rte_free(txq->free); + txq->free = NULL; + } rte_free(txq); } } From patchwork Wed Apr 3 10:16:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jie Hai X-Patchwork-Id: 139077 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F7F643DE7; Wed, 3 Apr 2024 12:22:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE9664068E; Wed, 3 Apr 2024 12:21:50 +0200 (CEST) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id CF276402DD for ; Wed, 3 Apr 2024 12:21:45 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4V8gkp2BQ0z1GFZS for ; Wed, 3 Apr 2024 18:21:06 +0800 (CST) Received: from kwepemd100004.china.huawei.com (unknown [7.221.188.31]) by mail.maildlp.com (Postfix) with ESMTPS id BABFE1400D3 for ; Wed, 3 Apr 2024 18:21:44 +0800 (CST) Received: from localhost.localdomain (10.67.165.2) by kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.28; Wed, 3 Apr 2024 18:21:44 +0800 From: Jie Hai To: , Yisen Zhuang , "Min Hu (Connor)" , Chengchang Tang CC: , , , , Subject: [PATCH 4/5] net/hns3: fix variable overflow Date: Wed, 3 Apr 2024 18:16:22 +0800 Message-ID: <20240403101624.2771140-5-haijie1@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20240403101624.2771140-1-haijie1@huawei.com> References: <20240403101624.2771140-1-haijie1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.67.165.2] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemd100004.china.huawei.com (7.221.188.31) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Dengdui Huang the function strtoul() returns an unsigned long, which should be received using the variable uint64_t. Fixes: 2fc3e696a7f1 ("net/hns3: add runtime config for mailbox limit time") Cc: stable@dpdk.org Signed-off-by: Dengdui Huang Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_common.c b/drivers/net/hns3/hns3_common.c index 28c26b049cf9..5e6cdfdaa019 100644 --- a/drivers/net/hns3/hns3_common.c +++ b/drivers/net/hns3/hns3_common.c @@ -224,7 +224,7 @@ hns3_parse_dev_caps_mask(const char *key, const char *value, void *extra_args) static int hns3_parse_mbx_time_limit(const char *key, const char *value, void *extra_args) { - uint32_t val; + uint64_t val; RTE_SET_USED(key); From patchwork Wed Apr 3 10:16:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jie Hai X-Patchwork-Id: 139078 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BA0643DE7; Wed, 3 Apr 2024 12:22:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18D47406A2; Wed, 3 Apr 2024 12:21:52 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 60770402DD for ; Wed, 3 Apr 2024 12:21:46 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4V8ghK36gqzwR8K for ; Wed, 3 Apr 2024 18:18:57 +0800 (CST) Received: from kwepemd100004.china.huawei.com (unknown [7.221.188.31]) by mail.maildlp.com (Postfix) with ESMTPS id 483F418005D for ; Wed, 3 Apr 2024 18:21:45 +0800 (CST) Received: from localhost.localdomain (10.67.165.2) by kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.28; Wed, 3 Apr 2024 18:21:44 +0800 From: Jie Hai To: , Yisen Zhuang CC: , , , , Subject: [PATCH 5/5] net/hns3: disable SCTP verification Tag for RSS hash input Date: Wed, 3 Apr 2024 18:16:23 +0800 Message-ID: <20240403101624.2771140-6-haijie1@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20240403101624.2771140-1-haijie1@huawei.com> References: <20240403101624.2771140-1-haijie1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.67.165.2] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemd100004.china.huawei.com (7.221.188.31) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When the symmetric RSS algorithm is used, the same packet is expected to be hashed to the same queue in the upstream and downstream directions. The problem is that it could map the packets in the same SCTP connection to different NIC RX queues depending on the direction of packets. This is because the verification Tag is used as the RSS hash input for the SCTP packets, and the value depends on the peer end of the SCTP connection and could not be symmetrically used in the hardware-implemented RSS algorithm. In addition, the ethdev framework doesn't support setting SCTP V-tag as the RSS hash input. So disable it for all RSS hash algorithms. Cc: stable@dpdk.org Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_rss.c | 6 ++---- drivers/net/hns3/hns3_rss.h | 6 ++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c index 15feb26043af..3eae4caf52a2 100644 --- a/drivers/net/hns3/hns3_rss.c +++ b/drivers/net/hns3/hns3_rss.c @@ -153,8 +153,7 @@ static const struct { BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_IP_S) | BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_IP_D) | BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_S) | - BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_D) | - BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_VER), + BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_D), HNS3_RSS_TUPLE_IPV4_SCTP_M }, /* IPV6-FRAG */ @@ -274,8 +273,7 @@ static const struct { BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_IP_S) | BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_IP_D) | BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_D) | - BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_S) | - BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_VER), + BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_S), HNS3_RSS_TUPLE_IPV6_SCTP_M }, }; diff --git a/drivers/net/hns3/hns3_rss.h b/drivers/net/hns3/hns3_rss.h index 9d182a8025c5..0755760b4513 100644 --- a/drivers/net/hns3/hns3_rss.h +++ b/drivers/net/hns3/hns3_rss.h @@ -49,7 +49,6 @@ enum hns3_tuple_field { HNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_S, HNS3_RSS_FIELD_IPV4_SCTP_EN_IP_D, HNS3_RSS_FIELD_IPV4_SCTP_EN_IP_S, - HNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_VER, /* IPV4 ENABLE FIELD */ HNS3_RSS_FIELD_IPV4_EN_NONFRAG_IP_D = 24, @@ -74,7 +73,6 @@ enum hns3_tuple_field { HNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_S, HNS3_RSS_FIELD_IPV6_SCTP_EN_IP_D, HNS3_RSS_FIELD_IPV6_SCTP_EN_IP_S, - HNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_VER, /* IPV6 ENABLE FIELD */ HNS3_RSS_FIELD_IPV6_NONFRAG_IP_D = 56, @@ -96,12 +94,12 @@ enum hns3_tuple_field { #define HNS3_RSS_TUPLE_IPV4_TCP_M GENMASK(3, 0) #define HNS3_RSS_TUPLE_IPV4_UDP_M GENMASK(11, 8) -#define HNS3_RSS_TUPLE_IPV4_SCTP_M GENMASK(20, 16) +#define HNS3_RSS_TUPLE_IPV4_SCTP_M GENMASK(19, 16) #define HNS3_RSS_TUPLE_IPV4_NONF_M GENMASK(25, 24) #define HNS3_RSS_TUPLE_IPV4_FLAG_M GENMASK(27, 26) #define HNS3_RSS_TUPLE_IPV6_TCP_M GENMASK(35, 32) #define HNS3_RSS_TUPLE_IPV6_UDP_M GENMASK(43, 40) -#define HNS3_RSS_TUPLE_IPV6_SCTP_M GENMASK(52, 48) +#define HNS3_RSS_TUPLE_IPV6_SCTP_M GENMASK(51, 48) #define HNS3_RSS_TUPLE_IPV6_NONF_M GENMASK(57, 56) #define HNS3_RSS_TUPLE_IPV6_FLAG_M GENMASK(59, 58)