From patchwork Fri Jun 29 12:17:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rafal Kozik X-Patchwork-Id: 41959 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 378311B597; Fri, 29 Jun 2018 14:17:26 +0200 (CEST) Received: from mail-lf0-f66.google.com (mail-lf0-f66.google.com [209.85.215.66]) by dpdk.org (Postfix) with ESMTP id 484E71B592 for ; Fri, 29 Jun 2018 14:17:24 +0200 (CEST) Received: by mail-lf0-f66.google.com with SMTP id g21-v6so6651710lfb.4 for ; Fri, 29 Jun 2018 05:17:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=wWNxw0r4wrgI9Kp+M4NlaTVhfNuYhqp7kmjUW/FoeEc=; b=RtaoyvrJiSyNjd/6pnpBle55XJLJFGeaREg8SmPw5cKR4Loy9MmEmdUQByKOEWRtMk wRHIgpY16dQ4evukNDaTlIeQ1VH4CetzykY43JXOYlY/MwlyygHpXUQKnNXPvOvvvGQF +lh8BnwR1M6g+P0p/pIb0sPc6y/Cgv1tqdVC6vv9cKV9TvhZPfTBYuvKD5lqxVsVj2ze 9pAYMCTJF8Zi7lHW4ijoHaiAHQFQ8MqKNBfczQ0gXdmCZeExrol/CjYSyJmYfi71E08G FuhTfLOQvmS7qHIt3fZ7MR+u9xYRw6Iww41ftg1Bv7IotBqk+YItFzYJAg3WS9gbCUKq WCGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wWNxw0r4wrgI9Kp+M4NlaTVhfNuYhqp7kmjUW/FoeEc=; b=NJdOkJh9MHTrwdHvykHragbBfijnyHGseI1lCNp/0LLmo7MXXLqze338pCyLzjxYk9 Q7JzthAHD1+5hM7zQILQTEPy2wqMfmDPEOalc7dqU94VOlANjU8u24468QdsWzc0Fpny ujkimLdOLREWJsSjzwqmrRpFLi6KSxIM8zjECNPvLC/+QeeqMB/xNUc2XZ0+FTMoi/Xm 4rIGvH5YS/DBq1TYf9hI1TmBqSi8BMh47TY22imudoqlODNTG76edmYBtN1auqnGv7Zj IZ2KVMDInpF/LOumlR0W4DuMwSSZ+vXLkE9KNlDcsBbgjlAc8SQglKZbs8avE+dIm/ly nCGw== X-Gm-Message-State: APt69E3A/NsuhTpGNI3pArbeNpvZIMBzghdorRRQE16ZAzrujGaiL5KT R9E6mw3OujdYW7QXfXe8ZASQyP+c8zCmRg== X-Google-Smtp-Source: AAOMgpcbpqnCPOlK19b25dCvkEO/ebwWJJh99NWlWAIC11UxuyZCI2YtfrVMPlE/5A1ACmxhM01nyw== X-Received: by 2002:a19:1003:: with SMTP id f3-v6mr10103100lfi.116.1530274643647; Fri, 29 Jun 2018 05:17:23 -0700 (PDT) Received: from rafalkozik.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id r21-v6sm1527333lja.92.2018.06.29.05.17.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 Jun 2018 05:17:22 -0700 (PDT) From: Rafal Kozik To: dev@dpdk.org Cc: mw@semihalf.com, mk@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com, matua@amazon.com, igorch@amazon.com, thomas@monjalon.net, ferruh.yigit@intel.com, Kozik Date: Fri, 29 Jun 2018 14:17:14 +0200 Message-Id: <1530274637-10156-2-git-send-email-rk@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530274637-10156-1-git-send-email-rk@semihalf.com> References: <1530267873-7236-2-git-send-email-rk@semihalf.com> <1530274637-10156-1-git-send-email-rk@semihalf.com> Subject: [dpdk-dev] [PATCH v4 1/4] igb_uio: add wc option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Kozik Write combining (WC) increases NIC performance by making better utilization of PCI bus, but cannot be use by all PMD. To get internal_addr memory need to be mapped. But as memory could not be mapped twice: with and without WC it should be skipped for WC. [1] To do not spoil other drivers that potentially could use internal_addr, parameter wc_activate adds possibility to skip it for those PMDs, that do not use it. [1] https://www.kernel.org/doc/ols/2008/ols2008v2-pages-135-144.pdf section 5.3 and 5.4 Signed-off-by: Rafal Kozik Acked-by: Bruce Richardson Acked-by: Ferruh Yigit --- kernel/linux/igb_uio/igb_uio.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/kernel/linux/igb_uio/igb_uio.c b/kernel/linux/igb_uio/igb_uio.c index b3233f1..e16e760 100644 --- a/kernel/linux/igb_uio/igb_uio.c +++ b/kernel/linux/igb_uio/igb_uio.c @@ -30,6 +30,7 @@ struct rte_uio_pci_dev { int refcnt; }; +static int wc_activate; static char *intr_mode; static enum rte_intr_mode igbuio_intr_mode_preferred = RTE_INTR_MODE_MSIX; /* sriov sysfs */ @@ -375,9 +376,14 @@ igbuio_pci_setup_iomem(struct pci_dev *dev, struct uio_info *info, len = pci_resource_len(dev, pci_bar); if (addr == 0 || len == 0) return -1; - internal_addr = ioremap(addr, len); - if (internal_addr == NULL) - return -1; + if (wc_activate == 0) { + internal_addr = ioremap(addr, len); + if (internal_addr == NULL) + return -1; + } else { + internal_addr = NULL; + pr_info("wc_activate is set\n"); + } info->mem[n].name = name; info->mem[n].addr = addr; info->mem[n].internal_addr = internal_addr; @@ -650,6 +656,12 @@ MODULE_PARM_DESC(intr_mode, " " RTE_INTR_MODE_LEGACY_NAME " Use Legacy interrupt\n" "\n"); +module_param(wc_activate, int, 0); +MODULE_PARM_DESC(wc_activate, +"Activate support for write combining (WC) (default=0)\n" +" 0 - disable\n" +" other - enable\n"); + MODULE_DESCRIPTION("UIO driver for Intel IGB PCI cards"); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Intel Corporation"); From patchwork Fri Jun 29 12:17:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rafal Kozik X-Patchwork-Id: 41960 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C2E5F1B5A9; Fri, 29 Jun 2018 14:17:28 +0200 (CEST) Received: from mail-lf0-f67.google.com (mail-lf0-f67.google.com [209.85.215.67]) by dpdk.org (Postfix) with ESMTP id D77F61B59A for ; Fri, 29 Jun 2018 14:17:26 +0200 (CEST) Received: by mail-lf0-f67.google.com with SMTP id j26-v6so6644243lfb.11 for ; Fri, 29 Jun 2018 05:17:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=K2dHxLVizsecchLPAUNv+n6dRKmElQ/u1z1COViFIVA=; b=R5ACgpRvCJMocWmFNM62kVa4y4vUtw6Pf76NEmYf4bgiLCrAHsamSb4Ays+7OIRhat YztMvtBxWu7fCS5LDSICau9gwsYwhuJYzhZ3WGgMA4TQL9Ze6Yv0qveVcGSdd33HpcHX 1iRNo77M3TSAj+nKpwfn70HT9bZy5j3OSr0Wkn68EgsbfwKYqsi8cuYEvYyAz56wzIjH ZU3JcWE2zxFbzFYJbHZNGxNfkDBLuIcvyWmLVIc2xZNZycRNnSdY1JCtqI3Fp+deGf6t o+8URgj8ckRnjTsOSYibHaz6JTB0BVjmH9ESsXSlBAr9wNe+U7t2dsv7VXkABrH/Nw+v hLgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=K2dHxLVizsecchLPAUNv+n6dRKmElQ/u1z1COViFIVA=; b=uVxUZR4lT9/cgc6VPDtokCfPAh5or/J0Xj8knVZO0bi8sTDSFwaP4Sui+cSGu7U6cN TvEonin43konvxR5a7dVmEoXIJdAavzmM8hczz5hecmOsLzoqULH2u12vKFAFiy5opmC D1rw1GHp4txHplU/UHk2KFAM9nqGxPAEM3j/sLTRmCSKxhBBCHum4kFAxrke20twIBWR 0HjrvtlqVt5pXammYAHNU7atvMEq+qci6wroAeN3vudz1IBqcwpCu+xixRujupbV8kkT nR7OuIcrdvQcjh74ozxUbPqUTv22p4kXFb0yfXbO/UZhZmaobUurSNZYdrsRmGaxFvmt 91Hw== X-Gm-Message-State: APt69E162VH70QSjMd/RUH6Rx37mHgpU45m/a886olr3NUX/gfFBB2u/ zgBsNoOYPwxWPy8kNVigEQi5EK4thVfQXg== X-Google-Smtp-Source: AAOMgpcLT3NyIIqZ2r6/o/l8tkJf6oQc1+VjVoG4dQCdtKNErMRj4obx3DPCDWoJ60uoKj1+ef1IWQ== X-Received: by 2002:a19:ca09:: with SMTP id a9-v6mr339302lfg.142.1530274645571; Fri, 29 Jun 2018 05:17:25 -0700 (PDT) Received: from rafalkozik.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id r21-v6sm1527333lja.92.2018.06.29.05.17.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 Jun 2018 05:17:24 -0700 (PDT) From: Rafal Kozik To: dev@dpdk.org Cc: mw@semihalf.com, mk@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com, matua@amazon.com, igorch@amazon.com, thomas@monjalon.net, ferruh.yigit@intel.com, Kozik Date: Fri, 29 Jun 2018 14:17:15 +0200 Message-Id: <1530274637-10156-3-git-send-email-rk@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530274637-10156-1-git-send-email-rk@semihalf.com> References: <1530267873-7236-2-git-send-email-rk@semihalf.com> <1530274637-10156-1-git-send-email-rk@semihalf.com> Subject: [dpdk-dev] [PATCH v4 2/4] bus/pci: reference driver structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Kozik Add pointer to driver structure before calling rte_pci_map_device. It allows to use driver flags for adjusting configuration. Signed-off-by: Rafal Kozik Acked-by: Bruce Richardson --- drivers/bus/pci/pci_common.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index d8151b0..8f5d77f 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common.c @@ -158,17 +158,24 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr, RTE_LOG(INFO, EAL, " probe driver: %x:%x %s\n", dev->id.vendor_id, dev->id.device_id, dr->driver.name); + /* + * reference driver structure + * This need to be before rte_pci_map_device(), as it enable to use + * driver flags for adjusting configuration. + */ + dev->driver = dr; + dev->device.driver = &dr->driver; + if (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) { /* map resources for devices that use igb_uio */ ret = rte_pci_map_device(dev); - if (ret != 0) + if (ret != 0) { + dev->driver = NULL; + dev->device.driver = NULL; return ret; + } } - /* reference driver structure */ - dev->driver = dr; - dev->device.driver = &dr->driver; - /* call the driver probe() function */ ret = dr->probe(dr, dev); if (ret) { From patchwork Fri Jun 29 12:17:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rafal Kozik X-Patchwork-Id: 41961 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C03B31B5AF; Fri, 29 Jun 2018 14:17:31 +0200 (CEST) Received: from mail-lf0-f65.google.com (mail-lf0-f65.google.com [209.85.215.65]) by dpdk.org (Postfix) with ESMTP id 080261B59E for ; Fri, 29 Jun 2018 14:17:28 +0200 (CEST) Received: by mail-lf0-f65.google.com with SMTP id m13-v6so6633408lfb.12 for ; Fri, 29 Jun 2018 05:17:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=WPzKN/+Jm1syAx/3y0hWW2WWUwBF00KCZX8QjZjkls0=; b=w+I1+kPql7TIKyAESYIfB3qyX0IwQvKa8VSX1C23oT1Ah5kuSQmwfV4DCqd5mesnYb 6EiZg100kmckhGG/4CJNgJTzOkwJzF39+/9AoM8EYwn8Q2w1gC4lieU+80MYp8lVOWva xlv9JIuNAhEPbWwDKZZ4iX60z04iAcFCffOlnORvoD7C7CYHYzZ8RAIL/utga9FAUswb HUHOGZhi0MW8DtBZfWTN8jSZx6Hn6/JvbdHcrUvto3/agTOjkFnh6IRKQ7fB4ddm3MvD sJm9KDuk9zf5p5DNKfEqbS2PK7AOxhWkhOkePyfPut06hgV1E0N1/Xl1HZNJB2wmCPvT 5EKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=WPzKN/+Jm1syAx/3y0hWW2WWUwBF00KCZX8QjZjkls0=; b=nykDUQvht99rU5FOAKkjxxDFvotS/NCJZug2ChgWwh8FbBLWOhwK2sd6uhPWtoiqv/ zWMKrexCsL8ifDLpzJriEzACK9RrlDu2IIyfaWP+OdAqjRyYdir6XIdDnxtFoAsmRpGM bxD/2WuuhCd490CqnVeq58imXEF2OESn9J9pPKFpyaXSXbaHlcive9+J7lX50Zv+r8wj 6GCdbC2ngApQVgw9IgULIK4GM/SRMndULp/TJwVW0RDksngnXh+vpsjGd0CieXPnhTON lp1FkJVEAtNpl/LJ3MQ1ctlfOtrPK3HjKgssDSghAyAQWZ910zK3EcF0rwBkSX41d5y3 Et4Q== X-Gm-Message-State: APt69E3JmxYDbC4mcREvJrDfK64C3gqg9SP6Jo4bq6iNUcaWQwik9xwD zMrtkgUrRhRBQiUSUAjLF8KsTO2FbBZCXw== X-Google-Smtp-Source: AAOMgpclpum9YUsoVzrFwhinQzYD+WJ3mGFR52FsPA+I+8KX2sp8QrOMDthF+XT4UfMmrDNr/GUxuQ== X-Received: by 2002:a19:6d11:: with SMTP id i17-v6mr9455605lfc.103.1530274647433; Fri, 29 Jun 2018 05:17:27 -0700 (PDT) Received: from rafalkozik.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id r21-v6sm1527333lja.92.2018.06.29.05.17.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 Jun 2018 05:17:26 -0700 (PDT) From: Rafal Kozik To: dev@dpdk.org Cc: mw@semihalf.com, mk@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com, matua@amazon.com, igorch@amazon.com, thomas@monjalon.net, ferruh.yigit@intel.com, Kozik Date: Fri, 29 Jun 2018 14:17:16 +0200 Message-Id: <1530274637-10156-4-git-send-email-rk@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530274637-10156-1-git-send-email-rk@semihalf.com> References: <1530267873-7236-2-git-send-email-rk@semihalf.com> <1530274637-10156-1-git-send-email-rk@semihalf.com> Subject: [dpdk-dev] [PATCH v4 3/4] eal: enable WC during resources mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Kozik Write combining (WC) increases NIC performance by making better utilization of PCI bus, but cannot be used by all PMDs. It will be enabled only if RTE_PCI_DRV_WC_ACTIVATE will be set in drivers flags. For proper work also igb_uio driver must be loaded with wc_activate set to 1. When mapping PCI resources, firstly check if it supports WC and try to use it. In case of failure, it will fall-back to normal mode. Signed-off-by: Rafal Kozik Acked-by: Bruce Richardson --- drivers/bus/pci/linux/pci_uio.c | 47 ++++++++++++++++++++++++++++++----------- drivers/bus/pci/rte_bus_pci.h | 2 ++ 2 files changed, 37 insertions(+), 12 deletions(-) diff --git a/drivers/bus/pci/linux/pci_uio.c b/drivers/bus/pci/linux/pci_uio.c index d423e4b..a7c1442 100644 --- a/drivers/bus/pci/linux/pci_uio.c +++ b/drivers/bus/pci/linux/pci_uio.c @@ -282,22 +282,19 @@ int pci_uio_map_resource_by_index(struct rte_pci_device *dev, int res_idx, struct mapped_pci_resource *uio_res, int map_idx) { - int fd; + int fd = -1; char devname[PATH_MAX]; void *mapaddr; struct rte_pci_addr *loc; struct pci_map *maps; + int wc_activate = 0; + + if (dev->driver != NULL) + wc_activate = dev->driver->drv_flags & RTE_PCI_DRV_WC_ACTIVATE; loc = &dev->addr; maps = uio_res->maps; - /* update devname for mmap */ - snprintf(devname, sizeof(devname), - "%s/" PCI_PRI_FMT "/resource%d", - rte_pci_get_sysfs_path(), - loc->domain, loc->bus, loc->devid, - loc->function, res_idx); - /* allocate memory to keep path */ maps[map_idx].path = rte_malloc(NULL, strlen(devname) + 1, 0); if (maps[map_idx].path == NULL) { @@ -309,11 +306,37 @@ pci_uio_map_resource_by_index(struct rte_pci_device *dev, int res_idx, /* * open resource file, to mmap it */ - fd = open(devname, O_RDWR); - if (fd < 0) { - RTE_LOG(ERR, EAL, "Cannot open %s: %s\n", + if (wc_activate) { + /* update devname for mmap */ + snprintf(devname, sizeof(devname), + "%s/" PCI_PRI_FMT "/resource%d_wc", + rte_pci_get_sysfs_path(), + loc->domain, loc->bus, loc->devid, + loc->function, res_idx); + + if (access(devname, R_OK|W_OK) != -1) { + fd = open(devname, O_RDWR); + if (fd < 0) + RTE_LOG(INFO, EAL, "%s cannot be mapped. " + "Fall-back to non prefetchable mode.\n", + devname); + } + } + + if (!wc_activate || fd < 0) { + snprintf(devname, sizeof(devname), + "%s/" PCI_PRI_FMT "/resource%d", + rte_pci_get_sysfs_path(), + loc->domain, loc->bus, loc->devid, + loc->function, res_idx); + + /* then try to map resource file */ + fd = open(devname, O_RDWR); + if (fd < 0) { + RTE_LOG(ERR, EAL, "Cannot open %s: %s\n", devname, strerror(errno)); - goto error; + goto error; + } } /* try mapping somewhere close to the end of hugepages */ diff --git a/drivers/bus/pci/rte_bus_pci.h b/drivers/bus/pci/rte_bus_pci.h index 458e6d0..828acc5 100644 --- a/drivers/bus/pci/rte_bus_pci.h +++ b/drivers/bus/pci/rte_bus_pci.h @@ -135,6 +135,8 @@ struct rte_pci_bus { /** Device needs PCI BAR mapping (done with either IGB_UIO or VFIO) */ #define RTE_PCI_DRV_NEED_MAPPING 0x0001 +/** Device needs PCI BAR mapping with enabled write combining (wc) */ +#define RTE_PCI_DRV_WC_ACTIVATE 0x0002 /** Device driver supports link state interrupt */ #define RTE_PCI_DRV_INTR_LSC 0x0008 /** Device driver supports device removal interrupt */ From patchwork Fri Jun 29 12:17:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rafal Kozik X-Patchwork-Id: 41962 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C789D1B5B4; Fri, 29 Jun 2018 14:17:33 +0200 (CEST) Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) by dpdk.org (Postfix) with ESMTP id E18111B5AC for ; Fri, 29 Jun 2018 14:17:29 +0200 (CEST) Received: by mail-lf0-f68.google.com with SMTP id g21-v6so6651952lfb.4 for ; Fri, 29 Jun 2018 05:17:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AwNrRX1Landx1JIqow4Cyk+bUOdJqBZtnQCgn5pVDtM=; b=AMw/LEw90tAqDe3WGBqax/gd7bLbmkxbnZWAFoVecu8r5NwTHzVQJLBvqmf6ZZH4TF O6szMT1yV2zSs+Wj2lNaSjQOHHrbJHBPmwRAUZfOyvZVAdDzRL8MQn7lGfmJFmzfbKS9 tYXd2T4iGjUASFdYGfhdiqa4zKVe9k3D8vN2waZ2iOro3z+fyCwkdBT7fKL0j8zAZYzY Zoq7fysciiLDwSgsbXCYTsp15WNW02ZyM/yBwtMqKw0kQvgfYGQT79RuwkHuloZ4P8pY YY0x5UzpTFy4BIi04ZoFDiTYiQ8/PFF9yy+zIwQpLkLdd3hsLhJaBPQtjnRzBjYyy6Ve P1HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AwNrRX1Landx1JIqow4Cyk+bUOdJqBZtnQCgn5pVDtM=; b=S5kLg2KlAnKHrY/mSu4itlvdqH1p1y68ol22b4t/JKKeKdK9qjMUY8RyOzJZLD1Hpp 5XNTAPKu96Zzrra3xmsYyJR4Hs2AJWkbXehSEH95m3YDGj4j6YBdBTMOuzufxxf49XGA DSz4/ABNirjoavtLz+kTNzVzdYZhbvi997b12OFec6BehngHDusrud2skgA0L/RTmFiG 6yJ72Vr4h9vO3Hj5LlmPqZ1QXBKB9Y8TYm4rK6X8iotPF29NNFtFRtm+CtgKkYrL9C8B 36Dx1ElayY2xsvmVlKgKE4xtEoNLX1ZAhGNCtqesrbxVvI5R0rcvDUZy1/t3FVm1O/Y0 9VvQ== X-Gm-Message-State: APt69E10NC1sNcHqiZgvluu1njqk/wb5Re2PAZESCX3vS/MDyDcB0Qh9 I0jrbiVIqsTaMyJ/SeI3Qeuunxt0CJ0fLQ== X-Google-Smtp-Source: AAOMgpcYEqYQcwPewSW9De1LtjoDWyLjXNpSrEo5c7qIpC8IyFZzkBt1jZzg4OdHMYniPUKO9Y9PSA== X-Received: by 2002:a19:aac1:: with SMTP id t184-v6mr10245572lfe.65.1530274649395; Fri, 29 Jun 2018 05:17:29 -0700 (PDT) Received: from rafalkozik.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id r21-v6sm1527333lja.92.2018.06.29.05.17.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 Jun 2018 05:17:28 -0700 (PDT) From: Rafal Kozik To: dev@dpdk.org Cc: mw@semihalf.com, mk@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com, matua@amazon.com, igorch@amazon.com, thomas@monjalon.net, ferruh.yigit@intel.com, Kozik Date: Fri, 29 Jun 2018 14:17:17 +0200 Message-Id: <1530274637-10156-5-git-send-email-rk@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530274637-10156-1-git-send-email-rk@semihalf.com> References: <1530267873-7236-2-git-send-email-rk@semihalf.com> <1530274637-10156-1-git-send-email-rk@semihalf.com> Subject: [dpdk-dev] [PATCH v4 4/4] net/ena: enable WC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Kozik Write combining (WC) increases NIC performance by making better utilization of PCI bus. ENA PMD may make usage of this feature. To enable it load igb_uio driver with wc_activate set to 1. Signed-off-by: Rafal Kozik Acked-by: Bruce Richardson --- drivers/net/ena/ena_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 9ae73e3..1870edf 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -2210,7 +2210,8 @@ static int eth_ena_pci_remove(struct rte_pci_device *pci_dev) static struct rte_pci_driver rte_ena_pmd = { .id_table = pci_id_ena_map, - .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC, + .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC | + RTE_PCI_DRV_WC_ACTIVATE, .probe = eth_ena_pci_probe, .remove = eth_ena_pci_remove, };