From patchwork Mon Apr 22 19:07:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hernan Vargas X-Patchwork-Id: 139628 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0B9943EDD; Mon, 22 Apr 2024 21:11:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54AE2402E1; Mon, 22 Apr 2024 21:11:34 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id BE40740265; Mon, 22 Apr 2024 21:11:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713813093; x=1745349093; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=U102rpZZowkZZDbYPsHfWyMqROd+POpvWWOWGPmAy2I=; b=kaUh/RhCnRQnMxf4i6392+IKKyl796cOvMCEXhdSxtBlBnqfVe5Satva 1HsJfN5OiV/aTtfAVqphQcGy8yDvMgGBVxP/faceMa3egoA4KR4YHrQJS WiPr8TIhCbuKAEB6BcOFww4pjhNi+7tbSgERs5qZLAT0st8EOENOTpZjY jyxMhG5e/ZItZRpYy0jogCUBaH4VxCWybrn2DESczpwoCSmAT/V3N+gAg 9l+f949x5cD8dvycUnRsHGQG7UAMi9pYhlLlt5WbnZN92kLfyoAitHuxH nsLeBMeCcpUnrWPHzbs4NgkzuLSiZeS+vj0eQCJn3aTNfC1nzmWqaLW2y w==; X-CSE-ConnectionGUID: 06gxPlpjTZeqhsjJmjoPuw== X-CSE-MsgGUID: 5hDo64ArRf2qlolm38pVqQ== X-IronPort-AV: E=McAfee;i="6600,9927,11052"; a="19922791" X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="19922791" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2024 12:11:32 -0700 X-CSE-ConnectionGUID: Aau1hCWURJufCCGztTbx6w== X-CSE-MsgGUID: WDWpLxEhTdiVHK4ne6EZQg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="24555946" Received: from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103]) by orviesa006.jf.intel.com with ESMTP; 22 Apr 2024 12:11:31 -0700 From: Hernan Vargas To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com, maxime.coquelin@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, Hernan Vargas , stable@dpdk.org Subject: [PATCH v1 1/9] test/bbdev: fix TB logic Date: Mon, 22 Apr 2024 12:07:52 -0700 Message-Id: <20240422190800.123027-2-hernan.vargas@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20240422190800.123027-1-hernan.vargas@intel.com> References: <20240422190800.123027-1-hernan.vargas@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Fix discrepancy in logic when using large fake mbuf. Fixes: fd96ef3787f1 ("test/bbdev: extend support for large TB") Cc: stable@dpdk.org Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index dcce00aa0a17..efd046984d58 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -2131,7 +2131,8 @@ validate_op_chain(struct rte_bbdev_op_data *op, uint16_t data_len = rte_pktmbuf_data_len(m) - offset; total_data_size += orig_op->segments[i].length; - if (orig_op->segments[i].length > RTE_BBDEV_LDPC_E_MAX_MBUF) + if ((orig_op->segments[i].length + RTE_PKTMBUF_HEADROOM) + > RTE_BBDEV_LDPC_E_MAX_MBUF) ignore_mbuf = true; if (!ignore_mbuf) TEST_ASSERT(orig_op->segments[i].length == data_len, From patchwork Mon Apr 22 19:07:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hernan Vargas X-Patchwork-Id: 139629 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD04F43EDD; Mon, 22 Apr 2024 21:11:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 446BF402C7; Mon, 22 Apr 2024 21:11:37 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id 2E7A5402AE; Mon, 22 Apr 2024 21:11:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713813094; x=1745349094; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ubnWmrE+5EflGa3B8s6UFD3H/PquKKJcIw2u1f95Rd8=; b=Fi3J6A8k83sRbP9sOdZakbrUZD4zH+hVQyf3aDCnsSCljPKnILigmDxF HtvhesWm4fsuoSFKgXB8483CYZM4ozftTzV54eH+oe91HnC7xGNdVOiot iFJ1P7Qxyg0VhDMBhwt8+Cji2Xg+6bAXw+mM4g0/cC/hndZGTjfop7UNN A+ins7ZKw1piKOrusgWhaeQq/8aupzwlZhV2rZpae6L4sVnJWZJuwG2WE vg3ioLW3MmvY61pU6msu3mBQNF/L3d6P50Jms4t8W4NUMTrHZeUxVdeBO JZacQPmVnsK3rAFasWTFr7T7m2uyvck7STO7O+emPCse1X0iq6tW8LCQP Q==; X-CSE-ConnectionGUID: rrHtEsNbRY+0XktrQZWeJg== X-CSE-MsgGUID: rndnwW57S6WSwsQZ+rMSgw== X-IronPort-AV: E=McAfee;i="6600,9927,11052"; a="19922796" X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="19922796" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2024 12:11:33 -0700 X-CSE-ConnectionGUID: RvMzuPPJTCWL/ymSXGoVgQ== X-CSE-MsgGUID: yIxNPrdtTcqyriem3S2OGA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="24555949" Received: from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103]) by orviesa006.jf.intel.com with ESMTP; 22 Apr 2024 12:11:32 -0700 From: Hernan Vargas To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com, maxime.coquelin@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, Hernan Vargas , stable@dpdk.org Subject: [PATCH v1 2/9] test/bbdev: fix MLD output size computation Date: Mon, 22 Apr 2024 12:07:53 -0700 Message-Id: <20240422190800.123027-3-hernan.vargas@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20240422190800.123027-1-hernan.vargas@intel.com> References: <20240422190800.123027-1-hernan.vargas@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org For perf tests, the operation size for the MLD-TS was incorrect. Fixed so that the performance numbers are correct. Largely cosmetic only. Fixes: 95f192a40e35 ("test/bbdev: add MLD cases") Cc: stable@dpdk.org Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index efd046984d58..9ed0c4648d24 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -2896,8 +2896,14 @@ calc_fft_size(struct rte_bbdev_fft_op *op) static uint32_t calc_mldts_size(struct rte_bbdev_mldts_op *op) { - uint32_t output_size; - output_size = op->mldts.num_layers * op->mldts.num_rbs * op->mldts.c_rep; + uint32_t output_size = 0; + uint16_t i; + + for (i = 0; i < op->mldts.num_layers; i++) + output_size += op->mldts.q_m[i]; + + output_size *= 12 * 8 * op->mldts.num_rbs * (op->mldts.c_rep + 1); + return output_size; } From patchwork Mon Apr 22 19:07:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hernan Vargas X-Patchwork-Id: 139630 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04A9843EDD; Mon, 22 Apr 2024 21:11:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C739640395; Mon, 22 Apr 2024 21:11:38 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id 839B2402C5; Mon, 22 Apr 2024 21:11:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713813094; x=1745349094; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=NEecPZy4s2m+H49jr/WpaOjrI2Y3JbJ5TEZLqzVGhlk=; b=FNcbeHJKJRleKgG+iyh84IRUqcFnBQEMff70EDvW+abshafIZ1GGnX0m SJKYr7XYkdeafdKkJAuqSbFPIBnGiYASUZC1vZmLGwXxYT7jrG+EWcsYh 2wq1iuPk1t/RWWdIn8QB4rLG1bCrCMN6owH+tLlFqIkGaY0hszVESxAWa vmD89Ei33eN6N/S8AU5ieRAZufhMx8x5Ae4p3Y8Ha/0HWwwtuYMgpWH5u +4vH72CbYpn3gnVZId+ofDQinicNOQe7AvvC1Y29yrRgknv5YuiA8OcsS z2LB+r3XwXnbYHLJ/oYSuEFESJOHggeKSFuMWuJPNo7KOkHw3cvl3pC/r w==; X-CSE-ConnectionGUID: reoeVv79RuuAfY8/oJd2oA== X-CSE-MsgGUID: riUYnfhPQXi9zzbqEipfsg== X-IronPort-AV: E=McAfee;i="6600,9927,11052"; a="19922802" X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="19922802" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2024 12:11:33 -0700 X-CSE-ConnectionGUID: VOymZTCpSQuNz5sVUncbuA== X-CSE-MsgGUID: 66EOOVFWTd6dwACf2jIC+Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="24555952" Received: from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103]) by orviesa006.jf.intel.com with ESMTP; 22 Apr 2024 12:11:32 -0700 From: Hernan Vargas To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com, maxime.coquelin@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, Hernan Vargas , stable@dpdk.org Subject: [PATCH v1 3/9] test/bbdev: fix interrupt tests Date: Mon, 22 Apr 2024 12:07:54 -0700 Message-Id: <20240422190800.123027-4-hernan.vargas@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20240422190800.123027-1-hernan.vargas@intel.com> References: <20240422190800.123027-1-hernan.vargas@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Fix possible error with regards to setting the burst size from the enqueue thread. Fixes: b2e2aec3239e ("app/bbdev: enhance interrupt test") Cc: stable@dpdk.org Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 98 ++++++++++++++++---------------- 1 file changed, 49 insertions(+), 49 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 9ed0c4648d24..28d78e73a9c1 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -3406,15 +3406,6 @@ throughput_intr_lcore_ldpc_dec(void *arg) if (unlikely(num_to_process - enqueued < num_to_enq)) num_to_enq = num_to_process - enqueued; - enq = 0; - do { - enq += rte_bbdev_enqueue_ldpc_dec_ops( - tp->dev_id, - queue_id, &ops[enqueued], - num_to_enq); - } while (unlikely(num_to_enq != enq)); - enqueued += enq; - /* Write to thread burst_sz current number of enqueued * descriptors. It ensures that proper number of * descriptors will be dequeued in callback @@ -3424,6 +3415,15 @@ throughput_intr_lcore_ldpc_dec(void *arg) */ __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED); + enq = 0; + do { + enq += rte_bbdev_enqueue_ldpc_dec_ops( + tp->dev_id, + queue_id, &ops[enqueued], + num_to_enq); + } while (unlikely(num_to_enq != enq)); + enqueued += enq; + /* Wait until processing of previous batch is * completed */ @@ -3498,14 +3498,6 @@ throughput_intr_lcore_dec(void *arg) if (unlikely(num_to_process - enqueued < num_to_enq)) num_to_enq = num_to_process - enqueued; - enq = 0; - do { - enq += rte_bbdev_enqueue_dec_ops(tp->dev_id, - queue_id, &ops[enqueued], - num_to_enq); - } while (unlikely(num_to_enq != enq)); - enqueued += enq; - /* Write to thread burst_sz current number of enqueued * descriptors. It ensures that proper number of * descriptors will be dequeued in callback @@ -3515,6 +3507,14 @@ throughput_intr_lcore_dec(void *arg) */ __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED); + enq = 0; + do { + enq += rte_bbdev_enqueue_dec_ops(tp->dev_id, + queue_id, &ops[enqueued], + num_to_enq); + } while (unlikely(num_to_enq != enq)); + enqueued += enq; + /* Wait until processing of previous batch is * completed */ @@ -3584,14 +3584,6 @@ throughput_intr_lcore_enc(void *arg) if (unlikely(num_to_process - enqueued < num_to_enq)) num_to_enq = num_to_process - enqueued; - enq = 0; - do { - enq += rte_bbdev_enqueue_enc_ops(tp->dev_id, - queue_id, &ops[enqueued], - num_to_enq); - } while (unlikely(enq != num_to_enq)); - enqueued += enq; - /* Write to thread burst_sz current number of enqueued * descriptors. It ensures that proper number of * descriptors will be dequeued in callback @@ -3601,6 +3593,14 @@ throughput_intr_lcore_enc(void *arg) */ __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED); + enq = 0; + do { + enq += rte_bbdev_enqueue_enc_ops(tp->dev_id, + queue_id, &ops[enqueued], + num_to_enq); + } while (unlikely(enq != num_to_enq)); + enqueued += enq; + /* Wait until processing of previous batch is * completed */ @@ -3672,15 +3672,6 @@ throughput_intr_lcore_ldpc_enc(void *arg) if (unlikely(num_to_process - enqueued < num_to_enq)) num_to_enq = num_to_process - enqueued; - enq = 0; - do { - enq += rte_bbdev_enqueue_ldpc_enc_ops( - tp->dev_id, - queue_id, &ops[enqueued], - num_to_enq); - } while (unlikely(enq != num_to_enq)); - enqueued += enq; - /* Write to thread burst_sz current number of enqueued * descriptors. It ensures that proper number of * descriptors will be dequeued in callback @@ -3690,6 +3681,15 @@ throughput_intr_lcore_ldpc_enc(void *arg) */ __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED); + enq = 0; + do { + enq += rte_bbdev_enqueue_ldpc_enc_ops( + tp->dev_id, + queue_id, &ops[enqueued], + num_to_enq); + } while (unlikely(enq != num_to_enq)); + enqueued += enq; + /* Wait until processing of previous batch is * completed */ @@ -3761,14 +3761,6 @@ throughput_intr_lcore_fft(void *arg) if (unlikely(num_to_process - enqueued < num_to_enq)) num_to_enq = num_to_process - enqueued; - enq = 0; - do { - enq += rte_bbdev_enqueue_fft_ops(tp->dev_id, - queue_id, &ops[enqueued], - num_to_enq); - } while (unlikely(enq != num_to_enq)); - enqueued += enq; - /* Write to thread burst_sz current number of enqueued * descriptors. It ensures that proper number of * descriptors will be dequeued in callback @@ -3778,6 +3770,14 @@ throughput_intr_lcore_fft(void *arg) */ __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED); + enq = 0; + do { + enq += rte_bbdev_enqueue_fft_ops(tp->dev_id, + queue_id, &ops[enqueued], + num_to_enq); + } while (unlikely(enq != num_to_enq)); + enqueued += enq; + /* Wait until processing of previous batch is * completed */ @@ -3844,13 +3844,6 @@ throughput_intr_lcore_mldts(void *arg) if (unlikely(num_to_process - enqueued < num_to_enq)) num_to_enq = num_to_process - enqueued; - enq = 0; - do { - enq += rte_bbdev_enqueue_mldts_ops(tp->dev_id, - queue_id, &ops[enqueued], num_to_enq); - } while (unlikely(enq != num_to_enq)); - enqueued += enq; - /* Write to thread burst_sz current number of enqueued * descriptors. It ensures that proper number of * descriptors will be dequeued in callback @@ -3860,6 +3853,13 @@ throughput_intr_lcore_mldts(void *arg) */ __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED); + enq = 0; + do { + enq += rte_bbdev_enqueue_mldts_ops(tp->dev_id, + queue_id, &ops[enqueued], num_to_enq); + } while (unlikely(enq != num_to_enq)); + enqueued += enq; + /* Wait until processing of previous batch is * completed */ From patchwork Mon Apr 22 19:07:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hernan Vargas X-Patchwork-Id: 139631 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A52AF43EDD; Mon, 22 Apr 2024 21:12:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6324B4069F; Mon, 22 Apr 2024 21:11:40 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id E9FC640265 for ; Mon, 22 Apr 2024 21:11:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713813094; x=1745349094; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PW4nRZlAX0vZnhj3auU+EcBrV4aJtdh16HVKMCOiaHE=; b=gV1yJIrLssIoB87grPLuPK45xrLTo+Aum5sAx49V6jakiuaMhxa5BCi/ E+efuzerCE2myXwTfnwoDLKpicJkmF+Zayc3q2mlHI6v5jdi1Uia04K+x ObxxP8/KXdceaU3Wso5QRkXoqjJt044teicRmnvfTAoJSIGqEzq+vFpY7 FEmFXLxFdGVnMYh3B5PzVHuUgoJvYsnPGby6uOTSqqme8x2MzSf1MPC5l eMYJBm2RwvT0UiwAvBX9CP2gFJ3wpvZxaTSSu+n18hTDXbEEcoO8d27Z/ 4ZH26qEkSbtXZNboh3Sl76b+Kiiy07iTwN3dHeaWKLNt5VupADSYx0h86 A==; X-CSE-ConnectionGUID: +/QghQ1uT+O1tU/QAH58aA== X-CSE-MsgGUID: MZLH5l+pTkKUaEdGqlYKsg== X-IronPort-AV: E=McAfee;i="6600,9927,11052"; a="19922805" X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="19922805" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2024 12:11:34 -0700 X-CSE-ConnectionGUID: 99xuzSHYTZqhgLKdGhFWVw== X-CSE-MsgGUID: R1iH5llFQfyxh86V92K2hg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="24555960" Received: from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103]) by orviesa006.jf.intel.com with ESMTP; 22 Apr 2024 12:11:33 -0700 From: Hernan Vargas To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com, maxime.coquelin@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, Hernan Vargas Subject: [PATCH v1 4/9] test/bbdev: change iter-max argument Date: Mon, 22 Apr 2024 12:07:55 -0700 Message-Id: <20240422190800.123027-5-hernan.vargas@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20240422190800.123027-1-hernan.vargas@intel.com> References: <20240422190800.123027-1-hernan.vargas@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org -t --iter-max used for max number of iterations. -T --timeout used for test timeout value. Signed-off-by: Hernan Vargas --- app/test-bbdev/test-bbdev.py | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/app/test-bbdev/test-bbdev.py b/app/test-bbdev/test-bbdev.py index 65a34390548d..9ddca9e78d3b 100755 --- a/app/test-bbdev/test-bbdev.py +++ b/app/test-bbdev/test-bbdev.py @@ -27,16 +27,10 @@ def kill(process): parser.add_argument("-e", "--eal-params", help="EAL arguments which must be passed to the test app", default="--vdev=baseband_null0 -a00:00.0") -# Until deprecated in next release keep -t as an valid argument for timeout, then use -T -parser.add_argument("-t", "--timeout", +parser.add_argument("-T", "--timeout", type=int, help="Timeout in seconds", default=600) -# This will become -t option for iter_max in next release -parser.add_argument("--iter-max", - type=int, - help="Max iterations", - default=6) parser.add_argument("-c", "--test-cases", nargs="+", help="Defines test cases to run. Run all if not specified") @@ -58,6 +52,10 @@ def kill(process): type=int, help="SNR in dB for BLER tests", default=0) +parser.add_argument("-t", "--iter-max", + type=int, + help="Max iterations", + default=6) parser.add_argument("-l", "--num-lcores", type=int, help="Number of lcores to run.", @@ -83,10 +81,6 @@ def kill(process): if args.iter_max: params.extend(["-t", str(args.iter_max)]) - print("The argument for iter_max will be -t in next release") - -if args.timeout: - print("The argument for timeout will be -T in next release") if args.num_ops: params.extend(["-n", str(args.num_ops)]) From patchwork Mon Apr 22 19:07:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hernan Vargas X-Patchwork-Id: 139632 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82F2943EDD; Mon, 22 Apr 2024 21:12:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A165A406B8; Mon, 22 Apr 2024 21:11:41 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id 6DA02402C5 for ; Mon, 22 Apr 2024 21:11:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713813095; x=1745349095; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=q165fa5GLV5E3YfeuZ1NKbpXk1tITzNc830t3txKboQ=; b=Q7QyT2SPXGT7cGPKDT7kcQXMBFv7VjsTh47S7KAnvobUki/STQ0c1qw+ xPCQ66qBWVgzYi3DNGO3k/y56YuCnFH/cSdhRcxnO6i7TGcPm/C+GJUDN kK08WHuMs/aDOotoEtwNxPls79r3KGMOOs3EMDRCJ98aSXcWStirarhb+ CUGNYLs/4Ukd5vUm8K5kD9YVnvw7v3ukffBD+UIro5m9j9aM7WO6GjreN tCngorqEGx6tqPbD8Hibq1PqdgaTThuey56NrED4+xVVsDtqQgtcXaa6F HohpWvRxpsNEC06uLQtBlvlNh0dbc4CPXJjAUYDtdmbAefchlQgtp1+oR w==; X-CSE-ConnectionGUID: s0Qr2x20S8u09m/AuhK/Zw== X-CSE-MsgGUID: 6g20cRnUQlWzrU4EY9Fn1w== X-IronPort-AV: E=McAfee;i="6600,9927,11052"; a="19922809" X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="19922809" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2024 12:11:34 -0700 X-CSE-ConnectionGUID: vYBpQT7MRh6SVsdu68ixXQ== X-CSE-MsgGUID: XnEsOpCoRHGBfeoTfq5xAg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="24555964" Received: from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103]) by orviesa006.jf.intel.com with ESMTP; 22 Apr 2024 12:11:33 -0700 From: Hernan Vargas To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com, maxime.coquelin@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, Hernan Vargas Subject: [PATCH v1 5/9] test/bbdev: improve timeout message format Date: Mon, 22 Apr 2024 12:07:56 -0700 Message-Id: <20240422190800.123027-6-hernan.vargas@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20240422190800.123027-1-hernan.vargas@intel.com> References: <20240422190800.123027-1-hernan.vargas@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Print more info and format message for test timeouts. No functional impact. Signed-off-by: Hernan Vargas --- app/test-bbdev/test-bbdev.py | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/app/test-bbdev/test-bbdev.py b/app/test-bbdev/test-bbdev.py index 9ddca9e78d3b..d5b679f7867f 100755 --- a/app/test-bbdev/test-bbdev.py +++ b/app/test-bbdev/test-bbdev.py @@ -108,15 +108,29 @@ def kill(process): try: output = subprocess.run(call_params, timeout=args.timeout, universal_newlines=True) except subprocess.TimeoutExpired as e: + print("===========================================================") print("Starting Test Suite : BBdev TimeOut Tests") + print("INFO: One of the tests timed out {}".format(e)) + print("INFO: Unexpected Error") + print("+ ------------------------------------------------------- +") print("== test: timeout") - print("TestCase [ 0] : timeout passed") - print(" + Tests Failed : 1") print("Unexpected Error") + print("TestCase [ 0] : timeout failed") + print(" + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +") + print(" + Tests Failed : 1") + print(" + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +") + exit_status = 1 if output.returncode < 0: + print("===========================================================") print("Starting Test Suite : BBdev Exception Tests") + print("INFO: One of the tests returned {}".format(output.returncode)) + print("INFO: Unexpected Error") + print("+ ------------------------------------------------------- +") print("== test: exception") - print("TestCase [ 0] : exception passed") - print(" + Tests Failed : 1") print("Unexpected Error") + print("TestCase [ 0] : exception failed") + print(" + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +") + print(" + Tests Failed : 1") + print(" + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +") + exit_status = 1 sys.exit(exit_status) From patchwork Mon Apr 22 19:07:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hernan Vargas X-Patchwork-Id: 139633 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D29F243EDD; Mon, 22 Apr 2024 21:12:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3391540A4B; Mon, 22 Apr 2024 21:11:43 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id 165A6402C5 for ; Mon, 22 Apr 2024 21:11:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713813095; x=1745349095; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jogSBMD3h3P9DA8rRttQmI1GPrOKqBn67b5hRPxusbA=; b=YWHylJrtzQAMuQbYKKbeFHRdVQpw9t6v3uJ7Gs3xMo8BKnQAVc4g0cJl ilqld2UwJsmK0aNejiAr9VmH20Z5BSV9lAaNhiu+aU/reOOZXxzu1tI5C Qa1P6r6tatxSsS1zwxj7oBoMJ3UVOK8y46SjQOPaDpZKmPqEWlkNtECAH XHaNS3QlJ6mDSbLFTCCzQIRxGiqhodCoUGm6ZYhMoQEyX/gdsoQukD6Dg 9GQW2YouctCrF9atG6nqMdzBZhL/ppanMXv8kaTz9PaqOu+WzckJd8pXw uK3ysS0SCI8fNrTL79pRHWVOsrdZdw1dRga7wxQzDAUcpVT1hUPVFBVFi w==; X-CSE-ConnectionGUID: 5+ZhfWNkT/C4987mp5uX6w== X-CSE-MsgGUID: XURmOvd0RUOCVqfRlUWkXQ== X-IronPort-AV: E=McAfee;i="6600,9927,11052"; a="19922814" X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="19922814" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2024 12:11:35 -0700 X-CSE-ConnectionGUID: WRnMPMMNQ0GXGndmQG1ZmQ== X-CSE-MsgGUID: 33DChSTDQwSeTYsfScdP/A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="24555967" Received: from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103]) by orviesa006.jf.intel.com with ESMTP; 22 Apr 2024 12:11:34 -0700 From: Hernan Vargas To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com, maxime.coquelin@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, Hernan Vargas Subject: [PATCH v1 6/9] test/bbdev: add soft output parsing capability Date: Mon, 22 Apr 2024 12:07:57 -0700 Message-Id: <20240422190800.123027-7-hernan.vargas@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20240422190800.123027-1-hernan.vargas@intel.com> References: <20240422190800.123027-1-hernan.vargas@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add vector parsing capability for soft output vectors. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_vector.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-bbdev/test_bbdev_vector.c index 42fa630041e9..b3e9d4bb7504 100644 --- a/app/test-bbdev/test_bbdev_vector.c +++ b/app/test-bbdev/test_bbdev_vector.c @@ -837,6 +837,10 @@ parse_ldpc_decoder_params(const char *key_token, char *token, ret = parse_data_entry(key_token, token, vector, DATA_HARQ_OUTPUT, op_data_prefixes[DATA_HARQ_OUTPUT]); + else if (starts_with(key_token, op_data_prefixes[DATA_SOFT_OUTPUT])) + ret = parse_data_entry(key_token, token, vector, + DATA_SOFT_OUTPUT, + op_data_prefixes[DATA_SOFT_OUTPUT]); else if (!strcmp(key_token, "e")) { vector->mask |= TEST_BBDEV_VF_E; ldpc_dec->cb_params.e = (uint32_t) strtoul(token, &err, 0); From patchwork Mon Apr 22 19:07:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hernan Vargas X-Patchwork-Id: 139634 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FE5043EDD; Mon, 22 Apr 2024 21:12:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C6FC40A71; Mon, 22 Apr 2024 21:11:44 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id 67E2D402F0 for ; Mon, 22 Apr 2024 21:11:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713813096; x=1745349096; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Yoja6VPQ2sIc9oxPMcik3HfIHnvvsfFXkFXnhcTn++w=; b=NUaHY9f8AZNb6e51cjW4MIz+omo8O208Aclb7kvDuIZKvffKm4W5Wlpu mwMpwqBClnJoAeVXbTo7LCY5Iix9K5pF4oa/+uKjlnlS7jUzqVbHpXC9m pfhsXNilN5J/FTJOviQuhtkGBPQQ7ay4pd0WdBrwAAP6dDsoE8F71yOsP q3ygVI/e1JM/EK8d/iTuyyMpYGu9DIKaFtjW3hnYO+V6MtHbed5O32zg/ a7oLmG2GeRdamnJLTAUR34nsorHQ/maI3wQcuS11dq7IamOeGW1FmnTrV FKTXog+1TDOJzvLu/+ni3nTGZAfPXS2ExznLDyE94uCu8LaSm0G01p7nq w==; X-CSE-ConnectionGUID: 8DLLYyFjQheq6FoM9Ccnog== X-CSE-MsgGUID: B7lmTq7VT9SRReJE3jO9ZQ== X-IronPort-AV: E=McAfee;i="6600,9927,11052"; a="19922817" X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="19922817" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2024 12:11:35 -0700 X-CSE-ConnectionGUID: g8n7etWGQGqvgE6D+PJfVg== X-CSE-MsgGUID: wr0a78ZeSZyfhL3nbQhSWw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="24555972" Received: from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103]) by orviesa006.jf.intel.com with ESMTP; 22 Apr 2024 12:11:34 -0700 From: Hernan Vargas To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com, maxime.coquelin@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, Hernan Vargas Subject: [PATCH v1 7/9] test/bbdev: check assumptions on fft window Date: Mon, 22 Apr 2024 12:07:58 -0700 Message-Id: <20240422190800.123027-8-hernan.vargas@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20240422190800.123027-1-hernan.vargas@intel.com> References: <20240422190800.123027-1-hernan.vargas@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add check for FFT window width. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 26 ++++++++++++++++++++++---- app/test-bbdev/test_bbdev_vector.c | 14 ++++++++++++++ app/test-bbdev/test_bbdev_vector.h | 2 ++ 3 files changed, 38 insertions(+), 4 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 28d78e73a9c1..57b21730cab2 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -106,6 +106,8 @@ static int ldpc_llr_decimals; static int ldpc_llr_size; /* Keep track of the LDPC decoder device capability flag */ static uint32_t ldpc_cap_flags; +/* FFT window width predefined on device and on vector. */ +static int fft_window_width_dev; /* Represents tested active devices */ static struct active_device { @@ -881,6 +883,13 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info, rte_bbdev_info_get(dev_id, info); if (info->drv.device_status == RTE_BBDEV_DEV_FATAL_ERR) printf("Device Status %s\n", rte_bbdev_device_status_str(info->drv.device_status)); + if (info->drv.fft_window_width != NULL) + fft_window_width_dev = info->drv.fft_window_width[0]; + else + fft_window_width_dev = 0; + if (fft_window_width_dev != 0) + printf(" FFT Window0 width %d\n", fft_window_width_dev); + nb_queues = RTE_MIN(rte_lcore_count(), info->drv.max_num_queues); nb_queues = RTE_MIN(nb_queues, (unsigned int) MAX_QUEUES); @@ -2583,7 +2592,8 @@ validate_ldpc_enc_op(struct rte_bbdev_enc_op **ops, const uint16_t n, } static inline int -validate_op_fft_chain(struct rte_bbdev_op_data *op, struct op_data_entries *orig_op) +validate_op_fft_chain(struct rte_bbdev_op_data *op, struct op_data_entries *orig_op, + bool skip_validate_output) { struct rte_mbuf *m = op->data; uint8_t i, nb_dst_segments = orig_op->nb_segments; @@ -2613,7 +2623,7 @@ validate_op_fft_chain(struct rte_bbdev_op_data *op, struct op_data_entries *orig abs_delt = delt > 0 ? delt : -delt; error_num += (abs_delt > thres_hold ? 1 : 0); } - if (error_num > 0) { + if ((error_num > 0) && !skip_validate_output) { rte_memdump(stdout, "Buffer A", ref_out, data_len); rte_memdump(stdout, "Buffer B", op_out, data_len); TEST_ASSERT(error_num == 0, @@ -2686,16 +2696,24 @@ validate_fft_op(struct rte_bbdev_fft_op **ops, const uint16_t n, int ret; struct op_data_entries *fft_data_orig = &test_vector.entries[DATA_HARD_OUTPUT]; struct op_data_entries *fft_pwr_orig = &test_vector.entries[DATA_SOFT_OUTPUT]; + bool skip_validate_output = false; + + if ((test_vector.fft_window_width_vec > 0) && + (test_vector.fft_window_width_vec != fft_window_width_dev)) { + printf("The vector FFT width doesn't match with device - skip %d %d\n", + test_vector.fft_window_width_vec, fft_window_width_dev); + skip_validate_output = true; + } for (i = 0; i < n; ++i) { ret = check_fft_status_and_ordering(ops[i], i, ref_op->status); TEST_ASSERT_SUCCESS(ret, "Checking status and ordering for FFT failed"); TEST_ASSERT_SUCCESS(validate_op_fft_chain( - &ops[i]->fft.base_output, fft_data_orig), + &ops[i]->fft.base_output, fft_data_orig, skip_validate_output), "FFT Output buffers (op=%u) are not matched", i); if (check_bit(ops[i]->fft.op_flags, RTE_BBDEV_FFT_POWER_MEAS)) TEST_ASSERT_SUCCESS(validate_op_fft_chain( - &ops[i]->fft.power_meas_output, fft_pwr_orig), + &ops[i]->fft.power_meas_output, fft_pwr_orig, skip_validate_output), "FFT Power Output buffers (op=%u) are not matched", i); } diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-bbdev/test_bbdev_vector.c index b3e9d4bb7504..e48947b211ac 100644 --- a/app/test-bbdev/test_bbdev_vector.c +++ b/app/test-bbdev/test_bbdev_vector.c @@ -1050,6 +1050,20 @@ parse_fft_params(const char *key_token, char *token, } } ret = ((err == NULL) || (*err != '\0')) ? -1 : 0; + } else if (!strcmp(key_token, "fft_window_width")) { + tok = strtok(token, VALUE_DELIMITER); + if (tok == NULL) + return -1; + for (i = 0; i < FFT_WIN_SIZE; i++) { + if (i == 0) + vector->fft_window_width_vec = (uint32_t) strtoul(tok, &err, 0); + if (i < (FFT_WIN_SIZE - 1)) { + tok = strtok(NULL, VALUE_DELIMITER); + if (tok == NULL) + return -1; + } + } + ret = ((err == NULL) || (*err != '\0')) ? -1 : 0; } else if (!strcmp(key_token, "op_flags")) { vector->mask |= TEST_BBDEV_VF_OP_FLAGS; ret = parse_turbo_flags(token, &op_flags, vector->op_type); diff --git a/app/test-bbdev/test_bbdev_vector.h b/app/test-bbdev/test_bbdev_vector.h index 14b8ef2764ad..ba1d0d20f9ea 100644 --- a/app/test-bbdev/test_bbdev_vector.h +++ b/app/test-bbdev/test_bbdev_vector.h @@ -69,6 +69,8 @@ struct test_bbdev_vector { }; /* Additional storage for op data entries */ struct op_data_entries entries[DATA_NUM_TYPES]; + /* Vector FFT window width assumption. */ + uint16_t fft_window_width_vec; }; /* fills test vector parameters based on test file */ From patchwork Mon Apr 22 19:07:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hernan Vargas X-Patchwork-Id: 139635 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F59743EDD; Mon, 22 Apr 2024 21:12:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1AD840A8B; Mon, 22 Apr 2024 21:11:46 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id EC2B9402C5 for ; Mon, 22 Apr 2024 21:11:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713813096; x=1745349096; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=WjFTOCV68sgZ48p+4zvrvWZyj370txY2WUuzEH0S6Lo=; b=dnP6KlRzZjP4Yg0az1gaiFttf63fbCD5Mx9eFtQDUqDYdhvL2lP1+syS 8fwtmt360Qn6i3HB2TccxA4DWeVwN8cmlvCEI6gKcI6ETcIqeOlZa0bbg MIctD6prenFq1dWqJH+ffZJX0w7EyFPx6H5IvQ/aErs0JzvCBzDZGX2H+ AH0kyWIyN5/AFqd/RiSU7CUfAWcN5tQFKQDX38NvaZe25Qcj7PtpK6B+8 2Ck/9Agna/33A2J3B4wFVLQ8qvwWR4WrurNcu830S/fmudFOAHehwz9R3 QaNC74f6o6LpLRJl4hMv+0MsEb2N/uG+EZhLqat5X+BI5p0v8NMbtljdz g==; X-CSE-ConnectionGUID: hl1+AkGwST62st0t9UBvQQ== X-CSE-MsgGUID: SyNlTq25ToS0agjlz7x/Qw== X-IronPort-AV: E=McAfee;i="6600,9927,11052"; a="19922822" X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="19922822" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2024 12:11:36 -0700 X-CSE-ConnectionGUID: QhmHSAgtRROUHIfkTEL0TA== X-CSE-MsgGUID: hlf8MB70QQeIewBn0FbrOg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="24555975" Received: from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103]) by orviesa006.jf.intel.com with ESMTP; 22 Apr 2024 12:11:35 -0700 From: Hernan Vargas To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com, maxime.coquelin@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, Hernan Vargas Subject: [PATCH v1 8/9] test/bbdev: update fft measurement output Date: Mon, 22 Apr 2024 12:07:59 -0700 Message-Id: <20240422190800.123027-9-hernan.vargas@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20240422190800.123027-1-hernan.vargas@intel.com> References: <20240422190800.123027-1-hernan.vargas@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Update check for FFT measurement output to better account for tolerance. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 52 +++++++++++++++++++++++++++++++- 1 file changed, 51 insertions(+), 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 57b21730cab2..639e67a937b2 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -2637,6 +2637,56 @@ validate_op_fft_chain(struct rte_bbdev_op_data *op, struct op_data_entries *orig return TEST_SUCCESS; } +static inline int +validate_op_fft_meas_chain(struct rte_bbdev_op_data *op, struct op_data_entries *orig_op, + bool skip_validate_output) +{ + struct rte_mbuf *m = op->data; + uint8_t i, nb_dst_segments = orig_op->nb_segments; + double thres_hold = 1.0; + uint32_t j, data_len_iq, error_num; + int32_t *ref_out, *op_out; + double estSNR, refSNR, delt, abs_delt; + + TEST_ASSERT(nb_dst_segments == m->nb_segs, + "Number of segments differ in original (%u) and filled (%u) op fft", + nb_dst_segments, m->nb_segs); + + /* Due to size limitation of mbuf, FFT doesn't use real mbuf. */ + for (i = 0; i < nb_dst_segments; ++i) { + uint16_t offset = (i == 0) ? op->offset : 0; + uint32_t data_len = op->length; + + TEST_ASSERT(orig_op->segments[i].length == data_len, + "Length of segment differ in original (%u) and filled (%u) op fft", + orig_op->segments[i].length, data_len); + + /* Divided by 4 to get the number of 32 bits data. */ + data_len_iq = data_len >> 2; + ref_out = (int32_t *)(orig_op->segments[i].addr); + op_out = rte_pktmbuf_mtod_offset(m, int32_t *, offset); + error_num = 0; + for (j = 0; j < data_len_iq; j++) { + estSNR = 10*log10(op_out[j]); + refSNR = 10*log10(ref_out[j]); + delt = refSNR - estSNR; + abs_delt = delt > 0 ? delt : -delt; + error_num += (abs_delt > thres_hold ? 1 : 0); + } + if ((error_num > 0) && !skip_validate_output) { + rte_memdump(stdout, "Buffer A", ref_out, data_len); + rte_memdump(stdout, "Buffer B", op_out, data_len); + TEST_ASSERT(error_num == 0, + "FFT Output are not matched total (%u) errors (%u)", + data_len_iq, error_num); + } + + m = m->next; + } + + return TEST_SUCCESS; +} + static inline int validate_op_mldts_chain(struct rte_bbdev_op_data *op, struct op_data_entries *orig_op) @@ -2712,7 +2762,7 @@ validate_fft_op(struct rte_bbdev_fft_op **ops, const uint16_t n, &ops[i]->fft.base_output, fft_data_orig, skip_validate_output), "FFT Output buffers (op=%u) are not matched", i); if (check_bit(ops[i]->fft.op_flags, RTE_BBDEV_FFT_POWER_MEAS)) - TEST_ASSERT_SUCCESS(validate_op_fft_chain( + TEST_ASSERT_SUCCESS(validate_op_fft_meas_chain( &ops[i]->fft.power_meas_output, fft_pwr_orig, skip_validate_output), "FFT Power Output buffers (op=%u) are not matched", i); } From patchwork Mon Apr 22 19:08:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hernan Vargas X-Patchwork-Id: 139636 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3538A43EDD; Mon, 22 Apr 2024 21:12:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7404840DDC; Mon, 22 Apr 2024 21:11:48 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id 8034340268 for ; Mon, 22 Apr 2024 21:11:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713813097; x=1745349097; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=YHTmoO9cIDaWF3ley48k40u1Pg2C7UK16I7kPA9kRjE=; b=gQDQ7mK5kFQtVCtn/urMt5BGqUhMD57wEfp7cezqO6y0ROYNVuL/IZyh 8fT6QO7tIglx8O4xWt01VJ33zar5BgLMqzhlmPMYGQNkvlcgYWMQGBX9P Kk5fq0InkEX/vZneB1NqfK7MypwX5NzQKv7gxer0upMoHtRhlLcffom5t yectRZCo8JsDF0/ZdKTaeUGlBwIneRSFPFO8x15Nne2l7cjgz+GJgWsmD owtATLguF8YohFKNvt5LOUtIa1hoU2HuTBkcln5c9gSrTp+Zgg2DKig5M w4BcE0qjhT0WhgL6vAAUXaN0qLHctpp5qx/ZH0LLqE2q4bp63G6Rg2pjC w==; X-CSE-ConnectionGUID: xZpd5wI9SYazBVlN+9mzAQ== X-CSE-MsgGUID: n2bUrFYRTqm1wHwIV0gNgQ== X-IronPort-AV: E=McAfee;i="6600,9927,11052"; a="19922827" X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="19922827" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2024 12:11:36 -0700 X-CSE-ConnectionGUID: xr5bCeG3QYCsWBh0Q5SkPw== X-CSE-MsgGUID: pPAG7ZxdR7uAZ3O0VGV+oQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="24555979" Received: from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103]) by orviesa006.jf.intel.com with ESMTP; 22 Apr 2024 12:11:36 -0700 From: Hernan Vargas To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com, maxime.coquelin@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, Hernan Vargas Subject: [PATCH v1 9/9] test/bbdev: remove unnecessary line Date: Mon, 22 Apr 2024 12:08:00 -0700 Message-Id: <20240422190800.123027-10-hernan.vargas@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20240422190800.123027-1-hernan.vargas@intel.com> References: <20240422190800.123027-1-hernan.vargas@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove unnecesary line of code. No functional impact. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev.c b/app/test-bbdev/test_bbdev.c index cf224dca5d04..0bbce6ca923b 100644 --- a/app/test-bbdev/test_bbdev.c +++ b/app/test-bbdev/test_bbdev.c @@ -1239,7 +1239,6 @@ test_bbdev_invalid_driver(void) TEST_ASSERT_SUCCESS(rte_bbdev_callback_unregister(dev_id, RTE_BBDEV_EVENT_UNKNOWN, event_callback, NULL), "Failed to unregister RTE_BBDEV_EVENT_ERROR "); - dev2->dev_ops = dev1.dev_ops; /* Tests for rte_bbdev_stats_reset */ dev2->dev_ops = NULL;