From patchwork Mon May 6 11:44:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 139880 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10A0543FB4; Mon, 6 May 2024 13:44:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D6B9402DD; Mon, 6 May 2024 13:44:42 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2058.outbound.protection.outlook.com [40.107.94.58]) by mails.dpdk.org (Postfix) with ESMTP id A30EF402D0; Mon, 6 May 2024 13:44:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=URyfgewun4kd205ki5PUo3zXEBVUFLY5LUKJJ0hQdoOWbX2lm5hf5Kc+ea1BMizRnrFDNXJLvVO/aIdO/P+YXpxqmiZyC7YZvaTYdNbPMklu7VSFROlhEnyyCvMbCvcEoGNzClDTyzm9g3g8jutI9yaAk4iGNiXWnDqd+Vq2AU989Y8wKoG7LB411SFoSdCSN86fSgmbEkehsh+pYo1wC6YDuID3cJaomDbZm0DzMdtFnPtJQKW3KaGxZdzRxZjrwwPMIYOu9A5ia37bXLUk9LHizGQmBc9h40uecWVkoniOLN7fSNB6JMn41SJ8d9H8n1cjs7FDYTJlg1zfnjUCnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6mOm5j9R7xwBlAq9OsnPzkMb7Uq5OMsIrWOqUP6J6QY=; b=hiQwgIu8jGCIiosUwbLk68pMqhmCVMALoXS8p7m4HM223EohvJ0TC6q/3wYldMyYWrZEzKKp2mNNUDDrL8Xy/QnnqfB1vOEf37H/AFwNnNUAhkgIKVp6RaJ+Y7c62OAanlYC2RyU9rBE/ZML+enxt7ftexMPjnlitT1rt68ipWVGMWVUd/hZlO7dH+2L5yjrulDgW0hYOymTBmbFY8+4gPAxRz018K4BFMUCVojPMxX2M7+MdWCCxWsmu2gvRMkCTo/jGiSHHgJiNq9e4EoFDKiaWPlGW3L+tHHgSKucZc4NKzG/rlgsB9i0Op1x99IJyG266llXDb8C3QZbf2PH1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6mOm5j9R7xwBlAq9OsnPzkMb7Uq5OMsIrWOqUP6J6QY=; b=YLVNHYEFPfm4Scfm7IEizsOwtC938+Yf7Ge0Re9m9wbldoYXzKgUFNa8pJLOooDTzQ5/jNECevgTzijLcl2kyPmWWRGbS4Y1R6SZhw2WTgq56vGP6icAaLfTPhKj57T47rOoKGnt9q/uSRUaqn2K0xBJ30qDNYFanRFgBt2aCSuuQgergTqHRPK3DXLzP6bre8q4alWkYtrfHf2Iz5ktUFVOLZ9fy5RErZvXwt3Ld+9IbrdGzrwjhNxBihJxdvCUC5+igLqobcUQ9fxO90dGOuUZUzItJKUpz7jH25qUP+Aibb49s2uAzdoCBaOLEyGzoPrUIgZ/OGLJupGWrqwofg== Received: from PH0PR07CA0026.namprd07.prod.outlook.com (2603:10b6:510:5::31) by DS7PR12MB8201.namprd12.prod.outlook.com (2603:10b6:8:ef::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Mon, 6 May 2024 11:44:35 +0000 Received: from CY4PEPF0000E9D5.namprd05.prod.outlook.com (2603:10b6:510:5:cafe::cb) by PH0PR07CA0026.outlook.office365.com (2603:10b6:510:5::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend Transport; Mon, 6 May 2024 11:44:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by CY4PEPF0000E9D5.mail.protection.outlook.com (10.167.241.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.18 via Frontend Transport; Mon, 6 May 2024 11:44:34 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:44:29 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:44:29 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 6 May 2024 04:44:25 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Matan Azrad , Mark Bloch , Alex Vesker CC: , Subject: [v2 01/16] net/mlx5/hws: move warn into debug level when needed Date: Mon, 6 May 2024 14:44:04 +0300 Message-ID: <20240506114419.966498-1-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240314114220.203241-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D5:EE_|DS7PR12MB8201:EE_ X-MS-Office365-Filtering-Correlation-Id: 6d9e8fd0-c200-43cb-08e3-08dc6dc1e67a X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|36860700004|82310400017|1800799015|376005|921011; X-Microsoft-Antispam-Message-Info: CC9KyonO82l1sXQcLsmkhG0f9DeAg6Rb2zpn2e+SbshMIgv3XmeO/opD1u72BdI3jj90VqdZW9IML7f+ybMTSRDmQAJdK1cF8ofLuA+jI9z8dMks2lRygTtoV1Ozvx2azTGnKAy3s0PynxAj0tk6t8vQLf4Dgz6uUOHzEkqafa49SKydArlOv9evxVZrUu4DGzyylrY840XhOAJCkOysuXDzkSmJ3VAFrdbyLpIncyvBgZ/wILZGJBCBQ/EmFlEdZMjgCsbeCIpdAuX+vU6Ves7MKDlptNQHTLapZRhpsA4CqJ4QUwDy316DdNxux0ARauhKWxVRnmkqCt8L9e5rP/6HMImEfxhUva4M2CqXNV0J38PZOidvKyfqxv2uhAymDRJrPCy3FVqCQ09dQwF1YavmgEW3JPWj9qFiRX7iW9PYUBV47frHTBs4554SjbwP/EfKvJPxJQmoGRy1c68yJ7hRuOVgJJlZ/dE1poegwB5Q8adm3ro9OhWkmwuCGBc/IM+soJb+T0KIe7d69tOciky9G/B4ngGHpyUiJrhbw6Klf/DQmLepQBiVZATZ0FFg6m7Xou63QmGo9pRFtVLRR/VTET+TEVwmNLxdl+BZ8c6QrbdtnTkAba5R6+VmAHiKsMCmeGT+cwnVPaNgCcLYAqd1QMdqda5mPstEW/vZ0X9YNgr65NWIPesoTRE+buXZj7qdyrpmsMqG9WOCGQ/5FYTKx969jj3UW3KifPNtlHzq6yXaoQtpY7ks83pOSxC5ALSjZ+awq+a/TRkEnDnbfzb3sc7Y1/UH0DPG3/gS1DRl7VCiAfjbaA3ktlDeY7MiksI4UAom3WiNcFzpJXqiTQWjTdCib1A37GYSkRFbNoUOXi1uV9ZnSCU1KYeyAJBo7CR/A4eU8uacts2G7HBMlp6SMguxINz3WpwbJrQeT/oMFIMWdMF/2pbituNEO5mj/GzVYrLmVMZ8c4tPUm5iprJrs4ySSp2Gs8xNtNIryjsZN2k3JjiWfb8jCswfOTa/Z0j6rypmu+w1JJklZxoE6eZTXkEA78P0sO7UXFu2fcUVeWy2iRwhX4gHs+ypFGTpjQcTj4Ife1E2SFP+Cn9IvbVHVxhFJTooTGisPU+3KXPjwnQ7mO4WgCMUy/Ffct5pE8vXfw3z0AXIW2VvYO3GgtQRfUsvxKzDHLaw2seGXM0pAnPYbcy5uHmDaA4noDAp33uLih24LQfbVVkkc2U1pWAKEpplCDkXMvo7vJCuo4NbkULDnzG1VQV+My3m81l89kTq05feqJMvy/TC9Gv4DM+3BB4ryu2oJ1Dx47Wq+BrSS2QnFW/bA/PvbbPB9hGT04QhUUt/EPrAZNQ2Cm3Gje+SuVctwNM+CBf1kDX9T5+MIOoJ2xIg1RjbMeVYPiGf X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230031)(36860700004)(82310400017)(1800799015)(376005)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 11:44:34.1547 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6d9e8fd0-c200-43cb-08e3-08dc6dc1e67a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8201 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Erez Shitrit When the user tries to create a matcher and if failed with specific errno (E2BIG) the message will be in debug level and not in warning. It is a part of a feature when the user re-try to insert a new matching depends on that errno, no need the annoying message. Fixes: c55c2bf35333 ("net/mlx5/hws: add definer layer") Cc: stable@dpdk.org Signed-off-by: Erez Shitrit Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_definer.c | 6 +++--- drivers/net/mlx5/hws/mlx5dr_matcher.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c index 35a2ed2048..81d0e0e6df 100644 --- a/drivers/net/mlx5/hws/mlx5dr_definer.c +++ b/drivers/net/mlx5/hws/mlx5dr_definer.c @@ -3534,7 +3534,7 @@ mlx5dr_definer_find_best_match_fit(struct mlx5dr_context *ctx, return 0; } - DR_LOG(ERR, "Unable to find supporting match/jumbo definer combination"); + DR_LOG(DEBUG, "Unable to find supporting match/jumbo definer combination"); rte_errno = E2BIG; return rte_errno; } @@ -3689,7 +3689,7 @@ mlx5dr_definer_calc_layout(struct mlx5dr_matcher *matcher, /* Find the match definer layout for header layout match union */ ret = mlx5dr_definer_find_best_match_fit(ctx, match_definer, match_hl); if (ret) { - DR_LOG(ERR, "Failed to create match definer from header layout"); + DR_LOG(DEBUG, "Failed to create match definer from header layout"); goto free_fc; } @@ -4041,7 +4041,7 @@ int mlx5dr_definer_matcher_init(struct mlx5dr_context *ctx, ret = mlx5dr_definer_calc_layout(matcher, &match_layout, &range_layout); if (ret) { - DR_LOG(ERR, "Failed to calculate matcher definer layout"); + DR_LOG(DEBUG, "Failed to calculate matcher definer layout"); return ret; } diff --git a/drivers/net/mlx5/hws/mlx5dr_matcher.c b/drivers/net/mlx5/hws/mlx5dr_matcher.c index 1c64abfa57..1213e7f0ad 100644 --- a/drivers/net/mlx5/hws/mlx5dr_matcher.c +++ b/drivers/net/mlx5/hws/mlx5dr_matcher.c @@ -877,7 +877,7 @@ static int mlx5dr_matcher_bind_mt(struct mlx5dr_matcher *matcher) /* Calculate match, range and hash definers */ ret = mlx5dr_definer_matcher_init(ctx, matcher); if (ret) { - DR_LOG(ERR, "Failed to set matcher templates with match definers"); + DR_LOG(DEBUG, "Failed to set matcher templates with match definers"); return ret; } From patchwork Mon May 6 11:44:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 139881 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDE0A43FB4; Mon, 6 May 2024 13:44:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA564402E3; Mon, 6 May 2024 13:44:47 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2069.outbound.protection.outlook.com [40.107.212.69]) by mails.dpdk.org (Postfix) with ESMTP id 1D5C0402E1; Mon, 6 May 2024 13:44:46 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ACkbuk7RJfUEDn9ID2i1TzlckR72mIDbxqSSrHfwx2SrZ+iaXD7yYganfVH3aI1iBd37dEl9JfvYO+Q9WVGWbMsF6jS/h5E7xgRClmFNn3dZxSI9NyeQddDq/ejglFxvqqr/ObouT5+LNH1sRxUUk/si8qQSzXaYdW4nQxGg82bYeUZcWeCzThsO+3KgywervNxO68NhlHzL9jEMjNoezhkriMKIJfI7bpiUfnNJVJglwfeK0TNPpC5zrauoZlb1DZcw3Vm/8sIYISR0fY8AZMiASvT/qyyKzB2upFtuwxOzXhJXzc/JzsAj38R9ZDiDjMpJScTMtFPib9OSesYi/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZhRdSC9cbjyqAFGbKxTmqmF0N5GTl+NuoD/SISivetI=; b=XwZPNP3FrspFM6tWS7S2/LKBTV4pmnRYxbBny6NwGUagmcGR2jiLRSmGFj94u5ALXC3mqzLti8Eh/sPy75snHUHHHGfDjSZhJQKytTScn5S8R6axVGl/usdRoTtXiOJTXlux1pQjpincrn0NpjhspPyQapq//V5LMsnU0NymRQqh+592/32PYb1tcdlxSldiKrp85pmnfZ6T+NgVY3Z/d6SnZgCy5/qiGpTf/XzYkFn7cRB5qASnW2mFYcLjLF47WIc5PK5chdwCE/siwiPQBt9zFZY757eUyRZioLoEbHAs2XzIZoACHGuZFfb9d4tAcwlsuz/mmvWe0PK8kHMk8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZhRdSC9cbjyqAFGbKxTmqmF0N5GTl+NuoD/SISivetI=; b=O0D3b1kY5cTqF0P5Cwvts0pqhBRRKUHwIZ/EiPS321FPhBiMYlSIkLdhPTpPGmxMuKY3mSPXrbmZptZwImvumbc6bl0/K7bX8dHcAqEC/GMPMYA1coonOKtrkxcdTQL9a/5rIGu7rQd8jFFFYK2iss8p8w1S2h+AjNZev/z2q1i/LFPwdYTN1pzW6zz15FzBOiTXNRsiEAmZTUEur1wQaFdkeT9bttfK+Rb9UGFUBOLL9yDw7dGBCcLcOtKR1KjwpnTgtxvxWm9soFP3TFLJnxvXDNjSiEsTKwiAQeXPNz3hS3T2+S3dRkfPEo3f9Ivd3gs7SexpfpeqGedBzYPfGQ== Received: from PH0PR07CA0023.namprd07.prod.outlook.com (2603:10b6:510:5::28) by IA1PR12MB8538.namprd12.prod.outlook.com (2603:10b6:208:455::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Mon, 6 May 2024 11:44:41 +0000 Received: from CY4PEPF0000E9D5.namprd05.prod.outlook.com (2603:10b6:510:5:cafe::d6) by PH0PR07CA0023.outlook.office365.com (2603:10b6:510:5::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend Transport; Mon, 6 May 2024 11:44:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by CY4PEPF0000E9D5.mail.protection.outlook.com (10.167.241.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.18 via Frontend Transport; Mon, 6 May 2024 11:44:41 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:44:33 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:44:33 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 6 May 2024 04:44:29 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Matan Azrad , Alex Vesker CC: , Subject: [v2 02/16] common/mlx5: fix error in mlx5 prm structs Date: Mon, 6 May 2024 14:44:05 +0300 Message-ID: <20240506114419.966498-2-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240506114419.966498-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> <20240506114419.966498-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D5:EE_|IA1PR12MB8538:EE_ X-MS-Office365-Filtering-Correlation-Id: aaa1b9b4-8275-4eaa-ff8a-08dc6dc1ea9e X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|1800799015|82310400017|376005|36860700004|921011; X-Microsoft-Antispam-Message-Info: DpbsBOcwZoXlna56U7cL1AgR/9njX5R+eLKc2Y5FhILPTnI+tctZcYPnIPp71LwVtURIWRWBp+jtw5bvXOmmK5/PMjF07rx36gW8lF+/bM8A3YUHF9IulxlQ9PYLQ/XeK50gIAwQNXBYclzXgOGU7wMNbb4pc+AMymMGm72tcBdWvcBurDGRWNxj6+JaY3WwX++NXijCCZ4G8y38PAyrJCnNm00/mlVFBtEDp5XMds3UlG/+CB6FOl53PJt/Fyj1/tvBYlC9gPrOO8PDop4W3h7UkEGkgeN2Tk8pi7eGixM+RUCebUd89/nd4H6n+lthiHKKIzV8wXbClr0UJLYj5qXU1RptH73tp6g/C11OWHFxmvWyppKkZ/PjcfI7muFbph6V507LQLytq4IvySTwbpU5A6E+gdYQQTWSCHE4lGCx2+HWRv+nQYpLKZa/J41xOtHUYuZ7pXczWCpS9Wxp/M2vylC+osIs4DYsT51Bz4TO4aHsqXExIrHMwUCryHkAamrpPf6vWj9ZRCK69QPfhEcUwKYCYw9yjdQqjXdYPJTx1B1WrP/HxGip8JtkZtnz4LGaGwP8zXJXdqnVwh3a1MQNXr5YUR+z7apEbV5Gu9JdBNgjvs4B0sggPr1xuNdJHcXtus4izMcTdUxSvFazZjFCqwo6hd75z2+jBG/+h36TRqVhSMqAXSl6Kq+uamCD/DRpy08Sz7fhatAEMv2LB9U/2PORLa2Ta0c9jDVWvQk3YPCYQdYA2rgXdSVAMQKt3o3//ZILPAd9VetA2l81+ANxs0Htx/l29aYaC/YT2dHSlpeF/rY+jpJDPaC9r1QxQkjAk+7AMu9mIc7xJJFNTt3mtc9ZD5WgPORqigl2nKJYlAAFmIVq0yaT13I9I2HipmNN5VfYrCCv9wSS4++WEStXmfFgN9AKZabRbbj+20lDzoQ1jwdIbv55eKsj21DX+Y4AuD227Q6FNn3v8GOgB7jXdMpj+p/s/yCK5zZcmc27Vy5f+OB/wQsyUhbRvRvsRgb674QVQuJWt+c4cb8+8WGKdndRIgNgRE4pX59jz/ji9XhiZ7ay71hUWOr+M5rEWxEB0fNSbQbP7Ki2NoTZFc7RHM730kjw+jRKm4xEQyZmYkkwq7jaZo2X9hVWEjcCuEo6z/kE27UhTCVvOQaYHuhQSFOVvD7HWhzuRab+JC96KaRuMN2FYY8QQbp2xGJiCco2Ww9t6KhhqUnZzTTTn9++n2+P90+QSMyUjXVYUaFKgiUq0+6is19RJx1/NhVwiWse7pL8h3U+dL1uzixtsnaittdspMYoqU1Ti9/zdY53guJKrOoRfRXtGU3p1NGnUKIWnEYZLMxRYc6gJm5Hk1tILjDzCGtFIPzQqFgIkp59q1FMtoNSFGZu0C2Dp6c5 X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(82310400017)(376005)(36860700004)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 11:44:41.1547 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aaa1b9b4-8275-4eaa-ff8a-08dc6dc1ea9e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8538 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Yevgeny Kliteynik Fix wrong reserved size and add helpful comment Fixes: 365cdf5f8ce7 ("net/mlx5/hws: add command layer") Cc: stable@dpdk.org Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h index c671c75bfd..c6846cdb7e 100644 --- a/drivers/common/mlx5/mlx5_prm.h +++ b/drivers/common/mlx5/mlx5_prm.h @@ -2360,8 +2360,8 @@ struct mlx5_ifc_cmd_hca_cap_2_bits { u8 reserved_at_d0[0x3]; u8 log_conn_track_max_alloc[0x5]; u8 reserved_at_d8[0x3]; - u8 log_max_conn_track_offload[0x5]; - u8 cross_vhca_object_to_object_supported[0x20]; /* End of DW7. */ + u8 log_max_conn_track_offload[0x5]; /* End of DW7. */ + u8 cross_vhca_object_to_object_supported[0x20]; u8 allowed_object_for_other_vhca_access_high[0x20]; u8 allowed_object_for_other_vhca_access[0x20]; u8 reserved_at_140[0x20]; @@ -3655,7 +3655,7 @@ struct mlx5_ifc_stc_ste_param_vport_bits { u8 eswitch_owner_vhca_id[0x10]; u8 vport_number[0x10]; u8 eswitch_owner_vhca_id_valid[0x1]; - u8 reserved_at_21[0x59]; + u8 reserved_at_21[0x5f]; }; union mlx5_ifc_stc_param_bits { From patchwork Mon May 6 11:44:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 139882 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D36043FB4; Mon, 6 May 2024 13:45:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 372854067B; Mon, 6 May 2024 13:44:50 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2052.outbound.protection.outlook.com [40.107.94.52]) by mails.dpdk.org (Postfix) with ESMTP id 4D0BB402E8; Mon, 6 May 2024 13:44:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BqBd40ginQp6wxSQDjvVIyHQLU7XIvMQWgVaIdoCaWkkBBoM0Dc+YoCDkDZdXXDHPwEeOb4mDXzErLukWyEpPSMKiL0c+GdqfILq1Nhsy4bzB8UAczOUEUlyZEFn2+L/E11lEzr/rHj+Rj/jc/7fL8fQC3r8qErZWvoK6GutdY4Gxf7ckR00voM0xr8avE2ghhhK23zRl2ALQyTuwjwYF6C6xCK8RdAgbjaopxYqTyHcuZA38EHmPaN8oWE/jp8+GmkoXcFt/o3poSwRrTZipzjnw4cgtRwdu3+cwLZLLm80WoPv7CPzldfmrenLDBQJcwRQX2SVU8VY5Pro1IrzBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OXdsDNIMAAT7AqCRlD4KJ6XrpKroax1C4r+phQLBRvg=; b=k+bHHM85jzOrgeBFf4nHvcSGsejUn/0ED/30JJA/Gn2cAuPY0q6dReWH+HLi66r0F4Shck6k1f9E9MJWGMA6R3mBFjpqpjyReLPw4EOm0vrIdJN6SFtmII8eBqzb8CnmdEiLn8qy/FmKUuR9ZUDjLvJiuOxknayWk9gmFboqxLJPalqg/jUa2VZrJWHE9ify6kxXejnGV7fFNj5+r2ijkGGpdG4VnscXZxhCOCnOxDOKspbM+L/S5JYpin5LxjMA5exPIjPPmzJHDdusqnmr27HyAH782mTRz+bQn7Bm6Zh6YUuDUMNKIYlSQJ9yTAx+TP1U+hksREu88MDg7+DgQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OXdsDNIMAAT7AqCRlD4KJ6XrpKroax1C4r+phQLBRvg=; b=BTc57cHeeugSRkUrZjQh67iEBQk4L9Sjc2/cLBxqJq8EHQVyzMw27CjFlqgaaaD/obQHPbWjVu/+Q2HvO62RKu4ynH8UIMbZzEk+VY8Hkc5yoZsSxAhUeo5QZ3OwcUz8qIHrqarsAr9PQmCxj/jzTJHbiOxYVPeQjtd3YqXpojPNE5rJL7kfI+qLW5HJ6AtIpnS36IxDVn0MvmE46Q8XkXG7P2ZwfK0GUhEFCmM15eQO/Zm5/EOn2BRgjZ4AO8y8dVr4N3cuJ3dxtdi9z2bNDDWospuzyyfzTp1ZV2wCk7AVBlJ6TwG3ls6CQUCUfm+wJyapYlPYQi7tL0TLBy1GFw== Received: from PH8PR05CA0010.namprd05.prod.outlook.com (2603:10b6:510:2cc::15) by SJ1PR12MB6099.namprd12.prod.outlook.com (2603:10b6:a03:45e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Mon, 6 May 2024 11:44:45 +0000 Received: from CY4PEPF0000E9D7.namprd05.prod.outlook.com (2603:10b6:510:2cc:cafe::77) by PH8PR05CA0010.outlook.office365.com (2603:10b6:510:2cc::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend Transport; Mon, 6 May 2024 11:44:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by CY4PEPF0000E9D7.mail.protection.outlook.com (10.167.241.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.18 via Frontend Transport; Mon, 6 May 2024 11:44:45 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:44:37 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:44:36 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 6 May 2024 04:44:33 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Matan Azrad , Mark Bloch , Alex Vesker CC: , Subject: [v2 03/16] net/mlx5/hws: fix wrong comment in mlx5dr send Date: Mon, 6 May 2024 14:44:06 +0300 Message-ID: <20240506114419.966498-3-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240506114419.966498-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> <20240506114419.966498-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D7:EE_|SJ1PR12MB6099:EE_ X-MS-Office365-Filtering-Correlation-Id: 060ba196-d374-4db2-d013-08dc6dc1ed20 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|36860700004|376005|1800799015|82310400017|921011; X-Microsoft-Antispam-Message-Info: wAqzmn7l5XZCj1AGwRAEXa3GPPQveSk7vzt31E1hg5Hwx9IeLIVaBi2QAa0bUrh5ii0vD0aLaJkfQlquijuy1G+Qse69Yojsb6QMowSQemvbatOLy3Sj1CtkfX4tIbhTGxVAx7EEuVURm3pLb/Jm9mIimFweB8OZSFO47s5sNEkcbIawZp1UlIsTDWXZC8PgqZtrbDUQ8r4arm/0bGPZO6wcvPRCteFOmlnO9uDdIEBDvguQlvEKyXi72cD02w6BX9LmOlMTxf2igTqePYUhCCJWb7eWLxrVL/g4EXldl7etfn+X+leDHeQDFsVEgN8xRkuz9vS4gf33LYP02A13oFJQ8KGylmyhteMgeupTaBBmvRGl0Zo5Q80p0nmQGGbxSMwTqSpWafTa9d5G7LBxPKewJ4DTHlSMZo9eE4zjqCZsEgUTWzgtQ7SY8Bix63IZggHoEZKwY/IjS8Xqc1z5rGZqZqsXrC9Fx1GJZTVJylwynqNFJf1Dehb9HNW0ypn1hKXjX9/6S20joqyRWsn/fToRVRIsvWxe1cotlbdC1aOC/IL33eP6uUrRkDK4QlImIbD96M1L6XE2kqFoJLqpKMc+iRoz7k2lTIm6YzX25caR5CHDCdVPcSBtoiX4sZdW4utYentyXwTbSU6EWOyKYaHAzklEOkxvnNuw4McgQVm5+qNhh2t1suunKRLAfiRWJNoN+8Roz7H9ouQwrDt7zC5B0EcRlIsy26IE0oRIgNhND+zQz43fCage0+tpbefCMYiB+z9R5NQP4+sNsMV2/eq58OZ+S1vqiTGeVxudOAAUUmoC03+/W22lna8wkNOYVuFhO2hKCqXGaYfMSpqpf82K7tL4NCFRXieHcfa2vo5vVqSQyvSFXzDiuDnSJ0+nPx9q2UaZLBFWEAjqtOaxROGSEic0zRaluQ7W43wMyG0RuNBLjc0X17FWm0aT3aT08LYyArPxEEf+YFWMl533eWQ9cWffdosbVINQYOCN3eIcmyFKrONTvEowlQ037lCgvcivIiQXe/Vp7bYGHnk6YCG7UVPD1DObKobNeHTvbpfZ11A9ccCRBGK7MwNjM6l7Eyi65koD2hokmgBVZ/TJ1S9PIbIHrEUNsXb/PCwgU2Z6ZXzHroshCwUiU/yURCaCEWyifNoUphD6UMFQmjWgc8RcjU7lQzbYuGmbEkJ8FBAVJ+zd9xCLUelKcWdFYvj5E8tN0BTOrpqrOtxaC4x3oE36qDthirFLlV7hjEzfvknCIWUQpO6dr2c3fdu4HTFVya+4gIuXSHr9k/Yggfepao2R07HWwaCXSgXM1dpkTaoe5vH97MB8V+4Nq3jzqbkLeEo+oE2XusJ+L9+GyWwjEz4J9mg2iV77+9YXjUbThS+i573twLvwzmHC60J/QbZ0 X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230031)(36860700004)(376005)(1800799015)(82310400017)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 11:44:45.3140 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 060ba196-d374-4db2-d013-08dc6dc1ed20 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D7.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6099 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Yevgeny Kliteynik Remove comment that documents parameter that doesn't exist. Fixes: 3eb748869d2d ("net/mlx5/hws: add send layer") Cc: stable@dpdk.org Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_send.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_send.h b/drivers/net/mlx5/hws/mlx5dr_send.h index c4eaea52ab..0c89faa8a7 100644 --- a/drivers/net/mlx5/hws/mlx5dr_send.h +++ b/drivers/net/mlx5/hws/mlx5dr_send.h @@ -203,8 +203,6 @@ struct mlx5dr_send_ste_attr { * value to write in CPU endian format. * @param addr * Address to write to. - * @param lock - * Address of the lock to use for that UAR access. */ static __rte_always_inline void mlx5dr_uar_write64_relaxed(uint64_t val, void *addr) From patchwork Mon May 6 11:44:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 139883 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C0CA43FB4; Mon, 6 May 2024 13:45:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A4CF6402EE; Mon, 6 May 2024 13:44:54 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2065.outbound.protection.outlook.com [40.107.93.65]) by mails.dpdk.org (Postfix) with ESMTP id 0E73B402EE for ; Mon, 6 May 2024 13:44:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nk/0xVekiJQ1ql5lIcROE1NYTwvbbU/etEH3bOAaWSV2/WxZzZ6gqzTwwSr0TYzwyvLj8xPwl7tS2Go7m+KTTTmmH4LuMZjLroJCTHf8XyerNtp44EWxOHYL+WYcgV254Mbvz7D0m+X6hyQ+CSouhZMFH5rNCM8SgGKL2nHyJ1J3xJkesHJqIqspVI3GQo391MZ/ziYThOarRHn1WvR++bYWi2LWxqgdOi4DTulshyXXgA952ATiFPmJcJ2oyY/4It9Dq35dH0GFrji1o/HAMqYjRij5wom2I/3mY/sapCuHAAYln2PKs7Bm8inws3Gh3LaWy6iDQkyuGvQyUvmrKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cuBzhutTkD9BFus82ufCUwEb6ahUTKmQ7XOjKwoEojg=; b=W5qCFOR3Qq5tgMEAHr0/IEsGwaZJ6uUUHwUtf33OdKSPbmkuDG5i5Y1jrEycnRE0YHB4Ab+Kn0FgnNgnICL0Z+7sOKYYLu2yCn97+MTsQZvtmOo5bkJPlyCMyfGS9dNMQfiA24460o9sfeZOnEMwMTLfwjPNZfUU2ARwczVXUfCD0ZSEh0gv7dhKfibX+HYUaQieUV19eKjeQGPe0dUs072A+C/mk9WE1BBuSDQsvrVwJ93ic+vwjsXnSiocbw1Vhd9CbBnYQ+2mlOUd+JQ1wnmWtdMLCdLekxcsJzngGw9ua33gdsbWxTtQrZ40eQEOZYlH7DpUSwH0wOtayPRx/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cuBzhutTkD9BFus82ufCUwEb6ahUTKmQ7XOjKwoEojg=; b=MT1Vm7/1KsRUbPKFaTkEnTUSbRCaSNIb6Ox241/EMD9AmGzEoxXeQbBFudh4ByniNJbzYpL1dPr+ogXlWgrr0g2WY9BTv/L5yZj08UuzbL1ZiU1F1bA+p/QW3kjrpNvxnmgV4arC/5eS5t8w2HVQr6mKcrK0Q0gLmlQiyE8dzxTfXF7YUT9/8OcnTkfKznrT2taYbjQXg9/qSa4h+B7m92MpshdgVEUhhSyDY+Q8ihVx9/IW1avg+i/cyjB4bp/OBwi+7j26BvHFBH9PsQc2jHNtdr7drE25xDRYtc6MymcuNqdLeQxW+sXVF7zZulLiJ2YPda8clIebNeacyZAAlg== Received: from PH8PR05CA0021.namprd05.prod.outlook.com (2603:10b6:510:2cc::9) by PH7PR12MB5856.namprd12.prod.outlook.com (2603:10b6:510:1d7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Mon, 6 May 2024 11:44:49 +0000 Received: from CY4PEPF0000E9D7.namprd05.prod.outlook.com (2603:10b6:510:2cc:cafe::4e) by PH8PR05CA0021.outlook.office365.com (2603:10b6:510:2cc::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend Transport; Mon, 6 May 2024 11:44:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by CY4PEPF0000E9D7.mail.protection.outlook.com (10.167.241.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.18 via Frontend Transport; Mon, 6 May 2024 11:44:49 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:44:40 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:44:40 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 6 May 2024 04:44:37 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Matan Azrad CC: Subject: [v2 04/16] net/mlx5/hws: remove unused capabilities and fields Date: Mon, 6 May 2024 14:44:07 +0300 Message-ID: <20240506114419.966498-4-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240506114419.966498-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> <20240506114419.966498-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D7:EE_|PH7PR12MB5856:EE_ X-MS-Office365-Filtering-Correlation-Id: 027e55ba-9a20-4a24-663e-08dc6dc1ef7e X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|36860700004|376005|1800799015|82310400017|921011; X-Microsoft-Antispam-Message-Info: byB+tcmQJ2nTPK2rWDQxn8F5VgYNZqmfvo388bCgcZDV1XLDuDpPvBdnCLeFTsUe+GqHCC9l0cum+k7FyrUtCQRg4fIYzO2b9iuamzvw/td5hD0HN5sdj2J8pnf+60mmYjKHZl/p9nsfXMhCj4Df02yX6xVHAsgUckhbLe+DbCvt6c0vkZ7Upi6JDQTwuVPuBY0bJIF5w+IZp/aZUtNvri98YUw4v1AmrHpWLrhwRApLt7uKl0OdU1b7n0IAVL+NwKmRsaZywy47/i5TUdDxkI0NyMfc8oQLenhzPuSz553tP70wtnLYo52S7UX9g+dMiZfVz15LTvtF40J6ECx2mFq24f4Ve4BNGPKkLstQC8Ngdv2HSQBJidxfN4atrdMXZOlRde2zi6ZQY1xqj4Ke9DUObwNT+L2UY3042SXc5k5izPE153kSd3d5AgHKdErilcmNgRVEGb997eywgq4DrtEZ4wPLi2CMxseLHtDBBpihhcSnZX1/kwLCTVvyY4vKgK6E+ODbPknzgyneNST2hpg44bC2zM+JUzvwIVxvksVxCU6ozGs+HTcVE81b89ArPi93L3XYRXnB1hM4irngyXPIaY7Y0V9TsiFrtJic7jAOsHnZ9Yd8q2p3DFR1WpB+8DsixjqMhsI0q9+jB8c7j9z6ApELXXibbfcadbAt7mecJIcFVuHHfBytEn0qJPA6QXLMZMn2h/ItXzGi+jquwSnfW3KplCFlwK9JJ9hA/r2mnJN+4k23aViheBhazcfmHNLtJXkCRYMswLkvPQ8g6jWlUlRWX+VZbhnh43nA2IaN7OIfHm036VYqvCseHdklGjXMrDzOgiGYymI4y2TGXkC+DR7x+2+kMxbXjZAgcEKF4fMXpoRrTh0OKKt/U3RSvFL+xwxacQHogjpFecThBewJYBrjNFGCo2Xx3vQ3dfRaTolBBmn0UPZ+6k4raXw2TcE6zqE/PXtaV6plAjSgJci73sNQjNsvtb6mqZcp0rAvInpiWPSLAuyDiImY3Xo6dY14pczFSylD8hAM7cjK0mPiZziI6BElXfLYWhQ2D415exw0I0OWyGclZ7qC1rtY0XPgygQrJvM6dxpY8JH+rN249sqRzMhoLPxST2N7tNroMx5aFLEh6TmEYZ3vGENCWFwUpgjs7ZQ4CVSGjMa/1sd14TOSdaPvWuIlGEnhWFFF5iHG0U307RrCHLmtlNDUi0f/PW9ILZj9mbcMiOp7msrx/Y+0RL8eDSZ++kr7xKBa0JCa8aFAw1DQ7Jq6i6qyUecbUfi2yFSCm4qrtcMfLV9Nvpb4uPfkxPL4Rav2/3Xpe0q96yYJJ53D0ntRuQwLdtxqT6GFY4YKSTX7W3sg0/JVm5+7Jr4HZmpgX4FHHLM2tkc4RYkoHWR5QXTxwmLE X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230031)(36860700004)(376005)(1800799015)(82310400017)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 11:44:49.2828 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 027e55ba-9a20-4a24-663e-08dc6dc1ef7e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D7.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5856 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Yevgeny Kliteynik The following caps were never in use: - wire_regc - metadata_c - metadata_c_mask Also send ring's reg_addr field wasn't in use. Removing these caps and fields from structs and removing the code that queried them. Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_cmd.c | 11 ++--------- drivers/net/mlx5/hws/mlx5dr_cmd.h | 3 --- drivers/net/mlx5/hws/mlx5dr_send.c | 1 - drivers/net/mlx5/hws/mlx5dr_send.h | 1 - 4 files changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.c b/drivers/net/mlx5/hws/mlx5dr_cmd.c index 0e0cc479a6..666d678b42 100644 --- a/drivers/net/mlx5/hws/mlx5dr_cmd.c +++ b/drivers/net/mlx5/hws/mlx5dr_cmd.c @@ -1344,12 +1344,10 @@ int mlx5dr_cmd_query_caps(struct ibv_context *ctx, strlcpy(caps->fw_ver, attr_ex.orig_attr.fw_ver, sizeof(caps->fw_ver)); port_info = flow_hw_get_wire_port(ctx); - if (port_info) { - caps->wire_regc = port_info->regc_value; + if (port_info) caps->wire_regc_mask = port_info->regc_mask; - } else { + else DR_LOG(INFO, "Failed to query wire port regc value"); - } return ret; } @@ -1374,10 +1372,5 @@ int mlx5dr_cmd_query_ib_port(struct ibv_context *ctx, vport_caps->vport_num = port_info.vport_id; vport_caps->esw_owner_vhca_id = port_info.esw_owner_vhca_id; - if (port_info.query_flags & MLX5_PORT_QUERY_REG_C0) { - vport_caps->metadata_c = port_info.vport_meta_tag; - vport_caps->metadata_c_mask = port_info.vport_meta_mask; - } - return 0; } diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.h b/drivers/net/mlx5/hws/mlx5dr_cmd.h index 9d385fc57f..ea5d346d8e 100644 --- a/drivers/net/mlx5/hws/mlx5dr_cmd.h +++ b/drivers/net/mlx5/hws/mlx5dr_cmd.h @@ -194,8 +194,6 @@ struct mlx5dr_cmd_query_ft_caps { struct mlx5dr_cmd_query_vport_caps { uint16_t vport_num; uint16_t esw_owner_vhca_id; - uint32_t metadata_c; - uint32_t metadata_c_mask; }; struct mlx5dr_cmd_generate_wqe_attr { @@ -207,7 +205,6 @@ struct mlx5dr_cmd_generate_wqe_attr { }; struct mlx5dr_cmd_query_caps { - uint32_t wire_regc; uint32_t wire_regc_mask; uint32_t flex_protocols; uint8_t wqe_based_update; diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c index f749401c6f..d58fdb108f 100644 --- a/drivers/net/mlx5/hws/mlx5dr_send.c +++ b/drivers/net/mlx5/hws/mlx5dr_send.c @@ -729,7 +729,6 @@ static int mlx5dr_send_ring_open_sq(struct mlx5dr_context *ctx, buf_sz = queue->num_entries * MAX_WQES_PER_RULE; sq_log_buf_sz = log2above(buf_sz); sq_buf_sz = 1 << (sq_log_buf_sz + log2above(MLX5_SEND_WQE_BB)); - sq->reg_addr = queue->uar->reg_addr; page_size = sysconf(_SC_PAGESIZE); buf_aligned = align(sq_buf_sz, page_size); diff --git a/drivers/net/mlx5/hws/mlx5dr_send.h b/drivers/net/mlx5/hws/mlx5dr_send.h index 0c89faa8a7..48593adbed 100644 --- a/drivers/net/mlx5/hws/mlx5dr_send.h +++ b/drivers/net/mlx5/hws/mlx5dr_send.h @@ -114,7 +114,6 @@ struct mlx5dr_send_ring_sq { char *buf; uint32_t sqn; __be32 *db; - void *reg_addr; uint16_t cur_post; uint16_t buf_mask; struct mlx5dr_send_ring_priv *wr_priv; From patchwork Mon May 6 11:44:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 139884 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB7DC43FB4; Mon, 6 May 2024 13:45:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29BFB4068A; Mon, 6 May 2024 13:44:57 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2067.outbound.protection.outlook.com [40.107.244.67]) by mails.dpdk.org (Postfix) with ESMTP id 38E75402F1 for ; Mon, 6 May 2024 13:44:55 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fqq8nRawxhKnuS87h8zMCQC8ZHPF7ZzaAuCRHh1gJtuskCYnU97J/UJoCUnEQ8K5T4a5x9nVXxUG2Xvk1S0yDgXm41AzlHTnHRGc2p4jV/fnCB0AjqrAdSAnGT4BUmP7h6GMUFx22MJKHNC6+UNzSw7R74S7CjiY0z9njUvUA7qejZe6Iwz0g77hlM/AwrPIYELX/xQxYlumveq/9uvi1uABeQgPaetefF9kYQG8N9wZeCxYpxSbGW3vgGE0buoeElTSOuY8E5qd37pQ8earmlu507kzLYGcjssT1rSz0FWE/crp8RFW81pVfqyQRU3VTYMHRTTYkL3MBaucyD/xRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dg8CYyZLCYkg9LxB3PxgWsBz7NUD10OcQyeraMVBi9E=; b=DX0bwOqC11FRCKlNrt08EvZjJLZk1dl7dgKDFxnVzl/i0AvikFO6iIz+Wuk+ogXBxGiqN9A21TSfYsi5SqwVHCUDP/QyUH0/fdFTJBPPj7poGkaFynRAl1VIHCJQHmw1UE5JhM9e+TVK3txOhNC5E2V97manlpSrKBTR52JLgKJD15ODldkWxet90SrNYK7xEww916nvqdjuZ/d//IokPJLQrLv7c0G6kB/x9ONkHW4CqS5lwh14oT1gRMcJWOr9izz0f218sGExzImyS4K76y5LGra5imclwVWsD7iQliANl2rV52KcLo6+UcAabf9zzWWq+JgdWF8Cxpssduf9Wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dg8CYyZLCYkg9LxB3PxgWsBz7NUD10OcQyeraMVBi9E=; b=OBMCijqHE8LCv7yUY2F0v7ACPAgwX2FMQKQJKc91SdM1Uvgk0ZVYfFC+E6cmYiSa9tSyiVENzbfpYy8A71strxwYJRu8VauTsUVXE228GpKg9o1vfpp1EKIqOSRmhlvNmxGv6C3+7qIf1I6VeLXFGd+/lwtf/Xt2FvIDqNVWOfnHUJE4ZPcGe8/7608q0qgaqKE24Znp1r2tbJUIzJn3cLWuKYUoni3cNLPWY8XbHQgDw9ct/941m45IHSyZN+FLnM3fKa0HbuV/OTVHHrQYvwgfTHaBmr7KVYkPLNoJmkId9bPUxAzfF7ahKRPC30Ea5ux9yHl/m5MwGTXfCEqyHg== Received: from PH8PR05CA0020.namprd05.prod.outlook.com (2603:10b6:510:2cc::27) by SJ1PR12MB6100.namprd12.prod.outlook.com (2603:10b6:a03:45d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Mon, 6 May 2024 11:44:52 +0000 Received: from CY4PEPF0000E9D7.namprd05.prod.outlook.com (2603:10b6:510:2cc:cafe::54) by PH8PR05CA0020.outlook.office365.com (2603:10b6:510:2cc::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend Transport; Mon, 6 May 2024 11:44:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by CY4PEPF0000E9D7.mail.protection.outlook.com (10.167.241.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.18 via Frontend Transport; Mon, 6 May 2024 11:44:51 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:44:44 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:44:43 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 6 May 2024 04:44:41 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Matan Azrad CC: Subject: [v2 05/16] net/mlx5/hws: negating rte errno on rule creation failure Date: Mon, 6 May 2024 14:44:08 +0300 Message-ID: <20240506114419.966498-5-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240506114419.966498-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> <20240506114419.966498-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D7:EE_|SJ1PR12MB6100:EE_ X-MS-Office365-Filtering-Correlation-Id: c0c39298-8211-4166-dedc-08dc6dc1f0fb X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|1800799015|376005|36860700004|82310400017|921011; X-Microsoft-Antispam-Message-Info: TfL0VoxEVzFtuaYrOuWUe9rM02IRL+yTyow1SkuZYjYhA38l2tk6Wfy1PmhsyXikjx0uf+twi7eqUG9lFSXeixTCsL2T84xaznbhVdod+mA3eYDxmeqQiBeXa8h4yohVhoxpDMj5q2FlxxsXtG8RT6zsmkgNWg1d/LB7xvM2/AdMYEtUxpSWm+JtkLCTsfcBmKT9DLwEwK/qn+yjknWakFOwNde2UfHGJdmmTvHY0TMYlagk34feYhT3LAgaARlxEtS3plNx3hoRMticPoWCATlkSC+2VwleptINxnQ+5avUZOW6IaKPpvqEVfak+ux/ulG3/vxQtHFZdLmz9iVOlCVi6/nEA2I4hoou5Fy85D0gih19PQieSVa47vrM3LRNwYfh2La00cQ4+CKEYMdOAlQ5Ov6Kf6SFsZRrwL8ZbROte9VKFuT+rXZ2DG0B2H+4lQflCXSXblRHu6KbOFbVqZ+vK82mP6ABlkP1KbMoVsdaHl90HeGZfiPMZPUSD8oKGS94M6VOlrqyZANYHqT2xZzZd72+IhHd4eytcSkC/ZWsil+aGa3n5HCDlERkEOTJ59XdAe8XJk71/xjHpuEeSGJIXjh+KSTgSea8qAaayA3scYmA47HoilCYHWzgP5urx9oFUAvETMPNKjK+WRiQbvVvHljtpItsjKuQVF2BHso0+pzgxoXNi0n9JCcpbwBDOXND/T0ooowghJVYVbeniAo71OeMtYwFgnqLN78qf/Cr6yHEE6Mu2o36Y2fBXlJ3VD3szqf1OL/m/op2Zn95ZkxeKuojVnGAM5ttHrd23IGxBMRxizIWnbliH7j0PUOJjfGfyJadW2JyoeM83atvlbeFFWFHfUQbfC9VEIWH3MXLqXEtqNsx1/jJY1Rez8CfbJ7S6UXqWQ2J9PoC2yQCZDrebwjTjOSvZY6YuGPkHKtB7lPuLkjIp/ot+AkJjVY3uJPjBombU1uToEX/oGWBgCxTnNsEdP/ehbqzripjCT1ToRbPnAK3n2XTHvotz+wa6yXATt5//j9PWRo2n/Ff76OBTAQb/06mPWlK1m6EUMqcQxiY8ceZ9wnDL1gt/6a0kLGqbcxwRgDp4+0SBQi5/RiXDGrFbwaQuUZ/q1FKmy3or+BbHQdq+ILEsity/1NFrkewnLI2RBwtIGVygWk/9TJfSxY92v9QQ9IfkpfipKFzaKTgCQxBWW1Jx5YwmzIH0WeXRklp7sEfua1LSekaFciBGX2r44+itnh/oTW4PRFsYihneSRA3Ca/VEnfL9Qtn8Den9yakfKTJcSbFJVPQNGdBSaeoTpFlnSU5DQ1slOkfnFD0PnC7bAso9JBQIfJtF2WY0t6C6KsiNNwQRuo4h73kGDqIEzKPIMwws29nm9vr1tY6HE/YQQXq7yGu90E X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(376005)(36860700004)(82310400017)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 11:44:51.7828 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c0c39298-8211-4166-dedc-08dc6dc1f0fb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D7.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Yevgeny Kliteynik mlx5dr_rule_create returns -ret, so internal functions should return rte_errno on failure. Fix return values of the function that creates rule in root table. Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_rule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_rule.c b/drivers/net/mlx5/hws/mlx5dr_rule.c index f14e1e6ecd..7bcf2de55f 100644 --- a/drivers/net/mlx5/hws/mlx5dr_rule.c +++ b/drivers/net/mlx5/hws/mlx5dr_rule.c @@ -733,7 +733,7 @@ static int mlx5dr_rule_create_root(struct mlx5dr_rule *rule, free_attr: simple_free(attr); - return -rte_errno; + return rte_errno; } static int mlx5dr_rule_destroy_root(struct mlx5dr_rule *rule, From patchwork Mon May 6 11:44:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 139885 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E50A843FB4; Mon, 6 May 2024 13:45:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E8CE14067E; Mon, 6 May 2024 13:44:59 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2068.outbound.protection.outlook.com [40.107.96.68]) by mails.dpdk.org (Postfix) with ESMTP id C4C22406B4 for ; Mon, 6 May 2024 13:44:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ad7r6BG0eLWvHTi+L9vykVN3N6IUtt7cNmpv5cfze1B1pw3iZif1qR7gcAvsGrk5QbSZTnKoHIXk84b4pOjQcoUrSVe457dplbWevK24U0WhjIV0/StRhP5BPajRFspHX2EaLqNbe6BxHwJObw9s+OPHLun8FJJjVikJVCmLh9MUdjt1AeX4eZ6cMF/9G9+OY296KYpATtjOGa70VaoKwA+22ukx8WUB7jWVROAWCItspCmWLlErVhmzTuDfthlJuoafXifuRuNDukiBjch77BrmeFdlHYNusGYwZCXnUhDX/U4W3/aR4f+ixOb4Bq6Fsq9P2uTyrJOIaSsCNMtJ+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cx06RviQA/BcyHoUJNh6LyGqfiZBMQWWd4HL5w4QWno=; b=DKsEO3rOZygpSKgUsaLrwP+vFfGd2D1Ct7xTn9f1VsIqJ2/fd5vhqt1j8qsml1HVIc8V5+2A/forNTgqCRMR872RE8Cc2mGj+6ULtkC+DLdBTs1fXxGA7jPAo2RGqX0WxoAnmNO9MbxS5C59jNeG84HE5wwg8buLoTGVnsdLDyciBrq4Qv9by14lUlsdVsuCZWL1S+q6YNkFcQHMp1FigYNII1JVt3ec1+eMJRCAT05YsfplSxjXrCjSfb27GIr9D4ISQmRFWR9HsNMXFN6p2LjSQIE54b/tnxI6OxSnfsq4kU8EKsQpCF10jKCqe1w3SMYX9dkA/hjlAW0NpqqxUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cx06RviQA/BcyHoUJNh6LyGqfiZBMQWWd4HL5w4QWno=; b=NxgpY8UpChWDrF6gjKuinGS6cyzqx3FoyQ5ehGfq34hj8Qn5MOs/EYqro6HH50ETiVdr5WtRQwCCrS98MbHyEBOSgb1dTdVHnAoTqgCLkDQLsc6UjTK1h59m3Z+CLIyJWAIJaozConaZYDhimuDFjdLV8i2SkK2rSYXQfMybhKwl/7dD/0vaTlFEX3WYY0w36wDjkosnsUrv4ibrbgh1Em9QkJ2Qru9GVYkEfJDUbfC4bSnYvlhFV9Ys1w1u8UHNUPKN4/w1MMXy6u7J3X7LXhnXR8RrAkLx5+m2GPogTeGZByiqelXT026a8qBo7o6+oiN2VnnkMxjYIi1TFbrEow== Received: from PH8PR05CA0022.namprd05.prod.outlook.com (2603:10b6:510:2cc::10) by DM4PR12MB7525.namprd12.prod.outlook.com (2603:10b6:8:113::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42; Mon, 6 May 2024 11:44:56 +0000 Received: from CY4PEPF0000E9D7.namprd05.prod.outlook.com (2603:10b6:510:2cc:cafe::e1) by PH8PR05CA0022.outlook.office365.com (2603:10b6:510:2cc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend Transport; Mon, 6 May 2024 11:44:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by CY4PEPF0000E9D7.mail.protection.outlook.com (10.167.241.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.18 via Frontend Transport; Mon, 6 May 2024 11:44:55 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:44:47 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:44:47 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 6 May 2024 04:44:44 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Matan Azrad CC: Subject: [v2 06/16] net/mlx5/hws: simplify send queues close code Date: Mon, 6 May 2024 14:44:09 +0300 Message-ID: <20240506114419.966498-6-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240506114419.966498-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> <20240506114419.966498-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D7:EE_|DM4PR12MB7525:EE_ X-MS-Office365-Filtering-Correlation-Id: 7efc8f2f-4052-489b-ebca-08dc6dc1f34f X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|1800799015|376005|36860700004|82310400017|921011; X-Microsoft-Antispam-Message-Info: PAdJyJV0lxDnLkkMHKe+i2f8OeMkDeYQ5QdI9iU5yn2vDNuwKhWHN3bjHzHY+A7w5J15QnK6DqB/pcPdZLV8sLFgy5HIhWWArjeY21SlYGqMDo/RSPp8020zznGyeoVMSjjKHspiQoymITWL4JpCsZSUtWaX5dM1hc4QUZl8ooZIiIim54rZIG60yiK7MqTYAhufz9nw58q8VMXXz/pGq3a5xznF5tpyeXcX9MZve8vM1pd3qd6BrhaMpq9HgCrdMWpvi9ugtdF0zfQjYvNfJOaEvQZHWnk+BevGdruKLfAGedo4DfhUWKBRD3AuGSSIDr7QIlt7spfmBsvoqB5Mv5GyuYPq87n9PBN2cwlaNyOXWX4B1XaCbYCkT4hsh3MwT7ag2V48DIZU7QDuxdRov+vp4YeqrKE9MLcHVTAGZtqbSvMwrPRtcsUYE0MZQ3zmQZJIyWWHh4iqd3mo2Oe12C5fsmNNwZYFzwq43plHCZN5L+oejDcQLEvhhR5NfeGBnBnSYZvFV3Iv5FL5e0yHdg2XJezLjQUVedbW14TR6XTi93lbjsJZ3sWwAkeXM2Fv6Fc9xzVC3am+j2LSu9m5PKHwKQhmYCEE4GHEpIp5N6wj8VF/8urx4/U4dPnQOOpXaqWQLvK6WpECFEF7GT+Nft/e802Dy9DaGk63juDCA97hRwkd5LSu6PIk/5miLk3ai/nyjZCscaMtM9Tn+sNf4sZmRl70Y8P0osrnnfSsMOMDhg/gFPyHcVo5khrEtwyuNuqjoSGZCKgJRDpUr0vkaxNSaTL8Ja9t4QJgeKensMnmqZbG0Yjfza6j2es0r4/aUQgTMP6ByGNfRJVfmIn5QCdWo4mh4Pk2nYj+lnxzKmySnHlz+2PFZ0Whh+xhewNtXlLVbRUD2QCDf951dqsXncAa6JTS7YpUKsdsZo1aFS+fbCik3+f5bf6afygRiPgNAuj8L+/Au7k9kbIsJOTGXnX4irD5crf+FeiYqkyGYH3Z0zv/AbjH4wK0X99brlZzRm1ycPPUoxBfNbZhIrZ/E+CEJiKFErKuMmrLtddtWxjap4Gy6gFqrn1NzQ7pyTYfzm0jpnE1fBqUHVsSSVwYo0knhLCS5gv292sj7JRGLrWY+OZy0AaPUqTEUxAaEvM2glyDOYTJior8+RNqtLSIj9Bl+BHt9KSWpJkuYXFUOelswWdSwf3+PUDMujtzho2XcoCt5XyunJhsjYyRCcGPlTuNxRgNZEF72Yp8Y5Xn7J814iV+/KmKtMt3Jflvei6xX+qZDIdUn/nhz3lKdzLd0hYO8Wgm9nQk9LCewqCSetQuDijsb8DvK77pMMG93a8pwzt+XTmZk4LY7m0/z0FajOf06q1Doi8FtcADVrGZXPvCwEjQuzOZev/lJpogMYeD X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(376005)(36860700004)(82310400017)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 11:44:55.7047 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7efc8f2f-4052-489b-ebca-08dc6dc1f34f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D7.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7525 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Yevgeny Kliteynik Small simplification to the send_queues_close code Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_send.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c index d58fdb108f..d61862f074 100644 --- a/drivers/net/mlx5/hws/mlx5dr_send.c +++ b/drivers/net/mlx5/hws/mlx5dr_send.c @@ -970,13 +970,8 @@ int mlx5dr_send_queue_open(struct mlx5dr_context *ctx, static void __mlx5dr_send_queues_close(struct mlx5dr_context *ctx, uint16_t queues) { - struct mlx5dr_send_engine *queue; - - while (queues--) { - queue = &ctx->send_queue[queues]; - - mlx5dr_send_queue_close(queue); - } + while (queues--) + mlx5dr_send_queue_close(&ctx->send_queue[queues]); } void mlx5dr_send_queues_close(struct mlx5dr_context *ctx) From patchwork Mon May 6 11:44:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 139886 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A08B43FB4; Mon, 6 May 2024 13:45:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9513D406BC; Mon, 6 May 2024 13:45:08 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2068.outbound.protection.outlook.com [40.107.237.68]) by mails.dpdk.org (Postfix) with ESMTP id B900E402EB; Mon, 6 May 2024 13:45:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qc0ke9u/Ns/KRWRDnoh5GueVz3Yf9g3Zhahe8l/4kN6OFnC8bUQXUc78vMGsUOsv35WRii6OJvbyYKubZZg6MBal5gr5oQpu0fB/vBF5HVBdYP6PppazXaZsCwKlx1LsDu+2KMM+onByD+7N5X8JS6/tkVYLu+Az1CN9Zcm4mnERQooN2Qf2Y4wwsFhphLStLxGLBrQLRiNihYAbY8+e5PFXCjj7aJQVPy7hl2QeqKoWiGyDBddFr3SZk1iiJ9DgrMPd5k7WUs4642yu/viarsUvWB9w75fIyR4fjVFDXFIB3xEPYM6ogM4P1GbcpjZLxPHF3nCN7rU4vaktWbNwLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aFueeaTXYfvfkYcVoCeRDw3V4wgquURkgmTOqPSEkm4=; b=Oq9OLeZqU+uMZ4zLq2YHduzuv6v0jf8V9ewUI541j6HS1STFb+okbmQcX7MKOx4s6qUba/4DAjkq4r+CvTY0zaCOYJVd7s7lKw8Q3VjKJMGZYT/Rev5Hej6a0mtFgxZymUSek3ResfsfhoW1YWVsVu2giT3cyJJlvlmzXA5wZvXEufwCo4/7jpui7Z6JJYybo1WI3n9J1JQxwki5hBr1mBY5+a0ra5KeSY03VlPh3k7d2pFxwhU88KzfJG7w5TQ9ePp+hShsA87o5sS388HjWMF9ydG9OIRn1zz2YXkGvhlhf9A6NKwDgCRMNKdREVsmrYgkhhNZKFWiMjOt0yk0CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aFueeaTXYfvfkYcVoCeRDw3V4wgquURkgmTOqPSEkm4=; b=LctKRBiyIy9tV7T+t68FlrLGuXv1oN3dDblU/cvejp0DX5XW789XKoJAemOgSHpnqYUUq4QAlBfglmRTVvhcjkgsX8SmV9HUognWDFy13imLwj+ZE6+SCmaQ0Sv3oAoj07UYfRGxK7W/RilBc09R6X8DCUDdHsAqRlAab8HCpD0Nho+/+smpMoiaN6nYanf9WYD8TIuhtYGStRsfYmZ7FQg0IOXKWtoV+JJ/siIdC1o5Zge0wV61SFj9J+NdkEbJWOiMCdrIK3TXVNrrRPB4ebllmWdE1XbWz4VGDQNZ7Kk5w5HGTsSx4bgCNb/hy4GLWKv0E+0z+qpOf5NVao1a3g== Received: from BN0PR04CA0114.namprd04.prod.outlook.com (2603:10b6:408:ec::29) by IA1PR12MB7638.namprd12.prod.outlook.com (2603:10b6:208:426::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42; Mon, 6 May 2024 11:45:04 +0000 Received: from BN3PEPF0000B373.namprd21.prod.outlook.com (2603:10b6:408:ec:cafe::ab) by BN0PR04CA0114.outlook.office365.com (2603:10b6:408:ec::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.39 via Frontend Transport; Mon, 6 May 2024 11:45:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by BN3PEPF0000B373.mail.protection.outlook.com (10.167.243.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.0 via Frontend Transport; Mon, 6 May 2024 11:45:04 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:44:51 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:44:50 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 6 May 2024 04:44:47 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Matan Azrad , Alex Vesker CC: , Subject: [v2 07/16] net/mlx5/hws: fix error flow in mlx5dr context open Date: Mon, 6 May 2024 14:44:10 +0300 Message-ID: <20240506114419.966498-7-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240506114419.966498-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> <20240506114419.966498-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B373:EE_|IA1PR12MB7638:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d42eccd-c590-45d0-6f31-08dc6dc1f852 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|36860700004|376005|1800799015|82310400017|921011; X-Microsoft-Antispam-Message-Info: GXipr25YmiGZ/cs1PtJl0RVUoCFJGRFZbnjtLuZfW4E8uRUdb+JY+TX6FTrOW+gvsQKc02zkwZXJ+y5L7tbnj+P94BAOrXrPeSKJZbQNzxwAc1oFaAq/VnBpPXGF0Ykis6Q5mtKTnfTmmg7+f8Ijan2OnYuVKr47+x375vAlxNDLW8hKU9r4yhawhhpbE0Ru1bcdb+0oCO278l+E7QCV2RQw4jxngj4FokfaayNLOzlkLLMbLhXLRsIRf3LiFn9tO3pPROW9y8EdErF5JuPQ/vWYodiwDZZfVtzhzmaMzt+X8GzR9+eeKpMc33Ly02IEsjWqjoc2QK7i1M6x/8olmbjEs/s7lu7uDgh+EEqIwlbsQE56ynImV2KO7N38vS/mriXrIJKIdr74jPBehMINtoLZSQHoMTuaNzNC6W6np/cBHGQZQta7+GOcXffwVH4TOAMbnLNGSiAhZ3w+YQK+2eVl++rLIfzNs7pJDxc0thdv/a8Y2oDAOnCuPSWgXXKo24pGcDad2Bt6AdY2kEDW+yIIccFLrGbuw6DGvBYZOLnXNuTKvoY+buRAfTZgO3cBZ4/kTnYBKRQRQxvk306YZAGReTnjgK42o6HFlRHxoi992VSuQw3UlGPSPpyBiXhqgAp5WsAMsTf6FU6pLqd0LtO6GLHXEmDWZQ0fQoVmJY+qfkkR26T7Y42VoIaV4R1Uo/Z4ZnLOOPHzkLzKnJfiU0315K8gygaIjOX3h/pghzDyl/Uug/1i+akV02Rlhw/aEctDXCaAk2l9LtZpErDpPYQLDztTvq2Kc64t/vahY1Wsy5hJ4tjVHAeNHh+rpO+AFIsgsRpGV5n5GZWSGNBEI5QOm+kfvzxtqIm0gi1L9s+nFjaneajcDo6+teviLpsei2PjJHADWdWNM+J8Ss2m0k0tja30BYLjmY+3SKXlJ1iSjTizRIjvJY1vNrtQhX9MqtfygaBwksiXKEUaAe1gvv3E1wzHhDt13oaikLO4w6RkLKGaRLWaUkxVw1sDMWOhZx6MX7Cjs0jJKOevl8Shvp5xoOjSHW+if9TOk+7O0oo3d54eRqCniGpGwypVVVOtqnWJCXmcRTkpuiUZeJKVAq5/kCnUeCyTNaAflawOCl/ssOHjMAdUyDCyQCpFFpb65E/j5nWGTVjw8AUuDwz4IWUX+OjdKIkVl7kDvROAhaHCHPLIZhAphhBgg84iZaQDsM37GxVb197QCpT053/u4B7zcqv6DTiIGw7bG2d7x3buVFTD4p4xG1A6rsOVDb9xJ7YLDtuSQAE6UZz+8To7LnGMS0lRMVsLyLENrWf6ycqBpCG73BFWp249oIFM97UEAwf84+k9/98f77annppPg1SPQOr0bHtIRa3RReeTGvI= X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230031)(36860700004)(376005)(1800799015)(82310400017)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 11:45:04.0160 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4d42eccd-c590-45d0-6f31-08dc6dc1f852 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B373.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7638 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Yevgeny Kliteynik Add missing spinlock destruction in error flow. Fixes: b0290e56dd08 ("net/mlx5/hws: add context object") Cc: stable@dpdk.org Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/hws/mlx5dr_context.c b/drivers/net/mlx5/hws/mlx5dr_context.c index 15d53c578a..7f120b3b1b 100644 --- a/drivers/net/mlx5/hws/mlx5dr_context.c +++ b/drivers/net/mlx5/hws/mlx5dr_context.c @@ -263,6 +263,7 @@ struct mlx5dr_context *mlx5dr_context_open(struct ibv_context *ibv_ctx, free_caps: simple_free(ctx->caps); free_ctx: + pthread_spin_destroy(&ctx->ctrl_lock); simple_free(ctx); return NULL; } From patchwork Mon May 6 11:44:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 139887 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E49E43FB4; Mon, 6 May 2024 13:45:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1DE5E406B4; Mon, 6 May 2024 13:45:10 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2052.outbound.protection.outlook.com [40.107.102.52]) by mails.dpdk.org (Postfix) with ESMTP id 87CBC40696; Mon, 6 May 2024 13:45:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Th5t1Bx502OQvAYKlIJOSUMiJ3vue4wCcSACJ9PUFjvK6vmjWP7fCvwqy6Mwf/czjaCbLJU9BMWeaQ0ClH/hiSjBdHxt/ajJai7Li3iIP7jLtCsoskMwYnZmnmq2oVr73Be/b+zyRubldFxaI9Ko+ZyY0xJGTVO8ckU9zRBarjmIu0B+IWugR6XpPv6dLIPWxA6LvBztCFoNBC3RSKOa6I8jo+vTTA9q+x+UEEftfi4tN1tSPqiyq6waKHLMbbRv5pn2BsBQylbnz0MSa7v1RRaxIDdWI2pnUpZoCI1Z3vbcJu0MRRYlkdE6eyoy7/vpXc3+k/u2cnrlQ9WvI+FXHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/0GgSMoRZqy3RyFT3G4stfT9+CPBP6amM8Jigxh2nV4=; b=n9c/qOtQL+WTIRNVXWzD77DgsMvTjU3LfeUJr2G/sPSFv9B1yBBeS9vOvGj+fSFTgLVDzOaRg8FzfvWVkRpWGoDTHjXmz/RabQmMpTfBrS3u6uT9WBzTcjfN1y423wd9YssQLxae4oLfaMyzZhvf3X4LqcxeeB0kGbJ8VfOa01pbeXFU50juFAtn/IFR+p9y9Iam7w0oIwFkssFs/sx4tbFom4s/P6J4jH87CL13AW8xU626pB1IgROBE3UyaOpGwkiJIUriWmIHKTXhNe0uhwQGtf81C2ZAhE/cRXY3pn73z4Swhe9SlE5vFFpSERUk7VB3dfSl7oYJmejDXtgZ3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/0GgSMoRZqy3RyFT3G4stfT9+CPBP6amM8Jigxh2nV4=; b=Jzt1vYomzMSNu6LRnHGnvzwT8K51I3GgzjR/Af/a6LqoQEVVyWmhKEdAJHBf1JxGQxmZt0WIFn6iTvPW+EvVX11XgJE27a7qwhyHg9hJUav51VN26sQs+MnmfSDHm8hjWdrauPZq8iiZ+ddBuvZE2qyj6s3BTeh/nIQOkHOJJYImOVGa1oSVMDPRd9uhBvBS8WtosO0ZIk70o4m0Y6wIVPW7b9jchs5abn4hFGM5Q5LXBhbJeTtKc+d2lgBUXnzxX1tfp9CZiWlZMd6oVoQl5Rz02gPY8hO4dyrs9M9X4GI/2VRGaCavqyvzkgjSmpmHGRYz+y7BUuuOY+jG4VnCeA== Received: from DM6PR10CA0020.namprd10.prod.outlook.com (2603:10b6:5:60::33) by CYYPR12MB8892.namprd12.prod.outlook.com (2603:10b6:930:be::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Mon, 6 May 2024 11:45:03 +0000 Received: from CY4PEPF0000E9D8.namprd05.prod.outlook.com (2603:10b6:5:60:cafe::17) by DM6PR10CA0020.outlook.office365.com (2603:10b6:5:60::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend Transport; Mon, 6 May 2024 11:45:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by CY4PEPF0000E9D8.mail.protection.outlook.com (10.167.241.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.18 via Frontend Transport; Mon, 6 May 2024 11:45:02 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:44:54 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:44:54 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 6 May 2024 04:44:51 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Matan Azrad CC: , Subject: [v2 08/16] net/mlx5/hws: fix code analysis error in passing 0 enum val Date: Mon, 6 May 2024 14:44:11 +0300 Message-ID: <20240506114419.966498-8-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240506114419.966498-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> <20240506114419.966498-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D8:EE_|CYYPR12MB8892:EE_ X-MS-Office365-Filtering-Correlation-Id: 324634e8-9dba-4420-64e8-08dc6dc1f789 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|36860700004|376005|1800799015|82310400017|921011; X-Microsoft-Antispam-Message-Info: A2Rs0kV3VXxfFe+6OSnQf6vi5FgltN03gVeMdZpYzYZNua0hFk3QBqcrl3pjFTNBejyyEgw7TdquIZlQkhzNOAXhtDn8HcWCBZ063wK01B4QO6xnobeaZfsIBth79TSQIrNrrbhbavmt8xO7Ml7jeYUvunRuML3XcxUxi+TSKk8eu+XUtCbALBZ+n3p92RMg95agLIWFUln20PG5+VzJWRRVJdaAHL0YA/WXqq0YeV0bBUxLjga9zTOLg/2YERY2DElYkqTlnGSnHe55a5Vmk5ov98dgNQpmzvQtQj1YARh22HxAnRLX5dIq0fdBGEw/1xSCFkWYZxBjUr+ytw06B5FUrFeTVdScXNFRStSgX9ojnPB7QjYvucW5luzPi/NnPoezF+JJvYUYVtLSbza6fWcmvoio7zbKIVT25FY18WdU/8rrHGkL0szsPsZ2td9SaoEGXxQ+AmaWvsrN8IW20Yrwe/4O3IH15//6kkBkcw3uCp1IXJw5i2eHin9kIHQV5/yMDZ/UxfHRFTiKI4XwwRjWtOVld/7FDILLNwEhx6iWzbQ9RcSrddEJuvzxzLMFaumnGOmMQqNg/x0EpiogOK/jshZSebDBGYF2ZALKWOnIQVhokHkKm2HopHGHC4juwL0qdLAkgeDYxygdgYJ9VjSAJbXJi+Q/snrskTLuCzAq9yv3dzpda5qUtNnEvkTCBVBwXY8qBigjud6s0hA+PAaO9pVybTuPW+Y01bo+InzhJjBRhgbFbkTjR4Lw3yJ+9m1UGOLEF7xfOv2wh4gadSIYHu6/rF9qM+dZZDVlF76LJUHC50ssB3TvGnVR5XjVXq53bjqhU2dd/e1UYVL1CtcOpfwSqq1uupavGxT3iMudDdL1Mi6bLZFyf2nN1cQHZZ1JjN4i0iEjobLScDDVhkttm2PbMK5fnuJVl9cECKYIIqGdYweogz3n6+Rx5tvNYBSglajg6ShS0Me0YEvoMFRQ0BWnS5HyAq60nXjy2J15MlADPbbzyHc1p+J4J2tWes7xFrUobIsYS3OXNwSxmfOPjmpbwNOk2pTnyQhJ715dfE2tDFd1S+3al1rcQqdh5ZnrlDOz8BPwWnu2pVjtKlHBLvR6gtYmct+7hOWTS5ozg62vD8arjguMJY+z/5FkieffKuXEh57aKzLeBi7t5ah8oVjiKPOhJngICYzbTljXKWajz7rLD5oHJB+jIVxhb0fhAGMFkqAYUigTZRbj4NPuLSjQ/OLdeifr+2ct2korDSX4y7IqvywEt5Mc5kQtB7zQSswVJ9vJn45XIsK0MsfjLGkK8E6hbS1FFWYG0Le2Ivvr0DEVjF3MNUcHDzavfDBG0p5HpgE97rCgn69c+1ZpV1WaEvDxu2b4FpSApxuClqIA9GIXw6FUr4/FBX+n X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230031)(36860700004)(376005)(1800799015)(82310400017)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 11:45:02.8391 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 324634e8-9dba-4420-64e8-08dc6dc1f789 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8892 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Yevgeny Kliteynik Instead of passing 0 as an enum parameter, define flag NONE. This resolves the following code analysis error: "enumerated type mixed with another type". This value is currently used in tests only, and will later be used in backward-compatible steering API. Fixes: 5cadd74fbc08 ("net/mlx5: add HW steering low-level abstract stub") Cc: stable@dpdk.org Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/hws/mlx5dr.h b/drivers/net/mlx5/hws/mlx5dr.h index 80e118a980..d2c426e679 100644 --- a/drivers/net/mlx5/hws/mlx5dr.h +++ b/drivers/net/mlx5/hws/mlx5dr.h @@ -82,6 +82,7 @@ enum mlx5dr_action_aso_ct_flags { }; enum mlx5dr_match_template_flags { + MLX5DR_MATCH_TEMPLATE_FLAG_NONE = 0, /* Allow relaxed matching by skipping derived dependent match fields. */ MLX5DR_MATCH_TEMPLATE_FLAG_RELAXED_MATCH = 1, }; From patchwork Mon May 6 11:44:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 139888 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC87643FB4; Mon, 6 May 2024 13:45:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E84C4064A; Mon, 6 May 2024 13:45:14 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2068.outbound.protection.outlook.com [40.107.243.68]) by mails.dpdk.org (Postfix) with ESMTP id 0B85D4064A for ; Mon, 6 May 2024 13:45:12 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L+Yv/v5ao+rmeh+8PcsXX/PWiSeBGeoWei4cjF70o8uGyaO49VPnnAFwwKR6JSdmJggIzQ6w5Zf6YTrxzMGCXMZ3JaVZuyJ2v/NrGd6B19Uf7Vpe3y91Nl82i85LNR4R9sF9w0h/Q2SDMaxPZqE7t+m3NoNRdPErtd7Z5+Lhz7d4nn92Ee4jP/Hurxpz+p+UEFqylT0+Jx6YssZLYKl95ekmjB9fHAhHrUPf378JS1vSL0fijTQQIh6JNeyymwjoyWAawfPRqS+vhNQzrK/NrQ9qOux7NQZrkZUUkffcmE/+VRDW9PJfTq6tSISISMyMPBmAYWyaeRzqI+G+tb5kBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1RxP9ZFL5dYilofDsNEiziT7c8u0vExtHQFnD8chL80=; b=Mn99N7mlZ674oHb0dfdTGBqGrkCXvZ88IZ4szPnY79Su5d0Ze3iDB8EbzMuBxa86w8r3BKJhUpYNfQnAP9Bnzd10Y9kxBUSKDrmpYWQzoGeAOMVcbFBQ2E/wDoYZINnr/Su1bjCQnmlXVKUm6mZg5l8vzJRZbPvzSp3GyQsCft9Z44ZrsdIcnc+4ZAz6E3/ZSlvhSajoDkyIhMt3c/g38yOkbC5RV8jWFMOqzSBeSmVJjGazOaCl2FIkE1ZwPpROTzdsGG/uhvAf4NZAfnlVdDyNei7FilfTtbBoC5THJYBLD+ZMvo74s+yN7oSmSs8SvjYIG4u88azfpBr0acFTbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1RxP9ZFL5dYilofDsNEiziT7c8u0vExtHQFnD8chL80=; b=cC78FM6gRJMByNkH9klG7jtbj3FK/HS8cBjsTT+EBW2epkqWi4yFYDBM2dlmfV+MqyAGg/+5zgumNTDG4FDCRpaeOLpaIyIvmMAe8Pr/dGr0jiQoFZ6SJYOmuBC1UtYLB8/3dUMEWQlZxN2QEFWojNBXaUtKHtcljwfY85piuk4ZJVbJ3Bli5lbJk8UoaphJxWRoYJM28JZEmQv3wg1aT52RDKnrcOSEDiRYUWVj3tQaOAzPP5Lc7UX4lQMoGXwomVIxbrMCUi7JM0JAP9kGj5Dis86DHQk9TOh9wXJm2xvx3lCCVzk58T2exgK9O+KX4hhjQ1AxKYUw+iisU2zNgw== Received: from BN1PR10CA0026.namprd10.prod.outlook.com (2603:10b6:408:e0::31) by PH8PR12MB6769.namprd12.prod.outlook.com (2603:10b6:510:1c4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Mon, 6 May 2024 11:45:09 +0000 Received: from BN3PEPF0000B36F.namprd21.prod.outlook.com (2603:10b6:408:e0:cafe::6) by BN1PR10CA0026.outlook.office365.com (2603:10b6:408:e0::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend Transport; Mon, 6 May 2024 11:45:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by BN3PEPF0000B36F.mail.protection.outlook.com (10.167.243.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.0 via Frontend Transport; Mon, 6 May 2024 11:45:08 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:44:58 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:44:57 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 6 May 2024 04:44:55 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Matan Azrad CC: Subject: [v2 09/16] net/mlx5/hws: simplify code for updating CQ doorbell record Date: Mon, 6 May 2024 14:44:12 +0300 Message-ID: <20240506114419.966498-9-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240506114419.966498-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> <20240506114419.966498-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B36F:EE_|PH8PR12MB6769:EE_ X-MS-Office365-Filtering-Correlation-Id: f41fa185-1b44-4a43-e38f-08dc6dc1fafe X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|82310400017|376005|1800799015|36860700004|921011; X-Microsoft-Antispam-Message-Info: tt5EPO8sBGZEKujpZPRDzA4a2FN/sZCzxoBkYzKyTpfSva9iT4CWIEHfk4aXdPlr8wADqR4hHoM1zQRPWgvgiynIEKerRPlsboo20aou/WbmBQNUa9yH2Te8BYqiOc6p3rxvviUh7HefmCbd7CRtsXxC2Nq8duRoYwdqRnkSadtILL5weWPmRDQ2tA+lpVtNMSKCyJvhqDwgyE6bquoBIKHcwEFb0y8447dTDmFl+CCnkBzDeSMPIfg4rMOfjrFWsqcyzRDKcMhvoHLGrzUn8VlJ8XxmOY3JjY55mENehC+5Hkz9tK/tMzxbFSr3aSCWKw0L2eWywkGRCKipgtLSTpYt8Njk+OaFPSdOiTfSgapKKibUX+C7spZ/4HFejDRoW4Ty5k45smOBcQKy8n5K7I3nqaqx9abjCoo3Fe1OY83UnPgCGIxFZmVRBzxN7eZsnu5TBufl46q9JlEB2YR5QfY/Fv5V3Xob5GCWhjrLm4XZQI9rgSH/FhWvhPU4Ej7vCu4PjSWBDgSIkE1LUovCjYPnciuQnhytjgLxfcwDfOgQCPVIUPX9IGCWaIMFR950Gb+X3vEwZnhxCAIXraqn8sYnUp02LNCIu6Xv64m/Om582EZB4/QA1lk11NREEBlHFE5l/L/DJVt7wQfxwVKzZRn81R2FikMTw/TjEQwhs94T/5sJdfuGsispNEz0Ks4wMPUETz8Tuv9sQ3B5db8utXHI/dAzGBs873nD00fad6xkuu39mmoyE+fF6oq+9VdPf11HjmFtHnmkT43fPOSRJYemodO9/JM7LkiKoRhjRZPM3GyNqhNU8Y248TFILEcJtKlHZaOCoCEt9ItxNrmoHE6HdiCUL8nOyxjVeLZl1rkADcEvxSgtLZYxDoyyke5Fnyu/aPwY/Q87r2YBYrKbXK07AxJqJejZ651Nxt5+8OZNyR+bimhvVTY+7/ErG3axdd+H6dEuEFsxFfm5prALcIEo6Oae9rTa47n5xNn+zOKcX9Dsx4WBvlSQalguoPh42onkjMKtX/4/duJqbkIjPhXy7zGbC5LiJoDr/S/v0GqjtehfzSVwRO48lxx5B/86uhY+/LaZFJ+HJhT4Ntg2f8wLZcsZfcz8Nol+LahukqtMSd36kd2NqUIvU8fy7niK9KHCirZR+X/ewNShUqD/aTqTW5ImlzR7mWyb5yT+8dVWev3pkXu/gvmHy7wpNYN61TPQewcrw9ukSFJUG/GKj6eYMsR8ifMmh8vR/nZdkt8O8DN+sYo8jGC2Aj11RH45mfn3fS1qr1WB9BRZ4aSg0emGHe+DYiSmqPJtflQtz+rAqiy0+xwgYhthbZ0bXmZ8vRmUMh5YrR/tlzlDP7P/LgP8j77y0DCQ1YMqFerb8OvnooqgUSyibf53NcQSthbs X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230031)(82310400017)(376005)(1800799015)(36860700004)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 11:45:08.5016 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f41fa185-1b44-4a43-e38f-08dc6dc1fafe X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B36F.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6769 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Yevgeny Kliteynik Simplify the code that does CQ poll - have DB record update as part of CQ polling. Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_send.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c index d61862f074..2942668e76 100644 --- a/drivers/net/mlx5/hws/mlx5dr_send.c +++ b/drivers/net/mlx5/hws/mlx5dr_send.c @@ -594,7 +594,7 @@ static void mlx5dr_send_engine_poll_cq(struct mlx5dr_send_engine *queue, cqe_owner != sw_own) return; - if (unlikely(mlx5dv_get_cqe_opcode(cqe) != MLX5_CQE_REQ)) + if (unlikely(cqe_opcode != MLX5_CQE_REQ)) queue->err = true; rte_io_rmb(); @@ -611,6 +611,7 @@ static void mlx5dr_send_engine_poll_cq(struct mlx5dr_send_engine *queue, cq->poll_wqe = (wqe_cnt + priv->num_wqebbs) & sq->buf_mask; mlx5dr_send_engine_update(queue, cqe, priv, res, i, res_nb, wqe_cnt); cq->cons_index++; + *cq->db = htobe32(cq->cons_index & 0xffffff); } static void mlx5dr_send_engine_poll_cqs(struct mlx5dr_send_engine *queue, @@ -620,13 +621,9 @@ static void mlx5dr_send_engine_poll_cqs(struct mlx5dr_send_engine *queue, { int j; - for (j = 0; j < MLX5DR_NUM_SEND_RINGS; j++) { + for (j = 0; j < MLX5DR_NUM_SEND_RINGS; j++) mlx5dr_send_engine_poll_cq(queue, &queue->send_ring[j], res, polled, res_nb); - - *queue->send_ring[j].send_cq.db = - htobe32(queue->send_ring[j].send_cq.cons_index & 0xffffff); - } } static void mlx5dr_send_engine_poll_list(struct mlx5dr_send_engine *queue, From patchwork Mon May 6 11:44:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 139890 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1C0643FB4; Mon, 6 May 2024 13:46:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8239D40A75; Mon, 6 May 2024 13:45:21 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2078.outbound.protection.outlook.com [40.107.102.78]) by mails.dpdk.org (Postfix) with ESMTP id D796540A80 for ; Mon, 6 May 2024 13:45:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RKjBxcQVId4LQYz+vlJ/b1ttVCc8VO4Bspb983AWB6GmnF7+YJMNsZDQSysvwZoMD9agQ9qIMItYOUWtB+sCUlrvjejeH0/qb6/dnSZOH8aHqlnO/rQwxK3HtAQXMfVkuLc9ElbPYhqOIgBCvXXfpt5OBM2kVsyyhgRsrD543cu5E6QokKlDCCI3efF41FOTrGgqvX8AuiLQipcQmC3ypC6C3PRG/HJvdld1t2ZOrYT3ft9DvEaba+ylZAbL6nev9bStqyMmdZidveMnvEzCkMVZcugNZCi08c6s/uEghgG1zbphntvdFoajat/PvFSTneemBTVi97jgJngyHMvO4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l6ZBDlAFUIFFS+L/GCPkVhf35fx2Na82QiBLT+YCVu4=; b=FXfKUjJ0khq64U0Sx6YSiexSbQGDnT+hwMJpQQZmViD/lCyPqOV0jeCBy20UP+1Ui+qR1a/WcW2miulclNnF5OunO6Z/wFLXb8IgwkIBqi5gCFHyWXBDi5INp5jkXQ9NA3MM120XIotUyLxpHrR7f81uq3JQ4kLEiu4/rNTV4MNESpU6/JKGr2hSNBWwbLaHIXyVvPtPsyGOaXkkmmUviC2VRNEUKJgIG1poH3eF1KL3RXoNwTks08QchJzp6QCvFA49qWMZTbfWDGcp/u0FrlGm1A3uS5Wd/GalDuugmKkhHV0TQftnaqSNawTXKmVKS7u0hlQzQElrHdFgyFh92Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l6ZBDlAFUIFFS+L/GCPkVhf35fx2Na82QiBLT+YCVu4=; b=BAofAzsyn5NuHLTKaixl3BSAg6NBXPVp3VnvAzfe7/2bRaAUhZG84jjwldGEyPsTp7wfMmLq+3Di7XHbciUOIZg1m8wYXCNsUfp2tq/2q6+eMLWZDU59WdFhltrDLhEhDBGtpU4PaThvrV62bOWGERnpVIAKLeB8H6Bj5CpiFgeLylkK06OagwAXyR68Od5oe5i8S65krinaHnUVDQgmwPHRGVY9EhYUfaKkxzevFYWYCFxlU13UPrT7FsIqQ3KgEnwDDjnVTVJ/5mRSU3cLw9TtLWreDlduBc7Ncx09FM955AokXa9qwfeDHunVNMBXRvSR6kWXFt4SY6q9PjDDLA== Received: from BL0PR01CA0030.prod.exchangelabs.com (2603:10b6:208:71::43) by SA1PR12MB7342.namprd12.prod.outlook.com (2603:10b6:806:2b3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42; Mon, 6 May 2024 11:45:16 +0000 Received: from BN3PEPF0000B370.namprd21.prod.outlook.com (2603:10b6:208:71:cafe::e7) by BL0PR01CA0030.outlook.office365.com (2603:10b6:208:71::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend Transport; Mon, 6 May 2024 11:45:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by BN3PEPF0000B370.mail.protection.outlook.com (10.167.243.167) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.0 via Frontend Transport; Mon, 6 May 2024 11:45:10 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:45:01 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:45:01 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 6 May 2024 04:44:58 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Matan Azrad CC: , Alex Vesker Subject: [v2 10/16] net/mlx5/hws: drop at attach number of actions Date: Mon, 6 May 2024 14:44:13 +0300 Message-ID: <20240506114419.966498-10-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240506114419.966498-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> <20240506114419.966498-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B370:EE_|SA1PR12MB7342:EE_ X-MS-Office365-Filtering-Correlation-Id: 8bdf443a-c813-4bc7-84db-08dc6dc1fc4d X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|1800799015|376005|36860700004|82310400017|921011; X-Microsoft-Antispam-Message-Info: CVaY3wgkg4exK+nyFfbX4Exlz4WV2O4gc/ki4i3N4qmXk0Zm3GMVrqkZ63wa3TWf+ZWs+GSrCYiCRPyYS3cG0WasJu6ZoxIjj2fO6p1XD78hR3nfZAU4kq4tdOga1lM2jw+hE9yr1a4sZpn+p/NmXiGIT3ifJaDyoBKZuvo6bNkdGzTZ8acG4OkeucOr3jlx7i25NrwMYuhlY+Zj4GCy25NbXlN5Z4Wrd6dy5heLBTb/56fX5pgLryCGn7KCxvg85HT5FxsPOUdHPjA1aSwTPZo5ZK2h5y2ILBTX5yIGUB/RhxXfx08pxRT4TX79rSB2KAnc6ZWgyvMq9HR0xP0QCgLCY0j/0cRxhKzUADpTEyA1LoE6E6j4F+x/W9Edvw2ykX3YGk3FwyTYaWAG7RD6yZhOr/kbXYddBXogzjA2Z+9T7gTHm6Wjrcsj4y3vpqRQPrFBmvQfSIw9O9H4+QN/ttCxbuYS0IIBsqZLo2GzGhKwb+hbMMqoEYKJ5wnNBCg28L1Yi6t1yd88l5AxcvwBYae4nj3SqoqEc/JMw36CqFuLpD0kMsxhuExuVrFAIbpOvLHmZKzLdf1KxnZUkQsLEmbEPY4J8tS88xPpheb84GGwe0Mdp/wN53v5i2vZiep9iRGHKt8ssMuRIlPWaNhZoluV8aSa6CAqEAXURftJDc4PXYd/2wSSMiLPfldw5HSDEG50Ip8+tCcH+Q+kPOp+AbP1jk84/D23DPtTh8gr5ZA9jwaolYb7Oxd5f83NxPlT04kh/ISDdIESNEztv2JuNKcTC8cr6K8LyEmvHuboIHII2tvG0J4iyprnlGuBGf0F/9bYQU8A1DLdVOytic5MQ0gqtc1UEEYuWCxUc3P1BBg47O1eDU2O7NW8gLnAqJWYolWA7XjEJ9DDwKKS8lX7H6lOZ2/6WSRGNFXgCvmA9ZjiW6U2UafBBxGVc3YCh935LnelqRCljprXw/q2wlAZk1jnZl6RU0aBNStMfTQLfAF2pjb6QLTrdaUI3D+fkyCLC3dgec4YL0rrZNWGapY2D3S84sC4/prZ05d0hpcIe9mko1nIyOFRaT2+PQAWGR5QCkq6369ZiSfUbh1m3lsH2g8jNjNT/BjsD8RbbaAtxaeRqHVM0kxYyVeog3HwBhmkBzhEukPqcpoIrV+8dkDL576+GMc9ZswcQPOLm6bMnXMvMt8X2DgXTQFbNGTfcarwwG5R7Wx2H+oJ4gC8MatDzpb9yt7eRDRExTfP6yc6eneuFHE86oyud8B2Geg381sc5vSLQSxKRTXI/p0Q98CO8uwCXm+ATtkaW1o1PrIp5qY2NAMyrtfAnzgDCkyqHY1Th9mHZbnmLGSF5BWTFN3Tku29Y9i8Frh2ln26Jk2CPtYqPQAW4L9dg1oAGJpgiEtL X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(376005)(36860700004)(82310400017)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 11:45:10.6947 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8bdf443a-c813-4bc7-84db-08dc6dc1fc4d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B370.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7342 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Alex Vesker Requesting the user for number of action resources is not defined well enough, instead the user should provide an initial action template which should contain the future attached action templates. Signed-off-by: Alex Vesker Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_matcher.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/mlx5/hws/mlx5dr_matcher.c b/drivers/net/mlx5/hws/mlx5dr_matcher.c index 1213e7f0ad..78d525e578 100644 --- a/drivers/net/mlx5/hws/mlx5dr_matcher.c +++ b/drivers/net/mlx5/hws/mlx5dr_matcher.c @@ -785,6 +785,13 @@ static int mlx5dr_matcher_bind_at(struct mlx5dr_matcher *matcher) if (matcher->flags & MLX5DR_MATCHER_FLAGS_COLLISION) return 0; + if (matcher->attr.max_num_of_at_attach && + mlx5dr_matcher_req_fw_wqe(matcher)) { + DR_LOG(ERR, "FW extended matcher doesn't support additional at"); + rte_errno = ENOTSUP; + return rte_errno; + } + for (i = 0; i < matcher->num_of_at; i++) { struct mlx5dr_action_template *at = &matcher->at[i]; From patchwork Mon May 6 11:44:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 139891 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8108643FB4; Mon, 6 May 2024 13:46:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 219E140A84; Mon, 6 May 2024 13:45:23 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2079.outbound.protection.outlook.com [40.107.92.79]) by mails.dpdk.org (Postfix) with ESMTP id A948340A7D; Mon, 6 May 2024 13:45:21 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g0f/6s/2W83x6h8Y2Awg80MNuLybWoXUkgMYryaqewVTyh675nn/ZwpAZY41/r0gWLDdCEmoD9bDA11j0vLuMoyfTkXf3JciaPmmUIk2cehyaSR+o3p+MEWFtZVI6KIO429Z9oOtFsw9FT+XlMAqTrR76tQATit2a+7YoFARbmfIRWcXeGXWquE7blImOOeabJrH30zpu09DONRvIh7b0egXspfl6AxcIiCXM3R3w+fUTScwu37Hwj/NoHMGLZwgsnj220OEI+/jlTX3/B1rbeRvx1AmY0Xf6KMlFN6V1bb2iLJ360UrBb3D5gnxOAE80LeNANy0Vz3BBTNs6+F7og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jp0DahkA8HMr8I35a/0HCQnf6c830Go0v7IoGr5ZD7A=; b=P/3/UWtBgDSYFBhyrHnzTfA45UW7ZC7+QtOLEXFc4Z8KXzcgDd3kHoqudRM0S0NJzfLsTzqCJ+M7+pRaawLobwbgNf9O1TZGBnCU2yk0kTr38aO//4+Hyf4Ru+7Z3Aom1yzKzuiMfYHBLPyFM2wy25PF3zYZGRealh1pfiMuQrZFYS7dBlQETH2lvse8SP6iJifB75cxOiPhN1vLDd5S3k+s8PloCaqZ8ntawY/WXuPmV94IcEupwMsIfk0sVhmzcm61sTJmreTQtrm11OFHdb74pd6xgGHxI1o03BdaQX0opUBE62U2oh/XR7HQMHrQ3vI4333HnSkwKXY+mLZNNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jp0DahkA8HMr8I35a/0HCQnf6c830Go0v7IoGr5ZD7A=; b=rVfHpr8+OwwwvcxgkZB5Hx1j2YMgJFvvJsJy8eVW7aaNZ0mJJuATOexAHGMaLEI44NyfwgLmAJZwNz8BnJQCTMaB/+KNLzDif8ls7TittXtZE3EzzlKklPGdW1TpZJkqE6PrZcRVi46/1UoCnP6KNrahbwBC1UhM4VJ6Ju71GMsMPTkSyZ4L5QngzSoDgE2Aa6Ww+EaUMGdIUoygcQoDxd70mpBKDErgeqp5bFLubPPQNVzvOdKzFUlCWl+OMYySMMbeq/snCbOeFx+yVecrIzIbjkuuymAxNRpgjBZM5w8LhA4C8Kirbkkln/IRA11A37riziqfA7T22JdeRrhQyA== Received: from BN1PR10CA0010.namprd10.prod.outlook.com (2603:10b6:408:e0::15) by SN7PR12MB7348.namprd12.prod.outlook.com (2603:10b6:806:29b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Mon, 6 May 2024 11:45:18 +0000 Received: from BN3PEPF0000B36F.namprd21.prod.outlook.com (2603:10b6:408:e0:cafe::9c) by BN1PR10CA0010.outlook.office365.com (2603:10b6:408:e0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend Transport; Mon, 6 May 2024 11:45:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by BN3PEPF0000B36F.mail.protection.outlook.com (10.167.243.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.0 via Frontend Transport; Mon, 6 May 2024 11:45:18 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:45:05 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:45:04 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 6 May 2024 04:45:01 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Matan Azrad , Alex Vesker CC: , Subject: [v2 11/16] net/mlx5/hws: extending tag saving for match and jumbo Date: Mon, 6 May 2024 14:44:14 +0300 Message-ID: <20240506114419.966498-11-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240506114419.966498-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> <20240506114419.966498-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B36F:EE_|SN7PR12MB7348:EE_ X-MS-Office365-Filtering-Correlation-Id: 672856e7-7289-4bc5-01a8-08dc6dc200b2 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|1800799015|82310400017|376005|36860700004|921011; X-Microsoft-Antispam-Message-Info: OOAg5+UVciFr+4rtxrf9PMOs30zsJiTPx2xLnVfHOGxQj3jiP1IxpbwJXLGz/SeMOhUf4m+tJcwlRhxZv02CHuV/YalloUy02jkZZxu+1caVuZRSrM/mFhXx3Bdrpnneefy99zctt5ci0OeI+Y28Y8vuzE+kaa4zosq33miZdVn7dL6HSochZ3ovcz3q4mmlgpjhR/ECfIoqCaR37X1pb6EjKjySfwJIyBa3QQQMrTZn5alnNeGN5TcMqBx5HvOcbv/8jjPf3KR83zM0kgkORFY5sQhnh6xFc0DLC6ef47I5kTh2mnAxe2gYDf24s9X7GsKZ0sH4/bkSnTF3a4+x4Lcwb+H3YsrGgsQs5PyPUSDNfv8/F4POQgSsqMGTU+ChzqaPMu7TFK/NV/pKzBpIrDLlg9IVjyK5QsJI5seSzD2roSnrPcw6QdYhFatZWlGIRFAWa1zHhfoCKOQ1+i9xA9WJXIzjbcLBxhouXukklDeZEbfKubiXLKiF/vw+oKsnAR8HcAkt7/DdAO/z5TDLBlZ6V0coeAQZcGqZnI62EBZ4Z/zNRtY4CuPqNFnqnCKusEoZYLcbJw1X1qeRKHpUVVIdM6uZPJ8RifrhGllBiqUwG3hpaWQ4hu+hxMu4YHp3oZrnowMFYADxhFGsUjiFPS74IS27QyhiT2WTX0CtQ36oXwCh3Z4wsSkDbyhXY2Fg22BEjIdH3P4zJ+EUsxBUuOsnxGe8G/hT0czxHaQITuE2KgLy2ETWg+oUTJb5zP5Ve57omIHcyD7M8dnkcs3CKF55sWAu9aX8EbzZGxIvYYGQlKMPCN1tEClJ/7MnugX/9URCDFCi4a1xhCjt9yEXV18kuJwg0YpFZ/fcSVaYn/UUlMkjSen0vLF7+S66GmSnvLBXFgMwYrw0MMdh1coPeAJppEwKuO+0/64tCSKzZuewWfg0xfh33GbJWx0VLW+HPpGzjO058Qz+HYKUQCb0yY/zQonTK/7j4Db1bPEFe49mqVPFwbteww6zbiGkSMa+VJNSzWXosM0ZO9ziOcoAgfoOw/tRfsevO5Il8XgNaXJBiMbtnkGDJETRXWLfhik5VSahDNGPwYFZ8wLZlfyVYO4hHwR3CZ76fDFGE5AWPAuaYOoVcamWEqqkKrBIgAFrW0iEyCaaAqgwviF/vB4A5ppjSMUTWNeyr/j/EiQAixjIXBq6K+TOe/z4AMJjVnRjHV1VLF/adp9G3PCKZ5zY4te5vC6lapzXOsimarg6oqe6AVIlw3A9dIcy8BTvB75IfUbcbvV/6OPv1jvjTEW08m6kZ4CTOLyjdmZP9Y8PucJvh4Wc9FBWZ+W2e9jDqyUBC8z9RT+eSkIwo2HdfJwObmwuqBWs+uJoEHjmv41zzpxPsE6onSyQ3UDYkDhXsSwE X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(82310400017)(376005)(36860700004)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 11:45:18.0641 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 672856e7-7289-4bc5-01a8-08dc6dc200b2 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B36F.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7348 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Erez Shitrit Save the exact tag when matching over jumbo masking. Fixes: 348cdeec6472 ("net/mlx5/hws: add FW WQE rule creation logic") Cc: stable@dpdk.org Signed-off-by: Erez Shitrit Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_rule.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_rule.c b/drivers/net/mlx5/hws/mlx5dr_rule.c index 7bcf2de55f..5b74e6d85f 100644 --- a/drivers/net/mlx5/hws/mlx5dr_rule.c +++ b/drivers/net/mlx5/hws/mlx5dr_rule.c @@ -195,8 +195,13 @@ mlx5dr_rule_save_delete_info(struct mlx5dr_rule *rule, rule->tag_ptr = simple_calloc(2, sizeof(*rule->tag_ptr)); assert(rule->tag_ptr); - src_tag = (uint8_t *)ste_attr->wqe_data->tag; - memcpy(rule->tag_ptr[0].match, src_tag, MLX5DR_MATCH_TAG_SZ); + if (is_jumbo) + memcpy(rule->tag_ptr[0].jumbo, ste_attr->wqe_data->action, + MLX5DR_JUMBO_TAG_SZ); + else + memcpy(rule->tag_ptr[0].match, ste_attr->wqe_data->tag, + MLX5DR_MATCH_TAG_SZ); + rule->tag_ptr[1].reserved[0] = ste_attr->send_attr.match_definer_id; /* Save range definer id and tag for delete */ From patchwork Mon May 6 11:44:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 139889 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 075FA43FB4; Mon, 6 May 2024 13:45:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D435640A7F; Mon, 6 May 2024 13:45:18 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2064.outbound.protection.outlook.com [40.107.244.64]) by mails.dpdk.org (Postfix) with ESMTP id BDC98402EC; Mon, 6 May 2024 13:45:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TzQdjAoNIDL4Mops+ZEiAg9NWFUQ0cd7G27zngPWdzni3JGDP7v/kCDCYFPGmabCB4Ev+57nnEdYECsUCnCGfvYR/JlEuvJwEwOb/8uNhHK5T2ByQ8jaI5fMmOp6ti4VViPbnbImOv6EMHaqDjBW+AKfWSLt0bW3WgChhRdrCaOxoI5n62ewJmRW+xgPSRRiBAczZ0R4ibxLstI0sFiFZ8RQkJpKYMzUjomeboxWbxnCRGa+7DTkGxX4GrdrtffMaIRFeaX0dnBIT+WcNoctq7tKkhNRbM6f4vHTYJIvWcjwWwhgyyjpBVJoeGuKs88ylNxDL49j4CzZNr2CgM93xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7fk/La/HxcMhijKuj7KEujyXYRGFGfcZLbcYAYcUPrI=; b=AvgWcUgMQtJ/BMhY/q+tO3owhfII/VkSOPCXWP/IiM3vAjfFhRDQb06JC/djMk9uvUYN2lwNNYLGzcEtKolWX6VUUgIYqvSGw70MeoXE+IISdmrJPGShmh3DJ7gvfMw/+7rNom6/blXn8tm/GlJoiGowxmfFkOEbKo8w/TXAdF5fQmmYvsyDdeUsqwJEC0EQEwr5mEUAB004iodz8Km+fJkdtvbFy2Gv+a/qIM2MUnC8SRHBdR2YiYAz+a7t46qcGSthhUszZiEcrU3WGDC0pivQ8MvLh/dVta+7VQyVo+7nn+1VAcN3daDbFYSMtIxmA0b8mBtVgHValXkuw+wgyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7fk/La/HxcMhijKuj7KEujyXYRGFGfcZLbcYAYcUPrI=; b=f08rEM4357CdxSryqjBvfNXgVmuXa7c4+xDZIhvYul4MHUu/y9BmWM7f86BC1tONAkSb0Vk3U7o/zbO71zjL+8o2u212SbCsXkNAGSKL3P6WnawyiObSKCfUsForlT4tAxQddl6RCuBfd0cAd8eHeFP6viWRQl7M/KRh7vE5Oob+Aig06EKnJsMm+3vNVyyh1UYWajD3W6bLcYTpK/Q8gGflrXI3BUu5T2ps/bIO8HfP/BzSIBW6w+EJ8gnTiI4EY6aGdQo/sbNffQb2o0vqnHzOCaVwRtRB1bew1qy1iTpdSbqFgKs+NKxdnBVQYz2CSs+r4MXdHBFmiHaRaWJH7Q== Received: from DM6PR10CA0020.namprd10.prod.outlook.com (2603:10b6:5:60::33) by IA1PR12MB6387.namprd12.prod.outlook.com (2603:10b6:208:389::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Mon, 6 May 2024 11:45:15 +0000 Received: from CY4PEPF0000E9D8.namprd05.prod.outlook.com (2603:10b6:5:60:cafe::62) by DM6PR10CA0020.outlook.office365.com (2603:10b6:5:60::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend Transport; Mon, 6 May 2024 11:45:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by CY4PEPF0000E9D8.mail.protection.outlook.com (10.167.241.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.18 via Frontend Transport; Mon, 6 May 2024 11:45:14 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:45:08 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:45:08 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 6 May 2024 04:45:05 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Matan Azrad CC: , Subject: [v2 12/16] net/mlx5/hws: dw order optimization code enhancement Date: Mon, 6 May 2024 14:44:15 +0300 Message-ID: <20240506114419.966498-12-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240506114419.966498-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> <20240506114419.966498-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D8:EE_|IA1PR12MB6387:EE_ X-MS-Office365-Filtering-Correlation-Id: 71a644f3-4a30-4b87-76e9-08dc6dc1fe91 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|82310400017|1800799015|376005|36860700004|921011; X-Microsoft-Antispam-Message-Info: utMYYxVG4xLvvfqKlKgzoCA27jE8HKmzFL0x6DoPZFvwG87g8ONPsEm4gGgB7KKDv5xPL6CHwbivY6fq1tsgWMzx+oE44QPWaJQwNn5B6jiAbseZRVU+XAcGhBDkOnGKcEtV91iolYD/I1jU61CkUGyRlOi1zKxCNXEA3ViSZGcmcrNzkE3hTP/zh2ern1ExgWVOB+mWLw+W40ZvqbQ/y0XOAm3mzkG1hizXeNPWW0s54FLNGRMpvGVXrz5rZkJsctj7a4B4w/XlMtm3pzxCwSZ12iKE18fE9+NbjGfaamMDlxD9GjEWrxSR7L2H57inqkBBDs31p2aiZq4GVKncTouFK65GWH1SIyQVgtev40z3ueeLREN64Ufg/Djk1ByWuDiX3CxvgZHiNtpM3I13xtL2f+eH95iwS0vRnDHx8iFjjd4Br8zK4bvYNZgs19iUvBwX6Zq1X+3VF3WgLAau8iGyiZ1EzmnQe3q4SleovNte+nkFieAQucEDtvyOFeerYcHnXMefwOnI1bzJ4tSMfEY48n5/Zjp8NfPy85UOSWc6gW0FQ8ozAHAV/d7Z9oYCmZv3KnjFnUdeNdUpmA31lkhvFyipNSXykaWmaTt4hbJxEsGm0pFZuBWx4QuyZTm9brZAVFSO/elAi2Yw6fMywTOIzaPzyFlvCRTkND9JXOQ/IFVTcic1rtf7TeLs/EdhhJGeUQFgmDxkNrslEI4oZO7o31WnFqg8AOOR5neQCpGKkZRM8k2a+ZInRarCckBun3r0cQoRSoKyDMKhIYYsP5t2hYZi0s+wzbp1kMvISYH6VX2n3pCYnLw4vYZtMlN5uHtQ7WLlk3ujUAyYCX6XhHI75dow29wLBMKicfb8W7idbLw/SPMGvH5xhGxAv5uG9LHi+Ff9Fqby7tn6pxoHZ+zp5vpR0DpECopy7un0tVgR9f0MXJKrpM/mgjYq1Cuj2RsHJbjWoCh3cLUxrD6tN03IJxwfkWSSYlpOlELo/gqKT2mD9Nfg5JvA6/mlLbAIzmlc61Eatk7lSFc/DNjYQWq87HR8eZ2m8jl7vnMcE0Df+ZFEd5L/1H7YPcAgCuEeDfq0COYiD9ZT1BUJfNDl8Ibg5wJK7G1Ww50ppYnKaes5gSF6d4ajsQZOtAYSh5kucCbjMGA91OgfJHGMrDM23q0eUjAWpLPLqEYTIntvkjd+O+eewkYq+umT076dl5X+nFQkIn3u7fNI/UiI7Agv/Upm4ckXAqoquuY3Tp9sdu0CZcqpdZtEK8Y0bdNSzsNKo118XUlKvd0e2zSgHeHnU1VtFubsLjVI2SgBTNVQdBGqdPLO5VdqyrwY9PASX2p4jgg7eVF59W0+gzI2rHShb2ZbGsJAqN0WeUNtDgcDgy98D6W+cnyQwDftRZ2/gbjF X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230031)(82310400017)(1800799015)(376005)(36860700004)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 11:45:14.5735 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 71a644f3-4a30-4b87-76e9-08dc6dc1fe91 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6387 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Improving code readability by following code styles such as mlx5dr prefix and extracting a support check to an external function call. Also, reducing unneeded static memory allocation using a bounded size macro. Fixes: 88ff41793e7a ("net/mlx5/hws: reorder STE fields to improve hash") Cc: stable@dpdk.org Signed-off-by: Itamar Gozlan Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_definer.c | 39 ++++++++++++++------------- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c index 81d0e0e6df..cffbb7b589 100644 --- a/drivers/net/mlx5/hws/mlx5dr_definer.c +++ b/drivers/net/mlx5/hws/mlx5dr_definer.c @@ -31,6 +31,8 @@ #define MLX5DR_DEFINER_QUOTA_BLOCK 0 #define MLX5DR_DEFINER_QUOTA_PASS 2 +#define MLX5DR_DEFINER_MAX_ROW_LOG 32 +#define MLX5DR_DEFINER_HL_OPT_MAX 2 /* Setter function based on bit offset and mask, for 32bit DW*/ #define _DR_SET_32(p, v, byte_off, bit_off, mask) \ @@ -104,21 +106,13 @@ __mlx5_dw_off(typ, fld))) >> __mlx5_dw_bit_off(typ, fld)) & \ __mlx5_mask(typ, fld)) -#define MAX_ROW_LOG 31 - -enum header_layout { - MLX5DR_HL_IPV4_SRC = 64, - MLX5DR_HL_IPV4_DST = 65, - MAX_HL_PRIO, -}; - /* Each row (i) indicates a different matcher size, and each column (j) * represents {DW5, DW4, DW3, DW2, DW1, DW0}. - * For values 0,..,2^i, and j (DW) 0,..,5: optimal_dist_dw[i][j] is 1 if the + * For values 0,..,2^i, and j (DW) 0,..,5: mlx5dr_optimal_dist_dw[i][j] is 1 if the * number of different hash results on these values equals 2^i, meaning this * DW hash distribution is complete. */ -int optimal_dist_dw[MAX_ROW_LOG][DW_SELECTORS_MATCH] = { +int mlx5dr_optimal_dist_dw[MLX5DR_DEFINER_MAX_ROW_LOG][DW_SELECTORS_MATCH] = { {1, 1, 1, 1, 1, 1}, {0, 1, 1, 0, 1, 0}, {0, 1, 1, 0, 1, 0}, {1, 0, 1, 0, 1, 0}, {0, 0, 0, 1, 1, 0}, {0, 1, 1, 0, 1, 0}, {0, 0, 0, 0, 1, 0}, {0, 1, 1, 0, 1, 0}, {0, 0, 0, 0, 0, 0}, @@ -3471,16 +3465,16 @@ mlx5dr_definer_find_best_range_fit(struct mlx5dr_definer *definer, static void mlx5dr_definer_optimize_order(struct mlx5dr_definer *definer, int num_log) { - uint8_t hl_prio[MAX_HL_PRIO - 1] = {MLX5DR_HL_IPV4_SRC, - MLX5DR_HL_IPV4_DST, - MAX_HL_PRIO}; + uint8_t hl_prio[MLX5DR_DEFINER_HL_OPT_MAX]; int dw = 0, i = 0, j; int *dw_flag; uint8_t tmp; - dw_flag = optimal_dist_dw[num_log]; + dw_flag = mlx5dr_optimal_dist_dw[num_log]; + hl_prio[0] = __mlx5_dw_off(definer_hl, ipv4_src_dest_outer.source_address); + hl_prio[1] = __mlx5_dw_off(definer_hl, ipv4_src_dest_outer.destination_address); - while (hl_prio[i] != MAX_HL_PRIO) { + while (i < MLX5DR_DEFINER_HL_OPT_MAX) { j = 0; /* Finding a candidate to improve its hash distribution */ while (j < DW_SELECTORS_MATCH && (hl_prio[i] != definer->dw_selector[j])) @@ -3632,6 +3626,16 @@ int mlx5dr_definer_compare(struct mlx5dr_definer *definer_a, return 0; } +static int +mlx5dr_definer_optimize_order_supported(struct mlx5dr_definer *match_definer, + struct mlx5dr_matcher *matcher) +{ + return !mlx5dr_definer_is_jumbo(match_definer) && + !mlx5dr_matcher_req_fw_wqe(matcher) && + !mlx5dr_matcher_is_resizable(matcher) && + !mlx5dr_matcher_is_insert_by_idx(matcher); +} + static int mlx5dr_definer_calc_layout(struct mlx5dr_matcher *matcher, struct mlx5dr_definer *match_definer, @@ -3693,10 +3697,7 @@ mlx5dr_definer_calc_layout(struct mlx5dr_matcher *matcher, goto free_fc; } - if (!mlx5dr_definer_is_jumbo(match_definer) && - !mlx5dr_matcher_req_fw_wqe(matcher) && - !mlx5dr_matcher_is_resizable(matcher) && - !mlx5dr_matcher_is_insert_by_idx(matcher)) + if (mlx5dr_definer_optimize_order_supported(match_definer, matcher)) mlx5dr_definer_optimize_order(match_definer, matcher->attr.rule.num_log); /* Find the range definer layout for match templates fcrs */ From patchwork Mon May 6 11:44:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 139895 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F19AB43FB4; Mon, 6 May 2024 13:46:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54A8A40697; Mon, 6 May 2024 13:45:48 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2076.outbound.protection.outlook.com [40.107.244.76]) by mails.dpdk.org (Postfix) with ESMTP id BE49140DCB; Mon, 6 May 2024 13:45:46 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JUgOohSteX2Cybn3x03+iFTujcUyy6IhB6X4OqvnScBINRtP+/vOmKuPTuMcLS9indPdXCRRwVWC/FZ/+YwborMCdnFXkWt3vzKIT2+b4BnD0kU1OETJ3FYjIqnmYGhLk1Oq/tvWIWFUuz3qhxcmIcmE7ClM2HcJjw2oRoYT1FhikoGtxLJXxxDMX0kKhb6dXeQgtKibr1MKyK6RROGfVpd8f2eHm51MXQGofscmvq8VkNX9SXjav3vbtmuhOlZ8K3FuhMUstbRe5rTB2hXUlqGMsYqim0euIKN7ThJjghfb3wyLhsbv39jdATbZFpaCM+rjAa6OJPysEaXzCoRepA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XH1LCzMBj7ft6IYZqbnc03R0doZRxIOG7QGmpD0wqYw=; b=XgrIA20rLkMvrR4opUZ7e5CoQha2oU+zInOfH0UL8lzI5PpFsRWWmiL0GuqTKxXpeeyiahe7saE3A6EMqd09Yd1wRqatXQmELGtOqmd9bj2H2lfMCjGxdO0bPYDdhAqgp4LOL91RC286Beeq7+2Gt22TIwArcF828i9s5c2f8V4wxdVH2md2edSxGjXGk1z9sR1DFuuT2XXZqOQUNBkKglMVxSU5tIlzpi4nm8/LX9KnaK1dm1G5Z/7pIbRfJUkLmbhd6UkVHv8nGOjv9qjtWTOfxceXLxwoETVVXpIXZBwHqsrxyDXhdpB4rKqN5A9MtxYa6PS9crDeKm1UR5yDZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XH1LCzMBj7ft6IYZqbnc03R0doZRxIOG7QGmpD0wqYw=; b=tRVZmbuKaaggQQrEmBRBU/Dq98XKuEiJ1epSnnuc33HYivZ+Hdri+XVd5H3AX1ZoNHNBZrNBx9r4ksbOaH5pt4cWVK1mffiC32WKYPNyQrwBxdEOrRJEsB/JRMo+LpA5SopGzXaL+bY0EKkRrPHd3f2uCpwDAPz6dTM3GJGPxDnPPdpUDUa2mimmyZFTUnJDHV1a38dy5MnuGebWd0admBavC1ZyCLHtqrCyQpJnAOrOtxA786LFt73l1LhmhNqlpeq90DdRKq661VUrpvSEkMqbKfsxjcXxDTrqHet0vIy9CofV4rbPrOOikNUWGfQJvSMclmozuRDsdQPTJYpFtQ== Received: from DM6PR10CA0009.namprd10.prod.outlook.com (2603:10b6:5:60::22) by LV3PR12MB9332.namprd12.prod.outlook.com (2603:10b6:408:20f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42; Mon, 6 May 2024 11:45:20 +0000 Received: from CY4PEPF0000E9D8.namprd05.prod.outlook.com (2603:10b6:5:60:cafe::a2) by DM6PR10CA0009.outlook.office365.com (2603:10b6:5:60::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend Transport; Mon, 6 May 2024 11:45:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by CY4PEPF0000E9D8.mail.protection.outlook.com (10.167.241.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.18 via Frontend Transport; Mon, 6 May 2024 11:45:20 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:45:12 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:45:12 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 6 May 2024 04:45:09 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Matan Azrad CC: , Subject: [v2 13/16] net/mlx5/hws: set default miss when replacing table Date: Mon, 6 May 2024 14:44:16 +0300 Message-ID: <20240506114419.966498-13-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240506114419.966498-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> <20240506114419.966498-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D8:EE_|LV3PR12MB9332:EE_ X-MS-Office365-Filtering-Correlation-Id: 08d59600-9160-4029-b201-08dc6dc201f7 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|1800799015|376005|36860700004|82310400017|921011; X-Microsoft-Antispam-Message-Info: y0i+w1Cd8IPq26rSZMQs8ifcVEjThh8HYl0QzWXmGHKXiSUF6HdoL3LACT1JtRZcdKZ8IkSmtpQa+qrckQgesJmUAsUiygMKcvMWhWTLkJfiN0phrdAYrr7I2zJE/GRQ5CIkcMsgRNoRG9cza1vKwMhvqmlVBjZECLJ9uMgKzapr8xOXRvYbqDs+d0XDEkZ+0s4P9ZXQp5E/KLf20uPum6YtqC5Q2D19GuoW8A2axJMOFcNlEUZFqzsYYlu42TLp75BegX2n4mdZneFYevD0lPV+gAE3wvQqxVJoHZwQn3zY82az51J8ccdUGia7RgE4YUUHLq6swA+Ga83t9uwEHxixOdRv+BplvraPffjuH8xUHxk9D5Kq6CmW223M5tDtUiumrAeEfbVV/58hpVnRg7OVjZso7AcA253rb+kT6zk80fgGbAhG8yw/Fb4sAFZF+7M37WAtAHcxVX4oB0xiIf3FezkLsQHwANXrishQ10UNnjO1dIPBg2exHsOwfXYtj45Zv0BqAdUDh23ICahDrlEDMTWQ5Gady+dQZZcPaHGAUYKPIEZE/lTFMUQoe1yabjNdxYX9DP/krqDhhzbtKO3TFaS1GwmpOVs/32UIcYue78egjV2OOtsIHdi4EzLcifrhYp358UMv/un7lMmXJwZFJlBzPo0CW2O+pz311Duo3w/CbkgiZSLgpPTHRj66/hfkGzG7th56f6yICFSJjFVxaoW+qJyLMhflbtstmMD0gx/vZEeRWzQsIVWHCNh9kiygPFgXjdXfFneIovk0APLP+oGX/So/ACd95/yMgFAf3V6OWB+2PTKaSFJPNf/+yrD/I/4cPxjSfJKOHUGEtvvQU7KSy2E2VdG2X2TrNwcLRxJNnVwBl56S8EoBybHyJTav2jB6A9SHiURKiRmaUQlZc5bSnMUh3X6n7wC8R2N/T5gexskkQkKMnCRy3SHrpxZzdI1W4b19W1lbctFKpgjAUVN66IArtbvdg8YgpIkyY+kn0K2Gjepb0ROfeUcOoCQdF9kb1b5DZ0Fqc0V7rHOmbiKsOg4NNKLJ5PL4xKg5soDjG1njk9DZrLpgMNrUk/L5cIPVr2cQ785k0qGXnfXCWCkTX/MM5hv4ERIZLbBPHXIECZhYtL5hmKP6sM6jvHY7SjFOmIPOQ0H+4GFyd0EqQ/X9mj14azE30c0RgBkJMZkY/sqordFEJ4wkEOwDRUNoRCzkeB/Wswjs+7+megDzXeOMRdIYY/OQ0mvoD5v4VJMgscb2An+YRaV4/VUYVz2KteH2RPQ0aiOkWGZX39e5/YCv0AxD3LzuRHrb1igJi72coe4oZ0S6T3u6tv2iNdMxSGpLfrdQ8OecSa1Vp6oB0PNW5mX8wsyHsbvMZEz0jUdWAVabJtxLXG7ToPIK X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(376005)(36860700004)(82310400017)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 11:45:20.2767 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 08d59600-9160-4029-b201-08dc6dc201f7 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9332 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Allowing the replacement of a miss table without enforcing a previous disconnecting. This feature extension allows the user to change the destination miss table when the system runs without losing traffic. Fixes: b81f95ca770d ("net/mlx5/hws: support default miss table") Cc: stable@dpdk.org Signed-off-by: Itamar Gozlan Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_table.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_table.c b/drivers/net/mlx5/hws/mlx5dr_table.c index 55b9b20150..ab73017ade 100644 --- a/drivers/net/mlx5/hws/mlx5dr_table.c +++ b/drivers/net/mlx5/hws/mlx5dr_table.c @@ -611,8 +611,7 @@ static int mlx5dr_table_set_default_miss_not_valid(struct mlx5dr_table *tbl, if (mlx5dr_table_is_root(tbl) || (miss_tbl && mlx5dr_table_is_root(miss_tbl)) || - (miss_tbl && miss_tbl->type != tbl->type) || - (miss_tbl && tbl->default_miss.miss_tbl)) { + (miss_tbl && miss_tbl->type != tbl->type)) { DR_LOG(ERR, "Invalid arguments"); rte_errno = EINVAL; return -rte_errno; @@ -625,6 +624,7 @@ int mlx5dr_table_set_default_miss(struct mlx5dr_table *tbl, struct mlx5dr_table *miss_tbl) { struct mlx5dr_context *ctx = tbl->ctx; + struct mlx5dr_table *old_miss_tbl; int ret; ret = mlx5dr_table_set_default_miss_not_valid(tbl, miss_tbl); @@ -632,15 +632,16 @@ int mlx5dr_table_set_default_miss(struct mlx5dr_table *tbl, return ret; pthread_spin_lock(&ctx->ctrl_lock); - + old_miss_tbl = tbl->default_miss.miss_tbl; ret = mlx5dr_table_connect_to_miss_table(tbl, miss_tbl); if (ret) goto out; + if (old_miss_tbl) + LIST_REMOVE(tbl, default_miss.next); + if (miss_tbl) LIST_INSERT_HEAD(&miss_tbl->default_miss.head, tbl, default_miss.next); - else - LIST_REMOVE(tbl, default_miss.next); pthread_spin_unlock(&ctx->ctrl_lock); return 0; From patchwork Mon May 6 11:44:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 139892 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95B5943FB4; Mon, 6 May 2024 13:46:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F327406B6; Mon, 6 May 2024 13:45:28 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2081.outbound.protection.outlook.com [40.107.102.81]) by mails.dpdk.org (Postfix) with ESMTP id 04B50402E7; Mon, 6 May 2024 13:45:27 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RsL1M3tqMs4YfQgz+6I0yYxkMWZh0LHzYe15YaM/0JAGSm1rgkKVzODl1Cw2+b2BoZxJZ+0a+a0qcdE2zWsB7OSOn8uIw4YDKbhgg5soj3HwUQvMhEnChoVWZvVbeWf2jZ1gf+MrnLy+kuTs9oOKjebfC166ocjh9XbGEFxbTjm1LyKX6N205u+AoGOavX7/YwdYrhgkBHngkX8vtvA1o2y0f9qha39vjMwuhUzhKjtp2FALVGmkaF6E0wFqnzK2BgvmiJGB4yf7LVnsqXD6YOrxpZpG34tPbXVBqpxhnJmUy+mr+clswr3kfeF4Do9FQC2NQj33gyM3WEPPeHCCNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pZHmiEc4PZJEJxg0AF8TYPZx6aBsXEO7EH+/dRTW3iQ=; b=jsA6/lyfhLRLmzxhdX1IJp9fkAyOhcUgxOmOvXvEDyRu9GgBMLFhMNISdaq7FSifQwt9de2En79s3wUtooRrTJ95u503u6I35BfXgguIPyk6ndeGQY/sVime670tJun4+6BfBEx4JeDjRzRh/v7ZUPWANqtvpIWeyvadypCq7o16iCLN41bfrGVsU6WqToEuVehyiywQsITWUv+QxuHvG/URFdswPxu90VWs3O+JDOUf21wf3TPqH+fSGugIPNupSxFGa9LEnCq0EvdTNN+I1yALYkJKbyfZaPh4wyZI5w62rlkh6SjwkThtCvWbawjcBR0wqIUmjZcSXUDVS4S4rQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pZHmiEc4PZJEJxg0AF8TYPZx6aBsXEO7EH+/dRTW3iQ=; b=n73R8NyeLo7zd9sh1buVRU3Qknn3nXXJiNScddnfWjD9J0dTiTeqvBzqr61MRkPZIZFA91YemDEkqpkERBjU8jL5BxsN2l+RzJpdssfiIiaKc7sh6DXWdHfWhbXDW0sPmkpUhQfLXMltLp9OVkMOI/bzj8eVldvDW+APm6nZk5vr9rQZuNrfR4eR5HCSPclbSJarz3CF2vjTxVb287xDyDeE4fxMGWUP41Ee6cFyQ2xeHFKe4ZHHAOCqGNMxzPiYQT7hKnTtUYXHUabw6P/hJAHqp3tRUrkPz+hjSlm0ftVMOjkdiMlDJAVU3eVM4U/tAqEdgejUjIkNDMqb2UgREw== Received: from DM6PR10CA0021.namprd10.prod.outlook.com (2603:10b6:5:60::34) by DM4PR12MB8559.namprd12.prod.outlook.com (2603:10b6:8:17d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Mon, 6 May 2024 11:45:24 +0000 Received: from CY4PEPF0000E9D8.namprd05.prod.outlook.com (2603:10b6:5:60:cafe::29) by DM6PR10CA0021.outlook.office365.com (2603:10b6:5:60::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend Transport; Mon, 6 May 2024 11:45:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by CY4PEPF0000E9D8.mail.protection.outlook.com (10.167.241.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.18 via Frontend Transport; Mon, 6 May 2024 11:45:23 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:45:16 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:45:15 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 6 May 2024 04:45:12 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Matan Azrad , Alex Vesker CC: , Subject: [v2 14/16] net/mlx5/hws: fix invalid memory access in decapl3 Date: Mon, 6 May 2024 14:44:17 +0300 Message-ID: <20240506114419.966498-14-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240506114419.966498-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> <20240506114419.966498-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D8:EE_|DM4PR12MB8559:EE_ X-MS-Office365-Filtering-Correlation-Id: 5544689a-97a6-4107-6356-08dc6dc203ae X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|82310400017|376005|1800799015|36860700004|921011; X-Microsoft-Antispam-Message-Info: kfeTMCvi8hDe5Gv1rAia0UdUmZaRYxKfWwKxv+AcnHUE2mueLFQJIlI/vDSrwDCkHgH4zrMmzfsfCCWdU+NBKehfzB0J/Gwt+ZMpiQAAWXP2zCyzNsqUY7rgV1gNSWPxjpjSILAS4MQDjx3WvaT7sLZe/Ya+VuqSCX7rP1I8Ah3506ItCF7vbTSzNO1xDIX/p3M8hR2gTGXSpOEcDZj9Jq9afU6XX9qa6YGvSqF6G+EtHz4aeHYgpqb0gpP0v6hQF1dFu/7Ua9nygar7y+EjYTtX1emFpQWShD10SCohPpRgfLDxU6FJDtSaXkTA9ZyamV4CNSiryjZO4DRaVshJ20Y9Yo9LnrIYAh9tl2hYCG/ud2KWH29mGL6GlgZOlcSz8d3fktVFKw5NJjsApc54cEY+2IF3OXaD559aRH5ufiyDu4ws8Cbz9/dicWrst4VgiH9X9m5t2FnZjreegBA07j4Qz5sEa1rzrmHK7TixDmIfCaj5ql0O//tEH/wY7re8jILYs4eELWr/wOVPfQjiaJAisM1RoFVsYiKa4nVWNWDxJRjORJqFd3FuhWMzkvLNLdKhWzm7nMm+sHsC/sV+/oikhYp8FwiM7doggrybA0RNWSgEKv+9dBMBq/iIWZQ1YaInTrlwOspcFay+VE9l2vf1eqC9H6JGY5D+KNEhm+mirIlZn+bmxafqFpP73dnax60hINo4yK62uBFjYKjmV5eKeg2WUCJ0WGOUdUVUO9CEpxSkZqz3rAb3d3AcKP1y201i1FALzKL/j/IoEjfauqQUk4EvL8EN9DrRw9Rk3ssa5SXpNtxpwfpmeQrAWIY2QUVwNARWY7Z09w2/WEckC0Cg7PN4GddBbOBE4tbySxNTblQXmtIVtdBjXCxtc4JR6srBvGvFxvYM+ZgDzNtbsPIyPXu55QJHg6vSTFQb21x1axsLfJKi2bm+2G2NNT19lCcO9MRHM1/5AReT1g+dqeBnPfi1hzrReXmHWVvUxUx38BxgMhdjh//bWTn+gNOk3YAGmME4EwlcCjS4R8ZSkFhhGF7n7FPTTUK04w4o4oFBIsaSBYhBVCpoA4OYZXzLZKXwLnUcvdkKr0N6w7YrpYRjaWVXhgRmJEqeHmyVvAq1/jGaPNLG685nvHE0cGmVKhokznp9FJ2dV+H80rfzlTKqpHmTLmVxGxXc+BXAVRFuR+5bgIh9y8tTNx4oJaBHOl1EEkpR75DAIeYcC+xHFB8cMZpfupnddl+PP2TuaX4AI1J+OIcy1Rd/wbO3UGlmk1il6l3R8t5yK7h61qSCtPt6+TUg3hZQRtgvKW3uwvvWoYik38LG0eBQ2qnVwxRU3pZlvlF3XYKaEmTpUHhcRIHQ9fo5hw5EzhlOqyokCAK6jOedy5zNcwLmHeNimsYG X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230031)(82310400017)(376005)(1800799015)(36860700004)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 11:45:23.1517 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5544689a-97a6-4107-6356-08dc6dc203ae X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB8559 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Alex Vesker In case decapL3 action is created we would access header data even in case the SHARED flag is not set, this would lead to an invalid memory access. Fixes: 3a6c50215c07 ("net/mlx5/hws: support multi-pattern") Cc: stable@dpdk.org Signed-off-by: Alex Vesker Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_action.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_action.c b/drivers/net/mlx5/hws/mlx5dr_action.c index 084d4d606e..562fb5cbb4 100644 --- a/drivers/net/mlx5/hws/mlx5dr_action.c +++ b/drivers/net/mlx5/hws/mlx5dr_action.c @@ -1775,7 +1775,9 @@ mlx5dr_action_handle_tunnel_l3_to_l2(struct mlx5dr_action *action, /* Create a full modify header action list in case shared */ mlx5dr_action_prepare_decap_l3_actions(hdrs->sz, mh_data, &num_of_actions); - mlx5dr_action_prepare_decap_l3_data(hdrs->data, mh_data, num_of_actions); + + if (action->flags & MLX5DR_ACTION_FLAG_SHARED) + mlx5dr_action_prepare_decap_l3_data(hdrs->data, mh_data, num_of_actions); /* All DecapL3 cases require the same max arg size */ arg_obj = mlx5dr_arg_create_modify_header_arg(ctx, From patchwork Mon May 6 11:44:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 139893 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6961643FB4; Mon, 6 May 2024 13:46:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 485D540A80; Mon, 6 May 2024 13:45:40 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2060.outbound.protection.outlook.com [40.107.96.60]) by mails.dpdk.org (Postfix) with ESMTP id 0430B402F0 for ; Mon, 6 May 2024 13:45:39 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PFQbdnplRluTGl1cF2oNTGJsCqEaADb20tlcu7k25EswLEKu5e0ACkfvdpa95nCPr8gh9gIW/etNlPSlmnsO8FFwTz9MIvBSQNp0/6hNDWmNk0pnPH8XHQvcpZ1jzOFtBiBTs4w/nZz9GOl7zLqFgxY13yYXvG1zHHujQymr0ruZE823aEBEjj90c9H54+ykW6Tvm5mYfeSj8cup/vqpBVFBoo0pGHAmY2hw6RNS3zt2h0v3ykNisO18hv6leGPsjI1ljf+6FBI00FY5Z4DQ/pgovFy/NfZxZzwN2wMtiIK76FqvFLA0fwKduAaYeGjYaDWXHe4uHL3x2v7nKvDZjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3qUeDZEQqbhLP35Somu7fiF+X6/EWzP96G8lk0L+/uU=; b=WEif7b88hEVSrMxbG3Uds1nTpxt9OraFL9/6BklftG3XlappaSf6wH0a1U8h+ZcLlwW9NFhQ1zJ9ckvxtK1sVdqGHPM40HRsHR5AsTleoMkTZ3DwIAJyX1fevZwN1eksb3+Ss+s3PQi2CBq+bed27qhS/34/5FWk9z/bZ+y2k2CHnizQor969iTIsqjvdpjkHEeN6lTU2cN3QIIMYZy7vGiJA0DoJvqnq/HCOEX8qjoNcH3p+yv7MyVrZyDwdl5an26MKaTk5nIWK4ZtMf+jEndHYk50u8fSwjqk0opSbeg2Gg44nZ3SqU9cX1rSG1nQLKyZIAZyMt0KSYiXZ6D/mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3qUeDZEQqbhLP35Somu7fiF+X6/EWzP96G8lk0L+/uU=; b=AmuhC4Sg2sXv7OabUdRG1NEtmuNlaOmQST5boJ6i5m6QsgQcY1ADKlF84VCLEbUKgsSO8/DkFfcR8i2zDzY6axDNxk067PorKRS4nZ8nrlArDNpT4INe7CaXFxUrdzbR/vO/G1BlJbHM1SE4SskeNt7BXErmXBI6Yb7RSqwrJ3fgKnXfruJRIyWkVrYcODlnGqSPeWm6Dl5JU/0BYz8iop0txCzuD8+nK4Lx71NEI5sHASOk+QcnAdgnH0VUwLZ7NoutSbp7EWUUWdwN20deRZlIYE+P3efAOFzz53bjvv7UekfnWPfaNxdQjRybRAH61LAqdQH//Lv+JQ3wpF4niA== Received: from BN9PR03CA0070.namprd03.prod.outlook.com (2603:10b6:408:fc::15) by MN2PR12MB4062.namprd12.prod.outlook.com (2603:10b6:208:1d0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42; Mon, 6 May 2024 11:45:36 +0000 Received: from BN3PEPF0000B374.namprd21.prod.outlook.com (2603:10b6:408:fc:cafe::8f) by BN9PR03CA0070.outlook.office365.com (2603:10b6:408:fc::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend Transport; Mon, 6 May 2024 11:45:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by BN3PEPF0000B374.mail.protection.outlook.com (10.167.243.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.0 via Frontend Transport; Mon, 6 May 2024 11:45:36 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:45:19 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:45:19 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 6 May 2024 04:45:16 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Matan Azrad CC: Subject: [v2 15/16] net/mlx5/hws: dump action ste arrays info Date: Mon, 6 May 2024 14:44:18 +0300 Message-ID: <20240506114419.966498-15-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240506114419.966498-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> <20240506114419.966498-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B374:EE_|MN2PR12MB4062:EE_ X-MS-Office365-Filtering-Correlation-Id: ca1ed3f8-90fa-41de-34d1-08dc6dc20b65 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|1800799015|376005|36860700004|82310400017|921011; X-Microsoft-Antispam-Message-Info: asHVs8jclkZ0USksN6u4q2OsoelbEcDmbGFuryC2Br9I8auhS9fO1aa1QuMyR05qYiAnJOdAapnJPaqClW+q3sZjB5sp2guqM4nJtW/r7FulvX42brPVYRwPbakHxxaICb9DLyhFcvNZF7rIG62CkRKt0P/8Wr1otJqNi58koMnAiwn3IXlo5UDyn8zdBXybkmhHw2BL4NreVYekEgeGy3CZSY0RVAIXeGI4tUjZRFq7sIVFxmoHvdpAdY/fBDVYtiLRMkPHSuUjvoWPoEUv9Cp8dmMdkt9NSMuxVEmr2lj0H1VOHOhV84GRE2TWX45JpFO7obFIy963NogefVt+TOcmIbBL4jHakd68o6ijAF8pfk7b2AhPFyqlhjX5dkdiuiSBfASSQQrgJw6NF1D9tj/wXT9Cw7cGD4wrp9YZKpOBBDveGUoQPvIReX9ZqWj2VNNUEv06hPEkjsxQYThSlvhKwg54kr21iBg3cs7Y/5k72orFH9cZssmVcIuXko9u4gLov3KaORS6YwrOKvtpKg8kaOroO5uwqIw9O8NSJUY5YW3O+eJgstjd25d9+1BoQWhQzGxlL321XaUI5aIxNoENJQAg2kXjw2SDCFexeN3RCaHlNKeKVvVhQbFg1scpyEBsN5tAkObulcHWx17A3bQhsUXBYV5DFvtj71RLMH2P6XMcFTSuZ5FbRmUNkP2ywcFyYMZd0hdEUba6eJDbmUhfnrmmIEh9oIPkYkAnqWwyGHOcmahIX1CWQxG30Em9VozOBGyoZ7GPOOO8G3gq7zFVczKfl6gjorHqJZWJAY2fxHjWK3VJxpuPrDVVocmiatO+w11eapXHoKpxkdWRdlymWpnGhcq1S2l7K2KraiYGG0bH32RAxbXRXCvSNaiWz9rQtKenoO09GxgBcO3RzWzfJdPkFWY5hbdzESjJ1IvKs9oT9VeCTzNlwWrYh0sYv6ZKwk8jwDDLLEKAOachiOImntMA8sUkK8eFaEAA6cGvzjqVaHullMx07IwCB1kSSJisfXnpdigwR+nmvQo2/MPNp/bz8MG5fqXvFJRey+LD61YrntvnGOGeGADqAJitjNKcpBtQ4ok4dzoUlgnuxB7Djo6WOaEt4P02bSCHq3HsHbbjkUtgs9UubADveevupsX0GThuz4LqnvX5/b1Tyd4ZJtjWMEZvioUSP483VjBLvjSB49Q/KR7dTXa7xsRNeMhCALCj+yHyjLyfvHHlmsGi3NHPbzT2v9jMNZWJqEJTDcF6NwM2V1CHXb44WioFstnNh87KtiLutvSVZcDvatq4GQ8CZ9RxKYRU3VCIjLbIyJ6ZRWsLhAOQKgqrJ9zDuBAzIPoyu14FYbGDLH2bJloLRmcotjr5ACxKOFgdmCGX96ekRY+OWmzjpiDwKwDz X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(376005)(36860700004)(82310400017)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 11:45:36.0157 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ca1ed3f8-90fa-41de-34d1-08dc6dc20b65 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B374.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4062 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Hamdan Igbaria Dump action ste arrays info for resizing matchers. Signed-off-by: Hamdan Igbaria Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_debug.c | 23 +++++++++++++++++++++++ drivers/net/mlx5/hws/mlx5dr_debug.h | 1 + drivers/net/mlx5/hws/mlx5dr_matcher.c | 1 + drivers/net/mlx5/hws/mlx5dr_matcher.h | 1 + 4 files changed, 26 insertions(+) diff --git a/drivers/net/mlx5/hws/mlx5dr_debug.c b/drivers/net/mlx5/hws/mlx5dr_debug.c index 8f07c7fd66..5ad4ca2da5 100644 --- a/drivers/net/mlx5/hws/mlx5dr_debug.c +++ b/drivers/net/mlx5/hws/mlx5dr_debug.c @@ -206,6 +206,7 @@ static int mlx5dr_debug_dump_matcher(FILE *f, struct mlx5dr_matcher *matcher) bool is_shared = mlx5dr_context_shared_gvmi_used(matcher->tbl->ctx); bool is_root = matcher->tbl->level == MLX5DR_ROOT_LEVEL; enum mlx5dr_table_type tbl_type = matcher->tbl->type; + struct mlx5dr_matcher_resize_data *resize_data; struct mlx5dr_cmd_ft_query_attr ft_attr = {0}; struct mlx5dr_devx_obj *ste_0, *ste_1 = NULL; struct mlx5dr_pool_chunk *ste; @@ -288,6 +289,28 @@ static int mlx5dr_debug_dump_matcher(FILE *f, struct mlx5dr_matcher *matcher) if (ret) return ret; + LIST_FOREACH(resize_data, &matcher->resize_data, next) { + ste = &resize_data->ste; + ste_pool = resize_data->action_ste_pool; + if (ste_pool) { + ste_0 = mlx5dr_pool_chunk_get_base_devx_obj(ste_pool, ste); + if (tbl_type == MLX5DR_TABLE_TYPE_FDB) + ste_1 = mlx5dr_pool_chunk_get_base_devx_obj_mirror(ste_pool, ste); + } else { + ste_0 = NULL; + ste_1 = NULL; + } + ret = fprintf(f, "%d,0x%" PRIx64 ",%d,%d,%d,%d\n", + MLX5DR_DEBUG_RES_TYPE_MATCHER_RESIZABLE_ACTION_ARRAY, + (uint64_t)(uintptr_t)matcher, + resize_data->action_ste_rtc_0 ? resize_data->action_ste_rtc_0->id : 0, + ste_0 ? (int)ste_0->id : -1, + resize_data->action_ste_rtc_1 ? resize_data->action_ste_rtc_1->id : 0, + ste_1 ? (int)ste_1->id : -1); + if (ret < 0) + return ret; + } + return 0; out_err: diff --git a/drivers/net/mlx5/hws/mlx5dr_debug.h b/drivers/net/mlx5/hws/mlx5dr_debug.h index a89a6a0b1d..b69002b5cd 100644 --- a/drivers/net/mlx5/hws/mlx5dr_debug.h +++ b/drivers/net/mlx5/hws/mlx5dr_debug.h @@ -25,6 +25,7 @@ enum mlx5dr_debug_res_type { MLX5DR_DEBUG_RES_TYPE_MATCHER_TEMPLATE_HASH_DEFINER = 4205, MLX5DR_DEBUG_RES_TYPE_MATCHER_TEMPLATE_RANGE_DEFINER = 4206, MLX5DR_DEBUG_RES_TYPE_MATCHER_TEMPLATE_COMPARE_MATCH_DEFINER = 4207, + MLX5DR_DEBUG_RES_TYPE_MATCHER_RESIZABLE_ACTION_ARRAY = 4208, }; static inline uint64_t diff --git a/drivers/net/mlx5/hws/mlx5dr_matcher.c b/drivers/net/mlx5/hws/mlx5dr_matcher.c index 78d525e578..8f1a202f81 100644 --- a/drivers/net/mlx5/hws/mlx5dr_matcher.c +++ b/drivers/net/mlx5/hws/mlx5dr_matcher.c @@ -724,6 +724,7 @@ mlx5dr_matcher_resize_init(struct mlx5dr_matcher *src_matcher) return rte_errno; } + resize_data->ste = src_matcher->action_ste.ste; resize_data->stc = src_matcher->action_ste.stc; resize_data->action_ste_rtc_0 = src_matcher->action_ste.rtc_0; resize_data->action_ste_rtc_1 = src_matcher->action_ste.rtc_1; diff --git a/drivers/net/mlx5/hws/mlx5dr_matcher.h b/drivers/net/mlx5/hws/mlx5dr_matcher.h index 6dc3bf4d0d..caff403a38 100644 --- a/drivers/net/mlx5/hws/mlx5dr_matcher.h +++ b/drivers/net/mlx5/hws/mlx5dr_matcher.h @@ -62,6 +62,7 @@ struct mlx5dr_matcher_action_ste { }; struct mlx5dr_matcher_resize_data { + struct mlx5dr_pool_chunk ste; struct mlx5dr_pool_chunk stc; struct mlx5dr_devx_obj *action_ste_rtc_0; struct mlx5dr_devx_obj *action_ste_rtc_1; From patchwork Mon May 6 11:44:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 139894 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3255943FB4; Mon, 6 May 2024 13:46:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D996640608; Mon, 6 May 2024 13:45:41 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2044.outbound.protection.outlook.com [40.107.244.44]) by mails.dpdk.org (Postfix) with ESMTP id C0189406B7; Mon, 6 May 2024 13:45:39 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L3PXN9TX+PoyVWZbc9fGHvxV93JNk3eDNPpL/118IqsPX0rSV3dsD/cKlIxPBQiswswe2UGNfWWAQjQ9nRuSZKmjPe7DzyxuLKSHLCtodBE8X+EM6bUDHyFR13ucL94en2LAzJDquh4Cv3E5q6/VwYNs3a4r+9qF5N3rnLXUVKtwTu9EP5IU1NWicWkaDmZnK61wTUpLkuVu8fEQlZhcr2V8OXqfMIj4VJQdKZwmddkg8HOV6gJ5gx20jbb8XmHkejoYQDbr5ban3YSHSYw/kqGLpOVWleIJzHKKTYtkThbiF5C6qlKoDOvrtVudKjcyguLF2Wf+KbBtD1HIdYBREg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AcvfOjoLuDx1v3nPEcZfQ+HzEaPuTgUl8B7qPHF6QAE=; b=GBDgB9M6s3hCQGEsmdxE8Xgrxwr0t1/+Kzp5qAb9XxMWfKlR1QYJwwFvdZPYseKrJuKaI29UCrdTwMpxEKJuyrnrzeRC9VERQPXVefk5GMOk76t6Ekt5ziBhDcZXTtA+gNX6Vf8lMWl9IB1ZIUGVeahbGGNtuy4npMpP+jeojIwMiYpwrFJTFmZKjdjE9jKS1Yu7mhaL9Bg3CTOODbuGZq2s6bIoSki9OnZagxQVVB47zGkU84EMGHNWTLR8sHLpql0M0cYeWu2kTXHjDycXlRYIigt+5N8/R5Fe8P7LDgX4ICEsftr0JEW7jeAcVh8dZAA0ojbvXKecN+We79JMtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AcvfOjoLuDx1v3nPEcZfQ+HzEaPuTgUl8B7qPHF6QAE=; b=LNEW58ifUMFsu9xdNMhDUWe65wQ+LY2zCsCGQ5v6BX469NFi9mvAwawW4lWKjnoWdzxl9aZM7U5T2TlD09p1/Om+Ngbe2oIq9CaclMplflhaWeMIKSoZrwTsSNa6um9Pz8kWlBAmBdgURiFFWxRkJ0ieetqEfOW69bLlwwkHoHe/yqiAOGew6BcaCwI7GZ6/UeZG8OY1nWeeASksEIt74/xJgiZoikkhoxutZQAHrXwBjfLMGTSNcqb8cVsin8c4FhGKvWnfYx4eM9LOmjvW81NZlCiDYkx9dJt4XaPCspBtnrHgZehDaZjM9hQhLiOAdIUw24WpQha+JCCJAm6JNQ== Received: from DM6PR04CA0026.namprd04.prod.outlook.com (2603:10b6:5:334::31) by CYYPR12MB8872.namprd12.prod.outlook.com (2603:10b6:930:c8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.40; Mon, 6 May 2024 11:45:37 +0000 Received: from CY4PEPF0000E9DA.namprd05.prod.outlook.com (2603:10b6:5:334:cafe::fb) by DM6PR04CA0026.outlook.office365.com (2603:10b6:5:334::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41 via Frontend Transport; Mon, 6 May 2024 11:45:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by CY4PEPF0000E9DA.mail.protection.outlook.com (10.167.241.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.18 via Frontend Transport; Mon, 6 May 2024 11:45:30 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:45:23 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:45:23 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 6 May 2024 04:45:20 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Matan Azrad , Alex Vesker CC: , Subject: [v2 16/16] net/mlx5/hws: fix action template only term param dump print Date: Mon, 6 May 2024 14:44:19 +0300 Message-ID: <20240506114419.966498-16-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240506114419.966498-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> <20240506114419.966498-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9DA:EE_|CYYPR12MB8872:EE_ X-MS-Office365-Filtering-Correlation-Id: 451e99ea-5998-4808-0ff0-08dc6dc20810 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|1800799015|376005|36860700004|82310400017|921011; X-Microsoft-Antispam-Message-Info: lRUNLDpJLgSZTRTUnjIU0wCPJ5AcLIezBOT7tPuHioddFLe81D5s8cnY5RNRxWa/SYOAUL7ITLavBlq/AsQnrtbTHX18nBLn26ymeAkc4mEPJQ3VW6sgFqxXrSi+41KyWhR0sDTzobADxQAF7KL04BOSlcOvSJevVYybqc1NzAbwMATDQ9IiJrq+XuEsACrzHs+JIDmqd++B9qFMF9ZH42oda0vAVKEHCmNOqk2hq7MSH4RUUSeY0F4eTwJfOclJYH789sJ+71YyIilMvrEO94cd0WXKSYgXKjuORqx0uaEPN5+dxeqoU3rXEzjPtTzAxYm/Yjm1JEA/jSwsBO7c9kMhMcjZJCs/SbUABcmwLPsP81VgGBhw6isjZNDyDN8qWVXvZp/9eqwp6SbbOcxcaaK8a5XEVcDbuiH+GADU7de0Q+I2O1dDLnGqJxgTbm521WTDw60G/A5fG2O45xikJXcPe1FvYEWV6IRGm2bkI2YlbHYlAI8fRNXLfrS7bOy71nWag10/yaKczYVa3zucNZRRRL5S+YAyynh5ZFi14bp046SBauyy8I4B6byqKGAwZb9XvBeLH150OAALAppoTutd4j1ueh0CNxDawaV+oiLcYjzKV2kA6Kh/XSxXINUbpzcIaLtJDm/1yAR/oWAeRhVO5GisYLQTNmPcPXG76H8gBv4w7sxRLe4u1dAKNbOwfZ3gksZbLxidjeYB47w30Nn6+3l51WRvPhqRp5VZ1WlIPQ5tRJlij8GhQ14jCShkFvkc4LtxcfopIVNodCQhvX/VCgVGhF6DVojDkDleMcg1XVxLdvnY2ggHD7Sz2tvSuIk3DvtrViRETHEuOGW+6hf7WCQNbZ3DwrYkun2hfTei+SN8eYKUmeXwAP4SXYRzUXGUQ4evXDz5bMblfrRZYv9wESdU2+67xv5EOh435FSuTOFvVzrpS/+nhY3pZ2CgeGtCa1uW0slh0MlDzYCQ1KPx73qv2PyPDyRT5SuoN29HjTnxGynMPrzOVA44rhHTDCk/4lHQ4g9g3BTu09Aa7BZj7v3g68SWZReQhrzQkzL4XFoVO2Dpb44cL5+Oyhz3ZvpkNd0DCjUp4lOOW92crVaH/EZBMa5TqK8RGmRQAWgCDxiATssVzHyTjxIxpCvZ03SwUC1vFP5fl/sVLEyX62hg+dwHZfYuI1JNEoIKNFJr4yJmTqFGEVaVBH2SGcyalLMtpNG4M9hVXl9i8bDqQXRJljNQZVvrYvyS00brNxBAf74gWLsQUaw78nV/zMaCBvrr06GXd/SJlWZluCI0hk4cePOvmh3YI6gC2x9fJl3QxaQ9nQpdkO+8WEMuR8YYab+LWCBCj2AdmIHq1LX/ouR5VuOiXtVyS4RQ2jR6p0t3u0VOzl+Bwq1UwUBtfOHZ X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(376005)(36860700004)(82310400017)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 11:45:30.5027 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 451e99ea-5998-4808-0ff0-08dc6dc20810 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9DA.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8872 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Hamdan Igbaria The debug print of only_term param in the action template was printed incorrectly. Fixes: 78580cf4e796 ("net/mlx5/hws: add debug layer") Cc: stable@dpdk.org Signed-off-by: Hamdan Igbaria Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_debug.c b/drivers/net/mlx5/hws/mlx5dr_debug.c index 5ad4ca2da5..741a725842 100644 --- a/drivers/net/mlx5/hws/mlx5dr_debug.c +++ b/drivers/net/mlx5/hws/mlx5dr_debug.c @@ -153,7 +153,7 @@ mlx5dr_debug_dump_matcher_action_template(FILE *f, struct mlx5dr_matcher *matche MLX5DR_DEBUG_RES_TYPE_MATCHER_ACTION_TEMPLATE, (uint64_t)(uintptr_t)at, (uint64_t)(uintptr_t)matcher, - at->only_term ? 0 : 1, + at->only_term, is_root ? 0 : at->num_of_action_stes, at->num_actions); if (ret < 0) {