From patchwork Wed Feb 6 10:34:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arkadiusz Kusztal X-Patchwork-Id: 50139 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 332AB5942; Wed, 6 Feb 2019 11:36:16 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 5D53F5942 for ; Wed, 6 Feb 2019 11:36:14 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Feb 2019 02:36:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,339,1544515200"; d="scan'208";a="144607718" Received: from akusztax-mobl.ger.corp.intel.com ([10.104.12.166]) by fmsmga001.fm.intel.com with ESMTP; 06 Feb 2019 02:36:10 -0800 From: Arek Kusztal To: dev@dpdk.org Cc: akhil.goyal@nxp.com, fiona.trahe@intel.com, shally.verma@caviumnetworks.com, sunila.sahu@caviumnetworks.com, ashish.gupta@caviumnetworks.com, umesh.kartha@caviumnetworks.com, Arek Kusztal Date: Wed, 6 Feb 2019 11:34:26 +0100 Message-Id: <20190206103426.1568-1-arkadiuszx.kusztal@intel.com> X-Mailer: git-send-email 2.19.1.windows.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3] cryptodev: rework mod exp and mod inv comments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch changes modular exponentiation and modular multiplicative inverse API comments to make it more precise. Signed-off-by: Arek Kusztal Acked-by: Fiona Trahe Acked-by: Shally Verma Acked-by: Akhil Goyal --- v2: - grammar fixes v3: - remove information about positive integer lib/librte_cryptodev/rte_crypto_asym.h | 43 ++++++++++++++++++++++------------ 1 file changed, 28 insertions(+), 15 deletions(-) diff --git a/lib/librte_cryptodev/rte_crypto_asym.h b/lib/librte_cryptodev/rte_crypto_asym.h index 5e185b2..0a50cd5 100644 --- a/lib/librte_cryptodev/rte_crypto_asym.h +++ b/lib/librte_cryptodev/rte_crypto_asym.h @@ -72,8 +72,8 @@ enum rte_crypto_asym_xform_type { * Refer to rte_crypto_asym_op_type */ RTE_CRYPTO_ASYM_XFORM_MODINV, - /**< Modular Inverse - * Perform Modulus inverse b^(-1) mod n + /**< Modular Multiplicative Inverse + * Perform Modular Multiplicative Inverse b^(-1) mod n */ RTE_CRYPTO_ASYM_XFORM_MODEX, /**< Modular Exponentiation @@ -233,29 +233,38 @@ struct rte_crypto_rsa_xform { struct rte_crypto_modex_xform { rte_crypto_param modulus; /**< modulus - * Prime modulus of the modexp transform operation in octet-string - * network byte order format. + * Pointer to the modulus data for modexp transform operation + * in octet-string network byte order format + * + * In case this number is equal to zero the driver shall set + * the crypto op status field to RTE_CRYPTO_OP_STATUS_ERROR */ rte_crypto_param exponent; /**< exponent - * Private exponent of the modexp transform operation in - * octet-string network byte order format. + * Exponent of the modexp transform operation in + * octet-string network byte order format */ }; /** - * Asymmetric modular inverse transform operation + * Asymmetric modular multiplicative inverse transform operation * - * Structure describing modulus inverse xform params + * Structure describing modular multiplicative inverse transform * */ struct rte_crypto_modinv_xform { rte_crypto_param modulus; /**< - * Pointer to the prime modulus data for modular - * inverse operation in octet-string network byte - * order format. + * Pointer to the modulus data for modular multiplicative inverse + * operation in octet-string network byte order format + * + * In case this number is equal to zero the driver shall set + * the crypto op status field to RTE_CRYPTO_OP_STATUS_ERROR + * + * This number shall be relatively prime to base + * in corresponding Modular Multiplicative Inverse + * rte_crypto_mod_op_param */ }; @@ -317,14 +326,18 @@ struct rte_crypto_dsa_xform { /** * Operations params for modular operations: - * exponentiation and invert + * exponentiation and multiplicative inverse * */ struct rte_crypto_mod_op_param { rte_crypto_param base; /**< - * Pointer to base of modular exponentiation/inversion data in - * Octet-string network byte order format. + * Pointer to base of modular exponentiation/multiplicative + * inverse data in octet-string network byte order format + * + * In case Multiplicative Inverse is used this number shall + * be relatively prime to modulus in corresponding Modular + * Multiplicative Inverse rte_crypto_modinv_xform */ }; @@ -348,7 +361,7 @@ struct rte_crypto_asym_xform { /**< Modular Exponentiation xform parameters */ struct rte_crypto_modinv_xform modinv; - /**< Modulus Inverse xform parameters */ + /**< Modular Multiplicative Inverse xform parameters */ struct rte_crypto_dh_xform dh; /**< DH xform parameters */