From patchwork Sun Dec 22 12:49:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ariel Otilibili-Anieli X-Patchwork-Id: 149370 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E6B445F13; Sun, 22 Dec 2024 13:58:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A737D40615; Sun, 22 Dec 2024 13:57:57 +0100 (CET) Received: from smtp.eurecom.fr (smtp.eurecom.fr [193.55.113.210]) by mails.dpdk.org (Postfix) with ESMTP id D44EF402DE; Sun, 22 Dec 2024 13:57:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=eurecom.fr; i=@eurecom.fr; q=dns/txt; s=default; t=1734872268; x=1766408268; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=uVgx522J3KeVhLz7ZxySq3N8WGRG1XEMAPR/vXDMuQ4=; b=TA9Aev8V6rVFedNbuN8YLrnDjzl1iZ2KRfMAEkspA2Fm+Si8Gqck4812 DhAh0n7Q8Dh+VX3jECyHBw609t4FeHXN/T6DReQWsIEJ7/ZkIByGxXfX0 5MrRHUsTgWPJX7aNAz0DXaw09aeLFMiVm2u6kv/C5yPs7zL4QOflPePCc I=; X-CSE-ConnectionGUID: GaOTHyhtSqGsGD1xZZwpGg== X-CSE-MsgGUID: Ez3UhYTaRuC1M2blMbFf2w== X-IronPort-AV: E=Sophos;i="6.12,255,1728943200"; d="scan'208";a="28290598" Received: from waha.eurecom.fr (HELO smtps.eurecom.fr) ([10.3.2.236]) by drago1i.eurecom.fr with ESMTP; 22 Dec 2024 13:57:48 +0100 Received: from localhost.localdomain (88-183-119-157.subs.proxad.net [88.183.119.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtps.eurecom.fr (Postfix) with ESMTPSA id 73D672595; Sun, 22 Dec 2024 13:57:48 +0100 (CET) From: Ariel Otilibili To: dev@dpdk.org Cc: stable@dpdk.org, Thomas Monjalon , David Marchand , Ariel Otilibili , Stephen Hemminger , Andrew Boyer Subject: [PATCH v4 01/11] devtools/cocci, lib/eal: remove unused rte_bitmap_free() Date: Sun, 22 Dec 2024 13:49:21 +0100 Message-ID: <20241222125725.1532157-2-otilibil@eurecom.fr> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241222125725.1532157-1-otilibil@eurecom.fr> References: <20241222125725.1532157-1-otilibil@eurecom.fr> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Coverity reports return values of calls to rte_bitmap_free() are not used. As of commit 07604f2644 ("maintainers: update for next-net tree"): ``` $ awk 'NR>281 && NR<300 {print NR ":" $0}' lib/eal/include/rte_bitmap.h 282:/** 283: * Bitmap free 284: * 285: * @param bmp 286: * Handle to bitmap instance 287: * @return 288: * 0 upon success, error code otherwise 289: */ 290:static inline int 291:rte_bitmap_free(struct rte_bitmap *bmp) 292:{ 293: /* Check input arguments */ 294: if (bmp == NULL) { 295: return -1; 296: } 297: 298: return 0; 299:} ``` rte_bitmap_free() checks the pointer to its input rte_bitmap is not null, and does nothing else. Functions wherein rte_bitmap_free() is called do not use its return value. ``` $ git grep -Pn 'rte_bitmap_free\(' app/test/test_bitmap.c:211: rte_bitmap_free(bmp); app/test/test_bitmap.c:257: rte_bitmap_free(bmp); devtools/cocci/nullfree.cocci:19:- if (E != NULL) rte_bitmap_free(E); devtools/cocci/nullfree.cocci:20:+ rte_bitmap_free(E); drivers/common/cnxk/roc_platform.h:127:#define plt_bitmap_free rte_bitmap_free drivers/common/mlx5/mlx5_common_mr.c:497: rte_bitmap_free(mr->ms_bmp); drivers/crypto/ionic/ionic_crypto_main.c:817: rte_bitmap_free(dev->sess_bm); drivers/net/bonding/rte_eth_bond_pmd.c:2246: rte_bitmap_free(internals->vlan_filter_bmp); drivers/net/cxgbe/cxgbe_main.c:468: rte_bitmap_free(t->ftid_bmap); drivers/net/mlx4/mlx4_mr.c:474: rte_bitmap_free(mr->ms_bmp); drivers/net/netvsc/hn_rxtx.c:186: rte_bitmap_free(hv->chim_bmap); drivers/net/sfc/sfc_sw_stats.c:818: rte_bitmap_free(sa->sw_stats.queues_bitmap); lib/eal/include/rte_bitmap.h:291:rte_bitmap_free(struct rte_bitmap *bmp) ``` The clearing of these Coverity warnings have been discussed more than once this year, the question of its existence has also been asked. Subsequent commits will remove rte_bitmap_free where it was used. Coverity issue: 357712, 357737 Link: https://lore.kernel.org/all/6A08397F-8D6E-4631-B63E-4CAE319F1463@amd.com/T/#m35464e4e6dccfa904ab7e5f0a0b246e63e0ed74e Link: https://inbox.dpdk.org/dev/20241213085928.0f2f2de1@hermes.local/ Signed-off-by: Ariel Otilibili --- Cc: stable@dpdk.org Cc: Stephen Hemminger Cc: Andrew Boyer --- devtools/cocci/nullfree.cocci | 3 --- lib/eal/include/rte_bitmap.h | 19 ------------------- 2 files changed, 22 deletions(-) diff --git a/devtools/cocci/nullfree.cocci b/devtools/cocci/nullfree.cocci index c0526a2a3f..8f0c4a4144 100644 --- a/devtools/cocci/nullfree.cocci +++ b/devtools/cocci/nullfree.cocci @@ -16,9 +16,6 @@ expression E; - if (E != NULL) rte_acl_free(E); + rte_acl_free(E); | -- if (E != NULL) rte_bitmap_free(E); -+ rte_bitmap_free(E); -| - if (E != NULL) rte_comp_op_free(E); + rte_comp_op_free(E); | diff --git a/lib/eal/include/rte_bitmap.h b/lib/eal/include/rte_bitmap.h index abb102f1d3..63d54f5761 100644 --- a/lib/eal/include/rte_bitmap.h +++ b/lib/eal/include/rte_bitmap.h @@ -279,25 +279,6 @@ rte_bitmap_init_with_all_set(uint32_t n_bits, uint8_t *mem, uint32_t mem_size) return bmp; } -/** - * Bitmap free - * - * @param bmp - * Handle to bitmap instance - * @return - * 0 upon success, error code otherwise - */ -static inline int -rte_bitmap_free(struct rte_bitmap *bmp) -{ - /* Check input arguments */ - if (bmp == NULL) { - return -1; - } - - return 0; -} - /** * Bitmap reset * From patchwork Sun Dec 22 12:49:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ariel Otilibili-Anieli X-Patchwork-Id: 149371 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B69C45F13; Sun, 22 Dec 2024 13:58:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B674740655; Sun, 22 Dec 2024 13:57:59 +0100 (CET) Received: from smtp.eurecom.fr (smtp.eurecom.fr [193.55.113.210]) by mails.dpdk.org (Postfix) with ESMTP id C0E71402DE; Sun, 22 Dec 2024 13:57:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=eurecom.fr; i=@eurecom.fr; q=dns/txt; s=default; t=1734872270; x=1766408270; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=iLxjB0EXojKGScpZzqpb/4JQ5BRDpEHZeSb3Puw0tC0=; b=HKFow26CamW6P4AxEuEq7xlr5kiYbN8OgxhBCd07AtY0Sdb60cLa5R2F dvKUp3kw47FpYrdtK1eD7xeUApEAkJlPExxT2xC+bK2kuDcA4+ycKKZU/ pL2Szy9swgpyvDF5MF4lLmQmwMuGlhiQfFRiISlJ1BucifzQ93MF6Cf8/ U=; X-CSE-ConnectionGUID: bKgEYhN7Roi6qE6OsaLsbw== X-CSE-MsgGUID: 1ohQnFR0SN2Ii9O5oCJdmQ== X-IronPort-AV: E=Sophos;i="6.12,255,1728943200"; d="scan'208";a="28290599" Received: from waha.eurecom.fr (HELO smtps.eurecom.fr) ([10.3.2.236]) by drago1i.eurecom.fr with ESMTP; 22 Dec 2024 13:57:50 +0100 Received: from localhost.localdomain (88-183-119-157.subs.proxad.net [88.183.119.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtps.eurecom.fr (Postfix) with ESMTPSA id 664B12596; Sun, 22 Dec 2024 13:57:50 +0100 (CET) From: Ariel Otilibili To: dev@dpdk.org Cc: stable@dpdk.org, Thomas Monjalon , David Marchand , Ariel Otilibili , Cristian Dumitrescu , Stephen Hemminger Subject: [PATCH v4 02/11] app/test: remove unused rte_bitmap_free() Date: Sun, 22 Dec 2024 13:49:22 +0100 Message-ID: <20241222125725.1532157-3-otilibil@eurecom.fr> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241222125725.1532157-1-otilibil@eurecom.fr> References: <20241222125725.1532157-1-otilibil@eurecom.fr> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Coverity issue: 357712, 357737 Fixes: 24d376bfee ("test/bitmap: fix memory leak") Signed-off-by: Ariel Otilibili --- Cc: stable@dpdk.org Cc: Cristian Dumitrescu Cc: Stephen Hemminger --- app/test/test_bitmap.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/test/test_bitmap.c b/app/test/test_bitmap.c index bab11812c7..a21210a215 100644 --- a/app/test/test_bitmap.c +++ b/app/test/test_bitmap.c @@ -208,7 +208,6 @@ test_bitmap_all_clear(void) if (test_bitmap_scan_operations(bmp) < 0) return TEST_FAILED; - rte_bitmap_free(bmp); rte_free(mem); return TEST_SUCCESS; @@ -254,7 +253,6 @@ test_bitmap_all_set(void) return TEST_FAILED; } - rte_bitmap_free(bmp); rte_free(mem); return TEST_SUCCESS; From patchwork Sun Dec 22 12:49:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ariel Otilibili-Anieli X-Patchwork-Id: 149372 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8151D45F13; Sun, 22 Dec 2024 13:58:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A0EC04064F; Sun, 22 Dec 2024 13:58:03 +0100 (CET) Received: from smtp.eurecom.fr (smtp.eurecom.fr [193.55.113.210]) by mails.dpdk.org (Postfix) with ESMTP id 46E80402DE; Sun, 22 Dec 2024 13:57:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=eurecom.fr; i=@eurecom.fr; q=dns/txt; s=default; t=1734872272; x=1766408272; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=KQb9qJYgnNB/8iJSNhB1e54km1s4/h5NnEIl5Fqlsu8=; b=Mv7iLsg3GC8IFwzUABo5htdlKMyUwyIfoTwlFDI33aJSkOwCPfdoAmgq NC2JPRxfwj8zVw4InmyUwJlZbDm6Isp2A+6vHRPB0Z4tplk+A6n5j7tDA jPqApPsVhVYWfOpzEBcmaojvO3TI5zEMct6Yneo5CR3sLSnPg0HHRLtuD c=; X-CSE-ConnectionGUID: b2Bv+UBSToqldSeL14NWIw== X-CSE-MsgGUID: Zg+UIks9Sg6DfCKI2daZSg== X-IronPort-AV: E=Sophos;i="6.12,255,1728943200"; d="scan'208";a="28290600" Received: from waha.eurecom.fr (HELO smtps.eurecom.fr) ([10.3.2.236]) by drago1i.eurecom.fr with ESMTP; 22 Dec 2024 13:57:52 +0100 Received: from localhost.localdomain (88-183-119-157.subs.proxad.net [88.183.119.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtps.eurecom.fr (Postfix) with ESMTPSA id E1D5C2597; Sun, 22 Dec 2024 13:57:51 +0100 (CET) From: Ariel Otilibili To: dev@dpdk.org Cc: stable@dpdk.org, Thomas Monjalon , David Marchand , Ariel Otilibili , Andrew Rybchenko Subject: [PATCH v4 03/11] net/sfc: remove unused rte_bitmap_free() Date: Sun, 22 Dec 2024 13:49:23 +0100 Message-ID: <20241222125725.1532157-4-otilibil@eurecom.fr> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241222125725.1532157-1-otilibil@eurecom.fr> References: <20241222125725.1532157-1-otilibil@eurecom.fr> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: e00c3a0c1b ("net/sfc: rename SW stats structures") Signed-off-by: Ariel Otilibili --- Cc: stable@dpdk.org Cc: Andrew Rybchenko --- drivers/net/sfc/sfc_sw_stats.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/sfc/sfc_sw_stats.c b/drivers/net/sfc/sfc_sw_stats.c index 3ae5023b6f..90e95aed22 100644 --- a/drivers/net/sfc/sfc_sw_stats.c +++ b/drivers/net/sfc/sfc_sw_stats.c @@ -815,7 +815,6 @@ sfc_sw_xstats_configure(struct sfc_adapter *sa) static void sfc_sw_xstats_free_queues_bitmap(struct sfc_adapter *sa) { - rte_bitmap_free(sa->sw_stats.queues_bitmap); rte_free(sa->sw_stats.queues_bitmap_mem); } From patchwork Sun Dec 22 12:49:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ariel Otilibili-Anieli X-Patchwork-Id: 149373 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C1AF45F13; Sun, 22 Dec 2024 13:58:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 24E944066F; Sun, 22 Dec 2024 13:58:05 +0100 (CET) Received: from smtp.eurecom.fr (smtp.eurecom.fr [193.55.113.210]) by mails.dpdk.org (Postfix) with ESMTP id B0F13402DE; Sun, 22 Dec 2024 13:57:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=eurecom.fr; i=@eurecom.fr; q=dns/txt; s=default; t=1734872273; x=1766408273; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=uBA/RKc4qfcuHK/KFS/+/9JxHuaeSaI0fwoV8AnZB7Q=; b=YQ9laOzXS+B8SPVBKz+dlDkFsYfWqZeHHh6y8ritZv7HFrEcvUzMcWy1 R24rQwrV+U8LqKTLcO6V00aWQI3jkgoSrvbW6XPe96Z6TLulYkq/wBBpG hcawV8xxgXdNANH5KLY+t1mGytwohsgTyXWF2I0RRBLDiaHIQlb8MGak5 Y=; X-CSE-ConnectionGUID: XjmXGzu3Tj2cs+bjB/iqkA== X-CSE-MsgGUID: R+8pTCVQR/y8ntc/+n9XeA== X-IronPort-AV: E=Sophos;i="6.12,255,1728943200"; d="scan'208";a="28290601" Received: from waha.eurecom.fr (HELO smtps.eurecom.fr) ([10.3.2.236]) by drago1i.eurecom.fr with ESMTP; 22 Dec 2024 13:57:53 +0100 Received: from localhost.localdomain (88-183-119-157.subs.proxad.net [88.183.119.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtps.eurecom.fr (Postfix) with ESMTPSA id 4F4192598; Sun, 22 Dec 2024 13:57:53 +0100 (CET) From: Ariel Otilibili To: dev@dpdk.org Cc: stable@dpdk.org, Thomas Monjalon , David Marchand , Ariel Otilibili , Andrew Boyer Subject: [PATCH v4 04/11] crypto/ionic: remove unused rte_bitmap_free() Date: Sun, 22 Dec 2024 13:49:24 +0100 Message-ID: <20241222125725.1532157-5-otilibil@eurecom.fr> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241222125725.1532157-1-otilibil@eurecom.fr> References: <20241222125725.1532157-1-otilibil@eurecom.fr> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: 6bc7f2cf66 ("crypto/ionic: support sessions") Signed-off-by: Ariel Otilibili --- Cc: stable@dpdk.org Cc: Andrew Boyer --- drivers/crypto/ionic/ionic_crypto_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/crypto/ionic/ionic_crypto_main.c b/drivers/crypto/ionic/ionic_crypto_main.c index f670d6e658..ef5b54f161 100644 --- a/drivers/crypto/ionic/ionic_crypto_main.c +++ b/drivers/crypto/ionic/ionic_crypto_main.c @@ -814,7 +814,6 @@ iocpt_free_objs(struct iocpt_dev *dev) } if (dev->sess_bm != NULL) { - rte_bitmap_free(dev->sess_bm); rte_free(dev->sess_bm); dev->sess_bm = NULL; } From patchwork Sun Dec 22 12:49:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ariel Otilibili-Anieli X-Patchwork-Id: 149374 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8129F45F13; Sun, 22 Dec 2024 13:58:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B8D14067A; Sun, 22 Dec 2024 13:58:06 +0100 (CET) Received: from smtp.eurecom.fr (smtp.eurecom.fr [193.55.113.210]) by mails.dpdk.org (Postfix) with ESMTP id 08D20402DE; Sun, 22 Dec 2024 13:57:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=eurecom.fr; i=@eurecom.fr; q=dns/txt; s=default; t=1734872275; x=1766408275; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=KMOwC1xtDAgWc7zcqgCl1ky8thiRibfR3QPxDXwt8Kg=; b=yHaRZXmgxE0ZDND80zwgnsKRiwNPsiWYm5+2O9e7bZPiRaE3t3IMVtRN JrvtlHA9qsYCStHrMaXWa3X3BZX8ReTO+4dG7lhpF+D/QZ8YMXlFtXBln aq6frp+evKWZPWUolr3PUcmNtQEwGQXyd3jAyZBbI78TSc20mFfiRYklt Y=; X-CSE-ConnectionGUID: w+hAQ9tGRVOdT+fHyvi+0Q== X-CSE-MsgGUID: qnCLGkw3RhKIspZm+mgbmg== X-IronPort-AV: E=Sophos;i="6.12,255,1728943200"; d="scan'208";a="28290602" Received: from waha.eurecom.fr (HELO smtps.eurecom.fr) ([10.3.2.236]) by drago1i.eurecom.fr with ESMTP; 22 Dec 2024 13:57:54 +0100 Received: from localhost.localdomain (88-183-119-157.subs.proxad.net [88.183.119.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtps.eurecom.fr (Postfix) with ESMTPSA id A46A62599; Sun, 22 Dec 2024 13:57:54 +0100 (CET) From: Ariel Otilibili To: dev@dpdk.org Cc: stable@dpdk.org, Thomas Monjalon , David Marchand , Ariel Otilibili , Potnuri Bharat Teja Subject: [PATCH v4 05/11] net/cxgbe: remove unused rte_bitmap_free() Date: Sun, 22 Dec 2024 13:49:25 +0100 Message-ID: <20241222125725.1532157-6-otilibil@eurecom.fr> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241222125725.1532157-1-otilibil@eurecom.fr> References: <20241222125725.1532157-1-otilibil@eurecom.fr> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: 06c047b680 ("remove unnecessary null checks") Signed-off-by: Ariel Otilibili --- Cc: stable@dpdk.org Cc: Potnuri Bharat Teja --- drivers/net/cxgbe/cxgbe_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/cxgbe/cxgbe_main.c b/drivers/net/cxgbe/cxgbe_main.c index 2ed21f2d66..91ecddd287 100644 --- a/drivers/net/cxgbe/cxgbe_main.c +++ b/drivers/net/cxgbe/cxgbe_main.c @@ -465,7 +465,6 @@ void cxgbe_insert_tid(struct tid_info *t, void *data, unsigned int tid, static void tid_free(struct tid_info *t) { if (t->tid_tab) { - rte_bitmap_free(t->ftid_bmap); if (t->ftid_bmap_array) t4_os_free(t->ftid_bmap_array); From patchwork Sun Dec 22 12:49:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ariel Otilibili-Anieli X-Patchwork-Id: 149375 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8011A45F13; Sun, 22 Dec 2024 13:58:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C57D640671; Sun, 22 Dec 2024 13:58:07 +0100 (CET) Received: from smtp.eurecom.fr (smtp.eurecom.fr [193.55.113.210]) by mails.dpdk.org (Postfix) with ESMTP id 5A408402E7; Sun, 22 Dec 2024 13:57:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=eurecom.fr; i=@eurecom.fr; q=dns/txt; s=default; t=1734872276; x=1766408276; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HlwVapTm9FcG3z1JrLvDdzWAqzXKAepxPSRmJnFZmdE=; b=XCEEfnItj2LIByPhi83iDodxcWp/lsDYZsIb1ZMt3SqSdlmHauT094dZ 2Onw+OnF86IE0em/Cw0UiehFpnlopaoWoCfQ/J3kmxi/zqz0vzpM0UKJh 4VRWjYJozcMMwnbNT2D047W8lIfX13RnPDQKbezmczuQjugV3WUKiJUHM s=; X-CSE-ConnectionGUID: nTSCMCx0Q1W0F9MI/q6ZUA== X-CSE-MsgGUID: uy415/2oTpWnd0nqVEdJwg== X-IronPort-AV: E=Sophos;i="6.12,255,1728943200"; d="scan'208";a="28290603" Received: from waha.eurecom.fr (HELO smtps.eurecom.fr) ([10.3.2.236]) by drago1i.eurecom.fr with ESMTP; 22 Dec 2024 13:57:56 +0100 Received: from localhost.localdomain (88-183-119-157.subs.proxad.net [88.183.119.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtps.eurecom.fr (Postfix) with ESMTPSA id ED964259A; Sun, 22 Dec 2024 13:57:55 +0100 (CET) From: Ariel Otilibili To: dev@dpdk.org Cc: stable@dpdk.org, Thomas Monjalon , David Marchand , Ariel Otilibili , Matan Azrad , Viacheslav Ovsiienko Subject: [PATCH v4 06/11] net/mlx4: remove unused rte_bitmap_free() Date: Sun, 22 Dec 2024 13:49:26 +0100 Message-ID: <20241222125725.1532157-7-otilibil@eurecom.fr> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241222125725.1532157-1-otilibil@eurecom.fr> References: <20241222125725.1532157-1-otilibil@eurecom.fr> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: 06c047b680 ("remove unnecessary null checks") Signed-off-by: Ariel Otilibili --- Cc: stable@dpdk.org Cc: Matan Azrad Cc: Viacheslav Ovsiienko --- drivers/net/mlx4/mlx4_mr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/mlx4/mlx4_mr.c b/drivers/net/mlx4/mlx4_mr.c index 2251c624ff..67a2a66481 100644 --- a/drivers/net/mlx4/mlx4_mr.c +++ b/drivers/net/mlx4/mlx4_mr.c @@ -471,7 +471,6 @@ mr_free(struct mlx4_mr *mr) DEBUG("freeing MR(%p):", (void *)mr); if (mr->ibv_mr != NULL) claim_zero(mlx4_glue->dereg_mr(mr->ibv_mr)); - rte_bitmap_free(mr->ms_bmp); rte_free(mr); } From patchwork Sun Dec 22 12:49:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ariel Otilibili-Anieli X-Patchwork-Id: 149376 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5465745F13; Sun, 22 Dec 2024 13:58:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EDE0A406B6; Sun, 22 Dec 2024 13:58:08 +0100 (CET) Received: from smtp.eurecom.fr (smtp.eurecom.fr [193.55.113.210]) by mails.dpdk.org (Postfix) with ESMTP id EDA2D40647; Sun, 22 Dec 2024 13:57:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=eurecom.fr; i=@eurecom.fr; q=dns/txt; s=default; t=1734872278; x=1766408278; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=UEjfHVUGMmI9ohorKlrNm+ZZ7poBTyCUTsA/VZ0Y0ss=; b=T688WLVRIaKOReDq5TdAZdr2bnNNTV9JBDIJPNx6cIQk7MppeW+Gvl25 yutCMqXWpHQ+0bXvxzmoaP1/6nSc2y1qv/CRkndYIYaKltalu1Gu0NV04 wQKAOeDxJzsBpFCQWAhbQ6o3HV6xOQ7XTP9x2HlJWWCZK+Q7jBSBu8EKC A=; X-CSE-ConnectionGUID: w46dw83YQVOgc70FfPWWHg== X-CSE-MsgGUID: ANYPQFWcSeuhoTjf9cMP4A== X-IronPort-AV: E=Sophos;i="6.12,255,1728943200"; d="scan'208";a="28290604" Received: from waha.eurecom.fr (HELO smtps.eurecom.fr) ([10.3.2.236]) by drago1i.eurecom.fr with ESMTP; 22 Dec 2024 13:57:57 +0100 Received: from localhost.localdomain (88-183-119-157.subs.proxad.net [88.183.119.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtps.eurecom.fr (Postfix) with ESMTPSA id 730EC259B; Sun, 22 Dec 2024 13:57:57 +0100 (CET) From: Ariel Otilibili To: dev@dpdk.org Cc: stable@dpdk.org, Thomas Monjalon , David Marchand , Ariel Otilibili , Dariusz Sosnowski , Viacheslav Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad Subject: [PATCH v4 07/11] common/mlx5: remove unused rte_bitmap_free() Date: Sun, 22 Dec 2024 13:49:27 +0100 Message-ID: <20241222125725.1532157-8-otilibil@eurecom.fr> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241222125725.1532157-1-otilibil@eurecom.fr> References: <20241222125725.1532157-1-otilibil@eurecom.fr> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: 06c047b680 ("remove unnecessary null checks") Signed-off-by: Ariel Otilibili --- Cc: stable@dpdk.org Cc: Dariusz Sosnowski Cc: Viacheslav Ovsiienko Cc: Bing Zhao Cc: Ori Kam Cc: Suanming Mou Cc: Matan Azrad --- drivers/common/mlx5/mlx5_common_mr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/common/mlx5/mlx5_common_mr.c b/drivers/common/mlx5/mlx5_common_mr.c index 50922ad398..dee0b521dd 100644 --- a/drivers/common/mlx5/mlx5_common_mr.c +++ b/drivers/common/mlx5/mlx5_common_mr.c @@ -494,7 +494,6 @@ mlx5_mr_free(struct mlx5_mr *mr, mlx5_dereg_mr_t dereg_mr_cb) return; DRV_LOG(DEBUG, "freeing MR(%p):", (void *)mr); dereg_mr_cb(&mr->pmd_mr); - rte_bitmap_free(mr->ms_bmp); mlx5_free(mr); } From patchwork Sun Dec 22 12:49:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ariel Otilibili-Anieli X-Patchwork-Id: 149377 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3459045F13; Sun, 22 Dec 2024 13:58:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4281A406FF; Sun, 22 Dec 2024 13:58:10 +0100 (CET) Received: from smtp.eurecom.fr (smtp.eurecom.fr [193.55.113.210]) by mails.dpdk.org (Postfix) with ESMTP id 89BF3402DE; Sun, 22 Dec 2024 13:57:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=eurecom.fr; i=@eurecom.fr; q=dns/txt; s=default; t=1734872279; x=1766408279; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FoFzzdk2+zbAQPLFOVTnjySmNZHIlvHKyhULUOHebm0=; b=jyh8+AdmZNPKRh/NGlB1vXmWTphN4Pd9bPGT2y4j7N+3zN5ax+KXAWxJ CS+PKm2QSwcXkEzw08Lz1EdvrEipBS9GcqLnMCyQJSyHmg0N6vvTmNtJU bg1UP1KTbJuv21QWdh/r+zKg19tKH/3NZhwrLgsOvaUzuDHJJ7DRCKsnS 8=; X-CSE-ConnectionGUID: Hcysri8SQ0Wei3EvO8zLgA== X-CSE-MsgGUID: VvGJUPXcQtWbYVGro4GVsg== X-IronPort-AV: E=Sophos;i="6.12,255,1728943200"; d="scan'208";a="28290605" Received: from waha.eurecom.fr (HELO smtps.eurecom.fr) ([10.3.2.236]) by drago1i.eurecom.fr with ESMTP; 22 Dec 2024 13:57:59 +0100 Received: from localhost.localdomain (88-183-119-157.subs.proxad.net [88.183.119.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtps.eurecom.fr (Postfix) with ESMTPSA id 25547259C; Sun, 22 Dec 2024 13:57:59 +0100 (CET) From: Ariel Otilibili To: dev@dpdk.org Cc: stable@dpdk.org, Thomas Monjalon , David Marchand , Ariel Otilibili , Chas Williams , "Min Hu (Connor)" Subject: [PATCH v4 08/11] net/bonding: remove unused rte_bitmap_free() Date: Sun, 22 Dec 2024 13:49:28 +0100 Message-ID: <20241222125725.1532157-9-otilibil@eurecom.fr> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241222125725.1532157-1-otilibil@eurecom.fr> References: <20241222125725.1532157-1-otilibil@eurecom.fr> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: 171875d067 ("net/bonding: release port upon close") Signed-off-by: Ariel Otilibili --- Cc: stable@dpdk.org Cc: Chas Williams Cc: "Min Hu (Connor)" --- drivers/net/bonding/rte_eth_bond_pmd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 91bf2c2345..5f9a739e55 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -2243,7 +2243,6 @@ bond_ethdev_close(struct rte_eth_dev *dev) bond_ethdev_free_queues(dev); rte_bitmap_reset(internals->vlan_filter_bmp); - rte_bitmap_free(internals->vlan_filter_bmp); rte_free(internals->vlan_filter_bmpmem); /* Try to release mempool used in mode6. If the bond From patchwork Sun Dec 22 12:49:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ariel Otilibili-Anieli X-Patchwork-Id: 149378 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B711945F13; Sun, 22 Dec 2024 13:58:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 831FD40A6B; Sun, 22 Dec 2024 13:58:11 +0100 (CET) Received: from smtp.eurecom.fr (smtp.eurecom.fr [193.55.113.210]) by mails.dpdk.org (Postfix) with ESMTP id 09A974065D; Sun, 22 Dec 2024 13:58:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=eurecom.fr; i=@eurecom.fr; q=dns/txt; s=default; t=1734872281; x=1766408281; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+HN4p6iK/FX9gNL28689qvMAvUv7+CB66EHJuAXcjvw=; b=Yi3gGHOb+gymFZi20q1HKSsPSQIq8OzoKthbH+AyTC6CqqzzW6CuTiOR QOQX7KlNs5iPGULuBBxy1NtoD9d+T0CSvo+YEmnHBm80xoz0l3tx0x3BU xPiWNXJyBWw7ZfmphdoWG0EroZqrjVY9czVeO4Ldr8lHNle9ni7AVDu0c 8=; X-CSE-ConnectionGUID: skyMCsylTxCF86+HLE8UCw== X-CSE-MsgGUID: XMm55ngPSU+r2kIi7a3Yjw== X-IronPort-AV: E=Sophos;i="6.12,255,1728943200"; d="scan'208";a="28290606" Received: from waha.eurecom.fr (HELO smtps.eurecom.fr) ([10.3.2.236]) by drago1i.eurecom.fr with ESMTP; 22 Dec 2024 13:58:00 +0100 Received: from localhost.localdomain (88-183-119-157.subs.proxad.net [88.183.119.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtps.eurecom.fr (Postfix) with ESMTPSA id A5AE4259D; Sun, 22 Dec 2024 13:58:00 +0100 (CET) From: Ariel Otilibili To: dev@dpdk.org Cc: stable@dpdk.org, Thomas Monjalon , David Marchand , Ariel Otilibili , Long Li , Wei Hu Subject: [PATCH v4 09/11] net/netvsc: remove unused rte_bitmap_free() Date: Sun, 22 Dec 2024 13:49:29 +0100 Message-ID: <20241222125725.1532157-10-otilibil@eurecom.fr> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241222125725.1532157-1-otilibil@eurecom.fr> References: <20241222125725.1532157-1-otilibil@eurecom.fr> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: cc02518132 ("net/netvsc: split send buffers from Tx descriptors") Signed-off-by: Ariel Otilibili --- Cc: stable@dpdk.org Cc: Long Li Cc: Wei Hu --- drivers/net/netvsc/hn_rxtx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c index 9d3948e03d..148c7c4a33 100644 --- a/drivers/net/netvsc/hn_rxtx.c +++ b/drivers/net/netvsc/hn_rxtx.c @@ -183,7 +183,6 @@ hn_chim_uninit(struct rte_eth_dev *dev) { struct hn_data *hv = dev->data->dev_private; - rte_bitmap_free(hv->chim_bmap); rte_free(hv->chim_bmem); hv->chim_bmem = NULL; } From patchwork Sun Dec 22 12:49:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ariel Otilibili-Anieli X-Patchwork-Id: 149379 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2D9B45F13; Sun, 22 Dec 2024 13:58:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1315B40A72; Sun, 22 Dec 2024 13:58:13 +0100 (CET) Received: from smtp.eurecom.fr (smtp.eurecom.fr [193.55.113.210]) by mails.dpdk.org (Postfix) with ESMTP id AFF6C4064A; Sun, 22 Dec 2024 13:58:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=eurecom.fr; i=@eurecom.fr; q=dns/txt; s=default; t=1734872282; x=1766408282; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qZFwH7lwfAb2q6HhR0i8Z235o0vNE9SuvQuIjGTiOYk=; b=GEqjSY+2zbBBHuyMo8INS2KycMSGTbQdGAKa7jwbFZd8+SxzSVlZsArx AYCeIatvnbv67bCn7t+aOccJACqJAKPqmzuRcPruEVORhmI5+zdQSxte8 jQG/q2t6RTRKKxNPFJRvuFHOXWrpcq3F8Ep0Aq3w1PYNmXzP98fzfqyk0 M=; X-CSE-ConnectionGUID: imhA2qT8QAO75qj4MsRblQ== X-CSE-MsgGUID: p5zSQeBUTruI9FU3T0VAtw== X-IronPort-AV: E=Sophos;i="6.12,255,1728943200"; d="scan'208";a="28290607" Received: from waha.eurecom.fr (HELO smtps.eurecom.fr) ([10.3.2.236]) by drago1i.eurecom.fr with ESMTP; 22 Dec 2024 13:58:02 +0100 Received: from localhost.localdomain (88-183-119-157.subs.proxad.net [88.183.119.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtps.eurecom.fr (Postfix) with ESMTPSA id 2D8F6259E; Sun, 22 Dec 2024 13:58:02 +0100 (CET) From: Ariel Otilibili To: dev@dpdk.org Cc: stable@dpdk.org, Thomas Monjalon , David Marchand , Ariel Otilibili , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Harman Kalra Subject: [PATCH v4 10/11] common/cnxk: remove unused plt_bitmap_free() Date: Sun, 22 Dec 2024 13:49:30 +0100 Message-ID: <20241222125725.1532157-11-otilibil@eurecom.fr> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241222125725.1532157-1-otilibil@eurecom.fr> References: <20241222125725.1532157-1-otilibil@eurecom.fr> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Depends on d5941e7269 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). plt_bitmap_free() is an alias of rte_bitmap_free(). A subsequent commit removes all its occurrences: ``` $ git grep -Pn 'plt_bitmap_free\(' drivers/common/cnxk/roc_mcs.c:722: plt_bitmap_free(rsrc->tcam_bmap); drivers/common/cnxk/roc_mcs.c:724: plt_bitmap_free(rsrc->secy_bmap); drivers/common/cnxk/roc_mcs.c:726: plt_bitmap_free(rsrc->sc_bmap); drivers/common/cnxk/roc_mcs.c:728: plt_bitmap_free(rsrc->sa_bmap); drivers/common/cnxk/roc_nix_inl_dev.c:840: plt_bitmap_free(inl_dev->soft_exp_ring_bmap); drivers/common/cnxk/roc_nix_inl_dev.c:1072: plt_bitmap_free(inl_dev->soft_exp_ring_bmap); drivers/common/cnxk/roc_nix_tm.c:2036: plt_bitmap_free(nix->schq_bmp[hw_lvl]); drivers/common/cnxk/roc_nix_tm.c:2037: plt_bitmap_free(nix->schq_contig_bmp[hw_lvl]); drivers/common/cnxk/roc_npa.c:1260: plt_bitmap_free(lf->npa_bmp); drivers/common/cnxk/roc_npa.c:1277: plt_bitmap_free(lf->npa_bmp); drivers/common/cnxk/roc_npc_aging.c:46: plt_bitmap_free(flow_age->aged_flows); drivers/net/cnxk/cnxk_ethdev.c:314: plt_bitmap_free(dev->outb.sa_bmap); ``` Fixes: fa8f86a14e ("common/cnxk: add build infrastructre and HW definition") Signed-off-by: Ariel Otilibili --- Cc: stable@dpdk.org Cc: Nithin Dabilpuram Cc: Kiran Kumar K Cc: Sunil Kumar Kori Cc: Satha Rao Cc: Harman Kalra --- drivers/common/cnxk/roc_platform.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/common/cnxk/roc_platform.h b/drivers/common/cnxk/roc_platform.h index df4f88f288..6c4a69377f 100644 --- a/drivers/common/cnxk/roc_platform.h +++ b/drivers/common/cnxk/roc_platform.h @@ -124,7 +124,6 @@ #define plt_bitmap rte_bitmap #define plt_bitmap_init rte_bitmap_init #define plt_bitmap_reset rte_bitmap_reset -#define plt_bitmap_free rte_bitmap_free #define plt_bitmap_clear rte_bitmap_clear #define plt_bitmap_set rte_bitmap_set #define plt_bitmap_get rte_bitmap_get From patchwork Sun Dec 22 12:49:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ariel Otilibili-Anieli X-Patchwork-Id: 149380 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78FE345F13; Sun, 22 Dec 2024 13:59:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32BE340A79; Sun, 22 Dec 2024 13:58:15 +0100 (CET) Received: from smtp.eurecom.fr (smtp.eurecom.fr [193.55.113.210]) by mails.dpdk.org (Postfix) with ESMTP id 7E51C4065D; Sun, 22 Dec 2024 13:58:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=eurecom.fr; i=@eurecom.fr; q=dns/txt; s=default; t=1734872284; x=1766408284; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pvDCKWlymTTLFFgYOJOhXJynUih1s+Ps7bWcyLG9FFU=; b=rID2sX6a4IZ0WRc+cx7/ihtPDVr/R0dGc8mSWpaRw06hE2RVrZfAuhIr M50mn5OB4PBP87/TxO24Ba+8PTciAniO4ezoNamPXt13FfQomZWaD1gr/ 0FhpaM527rSKsIrc2uKHJQ+VbAGBbqY65lkDFgvHjrfOAhSWpb5iRDzpw Q=; X-CSE-ConnectionGUID: /c2yIFGARKClTZ2dw3Zbhg== X-CSE-MsgGUID: Jfxx2UQjTKaDfrkQ8obHFA== X-IronPort-AV: E=Sophos;i="6.12,255,1728943200"; d="scan'208";a="28290608" Received: from waha.eurecom.fr (HELO smtps.eurecom.fr) ([10.3.2.236]) by drago1i.eurecom.fr with ESMTP; 22 Dec 2024 13:58:04 +0100 Received: from localhost.localdomain (88-183-119-157.subs.proxad.net [88.183.119.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtps.eurecom.fr (Postfix) with ESMTPSA id 079D3259F; Sun, 22 Dec 2024 13:58:03 +0100 (CET) From: Ariel Otilibili To: dev@dpdk.org Cc: stable@dpdk.org, Thomas Monjalon , David Marchand , Ariel Otilibili , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Harman Kalra Subject: [PATCH v4 11/11] {common,net}/cnxk: remove unused plt_bitmap_free() Date: Sun, 22 Dec 2024 13:49:31 +0100 Message-ID: <20241222125725.1532157-12-otilibil@eurecom.fr> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241222125725.1532157-1-otilibil@eurecom.fr> References: <20241222125725.1532157-1-otilibil@eurecom.fr> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Depends on commits: * 13844f8557 ("common/cnxk: remove unused plt_bitmap_free()") * d5941e7269 ("devtools/cocci,lib/eal: remove unused rte_bitmap_free()"). Fixes: f752780f30 ("common/cnxk: add ROC MACsec initialization") Fixes: bea5d990a9 ("net/cnxk: support outbound soft expiry notification") Fixes: 05d727e8b1 ("common/cnxk: support NIX traffic management") Fixes: 124ff1a4cb ("common/cnxk: support NPA device") Fixes: 357f5ebc8a ("common/cnxk: support flow aging") Fixes: 7eabd6c637 ("net/cnxk: support inline security setup for cn9k") Signed-off-by: Ariel Otilibili --- Cc: stable@dpdk.org Cc: Nithin Dabilpuram Cc: Kiran Kumar K Cc: Sunil Kumar Kori Cc: Satha Rao Cc: Harman Kalra --- drivers/common/cnxk/roc_mcs.c | 4 ---- drivers/common/cnxk/roc_nix_inl_dev.c | 2 -- drivers/common/cnxk/roc_nix_tm.c | 5 ----- drivers/common/cnxk/roc_npa.c | 4 ---- drivers/common/cnxk/roc_npc_aging.c | 1 - drivers/net/cnxk/cnxk_ethdev.c | 1 - 6 files changed, 17 deletions(-) diff --git a/drivers/common/cnxk/roc_mcs.c b/drivers/common/cnxk/roc_mcs.c index f823f7f478..4df3b2ff92 100644 --- a/drivers/common/cnxk/roc_mcs.c +++ b/drivers/common/cnxk/roc_mcs.c @@ -719,13 +719,9 @@ mcs_alloc_bmap(uint16_t entries, void **mem, struct plt_bitmap **bmap) static void rsrc_bmap_free(struct mcs_rsrc *rsrc) { - plt_bitmap_free(rsrc->tcam_bmap); plt_free(rsrc->tcam_bmap_mem); - plt_bitmap_free(rsrc->secy_bmap); plt_free(rsrc->secy_bmap_mem); - plt_bitmap_free(rsrc->sc_bmap); plt_free(rsrc->sc_bmap_mem); - plt_bitmap_free(rsrc->sa_bmap); plt_free(rsrc->sa_bmap_mem); } diff --git a/drivers/common/cnxk/roc_nix_inl_dev.c b/drivers/common/cnxk/roc_nix_inl_dev.c index ffe6eef81f..d2b5aa5bab 100644 --- a/drivers/common/cnxk/roc_nix_inl_dev.c +++ b/drivers/common/cnxk/roc_nix_inl_dev.c @@ -837,7 +837,6 @@ nix_inl_outb_poll_thread_setup(struct nix_inl_dev *inl_dev) rc = plt_thread_create_control(&inl_dev->soft_exp_poll_thread, "outb-poll", nix_inl_outb_poll_thread, inl_dev); if (rc) { - plt_bitmap_free(inl_dev->soft_exp_ring_bmap); plt_free(inl_dev->soft_exp_ring_bmap_mem); } @@ -1069,7 +1068,6 @@ roc_nix_inl_dev_fini(struct roc_nix_inl_dev *roc_inl_dev) if (inl_dev->set_soft_exp_poll) { soft_exp_poll_thread_exit = true; plt_thread_join(inl_dev->soft_exp_poll_thread, NULL); - plt_bitmap_free(inl_dev->soft_exp_ring_bmap); plt_free(inl_dev->soft_exp_ring_bmap_mem); plt_free(inl_dev->sa_soft_exp_ring); } diff --git a/drivers/common/cnxk/roc_nix_tm.c b/drivers/common/cnxk/roc_nix_tm.c index abfe80978b..f8b14acb16 100644 --- a/drivers/common/cnxk/roc_nix_tm.c +++ b/drivers/common/cnxk/roc_nix_tm.c @@ -2030,11 +2030,6 @@ void nix_tm_conf_fini(struct roc_nix *roc_nix) { struct nix *nix = roc_nix_to_nix_priv(roc_nix); - uint16_t hw_lvl; - for (hw_lvl = 0; hw_lvl < NIX_TXSCH_LVL_CNT; hw_lvl++) { - plt_bitmap_free(nix->schq_bmp[hw_lvl]); - plt_bitmap_free(nix->schq_contig_bmp[hw_lvl]); - } plt_free(nix->schq_bmp_mem); } diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c index a33f9a8499..9ec010119b 100644 --- a/drivers/common/cnxk/roc_npa.c +++ b/drivers/common/cnxk/roc_npa.c @@ -1227,7 +1227,6 @@ npa_dev_init(struct npa_lf *lf, uintptr_t base, struct mbox *mbox) lf->npa_qint_mem = plt_zmalloc(sizeof(struct npa_qint) * nr_pools, 0); if (lf->npa_qint_mem == NULL) { rc = NPA_ERR_ALLOC; - goto bmap_free; } /* Allocate memory for nap_aura_lim memory */ @@ -1256,8 +1255,6 @@ npa_dev_init(struct npa_lf *lf, uintptr_t base, struct mbox *mbox) plt_free(lf->aura_lim); qint_free: plt_free(lf->npa_qint_mem); -bmap_free: - plt_bitmap_free(lf->npa_bmp); bmap_mem_free: plt_free(lf->npa_bmp_mem); lf_free: @@ -1274,7 +1271,6 @@ npa_dev_fini(struct npa_lf *lf) plt_free(lf->aura_lim); plt_free(lf->npa_qint_mem); - plt_bitmap_free(lf->npa_bmp); plt_free(lf->npa_bmp_mem); plt_free(lf->aura_attr); diff --git a/drivers/common/cnxk/roc_npc_aging.c b/drivers/common/cnxk/roc_npc_aging.c index 258c15e341..93b1bf2a47 100644 --- a/drivers/common/cnxk/roc_npc_aging.c +++ b/drivers/common/cnxk/roc_npc_aging.c @@ -43,7 +43,6 @@ npc_aged_flows_bitmap_free(struct roc_npc *roc_npc) struct roc_npc_flow_age *flow_age; flow_age = &roc_npc->flow_age; - plt_bitmap_free(flow_age->aged_flows); if (flow_age->age_mem) plt_free(roc_npc->flow_age.age_mem); } diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c index ea980a6d5e..3d30c2939f 100644 --- a/drivers/net/cnxk/cnxk_ethdev.c +++ b/drivers/net/cnxk/cnxk_ethdev.c @@ -311,7 +311,6 @@ nix_security_release(struct cnxk_eth_dev *dev) plt_err("Failed to cleanup nix inline outb, rc=%d", rc); ret |= rc; - plt_bitmap_free(dev->outb.sa_bmap); plt_free(dev->outb.sa_bmap_mem); dev->outb.sa_bmap = NULL; dev->outb.sa_bmap_mem = NULL;