From patchwork Tue Feb 12 23:05:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 50276 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E0D7E1B0F7; Wed, 13 Feb 2019 00:05:17 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id D72077D05; Wed, 13 Feb 2019 00:05:15 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 77C7E21E71; Tue, 12 Feb 2019 18:05:15 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 12 Feb 2019 18:05:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=OE9GpjkJLv SsWeJxBXjiVIdlJA18q6Vwf4tILS8RmwQ=; b=Tsd+rgFCyHrzS6z/F+Zm7oK0ur X76MwlAhkcP8QUKWntbaCG7ibVp17IM1BuqgpWYWXUTZUkRumbrPA5N0/V+2KGXz R8wWhaFOhtwKz2QKW+HZRskmq4a0jJda0ic/lueymVCRi52DXPBWEvAvMM/Q92ja sEbkVE3yazA+9ASLo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=OE9GpjkJLvSsWeJxBXjiVIdlJA18q6Vwf4tILS8RmwQ=; b=cLoto1lj I8kgwaFkhaERcNSVKreOwr80kZIQ/M61sUqYDa785OwVZrgFuWzqw2TEItqLZ78t Oqt5DG9lX7Ytv/9ACt/9tmXBQCWjgqTLuC3SETc5GHctpXyevLSnOcgk9llEz5L2 ikvhVMCxRYjr2vjpsXT+Ypd0sPWOyAkufZB93d/X99keEH+9qRd6Xf3qUAzN69qY dzdhUzFqLLs+G+YHlLDHzBUjL/FXPntKiIK6MEewdraapnnMu6YDXk9ZSOzKoJxt AJoyn6MEbB8daXVTPAnsipSlvRdWSASxY/x1MhqSvbAug98+Iu3yX4XiPqGFH5Ju 7teijmbLOmU/VA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtvddgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecumhhishhsihhnghcuvffquchfihgvlhguucdlfedtmdenucfjughrpefhvffuff fkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhho nhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffohhmrghinhepvhgrrh hsrdhmkhdplhhisgdrmhhknecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlh hushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 60859E409D; Tue, 12 Feb 2019 18:05:14 -0500 (EST) From: Thomas Monjalon To: Cc: dev@dpdk.org, bruce.richardson@intel.com, stable@dpdk.org Date: Wed, 13 Feb 2019 00:05:04 +0100 Message-Id: <20190212230507.11793-2-thomas@monjalon.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190212230507.11793-1-thomas@monjalon.net> References: <20190212230507.11793-1-thomas@monjalon.net> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/4] mk: fix build of shared library with libbsd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When building DPDK with "make" and options CONFIG_RTE_USE_LIBBSD=y and CONFIG_RTE_BUILD_SHARED_LIB=y libbsd was not linked, resulting in compilation errors: undefined reference to `strlcpy' The link option -lbsd is added in a common place for both Linux apps and libs. It is used in app linkage via EXECENV_LDLIBS, and in lib linkage via the added variable EXECENV_LDLIBS-y. Fixes: 5364de644a4b ("eal: support strlcpy function") Cc: bruce.richardson@intel.com Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon --- mk/exec-env/linuxapp/rte.vars.mk | 6 ++++++ mk/rte.app.mk | 3 --- mk/rte.lib.mk | 2 ++ 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/mk/exec-env/linuxapp/rte.vars.mk b/mk/exec-env/linuxapp/rte.vars.mk index 3129edc8c..57ee82150 100644 --- a/mk/exec-env/linuxapp/rte.vars.mk +++ b/mk/exec-env/linuxapp/rte.vars.mk @@ -24,6 +24,8 @@ ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) EXECENV_LDLIBS += -lgcc_s endif +EXECENV_LDLIBS-$(CONFIG_RTE_USE_LIBBSD) += -lbsd + # force applications to link with gcc/icc instead of using ld LINK_USING_CC := 1 @@ -32,4 +34,8 @@ EXECENV_LDFLAGS += -export-dynamic # Add library to the group to resolve symbols EXECENV_LDLIBS += -ldl +# EXECENV_LDLIBS-y applies to lib.so and app linking +# while EXECENV_LDLIBS applies only to app linking. +EXECENV_LDLIBS += $(EXECENV_LDLIBS-y) + export EXECENV_CFLAGS EXECENV_LDFLAGS EXECENV_ASFLAGS EXECENV_LDLIBS diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 8a4f0f4e5..d0ab942d5 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.mk @@ -309,9 +309,6 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_EAL) += -lrt ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP)$(CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES),yy) _LDLIBS-$(CONFIG_RTE_LIBRTE_EAL) += -lnuma endif -ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP)$(CONFIG_RTE_USE_LIBBSD),yy) -_LDLIBS-$(CONFIG_RTE_LIBRTE_EAL) += -lbsd -endif _LDLIBS-$(CONFIG_RTE_LIBRTE_SCHED) += -lm _LDLIBS-$(CONFIG_RTE_LIBRTE_SCHED) += -lrt _LDLIBS-$(CONFIG_RTE_LIBRTE_MEMBER) += -lm diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index c696a2174..4df8849a0 100644 --- a/mk/rte.lib.mk +++ b/mk/rte.lib.mk @@ -35,6 +35,8 @@ PREINSTALL = $(SYMLINK-FILES-y) _INSTALL = $(INSTALL-FILES-y) $(RTE_OUTPUT)/lib/$(LIB) _CLEAN = doclean +LDLIBS += $(EXECENV_LDLIBS-y) + .PHONY: all all: install From patchwork Tue Feb 12 23:05:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 50277 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5FBC91B11F; Wed, 13 Feb 2019 00:05:20 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id C229E1B0FF; Wed, 13 Feb 2019 00:05:18 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7099022164; Tue, 12 Feb 2019 18:05:18 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 12 Feb 2019 18:05:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=YXxcofGpsc 0h+V8bn2RdQ1rHVUYzYNvLXhC7zQM34Q8=; b=GiSDfQnq7Rag8MdSudJwMu2EpS s/HBErOSV4pZaoQFoQaz+RX7N8qUy1e/lBIj8wp21F3zf01dPHV1xuMB+j8i54Ls PI9SkW5nPsoPAApSF4KRp032SC2C051EwQto+nBhgZ3Gwdl56eMDpExudzpYW9ht 0rYDuKCHa1PuE4yKA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=YXxcofGpsc0h+V8bn2RdQ1rHVUYzYNvLXhC7zQM34Q8=; b=v6k+8q44 qMYl2Bp1zlCRNZArlGef2Ju0igpNcNwXSSWoFZNh3kpSTt46ZIDk/OhMhAyxPv0r bsYGLNpB2fPjStnFZmX54XY9BbtTJXB1+gV9gFwFtKnpGkTGq9k5t5PfUo5i3jKC UcmxsSSsWEugaDT3CkfuLpYGD+udDITybdfHzp8QubYRE1FI5EiVFAx/5woERI13 FYZ9P9GPtuHBJRJEWGWyKSXTx87Ypfly0d+esW1F+x0wFAXqlolKNaZFPz+7Qqm/ E2t1ZZqscM8Xppe/YHq3IwFKsNQRlcPiiepmbi1G8BjF7kccIIzXv3SFTeTYo1CA aFbSiJVXvBNnRA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtvddgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecumhhishhsihhnghcuvffquchfihgvlhguucdlfedtmdenucfjughrpefhvffuff fkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhho nhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrd dvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhj rghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4F997E4412; Tue, 12 Feb 2019 18:05:17 -0500 (EST) From: Thomas Monjalon To: Cc: dev@dpdk.org, konstantin.ananyev@intel.com, stable@dpdk.org Date: Wed, 13 Feb 2019 00:05:05 +0100 Message-Id: <20190212230507.11793-3-thomas@monjalon.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190212230507.11793-1-thomas@monjalon.net> References: <20190212230507.11793-1-thomas@monjalon.net> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 2/4] devtools: add libelf dependency to build test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The option CONFIG_RTE_LIBRTE_BPF_ELF was never enabled with test-build.sh. It is fixed with the environment variable DPDK_DEP_ELF. Fixes: 5dba93ae5f2d ("bpf: add ability to load eBPF program from ELF object file") Cc: konstantin.ananyev@intel.com Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon --- devtools/test-build.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/devtools/test-build.sh b/devtools/test-build.sh index 42f4ad003..ace52a776 100755 --- a/devtools/test-build.sh +++ b/devtools/test-build.sh @@ -9,6 +9,7 @@ default_path=$PATH # - DPDK_BUILD_TEST_CONFIGS (defconfig1+option1+option2 defconfig2) # - DPDK_DEP_ARCHIVE # - DPDK_DEP_CFLAGS +# - DPDK_DEP_ELF (y/[n]) # - DPDK_DEP_ISAL (y/[n]) # - DPDK_DEP_JSON (y/[n]) # - DPDK_DEP_LDFLAGS @@ -96,6 +97,7 @@ reset_env () unset CROSS unset DPDK_DEP_ARCHIVE unset DPDK_DEP_CFLAGS + unset DPDK_DEP_ELF unset DPDK_DEP_ISAL unset DPDK_DEP_JSON unset DPDK_DEP_LDFLAGS @@ -186,6 +188,8 @@ config () # sed -ri 's,(MVPP2_PMD=)n,\1y,' $1/.config test -z "$LIBMUSDK_PATH" || \ sed -ri 's,(MVNETA_PMD=)n,\1y,' $1/.config + test "$DPDK_DEP_ELF" != y || \ + sed -ri 's,(BPF_ELF=)n,\1y,' $1/.config test -z "$DPDK_DEP_JSON" || \ sed -ri 's,(TELEMETRY=)n,\1y,' $1/.config build_config_hook $1 $2 $3 From patchwork Tue Feb 12 23:05:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 50278 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DB6A91B138; Wed, 13 Feb 2019 00:05:22 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 6E6A81B123; Wed, 13 Feb 2019 00:05:21 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 11F3A22233; Tue, 12 Feb 2019 18:05:21 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 12 Feb 2019 18:05:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=tEhpHkvrsh lBu+Wwtw0RjNeqhh4/UsGaffBeVtgRdB4=; b=fAQyMGjh3FwdiHpevCsD8UWBTU W+xJjxZNTL+1omjrM7Ktx9tU58crvond+QvZJbwS4e7FyxsUNY3gNedPxbdoA69Q uo5OEc+aA0fmk67FPwvqCasIMsufeZ6b/AVbMyZ2CZjmz+0EveXP6dVDk7vALAwQ hOItIONul2TK7h/ls= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=tEhpHkvrshlBu+Wwtw0RjNeqhh4/UsGaffBeVtgRdB4=; b=61aMtp3H I14iRsSVY2zHdduT077Ugh/MFoME7x12q3BQ1TCNGZoInQDhvEsf3Rc7heukzGSo 9lzktwk5QImivle5HqsomV9phHKMaj8zNUOAjN4cMC78p1aWIVyUydce8r6FUiJW vC5x0lDQlaPDyc48UVrEyAWzZEw852MA+pYMeXUcQcTDf9tqBkOPc5pfAaP091GN dHIOli5hRW3+ooef+MDnFLgaH8vtOsfu6JE5x23cTI2pXsEcA3HpkSA1WflAdVgy FNB69AjABUiPs97yy8H3Ns3EV+Ae7+6OaNITrkqqxdIDgiMR0fzWgmDwm0PrgaF1 wG+MMwYeLgKgrg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtvddgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecumhhishhsihhnghcuvffquchfihgvlhguucdlfedtmdenucfjughrpefhvffuff fkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhho nhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrd dvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhj rghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgepud X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8FCD4E4652; Tue, 12 Feb 2019 18:05:19 -0500 (EST) From: Thomas Monjalon To: Cc: dev@dpdk.org, ashish.gupta@caviumnetworks.com, stable@dpdk.org Date: Wed, 13 Feb 2019 00:05:06 +0100 Message-Id: <20190212230507.11793-4-thomas@monjalon.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190212230507.11793-1-thomas@monjalon.net> References: <20190212230507.11793-1-thomas@monjalon.net> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 3/4] devtools: test build of zlib PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The PMD zlib was not enabled in devtools/test-build.sh. It is fixed by using the environment variable DPDK_DEP_ZLIB. Fixes: 0c4e4c16b004 ("compress/zlib: introduce zlib PMD") Cc: ashish.gupta@caviumnetworks.com Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon --- devtools/test-build.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/devtools/test-build.sh b/devtools/test-build.sh index ace52a776..0511ae6d0 100755 --- a/devtools/test-build.sh +++ b/devtools/test-build.sh @@ -158,6 +158,8 @@ config () # test "$DPDK_DEP_ZLIB" != y || \ sed -ri 's,(BNX2X_PMD=)n,\1y,' $1/.config test "$DPDK_DEP_ZLIB" != y || \ + sed -ri 's,(PMD_ZLIB=)n,\1y,' $1/.config + test "$DPDK_DEP_ZLIB" != y || \ sed -ri 's,(COMPRESSDEV_TEST=)n,\1y,' $1/.config test "$DPDK_DEP_PCAP" != y || \ sed -ri 's,(PCAP=)n,\1y,' $1/.config From patchwork Tue Feb 12 23:05:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 50279 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 057451B118; Wed, 13 Feb 2019 00:05:26 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E2E1F1B113; Wed, 13 Feb 2019 00:05:23 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 90FEB221B0; Tue, 12 Feb 2019 18:05:23 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 12 Feb 2019 18:05:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=zcmZI/fa5p Fsff5YaBNDP1ePPBoXl7kVgGC4pmcb2vI=; b=YkoiHeN5luM0yywR2NsGUttvmY KeEr+qTIHExFTeJMJWGk2YLmghPnfxssOHfx9C+I2lJ0wYTFYLVKIj//3sa2kIh/ +FPccJX8Jen4SVr/+nFGpCW/HKNuYJJMQrmQ0mPmpd9vIwoLW4tQdoXlh3SiWLZ4 kC3loSQFbGBUaQxik= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=zcmZI/fa5pFsff5YaBNDP1ePPBoXl7kVgGC4pmcb2vI=; b=YwTk08Al ngZRQvBmofKZcoXMd2ACyKbw9Ie5j9ravJWm9TSdh2FlK01SUQqj9Z1HPtWqrsDM 3/pqb2duzJ27INLajhGpxVNJLPt6QSyZpLcX71ZuZGkZhGYhpPDPrXpA+Y/UiiZm 85n+nhvvJzKPUg/GgoDXsHVik5XuHJY8BQe6V/mM5nIOSyWXQj/dMiY7RhCEJoJW 1WinY1SiRmX6J1UtnO98djeO0e0nPCentlg2aLZc3f+c76HqBxtrDOAkJf7qd9hR fXMesfUkY+JXET8GCrkJWxWlLMJesB/HKaHWqaNFEF5JX88qSiR7TC10RXVtoGE3 H/gmD89DQdKkTA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtvddgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecumhhishhsihhnghcuvffquchfihgvlhguucdlfedtmdenucfjughrpefhvffuff fkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhho nhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrd dvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhj rghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgepud X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A6A49E462B; Tue, 12 Feb 2019 18:05:22 -0500 (EST) From: Thomas Monjalon To: Cc: dev@dpdk.org, lee.daly@intel.com, fiona.trahe@intel.com, stable@dpdk.org Date: Wed, 13 Feb 2019 00:05:07 +0100 Message-Id: <20190212230507.11793-5-thomas@monjalon.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190212230507.11793-1-thomas@monjalon.net> References: <20190212230507.11793-1-thomas@monjalon.net> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 4/4] devtools: fix test of some build options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" CONFIG_RTE_LIBRTE_PMD_ISAL was not tested because of a typo. CONFIG_RTE_LIBRTE_PMD_QAT_SYM was not tested since it has been introduced and made CONFIG_RTE_LIBRTE_PMD_QAT enabled by default. While at it, DPDK_DEP_JSON is now checked for "y", as other DPDK_DEP_* variables, instead of non-empty. Fixes: 3c32e89f68e1 ("compress/isal: add skeleton ISA-L compression PMD") Cc: lee.daly@intel.com Fixes: 7a34c2155716 ("compress/qat: add empty driver") Cc: fiona.trahe@intel.com Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon Acked-by: Fiona Trahe --- devtools/test-build.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/devtools/test-build.sh b/devtools/test-build.sh index 0511ae6d0..d37b121ca 100755 --- a/devtools/test-build.sh +++ b/devtools/test-build.sh @@ -150,7 +150,7 @@ config () # test "$DPDK_DEP_ARCHIVE" != y || \ sed -ri 's,(RESOURCE_TAR=)n,\1y,' $1/.config test "$DPDK_DEP_ISAL" != y || \ - sed -ri 's,(ISAL_PMD=)n,\1y,' $1/.config + sed -ri 's,(PMD_ISAL=)n,\1y,' $1/.config test "$DPDK_DEP_MLX" != y || \ sed -ri 's,(MLX._PMD=)n,\1y,' $1/.config test "$DPDK_DEP_SZE" != y || \ @@ -180,7 +180,7 @@ config () # test "$DPDK_DEP_SSL" != y || \ sed -ri 's,(PMD_OPENSSL=)n,\1y,' $1/.config test "$DPDK_DEP_SSL" != y || \ - sed -ri 's,(PMD_QAT=)n,\1y,' $1/.config + sed -ri 's,(QAT_SYM=)n,\1y,' $1/.config test -z "$FLEXRAN_SDK" || \ sed -ri 's,(BBDEV_TURBO_SW=)n,\1y,' $1/.config sed -ri 's,(SCHED_.*=)n,\1y,' $1/.config @@ -192,7 +192,7 @@ config () # sed -ri 's,(MVNETA_PMD=)n,\1y,' $1/.config test "$DPDK_DEP_ELF" != y || \ sed -ri 's,(BPF_ELF=)n,\1y,' $1/.config - test -z "$DPDK_DEP_JSON" || \ + test "$DPDK_DEP_JSON" != y || \ sed -ri 's,(TELEMETRY=)n,\1y,' $1/.config build_config_hook $1 $2 $3