From patchwork Tue May 28 19:43:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 53784 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E7FE11B948; Tue, 28 May 2019 21:43:25 +0200 (CEST) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 082981B05 for ; Tue, 28 May 2019 21:43:24 +0200 (CEST) Received: by mail-pf1-f193.google.com with SMTP id b76so12116011pfb.5 for ; Tue, 28 May 2019 12:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FnvbgjJp8T5i4oEm1ZYXige2fA5DR/hN7Wv1TfCxUkA=; b=WDq/odDh1ANcu5en4wqmpAGjMdehy+hliIg5+oBOAAa9f1oW/Eqq389vE7u87JbVT2 gI1zGPOE1EykCRzV7RWNQzQNi3mIpi6tIXVuEXZCXbnrO1RaFaHKD2ygP6tUCAtXzReM G0qYhIBq4mmMgbc+un0T/hufQ6KP3DYrkwkVlEJjTiPNENuehjGF9tBsEJrZwqMtG3c4 WfjKo+AnqLNohPoNqWQbFlXS6l9yUgwDVeGkIrGDMV5pjeZXST3Dms7D+oZqu+fqr1Zt TRodwHgHh61PPTW7mbTS46kqYkXpf4jQwCS1PZqWRuEp768vSCL8hIH7gNpKrCN3XoAg Z64A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FnvbgjJp8T5i4oEm1ZYXige2fA5DR/hN7Wv1TfCxUkA=; b=NMKW+cuR44awfYqnVtxcqUAYEuUV5qZ4+s13C/mqWzo19gzduh03qu5NzsZbVxHGLP o+sDW1miZVFdeIzPAnxOY9HhoZHw4JmSbHEzX+0nxU7GlnLbJqYHOmqZr3kUsvRpWcDm VdhNjxV8xkDmfcYi3IESACpfKR+rh8QtAkDba2c80Nbb8qYVcjexDh5hrAeUWgW9hL/F +hOlLYXzjW3WH6Pwqe20O0FznzBjDTYtquyD2KhMQhQ8HcsW58I7wH4GmACU2h/HMC6G S1wvhC4Jn5J8WAbXYJBk6Is4fO6dircZTZfFfOu4QTVWuz28VKjLzNlqcCsdlMBldLQ7 xvnw== X-Gm-Message-State: APjAAAUa3fKUrXufF07ZPVotR2Yi0K9yCsLgNRsQN0KuqJiPogOlSvN3 RPla37wn54Zfdcp+myLm+M7v2Q== X-Google-Smtp-Source: APXvYqwLD7P3lsOg2ojxUv4q7r3KywFDE7ZaUmO5dOjg6cbGjv9QxCKTcyX0eeoIV+g7DKNIglEc5A== X-Received: by 2002:a63:2d41:: with SMTP id t62mr135841836pgt.113.1559072603188; Tue, 28 May 2019 12:43:23 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id q142sm20583327pfc.27.2019.05.28.12.43.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 May 2019 12:43:21 -0700 (PDT) From: Stephen Hemminger To: beilei.xing@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org, Stephen Hemminger Date: Tue, 28 May 2019 12:43:18 -0700 Message-Id: <20190528194318.11641-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] net/i40e: remove queue_stats_mapping_set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This driver was inserting its own stub for queue_stats_mapping which did nothing but cause this device to return a different errno than every other device driver. All devices that don't implement queue stats mapping should return the same error. Maybe the plan originally was to implement something, if that ever happens, just put in the right code. Fixes: 4861cde46116 ("i40e: new poll mode driver") Signed-off-by: Stephen Hemminger Acked-by: Maxime Coquelin --- drivers/net/i40e/i40e_ethdev.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index cab440f5a8f6..5bbcbb4fc608 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -237,10 +237,6 @@ static int i40e_dev_xstats_get_names(struct rte_eth_dev *dev, struct rte_eth_xstat_name *xstats_names, unsigned limit); static void i40e_dev_stats_reset(struct rte_eth_dev *dev); -static int i40e_dev_queue_stats_mapping_set(struct rte_eth_dev *dev, - uint16_t queue_id, - uint8_t stat_idx, - uint8_t is_rx); static int i40e_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size); static void i40e_dev_info_get(struct rte_eth_dev *dev, @@ -456,7 +452,6 @@ static const struct eth_dev_ops i40e_eth_dev_ops = { .xstats_get_names = i40e_dev_xstats_get_names, .stats_reset = i40e_dev_stats_reset, .xstats_reset = i40e_dev_stats_reset, - .queue_stats_mapping_set = i40e_dev_queue_stats_mapping_set, .fw_version_get = i40e_fw_version_get, .dev_infos_get = i40e_dev_info_get, .dev_supported_ptypes_get = i40e_dev_supported_ptypes_get, @@ -3431,17 +3426,6 @@ i40e_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats, return count; } -static int -i40e_dev_queue_stats_mapping_set(__rte_unused struct rte_eth_dev *dev, - __rte_unused uint16_t queue_id, - __rte_unused uint8_t stat_idx, - __rte_unused uint8_t is_rx) -{ - PMD_INIT_FUNC_TRACE(); - - return -ENOSYS; -} - static int i40e_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size) {