From patchwork Tue Jun 25 10:31:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wang, Haiyue" X-Patchwork-Id: 55299 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 20B2A1BB74; Tue, 25 Jun 2019 12:38:27 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 767ED3798; Tue, 25 Jun 2019 12:38:25 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jun 2019 03:38:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,415,1557212400"; d="scan'208";a="169742881" Received: from npg-dpdk-haiyue-2.sh.intel.com ([10.67.119.117]) by FMSMGA003.fm.intel.com with ESMTP; 25 Jun 2019 03:38:23 -0700 From: Haiyue Wang To: dev@dpdk.org Cc: Haiyue Wang , stable@dpdk.org Date: Tue, 25 Jun 2019 18:31:45 +0800 Message-Id: <1561458705-29639-1-git-send-email-haiyue.wang@intel.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH v1] app/testpmd: fix setting RSS queue rule failure on fedora30 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Declare a local variable 'arg' to hold the pointer to ARGS_ENTRY_ARB, otherwise, the pop 'arg' in 'parse_int' holds wrong data like 'arg-> offset = 5912737, arg->size = 0', this caused the parse failure. If calling like 'push_args(ctx, ARGS_ENTRY_ARB..)', the below code for assgining 'offset & size' will be missed for some gcc optimization. 0000000000002950 : 29c5: c5 f9 ef c0 vpxor %xmm0,%xmm0,%xmm0 29c9: 43 8d 44 24 68 lea 0x68(%r12,%r12,1),%eax 29ce: 48 c7 44 24 20 00 00 movq $0x0,0x20(%rsp) 29d5: 00 00 29d7: c5 f8 29 44 24 10 vmovaps %xmm0,0x10(%rsp) 29dd: 89 44 24 18 mov %eax,0x18(%rsp) 29e1: 48 63 83 0c 01 00 00 movslq 0x10c(%rbx),%rax 29e8: c7 44 24 1c 02 00 00 movl $0x2,0x1c(%rsp) 29ef: 00 29f0: c5 f8 29 04 24 vmovaps %xmm0,(%rsp) The above assembly code is from this modification with: gcc version 9.1.1 20190503 (Red Hat 9.1.1-1) (GCC) Fedora release 30 (Thirty) 5.1.11-300.fc30.x86_64 Fixes: d0ad8648b1c5 ("app/testpmd: fix RSS flow action configuration") Cc: stable@dpdk.org Signed-off-by: Haiyue Wang --- app/test-pmd/cmdline_flow.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 201bd9d..4a083d4 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -3378,6 +3378,7 @@ parse_vc_action_rss_queue(struct context *ctx, const struct token *token, { static const enum index next[] = NEXT_ENTRY(ACTION_RSS_QUEUE); struct action_rss_data *action_rss_data; + const struct arg *arg; int ret; int i; @@ -3393,10 +3394,10 @@ parse_vc_action_rss_queue(struct context *ctx, const struct token *token, } if (i >= ACTION_RSS_QUEUE_NUM) return -1; - if (push_args(ctx, - ARGS_ENTRY_ARB(offsetof(struct action_rss_data, queue) + - i * sizeof(action_rss_data->queue[i]), - sizeof(action_rss_data->queue[i])))) + arg = ARGS_ENTRY_ARB(offsetof(struct action_rss_data, queue) + + i * sizeof(action_rss_data->queue[i]), + sizeof(action_rss_data->queue[i])); + if (push_args(ctx, arg)) return -1; ret = parse_int(ctx, token, str, len, NULL, 0); if (ret < 0) {