From patchwork Thu Jul 4 10:03:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 56075 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 984331BDE5; Thu, 4 Jul 2019 12:03:58 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 9EBB11B9A0; Thu, 4 Jul 2019 12:03:56 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 896C940006A; Thu, 4 Jul 2019 10:03:55 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 4 Jul 2019 03:03:52 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Thu, 4 Jul 2019 03:03:52 -0700 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id x64A3ph8021322; Thu, 4 Jul 2019 11:03:51 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 0C7981613C2; Thu, 4 Jul 2019 11:03:51 +0100 (BST) From: Andrew Rybchenko To: Jerin Jacob , Nikhil Rao , "Erik Gabriel Carrillo" CC: , Dilshod Urazov , Date: Thu, 4 Jul 2019 11:03:30 +0100 Message-ID: <1562234612-631-2-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1562234612-631-1-git-send-email-arybchenko@solarflare.com> References: <1562234612-631-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24738.005 X-TM-AS-Result: No-11.852300-4.000000-10 X-TMASE-MatchedRID: BkMpb3gCdH6KQsBMcfAIqeuhtmmz4+rYKDskCYe7jihjyv+d0Z0OxYVH 2zcrc5+5jCil0wQw2lLiAp6vkYgGXbhYaHW9RIv/Pja3w1ExF8Q/pOSL72dTfwdkFovAReUoLPJ tWpbJjY3LLCKyF09LW3r3QpbFFsBrtLBZFT+Jy66bbGl0ztMpl3vEgoSBmr8BUjFJwpdmcrTj3a QyxbuPYmINlOGYJobx0WfbEzp7A7uwOCWVB42yGtYpUOCigMK3wJjn8yqLU6Ko8aocg8ZmIx3+O LpZQttdYkf8dVZxle+9moU6TdG2HSjehnVy6ln2joyKzEmtrEdJaD67iKvY08uSXx71bvSLRh00 GGPaDz9abtDUTUShUTQ6mr/whkMreIWtaoT+rz5TLFbi+a8u3awmLjb7urxIC/U4++8MvOxv2TR SfxSVxuLzNWBegCW2wgn7iDBesS0gBwKKRHe+r+U77lit4zi38iBs26LS5H6Hdu5AlF853VnYi/ Nf+ZkigqTzsdnpBF4= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--11.852300-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24738.005 X-MDID: 1562234636-18AvSe9yRFkm Subject: [dpdk-dev] [PATCH 1/3] eventdev: fix to set positive rte_errno X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Dilshod Urazov Fixes: c9bf83947e2e ("eventdev: add eth Tx adapter APIs") Fixes: 47d05b292820 ("eventdev: add timer adapter common code") Fixes: 6750b21bd6af ("eventdev: add default software timer adapter") Fixes: c75f7897ea35 ("eventdev: set error code in port link/unlink functions") Fixes: 7d1acc9dde93 ("eventdev: introduce helper function for enqueue burst") Fixes: 406aed4e0dd9 ("eventdev: add errno-style return values") Fixes: c64e1b7b20d2 ("eventdev: add new software event timer adapter") Cc: stable@dpdk.org Signed-off-by: Dilshod Urazov Signed-off-by: Andrew Rybchenko Reviewed-by: David Marchand --- lib/librte_eventdev/rte_event_eth_tx_adapter.h | 8 ++++---- lib/librte_eventdev/rte_event_timer_adapter.c | 18 +++++++++--------- lib/librte_eventdev/rte_eventdev.c | 16 ++++++++-------- lib/librte_eventdev/rte_eventdev.h | 26 +++++++++++++------------- 4 files changed, 34 insertions(+), 34 deletions(-) diff --git a/lib/librte_eventdev/rte_event_eth_tx_adapter.h b/lib/librte_eventdev/rte_event_eth_tx_adapter.h index 9bed12b..c848261 100644 --- a/lib/librte_eventdev/rte_event_eth_tx_adapter.h +++ b/lib/librte_eventdev/rte_event_eth_tx_adapter.h @@ -332,10 +332,10 @@ struct rte_event_eth_tx_adapter_stats { * *rte_event*. If the return value is less than *nb_events*, the remaining * events at the end of ev[] are not consumed and the caller has to take care * of them, and rte_errno is set accordingly. Possible errno values include: - * - -EINVAL The port ID is invalid, device ID is invalid, an event's queue + * - EINVAL The port ID is invalid, device ID is invalid, an event's queue * ID is invalid, or an event's sched type doesn't match the * capabilities of the destination queue. - * - -ENOSPC The event port was backpressured and unable to enqueue + * - ENOSPC The event port was backpressured and unable to enqueue * one or more events. This error code is only applicable to * closed systems. */ @@ -350,12 +350,12 @@ struct rte_event_eth_tx_adapter_stats { #ifdef RTE_LIBRTE_EVENTDEV_DEBUG if (dev_id >= RTE_EVENT_MAX_DEVS || !rte_eventdevs[dev_id].attached) { - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } if (port_id >= dev->data->nb_ports) { - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } #endif diff --git a/lib/librte_eventdev/rte_event_timer_adapter.c b/lib/librte_eventdev/rte_event_timer_adapter.c index 459bc47..5ce399e 100644 --- a/lib/librte_eventdev/rte_event_timer_adapter.c +++ b/lib/librte_eventdev/rte_event_timer_adapter.c @@ -192,17 +192,17 @@ struct rte_event_timer_adapter * &adapter->data->caps, &adapter->ops); if (ret < 0) { - rte_errno = ret; + rte_errno = -ret; goto free_memzone; } if (!(adapter->data->caps & RTE_EVENT_TIMER_ADAPTER_CAP_INTERNAL_PORT)) { - FUNC_PTR_OR_NULL_RET_WITH_ERRNO(conf_cb, -EINVAL); + FUNC_PTR_OR_NULL_RET_WITH_ERRNO(conf_cb, EINVAL); ret = conf_cb(adapter->data->id, adapter->data->event_dev_id, &adapter->data->event_port_id, conf_arg); if (ret < 0) { - rte_errno = ret; + rte_errno = -ret; goto free_memzone; } } @@ -214,10 +214,10 @@ struct rte_event_timer_adapter * adapter->ops = &swtim_ops; /* Allow driver to do some setup */ - FUNC_PTR_OR_NULL_RET_WITH_ERRNO(adapter->ops->init, -ENOTSUP); + FUNC_PTR_OR_NULL_RET_WITH_ERRNO(adapter->ops->init, ENOTSUP); ret = adapter->ops->init(adapter); if (ret < 0) { - rte_errno = ret; + rte_errno = -ret; goto free_memzone; } @@ -509,11 +509,11 @@ struct event_buffer { *nb_events_flushed = rte_event_enqueue_burst(dev_id, port_id, &events[tail_idx], n); if (*nb_events_flushed != n) { - if (rte_errno == -EINVAL) { + if (rte_errno == EINVAL) { EVTIM_LOG_ERR("failed to enqueue invalid event - " "dropping it"); (*nb_events_inv)++; - } else if (rte_errno == -ENOSPC) + } else if (rte_errno == ENOSPC) rte_pause(); } @@ -832,7 +832,7 @@ struct swtim { if (ret < 0) { if (ret != -EALREADY) { EVTIM_LOG_ERR("failed to initialize timer subsystem"); - rte_errno = ret; + rte_errno = -ret; goto free_mempool; } } @@ -840,7 +840,7 @@ struct swtim { ret = rte_timer_data_alloc(&sw->timer_data_id); if (ret < 0) { EVTIM_LOG_ERR("failed to allocate timer data instance"); - rte_errno = ret; + rte_errno = -ret; goto free_mempool; } diff --git a/lib/librte_eventdev/rte_eventdev.c b/lib/librte_eventdev/rte_eventdev.c index cc3199f..f44c869 100644 --- a/lib/librte_eventdev/rte_eventdev.c +++ b/lib/librte_eventdev/rte_eventdev.c @@ -889,18 +889,18 @@ uint16_t *links_map; int i, diag; - RTE_EVENTDEV_VALID_DEVID_OR_ERRNO_RET(dev_id, -EINVAL, 0); + RTE_EVENTDEV_VALID_DEVID_OR_ERRNO_RET(dev_id, EINVAL, 0); dev = &rte_eventdevs[dev_id]; if (*dev->dev_ops->port_link == NULL) { RTE_EDEV_LOG_ERR("Function not supported\n"); - rte_errno = -ENOTSUP; + rte_errno = ENOTSUP; return 0; } if (!is_valid_port(dev, port_id)) { RTE_EDEV_LOG_ERR("Invalid port_id=%" PRIu8, port_id); - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } @@ -921,7 +921,7 @@ for (i = 0; i < nb_links; i++) if (queues[i] >= dev->data->nb_queues) { - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } @@ -948,18 +948,18 @@ int i, diag, j; uint16_t *links_map; - RTE_EVENTDEV_VALID_DEVID_OR_ERRNO_RET(dev_id, -EINVAL, 0); + RTE_EVENTDEV_VALID_DEVID_OR_ERRNO_RET(dev_id, EINVAL, 0); dev = &rte_eventdevs[dev_id]; if (*dev->dev_ops->port_unlink == NULL) { RTE_EDEV_LOG_ERR("Function not supported"); - rte_errno = -ENOTSUP; + rte_errno = ENOTSUP; return 0; } if (!is_valid_port(dev, port_id)) { RTE_EDEV_LOG_ERR("Invalid port_id=%" PRIu8, port_id); - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } @@ -988,7 +988,7 @@ nb_unlinks = j; for (i = 0; i < nb_unlinks; i++) if (queues[i] >= dev->data->nb_queues) { - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h index 927f43c..5044a13 100644 --- a/lib/librte_eventdev/rte_eventdev.h +++ b/lib/librte_eventdev/rte_eventdev.h @@ -1318,12 +1318,12 @@ struct rte_eventdev { #ifdef RTE_LIBRTE_EVENTDEV_DEBUG if (dev_id >= RTE_EVENT_MAX_DEVS || !rte_eventdevs[dev_id].attached) { - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } if (port_id >= dev->data->nb_ports) { - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } #endif @@ -1372,10 +1372,10 @@ struct rte_eventdev { * *rte_event*. If the return value is less than *nb_events*, the remaining * events at the end of ev[] are not consumed and the caller has to take care * of them, and rte_errno is set accordingly. Possible errno values include: - * - -EINVAL The port ID is invalid, device ID is invalid, an event's queue + * - EINVAL The port ID is invalid, device ID is invalid, an event's queue * ID is invalid, or an event's sched type doesn't match the * capabilities of the destination queue. - * - -ENOSPC The event port was backpressured and unable to enqueue + * - ENOSPC The event port was backpressured and unable to enqueue * one or more events. This error code is only applicable to * closed systems. * @see rte_event_port_attr_get(), RTE_EVENT_PORT_ATTR_ENQ_DEPTH @@ -1422,10 +1422,10 @@ struct rte_eventdev { * *rte_event*. If the return value is less than *nb_events*, the remaining * events at the end of ev[] are not consumed and the caller has to take care * of them, and rte_errno is set accordingly. Possible errno values include: - * - -EINVAL The port ID is invalid, device ID is invalid, an event's queue + * - EINVAL The port ID is invalid, device ID is invalid, an event's queue * ID is invalid, or an event's sched type doesn't match the * capabilities of the destination queue. - * - -ENOSPC The event port was backpressured and unable to enqueue + * - ENOSPC The event port was backpressured and unable to enqueue * one or more events. This error code is only applicable to * closed systems. * @see rte_event_port_attr_get(), RTE_EVENT_PORT_ATTR_ENQ_DEPTH @@ -1473,10 +1473,10 @@ struct rte_eventdev { * *rte_event*. If the return value is less than *nb_events*, the remaining * events at the end of ev[] are not consumed and the caller has to take care * of them, and rte_errno is set accordingly. Possible errno values include: - * - -EINVAL The port ID is invalid, device ID is invalid, an event's queue + * - EINVAL The port ID is invalid, device ID is invalid, an event's queue * ID is invalid, or an event's sched type doesn't match the * capabilities of the destination queue. - * - -ENOSPC The event port was backpressured and unable to enqueue + * - ENOSPC The event port was backpressured and unable to enqueue * one or more events. This error code is only applicable to * closed systems. * @see rte_event_port_attr_get(), RTE_EVENT_PORT_ATTR_ENQ_DEPTH @@ -1595,12 +1595,12 @@ struct rte_eventdev { #ifdef RTE_LIBRTE_EVENTDEV_DEBUG if (dev_id >= RTE_EVENT_MAX_DEVS || !rte_eventdevs[dev_id].attached) { - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } if (port_id >= dev->data->nb_ports) { - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } #endif @@ -1673,9 +1673,9 @@ struct rte_eventdev { * of link[] are not established, and the caller has to take care of them. * If return value is less than *nb_links* then implementation shall update the * rte_errno accordingly, Possible rte_errno values are - * (-EDQUOT) Quota exceeded(Application tried to link the queue configured with + * (EDQUOT) Quota exceeded(Application tried to link the queue configured with * RTE_EVENT_QUEUE_CFG_SINGLE_LINK to more than one event ports) - * (-EINVAL) Invalid parameter + * (EINVAL) Invalid parameter * */ int @@ -1720,7 +1720,7 @@ struct rte_eventdev { * end of queues[] are not unlinked, and the caller has to take care of them. * If return value is less than *nb_unlinks* then implementation shall update * the rte_errno accordingly, Possible rte_errno values are - * (-EINVAL) Invalid parameter + * (EINVAL) Invalid parameter */ int rte_event_port_unlink(uint8_t dev_id, uint8_t port_id, From patchwork Thu Jul 4 10:03:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 56076 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 771241BDED; Thu, 4 Jul 2019 12:04:04 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 7A2A01B9A0; Thu, 4 Jul 2019 12:04:03 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 7898F140061; Thu, 4 Jul 2019 10:04:02 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 4 Jul 2019 03:03:59 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Thu, 4 Jul 2019 03:03:59 -0700 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id x64A3wIw021407; Thu, 4 Jul 2019 11:03:58 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 3292B1613C2; Thu, 4 Jul 2019 11:03:58 +0100 (BST) From: Andrew Rybchenko To: Jerin Jacob , Harry van Haaren CC: , Dilshod Urazov , Date: Thu, 4 Jul 2019 11:03:31 +0100 Message-ID: <1562234612-631-3-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1562234612-631-1-git-send-email-arybchenko@solarflare.com> References: <1562234612-631-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24738.005 X-TM-AS-Result: No-0.568000-4.000000-10 X-TMASE-MatchedRID: MS5rc/rqO2ymnG2tP+vqUeKggdmU+sgMAKbvziCwm7hjLp8Cm8vwF0Ac 6DyoS2rIX5ZfmW1Ym4XVnq+mUKhlX9z3VV8c3pGI6GyDR2ZB+cY0I3BVHYDiV21Kmd3GH68Oo8W MkQWv6iXBcIE78YqRWo6HM5rqDwqtI067fxPFupa4SyitP13KbBdlCJV+w3xvp1Tn2E7fsdxcjA uhRtRvh3F9F0RpMg4OpItrm3GGcvMm0X6CDHZlTCTgUe1VtM40hdeYev6ImzWyrFieOBrhBjzcW rt/fwYrRcB2ZpPnVjJQ5+rfVDglH5RMZUCEHkRt X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10-0.568000-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24738.005 X-MDID: 1562234643-EoxLm5QAuIea Subject: [dpdk-dev] [PATCH 2/3] event/sw: fix to set positive rte_errno X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Dilshod Urazov Fixes: 371a688fc159 ("event/sw: support linking queues to ports") Cc: stable@dpdk.org Signed-off-by: Dilshod Urazov Signed-off-by: Andrew Rybchenko Acked-by: Harry van Haaren --- drivers/event/sw/sw_evdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c index 1175d6c..fb8e8be 100644 --- a/drivers/event/sw/sw_evdev.c +++ b/drivers/event/sw/sw_evdev.c @@ -38,12 +38,12 @@ /* check for qid map overflow */ if (q->cq_num_mapped_cqs >= RTE_DIM(q->cq_map)) { - rte_errno = -EDQUOT; + rte_errno = EDQUOT; break; } if (p->is_directed && p->num_qids_mapped > 0) { - rte_errno = -EDQUOT; + rte_errno = EDQUOT; break; } @@ -59,12 +59,12 @@ if (q->type == SW_SCHED_TYPE_DIRECT) { /* check directed qids only map to one port */ if (p->num_qids_mapped > 0) { - rte_errno = -EDQUOT; + rte_errno = EDQUOT; break; } /* check port only takes a directed flow */ if (num > 1) { - rte_errno = -EDQUOT; + rte_errno = EDQUOT; break; } From patchwork Thu Jul 4 10:03:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 56077 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A47C71BDE4; Thu, 4 Jul 2019 12:04:07 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 9F17D1BDF3; Thu, 4 Jul 2019 12:04:05 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id BBAB99C0066; Thu, 4 Jul 2019 10:04:04 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 4 Jul 2019 03:04:02 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Thu, 4 Jul 2019 03:04:01 -0700 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id x64A40cX021421; Thu, 4 Jul 2019 11:04:00 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 959411613C2; Thu, 4 Jul 2019 11:04:00 +0100 (BST) From: Andrew Rybchenko To: Jerin Jacob , Liang Ma , "Peter Mccarthy" CC: , Dilshod Urazov , Date: Thu, 4 Jul 2019 11:03:32 +0100 Message-ID: <1562234612-631-4-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1562234612-631-1-git-send-email-arybchenko@solarflare.com> References: <1562234612-631-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24738.005 X-TM-AS-Result: No-7.383800-4.000000-10 X-TMASE-MatchedRID: p9rK+f8v5s+mnG2tP+vqUW6HurDH4PpP9teeW6UfkyB0+P0tQGP+S51b YL8THayD6eCSFghTVfiaYG6s7Uku2+O3C1C2ZcTlnFVnNmvv47tLXPA26IG0hN9RlPzeVuQQXmr nY1Xus+2HUUm9FGrCb3FypV9HM4SoCyoWuBSi9xXHmyDJSEsI2805KBm2/UMhmyiLZetSf8mfop 0ytGwvXiq2rl3dzGQ1HyQ+JiGcJ0z/ITeMF4QpX3OrmhMVxztXYGX7BITnTWCeD+VpjsfJ6Q== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--7.383800-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24738.005 X-MDID: 1562234645-IqDWJVzBYrnF Subject: [dpdk-dev] [PATCH 3/3] event/opdl: fix to set positive rte_errno X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Dilshod Urazov Fixes: 0bf298e39286 ("event/opdl: add event port config get/set") Fixes: 3c7f3dcfb099 ("event/opdl: add PMD main body and helper function") Fixes: 4236ce9bf5bf ("event/opdl: add OPDL ring infrastructure library") Cc: stable@dpdk.org Signed-off-by: Dilshod Urazov Signed-off-by: Andrew Rybchenko Reviewed-by: David Marchand --- drivers/event/opdl/opdl_evdev.c | 10 +++++----- drivers/event/opdl/opdl_evdev_init.c | 12 ++++++------ drivers/event/opdl/opdl_ring.c | 2 +- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_evdev.c index d2d2be4..3beca89 100644 --- a/drivers/event/opdl/opdl_evdev.c +++ b/drivers/event/opdl/opdl_evdev.c @@ -102,7 +102,7 @@ dev->data->dev_id, queues[0], p->id); - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } @@ -113,7 +113,7 @@ dev->data->dev_id, num, p->id); - rte_errno = -EDQUOT; + rte_errno = EDQUOT; return 0; } @@ -123,7 +123,7 @@ dev->data->dev_id, p->id, queues[0]); - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } @@ -134,7 +134,7 @@ p->id, p->external_qid, queues[0]); - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } @@ -160,7 +160,7 @@ dev->data->dev_id, queues[0], p->id); - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } RTE_SET_USED(nb_unlinks); diff --git a/drivers/event/opdl/opdl_evdev_init.c b/drivers/event/opdl/opdl_evdev_init.c index 582ad69..15aae47 100644 --- a/drivers/event/opdl/opdl_evdev_init.c +++ b/drivers/event/opdl/opdl_evdev_init.c @@ -35,7 +35,7 @@ p->id, ev[i].queue_id, p->next_external_qid); - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } } @@ -63,7 +63,7 @@ } else { if (num > 0 && ev[0].queue_id != p->next_external_qid) { - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } } @@ -116,7 +116,7 @@ RTE_SET_USED(ev); RTE_SET_USED(num); - rte_errno = -ENOSPC; + rte_errno = ENOSPC; return 0; } @@ -145,7 +145,7 @@ if (enqueued < num) - rte_errno = -ENOSPC; + rte_errno = ENOSPC; return enqueued; } @@ -164,7 +164,7 @@ RTE_SET_USED(ev); RTE_SET_USED(num); - rte_errno = -ENOSPC; + rte_errno = ENOSPC; return 0; } @@ -240,7 +240,7 @@ "Attempt to dequeue num of events larger than port (%d) max", opdl_pmd_dev_id(p->opdl), p->id); - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } diff --git a/drivers/event/opdl/opdl_ring.c b/drivers/event/opdl/opdl_ring.c index e988f1c..e8b29e2 100644 --- a/drivers/event/opdl/opdl_ring.c +++ b/drivers/event/opdl/opdl_ring.c @@ -756,7 +756,7 @@ struct opdl_ring { opdl_stage_disclaim(struct opdl_stage *s, uint32_t num_entries, bool block) { if (num_entries != s->num_event) { - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } if (s->threadsafe == false) {