From patchwork Fri Aug 2 02:51:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 57372 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C44531C1FD; Fri, 2 Aug 2019 04:52:07 +0200 (CEST) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 228121C1EF for ; Fri, 2 Aug 2019 04:52:03 +0200 (CEST) Received: by mail-pg1-f193.google.com with SMTP id f5so26455717pgu.5 for ; Thu, 01 Aug 2019 19:52:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QpFghJ/hgCGlIb7LGubFur6kOWcPQls5dJoD5tFeMlc=; b=t0AB3ceuduRotod1dPbJgFwmw1RGHhO8RS+zhB72LXc35FkB7vxVp/QINxHCTr661X bzxXnUqY57pFGC3B1VO4YCEhjoi3py93PgvpytAeJ+SHnl3doOoPKW3vTlIHaPwGCwxx t5eU6N4rwk7WejpsouRqDSUI8k1odSu6qwDLFRgUs72tLbH6xQcAkn2Y656sK/AJ5tsI bBE8E5HTjtKyPz7WcJupxYjG1hTb0faXjLYTxv51Dzx2ykDq6HBKb262wuZiluz58TuU aZI9fyitxwRLZWQLufHsEl5JIWWXhXd4LfbJneRjSZJMx4nTsjPFtlJm+z/YhCVixTkh NqYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QpFghJ/hgCGlIb7LGubFur6kOWcPQls5dJoD5tFeMlc=; b=OAe+b6dxwi95mV4gR/+L2xfWNbxiARW4ywY4JEH4F5UQ0Ng4R2LZQbMJqqBlG7ogZ9 lQblZmgDn14QtV9YfxXTRzmfUSOtSBPO50uraijfmWUMXV161zF23dFi/f3ueAtPL35z 2QEVAMQrch9ZuLZuvBkFcNoDZP+eZrNOpgeFQjKooRXNMX6M41XDcspsrFX9D9XprwvV 9V5Ib3xWA+sizG3KCSOjWpcEkOb7M1wSmZoh3fFz6wziXrh3Aja18o5DUJaHqKNxXCLz wXyiKhyfT0LoKXZguTVrG+N7GE4BVs7Ekf0kppccwxnxuzkN22uh3wC7vJ7ZhowYdA8R b9cg== X-Gm-Message-State: APjAAAX0jHahCn2Yi5hX959Pnf705HSZvUEPm/ThN8kyUcD5ebSqMZc3 z6yT1mlehjQcnxbx/Y+rQdObu9qH X-Google-Smtp-Source: APXvYqzIFvJXzxO0rEtDImJPcq/mwefwGR6luNA08Dz0pdjEFa6+l+9QKXww5w6gkfSLNQwilXH56A== X-Received: by 2002:a63:5402:: with SMTP id i2mr95045287pgb.414.1564714321945; Thu, 01 Aug 2019 19:52:01 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id s24sm73911995pfh.133.2019.08.01.19.52.01 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 01 Aug 2019 19:52:01 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Thu, 1 Aug 2019 19:51:52 -0700 Message-Id: <20190802025154.328-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190802025154.328-1-stephen@networkplumber.org> References: <20190802025154.328-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/3] testpmd: allow configuring log level on command line X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since testpmd registers log type after processing command line arguments, it is not possible to do: # testpmd --log-level='testpmd:info' ... Fix this by initializing logtype first. Signed-off-by: Stephen Hemminger --- app/test-pmd/testpmd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 518865a7db25..159c2ef05b6c 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3234,15 +3234,15 @@ main(int argc, char** argv) signal(SIGINT, signal_handler); signal(SIGTERM, signal_handler); - diag = rte_eal_init(argc, argv); - if (diag < 0) - rte_panic("Cannot init EAL\n"); - testpmd_logtype = rte_log_register("testpmd"); if (testpmd_logtype < 0) rte_panic("Cannot register log type"); rte_log_set_level(testpmd_logtype, RTE_LOG_DEBUG); + diag = rte_eal_init(argc, argv); + if (diag < 0) + rte_panic("Cannot init EAL\n"); + ret = register_eth_event_callback(); if (ret != 0) rte_panic("Cannot register for ethdev events"); From patchwork Fri Aug 2 02:51:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 57373 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 38E911C204; Fri, 2 Aug 2019 04:52:10 +0200 (CEST) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by dpdk.org (Postfix) with ESMTP id 778651C1ED for ; Fri, 2 Aug 2019 04:52:04 +0200 (CEST) Received: by mail-pf1-f179.google.com with SMTP id m30so35207777pff.8 for ; Thu, 01 Aug 2019 19:52:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QpCO5D5WJ6edy8yJuOwA4VXwhfKciwovvuTBGpYDeU0=; b=lSG2kb16yDPa/pKfwr8yqBaxloBYv3RUT6o9lMvSDBaV6pLGd42uUhEZZjKyj6hIPv nDF3GmMWvfGtcR6v1MySp/ob44CLy5/hk+SKbIupYmNyqcxk5Oh7Ml3NbOf7+lNT4rqw 126YUiQBQp9SsApv+jt7Mq4wrpg/NaUCArx5DNTLfbPa685Tm1UqUOTHZoewjCoFJMY8 UQOAbhBv09CXqCzqJnVskmO5fBG/wP6H5+yb73KvizYCVTGqrxU7bKXo362A7d7rZ0KE d8gCUVkj1LBn2j91uJmQMMTopC1jjJvyHz3HEWtBG4/MZfz+nvNC9AVnjHxB+jogedOV Dr/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QpCO5D5WJ6edy8yJuOwA4VXwhfKciwovvuTBGpYDeU0=; b=MTeCH9mucUaWvtv+IChHAZZr3oaJAjUc+xmjYzsInuEYF0azdN/4JvlhuvrU9yXjH4 jCNfSx6s/r/05j4FlNkr1BhnLIMnNXwBAJH+hwtQslsAqPTLtREXAgId5rexGc3X9HM6 1Um3pJgdk37lH2Ee8mJHQGidv9Z+6LkeqDs9UbQCDDKsPGPUN/McfIMvZkorTBatm1wB 1pklSmIWgEzDpc0OfM1OOtEtGdk7Xir+NCvpuMc0KBecOiLPsyY3dtI0s+KQ42hZWW+a FollhFS4sfeXG2udTbgLuNmHDSKecfViU1nwh+Lwab7y8HQvalNXSNbIp25ueCZsqFlY xgpQ== X-Gm-Message-State: APjAAAW72eU027S+AgD4jWIgpCo+f6xLt5/eoKjWLcWIFcsxieZK+BH9 ReHyLjN86bYSbMqk3SxGbxXa7hTX X-Google-Smtp-Source: APXvYqxCWoAJYyQEF9xZ2Byk9e8NfWh89t/G3oeMwgPVaYZsRKnIBvc5WnEXqsDIyqhIOZFLB8Sffg== X-Received: by 2002:a63:1341:: with SMTP id 1mr14594036pgt.48.1564714323175; Thu, 01 Aug 2019 19:52:03 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id s24sm73911995pfh.133.2019.08.01.19.52.02 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 01 Aug 2019 19:52:02 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Thu, 1 Aug 2019 19:51:53 -0700 Message-Id: <20190802025154.328-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190802025154.328-1-stephen@networkplumber.org> References: <20190802025154.328-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 2/3] testpmd: block secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since testpmd has several issues which keep it from working correctly as a secondary process; abort if user tries to do it, rather than running into later problems. Signed-off-by: Stephen Hemminger --- app/test-pmd/testpmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 159c2ef05b6c..d0142cae68d7 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3243,6 +3243,9 @@ main(int argc, char** argv) if (diag < 0) rte_panic("Cannot init EAL\n"); + if (rte_eal_process_type() == RTE_PROC_SECONDARY) + rte_panic("Secondary process type not supported.\n"); + ret = register_eth_event_callback(); if (ret != 0) rte_panic("Cannot register for ethdev events"); From patchwork Fri Aug 2 02:51:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 57374 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 753FC1C20B; Fri, 2 Aug 2019 04:52:12 +0200 (CEST) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id C118A1C1FB for ; Fri, 2 Aug 2019 04:52:05 +0200 (CEST) Received: by mail-pg1-f193.google.com with SMTP id k189so16228955pgk.13 for ; Thu, 01 Aug 2019 19:52:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DyCOaXXLJ5xS3y4c0vquyJVQrHurp2Jx8KDuemTGIYs=; b=jEj3xNbKleKKIQD5y9Sj+/nI6GiiGA8tJmw1nKx5P8FcOATNpH1OxKccGdYJ+cZLhB XtdeqEaHHkKcaUhMtQonBrnc3Z/brIFRat3qbD5TuTjWm7GbboCsPLZ2jdaVWZ9Kv/Ly 0SvP6U9NL394YuqCECNWn+8m3lSa7JTbIifSj9uinlOY+3Iy3BwZHW4C5AGaamM9h0YH YDGHaNuJIBsKCRTOrERpGt7I3ePx4PW1VMK9L7Y75V312SStlEyfiWVbJuxdnwXO8INj QMoD/+O+Mi+7b/1GmAZZxws7pfYyXTneauU6nsUrq4+l6cWcL38WU+xTPffU9iyqJuQV mg7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DyCOaXXLJ5xS3y4c0vquyJVQrHurp2Jx8KDuemTGIYs=; b=Sj5qUT9070JWDO1a39zRbA2Tu/v5qqhaAB4sI/pFt8dTWaj3KohNWWjETFo7B7CzHv zIQNuN3cCXR3vFSAx5lUV3GsHPeaxcQQYUvu6U7CVJvjNyg19v7L/WikwkcDDgKkfGDV /mynj81CR9xV5S6pEvr1wPNMxR6XdUaSAdc19VfMrLyYhjAEfrLsNGTHfn9YyeGghOEN 1QI53+2ArVBcRcUBBJRBg4wPLPV0z6JNKwIt9kJS4Gtjq2JhmnU8THKJu8iPRUNAegdo CPrjA0pz6IfQRdLN7CHQdHmuyqWl8evPegOPVnWjnlxvPFZbXHDlOimvDN5OSyux8/WM ypfg== X-Gm-Message-State: APjAAAUMG9iKJefX4/4s/ODaol8mVNfU16lINNNpfdIJGObi8MFkDDuh +mEpO/kN2/9YXkedOen1ruP9lrw2 X-Google-Smtp-Source: APXvYqzotU7k5z9x3bpOOSa2u3WdBv+iwHIa4tZozL+3shaTahtU268YbPgtdpebqasiKtdHQ/OCkQ== X-Received: by 2002:a63:5048:: with SMTP id q8mr120488591pgl.446.1564714324490; Thu, 01 Aug 2019 19:52:04 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id s24sm73911995pfh.133.2019.08.01.19.52.03 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 01 Aug 2019 19:52:03 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Thu, 1 Aug 2019 19:51:54 -0700 Message-Id: <20190802025154.328-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190802025154.328-1-stephen@networkplumber.org> References: <20190802025154.328-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 3/3] testpmd: use exit instead of panic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_panic causes a backtrace (which is uniformative since all these calls are in main). Instead use rte_exit and try and make the messages informative. Signed-off-by: Stephen Hemminger Reviewed-by: Anatoly Burakov --- app/test-pmd/testpmd.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index d0142cae68d7..a461cef188e3 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3236,19 +3236,21 @@ main(int argc, char** argv) testpmd_logtype = rte_log_register("testpmd"); if (testpmd_logtype < 0) - rte_panic("Cannot register log type"); + rte_exit(EXIT_FAILURE, "Cannot register log type"); rte_log_set_level(testpmd_logtype, RTE_LOG_DEBUG); diag = rte_eal_init(argc, argv); if (diag < 0) - rte_panic("Cannot init EAL\n"); + rte_exit(EXIT_FAILURE, "Cannot init EAL: %s\n", + rte_strerror(rte_errno)); if (rte_eal_process_type() == RTE_PROC_SECONDARY) - rte_panic("Secondary process type not supported.\n"); + rte_exit(EXIT_FAILURE, + "Secondary process type not supported.\n"); ret = register_eth_event_callback(); if (ret != 0) - rte_panic("Cannot register for ethdev events"); + rte_exit(EXIT_FAILURE, "Cannot register for ethdev events"); #ifdef RTE_LIBRTE_PDUMP /* initialize packet capture framework */ @@ -3269,8 +3271,8 @@ main(int argc, char** argv) set_def_fwd_config(); if (nb_lcores == 0) - rte_panic("Empty set of forwarding logical cores - check the " - "core mask supplied in the command parameters\n"); + rte_exit(EXIT_FAILURE, "No cores defined for forwarding\n" + "Check the core mask argument\n"); /* Bitrate/latency stats disabled by default */ #ifdef RTE_LIBRTE_BITRATE