From patchwork Fri Sep 6 10:49:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 58832 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B03D1F288; Fri, 6 Sep 2019 12:50:23 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id C636E1F173; Fri, 6 Sep 2019 12:50:21 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 6DE53A40058; Fri, 6 Sep 2019 10:50:20 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 6 Sep 2019 03:50:17 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Fri, 6 Sep 2019 03:50:15 -0700 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id x86AoFjB007668; Fri, 6 Sep 2019 11:50:15 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 0A6CF1613D1; Fri, 6 Sep 2019 11:50:15 +0100 (BST) From: Andrew Rybchenko To: CC: Date: Fri, 6 Sep 2019 11:49:49 +0100 Message-ID: <1567766989-25918-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24892.005 X-TM-AS-Result: No-1.360100-4.000000-10 X-TMASE-MatchedRID: B8PsQTrLt2SRpSeUCslIgrsHVDDM5xAPHem4B9zINcljLp8Cm8vwF1Me 5Blkpry7rdoLblq9S5p1WMYsMQ0A8ddsyStrXg4QnMQdNQ64xfe2OhiJvBzMLSS30GKAkBxWWbA 8i7TsQRLi8zVgXoAltmHJPdY2OmlS0C1sQRfQzEHEQdG7H66TyJ8TMnmE+d0ZaNbEww2Avjs5Jo ymv+pCn6aiwsA/964flDV0+USta5KLzU4H/OD5ND/8cQh+e9oA3aeR5/3P0Tf8qQ05hs2l5Bo6h LCA1I5ck3UkV5Qp4wSI45Rd9ORJwFlJvEhEss3fvN+d4ahMo5NWXGvUUmKP2w== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--1.360100-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24892.005 X-MDID: 1567767021-uzn-t2xQugbr Subject: [dpdk-dev] [PATCH] net/sfc: fix missing notification on link status change X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_eth_linkstatus_set() returns 0 when link up status changes. Fixes: 4abe903e5078 ("net/sfc: use link status helper functions") Cc: stable@dpdk.org Reported-by: Shuki Katzenelson Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_ev.c b/drivers/net/sfc/sfc_ev.c index 0f216da5d9..6a58a2d975 100644 --- a/drivers/net/sfc/sfc_ev.c +++ b/drivers/net/sfc/sfc_ev.c @@ -420,7 +420,7 @@ sfc_ev_link_change(void *arg, efx_link_mode_t link_mode) struct rte_eth_link new_link; sfc_port_link_mode_to_info(link_mode, &new_link); - if (rte_eth_linkstatus_set(sa->eth_dev, &new_link)) + if (rte_eth_linkstatus_set(sa->eth_dev, &new_link) == 0) evq->sa->port.lsc_seq++; return B_FALSE;