From patchwork Mon Nov 11 13:21:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anoob Joseph X-Patchwork-Id: 62844 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6A71A04B9; Mon, 11 Nov 2019 14:21:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C190EB62; Mon, 11 Nov 2019 14:21:42 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 79F581F5 for ; Mon, 11 Nov 2019 14:21:40 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xABDFdmU001176; Mon, 11 Nov 2019 05:21:39 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0818; bh=2We4YbNdekgY01N+A+vKg5RBIepMJua/66YPlOlOf78=; b=hdnmL/vnPsNrhfJor6CdUAl72rdw6FqDvVgyH8Ej0z27zueenLPWQzFIdbD20MekFqUB zLniOdyyM80c7bMxmJNclTAlEzIEo0qnJ7j4P+DsP6iNj/QPZ4Dmm3jm7nBlPGRkOxUu BDVLBLzqB1DBd8fxYejRBBBGG6pCzTGfvM3RQDgORYFPHCIfTJCvQH8dIyBIEAVMFYnl v+Gtxa0qSd1CYDtTBYNtB8PcJMwXhAkzw++h5M/DLBqPyOraw9cQULXJod2KbmarkupP 6t8YARBntieySlDD7LAdwEfP7EPS36hszxOmYlUKyivGxW+RHN94mVaZoNgIBp/JFgF7 Fg== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2w5upuxvj3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 11 Nov 2019 05:21:39 -0800 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 11 Nov 2019 05:21:38 -0800 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Mon, 11 Nov 2019 05:21:38 -0800 Received: from ajoseph83.caveonetworks.com.com (unknown [10.29.45.60]) by maili.marvell.com (Postfix) with ESMTP id A6DD43F703F; Mon, 11 Nov 2019 05:21:35 -0800 (PST) From: Anoob Joseph To: Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K CC: Anoob Joseph , Ferruh Yigit , Andrew Rybchenko , Narayana Prasad , Date: Mon, 11 Nov 2019 18:51:14 +0530 Message-ID: <1573478474-17984-1-git-send-email-anoobj@marvell.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-11-11_03:2019-11-11,2019-11-11 signatures=0 Subject: [dpdk-dev] [PATCH] net/octeontx2: fix exit paths after cq init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" After otx2_nix_register_cq_irqs() is called and the IRQs are setup, otx2_nix_unregister_cq_irqs() need to be called in the subsequent error exit paths. Fixes: d34db5ccbf30 ("net/octeontx2: fix driver reconfiguration") Signed-off-by: Anoob Joseph Acked-by: Jerin Jacob --- drivers/net/octeontx2/otx2_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c index aab34db..18aa0f5 100644 --- a/drivers/net/octeontx2/otx2_ethdev.c +++ b/drivers/net/octeontx2/otx2_ethdev.c @@ -1700,13 +1700,13 @@ otx2_nix_configure(struct rte_eth_dev *eth_dev) rc = cgx_intlbk_enable(dev, eth_dev->data->dev_conf.lpbk_mode); if (rc) { otx2_err("Failed to configure cgx loop back mode rc=%d", rc); - goto q_irq_fini; + goto cq_fini; } rc = otx2_nix_rxchan_bpid_cfg(eth_dev, true); if (rc) { otx2_err("Failed to configure nix rx chan bpid cfg rc=%d", rc); - goto q_irq_fini; + goto cq_fini; } rc = otx2_nix_mc_addr_list_install(eth_dev);