From patchwork Tue Nov 19 12:12:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 63109 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB419A04B4; Tue, 19 Nov 2019 13:12:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ADCAFCF3; Tue, 19 Nov 2019 13:12:42 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 55C66271 for ; Tue, 19 Nov 2019 13:12:39 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 93904100077; Tue, 19 Nov 2019 12:12:37 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 19 Nov 2019 04:12:35 -0800 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Tue, 19 Nov 2019 04:12:34 -0800 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id xAJCCXTi015155; Tue, 19 Nov 2019 12:12:33 GMT Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 76BA5161648; Tue, 19 Nov 2019 12:12:33 +0000 (GMT) From: Andrew Rybchenko To: Thomas Monjalon , Ferruh Yigit , Pavan Nikhilesh , "Neil Horman" , John McNamara , Marko Kovacevic CC: Date: Tue, 19 Nov 2019 12:12:14 +0000 Message-ID: <1574165536-2586-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1574165145-23960-1-git-send-email-arybchenko@solarflare.com> References: <1574165145-23960-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-25050.005 X-TM-AS-Result: No-5.231400-4.000000-10 X-TMASE-MatchedRID: RoGFAXAsZ+BWUdWZNc/zWRIRh9wkXSlFJih/yo+OvlWRoQLwUmtovxxS cgjK3TZJ35oRU0iC50SPQi9XuOWoOKerivEziUtxcI7vRACwF0IGchEhVwJY3ygVbxW7FDOVNH2 M+0Uex9zMXMCgAgCo/gGgqRQZQsCiVHa5Ax0DhIiEv01fZOqaQLx2voUbwFB95kCVFHoAgnuSDd w9v34fhDa+bWYqf1uAU2yoXteGi/121zBthUokNZixDyZ4rnsHfS0Ip2eEHnz3IzXlXlpamPoLR 4+zsDTtLa13Fo3TPRYYQblXyWS6BwfafHqawJzmuVhzwgNj6+BR/RgxK4o8nFZca9RSYo/b X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.231400-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-25050.005 X-MDID: 1574165558-CmO0amI5igv1 Subject: [dpdk-dev] [PATCH v2 1/3] ethdev: remove deprecation notice for packet type set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The functionality is added, but the deprecation notice is not removed. Fixes: 5d4813acda2c ("ethdev: add packet type range function") Signed-off-by: Andrew Rybchenko Acked-by: Ferruh Yigit --- v2: - none doc/guides/rel_notes/deprecation.rst | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index f545801f6d..65076acb13 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -68,21 +68,6 @@ Deprecation Notices In 19.11 PMDs will still update the fields even when the offloads are not enabled. -* ethdev: New function ``rte_eth_dev_set_supported_ptypes`` will be added in - 19.11. - This will allow application to request PMD to set specific ptypes defined - through ``rte_eth_dev_set_supported_ptypes`` in ``rte_mbuf::packet_type``. - If application doesn't want any ptype information it can call - ``rte_eth_dev_set_supported_ptypes(ethdev_id, RTE_PTYPE_UNKNOWN)`` and PMD - will set ``rte_mbuf::packet_type`` to ``0``. - If application doesn't call ``rte_eth_dev_set_supported_ptypes`` PMD can - return ``rte_mbuf::packet_type`` with ``rte_eth_dev_get_supported_ptypes``. - If application is interested only in L2/L3 layer, it can inform the PMD - to update ``rte_mbuf::packet_type`` with L2/L3 ptype by calling - ``rte_eth_dev_set_supported_ptypes(ethdev_id, RTE_PTYPE_L2_MASK | RTE_PTYPE_L3_MASK)``. - This scheme will allow PMDs to avoid lookup to internal ptype table on Rx and - thereby improve Rx performance if application wishes do so. - * cryptodev: support for using IV with all sizes is added, J0 still can be used but only when IV length in following structs ``rte_crypto_auth_xform``, ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equal From patchwork Tue Nov 19 12:12:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 63108 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57900A04B4; Tue, 19 Nov 2019 13:12:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CB225271; Tue, 19 Nov 2019 13:12:40 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 51C02237 for ; Tue, 19 Nov 2019 13:12:39 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 1FFC2100059; Tue, 19 Nov 2019 12:12:38 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 19 Nov 2019 04:12:35 -0800 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Tue, 19 Nov 2019 04:12:34 -0800 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id xAJCCXWc015159; Tue, 19 Nov 2019 12:12:33 GMT Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id B856D161648; Tue, 19 Nov 2019 12:12:33 +0000 (GMT) From: Andrew Rybchenko To: Thomas Monjalon , Ferruh Yigit , Pavan Nikhilesh , "Neil Horman" , John McNamara , Marko Kovacevic CC: Date: Tue, 19 Nov 2019 12:12:15 +0000 Message-ID: <1574165536-2586-2-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1574165536-2586-1-git-send-email-arybchenko@solarflare.com> References: <1574165145-23960-1-git-send-email-arybchenko@solarflare.com> <1574165536-2586-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-25050.005 X-TM-AS-Result: No-0.484600-4.000000-10 X-TMASE-MatchedRID: nGM1jKVnzf5yT9UFBBwsEokvHinQ/+7kMVx/3ZYby78ZwGrh4y4izBkh PVvMB7dGA9KvxXqF/7nAm4BsdHOth5xBJWVIsdLqA9lly13c/gGIjpcCkaLYxuE1pYoXZydBkSM wPmntMVwCQ+noxLcPebRMvXAdd3BVajCF67OIrSqOjIrMSa2sRw/o5bNHEsCTSMg2Oe/b8Ezus/ QM9P83V5yM89otn92zWHJH5Nrd3oh7rjItHwarhZXi1z8zt1TRfS0Ip2eEHnz3IzXlXlpamPoLR 4+zsDTtStBGwEBjie6h7oq8EOmq4SbhWjzr65RGVE0lWNS4gbILUw5WC3locIgaevvZ/QcIAekZ 1pNl583DWxHgmUWyzrkgNNiBIPQUVjoiXXpYtLHaQLtLC8aUqEPBvsmCWGHWUWQ7Bol0IqC+I8S pxyUS3O53VB1DJl7uftwZ3X11IV0= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10-0.484600-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-25050.005 X-MDID: 1574165558-NZsc39hK9_e6 Subject: [dpdk-dev] [PATCH v2 2/3] ethdev: remove deprecation notice about RSS hash offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The offload was added, but the deprecation notice was not removed. Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload") Signed-off-by: Andrew Rybchenko Acked-by: Ferruh Yigit --- v2: - 'offloads are' -> 'offload is' in the last sentence doc/guides/rel_notes/deprecation.rst | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 65076acb13..afa94b43e2 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -59,13 +59,12 @@ Deprecation Notices - ``rte_eth_dev_stop`` - ``rte_eth_dev_close`` -* ethdev: New offload flags ``DEV_RX_OFFLOAD_RSS_HASH`` and - ``DEV_RX_OFFLOAD_FLOW_MARK`` will be added in 19.11. +* ethdev: New offload flags ``DEV_RX_OFFLOAD_FLOW_MARK`` will be added in 19.11. This will allow application to enable or disable PMDs from updating - ``rte_mbuf::hash::rss`` and ``rte_mbuf::hash::fdir`` respectively. + ``rte_mbuf::hash::fdir``. This scheme will allow PMDs to avoid writes to ``rte_mbuf`` fields on Rx and thereby improve Rx performance if application wishes do so. - In 19.11 PMDs will still update the fields even when the offloads are not + In 19.11 PMDs will still update the field even when the offload is not enabled. * cryptodev: support for using IV with all sizes is added, J0 still can From patchwork Tue Nov 19 12:12:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 63110 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA84CA04B4; Tue, 19 Nov 2019 13:12:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3548C2BA2; Tue, 19 Nov 2019 13:12:44 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 67D6D27D for ; Tue, 19 Nov 2019 13:12:39 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 3483810005E; Tue, 19 Nov 2019 12:12:38 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 19 Nov 2019 04:12:35 -0800 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Tue, 19 Nov 2019 04:12:35 -0800 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id xAJCCYBP015163; Tue, 19 Nov 2019 12:12:34 GMT Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 0EB8D161648; Tue, 19 Nov 2019 12:12:34 +0000 (GMT) From: Andrew Rybchenko To: Thomas Monjalon , Ferruh Yigit , Pavan Nikhilesh , "Neil Horman" , John McNamara , Marko Kovacevic CC: Date: Tue, 19 Nov 2019 12:12:16 +0000 Message-ID: <1574165536-2586-3-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1574165536-2586-1-git-send-email-arybchenko@solarflare.com> References: <1574165145-23960-1-git-send-email-arybchenko@solarflare.com> <1574165536-2586-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-25050.005 X-TM-AS-Result: No-3.922900-4.000000-10 X-TMASE-MatchedRID: lnsQrTwpx4mtRp+fZJPWMB23b+lJHvPAa2pCAnJvQFFpsnGGIgWMmRGG Vq+vrXC0yOQ1BalexnpmAlyyODjbizM9BBRuZZ1vw9GVhGa/57ZLXPA26IG0hN9RlPzeVuQQ3AE qvnWPfyoP8SQMpzefdj/DjswrOXnL0X+0CFhNLNewWQIt5658217OZ6hrwwnzx6C6dcifNxg56G dZxUF9VgWNb8PrNCkEoSQlxmAAlGi24cRwPAxMJ/KUR83BvqItKVrLOZD1BXRPvOpmjDN2koAM/ 6b/EGCGGEXSzEniJe2AMuqetGVetnyef22ep6XYro1URZJFbJvJFBtSVk8OK1VQZnXRINfAXDdd p2ki3OsXzpvYsvSqaCrwQIqKa619mcz8ZQvd/odsZb+lQSg42/fsvSYgh9mVokncHxNFQOnw7Jx wU0EvZMqEROLb/+yO4/0Jvn0rwAJmtL4Dw+zNb0D/MIf9Orkd X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10-3.922900-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-25050.005 X-MDID: 1574165558-4EeWFIUervYe Subject: [dpdk-dev] [PATCH v2 3/3] ethdev: improve flow mark Rx offload deprecation notice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The deprecation notice is required since it adds more requirements when RTE flow mark and flag actions may be used and require changes in applications. Signed-off-by: Andrew Rybchenko --- v2: - rebase after changes in the previous patch doc/guides/rel_notes/deprecation.rst | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index afa94b43e2..7060a6a0d0 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -59,13 +59,13 @@ Deprecation Notices - ``rte_eth_dev_stop`` - ``rte_eth_dev_close`` -* ethdev: New offload flags ``DEV_RX_OFFLOAD_FLOW_MARK`` will be added in 19.11. - This will allow application to enable or disable PMDs from updating - ``rte_mbuf::hash::fdir``. - This scheme will allow PMDs to avoid writes to ``rte_mbuf`` fields on Rx and - thereby improve Rx performance if application wishes do so. - In 19.11 PMDs will still update the field even when the offload is not - enabled. +* ethdev: New offload flag ``DEV_RX_OFFLOAD_FLOW_MARK`` will be added in 20.02. + This will provide application an information if ``RTE_FLOW_ACTION_TYPE_MARK`` + or ``RTE_FLOW_ACTION_TYPE_FLAG`` is supported and, what is more important, + allow an application to let PMD know that it would like to use these + features. + PMD may use the information to choose optimal datapath implementation and + configure HW appropriately to optimize performance and/or resources usage. * cryptodev: support for using IV with all sizes is added, J0 still can be used but only when IV length in following structs ``rte_crypto_auth_xform``,